From patchwork Wed Jul 21 21:19:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Taylor Simpson X-Patchwork-Id: 483346 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp6570828jao; Wed, 21 Jul 2021 14:21:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/unEwwwpNqwypDhHdwsHwiLv2VrTnHlDA5GvMjZsEdf7mUQw8pWph8v6gqy0tcaaLrPVf X-Received: by 2002:a25:ad95:: with SMTP id z21mr48337113ybi.25.1626902468005; Wed, 21 Jul 2021 14:21:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626902468; cv=none; d=google.com; s=arc-20160816; b=CmZV62Rw4F+n9lbWP1WLCg18NNELONFppld0JSdtcegoCdPMTNiNyI+SdxixpzUzze yIAAFVhO37IJZqIfh27t2umdv83wwL4gRFnt7b0YhtuDTQTDr0qbIE0+phHI/SooH285 x0WfuXtHsB4NK3pkO4J0aqbfYepj0cIv5PfLZB0neHVIHomJtrX8zrYCaNbXSLaRnDp2 3EJDkEc2rK2vi925XnU1mC/o1n0uRpPWD+skT3Ru20oMeoZwLyuQlMV6K6AxI8XfNYGT EaqcajdZxo7D65MJHAluF2F27SgaOHnYBNQV6QPmEvQ8Dq6WN1tO+MBTAcZi3j04tRrc 4L6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ce/ncbFel0kDoOofyeNEWzeZGTOA4D5+bW1/RX/ZavM=; b=k1C1U4AZpJTGMvxyYaLkVvvYkE1lmYup55ei8Bn0zvhwqw0WnFCSs+aNMLjoMNoCaV 5NOc9tSARTxE30kDdCF4efWhDJZMpUAGwBJ09OPgqS8ciVlQBBem3Jdxc5z40x+PLsVx 1zOPGT367ag1oWAqJG4+bQXtMf5uAHudOgvvpu9FFnN3DD371Jru3+CoRvQsYJOwyg8L ebd2Y7fwXxf/nLaxVT1xN0IIazQSCXjklylnl2y23htIU+9jCT51Nh4+jRAj039vCzwd 0iFdJAKxdiBfHbPx5FCjVIEETgK5Sb4grahNH4x599GlUw9hQ3ArnlZLKIBKJzR6PNUu BnAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=uVZJJnQP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d134si1000677ybc.27.2021.07.21.14.21.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Jul 2021 14:21:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=uVZJJnQP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from localhost ([::1]:47064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6JeN-0004sw-Dd for patch@linaro.org; Wed, 21 Jul 2021 17:21:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6JdJ-0004n5-S1 for qemu-devel@nongnu.org; Wed, 21 Jul 2021 17:20:01 -0400 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:23035) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1m6JdI-0001IN-6S for qemu-devel@nongnu.org; Wed, 21 Jul 2021 17:20:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1626902400; x=1658438400; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ce/ncbFel0kDoOofyeNEWzeZGTOA4D5+bW1/RX/ZavM=; b=uVZJJnQPAkPlYPnAbYPM+piHPuI86HUmmLuehdKoRS91H1a3W5Yr9QHb kNxpdI2VZKmHGgqLSyriBwfUYmvzkbxsVwUmVr7Z9/XY3017ySRQAHH4i c+NrMtwdMNscpIdhnTivHklTQ5d2DD6+6ghKLKFOifxdOBqFF4YH67bC3 w=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-01.qualcomm.com with ESMTP; 21 Jul 2021 14:19:53 -0700 X-QCInternal: smtphost Received: from vu-tsimpson-aus.qualcomm.com (HELO vu-tsimpson1-aus.qualcomm.com) ([10.222.150.1]) by ironmsg03-sd.qualcomm.com with ESMTP; 21 Jul 2021 14:19:51 -0700 Received: by vu-tsimpson1-aus.qualcomm.com (Postfix, from userid 47164) id B226F1191; Wed, 21 Jul 2021 16:19:51 -0500 (CDT) From: Taylor Simpson To: qemu-devel@nongnu.org Subject: [PULL 2/3] target/hexagon: Drop include of qemu.h Date: Wed, 21 Jul 2021 16:19:34 -0500 Message-Id: <1626902375-7002-3-git-send-email-tsimpson@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1626902375-7002-1-git-send-email-tsimpson@quicinc.com> References: <1626902375-7002-1-git-send-email-tsimpson@quicinc.com> MIME-Version: 1.0 Received-SPF: pass client-ip=199.106.114.38; envelope-from=tsimpson@qualcomm.com; helo=alexa-out-sd-01.qualcomm.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, peter.maydell@linaro.org, bcain@quicinc.com, richard.henderson@linaro.org, tsimpson@quicinc.com, philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on the include path for softmmu builds. Currently we include it unconditionally in target/hexagon/op_helper.c. We used to need it for the put_user_*() and get_user_*() functions, but now that we have removed the uses of those from op_helper.c, the only reason it's still there is that we're implicitly relying on it pulling in some other headers. Explicitly include the headers we need for other functions, and drop the include of qemu.h. Signed-off-by: Peter Maydell Message-Id: <20210717103017.20491-1-peter.maydell@linaro.org> Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson Signed-off-by: Taylor Simpson --- target/hexagon/op_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index a959dba..61d5cde 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -16,7 +16,8 @@ */ #include "qemu/osdep.h" -#include "qemu.h" +#include "qemu/log.h" +#include "exec/exec-all.h" #include "exec/cpu_ldst.h" #include "exec/helper-proto.h" #include "fpu/softfloat.h"