From patchwork Tue Sep 11 11:13:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 146436 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp3512920ljw; Tue, 11 Sep 2018 04:13:12 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaaH9GR7M5fibSO9Iz8NG2VjrUB+8tz5jiVTj0ocWBy/tm6E7z1igQIf/9QJZCPEYXxarmO X-Received: by 2002:a5d:6451:: with SMTP id d17-v6mr17026111wrw.64.1536664392456; Tue, 11 Sep 2018 04:13:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536664392; cv=none; d=google.com; s=arc-20160816; b=H8NFwgJVRY47i8RktBv0UD0aeWImJVnmCHZR3nG4VkzwlAHHcOAWvQi8mkqWcM4AW8 7mzvHzLBmiFrpxDp9wzQ80fm5xv5lR1fYxPv4iMbxeTxqWzMw10OvMRRq3vFYlDKunoc RdlFkkmBMMPQqseYA+2oEOy25m9CXBNNEjkMICZE0+GF3Gi0Hq1l0pK8R1LvL5oZ5DwA 6CKN9rbvoxaQttar5zzr0c45jiqupGgMnjX+c5sBpVZrbfRsUtYXLxcuk5tSz9RGqHL8 OQd1Jk0A8VoqRPiBVFo4za/URjH2wBV/m0gc4oL7wZrNg5euSfDpNvVHUV+D+mWMG9aX cO9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to; bh=RD2Me6//1P6ikQssHkECUdYZ1BdlOOMkfU1pinI0FfQ=; b=a0nNggSh5QOgMswfd0HG/fiUzgZEepc5GYA6RJTzKDDpuWYea7wpPQPPNPBctIiGuF N/lvJOOW94JxLrK07Tk0dUvBm6STiV9dkQpRcx01QXcIyNdQgHJBzGezGNur7SLQ3GNp h0F/NY/93Mi1pKqW6EYkuGfgVO9h2EgZxYZhB1xn/XQc6IRAd+fuxD/0MVwaEu4PfwmB GLlm4p9c8cWo49MBHNgSTS+UkAgpTmMXnlgcA/OAG3zD3oIQX+O42sLkIWH77nyw9+XH UJp+DUdFmMxS0nFCnlBMm/bR2Cprbxe3S3j/b0P2skTMO6Da4iDQCHfqIZnXuOsIvAV+ uh6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="rlJbX/J7"; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id l1-v6si18025034wre.114.2018.09.11.04.13.12; Tue, 11 Sep 2018 04:13:12 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="rlJbX/J7"; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 442AF267821; Tue, 11 Sep 2018 13:13:11 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1FB8D26784A; Tue, 11 Sep 2018 13:13:09 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id CC8B6267795 for ; Tue, 11 Sep 2018 13:13:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=MkpsRaaEPgz6hQ5VLNLzZLei4j1ZmtSg2ql0yEc/UPs=; b=rlJbX/J7ojzZ qX/onLqCkzukvxsJCAoTSRb72URbMO4GEmMQ1W4d4IAtVVQGprF83FP9AJH06jV63IRzQagBONxIB s+Uf37sIV5hBJWEHZ5fJf5tnZ89uSXoxWLC5V2dFdXkhs2fNE9JVoSmPAXhPsrcXeMTESFweHQX4K BkXbQ=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fzgbQ-0004ku-Ru; Tue, 11 Sep 2018 11:13:04 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 909341121AF8; Tue, 11 Sep 2018 12:13:04 +0100 (BST) From: Mark Brown To: zhong jiang In-Reply-To: Message-Id: <20180911111304.909341121AF8@debutante.sirena.org.uk> Date: Tue, 11 Sep 2018 12:13:04 +0100 (BST) Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: skl-topology: Use kmemdup to replace kzalloc + memcpy" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: skl-topology: Use kmemdup to replace kzalloc + memcpy has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From ca92cc4636fdedf0d7ee88a5e50cd2b85c246a3b Mon Sep 17 00:00:00 2001 From: zhong jiang Date: Sat, 8 Sep 2018 16:36:20 +0800 Subject: [PATCH] ASoC: skl-topology: Use kmemdup to replace kzalloc + memcpy kmemdup has implemented the function that kzalloc() + memcpy() will do. and we prefer to kmemdup rather than the open coded implementation. Signed-off-by: zhong jiang Signed-off-by: Mark Brown --- sound/soc/intel/skylake/skl-topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.19.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 2620d77729c5..52a9915da0f5 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -898,11 +898,10 @@ static int skl_tplg_set_module_bind_params(struct snd_soc_dapm_widget *w, bc = (struct skl_algo_data *)sb->dobj.private; if (bc->set_params == SKL_PARAM_BIND) { - params = kzalloc(bc->max, GFP_KERNEL); + params = kmemdup(bc->params, bc->max, GFP_KERNEL); if (!params) return -ENOMEM; - memcpy(params, bc->params, bc->max); skl_fill_sink_instance_id(ctx, params, bc->max, mconfig);