From patchwork Tue Sep 11 11:15:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 146437 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp3514698ljw; Tue, 11 Sep 2018 04:15:08 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYYkPEtnCVVRyTrqpD6m31CW5hgtbnVqD6+u8o/Oj3QC/vLqN7L245VQE7bX7SjVssngU4Q X-Received: by 2002:a1c:c44a:: with SMTP id u71-v6mr1053754wmf.43.1536664508820; Tue, 11 Sep 2018 04:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536664508; cv=none; d=google.com; s=arc-20160816; b=a2U8+BBSF0yLtlh0e8gkqy62h+uLJBuEL4LK7o36dWvCN+mrq1bL+dgI2gZuDQbmGb mnC2hXf4FwSfPhDZlS6EkVNsajrnLy0LXZvB2u1bj4+kqp8NEDGqz3mQMnB7nDg9FW1U tnOXGrrGUZLDn3luwBK4sPj8l0kr3XTzTYatGvMQQtboW2oSMUJ7UFs9fku7E1OX5F/C MJIWVibKyK1EfflDv24CX/3991H1A+Z2V0a5Y2O4ZDxQ1TBRkr7TYmPErzwqfnA7p0mm 6iUuuo1dgQBr38mWKrH3Q7I574Y9BG0WwFSpOipXEk62+RNVRRN6Bp+fcYlFGJviFXWL HFow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to; bh=MMqBGydqwKYmvLSyd76ZTGTv/0al6Z1WTxIrO6K9cKM=; b=OpeT8EcXqYD0Ok52G0TLJf31rIXdfF49tU+P3EZBqgucOGj9gu+a4SKqNzh6eAnmEP AlFRcQzTDcbousa/hPizzvBJRTfekKNnyAc4vQFXaWHYWLJBxxd+hBbszYSvGBEqTOnj ICOyDWQvGq35T2vqCZKIHXx/KsLrotET5geZmrM8c9MsDIzYb7o3XESVvN5P4hfViU9o Pvq2/4veSiOB/JCXvtnQR5KFb134MpRt0v2jz8v4H/I7cSERTIyutcab4dZLereWRTz6 okmv1AezDzZ9B/hM8YoqZ/yPmpQ1IR9//Rcqp+PRdwQubqnILH4ZY9LsbZgpiO17hMtr uuCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=nbU66iSI; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id n17-v6si19406423wri.54.2018.09.11.04.15.08; Tue, 11 Sep 2018 04:15:08 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=nbU66iSI; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 42EBA267821; Tue, 11 Sep 2018 13:15:07 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D40F626784A; Tue, 11 Sep 2018 13:15:04 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 555D6267795 for ; Tue, 11 Sep 2018 13:15:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=8Od/XY9GeCo39t2lln3TGdXYMp7B2e2z6kCDltXgahk=; b=nbU66iSIq1ui zx02DARsLqXNWAZZ0eBiqgOLuegiDWBgwOahBA1dOeK0sofAREkI9/e311/ORlxMD8ZrNAIZeBgRM kPgmnyeubo/Sv8W6dxDRAy67cpfhRRi23845SSIxPbuZr7ZjzMDiMbC875liSeWvB5KIMJXgBWfJY PrrHs=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fzgdJ-0004l7-Li; Tue, 11 Sep 2018 11:15:01 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 636F51121AF8; Tue, 11 Sep 2018 12:15:01 +0100 (BST) From: Mark Brown To: zhong jiang In-Reply-To: Message-Id: <20180911111501.636F51121AF8@debutante.sirena.org.uk> Date: Tue, 11 Sep 2018 12:15:01 +0100 (BST) Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: q6core: Use kmemdup to replace kzalloc + memcpy" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: q6core: Use kmemdup to replace kzalloc + memcpy has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 18fbe800e6066050ab6ae7751708da04975cdc22 Mon Sep 17 00:00:00 2001 From: zhong jiang Date: Sat, 8 Sep 2018 16:36:19 +0800 Subject: [PATCH] ASoC: q6core: Use kmemdup to replace kzalloc + memcpy kmemdup has implemented the function that kzalloc() + memcpy() will do. and we prefer to use the kmemdup rather than the open coded implementation. Signed-off-by: zhong jiang Signed-off-by: Mark Brown --- sound/soc/qcom/qdsp6/q6core.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.19.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/qcom/qdsp6/q6core.c b/sound/soc/qcom/qdsp6/q6core.c index 06f03a5fe9bd..ca1be7305524 100644 --- a/sound/soc/qcom/qdsp6/q6core.c +++ b/sound/soc/qcom/qdsp6/q6core.c @@ -105,12 +105,10 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) bytes = sizeof(*fwk) + fwk->num_services * sizeof(fwk->svc_api_info[0]); - core->fwk_version = kzalloc(bytes, GFP_ATOMIC); + core->fwk_version = kmemdup(data->payload, bytes, GFP_ATOMIC); if (!core->fwk_version) return -ENOMEM; - memcpy(core->fwk_version, data->payload, bytes); - core->fwk_version_supported = true; core->resp_received = true; @@ -124,12 +122,10 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data) len = sizeof(*v) + v->num_services * sizeof(v->svc_api_info[0]); - core->svc_version = kzalloc(len, GFP_ATOMIC); + core->svc_version = kmemdup(data->payload, len, GFP_ATOMIC); if (!core->svc_version) return -ENOMEM; - memcpy(core->svc_version, data->payload, len); - core->get_version_supported = true; core->resp_received = true;