From patchwork Sun Jul 25 21:42:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Taylor Simpson X-Patchwork-Id: 485673 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp3259592jao; Sun, 25 Jul 2021 14:44:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCaj50Q3mZSa1G51X3xr/RXPV0Jnekn2jJLX6ctr6rr4Vrqw5wOWFEkmONdUOoEjxTfmlS X-Received: by 2002:a25:e548:: with SMTP id c69mr20265426ybh.46.1627249486312; Sun, 25 Jul 2021 14:44:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627249486; cv=none; d=google.com; s=arc-20160816; b=Rrj0cGOBNzv4j1xG/EuVY428cIi8E+O71QCe1cRnmAcWHgKH+3fBStNiNHzkdqxwZA tZLi3/tuEkNFl4Px6/9RLeQK+zT4PDgTElwWRHfwmLBhKkuuZNw2YvUbFgtZqe5HSFjY T/sEnZ3BAtnHMO4WXgJh9dVLH37xobQb74DPY2YPUTroAzjeZP9yyinB3OLmQLstIE9q 3iPyo3/Gr3FugMZHZZhfaC7THD6rDvoUSPihQkBLY1HmaYXodh56gZ1If9QmYpiAAyCx 8rou8JIs3HZrbxuC8/JUSnJcnYBHZbLpvVyJCNnwTBr8LC03Az5Siokdr4EvJhv+1CFL trhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ce/ncbFel0kDoOofyeNEWzeZGTOA4D5+bW1/RX/ZavM=; b=R3T/DR9qZjsBYeimxF7dGW69oekTIui4zTZYU++OIsvwQARdyZJmg8woZoe4m1KoTh 50J/OKkON4My6wLThiqi7J+z318iZQeR9obVjFLidNfd1QBJ1zCPhoO+FDPW2h1kra+t C8vT9g59zjZZuFdHs75dygysOjcPsmsGoQmRfual8fyOJ+/LMy9wVFS1MeyxoCtZC92n MWxcCXpbNZrqjS+n2x0ncex3MdEIe8CIsFtxrdm1RPRq/mi4WFBqWmHKAl9QSPjqqW60 97t+TUc3m8XmJCsOc9GDf6CzpYmnB70x3q+5XxxgQjbcIp5MKy1IwxH/XpR4N/JXadU4 rDqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=fG8idIiv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t12si36243209ybg.248.2021.07.25.14.44.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Jul 2021 14:44:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@quicinc.com header.s=qcdkim header.b=fG8idIiv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from localhost ([::1]:59808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7lvR-0004Xl-Ps for patch@linaro.org; Sun, 25 Jul 2021 17:44:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7ltl-0001ki-Pn for qemu-devel@nongnu.org; Sun, 25 Jul 2021 17:43:01 -0400 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:3744) by eggs.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1m7ltk-0005XQ-5J for qemu-devel@nongnu.org; Sun, 25 Jul 2021 17:43:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1627249380; x=1658785380; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ce/ncbFel0kDoOofyeNEWzeZGTOA4D5+bW1/RX/ZavM=; b=fG8idIivMzTLKsQa7PcK9aZZVpOrK3z8w4Fh0Qidmzyf9UrV4qkOfUvA n8ggsfIBtQr01t7U+AqEc2vaXACYiA263rF1gQXgj/TPh3O88JwPXdxoy x0YHNqIHHmgVJOs53q4VUbV+HuksbX/bAJKx8/HUJTzUs70g+It67oCRM c=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-02.qualcomm.com with ESMTP; 25 Jul 2021 14:42:53 -0700 X-QCInternal: smtphost Received: from vu-tsimpson-aus.qualcomm.com (HELO vu-tsimpson1-aus.qualcomm.com) ([10.222.150.1]) by ironmsg02-sd.qualcomm.com with ESMTP; 25 Jul 2021 14:42:53 -0700 Received: by vu-tsimpson1-aus.qualcomm.com (Postfix, from userid 47164) id B14E01223; Sun, 25 Jul 2021 16:42:52 -0500 (CDT) From: Taylor Simpson To: qemu-devel@nongnu.org Subject: [PULL v2 2/2] target/hexagon: Drop include of qemu.h Date: Sun, 25 Jul 2021 16:42:48 -0500 Message-Id: <1627249368-8366-3-git-send-email-tsimpson@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1627249368-8366-1-git-send-email-tsimpson@quicinc.com> References: <1627249368-8366-1-git-send-email-tsimpson@quicinc.com> MIME-Version: 1.0 Received-SPF: pass client-ip=199.106.114.39; envelope-from=tsimpson@qualcomm.com; helo=alexa-out-sd-02.qualcomm.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, peter.maydell@linaro.org, bcain@quicinc.com, richard.henderson@linaro.org, tsimpson@quicinc.com, philmd@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on the include path for softmmu builds. Currently we include it unconditionally in target/hexagon/op_helper.c. We used to need it for the put_user_*() and get_user_*() functions, but now that we have removed the uses of those from op_helper.c, the only reason it's still there is that we're implicitly relying on it pulling in some other headers. Explicitly include the headers we need for other functions, and drop the include of qemu.h. Signed-off-by: Peter Maydell Message-Id: <20210717103017.20491-1-peter.maydell@linaro.org> Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson Signed-off-by: Taylor Simpson --- target/hexagon/op_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index a959dba..61d5cde 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -16,7 +16,8 @@ */ #include "qemu/osdep.h" -#include "qemu.h" +#include "qemu/log.h" +#include "exec/exec-all.h" #include "exec/cpu_ldst.h" #include "exec/helper-proto.h" #include "fpu/softfloat.h"