From patchwork Mon Jul 26 10:44:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Krzysztof_Ha=C5=82asa?= X-Patchwork-Id: 486089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB57C4338F for ; Mon, 26 Jul 2021 10:44:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CF3260F46 for ; Mon, 26 Jul 2021 10:44:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232334AbhGZKE1 (ORCPT ); Mon, 26 Jul 2021 06:04:27 -0400 Received: from ni.piap.pl ([195.187.100.5]:41240 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231421AbhGZKE0 (ORCPT ); Mon, 26 Jul 2021 06:04:26 -0400 Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) by ni.piap.pl (Postfix) with ESMTPSA id 59631C3EEAF4; Mon, 26 Jul 2021 12:44:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 59631C3EEAF4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=piap.pl; s=mail; t=1627296294; bh=TitUt7zc8oIlC/P+XYSuGU7yfbmpZODOznbaK6H2hxE=; h=From:To:Cc:Subject:Date:From; b=AQcadDzsVlgnq0Fuc1vSz77wGvfG81YTeL6D1dzc1oWh8cHDBDWkPvhRZOdoKrSjQ J6Gros7VetG7rxCpkX1LylZdpIhNXccNAVlFUzE2S9XzhFh8hvPhaWP7myYC7mEz1e yJaRJ25ZXYKgMdv5dq0ZTzyXy3LwazFFi30PcV34= From: =?utf-8?q?Krzysztof_Ha=C5=82asa?= To: Tim Harvey Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] TDA1997x: fix tda1997x_remove() Sender: khalasa@piap.pl Date: Mon, 26 Jul 2021 12:44:54 +0200 Message-ID: MIME-Version: 1.0 X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 165240 [Jul 26 2021] X-KLMS-AntiSpam-Version: 5.9.20.0 X-KLMS-AntiSpam-Envelope-From: khalasa@piap.pl X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Auth: dkim=pass header.d=piap.pl X-KLMS-AntiSpam-Info: LuaCore: 449 449 5db59deca4a4f5e6ea34a93b13bc730e229092f4, {Tracking_Text_ENG_RU_Has_Extended_Latin_Letters, eng}, {Tracking_marketers, three}, {Tracking_from_domain_doesnt_match_to}, 127.0.0.199:7.1.2; t19.piap.pl:7.1.1; piap.pl:7.1.1; d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-MS-Exchange-Organization-SCL: -1 X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, bases: 2021/07/26 09:41:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2021/07/26 07:37:00 #16957752 X-KLMS-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org TDA1997x I2C "client data" pointer was never set in tda1997x_probe(), then the code tried to use invalid pointer in tda1997x_remove(). Signed-off-by: Krzysztof Hałasa diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c index 71194746c874..043cc8275d00 100644 --- a/drivers/media/i2c/tda1997x.c +++ b/drivers/media/i2c/tda1997x.c @@ -2771,6 +2771,7 @@ static int tda1997x_probe(struct i2c_client *client, goto err_free_media; } + i2c_set_clientdata(client, sd); return 0; err_free_media: