From patchwork Fri Jul 30 21:44:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 489343 Delivered-To: patch@linaro.org Received: by 2002:a05:6638:1185:0:0:0:0 with SMTP id f5csp3537362jas; Fri, 30 Jul 2021 14:45:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4cIkwSi7xJimV8fvYokGdNhHOzT8q8bj8aVI1BYiAbOfSlByHHEkAqb0tCifChtgg+Po5 X-Received: by 2002:a17:906:49ce:: with SMTP id w14mr4826809ejv.273.1627681505642; Fri, 30 Jul 2021 14:45:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627681505; cv=none; d=google.com; s=arc-20160816; b=BFgw5qxCmViexJs7UhpiN4g+xoeVoB7Y8dRaMJ+B1rhsH5RsldQ5Lm/+XzebtX9nro m+hV12ddCUyOjJyeS1bUPoWFRf23n4wvLpOeoznylcoOU3t0bergOL7dMnsPMMUGxeDJ idbnd8P6OcpK02x2lTN5/o0tJ1WW5teLOaVegPl0ZJCtzJbRa4cQRSG0LZrNJC5/Zb0A lJCqmfQusTE9fP04PoN6ksc4jppkEzNrpk877ahAyepCX7MGr00ZX2AwtFKoFnHjfH6b QwrKW8Y8ZZTPeoUaLR0YInkYlPK3BvPsJfp0iw6k1/2SiJHKnNylIrCKuwXW55HPu51d /zdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:cc:to :from; bh=VoXfe+xuIl4W5dsAISVrAhDEjGA6d9+P7Teq5qOUoEA=; b=ziX9BWcRLcbRodBsWsRG4nMOPpNFO4O2PoteaCl7bUmYMZ31panbHhfPUuSJOihyBM OOaJGFw/JfdWA3FKl82TG/V8wx4Ut42kVYRDyTjF6zSoo+AqW3UwqTTihy43nhTCl0hO Xpj+Fp1ase/h/iEiU0wlDk/Rs3hKSFl3L0H7bvHnJVbj+hbW04rLQlt4rdVn/7Izbt9x I36b1A6OuzVYtwApJYupChZCEM6XwQmLEHvK8dOYmO1QCCllDwMp1gTA8fjkYfu0DImJ UzxNjfrMmOZaaAWcL8muzOUnsCW3Pdteai204ujBX3jXO09n1XzqWiRYVzceWm+emiKN Oxbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 217.70.189.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from mails.dpdk.org (mails.dpdk.org. [217.70.189.124]) by mx.google.com with ESMTP id bi5si3051030ejb.664.2021.07.30.14.45.05; Fri, 30 Jul 2021 14:45:05 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 217.70.189.124 as permitted sender) client-ip=217.70.189.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 217.70.189.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1B3540040; Fri, 30 Jul 2021 23:45:04 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 49F5B4003F for ; Fri, 30 Jul 2021 23:45:03 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8A2811B3; Fri, 30 Jul 2021 14:45:02 -0700 (PDT) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.12.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 948253F70D; Fri, 30 Jul 2021 14:45:02 -0700 (PDT) From: Honnappa Nagarahalli To: dev@dpdk.org, honnappa.nagarahalli@arm.com, olivier.matz@6wind.com, lucp.at.work@gmail.com, david.marchand@redhat.com, thomas@monjalon.net Cc: ruifeng.wang@arm.com, nd@arm.com Date: Fri, 30 Jul 2021 16:44:53 -0500 Message-Id: <20210730214453.19975-1-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The current expected behaviour of the function rte_ctrl_thread_create is rigid which makes the implementation of the function complex. Make the expected behaviour abstract to allow for simplified implementation. With this change, the calls to pthread_setaffinity_np can be moved to the control thread. This will avoid the use of pthread_barrier_wait and simplify the synchronization mechanism between rte_ctrl_thread_create and the calling thread. Signed-off-by: Honnappa Nagarahalli --- Possible patch is at: http://patches.dpdk.org/project/dpdk/patch/20210730213709.19400-1-honnappa.nagarahalli@arm.com/ doc/guides/rel_notes/deprecation.rst | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.17.1 Acked-by: Ruifeng Wang Acked-by: Jerin Jacob diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 9584d6bfd7..1960e3c8bf 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -11,6 +11,13 @@ here. Deprecation Notices ------------------- +* eal: The expected behaviour of the function ``rte_ctrl_thread_create`` + abstracted to allow for simplified implementation. The new behaviour is + as follows: + Creates a control thread with the given name. The affinity of the new + thread is based on the CPU affinity retrieved at the time rte_eal_init() + was called, the dataplane and service lcores are then excluded. + * kvargs: The function ``rte_kvargs_process`` will get a new parameter for returning key match count. It will ease handling of no-match case.