From patchwork Tue Aug 10 08:48:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juri Lelli X-Patchwork-Id: 494666 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2E4C4320A for ; Tue, 10 Aug 2021 08:48:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92DFB61076 for ; Tue, 10 Aug 2021 08:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237764AbhHJIs7 (ORCPT ); Tue, 10 Aug 2021 04:48:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40947 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237188AbhHJIsx (ORCPT ); Tue, 10 Aug 2021 04:48:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628585311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WWWfZfczx65IParlduf54SQJn/f7jfyxJXfN8MyeRwI=; b=csBk94EAfIvBMDh3QQcJF+1cwN4SNRcvP82LWqH67CxWEqTC4njJ+3+IZPPpzy9vZzpmwp upbwfHiw28OGKfv0vpYRREMlKnzgwHQoUeQjraoUwiLRKcPkmphKkl44K/3upmXChnTiJt tGsr4FQ2HtcnDQxywwXO4tcNCKJqKMs= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-537-yE_V2RM8P3mhdQdf_WB2dw-1; Tue, 10 Aug 2021 04:48:30 -0400 X-MC-Unique: yE_V2RM8P3mhdQdf_WB2dw-1 Received: by mail-ed1-f69.google.com with SMTP id u4-20020a50eac40000b02903bddc52675eso10251650edp.4 for ; Tue, 10 Aug 2021 01:48:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WWWfZfczx65IParlduf54SQJn/f7jfyxJXfN8MyeRwI=; b=LzK1d1s5ZFhG1EDHVoXHRYGTzWM4WC1Qt8ErG16u73s0Wksp9p6hJi/ZgA1pJPa8OE ztfn/ZzND8+nnmckha7msW59paLjALVWADlYcPszqjpTvi0FLD2RIiJb+O7yHahlPw0k AtJbfQEoGymP0ho2by64gE2GL8/AvPgYNH6J2BTxyH2BxzHdoKh8/Xb47QRufXBvuE0B ZgRozVBAGZponJCvredq0iLmDb5qPBOMEGXNbIu1H1/K+rca2R9RWIqFkDlNPQ1paOcU UachvBWYbYTKeENFQScAOCcMta9uECJO9onIH6C/fO+HMqBTqczjyIOxVke3vvd/kpaj pniQ== X-Gm-Message-State: AOAM533vz1OuYuU31DCGfeZNKDunHJpRV/VTRvvVVeEJshrwiYDXOhY6 Nv3nXEQmhNwXIV3ECfrPe7Kb4YLj+5fsFMBQQlGJNBQMiqSsUdqw8ESJT0+xBQjRt06tFdsP8HH fioE7zz8LTN1A5veoVUKp2vyfefA= X-Received: by 2002:a17:906:c006:: with SMTP id e6mr26786003ejz.510.1628585308628; Tue, 10 Aug 2021 01:48:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzn80ECnujwqU7hjqyUptCj/nIeG0tDzxXAB3iqy+3raekA06q/d65FphjKgOD6D/7OJW+HXg== X-Received: by 2002:a17:906:c006:: with SMTP id e6mr26785981ejz.510.1628585308409; Tue, 10 Aug 2021 01:48:28 -0700 (PDT) Received: from localhost.localdomain.com ([151.29.52.108]) by smtp.gmail.com with ESMTPSA id la23sm6557667ejc.63.2021.08.10.01.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 01:48:27 -0700 (PDT) From: Juri Lelli To: paulmck@kernel.org, josh@joshtriplett.org Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, peterz@infradead.org, bigeasy@linutronix.de, tglx@linutronix.de, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, rcu@vger.kernel.org, Juri Lelli Subject: [PATCH v2 1/2] rcu: Make rcu_normal_after_boot writable again Date: Tue, 10 Aug 2021 10:48:15 +0200 Message-Id: <20210810084816.155203-2-juri.lelli@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210810084816.155203-1-juri.lelli@redhat.com> References: <20210810084816.155203-1-juri.lelli@redhat.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org Certain configurations (e.g., systems that make heavy use of netns) need to use synchronize_rcu_expedited() to service RCU grace periods even after boot. Even though synchronize_rcu_expedited() has been traditionally considered harmful for RT for the heavy use of IPIs, it is perfectly usable under certain conditions (e.g. nohz_full). Make rcupdate.rcu_normal_after_boot= again writeable on RT (if NO_HZ_ FULL is defined), but keep its default value to 1 (enabled) to avoid regressions. Users who need synchronize_rcu_expedited() will boot with rcupdate.rcu_normal_after_ boot=0 in the kernel cmdline. Reflect the change in synchronize_rcu_expedited_wait() by removing the WARN related to CONFIG_PREEMPT_RT. Signed-off-by: Juri Lelli --- kernel/rcu/tree_exp.h | 1 - kernel/rcu/update.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h index 2796084ef85a..d9e4f8eb9ae2 100644 --- a/kernel/rcu/tree_exp.h +++ b/kernel/rcu/tree_exp.h @@ -512,7 +512,6 @@ static void synchronize_rcu_expedited_wait(void) j = READ_ONCE(jiffies_till_first_fqs); if (synchronize_rcu_expedited_wait_once(j + HZ)) return; - WARN_ON_ONCE(IS_ENABLED(CONFIG_PREEMPT_RT)); } for (;;) { diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c index c21b38cc25e9..bd551134e2f4 100644 --- a/kernel/rcu/update.c +++ b/kernel/rcu/update.c @@ -57,7 +57,7 @@ module_param(rcu_expedited, int, 0); module_param(rcu_normal, int, 0); static int rcu_normal_after_boot = IS_ENABLED(CONFIG_PREEMPT_RT); -#ifndef CONFIG_PREEMPT_RT +#if !defined(CONFIG_PREEMPT_RT) || defined(CONFIG_NO_HZ_FULL) module_param(rcu_normal_after_boot, int, 0); #endif #endif /* #ifndef CONFIG_TINY_RCU */ From patchwork Tue Aug 10 08:48:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juri Lelli X-Patchwork-Id: 495524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46557C432BE for ; Tue, 10 Aug 2021 08:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B7B360F25 for ; Tue, 10 Aug 2021 08:48:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237813AbhHJItC (ORCPT ); Tue, 10 Aug 2021 04:49:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27605 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237520AbhHJIsy (ORCPT ); Tue, 10 Aug 2021 04:48:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628585312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4yZNIu6PGRqh0XUsAg6YLnUrC7a2tSubYiI4yoIHuuI=; b=LSRN8HbWQ9gyE7lFu5uFwKZbtFWXIcDagC7LpcfHSzqN0ytZcCO68/lanTWBiek/yxUdaZ L+OEeURoLJ1lTQ7uQblnbOfXGbFDSa4OAZEqARcGBo3bIx8u/O2U8EWjHkn3/2EjlZD5jP v8SoNLGBm9xizJNc4q//o8AWdU6T9yQ= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-E5PeWuIoM82iFn5hRb9F3g-1; Tue, 10 Aug 2021 04:48:31 -0400 X-MC-Unique: E5PeWuIoM82iFn5hRb9F3g-1 Received: by mail-ed1-f71.google.com with SMTP id u25-20020aa7d8990000b02903bb6a903d90so10449270edq.17 for ; Tue, 10 Aug 2021 01:48:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4yZNIu6PGRqh0XUsAg6YLnUrC7a2tSubYiI4yoIHuuI=; b=uKUJ1T5Zv1kdcv/w1og/XGSg1M5wSS8V/0/wxHYUcLxKKws1pUx0F6fpIF3p5gL2qI 54VP4Cm33nbUG+pafSTkPBvACuy363KdXqcg9A2tcQtEVL2eT8fXA8HgVp9lBZhvD4Og Ek3FAoeP2dPwye8W9uxwqmBTtim7J1gVfP1INPBj42AXqM/rJrIgSpeuQ32rixn/YvWb lgFSqDPp4jwm65YtAcmgFv3yR6Y6u19sCdovcHK7/wZIaqsAFSHlNUQ9tONarbO/RfFi dU+WLrikIYvxWmr7jCI0Sf9WJGSOSsXLZ+59uwArHRZ21QHOrSobC0hkKM5u/rn9N+/E ZDWQ== X-Gm-Message-State: AOAM530YMqD25X+KYW7nmAhNCG3xIUT+GzrC/GtfY9MTFJMOTptZWOhM /YVtXuNPur5xl8E+DwDdGBiXcByD2ZI6Zre6ttl6PPMsJwHsoMKqgUEg31rftg62XcUCZITAViI 8EA/ZI3jQNiOoClNvUiXvIiWAQHk= X-Received: by 2002:a17:906:405:: with SMTP id d5mr26430802eja.189.1628585310190; Tue, 10 Aug 2021 01:48:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz22EQal9Exqyj7ThilEjaTvbLq4Q2a5syoFgJGe/g8lj7NmDmRexbLX8nYJHLpkiLxzCdkUg== X-Received: by 2002:a17:906:405:: with SMTP id d5mr26430786eja.189.1628585310038; Tue, 10 Aug 2021 01:48:30 -0700 (PDT) Received: from localhost.localdomain.com ([151.29.52.108]) by smtp.gmail.com with ESMTPSA id la23sm6557667ejc.63.2021.08.10.01.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 01:48:29 -0700 (PDT) From: Juri Lelli To: paulmck@kernel.org, josh@joshtriplett.org Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, peterz@infradead.org, bigeasy@linutronix.de, tglx@linutronix.de, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, rcu@vger.kernel.org, Juri Lelli Subject: [PATCH v2 2/2] rcu: Make rcu update module parameters world-readable Date: Tue, 10 Aug 2021 10:48:16 +0200 Message-Id: <20210810084816.155203-3-juri.lelli@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210810084816.155203-1-juri.lelli@redhat.com> References: <20210810084816.155203-1-juri.lelli@redhat.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org rcu update module parameters currently don't appear in sysfs and this is a serviceability issue as it might be needed to access their default values at runtime. Fix this issue by changing rcu update module parameters permissions to world-readable. Suggested-by: Paul E. McKenney Signed-off-by: Juri Lelli --- kernel/rcu/update.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c index bd551134e2f4..94282dc12bab 100644 --- a/kernel/rcu/update.c +++ b/kernel/rcu/update.c @@ -54,11 +54,11 @@ #define MODULE_PARAM_PREFIX "rcupdate." #ifndef CONFIG_TINY_RCU -module_param(rcu_expedited, int, 0); -module_param(rcu_normal, int, 0); +module_param(rcu_expedited, int, 0444); +module_param(rcu_normal, int, 0444); static int rcu_normal_after_boot = IS_ENABLED(CONFIG_PREEMPT_RT); #if !defined(CONFIG_PREEMPT_RT) || defined(CONFIG_NO_HZ_FULL) -module_param(rcu_normal_after_boot, int, 0); +module_param(rcu_normal_after_boot, int, 0444); #endif #endif /* #ifndef CONFIG_TINY_RCU */