From patchwork Tue Aug 31 12:58:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Saenz Julienne X-Patchwork-Id: 504715 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF429C432BE for ; Tue, 31 Aug 2021 12:59:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7DC66103D for ; Tue, 31 Aug 2021 12:59:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233721AbhHaNAA (ORCPT ); Tue, 31 Aug 2021 09:00:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31556 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233530AbhHaM75 (ORCPT ); Tue, 31 Aug 2021 08:59:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630414742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VFi9mk+JrNYqm9om9cI3aYM4Tz+JK5QNKRVw7UvYJXE=; b=IwsU7QwrwZoqqfg9gxTDolrNRIRtOe52u8LmNMVzPvrHIJzfyy4IXxpQKqM1/a+gVzqwf3 vR4HcfQkqG1h6fLP8I51z/HQd0DCS7rGr7pVtgki45qZk4ncbjPj4rnJ+EB378t8E1D53H UpXxmu0Uzki4PJ+t9kZYI/JXB6mtiHY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-444-RpSO8R-_PwmdTEy8FtCgoQ-1; Tue, 31 Aug 2021 08:59:00 -0400 X-MC-Unique: RpSO8R-_PwmdTEy8FtCgoQ-1 Received: by mail-wr1-f69.google.com with SMTP id l1-20020adff481000000b00156e670a09dso4033687wro.1 for ; Tue, 31 Aug 2021 05:59:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VFi9mk+JrNYqm9om9cI3aYM4Tz+JK5QNKRVw7UvYJXE=; b=rFM18AKz/s/TFz1cXlWGCA525BAiEU6ChqjNnt+4PC9cauxyEUIXMm+lg++/pvFqPa ykmgt1H6O3EpHWzfiRUaj8Zi3pOrfW0iBfWrwjj6Od1PEVw+B81jBztFxsb8dykBTXIe TDcUHjZKVz/RWVkNB6tQEbAmFOQjG+exmGhf6JlX0J7VSWmT3ilRdKuF6ScQcno2ndtu 3VsiXTjfwhr1V5Bhhj0ML8ROxrD76eaPq7FCkuebtsFv0o8loGAiUnJQsHa/5NMBcylA hMCyxfnCyfZMl2tjWMrtqAJXBOzcDNM19UUSo4U3a9G5twmbTMLhWNFDqFs2qlfAgL34 FcMw== X-Gm-Message-State: AOAM531ZaM5OE8lnojrgmpTilqwHxiUiK3StfBD8vmKeEz0Ffe67pnKq eX/DUulfsgB+e8KREfS8KtXxE8KUWN7AKJMBltDwuS6ciiH131iH/VjdBCcdFgcyPJHdIqVvcEa VtjuY3xJcCwTKvt6lQbH4sg== X-Received: by 2002:a5d:6e84:: with SMTP id k4mr30756121wrz.426.1630414739547; Tue, 31 Aug 2021 05:58:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzflIax6tFxvMs9mjbd8B1Mb2iEt9SCQmR/++VhwuAoQyhS9HpVASDt6bCiXW4+7etv8yFh8w== X-Received: by 2002:a5d:6e84:: with SMTP id k4mr30756112wrz.426.1630414739351; Tue, 31 Aug 2021 05:58:59 -0700 (PDT) Received: from vian.redhat.com ([2a0c:5a80:3c08:b500:afb2:5ebc:3fd2:26de]) by smtp.gmail.com with ESMTPSA id a133sm2553199wme.5.2021.08.31.05.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 05:58:59 -0700 (PDT) From: Nicolas Saenz Julienne To: robh+dt@kernel.org, nsaenz@kernel.org, f.fainelli@gmail.com Cc: gregkh@linuxfoundation.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stefan.wahren@i2se.com, Nicolas Saenz Julienne , Rob Herring Subject: [PATCH v2 2/2] ARM: dts: bcm2711-rpi-4-b: Fix usb's unit address Date: Tue, 31 Aug 2021 14:58:43 +0200 Message-Id: <20210831125843.1233488-2-nsaenzju@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210831125843.1233488-1-nsaenzju@redhat.com> References: <20210831125843.1233488-1-nsaenzju@redhat.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The unit address is supposed to represent ','. Which are both 0 for RPi4b's XHCI controller. On top of that although OpenFirmware states bus number goes in the high part of the last reg parameter, FDT doesn't seem to care for it[1], so remove it. [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830103909.323356-1-nsaenzju@redhat.com/#24414633 Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node") Suggested-by: Rob Herring Signed-off-by: Nicolas Saenz Julienne --- Chages since v1: - Add patch as per robh suggestion arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts index 8377dc14b7b5..50530cc91876 100644 --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts @@ -225,8 +225,8 @@ pci@0,0 { reg = <0 0 0 0 0>; - usb@1,0 { - reg = <0x10000 0 0 0 0>; + usb@0,0 { + reg = <0 0 0 0 0>; resets = <&reset RASPBERRYPI_FIRMWARE_RESET_ID_USB>; }; };