From patchwork Fri Oct 19 23:26:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 149355 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp3894312lji; Fri, 19 Oct 2018 16:26:29 -0700 (PDT) X-Google-Smtp-Source: ACcGV63hxeasfV2fTBbbiwRDPS6i3yT5HlIUhrqvBzlhuM2VtboXF3eehOeGL9TgyhY50CTCaEBN X-Received: by 2002:a62:c60a:: with SMTP id m10-v6mr36807728pfg.15.1539991589654; Fri, 19 Oct 2018 16:26:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539991589; cv=none; d=google.com; s=arc-20160816; b=s7Wd8BeUPK9dxMZFIF0hrO954E+yZFZGHe9+OubVPMfdgxSCnFqbXrut2ab43a4gjQ 5Zm37gkqNa5W7PIDUrEqjme5qMiu+pN4GEHIygTykftAfQ/Kg8pQh8qalSjZEHPk/0nb JfSRpbGummgTdu6ztAuquPJCtUoRNT+0PLVVP0B+8my9fEu7Y9lIYGj725qG2wnEBFeT bL/FEe41ewkfcMfLCoqti7PsqZdkqFfwIUhBO0zgk11HOqGVOAb+2uxk4AC+YP9iK7BS 0DQHqaJ6WBvhIrTSzGfFfOfCkj3GKnZZPYAYi9YgMYrn/INUZ3rc0VGSIN8W4gqUbIfV iMvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:to:from:dkim-signature:delivered-to:sender :list-help:list-post:list-archive:list-subscribe:list-unsubscribe :list-id:precedence:mailing-list:dkim-signature:domainkey-signature; bh=fTZL2QNY6Vw7wOCYP9xDvitUG0rEkvLsatdly/fLZBM=; b=N6HrelJDGkxNWqTOpOTTyd9AsKiwYSRO6Yswe8Xw4kAmJw4OXVvJGSwYfvduFgeudJ mL/nTUmsNJ50nOIxj/m9zng+yNOtdBQqcWTH2+QHDSJNpKK1R+bEUtg3ysp1JgfI8Bdt EsY/VxD0J19AMtTygx+5zLnOd8aAzWTeAlBCITmNLIA2RYuWDRIxnaZitHds2M41FWY+ YiM4BeECcI8NHlhDLi/s012QS6ys2ANEIgHUXH/HWnSDMJal3IHpPW72ZQXsZ8bYYh+L ycepV333PJr5LjWzw7+VCahmNp3hNJcwYoeLTK8s6EayikFbLpGApXDcuRmVndvuQY2c 1RUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=rYVZlNwF; dkim=pass header.i=@linaro.org header.s=google header.b=OLCZCc+4; spf=pass (google.com: domain of libc-alpha-return-96543-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-96543-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id p6-v6si26260342pgp.243.2018.10.19.16.26.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Oct 2018 16:26:29 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-96543-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=rYVZlNwF; dkim=pass header.i=@linaro.org header.s=google header.b=OLCZCc+4; spf=pass (google.com: domain of libc-alpha-return-96543-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-96543-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=l3xRho2v09/Qp0FyYugP1evKUHuXLBx5P4FQcLdX0CRAJ45hFnYEB 82Ay69kUPgpu6dwbRE8QReOSci2Fdvi/Q3IdKIreiTpYk5xdHw7DkDftYgRdfLYd b9y3HxtV/mofCB6dkhDadrWzeRZhRa53AZVRQLCjFkBnj0kAsRipWg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=onc4IE0JvbasSQmoHeBppOZLn0M=; b=rYVZlNwFZaWixLqyk6LJ+QIdSIEc Y6PFU58ZlzxIS08IolxSdHI85Dv7pQfHt4efC/kGAgBwTx+ProhU4CsUzxz4UEqP w5jRlhyRlT+G4VCHD1fQy+fGnrcWlQC12HVY91SQDdegCFzzTsQWoLwc7AAvKm6O ApPzxePG6XP2ptY= Received: (qmail 43957 invoked by alias); 19 Oct 2018 23:26:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 43941 invoked by uid 89); 19 Oct 2018 23:26:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Simply, signals, 19, 8, 198 X-HELO: mail-qt1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id; bh=fTZL2QNY6Vw7wOCYP9xDvitUG0rEkvLsatdly/fLZBM=; b=OLCZCc+40e68AV28uj8El9cI+HUPTiSPi3Fv2siMsSVXjg6nUrpJ7Xap7/R4RxL0Fu GU0/rkD3BcBAip1M4J7wHfS/tcdcPDQmjtQB7oG2vjC37RjuVqB0u06uTFz5MWDeYZJD 1oOjB6WNblKLhANil17V4e1GVwv69W4hUG6og= Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH v2 1/3] posix: Add internal symbols for posix_spawn interface Date: Fri, 19 Oct 2018 20:26:07 -0300 Message-Id: <20181019232609.25531-1-adhemerval.zanella@linaro.org> This patch adds internal hidden definition for mostly of the posix_spawn function so it can be used internally on both popen and system implementations. Checked on x86_64-linux-gnu. * include/spawn.h (__posix_spawn, posix_spawn_file_actions_addclose, __posix_spawn_file_actions_adddup2, __posix_spawn_file_actions_destroy, __posix_spawn_file_actions_init, __posix_spawnattr_init, __posix_spawnattr_destroy, __posix_spawnattr_setflags, __posix_spawnattr_setsigdefault, __posix_spawnattr_setsigmask): New prototype. * posix/spawn.c (__posix_spawn): Add libc_hidden_def. * posix/spawn_faction_addclose.c (__posix_spawn_file_actions_addclose): Add hidden definition. * posix/spawn_faction_adddup2.c (__posix_spawn_file_actions_adddup2): Likewise. * posix/spawn_faction_destroy.c (__posix_spawn_file_actions_destroy): Likewise. * posix/spawn_faction_init.c (__posix_spawn_file_actions_init): Likewise. * posix/spawnattr_destroy.c (__posix_spawnattr_destroy): Likewise. * posix/spawnattr_init.c (__posix_spawnattr_init): Likewise. * posix/spawnattr_setdefault.c (__posix_spawnattr_setsigdefault): Likewise. * posix/spawnattr_setflags.c (__posix_spawnattr_setflags): Likewise. * posix/spawnattr_setsigmask.c (__posix_spawnattr_setsigmask): Likewise. --- ChangeLog | 25 ++++++++++++++++++++++++ include/spawn.h | 35 ++++++++++++++++++++++++++++++++++ posix/spawn.c | 1 + posix/spawn_faction_addclose.c | 6 ++++-- posix/spawn_faction_adddup2.c | 6 ++++-- posix/spawn_faction_destroy.c | 4 +++- posix/spawn_faction_init.c | 3 ++- posix/spawnattr_destroy.c | 3 ++- posix/spawnattr_init.c | 3 ++- posix/spawnattr_setdefault.c | 5 +++-- posix/spawnattr_setflags.c | 3 ++- posix/spawnattr_setsigmask.c | 3 ++- 12 files changed, 85 insertions(+), 12 deletions(-) -- 2.17.1 diff --git a/ChangeLog b/ChangeLog index 0f3a846ad3..5a037a21e7 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,28 @@ +2018-09-17 Adhemerval Zanella + + * include/spawn.h (__posix_spawn, posix_spawn_file_actions_addclose, + __posix_spawn_file_actions_adddup2, __posix_spawn_file_actions_destroy, + __posix_spawn_file_actions_init, __posix_spawnattr_init, + __posix_spawnattr_destroy, __posix_spawnattr_setflags, + __posix_spawnattr_setsigdefault, __posix_spawnattr_setsigmask): New + prototype. + * posix/spawn.c (__posix_spawn): Add libc_hidden_def. + * posix/spawn_faction_addclose.c + (__posix_spawn_file_actions_addclose): Add hidden definition. + * posix/spawn_faction_adddup2.c + (__posix_spawn_file_actions_adddup2): Likewise. + * posix/spawn_faction_destroy.c + (__posix_spawn_file_actions_destroy): Likewise. + * posix/spawn_faction_init.c (__posix_spawn_file_actions_init): + Likewise. + * posix/spawnattr_destroy.c (__posix_spawnattr_destroy): Likewise. + * posix/spawnattr_init.c (__posix_spawnattr_init): Likewise. + * posix/spawnattr_setdefault.c (__posix_spawnattr_setsigdefault): + Likewise. + * posix/spawnattr_setflags.c (__posix_spawnattr_setflags): Likewise. + * posix/spawnattr_setsigmask.c (__posix_spawnattr_setsigmask): + Likewise. + 2018-10-17 Joseph Myers * sysdeps/unix/sysv/linux/Makefile (sysdep_headers): Add diff --git a/include/spawn.h b/include/spawn.h index a6c7a8adc3..7fdd965bd7 100644 --- a/include/spawn.h +++ b/include/spawn.h @@ -1 +1,36 @@ +#ifndef _SPAWN_H #include + +# ifndef _ISOMAC +__typeof (posix_spawn) __posix_spawn; +libc_hidden_proto (__posix_spawn) + +__typeof (posix_spawn_file_actions_addclose) + __posix_spawn_file_actions_addclose attribute_hidden; + +__typeof (posix_spawn_file_actions_adddup2) + __posix_spawn_file_actions_adddup2 attribute_hidden; + +__typeof (posix_spawn_file_actions_destroy) + __posix_spawn_file_actions_destroy attribute_hidden; + +__typeof (posix_spawn_file_actions_init) __posix_spawn_file_actions_init + attribute_hidden; + +__typeof (posix_spawnattr_init) __posix_spawnattr_init + attribute_hidden; + +__typeof (posix_spawnattr_destroy) __posix_spawnattr_destroy + attribute_hidden; + +__typeof (posix_spawnattr_setflags) __posix_spawnattr_setflags + attribute_hidden; + +__typeof (posix_spawnattr_setsigdefault) __posix_spawnattr_setsigdefault + attribute_hidden; + +__typeof (posix_spawnattr_setsigmask) __posix_spawnattr_setsigmask + attribute_hidden; + +# endif /* !_ISOMAC */ +#endif /* spawn.h */ diff --git a/posix/spawn.c b/posix/spawn.c index 51f67b2755..a82f1c84e2 100644 --- a/posix/spawn.c +++ b/posix/spawn.c @@ -30,6 +30,7 @@ __posix_spawn (pid_t *pid, const char *path, return __spawni (pid, path, file_actions, attrp, argv, envp, 0); } versioned_symbol (libc, __posix_spawn, posix_spawn, GLIBC_2_15); +libc_hidden_def (__posix_spawn) #if SHLIB_COMPAT (libc, GLIBC_2_2, GLIBC_2_15) diff --git a/posix/spawn_faction_addclose.c b/posix/spawn_faction_addclose.c index 21081e19b5..e1fafe438c 100644 --- a/posix/spawn_faction_addclose.c +++ b/posix/spawn_faction_addclose.c @@ -24,8 +24,8 @@ /* Add an action to FILE-ACTIONS which tells the implementation to call `close' for the given file descriptor during the `spawn' call. */ int -posix_spawn_file_actions_addclose (posix_spawn_file_actions_t *file_actions, - int fd) +__posix_spawn_file_actions_addclose (posix_spawn_file_actions_t *file_actions, + int fd) { struct __spawn_action *rec; @@ -48,3 +48,5 @@ posix_spawn_file_actions_addclose (posix_spawn_file_actions_t *file_actions, return 0; } +weak_alias (__posix_spawn_file_actions_addclose, + posix_spawn_file_actions_addclose) diff --git a/posix/spawn_faction_adddup2.c b/posix/spawn_faction_adddup2.c index 363bc29ae5..371b1de3e6 100644 --- a/posix/spawn_faction_adddup2.c +++ b/posix/spawn_faction_adddup2.c @@ -24,8 +24,8 @@ /* Add an action to FILE-ACTIONS which tells the implementation to call `dup2' for the given file descriptors during the `spawn' call. */ int -posix_spawn_file_actions_adddup2 (posix_spawn_file_actions_t *file_actions, - int fd, int newfd) +__posix_spawn_file_actions_adddup2 (posix_spawn_file_actions_t *file_actions, + int fd, int newfd) { struct __spawn_action *rec; @@ -49,3 +49,5 @@ posix_spawn_file_actions_adddup2 (posix_spawn_file_actions_t *file_actions, return 0; } +weak_alias (__posix_spawn_file_actions_adddup2, + posix_spawn_file_actions_adddup2) diff --git a/posix/spawn_faction_destroy.c b/posix/spawn_faction_destroy.c index 46061ee347..2a2de4e41d 100644 --- a/posix/spawn_faction_destroy.c +++ b/posix/spawn_faction_destroy.c @@ -22,7 +22,7 @@ /* Deallocate the file actions. */ int -posix_spawn_file_actions_destroy (posix_spawn_file_actions_t *file_actions) +__posix_spawn_file_actions_destroy (posix_spawn_file_actions_t *file_actions) { /* Free the paths in the open actions. */ for (int i = 0; i < file_actions->__used; ++i) @@ -44,3 +44,5 @@ posix_spawn_file_actions_destroy (posix_spawn_file_actions_t *file_actions) free (file_actions->__actions); return 0; } +weak_alias (__posix_spawn_file_actions_destroy, + posix_spawn_file_actions_destroy) diff --git a/posix/spawn_faction_init.c b/posix/spawn_faction_init.c index ddb42e6a77..98432067c6 100644 --- a/posix/spawn_faction_init.c +++ b/posix/spawn_faction_init.c @@ -45,9 +45,10 @@ __posix_spawn_file_actions_realloc (posix_spawn_file_actions_t *file_actions) /* Initialize data structure for file attribute for `spawn' call. */ int -posix_spawn_file_actions_init (posix_spawn_file_actions_t *file_actions) +__posix_spawn_file_actions_init (posix_spawn_file_actions_t *file_actions) { /* Simply clear all the elements. */ memset (file_actions, '\0', sizeof (*file_actions)); return 0; } +weak_alias (__posix_spawn_file_actions_init, posix_spawn_file_actions_init) diff --git a/posix/spawnattr_destroy.c b/posix/spawnattr_destroy.c index 603e00fffe..0433867785 100644 --- a/posix/spawnattr_destroy.c +++ b/posix/spawnattr_destroy.c @@ -19,8 +19,9 @@ /* Initialize data structure for file attribute for `spawn' call. */ int -posix_spawnattr_destroy (posix_spawnattr_t *attr) +__posix_spawnattr_destroy (posix_spawnattr_t *attr) { /* Nothing to do in the moment. */ return 0; } +weak_alias (__posix_spawnattr_destroy, posix_spawnattr_destroy) diff --git a/posix/spawnattr_init.c b/posix/spawnattr_init.c index bab464e62b..4e1218ab44 100644 --- a/posix/spawnattr_init.c +++ b/posix/spawnattr_init.c @@ -20,7 +20,7 @@ /* Initialize data structure for file attribute for `spawn' call. */ int -posix_spawnattr_init (posix_spawnattr_t *attr) +__posix_spawnattr_init (posix_spawnattr_t *attr) { /* All elements have to be initialized to the default values which is generally zero. */ @@ -28,3 +28,4 @@ posix_spawnattr_init (posix_spawnattr_t *attr) return 0; } +weak_alias (__posix_spawnattr_init, posix_spawnattr_init) diff --git a/posix/spawnattr_setdefault.c b/posix/spawnattr_setdefault.c index c77cda59be..174bcfa423 100644 --- a/posix/spawnattr_setdefault.c +++ b/posix/spawnattr_setdefault.c @@ -20,11 +20,12 @@ /* Set signal mask for signals with default handling in ATTR to SIGDEFAULT. */ int -posix_spawnattr_setsigdefault (posix_spawnattr_t *attr, - const sigset_t *sigdefault) +__posix_spawnattr_setsigdefault (posix_spawnattr_t *attr, + const sigset_t *sigdefault) { /* Copy the sigset_t data to the user buffer. */ memcpy (&attr->__sd, sigdefault, sizeof (sigset_t)); return 0; } +weak_alias (__posix_spawnattr_setsigdefault, posix_spawnattr_setsigdefault) diff --git a/posix/spawnattr_setflags.c b/posix/spawnattr_setflags.c index cf9a60181d..0a42e94770 100644 --- a/posix/spawnattr_setflags.c +++ b/posix/spawnattr_setflags.c @@ -30,7 +30,7 @@ /* Store flags in the attribute structure. */ int -posix_spawnattr_setflags (posix_spawnattr_t *attr, short int flags) +__posix_spawnattr_setflags (posix_spawnattr_t *attr, short int flags) { /* Check no invalid bits are set. */ if (flags & ~ALL_FLAGS) @@ -41,3 +41,4 @@ posix_spawnattr_setflags (posix_spawnattr_t *attr, short int flags) return 0; } +weak_alias (__posix_spawnattr_setflags, posix_spawnattr_setflags) diff --git a/posix/spawnattr_setsigmask.c b/posix/spawnattr_setsigmask.c index 7ae81ad470..12c0111af4 100644 --- a/posix/spawnattr_setsigmask.c +++ b/posix/spawnattr_setsigmask.c @@ -20,7 +20,7 @@ /* Set signal mask for the new process in ATTR to SIGMASK. */ int -posix_spawnattr_setsigmask (posix_spawnattr_t *attr, +__posix_spawnattr_setsigmask (posix_spawnattr_t *attr, const sigset_t *sigmask) { /* Copy the sigset_t data to the user buffer. */ @@ -28,3 +28,4 @@ posix_spawnattr_setsigmask (posix_spawnattr_t *attr, return 0; } +weak_alias (__posix_spawnattr_setsigmask, posix_spawnattr_setsigmask) From patchwork Fri Oct 19 23:26:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 149356 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp3894416lji; Fri, 19 Oct 2018 16:26:38 -0700 (PDT) X-Google-Smtp-Source: ACcGV61gQ4XsJBrSwrnXU59xNchRXafhpxHnV9bAQYaZ6GqwuAd0vPfag3kGqV5DymDM/IGyXT/H X-Received: by 2002:a17:902:b943:: with SMTP id h3-v6mr36128349pls.5.1539991598208; Fri, 19 Oct 2018 16:26:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539991598; cv=none; d=google.com; s=arc-20160816; b=GBXH9TIiLNsZQoyGWh/dFjB3EjirKITZW1g3OaHSVkRk0Nk22XGtMXmXrP1OYrqkAA ZddXkSMGYWsAiM3OfM5D7rcFIPxokPPTwrpzxRyDiwm4UEI2YEhVUQAgAtBPTEBSLr3f 92Nlp5GZ3AQLUqm+IBkmrMja8DyTVm6UxwHjiP1P5HnJVHFDGX/FMLeTzX3/GyXd/NJv j79Qnrg5yD9oDjU/aWgI5yX/30mOizelgi5SF10bplfBHTSmuPY/Wt3rGC2hwibQeTJ/ dWLR2UWKDNJTBPuzrurB78kJTIy/ygc57BzyAa+W6+DlsNuvPOo8XTCPSGSSd26ysAZ1 C5yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=3vTxn6omg6+ipxj4eCp+BlsHzeMABUUXDJRuJVnGsYk=; b=PO5MeJ5IOVv8unF3G6hbwlAomE4CZKW0DH96X/4uguqPH9KIGQgcYbm3DDsXE3DiK2 v/jkoPUioCze7DRVCgKLzkSSebbtScCqfhsqaq6lgZnMSa3L7oeMMJsw0XY9hNaSv9xn 7e5nIO1HtfxpISsprvpnNWdXneNDTdH1c2qo3Fm4yXaHYJHNGJ3Uv61mQyEfv9inRCgy CxyjbwcdIJ5+rgMMKnQz+QPVjKd8dfEaBRCrFi8YMz3iNN6LzhWf8L7MvE4V09C8gyr1 KyCZX+ShfZXxwPi72UbR9PF+B25mgjUcjlXPhaYvHRh+V41h3W3C3z4gnbVpg9LhaB45 vqyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=BPdSKQFR; dkim=pass header.i=@linaro.org header.s=google header.b=BQWd6tib; spf=pass (google.com: domain of libc-alpha-return-96544-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-96544-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id bj12-v6si24442085plb.178.2018.10.19.16.26.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Oct 2018 16:26:38 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-96544-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=BPdSKQFR; dkim=pass header.i=@linaro.org header.s=google header.b=BQWd6tib; spf=pass (google.com: domain of libc-alpha-return-96544-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-96544-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=C3lzpZOxyVOERYf3Ft6lpPUkJcaohoh Y61/N7Pkk+5P6DwBXqgIFE3Cz/QGbKQCb4aec+ZrIeOD77uOhz5ZQ1vtJfmtMrlg P4WUYOzpxmppOejQpGLnNneW5/xz0/b9AL2U9B+CCwgMpoAAaCGnwE996q+3ltXP zaMfyQqusVfo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=K+7fHa2UyaOXIizywEhx+1BP/7g=; b=BPdSK QFRU53f24+whc60Iz6FjDb1vtWpFKXHJOf7h36AXjPrk6CHoYunp5kbOFaEBjuNk PGA3uv8gqyr7qEFMe0LojrZbY7m5sTcy1axrdhyLDKB5HYs3hIa8YqUuArjd77ec octx1cwg3OBfxpWlcwhkWZ/WylWNONsjNtNe/4= Received: (qmail 44029 invoked by alias); 19 Oct 2018 23:26:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 43956 invoked by uid 89); 19 Oct 2018 23:26:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=unlock, HX-Received:sk:18-v6mr X-HELO: mail-qk1-f194.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=3vTxn6omg6+ipxj4eCp+BlsHzeMABUUXDJRuJVnGsYk=; b=BQWd6tibLEP8DlXC6ul8hsW5f6VZXkZORbFYoH3LbDqADBgBCbD2qDUVDCEIKLiPba UhDErmV7c43lLsYfb7/N+msxsp6iE6IhUJw8GW39sVsud2sQtLYBgJMTGz0NGVPY273n EqE7wswx0VSCeKYDlv+ULZ+LLoJTnqRVIoY/c= Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH v2 2/3] posix: Use posix_spawn on popen Date: Fri, 19 Oct 2018 20:26:08 -0300 Message-Id: <20181019232609.25531-2-adhemerval.zanella@linaro.org> In-Reply-To: <20181019232609.25531-1-adhemerval.zanella@linaro.org> References: <20181019232609.25531-1-adhemerval.zanella@linaro.org> Changed from previous version: - Added note about BZ#17490 fix. - Use proc_file_chain_lock to access proc_file_chain (BZ#22834). --- This patch uses posix_spawn on popen instead of fork and execl. On Linux this has the advantage of much lower memory consumption (usually 32 Kb minimum for the mmap stack area). Two issues are also fixed with this change: * BZ#17490: although POSIX pthread_atfork description only list 'fork' as the function where should issue the atfork handlers and popen description states that: '[...] shall be *as if* a child process were created within the popen() call using the fork() function [...]' Other libc/system seems to follow the idea atfork handlers should not be issue for popen: libc/system | run atfork handles | notes ------------|----------------------|--------------------------------------- freebsd | no | uses vfork solaris 11 | no | MacOSX 11i | no | implemented through posix_spawn syscall ------------|----------------------|---------------------------------------- Similar to posix_spawn and system, popen idea is to spawn a different binary so all the POSIX rationale to run the atfork handlers to avoid internal process inconsistency is not really required and in some cases might be unsafe. * BZ#22834: now that proc_file_chain is not copied on another process, it just require to access is through the proc_file_chain_lock. Checked on x86_64-linux-gnu and i686-linux-gnu. [BZ #22834] [BZ #17490] * libio/iopopen.c (_IO_new_proc_open): use posix_spawn instead of fork and execl. --- ChangeLog | 4 ++ libio/iopopen.c | 105 ++++++++++++++++++++++++++++++------------------ 2 files changed, 70 insertions(+), 39 deletions(-) -- 2.17.1 diff --git a/libio/iopopen.c b/libio/iopopen.c index 2eff45b4c8..a2867abb02 100644 --- a/libio/iopopen.c +++ b/libio/iopopen.c @@ -34,7 +34,8 @@ #include #include #include -#include +#include +#include struct _IO_proc_file { @@ -63,9 +64,8 @@ FILE * _IO_new_proc_open (FILE *fp, const char *command, const char *mode) { int read_or_write; - int parent_end, child_end; int pipe_fds[2]; - pid_t child_pid; + int op; int do_read = 0; int do_write = 0; @@ -108,59 +108,86 @@ _IO_new_proc_open (FILE *fp, const char *command, const char *mode) if (do_read) { - parent_end = pipe_fds[0]; - child_end = pipe_fds[1]; + op = 0; read_or_write = _IO_NO_WRITES; } else { - parent_end = pipe_fds[1]; - child_end = pipe_fds[0]; + op = 1; read_or_write = _IO_NO_READS; } - ((_IO_proc_file *) fp)->pid = child_pid = __fork (); - if (child_pid == 0) - { - int child_std_end = do_read ? 1 : 0; - struct _IO_proc_file *p; - - if (child_end != child_std_end) - __dup2 (child_end, child_std_end); - else - /* The descriptor is already the one we will use. But it must - not be marked close-on-exec. Undo the effects. */ - __fcntl (child_end, F_SETFD, 0); - /* POSIX.2: "popen() shall ensure that any streams from previous - popen() calls that remain open in the parent process are closed - in the new child process." */ - for (p = proc_file_chain; p; p = p->next) - { - int fd = _IO_fileno ((FILE *) p); + { + posix_spawn_file_actions_t fa; + /* posix_spawn_file_actions_init does not fail. */ + __posix_spawn_file_actions_init (&fa); - /* If any stream from previous popen() calls has fileno - child_std_end, it has been already closed by the dup2 syscall - above. */ - if (fd != child_std_end) - __close_nocancel (fd); - } + /* The descriptor is already in the one the child will use. In this case + it must be moved to another one, otherwise there is no safe way to + remove the close-on-exec flag in the child without creating a FD leak + race in the parent. */ + if (pipe_fds[1 - op] == 1 - op) + { + int tmp = __fcntl (1 - op, F_DUPFD_CLOEXEC, 0); + if (tmp < 0) + goto spawn_failure; + __close_nocancel (pipe_fds[1 - op]); + pipe_fds[1 - op] = tmp; + } - execl ("/bin/sh", "sh", "-c", command, (char *) 0); - _exit (127); - } - __close_nocancel (child_end); - if (child_pid < 0) + if (__posix_spawn_file_actions_adddup2 (&fa, pipe_fds[1 - op], 1 - op) + != 0) + goto spawn_failure; + + /* POSIX.2: "popen() shall ensure that any streams from previous popen() + calls that remain open in the parent process are closed in the new + child process." */ +#ifdef _IO_MTSAFE_IO + _IO_cleanup_region_start_noarg (unlock); + _IO_lock_lock (proc_file_chain_lock); +#endif + for (struct _IO_proc_file *p = proc_file_chain; p; p = p->next) + { + int fd = _IO_fileno ((FILE *) p); + + /* If any stream from previous popen() calls has fileno + child_send, it has been already closed by the dup2 syscall + above. */ + if (fd != 1 - op + && __posix_spawn_file_actions_addclose (&fa, fd) != 0) + goto spawn_failure; + } +#ifdef _IO_MTSAFE_IO + _IO_lock_unlock (proc_file_chain_lock); + _IO_cleanup_region_end (0); +#endif + + if (__posix_spawn (&((_IO_proc_file *) fp)->pid, _PATH_BSHELL, &fa, 0, + (char *const[]){ (char*) "sh", (char*) "-c", + (char *) command, NULL }, __environ) != 0) + { + spawn_failure: + __posix_spawn_file_actions_destroy (&fa); + __close_nocancel (pipe_fds[1 - op]); + __set_errno (ENOMEM); + return NULL; + } + + __posix_spawn_file_actions_destroy (&fa); + } + __close_nocancel (pipe_fds[1 - op]); + if (((_IO_proc_file *) fp)->pid < 0) { - __close_nocancel (parent_end); + __close_nocancel (pipe_fds[op]); return NULL; } if (!do_cloexec) /* Undo the effects of the pipe2 call which set the close-on-exec flag. */ - __fcntl (parent_end, F_SETFD, 0); + __fcntl (pipe_fds[op], F_SETFD, 0); - _IO_fileno (fp) = parent_end; + _IO_fileno (fp) = pipe_fds[op]; /* Link into proc_file_chain. */ #ifdef _IO_MTSAFE_IO From patchwork Fri Oct 19 23:26:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 149357 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp3894543lji; Fri, 19 Oct 2018 16:26:47 -0700 (PDT) X-Google-Smtp-Source: ACcGV62FaTmoSJhU5cksMS3sfkHm9YNZ9MpEUAtAJOf7UhjeqJWMN0I+91uaJnRTuB0S2ogjbNrN X-Received: by 2002:a63:4745:: with SMTP id w5-v6mr35226324pgk.377.1539991607770; Fri, 19 Oct 2018 16:26:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539991607; cv=none; d=google.com; s=arc-20160816; b=h8okh5IQAbK/J7uELSk0CsPIJa2fkkV4DyKCtJcQfndff9gtg3o59APhb1/LoRQqUE LuetSrIubxASEK9SkKKcs1Cwzi5CHotXynznfKmnt4SkwOWkCpXHGrh6HjFKb9REO+/L Wz4a/tkcF8DI/teVpFZWmVrDaY/o/rNA+1OBtun/NULfl4knDDPP1HVOFbmVsToWjRVe o6c7INPMtCltURH8w4od1Vqy60YOfD+Zqqmd6RYYtMm0b1Tx2o+vct/hBDwWpzs8ZnPH 5EeKmKZ+wYiwKxykAOxdinH3TgVXQOTkleovA1GiHcwZ8t3OViVwdcssn2IQvScQxpl1 WpAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=6m1NQbD+uOOdGUdjtN/vSmJ0LUNFcEzgwrE5Q5wwGfY=; b=PzXaYrh+ebyWybc6JvH/0x4pLLvCxC1lQqhK9XK+2w9k4vOPOXpu39xIc5WI+lnqSw SZO+ACOx99yq/hjV6IMWKq4lqGXAddUUvO22YeSju7P3AMWEYJRNQ3J9hRhL1RZF5a6h 4Yn2G1j7ZqHcfT4V0nht/+biz8FdE5QCMW4Bs1AjptLGaXR+fJ7Atgmmx6vQGS4IV0e+ oQqw4CeK8MfidSWj613+Od8RyJm9hc0ytkhsHKtih79MlFrKDq2K08fpZrsPgPvJm7Ls Nlh8NSCge75cijoBVMdg9J2uB3pgFCiWaXs66lOujJXleWywLb8xF5HwqDibt4eilGqD 1KcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=OYXJ+lqW; dkim=pass header.i=@linaro.org header.s=google header.b=MlbDqjjm; spf=pass (google.com: domain of libc-alpha-return-96545-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-96545-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id 8-v6si26597319pfx.185.2018.10.19.16.26.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Oct 2018 16:26:47 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-96545-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=OYXJ+lqW; dkim=pass header.i=@linaro.org header.s=google header.b=MlbDqjjm; spf=pass (google.com: domain of libc-alpha-return-96545-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-96545-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=Vs/EoCcYxEY6fLYRYKHrF3/vQfbrFCg H56RoLat6dNyEMR/qllq/XZ0MDQMzlrvt2nke2lv/vly4mvraoBq6EZcpo1TY20S DntROplGHPN/uAWJZj1tdzXGboZUcKtXbGvgIrCisWoaGaSI0gIJy3Ic3bshgOX/ 5BN0RB4rdcOU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=vryvcprDjPorN5C+1Rc89mbA2aQ=; b=OYXJ+ lqWrOsNcDnc0DFOof8CnljecXltcxRm7NnUdNFTCLCvjlNa9kfWOeMYPmhsm72rA uXSAa0dBKxFF8Xs52ENGGbwyILVPD6mJKr4JbQNKItISBpVHrVOiBWaWiZYkVoiY SAYmeIkaaN7YvBcYsv8jIBFh1LreY7Un/mayUM= Received: (qmail 44583 invoked by alias); 19 Oct 2018 23:26:25 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 44474 invoked by uid 89); 19 Oct 2018 23:26:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Google-Smtp-Source:ACcGV60, 0x3, aims X-HELO: mail-qt1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=6m1NQbD+uOOdGUdjtN/vSmJ0LUNFcEzgwrE5Q5wwGfY=; b=MlbDqjjmiZBR1DosoVbUE4gnpIKTRvT/0PUsucBJ2tT0/uJjPami5tIUqchvS+TxQ3 T7/zDz9TmpaG8Xd7ci8UEFORviRvz7K7P/2fejkP8olNalSjpExvdVFKOstVk/xJGxnc iPjyewu16ovcG22ZiLVGR6J3DfmLu2wfVarvU= Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH v2 3/3] posix: Use posix_spawn on system Date: Fri, 19 Oct 2018 20:26:09 -0300 Message-Id: <20181019232609.25531-3-adhemerval.zanella@linaro.org> In-Reply-To: <20181019232609.25531-1-adhemerval.zanella@linaro.org> References: <20181019232609.25531-1-adhemerval.zanella@linaro.org> Changed from previous version: - Call __libc_signal_block_app for SPAWN_XFLAGS_ENABLE_CANCEL. --- This patch uses posix_spawn on system implementation. On Linux this has the advantage of much lower memory consumption (usually 32 Kb minimum for the mmap stack area). Although POSIX does not require, glibc system implementation aims to be thread and cancellation safe. While reentracy handling does not require any direct change of current strategy, cancellation requires a posix_spawn to be cancellable. This is done by adding an internal __posix_spawn_cancellable which does not disable cancellation neither change process signal mask. The cancellation code is also moved to generic implementation and enabled only if SIGCANCEL is defined (similar on how the cancellation handler is enabled on nptl-init.c). Checked on x86_64-linux-gnu and i686-linux-gnu. * include/spawn.h (__posix_spawn_cancellable): New prototype. * posix/spawn.c (__posix_spawn_cancellable): New function. * posix/spawn_int.h (SPAWN_XFLAGS_ENABLE_CANCEL): New define. * sysdeps/generic/not-errno.h (__kill_noerrno): New prototype. * sysdeps/unix/sysv/linux/not-errno.h (__kill_noerrno): New implementation. * sysdeps/posix/spawni.c (__spawnix): Disable cancellation for !SPAWN_XFLAGS_ENABLE_CANCEL. * sysdeps/unix/sysv/linux/spawni.c (__spawnix): Likewise. * sysdeps/posix/system.c [_LIBC_REENTRANT && SIGCANCEL] (cancel_handler): New function. (CLEANUP_HANDLER, CLEANUP_RESET): Likewise. (do_system): Use posix_spawn instead of fork and execl. * sysdeps/unix/sysv/linux/ia64/system.c: Remove file. * sysdeps/unix/sysv/linux/s390/system.c: Likewise. * sysdeps/unix/sysv/linux/sparc/system.c: Likewise. * sysdeps/unix/sysv/linux/system.c: Likewise. --- ChangeLog | 18 ++++ include/spawn.h | 2 + posix/spawn.c | 14 +++ posix/spawn_int.h | 1 + sysdeps/generic/not-errno.h | 2 + sysdeps/posix/spawni.c | 8 +- sysdeps/posix/system.c | 132 ++++++++++++++----------- sysdeps/unix/sysv/linux/ia64/system.c | 30 ------ sysdeps/unix/sysv/linux/not-errno.h | 13 +++ sysdeps/unix/sysv/linux/s390/system.c | 29 ------ sysdeps/unix/sysv/linux/sparc/system.c | 29 ------ sysdeps/unix/sysv/linux/spawni.c | 22 +++-- sysdeps/unix/sysv/linux/system.c | 76 -------------- 13 files changed, 145 insertions(+), 231 deletions(-) delete mode 100644 sysdeps/unix/sysv/linux/ia64/system.c delete mode 100644 sysdeps/unix/sysv/linux/s390/system.c delete mode 100644 sysdeps/unix/sysv/linux/sparc/system.c delete mode 100644 sysdeps/unix/sysv/linux/system.c -- 2.17.1 diff --git a/include/spawn.h b/include/spawn.h index 7fdd965bd7..995ab9a8f4 100644 --- a/include/spawn.h +++ b/include/spawn.h @@ -5,6 +5,8 @@ __typeof (posix_spawn) __posix_spawn; libc_hidden_proto (__posix_spawn) +__typeof (posix_spawn) __posix_spawn_cancellable attribute_hidden; + __typeof (posix_spawn_file_actions_addclose) __posix_spawn_file_actions_addclose attribute_hidden; diff --git a/posix/spawn.c b/posix/spawn.c index a82f1c84e2..24a416f53c 100644 --- a/posix/spawn.c +++ b/posix/spawn.c @@ -33,6 +33,20 @@ versioned_symbol (libc, __posix_spawn, posix_spawn, GLIBC_2_15); libc_hidden_def (__posix_spawn) +/* Same as __posix_spawn but allows asynchronous cancellation. It is used + internally on SYSTEM implementation to avoid leak a process ID through + a cancellation handler. */ +int +__posix_spawn_cancellable (pid_t *pid, const char *path, + const posix_spawn_file_actions_t *file_actions, + const posix_spawnattr_t *attrp, char *const argv[], + char *const envp[]) +{ + return __spawni (pid, path, file_actions, attrp, argv, envp, + SPAWN_XFLAGS_ENABLE_CANCEL); +} + + #if SHLIB_COMPAT (libc, GLIBC_2_2, GLIBC_2_15) int attribute_compat_text_section diff --git a/posix/spawn_int.h b/posix/spawn_int.h index 171f67c649..5cb8ce49b3 100644 --- a/posix/spawn_int.h +++ b/posix/spawn_int.h @@ -55,6 +55,7 @@ struct __spawn_action #define SPAWN_XFLAGS_USE_PATH 0x1 #define SPAWN_XFLAGS_TRY_SHELL 0x2 +#define SPAWN_XFLAGS_ENABLE_CANCEL 0x3 extern int __posix_spawn_file_actions_realloc (posix_spawn_file_actions_t * file_actions) diff --git a/sysdeps/generic/not-errno.h b/sysdeps/generic/not-errno.h index 93617a3266..0fd66b5c5e 100644 --- a/sysdeps/generic/not-errno.h +++ b/sysdeps/generic/not-errno.h @@ -17,3 +17,5 @@ . */ extern __typeof (__access) __access_noerrno attribute_hidden; + +extern __typeof (__kill) __kill_noerrno attribute_hidden; diff --git a/sysdeps/posix/spawni.c b/sysdeps/posix/spawni.c index b138ab4393..e1a391659b 100644 --- a/sysdeps/posix/spawni.c +++ b/sysdeps/posix/spawni.c @@ -256,8 +256,9 @@ __spawnix (pid_t *pid, const char *file, /* Disable asynchronous cancellation. */ int state; - __libc_ptf_call (__pthread_setcancelstate, - (PTHREAD_CANCEL_DISABLE, &state), 0); + if ((xflags & SPAWN_XFLAGS_ENABLE_CANCEL) == 0) + __libc_ptf_call (__pthread_setcancelstate, + (PTHREAD_CANCEL_DISABLE, &state), 0); ptrdiff_t argc = 0; ptrdiff_t limit = INT_MAX - 1; @@ -299,7 +300,8 @@ __spawnix (pid_t *pid, const char *file, if ((ec == 0) && (pid != NULL)) *pid = new_pid; - __libc_ptf_call (__pthread_setcancelstate, (state, NULL), 0); + if ((xflags & SPAWN_XFLAGS_ENABLE_CANCEL) == 0) + __libc_ptf_call (__pthread_setcancelstate, (state, NULL), 0); return ec; } diff --git a/sysdeps/posix/system.c b/sysdeps/posix/system.c index d7594436ed..38d5e28ca2 100644 --- a/sysdeps/posix/system.c +++ b/sysdeps/posix/system.c @@ -17,20 +17,22 @@ #include #include -#include #include #include +#include +#include +#include #include #include -#include -#include -#include +#include +#include +#include +#include #define SHELL_PATH "/bin/sh" /* Path of the shell. */ #define SHELL_NAME "sh" /* Name to give it. */ - #ifdef _LIBC_REENTRANT static struct sigaction intr, quit; static int sa_refcntr; @@ -38,17 +40,53 @@ __libc_lock_define_initialized (static, lock); # define DO_LOCK() __libc_lock_lock (lock) # define DO_UNLOCK() __libc_lock_unlock (lock) -# define INIT_LOCK() ({ __libc_lock_init (lock); sa_refcntr = 0; }) # define ADD_REF() sa_refcntr++ # define SUB_REF() --sa_refcntr + #else # define DO_LOCK() # define DO_UNLOCK() -# define INIT_LOCK() # define ADD_REF() 0 # define SUB_REF() 0 #endif +/* We have to and actually can handle cancelable system(). The big + problem: we have to kill the child process if necessary. To do + this a cleanup handler has to be registered and is has to be able + to find the PID of the child. The main problem is to reliable have + the PID when needed. It is not necessary for the parent thread to + return. It might still be in the kernel when the cancellation + request comes. Therefore we have to use the clone() calls ability + to have the kernel write the PID into the user-level variable. */ + +#if defined(_LIBC_REENTRANT) && defined(SIGCANCEL) +static void cancel_handler (void *arg) +{ + pid_t child = *(pid_t *) arg; + + __kill_noerrno (child, SIGKILL); + + TEMP_FAILURE_RETRY (__waitpid (child, NULL, 0)); + + DO_LOCK (); + + if (SUB_REF () == 0) + { + __sigaction (SIGQUIT, &quit, NULL); + __sigaction (SIGINT, &intr, NULL); + } + + DO_UNLOCK (); +} +# define CLEANUP_HANDLER() \ + __libc_cleanup_region_start (1, cancel_handler, &pid) +# define CLEANUP_RESET() \ + __libc_cleanup_region_end (0) +#else +# define CLEANUP_HANDLER() +# define CLEANUP_RESET() +#endif + /* Execute LINE as a shell command, returning its status. */ static int @@ -60,7 +98,9 @@ do_system (const char *line) #ifndef _LIBC_REENTRANT struct sigaction intr, quit; #endif + struct sigaction oldintr, oldquit; sigset_t omask; + sigset_t reset; sa.sa_handler = SIG_IGN; sa.sa_flags = 0; @@ -98,9 +138,9 @@ do_system (const char *line) if (SUB_REF () == 0) { save = errno; - (void) __sigaction (SIGQUIT, &quit, (struct sigaction *) NULL); + __sigaction (SIGQUIT, &quit, &oldquit); out_restore_sigint: - (void) __sigaction (SIGINT, &intr, (struct sigaction *) NULL); + __sigaction (SIGINT, &intr, &oldintr); __set_errno (save); } out: @@ -109,39 +149,30 @@ do_system (const char *line) } } -#ifdef CLEANUP_HANDLER - CLEANUP_HANDLER; -#endif - -#ifdef FORK - pid = FORK (); -#else - pid = __fork (); -#endif - if (pid == (pid_t) 0) - { - /* Child side. */ - const char *new_argv[4]; - new_argv[0] = SHELL_NAME; - new_argv[1] = "-c"; - new_argv[2] = line; - new_argv[3] = NULL; - - /* Restore the signals. */ - (void) __sigaction (SIGINT, &intr, (struct sigaction *) NULL); - (void) __sigaction (SIGQUIT, &quit, (struct sigaction *) NULL); - (void) __sigprocmask (SIG_SETMASK, &omask, (sigset_t *) NULL); - INIT_LOCK (); - - /* Exec the shell. */ - (void) __execve (SHELL_PATH, (char *const *) new_argv, __environ); - _exit (127); - } - else if (pid < (pid_t) 0) - /* The fork failed. */ - status = -1; - else - /* Parent side. */ + __sigemptyset (&reset); + if (oldintr.sa_handler != SIG_IGN) + __sigaddset(&reset, SIGINT); + if (oldquit.sa_handler != SIG_IGN) + __sigaddset(&reset, SIGQUIT); + + posix_spawnattr_t spawn_attr; + /* None of the posix_spawnattr_* function returns, including + posix_spawnattr_setflags for the follow specific usage (using valid + flags). */ + __posix_spawnattr_init (&spawn_attr); + __posix_spawnattr_setsigmask (&spawn_attr, &omask); + __posix_spawnattr_setsigdefault (&spawn_attr, &reset); + __posix_spawnattr_setflags (&spawn_attr, + POSIX_SPAWN_SETSIGDEF | POSIX_SPAWN_SETSIGMASK); + + CLEANUP_HANDLER (); + status = __posix_spawn_cancellable (&pid, SHELL_PATH, 0, &spawn_attr, + (char *const[]){ (char*) SHELL_NAME, + (char*) "-c", + (char *) line, NULL }, + __environ); + __posix_spawnattr_destroy (&spawn_attr); + if (status == 0) { /* Note the system() is a cancellation point. But since we call waitpid() which itself is a cancellation point we do not @@ -149,25 +180,16 @@ do_system (const char *line) if (TEMP_FAILURE_RETRY (__waitpid (pid, &status, 0)) != pid) status = -1; } - -#ifdef CLEANUP_HANDLER - CLEANUP_RESET; -#endif + CLEANUP_RESET (); save = errno; DO_LOCK (); if ((SUB_REF () == 0 - && (__sigaction (SIGINT, &intr, (struct sigaction *) NULL) - | __sigaction (SIGQUIT, &quit, (struct sigaction *) NULL)) != 0) + && (__sigaction (SIGINT, &intr, NULL) + | __sigaction (SIGQUIT, &quit, NULL)) != 0) || __sigprocmask (SIG_SETMASK, &omask, (sigset_t *) NULL) != 0) { -#ifndef _LIBC - /* glibc cannot be used on systems without waitpid. */ - if (errno == ENOSYS) - __set_errno (save); - else -#endif - status = -1; + status = -1; } DO_UNLOCK (); diff --git a/sysdeps/unix/sysv/linux/ia64/system.c b/sysdeps/unix/sysv/linux/ia64/system.c deleted file mode 100644 index d09fefefe6..0000000000 --- a/sysdeps/unix/sysv/linux/ia64/system.c +++ /dev/null @@ -1,30 +0,0 @@ -/* Copyright (C) 2002-2018 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - . */ - -/* We have to and actually can handle cancelable system(). The big - problem: we have to kill the child process if necessary. To do - this a cleanup handler has to be registered and is has to be able - to find the PID of the child. The main problem is to reliable have - the PID when needed. It is not necessary for the parent thread to - return. It might still be in the kernel when the cancellation - request comes. Therefore we have to use the clone() calls ability - to have the kernel write the PID into the user-level variable. */ -#define FORK() \ - INLINE_SYSCALL (clone2, 6, CLONE_PARENT_SETTID | SIGCHLD, NULL, 0, \ - &pid, NULL, NULL) - -#include diff --git a/sysdeps/unix/sysv/linux/not-errno.h b/sysdeps/unix/sysv/linux/not-errno.h index 106ba5c72e..4c5ae1a4c2 100644 --- a/sysdeps/unix/sysv/linux/not-errno.h +++ b/sysdeps/unix/sysv/linux/not-errno.h @@ -16,6 +16,8 @@ License along with the GNU C Library; if not, see . */ +#include + /* This function is used on maybe_enable_malloc_check (elf/dl-tunables.c) and to avoid having to build/use multiple versions if stack protection in enabled it is defined as inline. */ @@ -33,3 +35,14 @@ __access_noerrno (const char *pathname, int mode) return INTERNAL_SYSCALL_ERRNO (res, err); return 0; } + +static inline int +__kill_noerrno (pid_t pid, int sig) +{ + int res; + INTERNAL_SYSCALL_DECL (err); + res = INTERNAL_SYSCALL_CALL (kill, err, pid, sig); + if (INTERNAL_SYSCALL_ERROR_P (res, err)) + return INTERNAL_SYSCALL_ERRNO (res, err); + return 0; +} diff --git a/sysdeps/unix/sysv/linux/s390/system.c b/sysdeps/unix/sysv/linux/s390/system.c deleted file mode 100644 index d8ef461334..0000000000 --- a/sysdeps/unix/sysv/linux/s390/system.c +++ /dev/null @@ -1,29 +0,0 @@ -/* Copyright (C) 2003-2018 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - . */ - -/* We have to and actually can handle cancelable system(). The big - problem: we have to kill the child process if necessary. To do - this a cleanup handler has to be registered and is has to be able - to find the PID of the child. The main problem is to reliable have - the PID when needed. It is not necessary for the parent thread to - return. It might still be in the kernel when the cancellation - request comes. Therefore we have to use the clone() calls ability - to have the kernel write the PID into the user-level variable. */ -#define FORK() \ - INLINE_SYSCALL (clone, 3, 0, CLONE_PARENT_SETTID | SIGCHLD, &pid) - -#include "../system.c" diff --git a/sysdeps/unix/sysv/linux/sparc/system.c b/sysdeps/unix/sysv/linux/sparc/system.c deleted file mode 100644 index 1f65c83399..0000000000 --- a/sysdeps/unix/sysv/linux/sparc/system.c +++ /dev/null @@ -1,29 +0,0 @@ -/* Copyright (C) 2003-2018 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - . */ - -/* We have to and actually can handle cancelable system(). The big - problem: we have to kill the child process if necessary. To do - this a cleanup handler has to be registered and is has to be able - to find the PID of the child. The main problem is to reliable have - the PID when needed. It is not necessary for the parent thread to - return. It might still be in the kernel when the cancellation - request comes. Therefore we have to use the clone() calls ability - to have the kernel write the PID into the user-level variable. */ -#define FORK() \ - INLINE_CLONE_SYSCALL (CLONE_PARENT_SETTID | SIGCHLD, 0, &pid, NULL, NULL) - -#include "../system.c" diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c index 85239cedbf..7f17fb2f89 100644 --- a/sysdeps/unix/sysv/linux/spawni.c +++ b/sysdeps/unix/sysv/linux/spawni.c @@ -138,11 +138,11 @@ __spawni_child (void *arguments) for (int sig = 1; sig < _NSIG; ++sig) { if ((attr->__flags & POSIX_SPAWN_SETSIGDEF) - && sigismember (&attr->__sd, sig)) + && __sigismember (&attr->__sd, sig)) { sa.sa_handler = SIG_DFL; } - else if (sigismember (&hset, sig)) + else if (__sigismember (&hset, sig)) { if (__is_internal_signal (sig)) sa.sa_handler = SIG_IGN; @@ -330,10 +330,16 @@ __spawnix (pid_t * pid, const char *file, if (__glibc_unlikely (stack == MAP_FAILED)) return errno; - /* Disable asynchronous cancellation. */ int state; - __libc_ptf_call (__pthread_setcancelstate, - (PTHREAD_CANCEL_DISABLE, &state), 0); + if (xflags & SPAWN_XFLAGS_ENABLE_CANCEL) + __libc_signal_block_app (&args.oldmask); + else + { + /* Disable asynchronous cancellation. */ + __libc_ptf_call (__pthread_setcancelstate, + (PTHREAD_CANCEL_DISABLE, &state), 0); + __libc_signal_block_all (&args.oldmask); + } /* Child must set args.err to something non-negative - we rely on the parent and child sharing VM. */ @@ -347,8 +353,6 @@ __spawnix (pid_t * pid, const char *file, args.envp = envp; args.xflags = xflags; - __libc_signal_block_all (&args.oldmask); - /* The clone flags used will create a new child that will run in the same memory space (CLONE_VM) and the execution of calling thread will be suspend until the child calls execve or _exit. @@ -390,8 +394,8 @@ __spawnix (pid_t * pid, const char *file, *pid = new_pid; __libc_signal_restore_set (&args.oldmask); - - __libc_ptf_call (__pthread_setcancelstate, (state, NULL), 0); + if ((xflags & SPAWN_XFLAGS_ENABLE_CANCEL) == 0) + __libc_ptf_call (__pthread_setcancelstate, (state, NULL), 0); return ec; } diff --git a/sysdeps/unix/sysv/linux/system.c b/sysdeps/unix/sysv/linux/system.c deleted file mode 100644 index 7cc68a1528..0000000000 --- a/sysdeps/unix/sysv/linux/system.c +++ /dev/null @@ -1,76 +0,0 @@ -/* Copyright (C) 2002-2018 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - . */ - -#include -#include -#include /* For the real memset prototype. */ -#include -#include -#include -#include - -/* We have to and actually can handle cancelable system(). The big - problem: we have to kill the child process if necessary. To do - this a cleanup handler has to be registered and is has to be able - to find the PID of the child. The main problem is to reliable have - the PID when needed. It is not necessary for the parent thread to - return. It might still be in the kernel when the cancellation - request comes. Therefore we have to use the clone() calls ability - to have the kernel write the PID into the user-level variable. */ -#ifndef FORK -# define FORK() \ - INLINE_SYSCALL (clone, 3, CLONE_PARENT_SETTID | SIGCHLD, 0, &pid) -#endif - -#ifdef _LIBC_REENTRANT -static void cancel_handler (void *arg); - -# define CLEANUP_HANDLER \ - __libc_cleanup_region_start (1, cancel_handler, &pid) - -# define CLEANUP_RESET \ - __libc_cleanup_region_end (0) -#endif - - -/* Linux has waitpid(), so override the generic unix version. */ -#include - - -#ifdef _LIBC_REENTRANT -/* The cancellation handler. */ -static void -cancel_handler (void *arg) -{ - pid_t child = *(pid_t *) arg; - - INTERNAL_SYSCALL_DECL (err); - INTERNAL_SYSCALL (kill, err, 2, child, SIGKILL); - - TEMP_FAILURE_RETRY (__waitpid (child, NULL, 0)); - - DO_LOCK (); - - if (SUB_REF () == 0) - { - (void) __sigaction (SIGQUIT, &quit, (struct sigaction *) NULL); - (void) __sigaction (SIGINT, &intr, (struct sigaction *) NULL); - } - - DO_UNLOCK (); -} -#endif