From patchwork Thu Nov 1 16:17:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 149978 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp986508ljp; Thu, 1 Nov 2018 09:20:00 -0700 (PDT) X-Google-Smtp-Source: AJdET5fuBSaOWax735igQFrd7cKRKOUB56p00Xn1Op70WwGi75uQ3+wQlbDdKbQEZHRrepLg5Awe X-Received: by 2002:a0c:f184:: with SMTP id m4mr1953860qvl.178.1541089200164; Thu, 01 Nov 2018 09:20:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541089200; cv=none; d=google.com; s=arc-20160816; b=RhD/hnAGckEvZ6abMByOHjKrsBl5XtLS8m1lgsWvz+GcPGCmq+TS5HwrFIZz+stoS2 Rw6oaO76ATtHyFB7rzaJ1RznNqstkQNEy+XG+0pzloB4365pVS7qwC3nomcbp496ZKaf xTWWcCabknUYq3sBR0mITH71lTi0V7Orz5OIVOkOZ5/WR/KmFl9Ek52VmTptQbDgRi8e MwiluyHzZedKpWSFTvgxqQAsQ0Xsn93styxN3RRD5TMC/Lurd1XOcEciafKzDrsPPmfD p2c+44AGKenCSkh+42mrGceehklhv5EGIb8MFW9Ur2UHil10X8tDzfO0Or49Y85tDr/4 C9Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from; bh=vIRCUaAZridyw/l/khnH7lHLhuRdTOKoNstqRoITDpE=; b=aTywS327iF95CDKi60vDvQ0lVbLGetJLA00636XheWJs0+fpy9sw1m5Hbj5Fw6v0tM hyvlwjtaqvjbCsalm9dfAm2VWMjC/wlf/rAhOSqWCKRpQsQ9k/m0phjrw+NS6Q1t9PYr N84IsD8egidfio5vYnQ4cnImr6CnIpbXLpcUZZkRr4ctsI+6xEcfxiIil0k/SsT6LngG zDj8jcNGCmmuVtNmc8KGIsMoobjL0JKebkLfUgdnOarHPEv9rmfnNwhssaot/6eu48/c 3RMWRLbhc+7uwLnvKgQzO2RnlAkw5HDJYzLP7tuvcrGDXhtuFJ18Ap9evMJwLHTW9Jc9 VkQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id g88si1172433qva.79.2018.11.01.09.19.59 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 01 Nov 2018 09:20:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIFhP-0008Gn-Nk for patch@linaro.org; Thu, 01 Nov 2018 12:19:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIFfe-00076q-DC for qemu-devel@nongnu.org; Thu, 01 Nov 2018 12:18:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIFfd-00024t-Lx for qemu-devel@nongnu.org; Thu, 01 Nov 2018 12:18:10 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:52192) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gIFfd-00023M-FI; Thu, 01 Nov 2018 12:18:09 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1gIFfV-0002rh-3d; Thu, 01 Nov 2018 16:18:01 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 1 Nov 2018 16:17:58 +0000 Message-Id: <20181101161758.12300-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PATCH for-3.1] hw/ppc/mac_newworld: Free openpic_irqs array after use X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" In ppc_core99_init(), we allocate an openpic_irqs array, which we then use to collect up the various qemu_irqs which we're going to connect to the interrupt controller. Once we've called sysbus_connect_irq() to connect them all up, the array is no longer required, but we forgot to free it. Since board init is only run once at startup, the memory leak is not a significant one. Spotted by Coverity: CID 1192916. Signed-off-by: Peter Maydell --- hw/ppc/mac_newworld.c | 1 + 1 file changed, 1 insertion(+) -- 2.19.1 Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c index a630cb81cd8..14273a123e5 100644 --- a/hw/ppc/mac_newworld.c +++ b/hw/ppc/mac_newworld.c @@ -303,6 +303,7 @@ static void ppc_core99_init(MachineState *machine) sysbus_connect_irq(s, k++, openpic_irqs[i][j]); } } + g_free(openpic_irqs); if (PPC_INPUT(env) == PPC_FLAGS_INPUT_970) { /* 970 gets a U3 bus */