From patchwork Thu Sep 16 15:33:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Cai,Huoqing" X-Patchwork-Id: 513303 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5240AC433FE for ; Thu, 16 Sep 2021 15:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E48361246 for ; Thu, 16 Sep 2021 15:48:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240123AbhIPPuO (ORCPT ); Thu, 16 Sep 2021 11:50:14 -0400 Received: from mx24.baidu.com ([111.206.215.185]:45106 "EHLO baidu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S240119AbhIPPuM (ORCPT ); Thu, 16 Sep 2021 11:50:12 -0400 Received: from BC-Mail-Ex23.internal.baidu.com (unknown [172.31.51.17]) by Forcepoint Email with ESMTPS id B4C5DE97F8BD8513450B; Thu, 16 Sep 2021 23:33:09 +0800 (CST) Received: from BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) by BC-Mail-Ex23.internal.baidu.com (172.31.51.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2242.12; Thu, 16 Sep 2021 23:33:09 +0800 Received: from LAPTOP-UKSR4ENP.internal.baidu.com (172.31.63.8) by BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 16 Sep 2021 23:33:09 +0800 From: Cai Huoqing To: CC: Dmitry Torokhov , , Subject: [PATCH] Input: ps2-gpio - Make use of the helper function dev_err_probe() Date: Thu, 16 Sep 2021 23:33:03 +0800 Message-ID: <20210916153304.14575-1-caihuoqing@baidu.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [172.31.63.8] X-ClientProxiedBy: BC-Mail-Ex11.internal.baidu.com (172.31.51.51) To BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/input/serio/ps2-gpio.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c index 8970b49ea09a..d46355f868fd 100644 --- a/drivers/input/serio/ps2-gpio.c +++ b/drivers/input/serio/ps2-gpio.c @@ -323,18 +323,14 @@ static int ps2_gpio_get_props(struct device *dev, struct ps2_gpio_data *drvdata) { drvdata->gpio_data = devm_gpiod_get(dev, "data", GPIOD_IN); - if (IS_ERR(drvdata->gpio_data)) { - dev_err(dev, "failed to request data gpio: %ld", - PTR_ERR(drvdata->gpio_data)); - return PTR_ERR(drvdata->gpio_data); - } + if (IS_ERR(drvdata->gpio_data)) + return dev_err_probe(dev, PTR_ERR(drvdata->gpio_data), + "failed to request data gpio: %ld") drvdata->gpio_clk = devm_gpiod_get(dev, "clk", GPIOD_IN); - if (IS_ERR(drvdata->gpio_clk)) { - dev_err(dev, "failed to request clock gpio: %ld", - PTR_ERR(drvdata->gpio_clk)); - return PTR_ERR(drvdata->gpio_clk); - } + if (IS_ERR(drvdata->gpio_clk)) + return dev_err_probe(dev, PTR_ERR(drvdata->gpio_clk), + "failed to request clock gpio"); drvdata->write_enable = device_property_read_bool(dev, "write-enable");