From patchwork Thu Jan 6 23:55:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 530368 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7121C4332F for ; Thu, 6 Jan 2022 23:53:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343575AbiAFXxm (ORCPT ); Thu, 6 Jan 2022 18:53:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343574AbiAFXxg (ORCPT ); Thu, 6 Jan 2022 18:53:36 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8675CC061245 for ; Thu, 6 Jan 2022 15:53:35 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id i22so7789595wrb.13 for ; Thu, 06 Jan 2022 15:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NN+qWCSZGy/v8XPK3GfGhOOy6vI+oH7th5UvnDASdeQ=; b=MyowuYeOH+dlLfDjZE5uaUcBxPTnfRBRICJOh5t/czuU+VLaZClLX0ohrlh4pzeWeS cfrAchsJsVrx5ujwif5l1fEgePWTePxsL5hlB6fG6TL+wi0CcaKkRtXhcIUcLbdmTSRM F02fFy4+EQ027mMrz1sRvilM7Y5WXRbP+xzEcFfTJFoNHvJz0REH3Xjn/PwX2FJNIm/6 F0uhHpt267opCx4VdDiiLXiYZMaozT/dGF+MBUuU+46ePm4In6nvE8qLUV/VIviMz7X0 3yEzDMfliA2rQpFgfRsD5OEolORWBBPJS0lc5pDykLL77J5JxNeaZCe7jorZ9Z6aw9Qz 71bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NN+qWCSZGy/v8XPK3GfGhOOy6vI+oH7th5UvnDASdeQ=; b=5iuqDRtd0ai+KV8QpgczFY/Asj5xw0XT0uZh1xU3vwBueV4E+J0I43XkcvF28BgDl2 sejIAIGHkeulKTQVcuNQ5lTQ73Ltg5x2quuCngy0Y/Mor+ljSb9pLeFhKABk+W7fxtrp WSvbJ0MH+V2AHOymfHDT3ZI8C84Y32ij2ddVyz8/48Q1yzWlGt6oIPkaPmIglx8UHhHt VE8xVjKdW/tUo9k1yvMJJZgmCLQnTwcgep+/Zs+DzL0lfJjPknkV0zrUru+FffWbuSIi PQ32sJiWV/975Sq8SnnjbyURwdKypZ/yFfHXxVpMM6B2FP8Lf0+flj9oyr0tZt4E9Epe et/Q== X-Gm-Message-State: AOAM532gVEyfnK4Yih0ZARkzHQenXQiC59LMphmiBOwvgU7AEzXJL4uH tY8YVkl9SmHXNobu6VP9EIadXUu7RnD0uQ== X-Google-Smtp-Source: ABdhPJxo7KxNxf9vEXrXR73eO9AbU/jeJeEHVVTtG45Z4QKqPgIYmCvY4Fbjp+8dKbnYqnw/KWhsmg== X-Received: by 2002:a5d:65c9:: with SMTP id e9mr3555246wrw.661.1641513213897; Thu, 06 Jan 2022 15:53:33 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id a71sm335893wme.39.2022.01.06.15.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 15:53:33 -0800 (PST) From: Bryan O'Donoghue To: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, hverkuil@xs4all.nl, robert.foss@linaro.org Cc: jonathan@marek.ca, andrey.konovalov@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, jgrahsl@snap.com, hfink@snap.com, vladimir.zapolskiy@linaro.org, dmitry.baryshkov@linaro.org, bryan.odonoghue@linaro.org, devicetree@vger.kernel.org, robh@kernel.org Subject: [PATCH 2/7] media: dt-bindings: media: camss: Add vdda supply declarations sm8250 Date: Thu, 6 Jan 2022 23:55:35 +0000 Message-Id: <20220106235540.1567839-3-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220106235540.1567839-1-bryan.odonoghue@linaro.org> References: <20220106235540.1567839-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add in missing vdda-phy-supply and vdda-pll-supply declarations. The sm8250 USB, PCIe, UFS, DSI and CSI PHYs use a common set of vdda rails. Define the CSI vdda regulators in the same way the qmp PHY does. Cc: devicetree@vger.kernel.org Cc: robh@kernel.org Signed-off-by: Bryan O'Donoghue --- .../bindings/media/qcom,sm8250-camss.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml index af877d61b607d..07a2af12f37df 100644 --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml @@ -265,6 +265,14 @@ properties: - const: vfe_lite0 - const: vfe_lite1 + vdda-phy-supply: + description: + Phandle to a regulator supply to PHY core block. + + vdda-pll-supply: + description: + Phandle to 1.8V regulator supply to PHY refclk pll block. + required: - clock-names - clocks @@ -277,6 +285,8 @@ required: - power-domains - reg - reg-names + - vdda-phy-supply + - vdda-pll-supply additionalProperties: false @@ -316,6 +326,9 @@ examples: "vfe_lite0", "vfe_lite1"; + vdda-phy-supply = <&vreg_l5a_0p88>; + vdda-pll-supply = <&vreg_l9a_1p2>; + interrupts = , , , From patchwork Thu Jan 6 23:55:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 530367 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E5CBC433EF for ; Thu, 6 Jan 2022 23:53:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343619AbiAFXxq (ORCPT ); Thu, 6 Jan 2022 18:53:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343584AbiAFXxi (ORCPT ); Thu, 6 Jan 2022 18:53:38 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12655C034001 for ; Thu, 6 Jan 2022 15:53:38 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id r10so167651wrc.3 for ; Thu, 06 Jan 2022 15:53:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cmFENN6DpfU2w2rL3CjvPLwaJNNz4VsyBwG74nM5M44=; b=zUfhr6sav/maZtnP9i/JC5E/7dr0f9dGHSMAyCcPznMDdQRq3pdIuRG31d3vDW/DO/ Eh7rNOKQ8SsycNZFLrkm4/EsUr42xMCBKBrpaES7Y4RLufFoxTqrzOIKdcv5nwY25pqt mQivjVZPoPmKMWB1vXPMAgig08hegddrmxViDAJThX9iOb679J2pRc6raOU1y71Mhi61 2CvllXtZ4SmYRuSP+bYhIn0jddXCxKkSkhVwXyI6PIs4kAD39ZkVKVeetWgGdv2BE8w5 fh483m7gOf/DkAY57jfAYF+8v1/2iHqC7U3nkORoJoskuWq0Ctvqv1RPdig7t6felokq rYWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cmFENN6DpfU2w2rL3CjvPLwaJNNz4VsyBwG74nM5M44=; b=rCLqYiYfd4bcfr7QEa2M1wyMQmiEyJ7DY7+yR2z+B/ZFg6H5etdoRLYLHBlBBjsbyC 66H3JkVtTIBZ73gpVHCYjHT7dL7uDyyRWWkocoTusnciVz7YsNZpKxNFqV2C6PNaw3GG rSUFjGjRfbqEClSgSc30SNQ+fWwXMVlT19Snp8L6yiAZo3n1jyjy3J7nkolLRV4ytleQ SAqnl+1GSTMYr1GCiJhBFOtxhYSFFRfhGWAZDUjagV/CqC75uvaVWF0gjn9OEXyPPeoO RXcG50OX17dq/2c+o++2SJNPaRiqYadSUAny55Ov8c/iD5l+uJ4rMvdSqeBcy/qFMVGL a5lw== X-Gm-Message-State: AOAM533d6AlJeAkj9fxoEFHrtTUKcdCBEWQngxxwiaOsobbUJvgHlzvY oci+dFhF3XYXOu2/Q6VYxy0Jy4ijjROtYg== X-Google-Smtp-Source: ABdhPJzKFnQV7XhqXPsX/KMievHHwXmjdo/Bagi2gCQ4gxBVDyNaAYfRnuNTyuqtc56tJ/PU5X4qYQ== X-Received: by 2002:adf:fa4d:: with SMTP id y13mr8348924wrr.278.1641513216402; Thu, 06 Jan 2022 15:53:36 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id a71sm335893wme.39.2022.01.06.15.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 15:53:35 -0800 (PST) From: Bryan O'Donoghue To: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, hverkuil@xs4all.nl, robert.foss@linaro.org Cc: jonathan@marek.ca, andrey.konovalov@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, jgrahsl@snap.com, hfink@snap.com, vladimir.zapolskiy@linaro.org, dmitry.baryshkov@linaro.org, bryan.odonoghue@linaro.org Subject: [PATCH 4/7] arm64: dts: qcom: sdm845: Add camss vdda-pll-supply Date: Thu, 6 Jan 2022 23:55:37 +0000 Message-Id: <20220106235540.1567839-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220106235540.1567839-1-bryan.odonoghue@linaro.org> References: <20220106235540.1567839-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add in the missing vdda-pll-supply rail description. Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index c4db88dbf8766..f7bfd69b13620 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -1116,6 +1116,7 @@ &cci { &camss { vdda-phy-supply = <&vreg_l1a_0p875>; + vdda-pll-supply = <&vreg_l26a_1p2>; status = "ok"; From patchwork Thu Jan 6 23:55:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 530366 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C1F3C433F5 for ; Thu, 6 Jan 2022 23:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343583AbiAFXxs (ORCPT ); Thu, 6 Jan 2022 18:53:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343598AbiAFXxl (ORCPT ); Thu, 6 Jan 2022 18:53:41 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61F73C0611FD for ; Thu, 6 Jan 2022 15:53:40 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id d187-20020a1c1dc4000000b003474b4b7ebcso1372220wmd.5 for ; Thu, 06 Jan 2022 15:53:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f0/jP+wtHGnEZCaZ9/FXXw65LhXfTFFCKBh0r3UhICg=; b=Dv/yut/JRt/ZVOjBgbZq7X4t3JU2hRhepXqMSK2lfvZyKE7pYV3PumP/JwIpJ4s4h7 a47lxKxlab97q0smmBcqmni1J00ZO9ibnRe4OuAi8dRI36MJmNeRUimQDRIG/x8vA/tr NuksPEMIR01ZKSV+i/t8wn5oQCGLtUUPFnHWZ/xgC03Bk7Ro9wH0bYVguDagtuz9mYBa hVuNpWL+SdrCi6wTxj1mjcgRUbAnnvmmZ9mkaosCsYen20yXbsWClJRNZGAOO8OzAeX1 UQ2HjN4FlUF1cTZk8lbjtGwtDYK4joFAgM+FNmYiPdS3PN69IUSjuNOKECg1/6Y+36pi 5fsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f0/jP+wtHGnEZCaZ9/FXXw65LhXfTFFCKBh0r3UhICg=; b=TyhcPDNoNCR4nCByoaTAekzl7l78qB2eR7Fa30oN+dHqTF0YwmvAIgxKWhzWmtRl4M 0zx5G7heHTOe03d5nkRInMtMOchs++3w08s+PnTROepzLceBnopgPEgtqqnyAbgmJE1i x1Ne4fm6ayBSQnmGMSWI16N+5AheXR3fMHAC8q2NrVL6T6BvrrvQvoteyTSIDU7K4epS CUAU84GsLZUlrd7szJBW6s0a0cCWK50vsu/7YZNq3BtMegpugEaEx2Yp4DmdwIQZkqO6 wyrhK354F2I8jICQ3Mmqh4YJEswMFLm46uI17LnOBt39uMqGoPy949LToDFcE76Ni6YS PGYA== X-Gm-Message-State: AOAM532S0ouFKMAwVQrnTsr0kyyKezPmJaF1kb+iXd+fYorgKRQZe+50 XkEERDV9DX9YeqI5S+BcgZu7o9PH6CfwVg== X-Google-Smtp-Source: ABdhPJxcFcMQuIk/0p73clG3HeTa7gIkYGcpdF+XxUcS0M11AJAff5lVTE72GMYHcCbKOlc2a6jhIQ== X-Received: by 2002:a05:600c:643:: with SMTP id p3mr8771786wmm.130.1641513218743; Thu, 06 Jan 2022 15:53:38 -0800 (PST) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id a71sm335893wme.39.2022.01.06.15.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 15:53:38 -0800 (PST) From: Bryan O'Donoghue To: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, hverkuil@xs4all.nl, robert.foss@linaro.org Cc: jonathan@marek.ca, andrey.konovalov@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, jgrahsl@snap.com, hfink@snap.com, vladimir.zapolskiy@linaro.org, dmitry.baryshkov@linaro.org, bryan.odonoghue@linaro.org Subject: [PATCH 6/7] media: camss: Point sdm845 at the correct vdda regulators Date: Thu, 6 Jan 2022 23:55:39 +0000 Message-Id: <20220106235540.1567839-7-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220106235540.1567839-1-bryan.odonoghue@linaro.org> References: <20220106235540.1567839-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Reviewing the RB3 schematic its clear that we have missed out on defining one of the power-rails associated with the CSI PHY. Other PHYs such as the UFS, PCIe and USB connect to these rails and define each regulator individually. This means if we were to switch off the other various PHYs which enable these rails, the CAMSS would not appropriately power-on the CSI PHY. Signed-off-by: Bryan O'Donoghue --- drivers/media/platform/qcom/camss/camss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c index 419c48c4f1d52..6de257502e88b 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -543,7 +543,7 @@ static const struct resources csiphy_res_845[] = { static const struct resources csid_res_845[] = { /* CSID0 */ { - .regulators = { NULL }, + .regulators = { "vdda-phy", "vdda-pll" }, .clock = { "cpas_ahb", "cphy_rx_src", "slow_ahb_src", "soc_ahb", "vfe0", "vfe0_src", "vfe0_cphy_rx", "csi0", @@ -563,7 +563,7 @@ static const struct resources csid_res_845[] = { /* CSID1 */ { - .regulators = { NULL }, + .regulators = { "vdda-phy", "vdda-pll" }, .clock = { "cpas_ahb", "cphy_rx_src", "slow_ahb_src", "soc_ahb", "vfe1", "vfe1_src", "vfe1_cphy_rx", "csi1", @@ -583,7 +583,7 @@ static const struct resources csid_res_845[] = { /* CSID2 */ { - .regulators = { NULL }, + .regulators = { "vdda-phy", "vdda-pll" }, .clock = { "cpas_ahb", "cphy_rx_src", "slow_ahb_src", "soc_ahb", "vfe_lite", "vfe_lite_src", "vfe_lite_cphy_rx", "csi2",