From patchwork Fri Nov 23 07:57:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 151841 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1755206ljp; Thu, 22 Nov 2018 23:57:56 -0800 (PST) X-Google-Smtp-Source: AFSGD/UMxbWdpsqaiNWJYoROXFVSRT171Ujt/3is0W+lBg+f1a6rfZI31Dux+bMgwE7kH3ylHZU/ X-Received: by 2002:a17:902:1008:: with SMTP id b8mr5171974pla.252.1542959876183; Thu, 22 Nov 2018 23:57:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542959876; cv=none; d=google.com; s=arc-20160816; b=scMoFHf97BeRv6Iy4ESXnWpc1vFlmU0b4u/Hl8Wb53y8ZXWBBQ/PVuYn8VZS+CyOWU nyL0AgImyMYxBhK7RzwJ2uoyxm3zXLot+zWuVgbubTrR4PLhL3xjX7ajt1IHtc3PBKM1 zXSFsx97pc3l3YLFYJKVv/x5LN+ZKI2eg3ObRO99HRteSSZVuDlTdxqy0/VIy4E8vOFX 5yS1zmCUL+cMsQ1znZw/7oWm0hreix3vVVqOLy6M17LNGJYXtnQQAnAyC4QeNk+OKQdg 8Z/d/wH+7/qlP2saS9z5TCrSmLHhn9RtHpWhXJiQ21UsppAF9OsD/EtFk+WL0/YTayOg jQ4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=Yqsi8EZdGJBsAxM6FldKbnl+rKoATI9SGx36ZNkWo0I=; b=ui7IbyrnCnx44SsvlHTxCmZMjkJt87K+s4d70gkeP8ull3C5R1S9Nf13Ldlrv4w8gR dDTjX1mGAp1npupIuaSXmCd7inR9rp5spK/kS33I/xWK1kKOAqdnX+VvI265gborqY1q AQ4qxuHAF671iScl6WR1Admn+TZmsXg2U7nGs3t1ivtLZWYjx7aBIJ24HL8FtsrjH4Mx XnJpbZiBKajxIZVYBSNEyWTNtnYS6yOKe3ZDpyRX/YTs4m+0QRE1+LPzTxueaFxJZ7/x 72JEeiclPtcWgbf6tvIQCx7zVlmHGxu++QlTJciX7XsXsjBn43TpDM+pe0J/kAPVSX0B Zfog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=EZAV4q3k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p64si77663pfa.94.2018.11.22.23.57.55; Thu, 22 Nov 2018 23:57:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=EZAV4q3k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408322AbeKWSlA (ORCPT + 32 others); Fri, 23 Nov 2018 13:41:00 -0500 Received: from conuserg-08.nifty.com ([210.131.2.75]:55963 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729827AbeKWSk6 (ORCPT ); Fri, 23 Nov 2018 13:40:58 -0500 Received: from grover.tkatk1.zaq.ne.jp (zaqdadce369.zaq.ne.jp [218.220.227.105]) (authenticated) by conuserg-08.nifty.com with ESMTP id wAN7vWj2021058; Fri, 23 Nov 2018 16:57:32 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com wAN7vWj2021058 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1542959853; bh=Yqsi8EZdGJBsAxM6FldKbnl+rKoATI9SGx36ZNkWo0I=; h=From:To:Cc:Subject:Date:From; b=EZAV4q3kvX6yt4jMhdJkdkg9skzM/pxbCmde4J0CR1m5o7ScQoLTLihbIYSexMNXb tv8x552dge70Jc1KeLZI/+118oZAGE3uvud2q0Qam9a9UtI9CRRe33w8IAfPmvgyRc Py3ZRpsFZscD1/zexeWJ7ED78diijkwsfMsDnVuJLI8XqbJR8MLim5YvCNgaMper3E UC4VRZRW42U/FVBfZvlUN6zCmf5KR7HwRRTrwPztfUQCRs31mz4GHvxcUlDpWnx6EM tiGfei6Zcq1zor3XGMgRL+IQ1gUIHguIHweSH/Eo77svVLmIyhDZDcWBP+/kn5BUxW RcX7oni/JSkQQ== X-Nifty-SrcIP: [218.220.227.105] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Leonardo Bras , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 1/3] modpost: refactor seen flag clearing in add_depends() Date: Fri, 23 Nov 2018 16:57:21 +0900 Message-Id: <1542959843-16145-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org You do not need to iterate over all modules for resetting ->seen flag because add_depends() is only interested in modules that export symbols referenced from the given 'mod'. This also avoids shadowing the 'modules' parameter of add_depends(). Signed-off-by: Masahiro Yamada --- scripts/mod/modpost.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.7.4 diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index c64066d..39432c2 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2229,15 +2229,15 @@ static int add_versions(struct buffer *b, struct module *mod) return err; } -static void add_depends(struct buffer *b, struct module *mod, - struct module *modules) +static void add_depends(struct buffer *b, struct module *mod) { struct symbol *s; - struct module *m; int first = 1; - for (m = modules; m; m = m->next) - m->seen = is_vmlinux(m->name); + /* Clear ->seen flag of modules that own symbols needed by this. */ + for (s = mod->unres; s; s = s->next) + if (s->module) + s->module->seen = is_vmlinux(s->module->name); buf_printf(b, "\n"); buf_printf(b, "static const char __module_depends[]\n"); @@ -2506,7 +2506,7 @@ int main(int argc, char **argv) add_retpoline(&buf); add_staging_flag(&buf, mod->name); err |= add_versions(&buf, mod); - add_depends(&buf, mod, modules); + add_depends(&buf, mod); add_moddevtable(&buf, mod); add_srcversion(&buf, mod); From patchwork Fri Nov 23 07:57:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 151840 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1755158ljp; Thu, 22 Nov 2018 23:57:53 -0800 (PST) X-Google-Smtp-Source: AFSGD/XZiYV4xJm8UNGQDVLP1cJUbZvJXf7CWhjefVfXl0WBPMSX+ofp8smiiNTeNI25x4aFOOBN X-Received: by 2002:a63:6704:: with SMTP id b4mr13213597pgc.100.1542959873775; Thu, 22 Nov 2018 23:57:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542959873; cv=none; d=google.com; s=arc-20160816; b=ijf7o585yXuOIqEXh3AfS5hod7qkV2P9ldqaascghZd7JJKKySi+AZJ3f5rNC0YS5I QihTq2sa7I8fu8Ee6EAqBmtHN5yCVH/pHvgA6+ENGParU1gidLreUuRlK3sfHbhUyJb0 6hhTBUlh8VGmacNHrlfw4tXtAW4xJqyqQTI720sD4OzEFdBlXouhdqVmcAL4BjqZyhxH VTJiOa3KEpJwOlU/dGoggvzZIg5TQiyjWB8QXTRckL5KzNX2fI3Pb0hp4G3ehjiicOph IdkqiZBG5hHQU41MM/E8eWIz/H75t8scKBRmGq5tTJkIERYKgg/vQ2n5DHOt12c7/Wlz S0/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=QiRqh8yetZM167uoY2zCS9SR1gaXHDJe1PX6A2FbUWk=; b=KJoEEPWdGaQIAUbz4cPUJvqbYDAFyqOiQX6ALvWZ74knjryzlfxsIRKQrzwrNajocV YY/N15jipq5OAOQYcA1dM9bbnGb8tIDOGxgSu+6zB39qgfIi+u6cEfWDy6S4DHuZemli UfOsLHRrzkNQng8ssJFlZA/TOwKloYSwiY5V303I4+d+yc1W24lL9jn3wBkyfrLJbLUY YDur79Y46TS2EFhmo2vlfoLj6xymYKPu/KCHHXoLa41f3vt0jKAWrt39RY77hdKHgllx J5ev1oUx5ldpSpGebfh8RDccD1mCpjIqic+nkk0HeZtYmdBcpRdABE7tVBg/Xe0U5L2T 1oOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=uhKImOe4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p64si77663pfa.94.2018.11.22.23.57.53; Thu, 22 Nov 2018 23:57:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=uhKImOe4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393559AbeKWSk5 (ORCPT + 32 others); Fri, 23 Nov 2018 13:40:57 -0500 Received: from conuserg-08.nifty.com ([210.131.2.75]:55964 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390083AbeKWSk5 (ORCPT ); Fri, 23 Nov 2018 13:40:57 -0500 Received: from grover.tkatk1.zaq.ne.jp (zaqdadce369.zaq.ne.jp [218.220.227.105]) (authenticated) by conuserg-08.nifty.com with ESMTP id wAN7vWj3021058; Fri, 23 Nov 2018 16:57:33 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com wAN7vWj3021058 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1542959853; bh=QiRqh8yetZM167uoY2zCS9SR1gaXHDJe1PX6A2FbUWk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uhKImOe4cNfkV3//LxJArl7XFi6B2plvMt7ohzt3Wpmko4J19fQfzRL/gnI/qHEwO o2j2g6qDmTbfVo5AECwUFQvSeiZI91p2116q6ni15tfuXeORwVgPVk5cVB/koeiqYy GzKdVirsASaXzsCt0BtHqu/pQvTaB7dJ1zOvr5/u8z4V6H+KOlhD3NbwseTcZI5J29 hlaOGKNpfodnKryGTeS88R0VFKU7edCnZdV+BuGCovTdSD3sEGozyZkmBWv4IC1GON eMm4y8AYB3SfMfELIMIaVvF18N7NnA0GVy1urLT0lPLlip2W13xdz5/2uzjz4fB5Jn AsCpefVMgGWfQ== X-Nifty-SrcIP: [218.220.227.105] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Leonardo Bras , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] modpost: merge module iterations Date: Fri, 23 Nov 2018 16:57:22 +0900 Message-Id: <1542959843-16145-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1542959843-16145-1-git-send-email-yamada.masahiro@socionext.com> References: <1542959843-16145-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Probably, this is just a matter of the order of error/warning messages. Merge the two for-loops. Signed-off-by: Masahiro Yamada --- scripts/mod/modpost.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.7.4 diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 39432c2..05e41eb 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2484,12 +2484,6 @@ int main(int argc, char **argv) if (files_source) read_symbols_from_files(files_source); - for (mod = modules; mod; mod = mod->next) { - if (mod->skip) - continue; - check_exports(mod); - } - err = 0; for (mod = modules; mod; mod = mod->next) { @@ -2501,6 +2495,7 @@ int main(int argc, char **argv) buf.pos = 0; err |= check_modname_len(mod); + check_exports(mod); add_header(&buf, mod); add_intree_flag(&buf, !external_module); add_retpoline(&buf); From patchwork Fri Nov 23 07:57:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 151842 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp1755260ljp; Thu, 22 Nov 2018 23:58:01 -0800 (PST) X-Google-Smtp-Source: AJdET5fokySEZ4espQRxq9dY9FABQplkWn5ZL+Chd3GRTcd8oLLgiO09CbLyQmwGNNeu48xIufqN X-Received: by 2002:a63:f74f:: with SMTP id f15mr13163940pgk.190.1542959881695; Thu, 22 Nov 2018 23:58:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542959881; cv=none; d=google.com; s=arc-20160816; b=VYZmPBlBXJLPfzVAj5D8HU9anmYACA4vel6ZV2APrpZqRO6zBfZYm0OtkvGMLXvrKh mmv1ouIH8TzfKkwoUFWj85cuYmHrcLUUKrWJBvmGAO6/Gn3idHSOTfoaqeCp2QJO7cWj 3+btVk5AKCPDpUx8ofeVu3T1xlXXowZwC7Q5T8raGS7l1x4JgTLYYUPzbmVwqJndW945 5sf56fttv1eX49RLowFRHUobgmwIKjCypJSolW+/SwNBGyqhJg4SuZfqfOnEkpuAJUHh 5Dddi4HRQ7mZWqUyU4lkYyL1OGyd4RGESBr+Jhcroy7T+pyf6tpM+awizYMP73yYyUq0 uuUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=lOj4lXrPAtpsd7/ex0Gl8dUQwYFD9eQxYWKByw5NgPM=; b=zZJecUybjBqNCwwUfFMnK/35LyKAOKQgxcH8k79733nWpDQTWQoE+RH15vYcn1YYkM Oy8jE/dnBxDxdbzATVwGKDLkaCJQylydIFccaduxyca6geZCr7jx1aBkWhVOIwwEroRn FB8l2QI1S8yG/URjoQRZzcAH3+KEKUko6YYOJChinNdpTo6k9EX/ni8BE/HlrZmkZaE9 g6Y4bZ1hoiTQPYCIoVxV1ad8Yfr7XsdRzdayBth8HB5tlj2zzi0RyL9ok2CxyYCHpRKF HDa0hPvFyb7aFMizg3K0g+7kPIyvMC7fMR+9GerJGEamsrd8WevFBPqLkczi6agZOmF5 QjVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Sx8OsZDz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l12si28808247plc.0.2018.11.22.23.58.01; Thu, 22 Nov 2018 23:58:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Sx8OsZDz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405163AbeKWSlA (ORCPT + 32 others); Fri, 23 Nov 2018 13:41:00 -0500 Received: from conuserg-08.nifty.com ([210.131.2.75]:55965 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390244AbeKWSk6 (ORCPT ); Fri, 23 Nov 2018 13:40:58 -0500 Received: from grover.tkatk1.zaq.ne.jp (zaqdadce369.zaq.ne.jp [218.220.227.105]) (authenticated) by conuserg-08.nifty.com with ESMTP id wAN7vWj4021058; Fri, 23 Nov 2018 16:57:34 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com wAN7vWj4021058 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1542959854; bh=lOj4lXrPAtpsd7/ex0Gl8dUQwYFD9eQxYWKByw5NgPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sx8OsZDzhuTgWgFLlXbvFLWcV3pSYAVDEBgxFxVMS2LgCevnloYb2U7QEJwWz9MXv L/Upzk2qrX7mgA2zuPgd8nYtNohp9dKye07v8UCbsotgn8nsF4rhzWBACJ3t7qYFu0 JKNmHslMm6z6BLDHmESXA39h8ghc0ScPdvAs5Fy08/Nm3Yhj21Z3ZTlSSszjCnilq9 wIOHs8v/BhOxymxjyJ1vgrNHbD7Bsn6E88yv2xvTHGocNDub9TdVI/iRkOeWVcuJ41 edPVUxRB1yy0LfRixOgxh5H5yxoHqkrPKwhdNJWnWUUtR41vUVUpuoMn/AnPdOZQY0 1Z17/ydXedUSQ== X-Nifty-SrcIP: [218.220.227.105] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Leonardo Bras , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 3/3] modpost: move unresolved symbol checks to check_exports() Date: Fri, 23 Nov 2018 16:57:23 +0900 Message-Id: <1542959843-16145-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1542959843-16145-1-git-send-email-yamada.masahiro@socionext.com> References: <1542959843-16145-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This will fit better in check_exports() than add_versions(). Signed-off-by: Masahiro Yamada --- scripts/mod/modpost.c | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) -- 2.7.4 diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 05e41eb..32e5026 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2085,15 +2085,27 @@ static void check_for_unused(enum export exp, const char *m, const char *s) } } -static void check_exports(struct module *mod) +static int check_exports(struct module *mod) { struct symbol *s, *exp; + int err = 0; for (s = mod->unres; s; s = s->next) { const char *basename; exp = find_symbol(s->name); - if (!exp || exp->module == mod) + if (!exp || exp->module == mod) { + if (have_vmlinux && !s->weak) { + if (warn_unresolved) { + warn("\"%s\" [%s.ko] undefined!\n", + s->name, mod->name); + } else { + merror("\"%s\" [%s.ko] undefined!\n", + s->name, mod->name); + err = 1; + } + } continue; + } basename = strrchr(mod->name, '/'); if (basename) basename++; @@ -2103,6 +2115,8 @@ static void check_exports(struct module *mod) check_for_gpl_usage(exp->export, basename, exp->name); check_for_unused(exp->export, basename, exp->name); } + + return err; } static int check_modname_len(struct module *mod) @@ -2180,19 +2194,8 @@ static int add_versions(struct buffer *b, struct module *mod) for (s = mod->unres; s; s = s->next) { exp = find_symbol(s->name); - if (!exp || exp->module == mod) { - if (have_vmlinux && !s->weak) { - if (warn_unresolved) { - warn("\"%s\" [%s.ko] undefined!\n", - s->name, mod->name); - } else { - merror("\"%s\" [%s.ko] undefined!\n", - s->name, mod->name); - err = 1; - } - } + if (!exp || exp->module == mod) continue; - } s->module = exp->module; s->crc_valid = exp->crc_valid; s->crc = exp->crc; @@ -2495,7 +2498,7 @@ int main(int argc, char **argv) buf.pos = 0; err |= check_modname_len(mod); - check_exports(mod); + err |= check_exports(mod); add_header(&buf, mod); add_intree_flag(&buf, !external_module); add_retpoline(&buf);