From patchwork Tue Feb 22 06:22:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 545039 Delivered-To: patch@linaro.org Received: by 2002:ac0:e142:0:0:0:0:0 with SMTP id r2csp134691imn; Mon, 21 Feb 2022 22:23:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkh/dZhBFNlcocnD66y0RWcYPNVNBi+zOfO5Q63CwfZd8y/H1MZmi1ohb/s+KRoefYKV72 X-Received: by 2002:a17:902:ce91:b0:14e:d9a9:5d7c with SMTP id f17-20020a170902ce9100b0014ed9a95d7cmr21922959plg.40.1645510987975; Mon, 21 Feb 2022 22:23:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645510987; cv=none; d=google.com; s=arc-20160816; b=t17nv2xLOWAXs+f0cBkC2fmQvj5HNp5FEqpx9s0RdLgfdvD3sel5xojU6PAI3gcGGS taUzj2SEmCjmku/TQrLxAyd+yAXwPvF6xM5Rbyo22yXU0lVpFAVo80ORhVU0ZYhCrwfn 5nzrIN4BE2ErMM5yqsW+CKXxRXFrhPxlViiG/G09OkGfedw0Hn3hmfv0B7yEk6ei5MT8 5h0HWp80jqgyCCuZkPLEGWSeHM2l3h1YfWHKAlBxHbhTRMe6/WydGCZi/iuR1XsbBuON qkmTNdz1YfqK1WfgpM5scNElUBE66ea5JewqhEdCGGONJxCngSiCbR9WyGVrFG/ECj2P PVxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=DcGm7ltYqskU4cKmyhujRtdVm6Wd95PkL411GLVzEg0=; b=K7xN7yJKvZknZkLK/+YmV+6mmKnlWREOmDGFO6rJ86gaIVN7HZWmvNj/VaRRJEO2Vh Gt1oFtxO2LcfiyuqDDlE8qQnH/X9DMUYy8zWfISEnc5UaL7AryeWxXE/JtUxSxaTLLWA Vtqd/kA/6XYL766KIyUxxwMW3s5dsfMmBDcupJcSPOyVHPSapkDFu9Q8yl2PgiykcqvA kI5lQVmxJeueFj8Z72jWm5b4pUgrYpE14uwQICLk/WhvhN8xOuGAcBQz5EoDjhaBRcDL A8euYl0jl6GKQ0sz5+A8Ip2keXsg9jlYJcvRFPUuvzI0N5ZdkWr9tQkgfZddRaHULuw5 TVsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZOeIhdUl; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id mu12si1346622pjb.73.2022.02.21.22.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:23:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=ZOeIhdUl; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAB6C10EF57; Tue, 22 Feb 2022 06:23:06 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 045F410EF2C for ; Tue, 22 Feb 2022 06:22:51 +0000 (UTC) Received: by mail-lf1-x12f.google.com with SMTP id j7so22756662lfu.6 for ; Mon, 21 Feb 2022 22:22:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DcGm7ltYqskU4cKmyhujRtdVm6Wd95PkL411GLVzEg0=; b=ZOeIhdUl8aEQPWT0Lk9FhpAJNeRoEsOodBzDBZaHbHToDTJmeN5zGVJgRaaIuoTeP1 hW2jr0//5VYifyiU0rPvnZWxkHVaBwP/WvgoPxMrdKPr7OZkr2LPDFvQbQne0XiDjzkH F7gT2Ex3L5oo79xqxF0ZY3LWXRMJqAkT5Bkmt3nsesc5PuSjDGRwucZjBH/SseFximdy Ttx8Yo+2TdyBoTqzRcQfAF3s01M/21IwMZR1OrFZ8u51915StsSAxT0T7bNpAqEHGUot RRol0OqhsCsVM4Wj9jfB3xZ6LgB1hRaCaS/J9yn6WkWETMuUI2iT1O/HNpcr4Vjz2zKH xP+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DcGm7ltYqskU4cKmyhujRtdVm6Wd95PkL411GLVzEg0=; b=T9hrhqyJTEkLG+mw+ro/P9AX+nwLlooe18GkSdQy49mmh7L4ZpF4/opG4qKXYXk/o1 y/ZnRcXFi+l2ITVhDtDDG2FAjUoJTmQiBXzDznzPColP3c7UhQPbZKQNS5aqlL11exHI Ja4P1tEgmJ60h4ZLu3UHe4Gi7zuKaXPrM+8o94ivaIyDcI1C3zv2xaImnh5ZsP0MmlfI ZBieP0bIa8QDqGh/OqVhGMHCo9jaBBGHepeIsHCcL2dBkM37fnWq4FfuWJlxfYc79pOP CtUkELHYQzoysHBc9br9mSzDdhtX7PFHQVQO6Ut3FeS6cAvtjMh1lhRLfrpC6Yg+UGNi uP0g== X-Gm-Message-State: AOAM533XoDaAmMOT+n9M9/Cq9Xhx9ncR8b+5whmEf1mWRoGSG2x0kcQ3 ayk5VkXyv7lNS0FbEpUnHnTHwg== X-Received: by 2002:ac2:4a65:0:b0:443:7f84:5e08 with SMTP id q5-20020ac24a65000000b004437f845e08mr16481610lfp.336.1645510969232; Mon, 21 Feb 2022 22:22:49 -0800 (PST) Received: from eriador.lumag.spb.ru ([188.162.65.160]) by smtp.gmail.com with ESMTPSA id j24sm1216245lfb.59.2022.02.21.22.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:22:48 -0800 (PST) From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar Subject: [PATCH 1/4] drm/msm/dpu: document INTF_EDP/INTF_DP difference Date: Tue, 22 Feb 2022 09:22:43 +0300 Message-Id: <20220222062246.242577-2-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> References: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Based on the discussions on the mailing list, document enum dpu_intf_type and it's controversial fields: INTF_DP and INTF_EDP. INTF_EDP is used for older eDP interface found on msm8x74/msm8x84 INTF_DP is used for both eDP and DP interfaces handled by the msm/dp driver. The DPU driver does not make a difference between them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h index bb9ceadeb0bb..4f8336cc7911 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h @@ -205,12 +205,20 @@ enum dpu_intf { INTF_MAX }; +/* + * Historically these values correspond to the values written to the + * DISP_INTF_SEL register, which had to programmed manually. On newer MDP + * generations this register is NOP, but we keep the values for historical + * reasons. + */ enum dpu_intf_type { INTF_NONE = 0x0, INTF_DSI = 0x1, INTF_HDMI = 0x3, INTF_LCDC = 0x5, + /* old eDP found on 8x74 and 8x84 */ INTF_EDP = 0x9, + /* both DP and eDP, handled by the new DP driver */ INTF_DP = 0xa, INTF_TYPE_MAX, From patchwork Tue Feb 22 06:22:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 545036 Delivered-To: patch@linaro.org Received: by 2002:ac0:e142:0:0:0:0:0 with SMTP id r2csp134602imn; Mon, 21 Feb 2022 22:22:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJz9BkhM/EDtgrqHBqSQLW2cybvWwMFL99LJ76aqa15AZ17+dCy6MjnQsU3dtB18/64QCPNU X-Received: by 2002:a63:e604:0:b0:373:8aca:846e with SMTP id g4-20020a63e604000000b003738aca846emr18665819pgh.406.1645510978197; Mon, 21 Feb 2022 22:22:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645510978; cv=none; d=google.com; s=arc-20160816; b=gkAs4o5xsNP+5DL77ThbqwJPY0EGPpcjwMXghUAyuHsycHEtxlhJvXCkPdK38agpok IKCKMH07tq/SVw1MJEpDylSSB3MirEv0Y0Od19ObvrLa8SJZjAeC3DTeSXmdXyg022Jq w+Dg54VXJoQDkQonN2JDajjaNtfuulcc+grJgvWlzP4+wInzaMCWHzV7vEAtTWXIkzSm Vp9HwHkt/SDopjExJJ4Is442ZDV9KzCreIEWtgO7KNXxDqm9ryAGQy8wgkI2hj9yUCvG EweSoYjTzG2t9p+kGv8RHryJ4j7JhJuF6m2b+hO3EErya0Y4Wqx3pkmNivnmfB7BiT+N dq4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=B35/xt4SCJGelHk6jNUJaO+E/UL5oTZkMPlhEe6zMWM=; b=ISyYEgM7HVNg9Ph9BgvLNyUQr+o9Jx65cINcOtXPn2Fv5kF87WPrk+UrzbrDp8ggMY bPMNUMRDRmYKJr4spGq8n0VAwpHVPSVQncWVhXD9dcnwdko7KCPwrpXEb1ZcjgpwVgdk WyLdosHc1zYTB1zsAPkhdC3Okr3ZgHbbh8L1gLGFui5WlhUPuW5T0Ab0SOUGoj3FB7tt uyIuqRzdCz5uFU1DH/rjpAfUumjM0wKQGIjpz57gix/C860S7h6C2TDGl3TMmTfsOKzF lIM5xMfYMpcqmRffOBucD/H/a+Oj1dDdEBn7/3joZmOjhXsn8wo86q3icWWUc95ura4r 0ARg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="YomQ4ZP/"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id o12si16102590pgu.842.2022.02.21.22.22.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:22:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="YomQ4ZP/"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 01F6A10EF49; Tue, 22 Feb 2022 06:22:56 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09FE610EF39 for ; Tue, 22 Feb 2022 06:22:52 +0000 (UTC) Received: by mail-lf1-x12b.google.com with SMTP id y24so10390088lfg.1 for ; Mon, 21 Feb 2022 22:22:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B35/xt4SCJGelHk6jNUJaO+E/UL5oTZkMPlhEe6zMWM=; b=YomQ4ZP/jD1H5vI90v10St0iBplfmy54PC26Ap+h3GmjOR+gnoHnFHPpVUjgb6uA7w 34I3fAP25VKfcuB+fQA0iwkaxaTWciTAWNr2jDeni5IO1MLa1wpyjmQQJkvEk1Z/D5ou slQ8eumdxDCH6EhBCgWH6TeOL4MWQBeoDIZBy7wvU2f8kF4Cnp7CjiIAqlL47uWKstRf UmLRlZ3l6t7E1pkn02MCTxJDFSkKqGTaJJ+RTNK7zGHRWlLgkerz0CNYuhst5iY8Z8WA PXqlHFLZ51k9Kbhc+zMfhHPX0k8ueCdO1jihicO5UujGCmjGbLmIZBasDevJAWChcm3/ Wqmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B35/xt4SCJGelHk6jNUJaO+E/UL5oTZkMPlhEe6zMWM=; b=CAQoJfftZasYlLVLGA9S7/j+NykTH+RTEieoFCl+DxiwRgWkXZIr5TEmzIe4jNaOQP BGC6SK57eLLZiVebSKZBb3Lhl/QsHlpekQkV40veAF7g9tGUWlORzn6oOWmz49KxR6Ue e7Wr0kyp7J3Gd3vA123Cvo+wtAh3VrymPhYK2gnBNWXduwKdGTrR0mlopkHSxFQg2Ms7 TJdmr09ktKOQwOLiggTZ9epqtNjCIo2F0yJGdB37eRMbKkuPAsNn8wZcWD5Je39EVIkR 1O8Do/nT6Ko9+0e3IzjukNI+VRbf2UmdvVVmXMiqWoK7Imoovkz3ZhVUpCmzWgQ43fZD LLkA== X-Gm-Message-State: AOAM531OJ6EOcOxmdLv/39IFJlAtL9qYV9zF1ZHug+bAY/Da+iQRKtxl MRAEOsJaD/MReg4rkrjPCQDwUw== X-Received: by 2002:a05:6512:3094:b0:442:ca74:a610 with SMTP id z20-20020a056512309400b00442ca74a610mr16095850lfd.438.1645510970379; Mon, 21 Feb 2022 22:22:50 -0800 (PST) Received: from eriador.lumag.spb.ru ([188.162.65.160]) by smtp.gmail.com with ESMTPSA id j24sm1216245lfb.59.2022.02.21.22.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:22:49 -0800 (PST) From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar Subject: [PATCH 2/4] drm/msm/dpu: drop INTF_TYPE_MAX symbol Date: Tue, 22 Feb 2022 09:22:44 +0300 Message-Id: <20220222062246.242577-3-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> References: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This enum value does not correspond to any of actual interface types, it's not used by the driver, and the value of INTF_WB is greater than INTF_TYPE_MAX. Thus this symbol serves no purpose and can be removed. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h index 4f8336cc7911..a9b6d0955539 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h @@ -220,7 +220,6 @@ enum dpu_intf_type { INTF_EDP = 0x9, /* both DP and eDP, handled by the new DP driver */ INTF_DP = 0xa, - INTF_TYPE_MAX, /* virtual interfaces */ INTF_WB = 0x100, From patchwork Tue Feb 22 06:22:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 545037 Delivered-To: patch@linaro.org Received: by 2002:ac0:e142:0:0:0:0:0 with SMTP id r2csp134631imn; Mon, 21 Feb 2022 22:23:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSNeXdD7IZvYWH4SRjjXSBXmu75gmKLE7iCabUN7+pUCw74pkvBZvfg+rSCePRD8YPzxTQ X-Received: by 2002:a17:90a:aa91:b0:1b9:19d6:95b6 with SMTP id l17-20020a17090aaa9100b001b919d695b6mr2640021pjq.106.1645510981043; Mon, 21 Feb 2022 22:23:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645510981; cv=none; d=google.com; s=arc-20160816; b=ZkCC0wGJDYhcH6bo8/S+UFaTEygUKDOf/Y0keUeGG7pp5VLILDNO5W6cjV6b7NgkG0 zxcFPXfunzKajrxCsM52LPMbOT8kNF2tFUopqq1FbqVSK7nTuFtmnGMGiv3devubocVu SknIBNi4xvNlgJkuo8f6EJD1VEjLdJfD/jeESU/KonLzlDvCuO4dUVCVYqsAm7t4SpG3 cUugyZ69hRLJGnEst233u0Jy80NLsJlA9+nZb2v7OrpyCT1LyOb2hZVk6woZvLqYsTOK bJaqR1BEnRwviuwJ8LQj/fy4mFgDgW1ax2xWiy8Papj13bZUOY9ZcSlaPWj7bHMPNpiX ozDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=I+FUp1ylyZlTVPkOMx/YuQtPRcxSfUwrG3pZ+XT0maY=; b=nsnw3fNpwvikS4WVHbH5mmXCFsW+c+MqUXPTAi+vSO1afr2I3YnRjJ4Iu45q9d1Kfi qdNhQPc2JkXYVC586m3LpgpbBERDaBCHObflScC34mLSaUPpEWOKHd4vaGono7MFdgRW 2YBt4+ylH+mnu7bXTPMTfhyrEc7trHvHHuD+lt/mCTyQuUDT38mDfXxcOhJhm+g9b5lx cRIwTbsFec/IEs5Oa0uRa169VNHm9BxREu0LhPnXf4m+7L7vMy9cJl6GD1dCxwdUUc9I wXCMXNjI/sfPpcuPb6p/97hD9G59rNrdbUaIwnPyASP1sBhWD/FYwbYz/6C8BfMN9DFh cT2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=zQeIan6s; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id s64si18403916pgs.339.2022.02.21.22.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:23:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=zQeIan6s; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EEC8E10EF4F; Tue, 22 Feb 2022 06:22:56 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BC3C10EF3D for ; Tue, 22 Feb 2022 06:22:53 +0000 (UTC) Received: by mail-lj1-x229.google.com with SMTP id t14so17852234ljh.8 for ; Mon, 21 Feb 2022 22:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I+FUp1ylyZlTVPkOMx/YuQtPRcxSfUwrG3pZ+XT0maY=; b=zQeIan6symQMv3r+UD42j3SgZ2JFsvBjw1DG0LvEciJ5Z1K+pGe3OqhD0A/kM8RYVr EdVQTW2GwHmSOVRFhctzRn4/akdowswU0dGitnRCv2+KjJ/Kbo1EbDsgdGcaTidcMrPK NMQd5N0H6iljAsJLwnPD1Hnx+MqL0smsxuXS1/0K8yO54U7dGJbs4IM/QR8rNW+a949P 5juysvL4ZCh4uz9KCF8ViLBZp5tw2H3RCTmX7AxkuW0Hlab464jwlsIMW1P9a2SCwwX2 7hfnwVCk3EsxjszAnWrSC2kvfIEBkS5AzWgPN04wP99IW3uRKYRzcqeb2KsIQLZS4ZL4 72Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I+FUp1ylyZlTVPkOMx/YuQtPRcxSfUwrG3pZ+XT0maY=; b=kzleF1E9jnT6R19VtOMNQwbiw8Q6MrrH02hkRM+5nisoak+eQa8njLwDozR2ogOlLM P4C7j0aqjJgEKTB1SzHjSO0Io9cSNDR0GU3rAdPYjDXxfkTulJMOdGlmMpowubCpazbJ 7TrkMUL0AK3bg0mh85fi0TA4J2BJH0RJ859zYsHRSlsCl9UGxZ77C1d8RdlKQRcQqmMa wDrd9cQzUZmHyVxamUnt5pzdX8cCi4A8oNqS9UG1Z4PMuWRh6kr1gIlqVpQMGtx3gfux Od+Z1IXPhCEFkOuD+yCmSDal6A1ssyX+A+LRuKux7yTguGhhIBd/nwq/dAk3gEr4o2gs I0Fg== X-Gm-Message-State: AOAM532XHaLn3Ked23QmGFCzNPDs9+5s+kqRgLJDQSvzB5UbrXTv0wQe ctxEypb9BaXmDY65WxRPExp/DA== X-Received: by 2002:a2e:9cd5:0:b0:246:3ec0:7505 with SMTP id g21-20020a2e9cd5000000b002463ec07505mr6092017ljj.434.1645510971535; Mon, 21 Feb 2022 22:22:51 -0800 (PST) Received: from eriador.lumag.spb.ru ([188.162.65.160]) by smtp.gmail.com with ESMTPSA id j24sm1216245lfb.59.2022.02.21.22.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:22:51 -0800 (PST) From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar Subject: [PATCH 3/4] drm/msm/dpu: drop obsolete INTF_EDP comment Date: Tue, 22 Feb 2022 09:22:45 +0300 Message-Id: <20220222062246.242577-4-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> References: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" DPU driver never supported INTF_EDP, so let's drop the obsolete comment. If at some point 8x74/8x84's INTF_EDP is ported to DPU driver, corresponding handling will have to be ported too. Until that time, the comment serves no purpose. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c index f49f42e70b29..478a608ba7f2 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c @@ -91,17 +91,6 @@ static void drm_mode_to_intf_timing_params( timing->vsync_polarity = 0; } - /* - * For edp only: - * DISPLAY_V_START = (VBP * HCYCLE) + HBP - * DISPLAY_V_END = (VBP + VACTIVE) * HCYCLE - 1 - HFP - */ - /* - * if (vid_enc->hw->cap->type == INTF_EDP) { - * display_v_start += mode->htotal - mode->hsync_start; - * display_v_end -= mode->hsync_start - mode->hdisplay; - * } - */ /* for DP/EDP, Shift timings to align it to bottom right */ if ((phys_enc->hw_intf->cap->type == INTF_DP) || (phys_enc->hw_intf->cap->type == INTF_EDP)) { From patchwork Tue Feb 22 06:22:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 545038 Delivered-To: patch@linaro.org Received: by 2002:ac0:e142:0:0:0:0:0 with SMTP id r2csp134641imn; Mon, 21 Feb 2022 22:23:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJymk/71NZ7S/RBgBC5E1Cd9xl7DRKknyUovIdSBUkbVDJmrmEI6D620PJ4d6UOx/bAw1SfJ X-Received: by 2002:a05:6a00:2296:b0:4e1:3029:ee2 with SMTP id f22-20020a056a00229600b004e130290ee2mr23071790pfe.22.1645510983170; Mon, 21 Feb 2022 22:23:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645510983; cv=none; d=google.com; s=arc-20160816; b=Nrh2L4QwLV3BP1/Acqa+QiZvLJllANdBG/GtQzH04BumS8Ir42VHwNCaBE45sOC1GI hfBf4vjWLXhX9hcoGf+agkKryH8dzBIDHFnfheE1jnbkyJhuVHeWqgNlzQuXrC6NjAXc Dt8zBZC68mgZEKbYAITaqqjALVbQ04x3aDRGZ3pIqACrUWtfT5H5VuLWxYy4fAfUE7qM UjNCjFCvQCWoIOnUkvwxpnLCdfigIz/zBvShDVnn0FEUhYYKeruwKzXMezegk7mwmyA9 Ts4LF72LZA8vDmetadlpji+2gHjkRbTorMJA8p+vpMdiwaIxtAuZA4c7yaPYf351pWlW V5fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=iM+9d1vlrH8gvtpIKyDvBZU+m+WcrI9EbVXkjqnwrgU=; b=QCysdkUMYesbr4fjQK0qMgL57DadMQablIjrZ3rCyxjG+sgpz0bLPy5fUD1pTcZmsH Y6f50TenRL2SpRNa/uFtRQSbLBAPj1+8na6x8ArwDYLAI8rGMxZ81rvryn6E+A04jJgA ZmFaftcRaBkq6Mx+zqi+7lTUODJZBlEn0LH0AoPB21G7HmPrw4eJYDme7QTD5rKqhjbq eoEm68p1Z86fVetwt7BaHY52hjejoo4WbxuGvVE5TF7H+yA7d4pB1+PM3MnmPScsveA1 85B383nl5SgalTZHyprn4gu+w3Ia3WbznR5ko41cxoRxunDo+NHlRQGsPaBR+tGpyjG0 v7TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jpGdL2UW; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id u17si32684882plg.68.2022.02.21.22.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:23:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jpGdL2UW; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7E9010EF4E; Tue, 22 Feb 2022 06:22:56 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7993A10EF41 for ; Tue, 22 Feb 2022 06:22:54 +0000 (UTC) Received: by mail-lf1-x134.google.com with SMTP id j15so22711811lfe.11 for ; Mon, 21 Feb 2022 22:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iM+9d1vlrH8gvtpIKyDvBZU+m+WcrI9EbVXkjqnwrgU=; b=jpGdL2UWzg/HKSOtVLZnndwPDPtVWzbb/QNHcN8zho5Y4LDCr6KGRRmZM1LjG6NEDY JqmJeTejQukUyQGDA/TWOzev/9JOJU5/DGz2EpyXttNZDomlw9luYuOahhTVUDvPBTYL MaZb+lHFrE7aj9PKwD5qN3a8tgkzWQa9MHgCVQyi3fUxfiY1ScQBxWTbK7R8iv0ALLHD 8jrPCcI9OzfYNrYyr/PyC0P1xA2vEbufk887wsdKkDQA6oHSCj3ZJu2CHd9eydQAnmiW cmxImIEI6Y0qWMdGJAOw9fBHJkagYwdTyhVhRfp8rXrTKnpnk74wCD/YWowxVPCcl+ls V0KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iM+9d1vlrH8gvtpIKyDvBZU+m+WcrI9EbVXkjqnwrgU=; b=oRPXA+idQI3fnv2Q48JUKWOXe+TFq/Tr6kYMA9qNwLkWuPondAfVAEE08xogERgntp 04+x9K2RTjLKUV5y3HXCDICVhahH4C7nej6tv7U2o1NRo4A5X2sWbaPhKu19rSbqwNCS ohjokV+Y3VKDXtG6ywMxOn+Zx39vlOdMp/iNk9VEl1x6dmfHEpqPO2WE/vhIMfvm5gbu eaQsk8UY4+WOrs2VmfPUncZC49nvMM4DLdUVL+U5/RsQw9RHCxWvNfQWmBzxxubD93Dz OgAChvFXlcd+2wW5qT4XxiIVGlAtvZbyXXSihIbg7pqOK3r4kOzjNSWh5fvu8GcRkEZv BOCw== X-Gm-Message-State: AOAM530bYjNjpkDBMHmHX0cCwosa0m3I/n5N0qygAdhXXC0OsDwal01m MUb3O/2YbMOP6L2RIlIUr8AivQ== X-Received: by 2002:a05:6512:3e0e:b0:443:3cba:9e26 with SMTP id i14-20020a0565123e0e00b004433cba9e26mr16341176lfv.590.1645510972828; Mon, 21 Feb 2022 22:22:52 -0800 (PST) Received: from eriador.lumag.spb.ru ([188.162.65.160]) by smtp.gmail.com with ESMTPSA id j24sm1216245lfb.59.2022.02.21.22.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:22:52 -0800 (PST) From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar Subject: [PATCH 4/4] drm/msm/dpu: drop INTF_EDP from interface type conditions Date: Tue, 22 Feb 2022 09:22:46 +0300 Message-Id: <20220222062246.242577-5-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> References: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To remove possible confusion between (old) INTF_EDP and newer INTF_DP, stop using INTF_EDP in DPU's code. Until the 8x74/8x84 SoCs are supported by DPU driver, there is no point in using INTF_EDP. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 3 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c index 478a608ba7f2..e76d240f554d 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c @@ -92,8 +92,7 @@ static void drm_mode_to_intf_timing_params( } /* for DP/EDP, Shift timings to align it to bottom right */ - if ((phys_enc->hw_intf->cap->type == INTF_DP) || - (phys_enc->hw_intf->cap->type == INTF_EDP)) { + if (phys_enc->hw_intf->cap->type == INTF_DP) { timing->h_back_porch += timing->h_front_porch; timing->h_front_porch = 0; timing->v_back_porch += timing->v_front_porch; diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c index 116e2b5b1a90..1548614c508b 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c @@ -141,7 +141,7 @@ static void dpu_hw_intf_setup_timing_engine(struct dpu_hw_intf *ctx, hsync_ctl = (hsync_period << 16) | p->hsync_pulse_width; display_hctl = (hsync_end_x << 16) | hsync_start_x; - if (ctx->cap->type == INTF_EDP || ctx->cap->type == INTF_DP) { + if (ctx->cap->type == INTF_DP) { active_h_start = hsync_start_x; active_h_end = active_h_start + p->xres - 1; active_v_start = display_v_start;