From patchwork Sat Feb 26 12:45:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivasa Rao Mandadapu X-Patchwork-Id: 546451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F685C433EF for ; Sat, 26 Feb 2022 12:46:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8F86918FA; Sat, 26 Feb 2022 13:45:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8F86918FA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1645879601; bh=/yNKhmRNOud/3AJssaJGVCgAeNNtufQnDCkRsBuTN8s=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=rc8AJI8YUkZssog00NHV+3R9quKLCTJE1Rau5gl1QCcS8Fod7Ngyxvxi+b1IyF8Di EbMLAI1MN3J8vha8EaxflBjrdVtsf6PtrX1TTBbm1zYfVm1Bs8B8q20Vq3bs7TLc+L bRxIQby9rW3vG0dqSe62xUbENwQVkDic6alYSt/0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 152BEF8012B; Sat, 26 Feb 2022 13:45:51 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 07A76F8012E; Sat, 26 Feb 2022 13:45:49 +0100 (CET) Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 45E96F800B6 for ; Sat, 26 Feb 2022 13:45:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 45E96F800B6 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="lSuw7V5t" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1645879545; x=1677415545; h=from:to:cc:subject:date:message-id:mime-version; bh=4iZ92ymE7jSNJuadElFGgWcrZRahUwKuEPZoUCSBzrA=; b=lSuw7V5tm/8ZDvOcD4enDy2Y55odQGR7YvrsBnz1PvJZbGChWFn2z7o+ WTVI+aEWVKRMNd6Eam3XtYcyXdHJUl/zPgbsvzy9UG3kX0DWW2zVnB3i7 yePwzXlbO1eCh5+05H0iCVXzF5OblNNdFNks9JM7FIxfyCkJ1i7qWaaCv c=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 26 Feb 2022 04:45:40 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2022 04:45:39 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Sat, 26 Feb 2022 04:45:39 -0800 Received: from hu-srivasam-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Sat, 26 Feb 2022 04:45:33 -0800 From: Srinivasa Rao Mandadapu To: , , , , , , , , , , , , , , , , , , , Subject: [PATCH] "soundwire: qcom: revert wait for enumeration to be complete in probe" Date: Sat, 26 Feb 2022 18:15:18 +0530 Message-ID: <1645879518-14658-1-git-send-email-quic_srivasam@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Cc: Venkata Prasad Potturu , Srinivasa Rao Mandadapu X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Revert wait for enumeration from soundwire probe as it seems unnecessary and device enumeration is anyway not happening here, hence this api is blocking till it completes max wait time. Also, as device enumeration event is dependent on wcd938x probe to be completed, its of no use waiting here. Waiting here increasing the boot time almost 4 seconds and impacting other modules like touch screen. Revert: commit 06dd96738d618 ("soundwire: qcom: wait for enumeration to be complete in probe") Signed-off-by: Srinivasa Rao Mandadapu Co-developed-by: Venkata Prasad Potturu Signed-off-by: Venkata Prasad Potturu --- drivers/soundwire/qcom.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 5481341..9eb31ba 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -133,7 +133,6 @@ struct qcom_swrm_ctrl { struct dentry *debugfs; #endif struct completion broadcast; - struct completion enumeration; struct work_struct slave_work; /* Port alloc/free lock */ struct mutex port_lock; @@ -486,7 +485,6 @@ static int qcom_swrm_enumerate(struct sdw_bus *bus) } } - complete(&ctrl->enumeration); return 0; } @@ -1262,7 +1260,6 @@ static int qcom_swrm_probe(struct platform_device *pdev) dev_set_drvdata(&pdev->dev, ctrl); mutex_init(&ctrl->port_lock); init_completion(&ctrl->broadcast); - init_completion(&ctrl->enumeration); ctrl->bus.ops = &qcom_swrm_ops; ctrl->bus.port_ops = &qcom_swrm_port_ops; @@ -1309,8 +1306,6 @@ static int qcom_swrm_probe(struct platform_device *pdev) } qcom_swrm_init(ctrl); - wait_for_completion_timeout(&ctrl->enumeration, - msecs_to_jiffies(TIMEOUT_MS)); ret = qcom_swrm_register_dais(ctrl); if (ret) goto err_master_add;