From patchwork Tue Jan 26 14:09:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101079 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp1980986lbb; Tue, 26 Jan 2016 06:11:28 -0800 (PST) X-Received: by 10.98.66.139 with SMTP id h11mr34084359pfd.121.1453817488743; Tue, 26 Jan 2016 06:11:28 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xc4si2209967pab.244.2016.01.26.06.11.28; Tue, 26 Jan 2016 06:11:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757133AbcAZOLS (ORCPT + 30 others); Tue, 26 Jan 2016 09:11:18 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:54715 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756956AbcAZOLN (ORCPT ); Tue, 26 Jan 2016 09:11:13 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0MGAYZ-1aHgfq2d2l-00FC0a; Tue, 26 Jan 2016 15:10:29 +0100 From: Arnd Bergmann To: Hans de Goede , Mauro Carvalho Chehab Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] [media] pwc: hide unused label Date: Tue, 26 Jan 2016 15:09:55 +0100 Message-Id: <1453817424-3080054-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:N/LXzWLU7AzQzMoVs9zdG0Kdu9hALU3r3D3ylp60wdyw6HXhTL8 KkN+lGwDNhPahiNadqxqvoX19geGmMDqOW7GUkbkoK6lbLden3J6Q7Mia5WevLtYrNi510w 0H3WvL5m5TaNsdoMQRJzoEz8H+TMvnq6vZXHGCPBH/4lxFX2rYvRU8gWO43GSY8PG9ZEuzU Ei4wPtODflTYJFlVP7Aew== X-UI-Out-Filterresults: notjunk:1; V01:K0:dlmY3o4VsCk=:BnpMBWho8E3hyc+BSj9Qgv 5uaD4naqRO8ZD/lkOg6aeXmk3CoemDhoRgeMvgieGb3SWfQZv6PfJlMoNomOBuLHz+y889sVH AjTgtZqN1ADNDidyjRfvUCe+n/+pa7VvlXgW6ONxeM6mHbmm+Vas2wVnhHAo9rms42vMnR4+X 47AXTwxCECOXvTLbtvK1TCAUmHWs3T+nCvxx96/bDHdZcaI7XO/QCH3KOVaebOfF0N9+0gEOS 7Du0ZcTXDc6buSrSvXqIVC2MT6MzKmpGR4m8Jxd3CX0IFahqJjXuG07AnxOUHIXMQzoweFDyf jv9oY+RoijcnSOGep/Vvw1QczQG2cRXfk+8MhmnT9dXGqjyUBpFn62wX7wguE3vIFfqaKhAXR 5GzSWrdfDBJzpUp/llW9nmUDxdHaTm1qO/F/RoXQLOogR6jMRuxexZkVj8T3tNGGHCxJ+ZG7t 6cYpmw+KIPaw6iAEPPec3LURE3w93CoiFxf3PGmqLh0GmetSXXR+u6CXYIr4aXtGtv4sIwOGr vsoSvmV2JgeNJG6NUT0V4YJDz6yE0lWsA0nQyvBMe6NnSsy2wNSz6NVcpyz7EJWXlceqWf6D3 AVFKw6MYgXsYQXNnWm1/FKRCJr39c09HQlddQ4KaasvKDnkLJFKBmFw6Xrby4lvUsJcEiWpQb 6xr1Y6mVsrkBG3Rp5yNQPRLs3U4b5jCn3/Wt2UjPqLoyGI1Ac2Ya1VJi5YfxzHVoBxF0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pwc driver causes a warning when CONFIG_USB_PWC_INPUT_EVDEV is unset: drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe': drivers/media/usb/pwc/pwc-if.c:1115:1: warning: label 'err_video_unreg' defined but not used [-Wunused-label] Obviously, the cleanup of &pdev->vdev is not needed without the input device, so we can just move it inside of the existing #ifdef and remove the extra label. Signed-off-by: Arnd Bergmann --- drivers/media/usb/pwc/pwc-if.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.7.0 diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c index 086cf1c7bd7d..bdd416af84c7 100644 --- a/drivers/media/usb/pwc/pwc-if.c +++ b/drivers/media/usb/pwc/pwc-if.c @@ -1106,14 +1106,13 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id if (rc) { input_free_device(pdev->button_dev); pdev->button_dev = NULL; - goto err_video_unreg; + video_unregister_device(&pdev->vdev); + goto err_unregister_v4l2_dev; } #endif return 0; -err_video_unreg: - video_unregister_device(&pdev->vdev); err_unregister_v4l2_dev: v4l2_device_unregister(&pdev->v4l2_dev); err_free_controls: From patchwork Tue Jan 26 14:09:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101087 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp1981001lbb; Tue, 26 Jan 2016 06:11:30 -0800 (PST) X-Received: by 10.66.141.109 with SMTP id rn13mr33503745pab.83.1453817489205; Tue, 26 Jan 2016 06:11:29 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xc4si2209967pab.244.2016.01.26.06.11.28; Tue, 26 Jan 2016 06:11:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757253AbcAZOL0 (ORCPT + 30 others); Tue, 26 Jan 2016 09:11:26 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:57549 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757136AbcAZOLV (ORCPT ); Tue, 26 Jan 2016 09:11:21 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0MEEDQ-1aLoCr02sS-00FU3P; Tue, 26 Jan 2016 15:10:45 +0100 From: Arnd Bergmann To: Hans Verkuil , Mauro Carvalho Chehab Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] [media] hdpvr: hide unused variable Date: Tue, 26 Jan 2016 15:09:56 +0100 Message-Id: <1453817424-3080054-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1453817424-3080054-1-git-send-email-arnd@arndb.de> References: <1453817424-3080054-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:KJPfS55XE17nbMC+asF4ek31DgjkULWWBdlVhrWVJVDy9MZrukD ShWegEl4YatHcw5ar+BVMuh4IndhJfmnKEKOSFR/P7IzvkIuhrk9x468FICajegKCQ4wcC1 ENBdH4vPolsHkKZV4tEsaF3RerMNrd/xWprmNG2tA2+P8j1zkMmcFOAwWNczhoIq9TImXED Tuyj0WiDIlqnwDlTqDs6w== X-UI-Out-Filterresults: notjunk:1; V01:K0:cnY+032lXgU=:A0VEB0nL2xfyTqqpgMcvhn bxSNsyBfCh676v58aZCwYO5cWCg46lKJLuV8CMIweHvPJ1YML1r2pGyrPp0qPRAA38ExdgSe/ 3QA/PkjbLP8fj2v4BAHD9vaQ/6tPjE2CMCiTBiIJQU76uO+QO3EJJcvQjWqLY+CHrZiR7naE/ gAiQ8Uk9rJgDB2E2JqnVunPmyWgRN7Js3GWW3xXE1ixVpPh8jR/921t6exNNt/5NwbZtoQ3I0 g6F55xPRwPfhlS7QlpmOljxMbtDCoEHKwHsMjrhE6GhZ3b3g5+VkCC5rjO6q5bzQIjnDZpWEZ NuY+CeuGdSy6i+gagYRgtCsqgs0nAn/UySKCSkKjzzaH6V/l8lNlgu/FQkCDrDQom4AyJnfO4 AjTU/S0lk10nR+AYddRQJROOE5xLNAAVlVz5vJ9E7fCxelBBjfACPvaltFu+2N7ZyFuwiQrRn ht6nG8LYJhuR8q+CBAAG+qDc0dzGs4zR778c1dqKvx6tHUHuXuH4/FdXcF07mIi/EegUaItU1 lsecKRE1fw9ZQ3yHQnWLBFBkdCzi/eflSpwU9L9ehpR51I04rxUy6rbmcJpw+Ol8ibhxSxG0z bykfb16lNJt6Kqv+wII4oej5opWgUCm1T4Xs36zdGcVuplZ2Kw6H0eXiwDIuHD2TfyKkfXCzv O3OvANxhsyHAlNWeMBqCLPCoS2jMnUMGYlGNgb8EXnaDGpHP3W4Splq6XU+pr8rlPaD0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The i2c client pointer is only used when CONFIG_I2C is set, and otherwise produces a compile-time warning: drivers/media/usb/hdpvr/hdpvr-core.c: In function 'hdpvr_probe': drivers/media/usb/hdpvr/hdpvr-core.c:276:21: error: unused variable 'client' [-Werror=unused-variable] This uses the same #ifdef to hide the variable when the code using it is hidden. Signed-off-by: Arnd Bergmann --- drivers/media/usb/hdpvr/hdpvr-core.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.0 diff --git a/drivers/media/usb/hdpvr/hdpvr-core.c b/drivers/media/usb/hdpvr/hdpvr-core.c index 3fc64197b4e6..08f0ca7aa012 100644 --- a/drivers/media/usb/hdpvr/hdpvr-core.c +++ b/drivers/media/usb/hdpvr/hdpvr-core.c @@ -273,7 +273,9 @@ static int hdpvr_probe(struct usb_interface *interface, struct hdpvr_device *dev; struct usb_host_interface *iface_desc; struct usb_endpoint_descriptor *endpoint; +#if IS_ENABLED(CONFIG_I2C) struct i2c_client *client; +#endif size_t buffer_size; int i; int retval = -ENOMEM; From patchwork Tue Jan 26 14:09:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101086 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp1981184lbb; Tue, 26 Jan 2016 06:11:49 -0800 (PST) X-Received: by 10.98.87.204 with SMTP id i73mr33856211pfj.63.1453817509018; Tue, 26 Jan 2016 06:11:49 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l82si2274054pfb.158.2016.01.26.06.11.47; Tue, 26 Jan 2016 06:11:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757348AbcAZOLq (ORCPT + 30 others); Tue, 26 Jan 2016 09:11:46 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:54839 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757136AbcAZOLn (ORCPT ); Tue, 26 Jan 2016 09:11:43 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0M4I0B-1a5iGp2CAt-00roXA; Tue, 26 Jan 2016 15:11:04 +0100 From: Arnd Bergmann To: Hans de Goede , Mauro Carvalho Chehab Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Hans Verkuil , Leandro Costantino , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] [media] gspca: avoid unused variable warnings Date: Tue, 26 Jan 2016 15:09:57 +0100 Message-Id: <1453817424-3080054-3-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1453817424-3080054-1-git-send-email-arnd@arndb.de> References: <1453817424-3080054-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:CguCPt/JTmi/dwxI6iPwVVeLBkn5F1EfuYe/mpByaXLEsj/myT/ YiGwyf+UkfQy0yYRLlNOt1RcocdhQjh8TrcDI1Fh4NJZwK8b+eNEsaJT8/Ma1xc98Z8ph4l p/Ra6HiR51BqoUbowt5XkONLGFchZvf9BH4NcZIUiUsRLxwsVD/RuDDhGBqmevRyUpSChjf dcdABV35jXeC+r67OBJhw== X-UI-Out-Filterresults: notjunk:1; V01:K0:0+OLaIuJP84=:2V4NMBu7rTJqp9qJMEh10X qPQRImFmY3dqI6EK0i377lLYgSQcS1iP98CNRHAXd7gs/7eNbZniSXudupbzPExWKSejLlJsD 3w+tYznoqDagIXXwLzdh4bPHgymHoaFiFuOwdYXdS04Mzpnv4MGFqtZETu031Qz7CNS0k3a7m ZvzoL4bF97Lwt1JK7NFJw8T63f2Uy57md1W/M0cVKzatJ6VXsUb4tfpi5SteM6jYm0NnJgNue 883g20ogpzzeqq6UqYQ2LkdhXOougIJzwBEuEdJPxu1zM7rV8mAObGH0x9bokPOQLl5wsWIJC iYdisDxa/OAV0WEl/mFO3Judv0XzaRi8OJoWBl+Me0gVaNR1ml3fg9I26VGjQ0KZyY7Z4aG7P B8j9bMwCShPtVq44KHuZdxYaRc+T+RB67JA5u84gUSKRL7Ylfq6ihaKBRufG41jjfgwc6XYYf 1rVQRB9/qQMW0MY6skI+v2fYtbi4P8bKjR/zgYuxbNuedURwaJv/MEUpbpxqa/p/EVP9QS0Hq 6TQzWIimG0GPYLiLpn9WCR0lHWm1SGJuSHcTe+ZA97zQcxxiqft9dZsjUtzYsH57F1aX3IDC2 Z8z23t+kONlJtKgPeIZ1e2muu0mQPMyP/3yhaqmebwmdP5rsqH0viBw2n5lWceZCVt86/3S5J DyJvSqrnD9rbWdo3RZYm0s+Q9vYHjUPgKquIdC5q1qOd3hE48eyVsa5Udw/u6y2uK4Bo= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_INPUT is disabled, multiple gspca backend drivers print compile-time warnings about unused variables: media/usb/gspca/cpia1.c: In function 'sd_stopN': media/usb/gspca/cpia1.c:1627:13: error: unused variable 'sd' [-Werror=unused-variable] media/usb/gspca/konica.c: In function 'sd_stopN': media/usb/gspca/konica.c:246:13: error: unused variable 'sd' [-Werror=unused-variable] This encloses the declarations in #ifdef CONFIG_INPUT, just like the code using them is. Signed-off-by: Arnd Bergmann Fixes: ee186fd96a5f ("[media] gscpa_t613: Add support for the camera button") Fixes: c2f644aeeba3 ("[media] gspca_cpia1: Add support for button") Fixes: b517af722860 ("V4L/DVB: gspca_konica: New gspca subdriver for konica chipset using cams") --- drivers/media/usb/gspca/cpia1.c | 2 ++ drivers/media/usb/gspca/konica.c | 2 ++ drivers/media/usb/gspca/t613.c | 3 ++- 3 files changed, 6 insertions(+), 1 deletion(-) -- 2.7.0 diff --git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c index f23df4a9d8c5..e2264dc5d64d 100644 --- a/drivers/media/usb/gspca/cpia1.c +++ b/drivers/media/usb/gspca/cpia1.c @@ -1624,7 +1624,9 @@ static int sd_start(struct gspca_dev *gspca_dev) static void sd_stopN(struct gspca_dev *gspca_dev) { +#if IS_ENABLED(CONFIG_INPUT) struct sd *sd = (struct sd *) gspca_dev; +#endif command_pause(gspca_dev); diff --git a/drivers/media/usb/gspca/konica.c b/drivers/media/usb/gspca/konica.c index 39c96bb4c985..21c52655ef28 100644 --- a/drivers/media/usb/gspca/konica.c +++ b/drivers/media/usb/gspca/konica.c @@ -243,7 +243,9 @@ static int sd_start(struct gspca_dev *gspca_dev) static void sd_stopN(struct gspca_dev *gspca_dev) { +#if IS_ENABLED(CONFIG_INPUT) struct sd *sd = (struct sd *) gspca_dev; +#endif konica_stream_off(gspca_dev); #if IS_ENABLED(CONFIG_INPUT) diff --git a/drivers/media/usb/gspca/t613.c b/drivers/media/usb/gspca/t613.c index e2cc4e5a0ccb..d918c2d31502 100644 --- a/drivers/media/usb/gspca/t613.c +++ b/drivers/media/usb/gspca/t613.c @@ -837,11 +837,12 @@ static void sd_pkt_scan(struct gspca_dev *gspca_dev, u8 *data, /* isoc packet */ int len) /* iso packet length */ { - struct sd *sd = (struct sd *) gspca_dev; int pkt_type; if (data[0] == 0x5a) { #if IS_ENABLED(CONFIG_INPUT) + struct sd *sd = (struct sd *) gspca_dev; + if (len > 20) { u8 state = (data[20] & 0x80) ? 1 : 0; if (sd->button_pressed != state) { From patchwork Tue Jan 26 14:09:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101084 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp1981740lbb; Tue, 26 Jan 2016 06:12:42 -0800 (PST) X-Received: by 10.98.16.27 with SMTP id y27mr34344015pfi.33.1453817562162; Tue, 26 Jan 2016 06:12:42 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v86si2334071pfi.16.2016.01.26.06.12.41; Tue, 26 Jan 2016 06:12:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757456AbcAZOMb (ORCPT + 30 others); Tue, 26 Jan 2016 09:12:31 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:62932 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757356AbcAZOMR (ORCPT ); Tue, 26 Jan 2016 09:12:17 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0Lj2f0-1ZpXkA1RLK-00dJYL; Tue, 26 Jan 2016 15:11:48 +0100 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] [media] em28xx: only use mt9v011 if camera support is enabled Date: Tue, 26 Jan 2016 15:09:59 +0100 Message-Id: <1453817424-3080054-5-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1453817424-3080054-1-git-send-email-arnd@arndb.de> References: <1453817424-3080054-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:pam+EteejU3P4zgd1NnZPWF6BXW/0JGNKXMvRyH9wZACUODP39f oOmpFlnyM16t7BlxIkvArDiUDSHW39bhugUdVzyUBmKnS85Vj6YC7As8Qgrgb3iBHu1763Z 8h3nwcf2n6ZVJiiz1g3KYgPF84UUANcFsZ0n+hzfRACDQjlosMTgOTGFxcw/eqXgu0VUuat L5ZEA6pkuqFOXDaYp76vA== X-UI-Out-Filterresults: notjunk:1; V01:K0:cgenjSk76OA=:p6Is5Tngp2FgemCXcF1FDx 9igYzfPbrrY7VJ07czSZ6W6+wUH0pRAxfcEtpgMX3YLgPk9xDE38kytJEy9GQTl52hjGeqCmJ XzyjIo9bQZDT3H2AN+bhkibZLfN+9Xi0hWuD6EKWL91MKvxkuHCqbIl5zvtlrd85PdJLY5zlE eugEgS9eKGpQowy9OjdVkuZ+1vQT3ltANWuM6Bg9B1wWYC3Bjfh/AqxjGETjVNsY8XA+OxmlE LYjo6CYVN/qiF65XbzIansKWVtz4t8HvC4fHaA2zG3J78ajUTLgCWlm/x6BPqphdWKAKAlsjc dNgGOKF1YOPHSADQN2WVzsaGTFdCxO+B39V3I/efUDg1XluTcdsdEZgjkTU9ZOq63jM7cWNal Isvlo5s+MeUHDsvvLFfL+zJfSIsBNKfifd7j4sFXZpPWyp6WyAcQjEgyE+VGjq9Q3FDtmpzMS vdUrCC3Wc0XdtFAoO6Vwv4Pn7eii1Aow4fwMn0BRTpMTuntl+mm3GDNyhBI9eAfO16jpKJ3ES uY2iql7Qw+RfzjOlIJQjSkk+GPRu+AL/reHC7/LaUuWsJDh1jT2vHmH6ENr8q2w9IPBT4A/Rz 3z5dvPye+la6RaQg3oK6L/dEureli3+ZyyMX7wvoDBBFbJbKIsEcLonKPS8SOvfieGQQhbUzQ qHcAwTGQH6XvTyRFz+AkjwSHOJuL9wCAEIu/xYcQTVyWurWJ1gAeMjJtkp/h+xExi8X0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In randconfig builds that select VIDEO_EM28XX_V4L2 and MEDIA_SUBDRV_AUTOSELECT, but not MEDIA_CAMERA_SUPPORT, we get a Kconfig warning: warning: (VIDEO_EM28XX_V4L2) selects VIDEO_MT9V011 which has unmet direct dependencies (MEDIA_SUPPORT && I2C && VIDEO_V4L2 && MEDIA_CAMERA_SUPPORT) This avoids the warning by making that 'select' conditional on MEDIA_CAMERA_SUPPORT. Alternatively we could mark EM28XX as 'depends on MEDIA_CAMERA_SUPPORT', but it does not seem to have any real dependency on that itself. Signed-off-by: Arnd Bergmann --- drivers/media/usb/em28xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.0 diff --git a/drivers/media/usb/em28xx/Kconfig b/drivers/media/usb/em28xx/Kconfig index e382210c4ada..75323f5efd0f 100644 --- a/drivers/media/usb/em28xx/Kconfig +++ b/drivers/media/usb/em28xx/Kconfig @@ -11,7 +11,7 @@ config VIDEO_EM28XX_V4L2 select VIDEO_SAA711X if MEDIA_SUBDRV_AUTOSELECT select VIDEO_TVP5150 if MEDIA_SUBDRV_AUTOSELECT select VIDEO_MSP3400 if MEDIA_SUBDRV_AUTOSELECT - select VIDEO_MT9V011 if MEDIA_SUBDRV_AUTOSELECT + select VIDEO_MT9V011 if MEDIA_SUBDRV_AUTOSELECT && MEDIA_CAMERA_SUPPORT ---help--- This is a video4linux driver for Empia 28xx based TV cards. From patchwork Tue Jan 26 14:10:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101077 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp1981627lbb; Tue, 26 Jan 2016 06:12:31 -0800 (PST) X-Received: by 10.66.156.134 with SMTP id we6mr34158793pab.92.1453817551038; Tue, 26 Jan 2016 06:12:31 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5si2275571pfa.151.2016.01.26.06.12.30; Tue, 26 Jan 2016 06:12:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757429AbcAZOM3 (ORCPT + 30 others); Tue, 26 Jan 2016 09:12:29 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:56715 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756544AbcAZOMY (ORCPT ); Tue, 26 Jan 2016 09:12:24 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0MA5UH-1aH9W53l29-00BNJa; Tue, 26 Jan 2016 15:11:53 +0100 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/7] [media] em28xx: add MEDIA_TUNER dependency Date: Tue, 26 Jan 2016 15:10:00 +0100 Message-Id: <1453817424-3080054-6-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1453817424-3080054-1-git-send-email-arnd@arndb.de> References: <1453817424-3080054-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:ddrAnJoApqApUXPQJ2sUI9kuGFzRqdahIitTWTBOjmqFzWptBMq E8D3IjENcq9GIIahs3P2NC21RLs5KXvSM7dAbir24I2g4orXwec7brxP29II/O4ILTBejkP ZVbHd7OVLJV8jdHxziKoVn64tPV+EGfSbotNHcWYca+74GtH5r6P/TTqschg/J0qoPUwAfT DerPk4MZ1cVmMjTDGVXuw== X-UI-Out-Filterresults: notjunk:1; V01:K0:UK2ZaHElWX4=:OwhNm+AxTQMrHj2kLVxOaW /fhRYldYu+cOn9On7zxaeLaImRSdajDj/vbaKeIrBiL6WzDQTqwE0nBSXYKWJCHuhH2Cz/QOc z9CZo91MtqeTJGf28/OFAYc4QieXeagp4mRwPhTrqWOth7nZu765UlO8sKT0W04NzkYcfbZoT plMmSM8FycdwsAH08HN6PBadrmQcVYk0+xgXQUKixK71+OZUgzNAnf2MZyQ6ZEtXJlVsvFsIm O2RDBvlxxe9DGlrHY+uGxoEcuicSEORDxRDFs3fR+mA1Ww+NynsnwPsq213o7h1Ul7wtCtRZN NRxqBEiW9Pgdd/OtbxB6GxucwY3VKzCoEmQ7zXf30Z4jvHeDy01DF7pr+kCZU5DYvVq5D7YkT ZexIvUgSKn9s90sH0u6sFjhsGh5u6SXBSE3FiKoD2Xk306IrDnA5wMeJzB3ObNw33nGFGpG8T O+2BgmEjeR1SylFB3dIUSCvVWWZxwEWKCRhr/FVqa2VpPT2OqfosenmNzPffWMXWSQcN5Bvgk TA+/Os3XuOSVHE5nI1GLFZsuAHFOR7G7LyJR4ByCFBXF90qItbDwmtojYW7Yf69e5vLv1nwAz 5LPrGsuOaQwmrfncBigMj6kF7q0tbrOim5QYcYWYOdD2QBVGLs9s1XK4AHB7dfIlj6VFzoDIJ Jr0p6WJBr6K7eg75yrWHAD8rK506519AtYlbRzLmzStKyxuZWtv6cOMyVy450DLc1ZlU= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org em28xx selects VIDEO_TUNER, which has a dependency on MEDIA_TUNER, so we get a Kconfig warning if that is disabled: warning: (VIDEO_PVRUSB2 && VIDEO_USBVISION && VIDEO_GO7007 && VIDEO_AU0828_V4L2 && VIDEO_CX231XX && VIDEO_TM6000 && VIDEO_EM28XX && VIDEO_IVTV && VIDEO_MXB && VIDEO_CX18 && VIDEO_CX23885 && VIDEO_CX88 && VIDEO_BT848 && VIDEO_SAA7134 && VIDEO_SAA7164) selects VIDEO_TUNER which has unmet direct dependencies (MEDIA_SUPPORT && MEDIA_TUNER) This adds a dependency on MEDIA_TUNER to avoid the warning. Signed-off-by: Arnd Bergmann --- drivers/media/usb/em28xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.0 diff --git a/drivers/media/usb/em28xx/Kconfig b/drivers/media/usb/em28xx/Kconfig index 75323f5efd0f..cacc757e2254 100644 --- a/drivers/media/usb/em28xx/Kconfig +++ b/drivers/media/usb/em28xx/Kconfig @@ -1,6 +1,6 @@ config VIDEO_EM28XX tristate "Empia EM28xx USB devices support" - depends on VIDEO_DEV && I2C + depends on VIDEO_DEV && I2C && MEDIA_TUNER select VIDEO_TUNER select VIDEO_TVEEPROM