From patchwork Thu Apr 21 16:23:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 565280 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E3DBC43219 for ; Thu, 21 Apr 2022 16:24:55 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BCEC5164E; Thu, 21 Apr 2022 18:24:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BCEC5164E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650558293; bh=Ev5XW/hFAU2G7hEDOc8XRChJVIkYPecoTCVxax3VuEI=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=WJXLXo4CUsxWFtI49mERpTtrFmST6bY940FE1RC4ok55EZN1W54SgOPHYqIQ4t5Ux eRgd0DauL+f04+YOEC2Wov1/YAcWrDXVX1vIWU+r019c10t/8rcFtZUbSQmglFrURd 5Ln1Mw/4BUdGFydZf88sfoO+YHZ4u5I5FWzOoAjY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 32B09F80279; Thu, 21 Apr 2022 18:24:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 53BEEF8032D; Thu, 21 Apr 2022 18:24:01 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6D918F80125 for ; Thu, 21 Apr 2022 18:23:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6D918F80125 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZIvpccF0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650558235; x=1682094235; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Ev5XW/hFAU2G7hEDOc8XRChJVIkYPecoTCVxax3VuEI=; b=ZIvpccF0ZxmG3rU5HQ/WFFYODwyoGM7F7vKkzOwx9ztSmyML932QHUHh 1/x2lkvGMatfVpCp+ycGb5msx2RZoCUNVYE/cfYiXs0SdB2gX3BDLmnDh iLuGwqgsZqFA8y5UP20pekFjvZ98LR0mQrO6hWw8lzrnqyjHaOeqqu+xS ScTWelj9QxKpIQLcLL0lXMBQ/+0xV7xAYMM9Ph+vfbgHm6nxuAPCRXdDZ oshnZzrH9fmyBfHs5Ryvu1zAxyi7xSO8u5pZzDUxHFK0pjeIf6bqatorG 1ifBfuml/JqeiIxnEtgxn89oI8rQoa3ZgMNGOqdQTYk4Cx+657OgZpW66 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="264176427" X-IronPort-AV: E=Sophos;i="5.90,279,1643702400"; d="scan'208";a="264176427" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 09:23:50 -0700 X-IronPort-AV: E=Sophos;i="5.90,279,1643702400"; d="scan'208";a="533414777" Received: from qingsu-mobl.amr.corp.intel.com (HELO pbossart-mobl3.amr.corp.intel.com) ([10.212.148.250]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 09:23:49 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH] ASoC: soc-ops: fix error handling Date: Thu, 21 Apr 2022 11:23:28 -0500 Message-Id: <20220421162328.302017-1-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Cc: tiwai@suse.de, Bard Liao , Pierre-Louis Bossart , Rander Wang , broonie@kernel.org, =?utf-8?q?P=C3=A9t?= =?utf-8?q?er_Ujfalusi?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" cppcheck throws the following warning: sound/soc/soc-ops.c:461:8: style: Variable 'ret' is assigned a value that is never used. [unreadVariable] ret = err; ^ This seems to be a missing change in the return value. Fixes: 7f3d90a351968 ("ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_sx()") Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Rander Wang Reviewed-by: Péter Ujfalusi --- sound/soc/soc-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c index a0ca58ba16273..58347eadd219b 100644 --- a/sound/soc/soc-ops.c +++ b/sound/soc/soc-ops.c @@ -461,7 +461,7 @@ int snd_soc_put_volsw_sx(struct snd_kcontrol *kcontrol, ret = err; } } - return err; + return ret; } EXPORT_SYMBOL_GPL(snd_soc_put_volsw_sx);