From patchwork Wed Dec 26 21:50:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 154536 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp6274401ljp; Wed, 26 Dec 2018 13:50:40 -0800 (PST) X-Google-Smtp-Source: AFSGD/Why86q+IFMfW9dxQNF2Q9aE0dLTCGjeSEnfCha475iVJ754d2O53WYvNlPIuGoDQc8P30j X-Received: by 2002:ac8:3914:: with SMTP id s20mr20222592qtb.294.1545861039965; Wed, 26 Dec 2018 13:50:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545861039; cv=none; d=google.com; s=arc-20160816; b=m9JDMl2110tXNyJbRXvrU5Mk8nNJLHvXSZ13Uk3IEKxA61VEV/05luXiWX8ZxDza8M CYtszGr11nKu1RCTN+den/FHN8qn3mZtU/ITInDmqR9fU1+P/2ghkpi5coljKvHbgYEx xj2inb4emjtSl5GG5cD9juSzC18FZsXab2CdsQ7EYF7lE/QtYjyaTMWKegZdHTQ0gNBz dB6wRjjN8gt1oypz0hmFnjEuEHELkuEtv2XPH8p9w4vPB+cjmr/FHkyyGWk2v8k1Fmh+ Z8/+owUz38cIZgQQMcQ+oZvq1ZHTyXU/RewWGcb09eH9tCmJ15xGLKmrVns8dyr+Lyn1 oLpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature; bh=c2L54HAaHaZWMq9S4zEElrE2kFyMc5i7bbxx8z9XKWo=; b=HheHp+PSRIeEBqotEDE+70CwWMIXbOFl0Z5Gl+9Znt2o5jDuxZNLVdKhc5q0XKAlMz IGIesSYMOKm/Ua7IXTCSAYegAtJIP9AhSmnU4IlSNwuF9Dccts0wR7a2Xfj/fiNNserG FCbfNTwkeW2FOUscxcu1juv02MeOSwmITDPqigfroV89Xcq3l8Rp1rn8dC00ZbwzMmkL BG3pQLYzER1f4OqHhgay/toSPv9zmdEHf4ocqRA2phs9JMdwtepwi6EKXe4Y9CGBgK2r lu/M2haD4aV9GrHhHZjRoB33fP3WTc6QbaYKK/U6UNzksnDalbEnGCZZa613GHwKSw2A DTVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=X2OnEUnH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from listsout.gnu.org (listsout.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w54si5174085qtk.68.2018.12.26.13.50.39 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 26 Dec 2018 13:50:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=X2OnEUnH; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:48394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcH4Z-0007ei-Gs for patch@linaro.org; Wed, 26 Dec 2018 16:50:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcH4P-0007ec-Ma for qemu-devel@nongnu.org; Wed, 26 Dec 2018 16:50:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcH4M-0006nu-Ef for qemu-devel@nongnu.org; Wed, 26 Dec 2018 16:50:29 -0500 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:35506) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gcH4M-0006d8-6c for qemu-devel@nongnu.org; Wed, 26 Dec 2018 16:50:26 -0500 Received: by mail-pl1-x642.google.com with SMTP id p8so7961190plo.2 for ; Wed, 26 Dec 2018 13:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=c2L54HAaHaZWMq9S4zEElrE2kFyMc5i7bbxx8z9XKWo=; b=X2OnEUnH4ma5r7OWqEEOR6IOXTT4nBwZnTm2CBMl6ZfpfrFKG4VZecCOVr98FC3LUz wkl96sSixWJMrPYlnwoH3FJyZxOnzMzW8fJ1+HHlO0oLxT7zj/O9EJcYm1pJQpW9xNsb zX9cyCnL6nlVSgvpdeXKXay1mfIeRYPlbCtAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=c2L54HAaHaZWMq9S4zEElrE2kFyMc5i7bbxx8z9XKWo=; b=ENQoLEOe+gSxFaf5yL1CfDPJh5CK/sDjf69xr99qgjmjexKdC/C1PqhctXXfArcfl7 iQ1XKrjhallC0MgAmtY+KdTT+AZ+5uRiLB0yzcqYmJKFLK4Ol6B+57fBHPTvzSXv0RP2 /EFcXsjbhWQMlE7kqTAC2j32oTtdyrjKKsDjDXPxPwSi9yWMxHK3PiF+hLPxWy+R1n3V zsOLAMcX9/qPOG3iyhq2eCVT32patbUd4v40t5VvBA5XkBIKxgKsDBwSEiiJPrP+wTcK OUAKMUu09PUH22W7BlcdhBshhRjQlnWsZM4ahJcKO/2WbzwKtNyrWd8zpnpqVHqBY06L w9cg== X-Gm-Message-State: AJcUuke7zH9RI/InM3c7FZtPgmLOPO7rYZWVYeE1OxcJi3PO2qrQodoy PG9R/jSzxs05iW55y6WC+8WJfu+2+O+zuA== X-Received: by 2002:a17:902:6b83:: with SMTP id p3mr21141813plk.118.1545861014132; Wed, 26 Dec 2018 13:50:14 -0800 (PST) Received: from cloudburst.twiddle.net (c211-28-135-144.sunsh3.vic.optusnet.com.au. [211.28.135.144]) by smtp.gmail.com with ESMTPSA id d68sm50755148pfa.64.2018.12.26.13.50.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Dec 2018 13:50:12 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 27 Dec 2018 08:50:03 +1100 Message-Id: <20181226215003.31438-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::642 Subject: [Qemu-devel] [PATCH] target/arm: SVE brk[ab] merging does not have s bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" While brk[ab] zeroing has a flags setting option, the merging variant does not. Retain the same argument structure, to share expansion but force the flag zero and do not decode bit 22. Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- The xml from which Alex and I extracted risu test cases does not call out bit 22 as a field, so we did not test this illegal encoding. r~ --- target/arm/sve.decode | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.17.2 diff --git a/target/arm/sve.decode b/target/arm/sve.decode index e10b689454..4f580a25e7 100644 --- a/target/arm/sve.decode +++ b/target/arm/sve.decode @@ -99,6 +99,7 @@ # Two operand with governing predicate, flags setting @pd_pg_pn_s ........ . s:1 ...... .. pg:4 . rn:4 . rd:4 &rpr_s +@pd_pg_pn_s0 ........ . . ...... .. pg:4 . rn:4 . rd:4 &rpr_s s=0 # Three operand with unused vector element size @rd_rn_rm_e0 ........ ... rm:5 ... ... rn:5 rd:5 &rrr_esz esz=0 @@ -667,8 +668,8 @@ BRKPB 00100101 0. 00 .... 11 .... 0 .... 1 .... @pd_pg_pn_pm_s # SVE partition break condition BRKA_z 00100101 0. 01000001 .... 0 .... 0 .... @pd_pg_pn_s BRKB_z 00100101 1. 01000001 .... 0 .... 0 .... @pd_pg_pn_s -BRKA_m 00100101 0. 01000001 .... 0 .... 1 .... @pd_pg_pn_s -BRKB_m 00100101 1. 01000001 .... 0 .... 1 .... @pd_pg_pn_s +BRKA_m 00100101 00 01000001 .... 0 .... 1 .... @pd_pg_pn_s0 +BRKB_m 00100101 10 01000001 .... 0 .... 1 .... @pd_pg_pn_s0 # SVE propagate break to next partition BRKN 00100101 0. 01100001 .... 0 .... 0 .... @pd_pg_pn_s