From patchwork Mon Jan 7 06:58:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 154869 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3180372ljp; Sun, 6 Jan 2019 22:59:02 -0800 (PST) X-Google-Smtp-Source: AFSGD/U67HPHy0NRlosK5u3DWF67jsDTZVRqav4eFBaQPolftCEzseqV3EPTn9KimnzKNLw+zzIi X-Received: by 2002:a62:4156:: with SMTP id o83mr61782639pfa.72.1546844342726; Sun, 06 Jan 2019 22:59:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546844342; cv=none; d=google.com; s=arc-20160816; b=ju3pLCykDZIXuH9i4tQ0mZOiNnK6xKzzeo7I9GOdN4frAI0RJUzfrTgtWLws3G9PAo l4EQbwmuiEBUvq4QrsQsrLU3L9enoxJRXCIjltn351kOc5omXxWoMTuhn6gzEzVmGOjs /aNfCavKn9mUrz4lF5FR44WEYLhe9kJqkk+hrBMCXplLz/+2DqxlQDgBdjn8hKFoz+WS aK9I9VBGpRIhwmuZNn8q81bh7136KwtJUzlWJDwXcTN/x3NvISwqucBPFDXfCGoRo+M3 b1qJaNr1xNYs+Qvz45r76xyElhSgBQVrpLIJB3Dh6Xh4JPbvG8C3gHLQdH4KM4avQ3xU HYeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=aPcQQ3g+VFcLyuhwjnxAyzEpHmVwskJ1oHM3n1Kx1ls=; b=xwqDxk1UtPfo4YwmKC98xRNWyqzAfukE/fE8qXmuPUr6vjfPPYJrp4art3JgLPx0JQ pYavImIvJho7YWHHwIgstIKv0i0Bny0bnnCk+XEE25Biujd3fQlIC/1EnmJpWdnfsBJe idNRd6SDR9NU0cShwrqjoSflAI3UdAOJeEEvoJcGkq5Nr+SZsNa6F+/KQCEJBsfPchof nFtLe6RGMKRvOmV4oMmm/vIxTJrIBygtnL/Mvfb8berxVDtYCMvueTYRM8/dNQ38tWex LDG7q7Q7LdMt/+cHIugc63gScCimyZS2mWwjC+pxGQxo84a9L4HjvNPlHD/VEdSWe8ob nxzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KxlJt7VQ; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c30si52298204pgn.52.2019.01.06.22.59.02; Sun, 06 Jan 2019 22:59:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KxlJt7VQ; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726427AbfAGG7B (ORCPT + 11 others); Mon, 7 Jan 2019 01:59:01 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43404 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbfAGG7B (ORCPT ); Mon, 7 Jan 2019 01:59:01 -0500 Received: by mail-pf1-f196.google.com with SMTP id w73so21366421pfk.10 for ; Sun, 06 Jan 2019 22:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aPcQQ3g+VFcLyuhwjnxAyzEpHmVwskJ1oHM3n1Kx1ls=; b=KxlJt7VQvW8gSUxmmibJiBl+6oBaF5cV7NHkopfC7jQgfmUlPcQ4xmPvePXaoTjNW1 WiHIIYt6/bt7UWZEEyBIWmxbiya1mYyoLde1avWUX+gMPvFSSUbOXZAYmAmN1j19Ecif sLj1lT/Ondkx2oziZ2PnlligrZW7o9UQzrlk8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aPcQQ3g+VFcLyuhwjnxAyzEpHmVwskJ1oHM3n1Kx1ls=; b=Lsu49Sg4y5sjPdoetz9alqPjZNnPypaPjAmugRT+9Wii6xQ0RZeYApP/yyddXsba5W eNDaeMeYH5dxj1WwZsqXHRTwlpqOIm/3TId1bQPGtmVUu0e3Bq6CcFHO8WPepNv+/cUb IFNKTwOFoWamxvagtkKAefPaxx3U9ou4Vbcmk5lLQq2464hNgOsBz73oXCbomJfKLDad lpsMTv+9gn9cCfIkbf4d1gTgRfbJuY5QJib1+x3lGv752D5MwBPXHihFlIgQpIvUPMam Bkxne3jg5HMEHyo34l3ddPUwz699ht7yglLtFZ9rRpBO2HdIHLUXL4fwfUVmkD95lcSc Oicw== X-Gm-Message-State: AJcUukcEgWbJoQHmv2SrZdLtdWOmXCHJJtTnitmCUQMv0aqHYvgQcyuw uweWASECi3ur4I5FUjejJarQtw== X-Received: by 2002:a63:f615:: with SMTP id m21mr10174823pgh.428.1546844340557; Sun, 06 Jan 2019 22:59:00 -0800 (PST) Received: from localhost ([122.166.131.155]) by smtp.gmail.com with ESMTPSA id h129sm117827620pfb.110.2019.01.06.22.58.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jan 2019 22:58:59 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: Don't update new_policy on failures Date: Mon, 7 Jan 2019 12:28:54 +0530 Message-Id: X-Mailer: git-send-email 2.19.1.568.g152ad8e3369a MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The local variable "new_policy" isn't getting used in the error path since the commit f9f41e3ef99a ("cpufreq: Remove policy create/remove notifiers"). Don't update it in error path. Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq.c | 2 -- 1 file changed, 2 deletions(-) -- 2.19.1.568.g152ad8e3369a diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 7aa3dcad2175..9a5f82ef40e8 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1305,8 +1305,6 @@ static int cpufreq_online(unsigned int cpu) if (ret) { pr_err("%s: Failed to initialize policy for cpu: %d (%d)\n", __func__, cpu, ret); - /* cpufreq_policy_free() will notify based on this */ - new_policy = false; goto out_destroy_policy; }