From patchwork Thu May 19 13:47:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Meng, Li \(Jassmine\)" X-Patchwork-Id: 574826 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6352C433EF for ; Thu, 19 May 2022 13:52:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbiESNwj (ORCPT ); Thu, 19 May 2022 09:52:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239243AbiESNuR (ORCPT ); Thu, 19 May 2022 09:50:17 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on20603.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e8c::603]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA73640A28; Thu, 19 May 2022 06:50:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DmmAtnd0ZxhJOu/aeyHjY4vpS+UkONk51tF6c/pAgA5wkN3c80QJuNC0hmz3mUhko1xukLJ+MkvMWL+nNqrskNwkicagyonDx41VY9pQnOjwnJYDV7ZdIGHxrqfW2D4HN1CkQQLAcyKqLb6qksAKaSJxpdax193UCJljzQFUeIspyM5PKmAc5YpdXut7u18Vg5+oySBpGkcRiyFLZyyf7071TqrUnlHyFc9aTx2uKsXGSGgbrm86XX9B+bxOirjw4aCb6W23oaLiYL9X8zW/9hI7RnDI7/QwYA28nWMGyeT3lmu4sijrfef8lP9e7EZPaYPI6hN3o6znfomnWqZHXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EX2QXIj8acGQe+kLPliSKrmQ+ig8p/ZJIgFM6FJmS/Q=; b=AVxSNNPqyKoI6KJaK2X+eMOhAKA7neFa0kggzhWzQZSbnklnOv9J33po6x3xDlL2+1JQQ0EeSfxq9PRpdpiMek0C2rgU4Tx3GFEZaqgsK00HFZ2P7mvYscycbyeP5JR+zLRR/6jya4Pgrs+6R3PRE7+EbuMkZVPeOAReAUfU9wHQKnh1i32GYY9MEJn84+3qdJOmA6DCCYbQukFcuJbXz7byomVH6Zd88L8dZahLP+BXfgKoWbwIiOc67Hg0F+M4VGF1mIJf763aoEmOqVxCt2vldS5+nhYBTj8KWCAXHOElRblwtjO6cibYG2VkZRH71NSDDqpTV0rjyVEAF1Fp4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EX2QXIj8acGQe+kLPliSKrmQ+ig8p/ZJIgFM6FJmS/Q=; b=xU9Vhn7HObjwEGJQRHICsQcVruwKabxZs2yR8F8WbulBuW5RoZGSs4R7/GyruuHvwUYgPYQhWYGuUhpQZoPu2uo7vuCX5o1MPpusGt6BrO99mDEcyVpIGpnmW0kRay032rJGAw6wKZmgianaBQ3nEgOuxpHHelUq/qPaJzSdIo0= Received: from BN9PR03CA0361.namprd03.prod.outlook.com (2603:10b6:408:f7::6) by BY5PR12MB4292.namprd12.prod.outlook.com (2603:10b6:a03:212::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Thu, 19 May 2022 13:48:01 +0000 Received: from BN8NAM11FT053.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::e8) by BN9PR03CA0361.outlook.office365.com (2603:10b6:408:f7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 13:48:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT053.mail.protection.outlook.com (10.13.177.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 13:48:00 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 19 May 2022 08:47:56 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V6 1/4] cpufreq: amd-pstate: Expose struct amd_cpudata Date: Thu, 19 May 2022 21:47:34 +0800 Message-ID: <20220519134737.359290-2-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519134737.359290-1-li.meng@amd.com> References: <20220519134737.359290-1-li.meng@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c227daf-6f24-41b4-37f9-08da399e3077 X-MS-TrafficTypeDiagnostic: BY5PR12MB4292:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q1X3sSfmCwFDT9yKo3c0rDwNpsFcqv9kyXBeU+U9vRukHka4UXxcYNtQfGd1GyYsZiYS65Pw1puDupCqoSsdGzelTzJYB0j+0U758AQ4zoNt0Ruzo+wy8E6TlJ89DzVv7px5JSh91rIa1XK5+jyBv42TsFDjqf7nJA8Em+8C16xi6l7n8rflu0d55gOQt3nh+vUY98O0ZHF4oAptgBV7e7uaItPxbiKnDwqWaZwR1DpRm3ODIWEydnTzl+0VCYLpJ7LN69rsObb3g038cVwKmsp7pMvUzqF8ZqBKcQW2wgwZ/MEYkVpjquQ6H/h7+uOOZT9DmgWtSoR3xChLIC65PPQx3ytUFxsBYA9S7K0Kd9GfLbV01qlIlyhHMrer1ajaeKyEMHJjX2fwJNIyWbEIMzDB0pk0akvANDbrnqBVvAZwIMCPo0NobWwzmS2sHhpenyq/xfUoQpVV2V9kl01fz3d88WesKnvztYEPV9H3IeXnmWhxOfYETHWVcdSBl0myBHFnelU5GseXse5L7ZEc8XmRAhfuzPLW9PROBWeABk83gSo+/T7C5lJacMyqMq3CC9LG63r9o+WVQ51qaGWledV62SIIvsb7fHI6+E58DfjyzX/mIfrpJKIjuO7v+vqWLz5uIxi6iYCt32P0x4+G8lVogAL3bXZon8FqIj6BPRBCPuHipv7QTAAKQSP6I5k5HF9ZpehSwbMXNUBFFkTtUw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(2616005)(86362001)(6666004)(36860700001)(40460700003)(7696005)(110136005)(8936002)(426003)(508600001)(336012)(81166007)(316002)(54906003)(8676002)(70206006)(70586007)(4326008)(1076003)(83380400001)(16526019)(356005)(186003)(47076005)(82310400005)(36756003)(2906002)(26005)(5660300002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 13:48:00.6457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c227daf-6f24-41b4-37f9-08da399e3077 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT053.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4292 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Expose struct amd_cpudata to AMD P-State unit test module. This data struct will be used on the following AMD P-State unit test (amd-pstate-ut) module. The amd-pstate-ut module can get some AMD infomations by this data struct. For example: highest perf, nominal perf, boost supported etc. Signed-off-by: Meng Li Acked-by: Huang Rui --- MAINTAINERS | 1 + drivers/cpufreq/amd-pstate.c | 60 +--------------------------- include/linux/amd-pstate.h | 77 ++++++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+), 59 deletions(-) create mode 100644 include/linux/amd-pstate.h diff --git a/MAINTAINERS b/MAINTAINERS index edc96cdb85e8..c2e5299b0051 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1021,6 +1021,7 @@ L: linux-pm@vger.kernel.org S: Supported F: Documentation/admin-guide/pm/amd-pstate.rst F: drivers/cpufreq/amd-pstate* +F: include/linux/amd-pstate.h F: tools/power/x86/amd_pstate_tracer/amd_pstate_trace.py AMD PTDMA DRIVER diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 7be38bc6a673..5f7a00a64f76 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -36,6 +36,7 @@ #include #include #include +#include #include #include @@ -65,65 +66,6 @@ MODULE_PARM_DESC(shared_mem, static struct cpufreq_driver amd_pstate_driver; -/** - * struct amd_aperf_mperf - * @aperf: actual performance frequency clock count - * @mperf: maximum performance frequency clock count - * @tsc: time stamp counter - */ -struct amd_aperf_mperf { - u64 aperf; - u64 mperf; - u64 tsc; -}; - -/** - * struct amd_cpudata - private CPU data for AMD P-State - * @cpu: CPU number - * @req: constraint request to apply - * @cppc_req_cached: cached performance request hints - * @highest_perf: the maximum performance an individual processor may reach, - * assuming ideal conditions - * @nominal_perf: the maximum sustained performance level of the processor, - * assuming ideal operating conditions - * @lowest_nonlinear_perf: the lowest performance level at which nonlinear power - * savings are achieved - * @lowest_perf: the absolute lowest performance level of the processor - * @max_freq: the frequency that mapped to highest_perf - * @min_freq: the frequency that mapped to lowest_perf - * @nominal_freq: the frequency that mapped to nominal_perf - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf - * @cur: Difference of Aperf/Mperf/tsc count between last and current sample - * @prev: Last Aperf/Mperf/tsc count value read from register - * @freq: current cpu frequency value - * @boost_supported: check whether the Processor or SBIOS supports boost mode - * - * The amd_cpudata is key private data for each CPU thread in AMD P-State, and - * represents all the attributes and goals that AMD P-State requests at runtime. - */ -struct amd_cpudata { - int cpu; - - struct freq_qos_request req[2]; - u64 cppc_req_cached; - - u32 highest_perf; - u32 nominal_perf; - u32 lowest_nonlinear_perf; - u32 lowest_perf; - - u32 max_freq; - u32 min_freq; - u32 nominal_freq; - u32 lowest_nonlinear_freq; - - struct amd_aperf_mperf cur; - struct amd_aperf_mperf prev; - - u64 freq; - bool boost_supported; -}; - static inline int pstate_enable(bool enable) { return wrmsrl_safe(MSR_AMD_CPPC_ENABLE, enable); diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h new file mode 100644 index 000000000000..1c4b8659f171 --- /dev/null +++ b/include/linux/amd-pstate.h @@ -0,0 +1,77 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * linux/include/linux/amd-pstate.h + * + * Copyright (C) 2022 Advanced Micro Devices, Inc. + * + * Author: Meng Li + */ + +#ifndef _LINUX_AMD_PSTATE_H +#define _LINUX_AMD_PSTATE_H + +#include + +/********************************************************************* + * AMD P-state INTERFACE * + *********************************************************************/ +/** + * struct amd_aperf_mperf + * @aperf: actual performance frequency clock count + * @mperf: maximum performance frequency clock count + * @tsc: time stamp counter + */ +struct amd_aperf_mperf { + u64 aperf; + u64 mperf; + u64 tsc; +}; + +/** + * struct amd_cpudata - private CPU data for AMD P-State + * @cpu: CPU number + * @req: constraint request to apply + * @cppc_req_cached: cached performance request hints + * @highest_perf: the maximum performance an individual processor may reach, + * assuming ideal conditions + * @nominal_perf: the maximum sustained performance level of the processor, + * assuming ideal operating conditions + * @lowest_nonlinear_perf: the lowest performance level at which nonlinear power + * savings are achieved + * @lowest_perf: the absolute lowest performance level of the processor + * @max_freq: the frequency that mapped to highest_perf + * @min_freq: the frequency that mapped to lowest_perf + * @nominal_freq: the frequency that mapped to nominal_perf + * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf + * @cur: Difference of Aperf/Mperf/tsc count between last and current sample + * @prev: Last Aperf/Mperf/tsc count value read from register + * @freq: current cpu frequency value + * @boost_supported: check whether the Processor or SBIOS supports boost mode + * + * The amd_cpudata is key private data for each CPU thread in AMD P-State, and + * represents all the attributes and goals that AMD P-State requests at runtime. + */ +struct amd_cpudata { + int cpu; + + struct freq_qos_request req[2]; + u64 cppc_req_cached; + + u32 highest_perf; + u32 nominal_perf; + u32 lowest_nonlinear_perf; + u32 lowest_perf; + + u32 max_freq; + u32 min_freq; + u32 nominal_freq; + u32 lowest_nonlinear_freq; + + struct amd_aperf_mperf cur; + struct amd_aperf_mperf prev; + + u64 freq; + bool boost_supported; +}; + +#endif /* _LINUX_AMD_PSTATE_H */ From patchwork Thu May 19 13:47:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Meng, Li \(Jassmine\)" X-Patchwork-Id: 574828 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD40C433F5 for ; Thu, 19 May 2022 13:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236749AbiESNtH (ORCPT ); Thu, 19 May 2022 09:49:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239286AbiESNtE (ORCPT ); Thu, 19 May 2022 09:49:04 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on20609.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eab::609]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA0B463AF; Thu, 19 May 2022 06:48:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YW1WKv8gn45p94Zw5lxqlBrhfb6KctqCh/R7ZyVwAu7+wdH/fpNl/RYZlQj2InCXQpSk0yLmoKjhxWfflutb2sAvWh0g51Eo0bj1J/BR49QZNX2Z8MaJw6+Zh26+9Pqo0jMktjhgTexa/YuY8N2z08or/jEFzRnGHGL505NdR0Tq5t7+a0W+xIkqbIsGKHSTIadDAPT6+dY2qSBRV7xTJ98jd8f3n10TwCRAAYjorMHAjXILKTrNdJewrGo5TqKJJL9b8Z4vwip+iLyCXUOt0weFus6IMAWEF9ZAMSUSdYzJIeqxuz5HLBen299mbdP9og+Y/mK+nM32/jRoJzWifg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dMS0KIT5zi3HbRcPHdoPs8D4m1tTMbAyvvohsHgh9YM=; b=cY2YTm8gvh7CMdUFfPYC3lKv37jQsYdpeHsYI8P5ctjagQ4Hs5cQuuAEgOMptlZAmWQds9g1kyOhCWkNzRcgqnRgN+F6O+Xs1HHiK9ocq3wh0qF1VGr9JO9lf4beoYvxYOEViWmjgcwUiG3fnGb+JlvqHEe4Q2xoF2VfItobrmo/tiqpJLDHbOmpnKoLQakVKt0d1XIf+naCr4K4mxg8lBek5A2DEa+9KqnR516hF0AO/M/zd+K03y1sHodAky93xksxtvnVMr0KCZoNNZU7R8KWjJOHWS0hqQ7OPlQouqZeiiDT/TQDD6IwxCXEJ9u1bFd+4GPxYW+5XF92FnPosQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dMS0KIT5zi3HbRcPHdoPs8D4m1tTMbAyvvohsHgh9YM=; b=U+M4mP9a85AUjBin0NWTCUA4wTR1L37k8VYfAWlB6K86slLBQVO+AIIqqMoZLr3Xdj7O0Eg1DrIX72ZQ+u+AO2gSRDRbzXkStc+7XjkhXO5fzJsBwB+RBQB9Q2AOlXhTuOSIFxecxaNLNs9FhXfb907NLFQYdDhx0ykS0Xaq9V8= Received: from BN9PR03CA0353.namprd03.prod.outlook.com (2603:10b6:408:f6::28) by DM5PR12MB1660.namprd12.prod.outlook.com (2603:10b6:4:9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Thu, 19 May 2022 13:48:05 +0000 Received: from BN8NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f6:cafe::c9) by BN9PR03CA0353.outlook.office365.com (2603:10b6:408:f6::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 13:48:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT052.mail.protection.outlook.com (10.13.177.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 13:48:04 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 19 May 2022 08:48:00 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V6 2/4] cpufreq: amd-pstate: Add test module for amd-pstate driver Date: Thu, 19 May 2022 21:47:35 +0800 Message-ID: <20220519134737.359290-3-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519134737.359290-1-li.meng@amd.com> References: <20220519134737.359290-1-li.meng@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41a29bfc-b8f1-475f-1bf9-08da399e32fc X-MS-TrafficTypeDiagnostic: DM5PR12MB1660:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Uw5xcmQgqUJZtxrPtcuiNvOUXaJAjvhmH/Y5wg+gaH5+Mq8oB23wv8FEKyIlIhbsU8cmuMkEs1dQGUriZwGQOAysDq+CKK681AH170eDuXsVDHGiS5iuVzvFjjNwbTg/V2hWqybtuxZYKa5oOE84Sv88FWzZx+kFHU+gPIiBnkiDvNX5ZptLJZfRHAUh6Ly2yj7fuwjkVRMo42AtW3zZAyJlaBvAQZbdzMsyWQJES3RyVI4e7pirm9/Z/2o3FRCsrpUSgcy37RmCZfjr46R1yEaXUkWF8NQWQKgVn/ginGLuKWTVKyUr/+1VspMyO0/pJhbBjIoEu7NfigICQ6ObDAtydw1UiX9RJZw+28c7VWCzIvndMldsQBAOMFAlqZeqc58wyozOKBzehV/mu53rFEllQbJiyFESdGAZ1cqx6H8ggyeKojh2P22wlHl6CMjO8ueSPnREfVrQ3uSW/j1pRup+8a7L73sJrRke4nbPZuHXUD9wEzvaX2OzXU0KgDFViISk/k5zoMwjYJ/t/RcSne6R5XdqkNWgKBCBytVOlkBgIlUwXOtDOfBSuDtKl/Wc7VHd3qGQ+jZ0iRTXI0/xkijUjPeZTMMoST8phQJU3VtCSg/yI9P3ZMINYvFREg5L8mKQqSyMFjTxbtZl/fRF1AZveiACgVC9M+iZ/qlFEbHozQk+UKGoLn3GP2y4bMrTFimJAfgP5t8GoLi5T+qTA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(7696005)(70206006)(26005)(508600001)(81166007)(110136005)(54906003)(2906002)(316002)(8676002)(86362001)(356005)(4326008)(6666004)(40460700003)(83380400001)(36756003)(8936002)(5660300002)(36860700001)(47076005)(336012)(426003)(82310400005)(1076003)(16526019)(2616005)(70586007)(186003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 13:48:04.8720 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 41a29bfc-b8f1-475f-1bf9-08da399e32fc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1660 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Add amd-pstate-ut module, which is conceptually out-of-tree module and provides ways for selftests/amd-pstate driver to test various kernel module-related functionality. This module will be expected by some of selftests to be present and loaded. Signed-off-by: Meng Li Acked-by: Huang Rui --- drivers/cpufreq/Kconfig.x86 | 6 + drivers/cpufreq/Makefile | 1 + drivers/cpufreq/amd-pstate-ut.c | 278 ++++++++++++++++++++++++++++++++ 3 files changed, 285 insertions(+) create mode 100644 drivers/cpufreq/amd-pstate-ut.c diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 index 55516043b656..37ba282cd156 100644 --- a/drivers/cpufreq/Kconfig.x86 +++ b/drivers/cpufreq/Kconfig.x86 @@ -51,6 +51,12 @@ config X86_AMD_PSTATE If in doubt, say N. +config X86_AMD_PSTATE_UT + tristate "selftest for AMD Processor P-State driver" + depends on X86_AMD_PSTATE + help + This kernel module is used for testing. It's safe to say M here. + config X86_ACPI_CPUFREQ tristate "ACPI Processor P-States driver" depends on ACPI_PROCESSOR diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile index 285de70af877..49b98c62c5af 100644 --- a/drivers/cpufreq/Makefile +++ b/drivers/cpufreq/Makefile @@ -30,6 +30,7 @@ amd_pstate-y := amd-pstate.o amd-pstate-trace.o obj-$(CONFIG_X86_ACPI_CPUFREQ) += acpi-cpufreq.o obj-$(CONFIG_X86_AMD_PSTATE) += amd_pstate.o +obj-$(CONFIG_X86_AMD_PSTATE_UT) += amd-pstate-ut.o obj-$(CONFIG_X86_POWERNOW_K8) += powernow-k8.o obj-$(CONFIG_X86_PCC_CPUFREQ) += pcc-cpufreq.o obj-$(CONFIG_X86_POWERNOW_K6) += powernow-k6.o diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c new file mode 100644 index 000000000000..a510355b804e --- /dev/null +++ b/drivers/cpufreq/amd-pstate-ut.c @@ -0,0 +1,278 @@ +// SPDX-License-Identifier: GPL-1.0-or-later +/* + * AMD Processor P-state Frequency Driver Unit Test + * + * Copyright (C) 2022 Advanced Micro Devices, Inc. All Rights Reserved. + * + * Author: Meng Li + * + * The AMD P-State Unit Test is a test module for testing the amd-pstate + * driver. 1) It can help all users to verify their processor support + * (SBIOS/Firmware or Hardware). 2) Kernel can have a basic function + * test to avoid the kernel regression during the update. 3) We can + * introduce more functional or performance tests to align the result + * together, it will benefit power and performance scale optimization. + * + * At present, it only implements the basic framework and some simple + * test cases. Next, 1) we will add a rst document. 2) we will add more + * test cases to improve the depth and coverage of the test. + */ + +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + +#include "../tools/testing/selftests/kselftest_module.h" + +#include +#include +#include +#include +#include + +#include + +/* + * Abbreviations: + * aput: used as a shortform for AMD P-State unit test. + * It helps to keep variable names smaller, simpler + */ + +KSTM_MODULE_GLOBALS(); + +/* + * Kernel module for testing the AMD P-State unit test + */ +enum aput_result { + APUT_RESULT_PASS, + APUT_RESULT_FAIL, + MAX_APUT_RESULT, +}; + +struct aput_struct { + const char *name; + void (*func)(u32 index); + enum aput_result result; +}; + +static void aput_acpi_cpc(u32 index); +static void aput_check_enabled(u32 index); +static void aput_check_perf(u32 index); +static void aput_check_freq(u32 index); + +static struct aput_struct aput_cases[] = { + {"acpi_cpc_valid", aput_acpi_cpc }, + {"check_enabled", aput_check_enabled }, + {"check_perf", aput_check_perf }, + {"check_freq", aput_check_freq } +}; + +static bool get_shared_mem(void) +{ + bool result = false; + char buf[5] = {0}; + struct file *filp = NULL; + loff_t pos = 0; + ssize_t ret; + + if (!boot_cpu_has(X86_FEATURE_CPPC)) { + filp = filp_open("/sys/module/amd_pstate/parameters/shared_mem", FMODE_PREAD, 0); + if (IS_ERR(filp)) + pr_err("%s Open param file fail!\n", __func__); + else { + ret = kernel_read(filp, &buf, sizeof(buf), &pos); + if (ret < 0) + pr_err("%s ret=%ld unable to read from param file!\n", + __func__, ret); + filp_close(filp, NULL); + } + + if ('Y' == *buf) + result = true; + } + + return result; +} + +static void aput_acpi_cpc(u32 index) +{ + if (acpi_cpc_valid()) + aput_cases[index].result = APUT_RESULT_PASS; + else + aput_cases[index].result = APUT_RESULT_FAIL; +} + +static void aput_pstate_enable(u32 index) +{ + int ret = 0; + u64 cppc_enable = 0; + + ret = rdmsrl_safe(MSR_AMD_CPPC_ENABLE, &cppc_enable); + if (ret) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s rdmsrl_safe MSR_AMD_CPPC_ENABLE ret=%d is error!\n", __func__, ret); + return; + } + if (cppc_enable) + aput_cases[index].result = APUT_RESULT_PASS; + else + aput_cases[index].result = APUT_RESULT_FAIL; +} + +/* + *Check if enabled amd pstate + */ +static void aput_check_enabled(u32 index) +{ + if (get_shared_mem()) + aput_cases[index].result = APUT_RESULT_PASS; + else + aput_pstate_enable(index); +} + +/* + * Check if the each performance values are reasonable. + * highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0 + */ +static void aput_check_perf(u32 index) +{ + int cpu = 0, ret = 0; + u32 highest_perf = 0, nominal_perf = 0, lowest_nonlinear_perf = 0, lowest_perf = 0; + u64 cap1 = 0; + struct cppc_perf_caps cppc_perf; + struct cpufreq_policy *policy = NULL; + struct amd_cpudata *cpudata = NULL; + + highest_perf = amd_get_highest_perf(); + + for_each_possible_cpu(cpu) { + policy = cpufreq_cpu_get(cpu); + if (!policy) + break; + cpudata = policy->driver_data; + + if (get_shared_mem()) { + ret = cppc_get_perf_caps(cpu, &cppc_perf); + if (ret) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cppc_get_perf_caps ret=%d is error!\n", __func__, ret); + return; + } + + nominal_perf = cppc_perf.nominal_perf; + lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf; + lowest_perf = cppc_perf.lowest_perf; + } else { + ret = rdmsrl_safe_on_cpu(cpu, MSR_AMD_CPPC_CAP1, &cap1); + if (ret) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s read CPPC_CAP1 ret=%d is error!\n", __func__, ret); + return; + } + + nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1); + lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1); + lowest_perf = AMD_CPPC_LOWEST_PERF(cap1); + } + + if ((highest_perf != READ_ONCE(cpudata->highest_perf)) || + (nominal_perf != READ_ONCE(cpudata->nominal_perf)) || + (lowest_nonlinear_perf != READ_ONCE(cpudata->lowest_nonlinear_perf)) || + (lowest_perf != READ_ONCE(cpudata->lowest_perf))) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d highest=%d %d nominal=%d %d lowest_nonlinear=%d %d lowest=%d %d are not equal!\n", + __func__, cpu, highest_perf, cpudata->highest_perf, + nominal_perf, cpudata->nominal_perf, + lowest_nonlinear_perf, cpudata->lowest_nonlinear_perf, + lowest_perf, cpudata->lowest_perf); + return; + } + + if (!((highest_perf >= nominal_perf) && + (nominal_perf > lowest_nonlinear_perf) && + (lowest_nonlinear_perf > lowest_perf) && + (lowest_perf > 0))) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d highest=%d nominal=%d lowest_nonlinear=%d lowest=%d have error!\n", + __func__, cpu, highest_perf, nominal_perf, + lowest_nonlinear_perf, lowest_perf); + return; + } + } + + aput_cases[index].result = APUT_RESULT_PASS; +} + +/* + * Check if the each frequency values are reasonable. + * max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0 + * check max freq when set support boost mode. + */ +static void aput_check_freq(u32 index) +{ + int cpu = 0; + struct cpufreq_policy *policy = NULL; + struct amd_cpudata *cpudata = NULL; + + for_each_possible_cpu(cpu) { + policy = cpufreq_cpu_get(cpu); + if (!policy) + break; + cpudata = policy->driver_data; + + if (!((cpudata->max_freq >= cpudata->nominal_freq) && + (cpudata->nominal_freq > cpudata->lowest_nonlinear_freq) && + (cpudata->lowest_nonlinear_freq > cpudata->min_freq) && + (cpudata->min_freq > 0))) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d max=%d nominal=%d lowest_nonlinear=%d min=%d have error!\n", + __func__, cpu, cpudata->max_freq, cpudata->nominal_freq, + cpudata->lowest_nonlinear_freq, cpudata->min_freq); + return; + } + + if (cpudata->min_freq != policy->min) { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d cpudata_min_freq=%d policy_min=%d have error!\n", + __func__, cpu, cpudata->min_freq, policy->min); + return; + } + + if (cpudata->boost_supported) { + if ((policy->max == cpudata->max_freq) || + (policy->max == cpudata->nominal_freq)) + aput_cases[index].result = APUT_RESULT_PASS; + else { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d policy_max=%d cpu_max=%d cpu_nominal=%d have error!\n", + __func__, cpu, policy->max, cpudata->max_freq, + cpudata->nominal_freq); + return; + } + } else { + aput_cases[index].result = APUT_RESULT_FAIL; + pr_err("%s cpu%d not support boost!\n", __func__, cpu); + return; + } + } +} + +static void aput_do_test_case(void) +{ + u32 i = 0, arr_size = ARRAY_SIZE(aput_cases); + + for (i = 0; i < arr_size; i++) { + pr_info("****** Begin %-5d\t %-20s\t ******\n", i+1, aput_cases[i].name); + aput_cases[i].func(i); + KSTM_CHECK_ZERO(aput_cases[i].result); + pr_info("****** End %-5d\t %-20s\t ******\n", i+1, aput_cases[i].name); + } +} + +static void __init selftest(void) +{ + aput_do_test_case(); +} + +KSTM_MODULE_LOADERS(amd_pstate_ut); +MODULE_AUTHOR("Meng Li "); +MODULE_DESCRIPTION("Unit test for AMD P-state driver"); +MODULE_LICENSE("GPL"); From patchwork Thu May 19 13:47:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Meng, Li \(Jassmine\)" X-Patchwork-Id: 574441 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62161C4332F for ; Thu, 19 May 2022 13:52:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234953AbiESNwq (ORCPT ); Thu, 19 May 2022 09:52:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239411AbiESNvG (ORCPT ); Thu, 19 May 2022 09:51:06 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2077.outbound.protection.outlook.com [40.107.220.77]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78BA6E64DD; Thu, 19 May 2022 06:50:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V/hDW6nlfzwVIxvRKbfMF956pn0C/AGO9ZojX8bW1YgRoPO5jcMWwWK9lriEDfYDal4Y1/+XLMAsN7gEuWQynXR97zxeNFxkEKoO5LXKK78v8xCsL2i+56+SaqUJEMAlcZBbExvKChTMTeR9PGpCpEAN5EE8XTEuWOpYt0szGblYJgkmRnRRTgGICbH7LT/+KqRPBnys4Q9rOjdDYsWoLcX7BgY1QsWdPbxa15OWlZQXTVGopxrJX4Xc8dkzrz5Q09vXMbt3CHfFQyEJsj7U26Ty6nMmgPMJzSxaTbajnRg3AI6PRrAKGbBM9awE9+ia705JNsEybuBjG3istLXkcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kx/7h0LqjSd+GsV2tfSqOvfm43DcSuET83U+A1CnloA=; b=GHJ4hLhDZhDxhcjxN5bUiTvrihdygaYMgdAREIHQ/a6rrWw6PLWA3GSc0i1L4xL8ciUYOyV9vYD7/2fw4DtjvYBjKF9uDRByOz5AH33tJxM+xKqKEEHrycGZQbrWz+Hc5CbhwZc1GaFcuDdjaRPHkUoLH+/TX8o3tA2KfIxuPPb1Sa1QYiytmPa/py6wq5nvy5kLH8J0IKo70Ri9C237vu+aS54vna033k0OuLneezKWYYdyYrvzmToecMLyJQNx+DczMKC3Co1V9kvEV6Cxr8ZPD/tmv+rASiFXMIxwUHlWVF8rA8NoRUfp09FAM8I3eR6pfifhnRHfcTNDSHD0lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kx/7h0LqjSd+GsV2tfSqOvfm43DcSuET83U+A1CnloA=; b=xNu0pWBJFM3JQHInlTK3CcuNtwopHr+xJOaojPx7ICPrPtNjTCcOmKIIsOsukZ4j+jT627AF0lfgWJWj04HylUh4q7+SrbFfcZdiZAkAA/cl/Vf3RifkIAz23kDrHKfDlecVpfRZI7K+LotvvWMxFmSxMmjdIPCkDVwGHbV0kt4= Received: from BN1PR13CA0028.namprd13.prod.outlook.com (2603:10b6:408:e2::33) by DM5PR12MB2470.namprd12.prod.outlook.com (2603:10b6:4:b4::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Thu, 19 May 2022 13:48:08 +0000 Received: from BN8NAM11FT035.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e2:cafe::45) by BN1PR13CA0028.outlook.office365.com (2603:10b6:408:e2::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.7 via Frontend Transport; Thu, 19 May 2022 13:48:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT035.mail.protection.outlook.com (10.13.177.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 13:48:08 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 19 May 2022 08:48:04 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V6 3/4] selftests: amd-pstate: Add test trigger for amd-pstate driver Date: Thu, 19 May 2022 21:47:36 +0800 Message-ID: <20220519134737.359290-4-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519134737.359290-1-li.meng@amd.com> References: <20220519134737.359290-1-li.meng@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59180a30-b65a-498c-6617-08da399e353c X-MS-TrafficTypeDiagnostic: DM5PR12MB2470:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bkmAVhG3K80g0vy5aVm3tLPCLUHMOpnoWxQEm6vJgNMmCU2EpMFNwSI6WDGm88ZM4a4SfphQIzJOKx56DuQMWeQ5o4o0gLWWuxM0yLz8e40BQquR7fAuVhBxwnd2f+fMpDRa3+1LYxQokB1SwSQdzJq63mYiXo+pu7Z0Q8k5YgnpD+4PTZE8q7yS94h/r2Z3Bf9AQfDt6fs7AwHb+ATIleZUlpkunmBemriMQw3+ue4tdU3YQmbQx438W9yhbhxma1aDM3hZVC1GkltqkwTynub8mpuDRIIpkBrBkCsK+78T6DcZWZj78nyul7SdR7cGoQvyXeKRhg+lUh+bLqT4oGYiRSht6iCqE7gdtLy50mJXd0DZK+rVNDH7xqCTAQlJfU4SjjZ0YPEjQ5olYMSLCJO/ijUFrHTWoipK8Tf0Niyex3mOxdLD1QZUi2NEGWLsWrUNttrA/O1hMBQp2SaDb20R4luLpJ+K3S568glFkHloaPeo0CweU6nZGf6QeYWOfed4P1z11Qyo2eCUWWsLDilIFICUUxe/Cv8bC7gByN0qbfmZnD0ick6HpdDcJDQbr77QvXUzcJXR6h5hH1l+cXfo/mR6giQkZIbBaXyTz/z7j7x77KPfHN6cX0R+oTzIIwwDQc9f7Tv42xMj2w0XO284/wTjGeBhfMjV1y0ip4WD0OgRUkzIbcgaLY2p4RUdPxLh0muM+eioy4Di4vAKYA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(16526019)(8676002)(508600001)(186003)(2616005)(2906002)(83380400001)(5660300002)(7696005)(36756003)(8936002)(70206006)(81166007)(336012)(316002)(40460700003)(426003)(6666004)(36860700001)(4326008)(110136005)(26005)(54906003)(47076005)(70586007)(1076003)(356005)(86362001)(82310400005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 13:48:08.6488 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59180a30-b65a-498c-6617-08da399e353c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT035.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2470 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Add amd-pstate test trigger in kselftest, it will load/unload amd-pstate-ut module to test some cases etc. Signed-off-by: Meng Li Acked-by: Huang Rui --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/amd-pstate/Makefile | 8 +++++ .../selftests/amd-pstate/amd-pstate-ut.sh | 34 +++++++++++++++++++ tools/testing/selftests/amd-pstate/config | 1 + 4 files changed, 44 insertions(+) create mode 100644 tools/testing/selftests/amd-pstate/Makefile create mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh create mode 100644 tools/testing/selftests/amd-pstate/config diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 2319ec87f53d..975c13368286 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 TARGETS += alsa +TARGETS += amd-pstate TARGETS += arm64 TARGETS += bpf TARGETS += breakpoints diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile new file mode 100644 index 000000000000..e1432112fb70 --- /dev/null +++ b/tools/testing/selftests/amd-pstate/Makefile @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-only +# Makefile for amd-pstate/ function selftests + +TEST_PROGS := amd-pstate-ut.sh + +include ../lib.mk + +$(TEST_GEN_FILES): $(HEADERS) diff --git a/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh new file mode 100755 index 000000000000..970f7a76c7d5 --- /dev/null +++ b/tools/testing/selftests/amd-pstate/amd-pstate-ut.sh @@ -0,0 +1,34 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 + +# amd-pstate-ut is a test module for testing the amd-pstate driver. +# (1) It can help all users to verify their processor support +# (SBIOS/Firmware or Hardware). +# (2) Kernel can have a basic function test to avoid the kernel +# regression during the update. +# (3) We can introduce more functional or performance tests to align +# the result together, it will benefit power and performance scale optimization. + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then + echo "$0 # Skipped: Test can only run on x86 architectures." + exit $ksft_skip +fi + +msg="Skip all tests:" +if [ ! -w /dev ]; then + echo $msg please run this as root >&2 + exit $ksft_skip +fi + +scaling_driver=$(cat /sys/devices/system/cpu/cpufreq/policy0/scaling_driver) + +if [ "$scaling_driver" != "amd-pstate" ]; then + echo "$0 # Skipped: Test can only run on amd-pstate driver." + echo "$0 # Current cpufreq scaling drvier is $scaling_driver." + exit $ksft_skip +fi + +$(dirname $0)/../kselftest/module.sh "amd-pstate-ut" amd-pstate-ut diff --git a/tools/testing/selftests/amd-pstate/config b/tools/testing/selftests/amd-pstate/config new file mode 100644 index 000000000000..f43103c9adc4 --- /dev/null +++ b/tools/testing/selftests/amd-pstate/config @@ -0,0 +1 @@ +CONFIG_X86_AMD_PSTATE_UT=m From patchwork Thu May 19 13:47:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Meng, Li \(Jassmine\)" X-Patchwork-Id: 574442 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2913CC4332F for ; Thu, 19 May 2022 13:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239215AbiESNt7 (ORCPT ); Thu, 19 May 2022 09:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239211AbiESNtn (ORCPT ); Thu, 19 May 2022 09:49:43 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2074.outbound.protection.outlook.com [40.107.223.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34D4922BDB; Thu, 19 May 2022 06:49:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hDjoGXBfdv4YWc24z4ktAknHCKJWGxVkLz402zfspu564JEPClv6fwNefAYNoSTdmqOtpWUdAbR3lV2UzcvBzIBH1UZGJo0wuB8QwK/xLTxVUVcxdY7pTcQnwUngv15/q4NKAlssc2Hv9RsVJC0arFN4Ji6eEbs1gZfQwuvrSZLcqo6UngG/d+YaB0ss3OYesmSQbMQwwLLkhk3GJG9rs9iJLtV+sIW4mdGYLOO4Q2zAYi5A1X9+ADrrWiYUff1x8xsjx6PHYs4zxFujYSPno0Nxpbo1in0bgw8AqODpWiz9Qtg4AzZO3YigW8C5riaRzTiUIwLks0rFxbaEpFPFBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vLmwWQZUqP97jUg1+MjO3pUICs4LXiAjz+nWYZn0J1E=; b=Xave0ILWUhD5U+bDJaQ3ARGiDzqi6n55o8Ezis3RseIv/vNdGPzXCC8XD/INpede6D8LI1z+bOuuA0ULEQeCbB5lgLpYytm7KYFXi933+aRr99Y8eztQPiNJ2h77Ub9Vi4icb31vHNPigpxgZQs32+r0Zp4ycyW6SNRfL2mp+wQD2RVd16cqmCG52GweNm0R81ayykzWOITJMxYdlBiHR1ZlPg2A582ObVqvPZ1F7OSW7VK9IZQkY3Usvq6ss/4EmV1YA2zmTLNg8zLSaC9D7tKqgHvm/fuOVKz6Y9YbOwm9KSdiV8lae61qPfdbvvBYBBWubQ1MX7w1CEJuPdAADQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linuxfoundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vLmwWQZUqP97jUg1+MjO3pUICs4LXiAjz+nWYZn0J1E=; b=h3RmVh2a63psniaD2hBK+MmYQBH97YZYtbls44sHw9dlOcA6w9nEpPtDrepnx+8WQN4UngHm98GLsJfG06Mrh8UslRA8tREooL6yS+ADfIoJjhosJ/MANPjU4LwTScqG/LuQ9uFsSrp+y/rmkTCfhy5Hw36H6ZSHCTHoW10DR3E= Received: from BN0PR07CA0009.namprd07.prod.outlook.com (2603:10b6:408:141::8) by BYAPR12MB3191.namprd12.prod.outlook.com (2603:10b6:a03:133::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 19 May 2022 13:48:13 +0000 Received: from BN8NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:408:141:cafe::10) by BN0PR07CA0009.outlook.office365.com (2603:10b6:408:141::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Thu, 19 May 2022 13:48:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT008.mail.protection.outlook.com (10.13.177.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Thu, 19 May 2022 13:48:12 +0000 Received: from jasmine-meng.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 19 May 2022 08:48:08 -0500 From: Meng Li To: Shuah Khan , Huang Rui , CC: "Rafael J . Wysocki" , Nathan Fontenot , Deepak Sharma , "Alex Deucher" , Mario Limonciello , Jinzhou Su , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov , , Meng Li Subject: [PATCH V6 4/4] Documentation: amd-pstate: Add unit test introduction Date: Thu, 19 May 2022 21:47:37 +0800 Message-ID: <20220519134737.359290-5-li.meng@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519134737.359290-1-li.meng@amd.com> References: <20220519134737.359290-1-li.meng@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6dd3333-74ac-4100-bd0e-08da399e37b9 X-MS-TrafficTypeDiagnostic: BYAPR12MB3191:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /6hJA53/y9aZEk3LqNDenD/L+K1JioOevr3XCZ9+d/SNN/Cq1OSrTLx5VWGiAsYZdlTu10EtV0YHi8mT9s+QiYZo6OiaIHYu8nAeVeWzArRmDxhhOUVUc/hb2QtUbOiFyflylp78EQkcHgO0rMxOugAYM/wXKs+UXCIVN19z+No2daqLdhDtpJ5FbHVOWxdqW+H+CazWWuIwWrGGx6mwZ2umanVh1jew231/GJdYzJX33SwFpJ6HkFn0VVS9FBn2oK2Y3ZwS4tXzm5W4UPqvR1pssr8gGA48F7T1u8o8P0oOU8nVnhdUFzhB5DKMWWFHiyKaiAmAnC9yLR59lRpuOPHnrv63s0n1mAZy60a36OpmrIW5G2SuyIDfIzH3kml6m1UCO+dPlonaIPcqwEOMItXRXjOv9YTX4F5v/6tRhrgN0vbzaWWx+MbEQgXhvBGUIHfAjknB6K55ZCMfKxrQF3x+Sz5sCXLexu2Uqtb8H/CfxoMD3R9Y+GJr6zCcO7RdGzmgFEa5PmZXy8uvIyPpD/lzci/QkupYs9tQkNdO29Q9A00QZ3vFl7hDehN5IUvVTHCVDtLzhNd+ijjXnwP0+J1EhOVthJQM0bPso4o4PuZ8AqaTAfR5CLW5Kc/olnYvOGuYJHrfQlDvkHweDQGe/SA8xY3BLhniik90qNhQMxKY1OXcGnTGPergqhFjQerCaW4O3ljEJLM5IM/9EinA6gPoohEW8gVY/y+wOMdd1m9nUdAnQeunYSMgdsB6L0lY3j5ENpbcefoAamvX4WYLpWzlSYWb2d8c4/0o1QoedXy6EgKD+Rree3RUlvu5T6iHPeyt12Mg7xhIF377UkSC4Q== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(16526019)(966005)(2616005)(26005)(2906002)(186003)(36756003)(1076003)(8936002)(5660300002)(8676002)(81166007)(70586007)(4326008)(336012)(82310400005)(426003)(508600001)(70206006)(47076005)(7696005)(83380400001)(86362001)(356005)(110136005)(40460700003)(316002)(54906003)(36860700001)(6666004)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 13:48:12.8256 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6dd3333-74ac-4100-bd0e-08da399e37b9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3191 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Introduce the AMD P-State unit test module design and implementation. Signed-off-by: Meng Li Acked-by: Huang Rui --- Documentation/admin-guide/pm/amd-pstate.rst | 84 +++++++++++++++++++++ 1 file changed, 84 insertions(+) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst index 83b58eb4ab4d..222e4f5fd817 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -182,6 +182,7 @@ to the ``struct sugov_cpu`` that the utilization update belongs to. Then, ``amd-pstate`` updates the desired performance according to the CPU scheduler assigned. +.. _processor_support: Processor Support ======================= @@ -282,6 +283,8 @@ efficiency frequency management method on AMD processors. Kernel Module Options for ``amd-pstate`` ========================================= +.. _shared_mem: + ``shared_mem`` Use a module param (shared_mem) to enable related processors manually with **amd_pstate.shared_mem=1**. @@ -393,6 +396,84 @@ about part of the output. :: CPU_005 712 116384 39 49 166 0.7565 9645075 2214891 38431470 25.1 11.646 469 2.496 kworker/5:0-40 CPU_006 712 116408 39 49 166 0.6769 8950227 1839034 37192089 24.06 11.272 470 2.496 kworker/6:0-1264 +Unit Tests for amd-pstate +------------------------- + +``amd-pstate-ut`` is a test module for testing the ``amd-pstate`` driver. + + * It can help all users to verify their processor support (SBIOS/Firmware or Hardware). + + * Kernel can have a basic function test to avoid the kernel regression during the update. + + * We can introduce more functional or performance tests to align the result together, it will benefit power and performance scale optimization. + +1. Test case decriptions + + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | Index | Functions | Description | + +=========+================================+====================================================================================+ + | 0 | aput_acpi_cpc || Check whether the _CPC object is present in SBIOS. | + | | || | + | | || The detail refer to `Processor Support `_. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 1 | aput_check_enabled || Check whether AMD P-State is enabled. | + | | || | + | | || AMD P-States and ACPI hardware P-States always can be supported in one processor. | + | | | But AMD P-States has the higher priority and if it is enabled with | + | | | :c:macro:`MSR_AMD_CPPC_ENABLE` or ``cppc_set_enable``, it will respond to the | + | | | request from AMD P-States. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 2 | aput_check_perf || Check if the each performance values are reasonable. | + | | || highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + | 3 | aput_check_freq || Check if the each frequency values and max freq when set support boost mode | + | | | are reasonable. | + | | || max_freq >= nominal_freq > lowest_nonlinear_freq > min_freq > 0 | + | | || If boost is not active but supported, this maximum frequency will be larger than | + | | | the one in ``cpuinfo``. | + +---------+--------------------------------+------------------------------------------------------------------------------------+ + +#. How to execute the tests + + We use test module in the kselftest frameworks to implement it. + We create amd-pstate-ut module and tie it into kselftest.(for + details refer to Linux Kernel Selftests [4]_). + + 1. Build + + + open the :c:macro:`CONFIG_X86_AMD_PSTATE` configuration option. + + set the :c:macro:`CONFIG_X86_AMD_PSTATE_UT` configuration option to M. + + make project + + make selftest :: + + jasminemeng@jasmine-meng:~/amd-brahma$ cd linux + jasminemeng@jasmine-meng:~/amd-brahma/linux$ make -C tools/testing/selftests + + #. Installation & Steps :: + + jasmine@jasmine-meng:~/amd-brahma/linux$ make -C tools/testing/selftests install INSTALL_PATH=~/kselftest + jasmine@jasmine-meng:~$ sudo ./kselftest/run_kselftest.sh -c amd-pstate + TAP version 13 + 1..1 + # selftests: amd-pstate: amd-pstate-ut.sh + # amd-pstate-ut: ok + ok 1 selftests: amd-pstate: amd-pstate-ut.sh + + #. Results :: + + jasmine@jasmine-meng:~$ dmesg | grep "amd-pstate-ut" | tee log.txt + [76697.480217] amd-pstate-ut: loaded. + [76697.480222] amd-pstate-ut: ****** Begin 1 acpi_cpc_valid ****** + [76697.480227] amd-pstate-ut: ****** End 1 acpi_cpc_valid ****** + [76697.480228] amd-pstate-ut: ****** Begin 2 check_enabled ****** + [76697.480253] amd-pstate-ut: ****** End 2 check_enabled ****** + [76697.480255] amd-pstate-ut: ****** Begin 3 check_perf ****** + [76697.480554] amd-pstate-ut: ****** End 3 check_perf ****** + [76697.480556] amd-pstate-ut: ****** Begin 4 check_freq ****** + [76697.480558] amd-pstate-ut: ****** End 4 check_freq ****** + [76697.480559] amd-pstate-ut: all 4 tests passed + [76697.482507] amd-pstate-ut: unloaded. + Reference =========== @@ -405,3 +486,6 @@ Reference .. [3] Processor Programming Reference (PPR) for AMD Family 19h Model 51h, Revision A1 Processors https://www.amd.com/system/files/TechDocs/56569-A1-PUB.zip + +.. [4] Linux Kernel Selftests, + https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html