From patchwork Tue Jan 8 16:21:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 154984 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5065141jaa; Tue, 8 Jan 2019 08:25:02 -0800 (PST) X-Google-Smtp-Source: ALg8bN4+dY9lFFgzuVTGnguIKC2mOnJf74n/XdJlB57TCIqvCqbf+gHh/glRPYO0LeSw37DTdxok X-Received: by 2002:a05:6000:120a:: with SMTP id e10mr1968539wrx.85.1546964702068; Tue, 08 Jan 2019 08:25:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546964702; cv=none; d=google.com; s=arc-20160816; b=FZrUtQ8o05sN1cDiNeiToAIWXPiAjAdDSGuiMHzfaKE5NOO9svpGBn2+6Q017Xn5aL zvQPr2sxNnFLVywar45G9Z4svPvGd3B1lQkK9PCkVUCS2jWg6jqpD9Q35aAfJUGxgIJN DY2Vm4fJS995tiSXlxx+wH6xYg43pHj+MysN4y7w0us9SGTKCbHoCiOupLm55tPaHFD0 jNSEifx9mG9YIWybi9wM2ZMPjhFwTOzEhfiaIm2MxYvol1GVnuiPjSx8ay4UQy9UYxjv zPlynUxf3xdS08OYqEXkZkzkR6/+o8CVg9pneXE8xuFSAnuCeSDDUIdm7OOZhiHzgTOa QFOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=zxMd6GPDwM6BPndhdG+Twn4eiN8aaFHmKKsZ7ct7NIQ=; b=XX3xt7m4couA9/Xa3GOuZs2R4wqxfCFkxhf8FNZpr4ukNOzSOWBRoaCblvvPRufq9w 5Q9g6HIO1x32ktuhau4LGwPC6xuvU9kTCGW62KDRZuk9fnN2AQe1aJoU2Z2dnlSTipN1 +ZyRlWIGueSwe6yfNJ3nxHJPsPrUcFo9RbFrT7Ucp0MObMjJoFlQ/Ts/OVV/HbWpN4Y2 IwoyWMnmzbG5mc+BQF7QRGcZ8PhTJzAD0LXvKeM88yDXlgD81LovVeXLmaoVetzZMgot S44iJ0BsyyITGOoMhNZWFKt643xC79Xd3Y19WdRQnnXyPJKrgSBBfC/OoPW+0DQIvQJG YIyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gZNK2V+c; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i8si37960173wrm.449.2019.01.08.08.25.01 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 08 Jan 2019 08:25:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=gZNK2V+c; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:53976 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gguBW-0006IV-1w for patch@linaro.org; Tue, 08 Jan 2019 11:24:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu8g-0004EL-Sv for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggu8f-0000fC-Ni for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:02 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:50895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggu8f-0000LY-ET for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:01 -0500 Received: by mail-wm1-x343.google.com with SMTP id n190so4729054wmd.0 for ; Tue, 08 Jan 2019 08:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zxMd6GPDwM6BPndhdG+Twn4eiN8aaFHmKKsZ7ct7NIQ=; b=gZNK2V+ciswNZDvZCL6Jrt76KxiJpSVGTJckc/LLHzvS8csUr5UKh/MqZ9jM0UqFZA oG+WnTLX+4VBT7U0qLr4YJ24B4OEWH0HSxypi8egL9gxDidKdo1lkJMqO+r+bgeLybpr UYljv5m3CN+Hqvk8yjLiyUKlfD1bfKYRAwuzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zxMd6GPDwM6BPndhdG+Twn4eiN8aaFHmKKsZ7ct7NIQ=; b=Xf+T5wBDUlnXJEFZcGGieWAZm5hDam14iMKKy19biu4/yXRvnv/HU7apelpq8S5lKT RCNSErRv0jcfyzzLVEov67Rux7SiBxKjWqNUQSGpcZD9oiWxA0XPZjHbJKm+FcbDef/H eNTqcr3TZDzk2BqLjMdZPAIKxVK7oitvZUG5Si9TNlGUPzHdtRFY8A4L9EzXja3/oYnG /SYg+7JM+J4C7jWav1YJmnt/m5qsHoKLKHI1aqypMm3JDpPMJtnzSQjYJ90M53jmx9Xc MBgp6Y278Z4l+SoMO+TEA1Ioj8dDEj7HREOb5H/hKMMiqLLblt8o2Me1BzCTXWv4JnBe 12XA== X-Gm-Message-State: AJcUukdi8VQ9YwDpZhy2gcibRjqSAZVS7t43UYnWVkeAmjw5Nki3KJ7s JlWW7FLOItkeNpE00y1HBPCPDw== X-Received: by 2002:a7b:c315:: with SMTP id k21mr2182318wmj.145.1546964515698; Tue, 08 Jan 2019 08:21:55 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id c10sm50030616wrw.49.2019.01.08.08.21.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jan 2019 08:21:54 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 7B5ED3E0D4E; Tue, 8 Jan 2019 16:21:54 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2019 16:21:49 +0000 Message-Id: <20190108162154.22259-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190108162154.22259-1-alex.bennee@linaro.org> References: <20190108162154.22259-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v1 1/6] fp-bench: fix update_random_ops X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , cota@braap.org, =?utf-8?q?Al?= =?utf-8?q?ex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" The second test in the branches is wrong; fix while converting to a switch statement, which is easier to get right. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index f5bc5edebf..546bac9c9c 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -143,15 +143,20 @@ static void update_random_ops(int n_ops, enum precision prec) for (i = 0; i < n_ops; i++) { uint64_t r = random_ops[i]; - if (prec == PREC_SINGLE || PREC_FLOAT32) { + switch (prec) { + case PREC_SINGLE: + case PREC_FLOAT32: do { r = xorshift64star(r); } while (!float32_is_normal(r)); - } else if (prec == PREC_DOUBLE || PREC_FLOAT64) { + break; + case PREC_DOUBLE: + case PREC_FLOAT64: do { r = xorshift64star(r); } while (!float64_is_normal(r)); - } else { + break; + default: g_assert_not_reached(); } random_ops[i] = r; From patchwork Tue Jan 8 16:21:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 154982 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5062705jaa; Tue, 8 Jan 2019 08:22:26 -0800 (PST) X-Google-Smtp-Source: ALg8bN7zNep8JGyzylUIcE0mO+8BT3sVeaZo5GoTKn9oai1kwOsuZs2XhXm16VkcjR/wpfJo+qkE X-Received: by 2002:adf:efd1:: with SMTP id i17mr1919598wrp.200.1546964546270; Tue, 08 Jan 2019 08:22:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546964546; cv=none; d=google.com; s=arc-20160816; b=wk18zoFVhUu82+dnsmlWuOYodfHGQ7WyDwSs5JQOEsCUJKtEpfpmgeo9jM7ge9TliG J2WtYTPzfFKp1D77iMu01vFxvOl73AbtRxrHeTAZ6c+XNvvYx6XWrlVm+iApcJ9CJIa4 IHjOfMILseTI8rpljKbT1OPYrlxiz6Q41Fdk1cFOhfpW3o3rOpn3HsIdWL68OMxYZOcs brXDCOtqJhGpBkqFNUoCna6vom2WfZcHnwsTV5mmGvG5qEKUPHvXmFQ15LsQdcUqH54d R7lvMP2pHjXeGrXyOxOcgP/hXJfSBVu1FrzXSB9sMs5ppcZ4Fb6IjupVLbY8XB54Rk2L OoGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=ETldxgIHGVeH/a1n8S6Mva5jjGnnGUzADuQ4s825HYgxgriy4fGEpF7etnfUrwE7Gm hvFaJYkvArNB034IHZWkytQRRDDVO9NYsWXDS5CZAcaH/kcMA9Id/bL7upMP4ITgaeOd 79Z7gmZ65kFCibqVu48eUIfux9XcjQbmIpzdw3yp7Cg0MOg16MxuOAgGGsmaL1iJ6vvA 3tf2QHzoq3N+oTEWKyJCia2oPDe0oeIQZ1IxDB/qwtMVsFJmpfyx4Cgw9/1oaxfVVBQY 0nGYuxlCFjogLbdwaypaVMQxPt9x+R8xbiNz/tCw4v7ifcVwOVs+/6bAsgO0wcZayyYj GuYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=HCRm+rbF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id a130si7166759wma.94.2019.01.08.08.22.26 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 08 Jan 2019 08:22:26 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=HCRm+rbF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:53783 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu93-0004G7-80 for patch@linaro.org; Tue, 08 Jan 2019 11:22:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu8h-0004Er-SU for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggu8e-0000a3-7n for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:02 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:38049) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggu8d-0000Rc-Uh for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:00 -0500 Received: by mail-wr1-x442.google.com with SMTP id v13so4663626wrw.5 for ; Tue, 08 Jan 2019 08:21:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=HCRm+rbFBQGNLLSMSNjNgL4vP+lJGx8Bfu88+dckemNj+DAVJRur00v6sCx7YxvI26 pgGk5TM5gK0wf2VwK0oK2QhrjOuHcT8GYOjDq2055uvypFJpuUmoRp+PTllu/PkMo27o 9XzHLMnFgnu1VwLhBNbWAkxxxk/PwFkKdMX6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BKiceF0eCEcLLYJ2HmNMq8GOYGcVmd+bgBmQXvFufFI=; b=i2JSwxH70aE8vp1sVyvZNcN9yAdwSh/WiNfkDhtS10Qc6XJF1SDTBsgZ990l3pGyGW zX5pmRvFQWxNlUx7F+G1HJwIZYJqWbJThjx8WfVhSEm8mSa6g2C9OaV5peavf3ilOK2S xWPCCrVrqyPEoGeqoEOhzE/UcB0O8JZ9htv/eLTIJ1ZTmk4hyT9pKlWg5LmmcfCR0ZHS WXBihPw/g6Wma8hjMldna9LWIf1f/8SZlU50FdHlvnLNSnI9jFKHt+3u6GyWUthTns08 4c/YPuozi2uMJCXv1cXfTRnJWYS1oBhWYkdntRThby8gPsegbfraywtahC93pdOBEfDP 5yhA== X-Gm-Message-State: AJcUukefhnDG29QWf1jX6jX6now2db45JPfmLGHFNYJslgy6Mw7VxXma lBF4CM9srlv/QN93izGpZ/U1durxyf4= X-Received: by 2002:adf:d1d2:: with SMTP id m18mr2040455wri.138.1546964517276; Tue, 08 Jan 2019 08:21:57 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id j3sm11424373wmb.39.2019.01.08.08.21.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jan 2019 08:21:55 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 91DE83E10A4; Tue, 8 Jan 2019 16:21:54 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2019 16:21:50 +0000 Message-Id: <20190108162154.22259-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190108162154.22259-1-alex.bennee@linaro.org> References: <20190108162154.22259-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v1 2/6] fp-bench: remove wrong exponent raise in fill_random X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , cota@braap.org, =?utf-8?q?Al?= =?utf-8?q?ex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" At this point random_ops[] only contains normals, so there's no need to do anything to them. In fact, raising the exponent here can make the output !normal, which is precisely what the comment says we want to avoid. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --- tests/fp/fp-bench.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.17.1 diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c index 546bac9c9c..4ba5e1d2d4 100644 --- a/tests/fp/fp-bench.c +++ b/tests/fp/fp-bench.c @@ -176,8 +176,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float32_is_neg(ops[i].f32)) { ops[i].f32 = float32_chs(ops[i].f32); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f32 |= 0x40000000; break; case PREC_DOUBLE: case PREC_FLOAT64: @@ -185,8 +183,6 @@ static void fill_random(union fp *ops, int n_ops, enum precision prec, if (no_neg && float64_is_neg(ops[i].f64)) { ops[i].f64 = float64_chs(ops[i].f64); } - /* raise the exponent to limit the frequency of denormal results */ - ops[i].f64 |= LIT64(0x4000000000000000); break; default: g_assert_not_reached(); From patchwork Tue Jan 8 16:21:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 154986 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5065317jaa; Tue, 8 Jan 2019 08:25:10 -0800 (PST) X-Google-Smtp-Source: ALg8bN4EMs2sGlPn1Pw8mZ6RFQMqMCdRFB6J4cPY0LgjjD48PE6Yi+N+XgE17YF9tW6FACXQQAZu X-Received: by 2002:a1c:8f95:: with SMTP id r143mr2174290wmd.65.1546964710311; Tue, 08 Jan 2019 08:25:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546964710; cv=none; d=google.com; s=arc-20160816; b=YRQoCT571R8wP56mBxODnDdLUCWQK0tOmWKpMglWmzWJ+BYk7bHn/GUmEo7Ymrlu4V G/PmUpp6EkRcur3FO/Y9qKANmRsHh5MDmPXXJW0pckfq07RDWTPXw+sVUF2AuZOhyhtW UtNzdYOFx5HuEEJE8vA0IO30EA/I2wtXm9WI2X7CrLdd85syz1G1DOlP3HscHSx7oOhA 0l0zuzXhEYQv9bvE62Fu8gnYIenusPh4p4SM6dWlHixpSiPAIwPVU8N4KrWHHs4Tx77Q THFHzxRTORGBxF9aQEJo46SuBwfHZm4+zGGv0ne74425IAwPaxvTcjUe2rya8ImPytFd IzdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=Cu0zWCd/QWoV++VI/VVTfNtwQXOM6UIZaGTYIh0OvRk=; b=Kw9ddC7QZQkvlblhngiq5gJulz5L8d3Za3BaVsSNGwc7i91s5aubuHji8eo9Pa4rQI cFC9Z0rTpdfevEeGisbNPhOuz2d42nviS3s0M/ulebQlqv/cwIkoS38Z+PlwaqR6RsDG 5TWsoU5imreVrPnqGBf8ajinjRSpdJyp7o6R2KcwVaFndrvcI9I8sFHdUABdKTTwgVTt 12O9jUehUXRQweu5WHNjKtyUko/ix7UMy6TrqYJFgBzEjVk+8zp3aB/bqavf8Wzh5mBF SZmTnaFSuMWqZvpCf+6RQzC359lmDluT9QfusGx4jen6KUJlVn5zVFIkRWL3e753snNC eVdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=RU7NZAsV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g7si39076550wri.268.2019.01.08.08.25.09 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 08 Jan 2019 08:25:10 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=RU7NZAsV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:54000 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gguBe-0006Oy-7l for patch@linaro.org; Tue, 08 Jan 2019 11:25:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48000) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu8m-0004HR-6W for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggu8g-0000jY-Sm for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:05 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:35990) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggu8f-0000Uz-Dt for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:02 -0500 Received: by mail-wr1-x442.google.com with SMTP id u4so4673521wrp.3 for ; Tue, 08 Jan 2019 08:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Cu0zWCd/QWoV++VI/VVTfNtwQXOM6UIZaGTYIh0OvRk=; b=RU7NZAsVWKRCWRoOFovvTpFekdnjE94bjqnfMRak74doeNqaakbCecBvEVF7E/kzrN pN/n3pGCdviZJor25a4rVWjsvffzLYin2GjnFQEsZLa/imu0VsqXxLsEebz9NxlkCqc8 jYj/hwUJQJFoTGaeBzn8cJhDtho02oUNuiZnA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Cu0zWCd/QWoV++VI/VVTfNtwQXOM6UIZaGTYIh0OvRk=; b=o6ryX5krW08x4cDbl5koL99xZhDI84smCW/AFhsMYNLvnLjXToD63VqOtwpR90iiWL Qf3npjHf3ky89B1z+hDeMi9WX9w/1RdKgkQ0sn865gVvR2Wv/1K/Kd74jf+ZH856FscX ctXh9pNqU5PQvJqSYQSUEToGkv/wW/bt2OMZFyIAyBhLF6LcSRAT3+N8AXfExBLufGHg fs+G4exWk3DghtqOsAwU99tpY9qcylxVv3G9jnYceRYTzAmCk8Sq/mh6y6581egIK1SV HzGcnCUNWtqvEktVqSS5MtX5UNeX1PnruyyJTLh6yPIxharx6vZRg1wMuPW6AdNb85s8 oRxw== X-Gm-Message-State: AJcUukfl1FaNyrmnffB0tMHCHtohGhpie5kAm3EreerboIydmp9i2aKB jUV/sS7Y1w6KUI+1iCVv8vkjvw== X-Received: by 2002:adf:d089:: with SMTP id y9mr1989239wrh.22.1546964518269; Tue, 08 Jan 2019 08:21:58 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id w125sm10303466wmb.45.2019.01.08.08.21.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jan 2019 08:21:56 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id ADB363E113B; Tue, 8 Jan 2019 16:21:54 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2019 16:21:51 +0000 Message-Id: <20190108162154.22259-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190108162154.22259-1-alex.bennee@linaro.org> References: <20190108162154.22259-1-alex.bennee@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v1 3/6] softfloat: enforce softfloat if the host's FMA is broken X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , cota@braap.org, =?utf-8?q?Al?= =?utf-8?q?ex_Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: "Emilio G. Cota" The added branch to the FMA ops is marked as unlikely and therefore its impact on performance (measured with fp-bench) is within noise range when measured on an Intel(R) Xeon(R) Gold 6142 CPU @ 2.60GHz. In addition, when the host doesn't have a hardware FMA instruction we force the use of softfloat, since whatever the libc does (e.g. checking the host's FP flags) is unlikely to be faster than our softfloat implementation. For instance, on an i386 machine with no hardware support for FMA, we get: $ for precision in single double; do ./fp-bench -o mulAdd -p $precision done - before: 5.07 MFlops 1.85 MFlops - after: 12.65 MFlops 10.05 MFlops Reported-by: Laurent Desnogues Suggested-by: Richard Henderson Signed-off-by: Emilio G. Cota --- fpu/softfloat.c | 85 ++++++++++++++++++++++++++++++++++++++++++++ include/qemu/cpuid.h | 6 ++++ 2 files changed, 91 insertions(+) -- 2.17.1 diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 59eac97d10..ccaed85b0f 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -1542,6 +1542,8 @@ soft_f64_muladd(float64 a, float64 b, float64 c, int flags, return float64_round_pack_canonical(pr, status); } +static bool force_soft_fma; + float32 QEMU_FLATTEN float32_muladd(float32 xa, float32 xb, float32 xc, int flags, float_status *s) { @@ -1562,6 +1564,11 @@ float32_muladd(float32 xa, float32 xb, float32 xc, int flags, float_status *s) if (unlikely(!f32_is_zon3(ua, ub, uc))) { goto soft; } + + if (unlikely(force_soft_fma)) { + goto soft; + } + /* * When (a || b) == 0, there's no need to check for under/over flow, * since we know the addend is (normal || 0) and the product is 0. @@ -1623,6 +1630,11 @@ float64_muladd(float64 xa, float64 xb, float64 xc, int flags, float_status *s) if (unlikely(!f64_is_zon3(ua, ub, uc))) { goto soft; } + + if (unlikely(force_soft_fma)) { + goto soft; + } + /* * When (a || b) == 0, there's no need to check for under/over flow, * since we know the addend is (normal || 0) and the product is 0. @@ -7974,3 +7986,76 @@ float128 float128_scalbn(float128 a, int n, float_status *status) , status); } + +#ifdef CONFIG_CPUID_H +#include "qemu/cpuid.h" +#endif + +static void check_host_hw_fma(void) +{ +#ifdef CONFIG_CPUID_H + int max = __get_cpuid_max(0, NULL); + int a, b, c, d; + bool has_fma3 = false; + bool has_fma4 = false; + bool has_avx = false; + + if (max >= 1) { + __cpuid(1, a, b, c, d); + + /* check whether avx is usable */ + if (c & bit_OSXSAVE) { + int bv; + + __asm("xgetbv" : "=a"(bv), "=d"(d) : "c"(0)); + if ((bv & 6) == 6) { + has_avx = c & bit_AVX; + } + } + + if (has_avx) { + /* fma3 */ + has_fma3 = c & bit_FMA3; + + /* fma4 */ + __cpuid(0x80000000, a, b, c, d); + if (a >= 0x80000001) { + __cpuid(0x80000001, a, b, c, d); + + has_fma4 = c & bit_FMA4; + } + } + } + /* + * Without HW FMA, whatever the libc does is probably slower than our + * softfloat implementation. + */ + if (!has_fma3 && !has_fma4) { + force_soft_fma = true; + } +#endif +} + +static void __attribute__((constructor)) softfloat_init(void) +{ + union_float64 ua, ub, uc, ur; + + if (QEMU_NO_HARDFLOAT) { + return; + } + + /* + * Test that the host's FMA is not obviously broken. For example, + * glibc < 2.23 can perform an incorrect FMA on certain hosts; see + * https://sourceware.org/bugzilla/show_bug.cgi?id=13304 + */ + ua.s = 0x0020000000000001ULL; + ub.s = 0x3ca0000000000000ULL; + uc.s = 0x0020000000000000ULL; + ur.h = fma(ua.h, ub.h, uc.h); + if (ur.s != 0x0020000000000001ULL) { + force_soft_fma = true; + } + + check_host_hw_fma(); +} diff --git a/include/qemu/cpuid.h b/include/qemu/cpuid.h index 69301700bd..320926ffe0 100644 --- a/include/qemu/cpuid.h +++ b/include/qemu/cpuid.h @@ -25,6 +25,9 @@ #endif /* Leaf 1, %ecx */ +#ifndef bit_FMA3 +#define bit_FMA3 (1 << 12) +#endif #ifndef bit_SSE4_1 #define bit_SSE4_1 (1 << 19) #endif @@ -53,5 +56,8 @@ #ifndef bit_LZCNT #define bit_LZCNT (1 << 5) #endif +#ifndef bit_FMA4 +#define bit_FMA4 (1 << 16) +#endif #endif /* QEMU_CPUID_H */ From patchwork Tue Jan 8 16:21:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 154983 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5062845jaa; Tue, 8 Jan 2019 08:22:35 -0800 (PST) X-Google-Smtp-Source: ALg8bN6W+tGa8KbfMl5A/m3y2pkJq91WJkIi/GPZfPmPhOyaa+/p8TgBYMq+uV3uZg6lGkv0C5zk X-Received: by 2002:a1c:6e06:: with SMTP id j6mr2346864wmc.3.1546964555744; Tue, 08 Jan 2019 08:22:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546964555; cv=none; d=google.com; s=arc-20160816; b=C74acaUggjF61ynT3VnfOpAulJZMtVu0C3grG20UOe38g0L6qi+cnkGKsF4smEmPti MwMWOzcntwrU60v0DBFIkSs7hR/wW3NxdSatUk57qOFa1iu8mQYzjtJk3KOmS9C2v2/l 5P+XQTidAMh4MNcN7DAKPJRdT4zhq9aOYyPnGi3p62CZNlErhQwlWvXn2vvyM5BRJvaI nPOobIMoiUKNdFDtITISxddHhVZHlkSYLKEA6icTBIab/PEWgVk/eqDKWKtHD/AKgSTe I7DGwPyPzSyfAkOws8tB1q9psAsCSqFccY1/z9gxzVJ2t/SdbbSXedRDQaIpR0miTBw5 8VZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=Pte7Wj4rgezoXgNvGxvsFaiSdpnOauW2cBpolG/kvlw=; b=iAkz80nyWkTQGL01ojoTw7CLaQmOeLwGPL16A3MClf4fDGJNS+Hs7K230no3qpnvqi GdvdONO4MSchbrV/IfPEp5R8xtQ6YyVqqkzq4e/aWDOBaS6lsjb+r/CmHLFOYNumw8f6 DCqmYVG2mOqr8L3JklMw0mziOh8nBHIyfNaMTn+eQZq4NejMfGhMtIr83/M+7zZIUHSi XcUgJcM42ZZU1qekzSQHinONwE69X07uvvPG2Elfx09iwcmQT5553j/BkedgZxVDn9nN 1+HH0j8atKPdtd2LbWabFtQQOIzapB5zHyvpoeuFKso8foz9r7QkWBoCWq5hystVQptP PbQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="dxp3bp6/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m12si37672518wrn.358.2019.01.08.08.22.35 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 08 Jan 2019 08:22:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="dxp3bp6/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:53788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu9A-0004He-KV for patch@linaro.org; Tue, 08 Jan 2019 11:22:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu8h-0004EK-RI for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggu8e-0000bg-Lq for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:01 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:35400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggu8e-0000YH-DG for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:00 -0500 Received: by mail-wm1-x341.google.com with SMTP id t200so5062444wmt.0 for ; Tue, 08 Jan 2019 08:22:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pte7Wj4rgezoXgNvGxvsFaiSdpnOauW2cBpolG/kvlw=; b=dxp3bp6/vl0AnZznNW6Rwh0G/S8QHmXWtG3SumESv2ti2ZlHfPJL2URa0eh6DoedoQ J76f6bvJbpSEDe8/jXM8cVaerwRpu82YKJ74NjDTNz3eVCUTRxsuNEZ0GCyBWCRWygdz 0SlG1/msr6wSx3JWgJI7IXeJV2ZtuuNJbvJRo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pte7Wj4rgezoXgNvGxvsFaiSdpnOauW2cBpolG/kvlw=; b=kRNva/TehEMDqvEOm7vNc/FNFqHXjaItPX0Hm1Qmyf3wlXthOjEJAiCA5bO59JgfBs 1xHCmxsKYyGN0j7zBJ8EsDvOJC2pgTvWaY0gaDZEAz2zcyeDvxI62kq5ipky64L3hwjA FHQAz2noPeDgav1SIOa5LMajV3HIkcE33uL204VVImX99dpcZVbkZd7sKKOFjbVTbqpY MFIWSKSpfe8XUVF4MzS1r73TSPymChikzau0j5uhetKZE6fKg30Y8MwXVlB9qMJU8IAs Ol+EMGJ/Bs5/zTR7fjcupWVv2WO4xgQtlE6XwlY8Zgmip7eUk4d/mJeEptZvO2ENFlpx bs0w== X-Gm-Message-State: AJcUuke/SuN/wHgs67/qx+UD5gvHBMQW8HSbRp6B7mWR2Sm6dZKRX4qg dOVGmSlHHDrRu+Y4frq6r2kZSQJMaz8= X-Received: by 2002:a1c:a548:: with SMTP id o69mr2348287wme.118.1546964519266; Tue, 08 Jan 2019 08:21:59 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id z206sm10345054wmc.18.2019.01.08.08.21.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jan 2019 08:21:56 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id C471D3E117B; Tue, 8 Jan 2019 16:21:54 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2019 16:21:52 +0000 Message-Id: <20190108162154.22259-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190108162154.22259-1-alex.bennee@linaro.org> References: <20190108162154.22259-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH v1 4/6] tests/Makefile: add floating point tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org, =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Wire up test/fp-test into the main testing Makefile. Currently we skip some of the extF80 and f128 related tests. Once we re-factor and fix these tests the plumbing should get simpler. Signed-off-by: Alex Bennée --- tests/Makefile.include | 115 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 115 insertions(+) -- 2.17.1 diff --git a/tests/Makefile.include b/tests/Makefile.include index 3f5a1d0c30..69610c0ed1 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -844,6 +844,121 @@ check-report.xml: $(patsubst %,check-report-qtest-%.xml, $(QTEST_TARGETS)) check check-report.html: check-report.xml $(call quiet-command,gtester-report $< > $@,"GEN","$@") +# FPU Emulation tests (aka softfloat) +# +# As we still have some places that need fixing the rules are a little +# more complex than they need to be and have to override some of the +# generic Makefile expansions. Once we are cleanly passing all +# the tests we can simplify the make syntax. + +# the build dir is created by configure +$(BUILD_DIR)/tests/fp/fp-test: $(BUILD_DIR)/tests/fp + $(call quiet-command, \ + cd $(BUILD_DIR)/tests/fp && make, \ + "BUILD", $<) + +# The full test suite can take a bit of time, default to a quick run +ifeq ($(SPEED), quick) +FP_TL=-l 1 +else +FP_TL=-l 2 -r all +endif + +# $1 = tests, $2 = description +test-softfloat = $(call quiet-command, \ + cd $(BUILD_DIR)/tests/fp && ./fp-test -s $(FP_TL) $1 > $2.out 2> $2.err, \ + "FLOAT TEST", $2) + +# Conversion Routines: +# FIXME: i32_to_extF80 (broken), i64_to_extF80 (broken) +# ui32_to_f128 (not implemented), f128_to_ui32 (not implemented) +# extF80_roundToInt (broken) +# +check-softfloat-conv: tests/fp/fp-test + $(call test-softfloat, \ + i32_to_f16 i64_to_f16 \ + i32_to_f32 i64_to_f32 \ + i32_to_f64 i64_to_f64 \ + i32_to_f128 i64_to_f128, int-to-float) + $(call test-softfloat, \ + ui32_to_f16 ui64_to_f16 \ + ui32_to_f32 ui64_to_f32 \ + ui32_to_f64 ui64_to_f64 \ + ui64_to_f128, uint-to-float) + $(call test-softfloat, \ + f16_to_i32 f16_to_i32_r_minMag \ + f32_to_i32 f32_to_i32_r_minMag \ + f64_to_i32 f64_to_i32_r_minMag \ + extF80_to_i32 extF80_to_i32_r_minMag \ + f128_to_i32 f128_to_i32_r_minMag \ + f16_to_i64 f16_to_i64_r_minMag \ + f32_to_i64 f32_to_i64_r_minMag \ + f64_to_i64 f64_to_i64_r_minMag \ + extF80_to_i64 extF80_to_i64_r_minMag \ + f128_to_i64 f128_to_i64_r_minMag, \ + float-to-int) + $(call test-softfloat, \ + f16_to_ui32 f16_to_ui32_r_minMag \ + f32_to_ui32 f32_to_ui32_r_minMag \ + f64_to_ui32 f64_to_ui32_r_minMag \ + f16_to_ui64 f16_to_ui64_r_minMag \ + f32_to_ui64 f32_to_ui64_r_minMag \ + f64_to_ui64 f64_to_ui64_r_minMag, \ + float-to-uint) + $(call test-softfloat, \ + f16_roundToInt f32_roundToInt \ + f64_roundToInt f128_roundToInt, \ + round-to-integer) + +# Generic rule for all float operations +# +# Some patterns are overidden due to broken or missing tests. +# Hopefully these can be removed over time. + +check-softfloat-%: tests/fp/fp-test + $(call test-softfloat, f16_$* f32_$* f64_$* extF80_$* f128_$*, $*) + +# Float Compare routines +SF_COMPARE_OPS=eq eq_signaling le le_quiet lt_quiet +SF_COMPARE_RULES=$(patsubst %,check-softfloat-%, $(SF_COMPARE_OPS)) + +# FIXME: extF80_le_quiet (broken) +check-softfloat-le_quiet: tests/fp/fp-test + $(call test-softfloat, \ + f16_le_quiet f32_le_quiet f64_le_quiet \ + f128_le_quiet, \ + le_quite) + +# FIXME: extF80_lt_quiet (broken) +check-softfloat-lt_quiet: tests/fp/fp-test + $(call test-softfloat, \ + f16_lt_quiet f32_lt_quiet f64_lt_quiet \ + f128_lt_quiet, \ + lt_quite) + +.PHONY: check-softfloat-compare +check-softfloat-compare: $(SF_COMPARE_RULES) + +# Math Operations + +# FIXME: extF80_mulAdd (missing) +check-softfloat-mulAdd: tests/fp/fp-test + $(call test-softfloat, \ + f16_mulAdd f32_mulAdd f64_mulAdd f128_mulAdd, \ + mulAdd) + +# FIXME: extF80_rem (broken) +check-softfloat-rem: tests/fp/fp-test + $(call test-softfloat, \ + f16_rem f32_rem f64_rem f128_rem, \ + rem) + +SF_MATH_OPS=add sub mul mulAdd div rem sqrt +SF_MATH_RULES=$(patsubst %,check-softfloat-%, $(SF_MATH_OPS)) + +.PHONY: check-softfloat-ops +check-softfloat-ops: $(SF_MATH_RULES) + # Per guest TCG tests LINUX_USER_TARGETS=$(filter %-linux-user,$(TARGET_DIRS)) From patchwork Tue Jan 8 16:21:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 154987 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5070054jaa; Tue, 8 Jan 2019 08:30:09 -0800 (PST) X-Google-Smtp-Source: ALg8bN6Y6ihrnKrblc4WwB70C1annDJMQUq4ebinAXQiCg8qiWrlLVJyqrvtD1TnwqDdrcFmg72k X-Received: by 2002:adf:f984:: with SMTP id f4mr2008353wrr.234.1546965009802; Tue, 08 Jan 2019 08:30:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546965009; cv=none; d=google.com; s=arc-20160816; b=ZFxnJ6OccNvO8mmOIFWCHeib0Y4b1k5k5zTF5LpiV++blye0Yb1VCpJpUu4RO7+u+v Wg+WIg6i0SG0FF1E7NU+/sRpMfstpY2cAGGsC02pfOO9pYQgubEdtK07MQZJKTlTeJSE 20+aqs77nnOpyB/U9N2g+Av+9PETecGO2YH39NYAUTen6iYK5zx0opuTcy0ETU5zsHm4 /9NROBHIVd2EoJakxKYF485P2VA94jNnzHkrl1co6U/6DShei2yuFOxQjrEhqL6d9cbt wTYzHpiLcNb8wERfIorJe7sWG5v3hw6hLv0OUdH9Hn107BTlrVmmorqzu+Jp57Rlct6P Z9hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=sncl268j326mbrHK+6GzulZI9Mox7RKtqTWf6ITvKco=; b=y+APPW6sWD0SJYRcfZRP3QWK/RGObUQATpFZXFPB0u/pdf+HvBmkRZ1F3GGphi5rwO FkFvysLsFhkF3EWPqr/PjvK3bV8CUCIt/NZpwGYdqbk5NkBar054XnO+t0E3vqWG7eym XyK8dIvicMza3kFJ1H1KHRsgg2zx6sEDYEv9ZgueGTXq9duDaR3atgQV4bPDQyYmHO0f Lw9yRJgLImXMmCxIN9i0D4i+9RTrW9KF45eZiTe8+0QF22jl5JmKlW4n7JfEaDus6u2z d0dbHD7hs2o43r20FX8Z3AOwsNh/O9+vY5PCusId8V6GKlyEhohivBySaKRWq9F6HPPu bCyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=P12do+pv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p3si37884788wrn.132.2019.01.08.08.30.09 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 08 Jan 2019 08:30:09 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=P12do+pv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:54431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gguGS-0001WU-B0 for patch@linaro.org; Tue, 08 Jan 2019 11:30:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu8s-0004Mi-BN for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggu8o-00017c-J3 for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:13 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:53974) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggu8j-0000dg-FF for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:09 -0500 Received: by mail-wm1-x32d.google.com with SMTP id d15so4712601wmb.3 for ; Tue, 08 Jan 2019 08:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sncl268j326mbrHK+6GzulZI9Mox7RKtqTWf6ITvKco=; b=P12do+pvLZ0mAslQRcv9ORsh3oaROOnTQh7LVGhPyWc+oSN7j8dXDR7wX7fOMangjU 3eV23935nueVd0VWlR69KioASp8gL0h+3u9SxKm9AuAicZo9obqzJPcDzLodunx/8Edi e8LwREoHzRWAX3a3IbaScKIkXGSpixIkCZJmY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sncl268j326mbrHK+6GzulZI9Mox7RKtqTWf6ITvKco=; b=YrNU4ZDaLLxhowYaToY4f6Rq+9o9IHnwHyO4xNBsC66dMFBkwF1/NjnTuz2s/PNkdI E23ArKm4acm/ehWDg6dlhzjrLn60cpr6zbYMyM6zjqYsG5mXHcGRbjmJ23NyXXhSL+Xm 7eVeHPzqc9vsoHIgxMEIg/p+YbaTEerHWJ7Nv/F73RxQG732m3vUxdQ4d7pI61BcF50S y+fYF66Xmr6dtiGoP0azoekDmJJ3avNazH3D3bxjPrsxJ9EDZ1zQwENq3VIg0jPBkki7 Czk4Yki9CZOvM9XTPSU0nULXSRSV1gTZXMnvY3trEQGYFlu4pbOasRgi4qMM13KrFVo2 Iexg== X-Gm-Message-State: AJcUuke2WX1999xNcIDU5hVCKw5XVmaqBilvnENa1OGNDKUzlAHlesd/ 05OUNvtnSxRe78P08WX+onCHvSMjfYA= X-Received: by 2002:a7b:c218:: with SMTP id x24mr2298105wmi.58.1546964520935; Tue, 08 Jan 2019 08:22:00 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id g9sm9892244wmg.44.2019.01.08.08.21.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jan 2019 08:21:57 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id D96B73E118E; Tue, 8 Jan 2019 16:21:54 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2019 16:21:53 +0000 Message-Id: <20190108162154.22259-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190108162154.22259-1-alex.bennee@linaro.org> References: <20190108162154.22259-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32d Subject: [Qemu-devel] [PATCH v1 5/6] scripts/archive-source: include softfloat tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org, =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We need these if we want to run unit/softfloat tests in our docker containers. Signed-off-by: Alex Bennée --- scripts/archive-source.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Reviewed-by: Richard Henderson diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh index 62bd22578b..6eed2a29bd 100755 --- a/scripts/archive-source.sh +++ b/scripts/archive-source.sh @@ -26,7 +26,7 @@ vroot_dir="${tar_file}.vroot" # independent of what the developer currently has initialized # in their checkout, because the build environment is completely # different to the host OS. -submodules="dtc ui/keycodemapdb" +submodules="dtc ui/keycodemapdb tests/fp/berkeley-softfloat-3 tests/fp/berkeley-testfloat-3" trap "status=$?; rm -rf \"$list_file\" \"$vroot_dir\"; exit \$status" 0 1 2 3 15 From patchwork Tue Jan 8 16:21:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 154985 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp5065191jaa; Tue, 8 Jan 2019 08:25:04 -0800 (PST) X-Google-Smtp-Source: ALg8bN6NJVK1UCYBxkurUisj49HfxK93aw5qVKFFQcB/6Qr9cwQFFFubzAkEX6HlOS9W2CVtzUJm X-Received: by 2002:adf:f009:: with SMTP id j9mr1907045wro.170.1546964703935; Tue, 08 Jan 2019 08:25:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546964703; cv=none; d=google.com; s=arc-20160816; b=VXynEPzd/LmgLM1Fdw0IuQCoinGgsqU55vz1Fati92TAf4JVHyvTlP5BuOJea+AgQh KmEKwHgi2S+AjshZvCpG1IUSygm3nAl1B8iwwaoyQP98cEa7H3/z/BbhP1qXdB2W1MWG zjkdQP7saXKF3+QUwt9GHNnZEQsPyoWJM7wq68WA+TjxjerKpX0ZfvukkCvB7K5U52xz RKrPXUM2DICvrsQ/xYRzQ/Wz/celL4+ZeHsdciAvthoX2i/y+FSO+t/yfY6Uc2iQujuP 0DNbudAD+TMCq1mfHfN+kpQRrXnBodyv6EPggjFtMfc+6FCN2S5eUqQXGeVk/UJ+r15e JUDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=Dl11T0QaTAXzCTmUGQS54C+SDceurmzs5fdGU6KlM+c=; b=H5uh5WeedAj1t86k1AdVasvwEUNEqcyVNWsSrXEP51JdiMaH1TNz6pza4pXiOtvHSN dlaiVUJ4wdf1ASz+PSEtgBJxWsA61exNlvCebGuolYWA5ud+rAER40dB2q99jUOGnHAd C8l8et9/xJ8lWpSIYHVk7pyY1/DNaY9O7uzGukAlYxqmFCO35XTZCyJf/AGLij4LaV5S 3tNYYJeQsBuHHDE7myYQLG2szrQ06m0KzQ7nKPDNLv+Oh6+yiSkaMSqijStn9PqVJrzG p6mnc8zwRHP+wQCxbi0Ql4GOI/2cQ0P1rPcMLgWbTKA87C2KCYLwhhozSB74eVcj4IVu zpTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jQN6v+Y5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s13si37371616wrv.406.2019.01.08.08.25.03 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 08 Jan 2019 08:25:03 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=jQN6v+Y5; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:53982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gguBY-0006Ks-Uw for patch@linaro.org; Tue, 08 Jan 2019 11:25:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggu8s-0004Mh-BF for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggu8o-00017Y-J4 for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:13 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:55813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggu8k-0000bo-GX for qemu-devel@nongnu.org; Tue, 08 Jan 2019 11:22:09 -0500 Received: by mail-wm1-x344.google.com with SMTP id y139so4666121wmc.5 for ; Tue, 08 Jan 2019 08:22:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dl11T0QaTAXzCTmUGQS54C+SDceurmzs5fdGU6KlM+c=; b=jQN6v+Y5qQ0CJqS9uvTtpWQixgVwQTs6pnz1ffnG+a4Uf+Qs1TfnvHgAWa1QunaLDj gXjtCYU3hGDFFfFgBMLcafyn7n5eBQf08HlqwqV6tPSkJGSdbVvB/Hi3J3fN/QA2iU9Y MFZ1VQ80MR1poiHvCVStq0RM6cg5oxnZC2hdM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dl11T0QaTAXzCTmUGQS54C+SDceurmzs5fdGU6KlM+c=; b=btAWpBL7YWF5H0BYAQOtBmdZEoVnbJH6gQrxwDUdAMKGUG8zhAzq7reXP/vSsOSiBf q0KmtOCZzbAKD6UQWtpFfMpx/osJYJEfipxzcHFkJwYT/bdIaI+/+hrH/e1i0dxKrNM2 3hAI/bhebvagyEvM0Tt3/+z8uTml5ulM9H0OQIm0dzpwgbOgCzsUga/PueclTnFrlf3D Gf7I7TPKJOF+cx6878zS5zUOgXhPNf4N5tB7wPUsIahMVcoSMhH6kOoVDoz+wcEbjeYL NgQ4CncpsKcCfaAqz2flPihT1ZO79xpuxJcG3AqAbY2Y5HQS0ddXpfcs8DR5pNEBRee3 JJcg== X-Gm-Message-State: AJcUukdenX8pcR1HgH7TOFB8Euklk+PTMsL2tfQv3Zl1lNbLj6pyawOC hfCPooR3x+JWq0qyWRQV141R0Q== X-Received: by 2002:a1c:2d4b:: with SMTP id t72mr2095262wmt.99.1546964520246; Tue, 08 Jan 2019 08:22:00 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id l20sm115623313wrb.93.2019.01.08.08.21.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jan 2019 08:21:57 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id EB6CB3E11E5; Tue, 8 Jan 2019 16:21:54 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 8 Jan 2019 16:21:54 +0000 Message-Id: <20190108162154.22259-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190108162154.22259-1-alex.bennee@linaro.org> References: <20190108162154.22259-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PATCH v1 6/6] tests/Makfile: add check-softfloat rule X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cota@braap.org, =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This adds a rule to run all of our softfloat tests. It is included as a pre-requisite to check-tcg and check-unit as well. Signed-off-by: Alex Bennée --- tests/Makefile.include | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- 2.17.1 diff --git a/tests/Makefile.include b/tests/Makefile.include index 69610c0ed1..efbfe7708a 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -11,6 +11,7 @@ check-help: @echo " $(MAKE) check-qapi-schema Run QAPI schema tests" @echo " $(MAKE) check-block Run block tests" @echo " $(MAKE) check-tcg Run TCG tests" + @echo " $(MAKE) check-softfloat Run FPU emulation tests" @echo " $(MAKE) check-acceptance Run all acceptance (functional) tests" @echo " $(MAKE) check-report.html Generates an HTML test report" @echo " $(MAKE) check-venv Creates a Python venv for tests" @@ -959,6 +960,18 @@ SF_MATH_RULES=$(patsubst %,check-softfloat-%, $(SF_MATH_OPS)) .PHONY: check-softfloat-ops check-softfloat-ops: $(SF_MATH_RULES) +# Finally a generic rule to test all of softfoat. If TCG isnt't +# enabled we define a null operation which skips the tests. + +.PHONY: check-softfloat +ifeq ($(CONFIG_TCG),y) +check-softfloat: check-softfloat-conv check-softfloat-compare check-softfloat-ops +else +check-softfloat: + $(call quiet-command, /bin/true, "FLOAT TEST", \ + "SKIPPED for non-TCG builds") +endif + # Per guest TCG tests LINUX_USER_TARGETS=$(filter %-linux-user,$(TARGET_DIRS)) @@ -991,7 +1004,7 @@ clean-tcg-tests-%: build-tcg: $(BUILD_TCG_TARGET_RULES) .PHONY: check-tcg -check-tcg: $(RUN_TCG_TARGET_RULES) +check-tcg: check-softfloat $(RUN_TCG_TARGET_RULES) .PHONY: clean-tcg clean-tcg: $(CLEAN_TCG_TARGET_RULES) @@ -1072,7 +1085,7 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR) .PHONY: check-qapi-schema check-qtest check-unit check check-clean check-qapi-schema: $(patsubst %,check-%, $(check-qapi-schema-y)) check-tests/qapi-schema/doc-good.texi check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS)) -check-unit: $(patsubst %,check-%, $(check-unit-y)) +check-unit: $(patsubst %,check-%, $(check-unit-y)) check-softfloat check-speed: $(patsubst %,check-%, $(check-speed-y)) check-block: $(patsubst %,check-%, $(check-block-y)) check: check-qapi-schema check-unit check-qtest check-decodetree