From patchwork Thu May 19 01:07:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chanwoo Choi X-Patchwork-Id: 574843 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DC90C433EF for ; Thu, 19 May 2022 00:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232290AbiESAmC (ORCPT ); Wed, 18 May 2022 20:42:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232183AbiESAl7 (ORCPT ); Wed, 18 May 2022 20:41:59 -0400 Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 897AD2B1A3 for ; Wed, 18 May 2022 17:41:46 -0700 (PDT) Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20220519004141epoutp0385785f7acb8a3f27e7da77f1316797a3~wWs1KKGCg2996929969epoutp03c for ; Thu, 19 May 2022 00:41:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20220519004141epoutp0385785f7acb8a3f27e7da77f1316797a3~wWs1KKGCg2996929969epoutp03c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1652920901; bh=1/6+G1PwL9P9KchBj2p5sbz8lwiQyq4Yp2+xeM30yOs=; h=From:To:Cc:Subject:Date:References:From; b=mFmEbI47tdVy/0JRSprUy0T3P9gotTXJlUcZ/5SVzsuxP7wNMO6NTwSRIhlc4dh7P 9ki8AjxNSaxX4X1vQ2XHAMhWPRQME3tMm211yeyr+DrBuI4Ww3HrzL2czrJmS/Lhie 0hqR5Po+AjqKq+syX3H3QZh+upqrydcTNcEYuQDQ= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20220519004140epcas1p2fbd9fd8953e1f1b9c204e6f2cd8df1ec~wWs0U8JdL2792127921epcas1p2O; Thu, 19 May 2022 00:41:40 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.36.133]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4L3WJM1FdJz4x9QD; Thu, 19 May 2022 00:41:39 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id 85.DB.10354.34295826; Thu, 19 May 2022 09:41:39 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20220519004138epcas1p1cb026c559dacbf3f8525910293b2de89~wWszBcPf32697226972epcas1p1t; Thu, 19 May 2022 00:41:38 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220519004138epsmtrp2b8212b74ac9262af585ebd354b2ff553~wWszAsLHN1245412454epsmtrp2D; Thu, 19 May 2022 00:41:38 +0000 (GMT) X-AuditID: b6c32a38-4b5ff70000002872-22-62859243f91c Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 81.F3.08924.24295826; Thu, 19 May 2022 09:41:38 +0900 (KST) Received: from localhost.localdomain (unknown [10.113.221.102]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220519004138epsmtip2b5f07f510de34158f06eb580f1b77c23~wWsy10rEz1367213672epsmtip2I; Thu, 19 May 2022 00:41:38 +0000 (GMT) From: Chanwoo Choi To: rjw@rjwysocki.net Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, cw00.choi@samsung.com, chanwoo@kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com Subject: [PATCH] PM / devfreq: passive: Return non-error when not-supported event is required Date: Thu, 19 May 2022 10:07:53 +0900 Message-Id: <20220519010753.32228-1-cw00.choi@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIKsWRmVeSWpSXmKPExsWy7bCmga7zpNYkg5M9bBYTb1xhsbj+5Tmr xdmmN+wWl3fNYbP43HuE0WLtkbvsFrcbV7BZnDl9idWBw2PTqk42jy1X21k8+rasYvT4vEku gCUq2yYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6Awl hbLEnFKgUEBicbGSvp1NUX5pSapCRn5xia1SakFKToFpgV5xYm5xaV66Xl5qiZWhgYGRKVBh QnbG264nbAWfuCp+bH7K1sA4l7OLkZNDQsBEov3aU5YuRi4OIYEdjBL9t2+yQTifGCW+XbgC lfnMKPF95yImmJb/G++yQiR2MUr8u7aVHcL5wihx9dUkVpAqNgEtif0vbrCB2CICohKXd09g AbGZQZZceGgDYgsLxEvMPbGdEcRmEVCVWLl0MtAgDg5eASuJy2uh7pOXWL3hADPIfAmBTewS fZunQl3hInHvyw82CFtY4tXxLewQtpTE53d72SAamhklGl7cZoRwehgljj7rY4GoMpbYv3Qy E8g2ZgFNifW79CHCihI7f89lhDiUT+Ld1x5WkBIJAV6JjjYhiBJlicsP7kLdICmxuL0T6gYP iVeHnoG1CgnESjxvfMsygVF2FsKCBYyMqxjFUguKc9NTiw0LTODRlJyfu4kRnLa0LHYwzn37 Qe8QIxMH4yFGCQ5mJRFextyWJCHelMTKqtSi/Pii0pzU4kOMpsAAm8gsJZqcD0yceSXxhiaW BiZmRsYmFoZmhkrivL1TTycKCaQnlqRmp6YWpBbB9DFxcEo1MAmf6UrVdK4Waj8TptKwU1W7 0qvHR/yazKptgd8dt4WLLgmVWs2/YX3TmUyhM5sZ0149sLtXdXkxd6Rdtp/w5o33pjBF+FWd vXWU7/zVOQurumK4qyvcy58+ynC9EOb1JcryqsjU2phPieU5fNZ7DRlWLI2RX8q84CSHw9w4 7ttSJ1YFf6n4XHDGsJ0jP+aniItn8ZnFk9LOlN6t6wj38A70tty+b6leUsYHo07FnuJLu9xD TyxwDV5itNfntNGNy/kf9Hsd81pmP+y5Oadw04/lPhWL819z/zKsXXczp2DGsbfeV87Z8x3W YVrtWJ1tp+slwfKXNTBWf0Po/gi3a796VKrqkn4+59YLXXFGiaU4I9FQi7moOBEAYDOCGOQD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHJMWRmVeSWpSXmKPExsWy7bCSvK7TpNYkg8656hYTb1xhsbj+5Tmr xdmmN+wWl3fNYbP43HuE0WLtkbvsFrcbV7BZnDl9idWBw2PTqk42jy1X21k8+rasYvT4vEku gCWKyyYlNSezLLVI3y6BK+Nt1xO2gk9cFT82P2VrYJzL2cXIySEhYCLxf+Nd1i5GLg4hgR2M Emd2HWWFSEhKTLt4lLmLkQPIFpY4fLgYouYTo8S954fBatgEtCT2v7jBBmKLCIhKXN49gQWk iFngAKPE6o+bGUESwgKxEq8mnWcCsVkEVCVWLp3MDjKUV8BK4vJaqCPkJVZvOMA8gZFnASPD KkbJ1ILi3PTcYsMCo7zUcr3ixNzi0rx0veT83E2M4CDS0trBuGfVB71DjEwcjIcYJTiYlUR4 GXNbkoR4UxIrq1KL8uOLSnNSiw8xSnOwKInzXug6GS8kkJ5YkpqdmlqQWgSTZeLglGpgqkmr 691y9mXloYJ3B2czNuh5fJ6b/Sy11i9o4nuJ97mJuv1lawTl3AI9/tVYW36epfE0xj3x6a0N OSazKv1XXd76wuVby/HC4Hrzq6aNQhqRIfwdnxcs+8yZff3iDp138XIGEaFv57Jlrruxx3jx O85360/pyxr5ckpZ/TS8p/B86fzz9+0dPu558y9u21pptkNftk/KiGg67Oz5QvSmMI+sC3t3 x22TswXum/+faq3fVVR6TnPbYUaFN+/2/2qfEsPPPdVA7d5Xs5gpcyeXZ0wvL6m/ZVf5u35C 7g6uUy/VryrOXcsiL9Z40i21rHuK7Fa/I7MqV0+3+3snw2rPNZuVanG/NpyYr7HAOVj3jRJL cUaioRZzUXEiADvNkLGRAgAA X-CMS-MailID: 20220519004138epcas1p1cb026c559dacbf3f8525910293b2de89 X-Msg-Generator: CA X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220519004138epcas1p1cb026c559dacbf3f8525910293b2de89 References: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Each devfreq governor specifies the supported governor event such as GOV_START and GOV_STOP. When not-supported event is required, just return non-error. But, commit ce9a0d88d97a ("PM / devfreq: Add cpu based scaling support to passive governor") returned the error value. So that return non-error value when not-supported event is required. Fixes: ce9a0d88d97a ("PM / devfreq: Add cpu based scaling support to passive governor") Reported-by: Marek Szyprowski Signed-off-by: Chanwoo Choi --- Dear Rafael, This patch fixes the issue of the pull request[1]. I'd like you to apply it to linux-pm.git direclty. [1] https://patchwork.kernel.org/project/linux-pm/patch/3acd6c32-6e78-dfc2-3e45-84f69a7d5f36@samsung.com/ Best Regards, Chanwoo Choi drivers/devfreq/governor_passive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c index 7306e943a234..72c67979ebe1 100644 --- a/drivers/devfreq/governor_passive.c +++ b/drivers/devfreq/governor_passive.c @@ -402,7 +402,7 @@ static int devfreq_passive_event_handler(struct devfreq *devfreq, { struct devfreq_passive_data *p_data = (struct devfreq_passive_data *)devfreq->data; - int ret = -EINVAL; + int ret = 0; if (!p_data) return -EINVAL;