From patchwork Thu May 26 03:30:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jianglei Nie X-Patchwork-Id: 576816 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB148C433F5 for ; Thu, 26 May 2022 03:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243949AbiEZDqB (ORCPT ); Wed, 25 May 2022 23:46:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231163AbiEZDqA (ORCPT ); Wed, 25 May 2022 23:46:00 -0400 X-Greylist: delayed 914 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 25 May 2022 20:45:58 PDT Received: from mail-m973.mail.163.com (mail-m973.mail.163.com [123.126.97.3]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 785C735DD7; Wed, 25 May 2022 20:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=CjTO1 zV1XxDBvRyik+WBGvUIZFFmgjo+eyQguphswZA=; b=fwlLaKzWVMM5dd12lo4e8 A/aAWpMLYTUCF86JRTQhpTcpd0yzeVoDKDXqncr1tSbACKnZ+WU0HdwscDV36A8B TXTHxCPw/Vh1ZT/RL7zhK6u0NmS544WTPCH9K67cGz44dNfcseaB6MZY+P/lr6UV 860oL8uw3R41TWTeWuwnPA= Received: from localhost.localdomain (unknown [123.112.69.106]) by smtp3 (Coremail) with SMTP id G9xpCgA3f6s89I5iG2uqEg--.14753S4; Thu, 26 May 2022 11:30:14 +0800 (CST) From: Jianglei Nie To: pizza@shaftnet.org, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jianglei Nie Subject: [PATCH] cw1200: Fix memory leak in cw1200_set_key() Date: Thu, 26 May 2022 11:30:03 +0800 Message-Id: <20220526033003.473943-1-niejianglei2021@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: G9xpCgA3f6s89I5iG2uqEg--.14753S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7Jr18Aw1rCF4DKFW7Cr4fuFg_yoW3KFX_GF 1Yqa18Grs7Jr12kryrAr4furWSv3WYgF4fuay2qayayanrurWDXr15XFWxJryUK3y8ZF4f Gw4kWa1rAw1jqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xREsjjJUUUUU== X-Originating-IP: [123.112.69.106] X-CM-SenderInfo: xqlhyxxdqjzvrlsqjii6rwjhhfrp/1tbiWwcNjGI0Up-XlwABsH Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org When wsm_key.index > WSM_KEY_MAX_INDEX, cw1200_set_key() returns without calling cw1200_free_key() like other wrong paths, which may lead to a potential memory leak. We can fix it by calling cw1200_free_key() when some error occurs. Signed-off-by: Jianglei Nie --- drivers/net/wireless/st/cw1200/sta.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/st/cw1200/sta.c b/drivers/net/wireless/st/cw1200/sta.c index 236022d4ae2a..c0097577978d 100644 --- a/drivers/net/wireless/st/cw1200/sta.c +++ b/drivers/net/wireless/st/cw1200/sta.c @@ -823,6 +823,7 @@ int cw1200_set_key(struct ieee80211_hw *dev, enum set_key_cmd cmd, }; if (wsm_key.index > WSM_KEY_MAX_INDEX) { + cw1200_free_key(priv, idx); ret = -EINVAL; goto finally; }