From patchwork Fri Jan 11 03:50:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 155295 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp119216jaa; Thu, 10 Jan 2019 19:51:37 -0800 (PST) X-Google-Smtp-Source: ALg8bN55JWGOBR9oRz5oWEzwthAoGWOi//RSMdHxRa39hWppXUiM6hOnzAxcKqAy8yovdzoxmqCp X-Received: by 2002:a62:5003:: with SMTP id e3mr13311104pfb.23.1547178697556; Thu, 10 Jan 2019 19:51:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547178697; cv=none; d=google.com; s=arc-20160816; b=TnH5NF2uAeMLMB9pOgeTkJ1S96aRzILSueSlWz9rikBG/UTD8w95o0ui+g6ZtN+TiI 6smt0BeMcZexf69CpaV7Xcs37EPeljZaGUQ1f/pM6jKx/52kkCUPYMSTrhZ9MtF0zovE 4JPS+yVW9AnhGltYK+2N+hL0MB1yJcJEXm6HuYnjPIo4uOUyk52u4gFhJiXjShBl3l8C 8aw5MLYTzWDM6q8u8qYuAKGSB7F1DRZKHa7ABoWNeIUzRiSdw4hZrUhS88PCz9kCAsy3 WvNL33GpWjVFJDpZZt9H8DB9UlL/LmFJFrmsbvuQcli/0EKE2KmEnMDtyLGnf7+HMlkA L5Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=ufrzE66vru7yDqtMOT9cFgQFnBsk166gcj53s1V7eR4=; b=xc6OV01T2WeMq9ZmfWQlUP3VnpPxmj4bp5ATsPWC+EMnAz6uxOJqIH0idrr/PFjx2w buYga8fe69hq4vzbwe7DMpBnbPuHjzIdj6DtpgclfTYbzxjaqdW5fESnb7AxqHtHKbTQ zyYkFxpMP5b66ErAa9RwWCGAS9iX5dqphSmAh3eXlAL7Db2BHFMLjRTYBU7PSw0OmR/j zbUadhtNcf79CJqNB//ey8iZQCa7bcIUx9PUs4/jqQcHqsy2prxcPVi0O1nqF/ABiHDG KAxTMUtu7ORoeTG2gkohPDcKEjT4On+dpwimGyhnpSEqXRRwqw6J5+UMUAfsA1nMSOas KwUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id s5si48424422pfi.134.2019.01.10.19.51.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 19:51:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAEA46F518; Fri, 11 Jan 2019 03:51:34 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D1926F509 for ; Fri, 11 Jan 2019 03:51:28 +0000 (UTC) Received: from pendragon.bb.dnainternet.fi (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 543F356D; Fri, 11 Jan 2019 04:51:24 +0100 (CET) From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 02/49] drm/omap: dsi: Fix crash in DSI debug dumps Date: Fri, 11 Jan 2019 05:50:33 +0200 Message-Id: <20190111035120.20668-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190111035120.20668-1-laurent.pinchart@ideasonboard.com> References: <20190111035120.20668-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Tomi Valkeinen Reading any of the DSI debugfs files results in a crash, as wrong pointer is passed to the dump functions, and the dump functions use a wrong pointer. This patch fixes DSI debug dumps. Fixes: f3ed97f9ae7d ("drm/omap: dsi: Simplify debugfs implementation") Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dsi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index 00a9c2ab9e6c..277f9dd2ec8c 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -1406,7 +1406,7 @@ static void dsi_pll_disable(struct dss_pll *pll) static int dsi_dump_dsi_clocks(struct seq_file *s, void *p) { - struct dsi_data *dsi = p; + struct dsi_data *dsi = s->private; struct dss_pll_clock_info *cinfo = &dsi->pll.cinfo; enum dss_clk_source dispc_clk_src, dsi_clk_src; int dsi_module = dsi->module_id; @@ -1467,7 +1467,7 @@ static int dsi_dump_dsi_clocks(struct seq_file *s, void *p) #ifdef CONFIG_OMAP2_DSS_COLLECT_IRQ_STATS static int dsi_dump_dsi_irqs(struct seq_file *s, void *p) { - struct dsi_data *dsi = p; + struct dsi_data *dsi = s->private; unsigned long flags; struct dsi_irq_stats stats; @@ -1558,7 +1558,7 @@ static int dsi_dump_dsi_irqs(struct seq_file *s, void *p) static int dsi_dump_dsi_regs(struct seq_file *s, void *p) { - struct dsi_data *dsi = p; + struct dsi_data *dsi = s->private; if (dsi_runtime_get(dsi)) return 0; @@ -5083,15 +5083,15 @@ static int dsi_bind(struct device *dev, struct device *master, void *data) snprintf(name, sizeof(name), "dsi%u_regs", dsi->module_id + 1); dsi->debugfs.regs = dss_debugfs_create_file(dss, name, - dsi_dump_dsi_regs, &dsi); + dsi_dump_dsi_regs, dsi); #ifdef CONFIG_OMAP2_DSS_COLLECT_IRQ_STATS snprintf(name, sizeof(name), "dsi%u_irqs", dsi->module_id + 1); dsi->debugfs.irqs = dss_debugfs_create_file(dss, name, - dsi_dump_dsi_irqs, &dsi); + dsi_dump_dsi_irqs, dsi); #endif snprintf(name, sizeof(name), "dsi%u_clks", dsi->module_id + 1); dsi->debugfs.clks = dss_debugfs_create_file(dss, name, - dsi_dump_dsi_clocks, &dsi); + dsi_dump_dsi_clocks, dsi); return 0; } From patchwork Fri Jan 11 03:50:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 155297 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp119269jaa; Thu, 10 Jan 2019 19:51:42 -0800 (PST) X-Google-Smtp-Source: ALg8bN48pQjuuF7giatnyfyCV/fItEy2qb93u8iw0EVo4EC/HNtUGXWbYl0o9bl+sbZ6pu+7Agrx X-Received: by 2002:a17:902:b090:: with SMTP id p16mr4063316plr.190.1547178702374; Thu, 10 Jan 2019 19:51:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547178702; cv=none; d=google.com; s=arc-20160816; b=UMtphCadh2LRiBFfefAyQpSDSl7h88sTMn5KhGYiUjGFVH1SNSEKGyTCZDjY8AKM1q 39KE5NGsCdKD5mOmrVnRasvdiNkg1Ll1oVZJa8lGBw26IL0pDoFPS3a8oLLkvcK7L7IM 0mh+1eq1B7WhPpYM+/whX075HhMubMuOTnPeYPLrpB5DENAOf46C4OOm3HV83SRS5av1 9MPQSE+7nRPgU8vAdL6DeiyK2xSayjtsvNEOaI9YEFEIAEs9AQdjDLa06uyr5xgPYzs7 XlXxLuUlTTXce/07GYoy6J/iwOk8MMY95ldOIFzxsOnxSQPXXJKPBKIFhlTbVCPhMknk QSjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=GxXMtkce7GxB8m6n4Wi58Eo9UwEwgUd0eVwW1MYqjW8=; b=QkUM9znxn4H8qBLD75JXtQhlBsPlV8uhuKREhypc74Pqv/JpwFYMgSyV2D5VFbhlcN kopspQnpTdfQbHtqdhL8iCTvitG5xbcBcc4RXVDPzLxtLZArm3aU3yxmUuUOzo+J1xdZ WrO4XiLaZ41WjO3gJUild3qvPp6xrps+aXGDHWRKYAfMfvRfv/HGej7jdr6m0UHlDbZM ItTR1/MkeikVv0k3btU4LjO+gydLm0iXOpIyhAHWc8LyDauMFnBSWjuJycZ9xbtPkGov IuVSYtLiQ2m3SemX1lXhkYwzSBcfbWeT3PaHCpewVuI5aqvBo+TskkqhQsjLVTJFr/7Y HeBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id 187si60762493pfv.238.2019.01.10.19.51.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 19:51:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 559DF6F517; Fri, 11 Jan 2019 03:51:34 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 366BB6F50A for ; Fri, 11 Jan 2019 03:51:28 +0000 (UTC) Received: from pendragon.bb.dnainternet.fi (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B4DFBD04; Fri, 11 Jan 2019 04:51:24 +0100 (CET) From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 03/49] drm/omap: dsi: Fix OF platform depopulate Date: Fri, 11 Jan 2019 05:50:34 +0200 Message-Id: <20190111035120.20668-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190111035120.20668-1-laurent.pinchart@ideasonboard.com> References: <20190111035120.20668-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Tomi Valkeinen Commit edb715dffdee ("drm/omap: dss: dsi: Move initialization code from bind to probe") moved the of_platform_populate() call from dsi_bind() to dsi_probe(), but failed to move the corresponding of_platform_depopulate() from dsi_unbind() to dsi_remove(). This results in OF child devices being potentially removed multiple times. Fix it by placing the of_platform_depopulate() call where it belongs. Fixes: edb715dffdee ("drm/omap: dss: dsi: Move initialization code from bind to probe") Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index 277f9dd2ec8c..b5685018d830 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -5104,8 +5104,6 @@ static void dsi_unbind(struct device *dev, struct device *master, void *data) dss_debugfs_remove_file(dsi->debugfs.irqs); dss_debugfs_remove_file(dsi->debugfs.regs); - of_platform_depopulate(dev); - WARN_ON(dsi->scp_clk_refcount > 0); dss_pll_unregister(&dsi->pll); @@ -5457,6 +5455,8 @@ static int dsi_remove(struct platform_device *pdev) dsi_uninit_output(dsi); + of_platform_depopulate(&pdev->dev); + pm_runtime_disable(&pdev->dev); if (dsi->vdds_dsi_reg != NULL && dsi->vdds_dsi_enabled) { From patchwork Fri Jan 11 03:50:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 155296 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp119256jaa; Thu, 10 Jan 2019 19:51:41 -0800 (PST) X-Google-Smtp-Source: ALg8bN5KG5y3vK2uiTL2BEn4IpBnceX0TXLuttzBp5XoK8X40cUfaHk0Wk0kfw/CmYOqefBWL8K2 X-Received: by 2002:a62:b24a:: with SMTP id x71mr13238856pfe.148.1547178700854; Thu, 10 Jan 2019 19:51:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547178700; cv=none; d=google.com; s=arc-20160816; b=OvTp0m7mhD0eatXf8lZb4IsNTYn1X3XbCPZ7FHtva6cJkmPVtVyM/hr/JryA3xPGcY s/cnkUiKvT41o3nHkoOyGDP39fMLpcUc/V7Y5DShx24xFzHLFaP/wMuIzHZzxh4fUbh6 b2tGT6/nbq5060RTpeLbGL+XLeSEca+eGlLV1TEbj5FDx7lUMry8GYZ2Yf3sW4JKFyNW Jq/9z6jzXcfMU7POXXFpL+cJEb22jaxNt2rA4pOXh6xjQTcolkwALFDiyJDQJo7tdNZd cZe9Q2YqmuZRdbfyJd2w1zbun1uayrlx7HDohij+ktBA26pc9vu76OTmmJHUR07wsmtf 3cqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=Zh2LOtCFv2+bVqeKx4S61O58iyTeHfvVcy+9KgwP74g=; b=09bCY2rL4r+NH+wiwPO+ZHLlelpj6V+CTNfh5oWLZHAGN3cQKrcw9qbbcEENmzfPF2 T7szLe9+i1kly/r2b7/Ng8+6NWZc2PvWlrfZozRTA0+h0HnDosqOcu3zr8l73ETuMYFY MAvY06+LwLk+mXtQAegq3SiXDvBIUdardXsJQQh6gAw9e5nZLzLxWMG/MmpwE9QccViq JeSbCosZhScNyQNaGrHIJ/eiV7QY6KYZEhiBMqeSSahqpS6NBHYzeK0NjSGO1N3ZJ3Pp Ke8sF1O/bkXgPfIFY4qCv27shXfWmBOjshOYAhkRV9M6DOGGpdNjFulwlI6+mD8ty3tn Fe+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id s19si3811269plp.151.2019.01.10.19.51.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 19:51:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0ACB26F515; Fri, 11 Jan 2019 03:51:34 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 197A36F509 for ; Fri, 11 Jan 2019 03:51:30 +0000 (UTC) Received: from pendragon.bb.dnainternet.fi (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 214E0E26; Fri, 11 Jan 2019 04:51:25 +0100 (CET) From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 04/49] drm/omap: dsi: Hack-fix DSI bus flags Date: Fri, 11 Jan 2019 05:50:35 +0200 Message-Id: <20190111035120.20668-5-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190111035120.20668-1-laurent.pinchart@ideasonboard.com> References: <20190111035120.20668-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Tomi Valkeinen Since commit b4935e3a3cfa ("drm/omap: Store bus flags in the omap_dss_device structure") video mode flags are managed by the omapdss (and later omapdrm) core based on bus flags stored in omap_dss_device. This works fine for all devices whose video modes are set by the omapdss and omapdrm core, but breaks DSI operation as the DSI still uses legacy code paths and sets the DISPC timings manually. To fix the problem properly we should move the DSI encoder to the new encoder model. This will however require a considerable amount of work. Restore DSI operation by adding back video mode flags handling in the DSI encoder driver as a hack in the meantime. Fixes: b4935e3a3cfa ("drm/omap: Store bus flags in the omap_dss_device structure") Signed-off-by: Laurent Pinchart Reviewed-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index b5685018d830..64fb788b6647 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -4751,6 +4751,17 @@ static int dsi_set_config(struct omap_dss_device *dssdev, dsi->vm.flags |= DISPLAY_FLAGS_HSYNC_HIGH; dsi->vm.flags &= ~DISPLAY_FLAGS_VSYNC_LOW; dsi->vm.flags |= DISPLAY_FLAGS_VSYNC_HIGH; + /* + * HACK: These flags should be handled through the omap_dss_device bus + * flags, but this will only be possible when the DSI encoder will be + * converted to the omapdrm-managed encoder model. + */ + dsi->vm.flags &= ~DISPLAY_FLAGS_PIXDATA_NEGEDGE; + dsi->vm.flags |= DISPLAY_FLAGS_PIXDATA_POSEDGE; + dsi->vm.flags &= ~DISPLAY_FLAGS_DE_LOW; + dsi->vm.flags |= DISPLAY_FLAGS_DE_HIGH; + dsi->vm.flags &= ~DISPLAY_FLAGS_SYNC_POSEDGE; + dsi->vm.flags |= DISPLAY_FLAGS_SYNC_NEGEDGE; dss_mgr_set_timings(&dsi->output, &dsi->vm);