From patchwork Tue Nov 8 13:59:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101556 Delivered-To: patch@linaro.org Received: by 10.182.113.165 with SMTP id iz5csp1713213obb; Tue, 8 Nov 2016 06:07:57 -0800 (PST) X-Received: by 10.99.143.73 with SMTP id r9mr4051368pgn.54.1478613627385; Tue, 08 Nov 2016 06:00:27 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si18800890pfh.232.2016.11.08.06.00.27; Tue, 08 Nov 2016 06:00:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941AbcKHOAX (ORCPT + 27 others); Tue, 8 Nov 2016 09:00:23 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:63102 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbcKHOAV (ORCPT ); Tue, 8 Nov 2016 09:00:21 -0500 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue001) with ESMTPA (Nemesis) id 0MBw2x-1bwixQ3nEN-00Aljb; Tue, 08 Nov 2016 14:59:48 +0100 From: Arnd Bergmann To: Jonathan Cameron Cc: Linus Walleij , Arnd Bergmann , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] iio: gyro: mpu3050: remove duplicate initializer Date: Tue, 8 Nov 2016 14:59:29 +0100 Message-Id: <20161108135945.2217384-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Qbl971ZGVN4UzuPPhnstg5tEj6vwCQH5NH/C6BLh9leRGElQkM3 OP7WseJ2A2CE9mevsSav8UUMi3VyipVF7oOrQZRB/o0Xsh8bmmU2GW1YmvENbRGuWB4fU6o WqChc9V+UUDplvj6dgZWU7SYHTgPr8HA+fpLJajrsyMMddGhTYM6SNsZvFRmaD4XUzvVvI0 Fojr1CtAdetb+YlRlbh6g== X-UI-Out-Filterresults: notjunk:1; V01:K0:8F5d0AwQ4Q8=:E/CR4ZRajF+rw+CvA8a/Ds HoN2jO8t86Z2mzFPQbiIZf+hkYA3xtf8kNIZDGINielGDWk+SBiA04Zdlf1WujOJVumuShyv0 Jkqr8Ef2KXhA9nfQZ7QC+YRQW/nCZ++EpBN5kLxit05NszSb3N+BjFwOfndf4ShuYWMfzN+K2 QAw9cd0Kt+JzoCozSGNd1D0XDo33irmQmszjWSIFMvisRTQMRaSNPmppCoKGxenhW4XN7txUY GeVVDbx8mf6u7A2WPU9p6SgXYgo2YyefpoubO0aH3CvNJcvfhzbU/sIoO1gDN2JGE8xNHUwos sRYnIJyrJku3X3l+iaF1vjxSYE5td0KMSIEg11l1lk0QdS0vga7wx0+RHMusKP+KD6XJmTsrU 0UlK5IpW/KPMsVuk9H/ZyrVUumcMqK88n3a786ZAVSBm2XDaXk9TUAbNBDoJyjCIlLfUr/woi lRAH7WQ6OeocC6SKi5Qa1xPWstTi8GbApzOYKvZqpW/1zihjpBRT8augP7TWu91K+DIexaxrg 875+xgG3K3LDP4RIuhr679DxgmlCuaa//vdqu6mVG2vB8iYxu/Xvf7hUzbof5+2TWUxE+6VJc s+0YnIrP1uQ8X1GBgzTl4RgOQ40yfoazjO7SYhWnOEviQ+iUlTlck1QayfV+bW3F4KVOicLxL ZZlQoUvHMWR+HKXX2N/nK/cPEnskG2NftHnAdwE6hRqf23baFQXxTjdOwUhhVtskFsdI= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added mpu3050 driver has two initializations for the module owner, which causes a warning for 'make W=1': include/linux/export.h:37:21: error: initialized field overwritten [-Werror=override-init] drivers/iio/gyro/mpu3050-core.c:749:19: note: in expansion of macro 'THIS_MODULE' This removes one of the two. Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope") Signed-off-by: Arnd Bergmann --- drivers/iio/gyro/mpu3050-core.c | 1 - 1 file changed, 1 deletion(-) -- 2.9.0 diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c index ed681c70a7b4..2be2a5d287e6 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -746,7 +746,6 @@ static const struct iio_info mpu3050_info = { .read_raw = mpu3050_read_raw, .write_raw = mpu3050_write_raw, .attrs = &mpu3050_attribute_group, - .driver_module = THIS_MODULE, }; /** From patchwork Tue Nov 8 13:59:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101555 Delivered-To: patch@linaro.org Received: by 10.182.113.165 with SMTP id iz5csp1708341obb; Tue, 8 Nov 2016 06:00:48 -0800 (PST) X-Received: by 10.98.35.211 with SMTP id q80mr7269761pfj.26.1478613647956; Tue, 08 Nov 2016 06:00:47 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i70si37158122pge.249.2016.11.08.06.00.47; Tue, 08 Nov 2016 06:00:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753152AbcKHOAn (ORCPT + 27 others); Tue, 8 Nov 2016 09:00:43 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:56101 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbcKHOAl (ORCPT ); Tue, 8 Nov 2016 09:00:41 -0500 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue001) with ESMTPA (Nemesis) id 0M48WZ-1cuyXu43O7-00rqIF; Tue, 08 Nov 2016 15:00:06 +0100 From: Arnd Bergmann To: Jonathan Cameron Cc: Linus Walleij , Arnd Bergmann , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] iio: gyro: mpu3050: add I2C dependency Date: Tue, 8 Nov 2016 14:59:30 +0100 Message-Id: <20161108135945.2217384-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161108135945.2217384-1-arnd@arndb.de> References: <20161108135945.2217384-1-arnd@arndb.de> X-Provags-ID: V03:K0:Cj2MmwTi9vcERO7Ph14crwrJUwg48xsN1Rl2ibQoV4x7KyZUI21 EfSKJdbRBhwgjoq1FpqK0GAcPNtWEZ23DX8EnAC8KMBODaPUFoZwkA++uo1GUjAnCUxaG/u Tu3VVfDCeCGOxmKO8BodgpHlBFvYFHAbgUzfbOH2gDkLO0rfwp12c0LCPAigUY1ibk7d6+V JsU5oiYQjWZDLtTJ0ER8g== X-UI-Out-Filterresults: notjunk:1; V01:K0:Ya8+YCFmXv8=:WPhFU6no+nrFYpL5W4Kdip 3lsMmFMjcBDlLsheS0o8dIm3lVtqaJm3cgy27A6GGWNEvxEjJB+Vm3fNb6Kb+KQLONFkiZPDy 5W7h85aYqMTMn59mKiPVs4zDZjs7jMi7zcCIK4kgvGzhm74g8DDEAM/faJFQCM0RpXUV5j+wK 5yBpcdBLNlJWzUyGtuXyA9aveW4kc7pstMeRFm9cXGQf9trPeM4j4ysMheu/2z3dZN0kFigbP Xvl5gZJcJrkqBtYeMHFtnfA42Zk5nq+DcuN7CO8EfXLf7IsG3ZEu+Bpg9UGf4J9Fe8PQexoFe n+4BDJ7Yj8KK4Tut1R5jYI5VhmLH5mt0m+ilBvnjRPHTBd0/BDZszNmtfXBAkMmbttd+GZlej rXTWqcrLzBL3iYuusc2KgmCptuKbYzUghaZagJo+kzEi0PZN/XpMSCqBMSq9/mpneMnNQ3LFo nv7dUmU81Kj/62eAd9F5KLDPXMC8ub1/E2iwD1tzo5bTLzjNO6YidtZ+ceszhR0MvvbAwUUd8 FmtXUNpZVgsm/kcizFx6c/tQNCmF1mXBK/okNGdUqkUbbI0HvojujSJ3qm2/dNsXtmtzuBvV7 J6KuDqp1xGKqIWm3m6NfWATe/7PaKEzcFoYRoB7yU5M9w1rC91s0wgzFLiqkO1yi6jGKghj27 WQ2r0OYA/oBN4OwW1fF90w8NEz9cc30zdFZmjA7+0EEC0yW7LV0T1/FQWJHhvyZzLGnY= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The new mpu3050 driver fails to build if I2C is disabled: drivers/iio/built-in.o: In function `mpu3050_i2c_driver_exit': mpu3050-i2c.c:(.exit.text+0x17f): undefined reference to `i2c_del_driver' drivers/iio/built-in.o: In function `mpu3050_i2c_driver_init': mpu3050-i2c.c:(.init.text+0x215): undefined reference to `i2c_register_driver' This adds a Kconfig dependency to ensure we only build it when I2C is available. Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope") Signed-off-by: Arnd Bergmann --- drivers/iio/gyro/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig index 107b5efd4178..3126cf05e6b9 100644 --- a/drivers/iio/gyro/Kconfig +++ b/drivers/iio/gyro/Kconfig @@ -93,6 +93,7 @@ config MPU3050 config MPU3050_I2C tristate "Invensense MPU3050 devices on I2C" depends on !(INPUT_MPU3050=y || INPUT_MPU3050=m) + depends on I2C select MPU3050 select REGMAP_I2C select I2C_MUX