From patchwork Sun Jun 26 07:24:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff LaBundy X-Patchwork-Id: 585164 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 228ADC433EF for ; Sun, 26 Jun 2022 07:24:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233049AbiFZHYp (ORCPT ); Sun, 26 Jun 2022 03:24:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232885AbiFZHYo (ORCPT ); Sun, 26 Jun 2022 03:24:44 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2069.outbound.protection.outlook.com [40.107.223.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9D4210571; Sun, 26 Jun 2022 00:24:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JSPMSH7Wp/Ip9wvGP9pFWGcEQgNUX5BTzem/nQZFNQZNnglCWCmv+haOx10Om3ytrKVu1td6rzHO2gt4qOCn2p0RwzIBAJgyBHz0JNhcQQi5APiSs8dZC4pNRhTNODlftz1ukwfhM81Aq4Tyy1zryRoF7kxWZOjAvKJe1kQ+R8Lz8wrudSlRsqDZzB6YttjHZSODaWImG0w9BS97PGdKcq3/y+h2Vanb9ccfwtUVr0Enp2dfiFNF47lP7CpCuYOdzabEmExuniiRXmjJhiXBUuPgKtzya+I7LndWMxOXG8DCAZEh5lXX/u2dO38cEzf+IVy+kJvQ+StRkVy9shJ9fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6lnNN83Xs0GUQ5fcRT0kNeDPc47CuH+MaGIvX5JJsuI=; b=Q+8FvfjWUDWYLLqm+oizgEz86qQ+crc2Qzv3h+9Fke6jcRl2QMVgXLZl4ZiGFD+ugLULWYwoFQKz3zswJqF1IiUpts2Eew8wyHahznIWWK2gSMrmWM4+tlPMs+dxm1LlLYIwRjSZgA7g8fAISP5wq3eH1TlX/0tr9DyRikwYuQ8HV/7zRHs0YsanNrwR+jXQuuPYoNza2WTOCQVl0HrHs/Tsh48WZNFemxuNoZP/C6X4fBrA82JKMyhHKSlkDTY4otq96OyYUBsiToa5lXdqJOhrRRorJCfYyBfxoujO/lSz7qD+pXEdZbw0fMZGE029bO7xEc6FgY1o4c49mpOxTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labundy.com; dmarc=pass action=none header.from=labundy.com; dkim=pass header.d=labundy.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORG5796793.onmicrosoft.com; s=selector1-NETORG5796793-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6lnNN83Xs0GUQ5fcRT0kNeDPc47CuH+MaGIvX5JJsuI=; b=smz9hdPBerh96q2zubAkfngwAs6rOVVcMsBeByB8Uuu3vWOq2hUEQtNn3tH9v+sMB81IP1Ie+vKLjy3Vzmd6sHcmf4rKmfBdBKB9p5SIPzr5RXTOO+O+uHXP6XN64dR45mlf1sqqScqOQy16CoStV8PLjJFugFkC/RAJWtZWIUA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=labundy.com; Received: from SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) by BN6PR08MB3395.namprd08.prod.outlook.com (2603:10b6:405:66::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Sun, 26 Jun 2022 07:24:41 +0000 Received: from SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0]) by SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0%7]) with mapi id 15.20.5373.018; Sun, 26 Jun 2022 07:24:41 +0000 From: Jeff LaBundy To: dmitry.torokhov@gmail.com, robh+dt@kernel.org Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, Jeff LaBundy Subject: [PATCH v2 1/9] Input: iqs7222 - correct slider event disable logic Date: Sun, 26 Jun 2022 02:24:04 -0500 Message-Id: <20220626072412.475211-2-jeff@labundy.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220626072412.475211-1-jeff@labundy.com> References: <20220626072412.475211-1-jeff@labundy.com> X-ClientProxiedBy: SN7PR04CA0064.namprd04.prod.outlook.com (2603:10b6:806:121::9) To SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af4ad5b5-6606-4ff4-6382-08da5744ef7f X-MS-TrafficTypeDiagnostic: BN6PR08MB3395:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cpZvVGREAvkWRm5ofnp4t9te5K44gN2KOH2cV7mT9AU4OTxUkROKa+DOhtdfLycCJjHNzc3AujXSGfe9ssiT7ix6BrBDvAJ7dlG8a/T0jKwZOYjAITOwnwE92TrYAO9/AyaPAiUvhBDNbT3sUpZUAjmmRtsAHDSxePvA5ufzgNnnFw+1GFcarbQqYGma0YuM1GnIezYWd5FcUEbUlwxR2bpZQn30h/BPNnUS2ReqkJkUNZ2Qege9MIsQjQOmBILi3n5OdHOCOFn5aceyQU+U8Yjd8AVYIjUxTDCx81zhb8alnsCoHkkr3VC9LL187KWdtEwzAj8aBIX4fkMDiXkX+LKikNVeYsVrL3Ew5mBD4X2vmADd2g1+8HyaflZ5E2r98z5jFsArWtREOazNYv8187uQUzWyLaCcKA5JVphAYCwhFqVp+J+wQ5JAYBlzfbG/5Pr5WE80U81li0BNc1mH6LTRYza0Im2HC6x7n7bLo49TAmCFmixSXekAX/lQPVt3iXr9ROStbl8ZOlcgFyApK5f07tBozmL4YvoSB9OvjTHgQVmZuHb0NW8Dyg3YignuKLIY4xZb64l+6QVvp+E/JLnOaFdxp7DghTPx3mXUj4I3b30W1QR+PsGrFf/F0CqXhop0tt2TiW/mbIIkTFkC2S2V26y0dYoSaR4paOC+9lgNdrc2anOVIskGfTkpZmDqhqepBu7RMJLIdg4rE3UItZhkEq9U90gcU3AHEptSfqzZXoSW6pQpKGJYGhHEt8bjhe3I7DM5NR1FVNB+jw1sF7AomSqfhw6Fx4dciRyKSNo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN4PR0801MB3774.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(39830400003)(136003)(376002)(396003)(2906002)(107886003)(6506007)(8676002)(316002)(83380400001)(8936002)(86362001)(1076003)(36756003)(66946007)(186003)(6512007)(66556008)(38350700002)(2616005)(52116002)(26005)(38100700002)(41300700001)(478600001)(4326008)(66476007)(6666004)(6486002)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qx+ym9WN2rvisiYV8AKtvprgnJi+TJG59nrFNxwZ6fiCA1jYbpM/XdMqb3qE5pWNy4+cINDooDfbSdcxSDF+OvnMZykg0zZxry2xOoPyB7mFro4shmiuiDNaHTd1oHizbad6Lk9jI/raH3qTMTdiFYKAps9MQlmkDpN6e9R+vkvouuVpdyV5VdnPmllYvfcb1IGJQcehLwFPEgSQuzIt6BLmkALHzzVFukkEzhPpfnGmByBvCkHYkNFJxSHh6dAanulI2rEbnLav4YDkoy/FDukRBo+byuIV7QStQLXmkWREOqXCVltGUq6VS2s3f0waOxwdGJlOa2WounBlu+8HfDcZf+KX9ki+181fpCc82+J21/7QkqLoX6kAqYpBgMUuhFp5fsHGvEnV3H9pZetRBMihCitkmX/oVSP5rRhIUDptnIWOzQ2gNfzVLIdH7P6Y+DfDMd4t2ccOic//e3GldW58ZrXAZSBuJ+zGV/Vk4HF8zpHOeRISoByjKd5rEHPPCd7B+tYN21a2SJUKuacLVMMShqDJ/7TYqSB1BAsY27woxcmnENX3bcZ6GMmkT32RHPudaye0JIfVG1GK/0kWQVBjP6e0FNd8mTPSzzBhdyfW6xvsgTLd0xec75um1SA8sMABjjM2VRtFS3UNKPlsQiSlxFWsQyPzgBdL4rmR67eZ66RXHCf8sEOzSLPiCAAvhdBZrKQR2hDZAx37fiNp7VG2N+aQ+LWkn+Jh0DxF1cjYhXBgoXMm5FerhHDcWbJBcfVjhe2nOZFQz05tmQ0zq6uBPZz0mgTD8n7VzgimSW1ItAqF02gkM7xiRWEOzpmTsvWjXUIbvGV+QOhEaFEzAG7FxqcMpIv7eXYCXf9f2TesWYwszOK6gHHpuaETKH/Hogfn1VjoTqVJ4CSnSzkTI2rpa0kloYWqwExQvS7Ju/LH7EghYqRX82X5OOcSP1JvKTODMamf+azTmBEFXMRoOoKOiySeXnkyv8j3iUMGJVt0q7X6mc4br+Eb5Q9B1+Z/OPMgrK1RVGSUgfAM2zAsJ14Aw7d9d0e/TfOa/k6na8epsFwSU45/kPpBpaH+EbJABz+bX5HQoIHo485IqiMT7MyMOEJQRni/pg4b/xqRfbm/Lbiil1Vx9acM+vZMl5m2/GW6sPCSg3O+MjT6LK02PTLdjoDN14Ecs9DbJLF+cQ6GhISc8ebIASshzx+Q27SUMhIj5ppmIjCB8n3AwPoPf5hGrB2Wvl1L5Ggq4IRxDZtnFrTzS4P1+38izZmkIid8mJFh0qyeCiuav3YJ66WuOs/eP/9EgZKZF1tNtjdZCFDB/KuB37uTKg6RL5jmrGAOQqEfMXEgiTPGjMUwk2mCl0JQFWeEcxc387dq02GzG9L2HLuFiiLMwcmC+cBqfCLQ3wXzL4fTvMnT3pmsFGzqqwNT9YXujk53lWtHILiwuoI8w/DE3tr35zS6hIjiP4traIr7JqQV2stOuSV00W58hOd/8EvEyRh2UZtetNQI9pFWMT29ys1Ag5y9qCSS3IzJl4vn7mr+LUO0gwpnMkkWM00UqF0cbw+JLDrB+nm29Rp0TfRn4LLra3cM5z6iNoWr X-OriginatorOrg: labundy.com X-MS-Exchange-CrossTenant-Network-Message-Id: af4ad5b5-6606-4ff4-6382-08da5744ef7f X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2022 07:24:41.4935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MWvZt1QVr4TbM96QcsgLFv+wzT5tSaLR+cfQOkYXmulaAHJsjNnRokKHmxFHKZgW0i1rx7uDunbHf94ilvhuLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR08MB3395 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org If a positive swipe/flick gesture is defined but the corresponding negative gesture is not, the former is inadvertently disabled. Fix this by gently refactoring the logic responsible for disabling all gestures by default. As part of this change, make the code a bit simpler by eliminating a superfluous conditional check. If a slider event does not define an enable control, the second term of the bitwise AND operation is simply 0xFFFF. Fixes: e505edaedcb9 ("Input: add support for Azoteq IQS7222A/B/C") Signed-off-by: Jeff LaBundy --- Changes in v2: - Added to series drivers/input/misc/iqs7222.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/input/misc/iqs7222.c b/drivers/input/misc/iqs7222.c index 6b4138771a3f..53df74f3a982 100644 --- a/drivers/input/misc/iqs7222.c +++ b/drivers/input/misc/iqs7222.c @@ -2081,17 +2081,19 @@ static int iqs7222_parse_sldr(struct iqs7222_private *iqs7222, int sldr_index) sldr_setup[0] |= dev_desc->wheel_enable; } + /* + * The absence of a register offset makes it safe to assume the device + * supports gestures, each of which is first disabled until explicitly + * enabled. + */ + if (!reg_offset) + for (i = 0; i < ARRAY_SIZE(iqs7222_sl_events); i++) + sldr_setup[9] &= ~iqs7222_sl_events[i].enable; + for (i = 0; i < ARRAY_SIZE(iqs7222_sl_events); i++) { const char *event_name = iqs7222_sl_events[i].name; struct fwnode_handle *event_node; - /* - * The absence of a register offset means the remaining fields - * in the group represent gesture settings. - */ - if (iqs7222_sl_events[i].enable && !reg_offset) - sldr_setup[9] &= ~iqs7222_sl_events[i].enable; - event_node = fwnode_get_named_child_node(sldr_node, event_name); if (!event_node) continue; From patchwork Sun Jun 26 07:24:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff LaBundy X-Patchwork-Id: 585163 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F62EC433EF for ; Sun, 26 Jun 2022 07:24:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233104AbiFZHYy (ORCPT ); Sun, 26 Jun 2022 03:24:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232885AbiFZHYw (ORCPT ); Sun, 26 Jun 2022 03:24:52 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2064.outbound.protection.outlook.com [40.107.223.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CEC862EC; Sun, 26 Jun 2022 00:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6zxHt2u1x19nYR0TS2c/ODT73oae8H2/zKI1L/uYMx5UYhZVBFMb1OQcKruZ8mE3fcf+h+4baDVXhV+J6RkPLEda5UbVwSpxAv7ZY9Y4XEyzrjfVzWoR7LrPjSnGoqYAGwCWXxf1VXS86h5AfiCGYbfVTQBsDwJABF//fDxslic6z4PNx00ngRZXwUYqJ/futl9og9mmvURGKbIjkXQ9DBvxN2ShOlA13ifBqyNDv9sxGMed0ApYsyQV+rW+/ejpygCM8EkQnqlKIbQyQM7829wiDfGGdCThVx8muxDiCj//+FnSWpV5+3iIw2Fvhv7eS0meX2AXM8YLXpF7B4zvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3EZw7rbfVv+OCcz+0aKBjyhYrkCp3xfZamrOwNsywLw=; b=S4htuNkW8xh5/81FfDbdImj69QR6ldsOhLxFPGELd8/k7Hhf8R9oRcezrOWXBkRXT9Rxez9yjQ2c7WFsTV4CFlUUembYIy0iVqSgJgpo9hlGtwIUBDghNU5hWTGvp7wdPNOSLGCVhaXptNu1hQYxXb2jJNfYo5qmPjNx6kTlYC/DsXC1ko1H1RmGnWVHMNgeOKMSZGk8l4Ek/t2K7F0BHxKAslnkpPIECpmONiCs3ueI60EZZjEdqPPVYSZL5UhJuBdc4KSNZbAh4DaFW6QlMALTuFlQ5nSzf0ejtzKKxTpi0VWEmSJvtgN4SUlGWbiFb/OBAgTvGdSrk8v6zF32hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labundy.com; dmarc=pass action=none header.from=labundy.com; dkim=pass header.d=labundy.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORG5796793.onmicrosoft.com; s=selector1-NETORG5796793-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3EZw7rbfVv+OCcz+0aKBjyhYrkCp3xfZamrOwNsywLw=; b=HD1FMvGbtT/MNySwLpjscTVC4Zhrn+K/tYHs0LL0G75LofjNBTp986RznNT3K9C+nU84MV/yB1oaMCs1n4Mt0JtMS07v+Gp4gJqZlQ7V7V2xGFppzgFCHjrZLW/VpQfTTMGZFEZJ3u8YoiZg7nPAdGZhGQ8Wqq9C2AbF4mRU0Go= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=labundy.com; Received: from SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) by BN6PR08MB3395.namprd08.prod.outlook.com (2603:10b6:405:66::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Sun, 26 Jun 2022 07:24:51 +0000 Received: from SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0]) by SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0%7]) with mapi id 15.20.5373.018; Sun, 26 Jun 2022 07:24:50 +0000 From: Jeff LaBundy To: dmitry.torokhov@gmail.com, robh+dt@kernel.org Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, Jeff LaBundy Subject: [PATCH v2 3/9] Input: iqs7222 - protect volatile registers Date: Sun, 26 Jun 2022 02:24:06 -0500 Message-Id: <20220626072412.475211-4-jeff@labundy.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220626072412.475211-1-jeff@labundy.com> References: <20220626072412.475211-1-jeff@labundy.com> X-ClientProxiedBy: SN7PR04CA0064.namprd04.prod.outlook.com (2603:10b6:806:121::9) To SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0463be68-5146-483c-62f0-08da5744f513 X-MS-TrafficTypeDiagnostic: BN6PR08MB3395:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sFuaRZtTEpObcQ6Jja6d6M3tCfpibkYE9Cv6xXqflmX0vqX2l1ApJ3tBlg6Z2wyXY5jtWIy9Cj/hgO9R5UxgGCRwxWo8FoU68hLVYOiVApL/Y0tYIYB/XHK140oEi4M+dbTqbzXxDhOBFfgcfYMaJ/0UE8dYY9WiUtybEnS5NknWr223XZuoueHPw6wpZXqQ72oP7YbmMZdtkLMvtwFUDsJCDe0Df3j20mSbl4oo6BTmUZcFJB0wmq3LkG7hEt4wMPDBF4P2xLqlmMIjRM41eXxn1RDEu3Okkk+4kLIrdFC13K55ZrXSvWjDihqG3DBy8PnQN73W638nVRtWP1OmM7zfwgnBlqEHExizn4tZEQ6uMKuQyMRSACiX7dx19r51Tgx0Sll3IdsVjNyGai0BAtecYi80FsWbv8GZpdC2Nu3J0WPKy84RDm4PKu+62GIb9zcTuXZNsb1i6oLwPnQMA1qu9JWhNn8nz+plUzr0okgqo6RQypEeOanMLyAsxT3KwpyLTF3ZgNdbO/qFQs23nJADgtXdAitkGrVUqChuUTWV1PsampRq3lCwrY+8+Sl9SH4Y9ILp3b5LIj/mjKwmQxtZGAZnhMXX5/uiT7sMPLyByAXNypyv35YdHO6aifzCb2vmc7zVf0oZItYqJeS4d+bOcJYO2ce08Mbky4An/AMvHtdOjzXNfMJY81MkPNu7/29JLIp7FCAkxDXif3e2lBTCXT/tJB4tsM3uSKLJDVGI6RPFJIILZsCaIh1I5eea/yNXitkpCb6OGJ7MShb3qchi7F68oWfgp+sbkfBu87M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN4PR0801MB3774.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(39830400003)(136003)(376002)(396003)(2906002)(107886003)(6506007)(8676002)(316002)(83380400001)(8936002)(86362001)(1076003)(36756003)(66946007)(186003)(6512007)(66556008)(38350700002)(2616005)(52116002)(26005)(38100700002)(41300700001)(478600001)(4326008)(66476007)(6666004)(6486002)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ajo/5N+Ki9VXmh4mjfCmTA0H3SJ7k2kbmPnTy+s5p1941qIkTDoqlYCqsLr1o3AVO4SZwMOiON8mb5ZiujiwZQ8CHGmQ3XLXWbPgagT7Lq4YKsKY3AI/7Iqr7dZ0NEvlf/3jGZsq5JOjuLDvNKaaleTDZZwgzJvRZNX3H1b5s1Z6Myrjub4otnjER+XjfVRRFsjvH6egafIVbYvkRQ4rVGMhtmcsilu1xl6Jii27bxqm364dvs3n1bd6JysmBT3HKsvtqJ+Kmn1V/iRh9NueITGTazCd24bl2+EkVL1s4ZO0Cjy0Z05Tn4OTbbk6opLJpt3/oi2VJypTgS42r5AAByr6ndbLS2wBE9XRTdFl+zckTZzYmxcZmlcgU5ausj0FP2+K6WEcAKZrqnwyRy5Ln4kgZYxmMbnOxfKDwJDIshJeITZwShZpJoWO7yYDlsBK8Vchx+ktl4v8AqOY+XnJ3X2wASB2EX7q1oJe81YOiN9DwKvcg8BDwAT5REQcm9f1Ui5/P0xb4XSo1ttDBUNw4r+RKnPuuUr/qRnQmvnY77N3FnXsCjkOWkzQjoWGLb9bJb6okJ0dYf6gkH9Y6D4JM5qBG9jwSInAXJkdEXCpKTqESNdIuAAiK5BxcR0ZvprZ6zDvsSNf49r9BZcMaNjzeHYLpWS2+cv0iV72AYoJRSeY8IX++QgQ165R8JEbCOYfvJSv4KQZ9fynOc3p8Ob+d+rU6u0HLjQ+C9/Jjw1pP9/6uvWdsiVtQ06admWaBO5T8B1r1er6ZC+De7/aqeHJ1BLsUPnSMHK7SFU/DrPMbDOl9RIDOdnKPsu5lTnVjjAfSW7s/lxEasdGs+ReCLykk63R0qjnnEeQHO2UgkE/5UNTLBanfiU/YYlWuwUl68UV7/g+59SkOpek+dRwf2ES84CvlohZtPJDnl/m4VEJdpMlATMcx9Y9NKfn893FqvLWKr98DTmRMUynT0//H/6fbE2goKY9GA8HIbwfJuYoAjbuWIXMERA5j0FJ5sDxqPnd25kVPriNxvG0DyCqBhHYdXuJY1BBLhx9nOZMwKyTBbA7Yo1YEoGT702UCa1ZryhscA9X/DVVdJnmuiVaE0CHqicrETIe32bwjaSuC8GmreFNZLm9qDqs2+yNpoxA7gevn2+9CJuawSOHWgjLtjgAnsgjMyEV69jy2S4u105qfPvkw0wNHDpCbh2NqfvR7PNDRulMy+brHkm+Fe/hHsYsuQVICPZKuWYYY8qJcuUiRGLVJAtdQpNYK+G4bIJsk2NCvVjCOFlPwDnBDfzn71FMvI+B//s6rE1bw4A0DL7MlLfRZJyfp88wN28QSiW1WgGYbEuXZ6EBB9eX0dQVfeV15u9Tn97O9vg0NXbZoB9RuQmt1i7i/ocpfqANwpJwrFYSG2wg9ciZOu+ozTyCBWG361Um905dXjkaa7oNFQEmqp/mrI9shweDXO/JluqFiAiIKCxwU3T0maQ3H7PHYo51upZI1koVmhK9dG3DfsPrOo42pqDopKQgXz3MEKTlQxQeoR8QGLQy9aD4LMXXyhsBdsQ6iSny3VV4ouOJ44bKg8AiW+D4DMaozG2ml7TnhRnl X-OriginatorOrg: labundy.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0463be68-5146-483c-62f0-08da5744f513 X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2022 07:24:50.8521 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k6Lm3DWoEKtS81JGapNFhkdWPL3MaV07ILxP6W9hgshDtHONiawgHKB+RAyyF6Vlk7SCthQhBB0s+qI7U8Xlmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR08MB3395 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Select variants of silicon silently mirror part of the event mask register to the system setup register (0xD0), and vice versa. For the following sequence: 1. Read registers 0xD0 onward and store their contents. 2. Modify the contents, including event mask fields. 3. Write registers 0xD0 onward with the modified contents. 4. Write register 0xD0 on its own again later, using the contents from step 1 to populate any reserved fields. ...the event mask register (e.g. address 0xDA) has been corrupted by writing register 0xD0 with contents that were made stale after step 3. To solve this problem, read register 0xD0 once more between steps 3 and 4. When register 0xD0 is written during step 4, the portion which is mirrored to the event mask register already matches what was written in step 3. Fixes: e505edaedcb9 ("Input: add support for Azoteq IQS7222A/B/C") Signed-off-by: Jeff LaBundy --- Changes in v2: - None drivers/input/misc/iqs7222.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/input/misc/iqs7222.c b/drivers/input/misc/iqs7222.c index 57616a7ebeae..c46d3c8f0230 100644 --- a/drivers/input/misc/iqs7222.c +++ b/drivers/input/misc/iqs7222.c @@ -1274,9 +1274,22 @@ static int iqs7222_ati_trigger(struct iqs7222_private *iqs7222) struct i2c_client *client = iqs7222->client; ktime_t ati_timeout; u16 sys_status = 0; - u16 sys_setup = iqs7222->sys_setup[0] & ~IQS7222_SYS_SETUP_ACK_RESET; + u16 sys_setup; int error, i; + /* + * The reserved fields of the system setup register may have changed + * as a result of other registers having been written. As such, read + * the register's latest value to avoid unexpected behavior when the + * register is written in the loop that follows. + */ + error = iqs7222_read_word(iqs7222, IQS7222_SYS_SETUP, &sys_setup); + if (error) + return error; + + sys_setup &= ~IQS7222_SYS_SETUP_INTF_MODE_MASK; + sys_setup &= ~IQS7222_SYS_SETUP_PWR_MODE_MASK; + for (i = 0; i < IQS7222_NUM_RETRIES; i++) { /* * Trigger ATI from streaming and normal-power modes so that @@ -2241,9 +2254,6 @@ static int iqs7222_parse_all(struct iqs7222_private *iqs7222) return error; } - sys_setup[0] &= ~IQS7222_SYS_SETUP_INTF_MODE_MASK; - sys_setup[0] &= ~IQS7222_SYS_SETUP_PWR_MODE_MASK; - sys_setup[0] |= IQS7222_SYS_SETUP_ACK_RESET; return iqs7222_parse_props(iqs7222, NULL, 0, IQS7222_REG_GRP_SYS, From patchwork Sun Jun 26 07:24:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff LaBundy X-Patchwork-Id: 585162 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC167C43334 for ; Sun, 26 Jun 2022 07:25:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232885AbiFZHZC (ORCPT ); Sun, 26 Jun 2022 03:25:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233516AbiFZHZB (ORCPT ); Sun, 26 Jun 2022 03:25:01 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2054.outbound.protection.outlook.com [40.107.223.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBF9210571; Sun, 26 Jun 2022 00:25:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZlPj112D1DO4YNJbFuAlyGVe5EYj2FRSDjABMf/p/piT+TPdC4F4fFAYxXU25HtP6zUaAn5sOEA2UuSiEw3bD6mTnLeAU3pX+/JSDYqX7tzYlDmcJVhuQsh0A4dREaNa1OaMZQACUjsLg3Af11eNnBxqwlGHAb3HUfjExWNKqT17YY9SzaBhkWwXi8mawxmwgACD5DbJ1HJdDKJGnBnvDaUHbciwVssaS3eSe6sglbzlmTvEZZRVJpK4lTwxm1f7kTF0CK2qF3bm2/+FkpqnYJsQ6+BOSe/jy/LEW3O45V4pNqQ7X0v0Ebx9PqbM0dWukU+rGlr11qd2bfeQPLT3iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wgTI281MornsjlatUlOhokJU1pCJWeR8Yh3ZBWRdgNE=; b=ec6ryvfJO2zYm4WgsPT2DCi3zIinHsvTRmpbbWO+sIQrIwhdIpvlxXC30FapcOlQ8KxaMgGOvMtVRgT0rtWqpJ/TD0IInrwGtWG/JXLAbfLVcRysYm+bb5LCyNALP14cKyUhlNhYYK6e/BL691cONIyJYjCJ2yFWXTlBoJRUFJlJu+ASEOmAHMSTTyoc/YO25XVK7WSL+o1MJSALYZh8HpEMHB0CCv279mkhb48S2dPf3dXFx/SGakeYd3wVpAh19Yxjb2aYtglJXRDOXMe8AclyBRh1VidM6DuD8IqPRYUmoKUN1tA4oIOLLp7Bb3/+HatF8SZLGZpBg0Oo2ZZjuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labundy.com; dmarc=pass action=none header.from=labundy.com; dkim=pass header.d=labundy.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORG5796793.onmicrosoft.com; s=selector1-NETORG5796793-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wgTI281MornsjlatUlOhokJU1pCJWeR8Yh3ZBWRdgNE=; b=GLwILCi6qFPKkCmb1UxQN+PC8rlltf3dDm60MNco3JLewry7nepX5Pzy8wcci5QqplUu4ZfzOR2Gj6m4q9KQPrruFK9DjjjSwxVtfG05b9QxHx4kr53d82yonaZ+cpAx7BfsgHbgw/mr4S8jKxvKx7KBSFSwjPuIsZ/DOWDCGCo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=labundy.com; Received: from SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) by BN6PR08MB3395.namprd08.prod.outlook.com (2603:10b6:405:66::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Sun, 26 Jun 2022 07:24:59 +0000 Received: from SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0]) by SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0%7]) with mapi id 15.20.5373.018; Sun, 26 Jun 2022 07:24:59 +0000 From: Jeff LaBundy To: dmitry.torokhov@gmail.com, robh+dt@kernel.org Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, Jeff LaBundy Subject: [PATCH v2 5/9] Input: iqs7222 - handle reset during ATI Date: Sun, 26 Jun 2022 02:24:08 -0500 Message-Id: <20220626072412.475211-6-jeff@labundy.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220626072412.475211-1-jeff@labundy.com> References: <20220626072412.475211-1-jeff@labundy.com> X-ClientProxiedBy: SN7PR04CA0064.namprd04.prod.outlook.com (2603:10b6:806:121::9) To SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c857dc8-14ca-4af1-7d8b-08da5744fa3e X-MS-TrafficTypeDiagnostic: BN6PR08MB3395:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 383JZX+aEPeKNfEpDjIufNVkK3s0cLZ9RWZhwRggyJan84rKjWbBoMMBRmHN76Wb2OroL5RrqzDx9KRJhCfQP8Wl0Gh8f8XuOEjv8oFXY+cnwD4CYS0lbtPxszBWph4sl7Tb2gfWdYrtmbCxBpFRa5XY/AGfVsJ+PapYF/p3NfLmnd90ajfbCwIMHaKF0Uz7whfsJAEEWTDN9TjqEgyluTEfHI3K/TNHd+XizO3iP6DbySljHj1cOIAXr4tSp6dgAndSqkaQ/RpHYgY3PFk2RQAyfudiYIb01iPUTd7qQNzLPjmMKZ7jLgSr2gVEtWjHLF7OjDtdcuq1uJNWCRqI8rANjwJfwGFwrY6AmE9GgQeyseKRgg9A5B88zQ5h5wfyVIUntIjIDWm320zlUGhzjwSH73InMBqGWOm0cWFh697jp6gf1NMvEPtBo5NYJm7LU9g9h0QsGVjkOQN+DPOz+ZHCN/q+ARcVkvsVWmDvKjilO5QaXtAb/OOBZAylBhNA4L5fntYRPPGYrhLlgS3bfWMbBhRkaD27E+ay+hsZqoiQ3hY0uFTqnQClio77xJ1am3hoam1a6z44Q0HFbCj4sKw4GLKyDuBwiW6OAf2mW1Lp69VzkWLFjXE8D6brbutzFXRshp7GfpRez2OmsuFhx3aS2iCipMTALVNBwhpkq0Aq8tRBUc6Fdb43JNZlC2bxGtCCGkzA/WBoNMrSaiWAdko5PaFt8CJGkuBk6eAFeFu9fGRHMMqBR4mx41JhfhRQ0lRUzBy9M/qo7mBaIqtwLvKRGobpEekR1+f2/ZuSMy4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN4PR0801MB3774.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(39830400003)(136003)(376002)(396003)(2906002)(107886003)(6506007)(8676002)(316002)(83380400001)(8936002)(86362001)(1076003)(36756003)(66946007)(186003)(6512007)(66556008)(38350700002)(2616005)(52116002)(26005)(38100700002)(41300700001)(478600001)(4326008)(66476007)(6666004)(6486002)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dkCvpwNevog0SEZjY88lXlp25UhGQGaMTLHawUF2hL5LQMsU4XiL2VWHzhZE3u6Us8okFyqu82y4vQeiKgaCqmnvHqeXQVzG52LivcHVBSdDErQ0V2ecbm9VAorpqCLTcMO6qabpee/EW3PhwuScXVyOwxHpumHER4+r9osnPcTpTsW24hNeN1j7SzEUuaaQjyiMS11IUvN6M+xEB+dlDlW105amJ+KkePB4/U9Jx4qokl1hHkHjitgS95qI1f834poVUbfLKAHccPtFfbjpFwke6/Ouv2ML+BJPYtgwWBoZcTMjDwKNlCCfzw5KdAPUG7RcaOiD41pntnSXuEtoHrjlXm9NUS6uBtxGDaldZ59ecToBqrs8WKbhcsUBcE0bRL8zJcXOC0BWEQZ2MKM6KziQ1yvY2+XCQBvSp45eyUTMv3qy9Ac2IBgODAFDpNkgg2x05GKM22bHu+AK71sC/3OvPvvF2RukzbGTSA7owTbr2lQuQSyvQHdQ6dqaUgLC6cdSVtkx/t1GAxz8O9pcKNeJPz8a133/KvTOCpWct5kJOGulDl3cRZgu6SbCKzz7UdvfYdOGEmlta8C7C26R2dl6WKXzg0ree2UJblMGJJ8GkbdjwWeV7KN5JfoaSAJbZgwnatluArdNGVVVmV7e7dua/4VHh/UOCJHeVBYkb71qf2iEstqQ42xieJZkaGZHpCkmgks+NYK2h4xcC/cd0Z3cDGg0o+cMVST0kKL+iveAKT9ybMeO4DOn3ufzTkNmNu84slTpI4pjARC+cNtltHVmvzbzsZqJ9+jxpB5WEvPTOH6oIfqr4MCmo1ozjeLSBczOUfqdD2eo8u6X11EzDLtAnPLDwl9RjphmZ+xdyLe/wXj3t2TLn0q7pOZD5M1LTg9hT2oCV3aaV8OwZNmUrl5tBPrjjWvNb6poGBDQCmVeTxVDvNIRHfJWIj3h4mFSq+f7LueUmfAd7bG+hwRImRVvKJY0aB5a6ZNnNt/t+FM4NXzpgyiyfSWCN5QtPit33lh++xR6/QuEa9nTLqKt+0/MlqwykIMBCVNp1ULF4cxXjYQvQC1MX1cBRJ20d0GtWlA6JsPJH04oCoyejV4l3ycdQSwPqSOQ69tdawWjD3YjpW2F7tGiZllZc6N32F9xwam7QgQFQlMgm3BclzZbUtdz6hApgXPx+Z0EIgjaX/4QJSd2BxOSHNafx77XgVJE0NTHxkVMIeM7iOYtimVHEHV73r3pPe/4seoQ5GsrvAjvzjjs0Hof3X+mSuQDTzHBChKfyCUXrlmqXkhcdr9sGLUlQXgY/7T+r6cjlGyuPuRrWrVmgERPTcyIQPADgGwGEkQPYGSK9pU41NCTpLlqL4QT87HnKtHOFkQALdC1A71e1XWIQ8518XTbywdi3rYSdx9NW3cfWpKxxMlFatXjXF+zRAHCz/2cNEeioOBgufR8WUjr/7cWTdLoe6PfcZ33CScypuFIJWIlYdTK9NaTcRNOLJm5HhCURTJVH86jdJko9ALh2rF5m9AdOuT81ou5eS9YhsM8pvFGSOJvKCD0WkpEqwP9GPBFKrk998/d0BtND2LUmFNyCD8QycKJGQkS X-OriginatorOrg: labundy.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c857dc8-14ca-4af1-7d8b-08da5744fa3e X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2022 07:24:59.5232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IQ9MIdX8t7XW+aRRngH32LY16+lz/3dYVG8XpNIH39DTK/4LTKe1umLUs8QlgZQw0IRPWZDa32F1doLPISMQ7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR08MB3395 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org If the device suffers a spurious reset during ATI, there is no point in enduring any further retries. Instead, simply return successfully from the polling loop. In this case, the interrupt handler will intervene and recognize the device has been reset. It then proceeds to initialize the device and trigger ATI once more. As part of this change, swap the order of status field evaluation to match that of the interrupt handler, and correct a nearby off-by-one error that causes an error message to suggest the final attempt will be retried. Fixes: e505edaedcb9 ("Input: add support for Azoteq IQS7222A/B/C") Signed-off-by: Jeff LaBundy --- Changes in v2: - None drivers/input/misc/iqs7222.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/input/misc/iqs7222.c b/drivers/input/misc/iqs7222.c index aa46f2cd4d34..e65260d290cc 100644 --- a/drivers/input/misc/iqs7222.c +++ b/drivers/input/misc/iqs7222.c @@ -1314,12 +1314,15 @@ static int iqs7222_ati_trigger(struct iqs7222_private *iqs7222) if (error) return error; - if (sys_status & IQS7222_SYS_STATUS_ATI_ACTIVE) - continue; + if (sys_status & IQS7222_SYS_STATUS_RESET) + return 0; if (sys_status & IQS7222_SYS_STATUS_ATI_ERROR) break; + if (sys_status & IQS7222_SYS_STATUS_ATI_ACTIVE) + continue; + /* * Use stream-in-touch mode if either slider reports * absolute position. @@ -1336,7 +1339,7 @@ static int iqs7222_ati_trigger(struct iqs7222_private *iqs7222) dev_err(&client->dev, "ATI attempt %d of %d failed with status 0x%02X, %s\n", i + 1, IQS7222_NUM_RETRIES, (u8)sys_status, - i < IQS7222_NUM_RETRIES ? "retrying..." : "stopping"); + i + 1 < IQS7222_NUM_RETRIES ? "retrying" : "stopping"); } return -ETIMEDOUT; From patchwork Sun Jun 26 07:24:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff LaBundy X-Patchwork-Id: 585161 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF134C433EF for ; Sun, 26 Jun 2022 07:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233729AbiFZHZL (ORCPT ); Sun, 26 Jun 2022 03:25:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbiFZHZL (ORCPT ); Sun, 26 Jun 2022 03:25:11 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2086.outbound.protection.outlook.com [40.107.223.86]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85E0B10571; Sun, 26 Jun 2022 00:25:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IRWsbCFpB+YZgQ8ydnMJl4BFTjywb+TzkI86UYmDmKHgjILWrK4XVKxP0KUEh9Uv/S06GI4/f0qdQ21sHnhKb7PmFkY4iHXBD1NhiII3qL8Ti4TlL+p/Rr/FpHjPQ7Po/NGZmBC58MBpafCPs5D/RQbaivbaxH0EAYCoeArmo1fafcUQfHOwcvKIA6KnbRh/OqohRL0AV3NMKjR9BUMBakN2c9kJjtLJVkSevCwgz43+NrqC2rZZ8BpjwEeircWtXYU6n1yG+G6fwiQa0WksAp3VYrvR6R/iPNizl5y/PtD0CzOGvTk7nVCGQcuxrv3vpZM5CTFauGHCyP9tMmnFPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0yEO2tv9Qnc/HOdokOfbKt5AHyiMu94qjGUCc6e7w4M=; b=DwIc/NT1Ne3U8mFEbxWlst5pdpeaIwjCehojax7tLeHdieikEuG7C1Ygmdr11S0QPAcqtr1Md2+pCOzMI/9RMM+oR9pZgefLB2ZDjyzym4lsfMIO1cSy/4jBYQDDWjtM46qt1XUOuW5Wlpdcg2DTXoknFU00yWfpWUB+Oh22ylK/FQPEJr6MNacdR6XKYDU5nFp4Xdpulq0bGxk65JV+6a2RlPg+a0cWI+RYRrG+jA1sz3yBdpmi+Sb5ALJFKGnzzijNHKGwfNZGAJviIn1Q8PkSARb/8JXAo+aqVK9yKRQxf9Ihe2UQL45O4NYEDrSu3ls/8VkTnSyfoBSVBCxJ8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labundy.com; dmarc=pass action=none header.from=labundy.com; dkim=pass header.d=labundy.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORG5796793.onmicrosoft.com; s=selector1-NETORG5796793-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0yEO2tv9Qnc/HOdokOfbKt5AHyiMu94qjGUCc6e7w4M=; b=wsJZ/80YQvhJi+KRNEwWD3c3lEwCCAgNr/MNvyxSe4ww3CBJ80O1eupHsT8xqQKY4CsqJUxKFXynfDKt572sAFwzObiZfQhDPXlJhcwwkAoSOfVtXr+Ueq5a+fYI9R5Bw9addfCKdi8imluM2u8fj+xfwPqUMYJY361Y71vwG6U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=labundy.com; Received: from SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) by BN6PR08MB3395.namprd08.prod.outlook.com (2603:10b6:405:66::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Sun, 26 Jun 2022 07:25:09 +0000 Received: from SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0]) by SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0%7]) with mapi id 15.20.5373.018; Sun, 26 Jun 2022 07:25:09 +0000 From: Jeff LaBundy To: dmitry.torokhov@gmail.com, robh+dt@kernel.org Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, Jeff LaBundy Subject: [PATCH v2 7/9] dt-bindings: input: iqs7222: Remove support for RF filter Date: Sun, 26 Jun 2022 02:24:10 -0500 Message-Id: <20220626072412.475211-8-jeff@labundy.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220626072412.475211-1-jeff@labundy.com> References: <20220626072412.475211-1-jeff@labundy.com> X-ClientProxiedBy: SN7PR04CA0064.namprd04.prod.outlook.com (2603:10b6:806:121::9) To SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a15a7aae-440b-45b6-7b3a-08da5744fff1 X-MS-TrafficTypeDiagnostic: BN6PR08MB3395:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XvBWA+zztqUKO0C+HT2dkmfFFObQQR5oLk0t1wDgHyhpBFHNpYH1jQyYQ9pH+DFFMhjLn9qP0qDNQYoJA8/01VGQsf5OEF7AJr+7tSyP6d71we2/Q34wQ0epqKrvUOnPt6bpc6tyAd6KGmXk142vN7iXQUe9OJFtSKBKiCI2aphOrjCtHaKjoeSogAkXs27eOQo5TwZ25Cu5rZ03eS4OBiLmu/BOPMIhavFogUudwbeFJgiVv23XZL/5v9mju5DJirYiKcqUD/nIGBX2BP5s54vUa3r2I7yTH4Y7pX0+I8FYQ0eEvQCqchkWjx81wnt5wGd4/pcVwklLSZhAjSs4y7uZykLOczB0RtuihheF3H5VRmz+qgewb/b584KOZ62O5r1wJsEPjQkV2LNT9MQ/A3N1F1hSBDbWASzn4S5X5VYwF8Qi0a1BLBauAciKU+2YF84mTq84NgNG1ZjuXGzNg+1tn6Y7Ps8KPROlumoUuGvhv0fq+m+vBG1DMbC/n2PEk0Y8nS09PF6xGX6EClevzKEdG5sgKjRatBeCOPlzZMxdj2dHhUR1ySstZBn64ddzU9aP03Y0Jv+aavXmMbpMufdNAd4+m1Tezpu6PjCBg652MdCGRs+TqYtITiBaZzMjMYZFBQ4T6gXleZCFoVBYDVPnS2r5J7Tk7h5L0xATRJMcluCehYzruJy/UTWEfE80N2NIq9QZQVY5p5QM13j1EX8FzCdgVb+zRR2l3wgo8CY/+ik5Pr1orUzU876xqm2fV+tQ7bXzq5xut5cLcoeWKstk2gaq2dpnHbw5xfnKTP0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN4PR0801MB3774.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(39830400003)(136003)(376002)(396003)(2906002)(107886003)(6506007)(8676002)(316002)(83380400001)(8936002)(86362001)(1076003)(36756003)(66946007)(186003)(6512007)(66556008)(38350700002)(2616005)(52116002)(26005)(38100700002)(41300700001)(478600001)(4326008)(66476007)(6666004)(6486002)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5Ivit22lXmSLfdKl3yvMChIWdz1TTFc8b4yu11p9RchvvfNJH3FODtBaST0WoyJq+gfgfOddv7YYsiSTiCuMwIUanSkX1BFBahRmyqOKfaTwC8DGy3QYnLZWNUpMISsfJtP9jA3OLVt0JgxrlqEgcJ2uEF/hVzr8jo5ZnD92e+r7LfEMwJt++w+NUT1SHg126BjYUyXWxYkvju0zin9tnuBhV/+Zmep2u4m2NFWacG41+egdHPwI6QK74r9OZB3UMIvOcl4X/jh0IoT6ljko+Ie08PK8wv18q6OJkUS2NayxJLdNyNyXnvZLTK68X5VKyTn8+8xRERuLuaOW8f17HVYpRcIpNnaNvYHuYNy9nxIV4ARMH1u96pURYiDkpop4Gsbfr8vppnyhS5P90dK5756tjXQP0xIG3x0XjzYUsJhv1w7swQL5Ony5ZFT7jYAJhpplRccBg18DpDcoUUw7RfUgm0Iv/LmnuDsLMre9u9uio+sUJQ9u/3nBi+qTS9WXm0DUDAjUDLe3xfkNDE5ohBx1jG6kMpWbIsIboTvTAdlKEEsLKnoZWPeXNzhRqcIobfmWzeUAN5KQs9WrAU4cGEXMsjeDMJ3Y7Teu7rG8f+DVKt8atzjnz5h3LP2NCCYNDwTPQvASo+fVdJddSySs1AThhdddbWouseZf/7wb5rQYNVxpbXm7xMlB0Ged472TQrvw4h6l/rNNDoRkBwfkKMIpRvNuOuWkhERrRF6svuWOrgxA9JaYZIEHfqMe4OPJ7e2eAQyybSdkSGuw3jwPJhAR2o/YyEvCbq7LXEo7XXgUHb+O8eSM/iZxTdVllxywUDlUjaeTfFaRrr5I3kCoT6zbtoFCTrQIzcQJeUHz8mA66braCdfgjw+Un7/0s8SarWIUtOQpLg6YhV0NXUbGfscYdu7G1kMdQHivtuTtowXENgGZD7njSf9QLG+pWUP2VvQLDqIPKeYx8Aan7QLdwoVXBDB4paciCWlBM/mufbBC5KqvfhoczYDGTVI/9hjv+l5WHzO/4JRbYxByjCZw1vlPdlNTHLuDqGsg2tilxHFJGP5eVGcgDmrEz1LflZ/OKfgYPZ0QfXgL4fs+1TSpoMlx0Clt0D8YUgmNtxJyvaENkAe/oPu2DoVX0V50oIOBUaZpTK6bVN+BoZ/ZshknE+mHcmRROKgp0ucfkMLf35DknuLlo3/N5qk34oQtpvL9jKW+1stZ9P2qnvxcGchZZUmz8DzXXtUOqddQDY4i49D9KOKXCFgtKEqiL065PC2IJNpm2wb8Vr7yxJnjB/+P9dvM7PfQtCKAiCf35m/GGZnzFoN4EjfkD8PZ+uZM2hVOcs5SJl178VteqpqkPijN9A+FAlw4BwX06RV/6vpBg+UpMEKXkhulZLqBqZS31augPr1X4gpp7LI0zY6c6Lkauyt4/x2oW1i4L9gs7UVjTu4wVPYckT6x/QW6roQjzygWEu50A0z4S87AUArADMszltfn+AOXkCWape4g0XHx3kl9A5r7mZWP/1QHBxf/S7y7kOnkz2cCKMDHH4LIVZSeaAssAiPwkOIWF8lyfJRv81LRUOXfLbsEx0vtRzImHkEu X-OriginatorOrg: labundy.com X-MS-Exchange-CrossTenant-Network-Message-Id: a15a7aae-440b-45b6-7b3a-08da5744fff1 X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2022 07:25:09.1004 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FYiWh2bGptwHWKrD3wQDrvu+CLE2snNaC30x19IWFX4wqOKQRk7dX4haHLRmZpngmWaR6UvMcXI/VLNDZG1iRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR08MB3395 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The vendor has marked the RF filter enable control as reserved in the datasheet; remove it from the binding. Fixes: 44dc42d254bf ("dt-bindings: input: Add bindings for Azoteq IQS7222A/B/C") Signed-off-by: Jeff LaBundy --- Changes in v2: - Clarified commit message Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml b/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml index a3a1e5a65306..6180f7ee2284 100644 --- a/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml +++ b/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml @@ -37,10 +37,6 @@ properties: device is temporarily held in hardware reset prior to initialization if this property is present. - azoteq,rf-filt-enable: - type: boolean - description: Enables the device's internal RF filter. - azoteq,max-counts: $ref: /schemas/types.yaml#/definitions/uint32 enum: [0, 1, 2, 3] From patchwork Sun Jun 26 07:24:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff LaBundy X-Patchwork-Id: 585160 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6551C433EF for ; Sun, 26 Jun 2022 07:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233883AbiFZHZV (ORCPT ); Sun, 26 Jun 2022 03:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233862AbiFZHZU (ORCPT ); Sun, 26 Jun 2022 03:25:20 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2084.outbound.protection.outlook.com [40.107.223.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 343DD10571; Sun, 26 Jun 2022 00:25:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kU+5bsrudE4A/Tcp1HOKy3nolxqFMIicbAdTraPM52AYr2nzkNjx07nfMf1EGrR0FrSUVjHqU6HPEVMu1JCno+DkyEiAErVcmLVyUdYISRKmAxYa6vdCGB3jRkIrdwqUfZAX+3QeVk9+iamJ+4jtNyvurFFbC8VkWhLUiSmjLAoSKBLewNGYkgYLnP87Kjn8jWJ9O+0imYKVZxeDXoUtZp2FrONZoxrcqbr2G4rT3/mP3bR+qlVuS/uwWri6Klzzy+Ftmzg059JgA+x1BxcP31gZ9vj4WCjxZ9/ihlmrS7zOSq9NwSLKH3aggZJhqL6LfSrlKaqbBCAYQ4HHoFwVCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=00rFrVl0swFH6LEceOTJflMyK5slsclyhzfM8VT91+0=; b=MrRGj1XheUE+1lUvkAWXtnsm4nGH/NNxg1+Y/N4kkmALVV/nWF6Ryto7yRw1cZKyAnWr/tWIzyywmoxLdpHzvI3Pb3vbcH75Cy3XVnUcLpqLmeTesP3/NxGwIuLkd3DvFOiOPAmzF3Tpe9Pj8DIj3l0uxIW0jjvEt9GtQaHvfAmv8lmxZcfUoZ6PcipZ+DE6FV+iRfCcizGg7xe5tzbPYnMTtXRPnVlX9wvrH79PlyCCosoSyu2axccGVNlpuYjJsjZJgEcZcwhcB2i4Tl1lWyCMegA+I0kkhwW8M9Sg/98bXjwJouUEL/AOfiKnrGYr/NZ7xD8e9sdzz7J/2oXDHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labundy.com; dmarc=pass action=none header.from=labundy.com; dkim=pass header.d=labundy.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORG5796793.onmicrosoft.com; s=selector1-NETORG5796793-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=00rFrVl0swFH6LEceOTJflMyK5slsclyhzfM8VT91+0=; b=P3L/Vd1QBeWiNFUQChLO74uDCCfa7XbpHplQsjZLw9HqIxZ/ke3ROijklULCblha77YNVMwkEIARA93pe9WAFwDAqRdYrqmKsAbotf3ya7x6ZTKwjUO9nf7tnEaoE9DOTdjIrFzvd37zeeHXfjXZrGLshDNkEIn0lFUteWETnt8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=labundy.com; Received: from SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) by BN6PR08MB3395.namprd08.prod.outlook.com (2603:10b6:405:66::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Sun, 26 Jun 2022 07:25:17 +0000 Received: from SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0]) by SN4PR0801MB3774.namprd08.prod.outlook.com ([fe80::2c67:a29a:4e8c:3ac0%7]) with mapi id 15.20.5373.018; Sun, 26 Jun 2022 07:25:17 +0000 From: Jeff LaBundy To: dmitry.torokhov@gmail.com, robh+dt@kernel.org Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, Jeff LaBundy Subject: [PATCH v2 9/9] dt-bindings: input: iqs7222: Extend slider-mapped GPIO to IQS7222C Date: Sun, 26 Jun 2022 02:24:12 -0500 Message-Id: <20220626072412.475211-10-jeff@labundy.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220626072412.475211-1-jeff@labundy.com> References: <20220626072412.475211-1-jeff@labundy.com> X-ClientProxiedBy: SN7PR04CA0064.namprd04.prod.outlook.com (2603:10b6:806:121::9) To SN4PR0801MB3774.namprd08.prod.outlook.com (2603:10b6:803:43::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20b4c25a-1d72-450a-5ab3-08da57450521 X-MS-TrafficTypeDiagnostic: BN6PR08MB3395:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DST51h/BjgHkbMay1bYmOLoLXUUQKq6gs+2HeqOScAv+1Kh29yo4plicRyejk8G7hoS3EyUp0a9WIhHAYDgZ7BdF2U7a2KaBhwWKYeq1bbh+M8/LjYymG/GK5x0PWXz0Sozb3SCmssEln895wbTDebFa2TtYbHHhKjDX1KtwxFm7kfgL0g6KE2GXJWQKTuhhOKB4Kh626m3v1miOr0ROpl+KSdzUi0Avtxcatu3GMWP4Nz7jp+scygfhJY1yRc+azwbIUMVV1kiJRp7ytK5HcJFxOsl51lnBLpKVOBzhPo6hIxxROJ8kMAYiTEClEw6J3gq17gDXJS6LDKKKQmwbDXKmg4KTZYebnaug5++zAMpqOqznD3xsgoo7XZuTYSZN+s/ILJrDffNadj6xfHeW74Fki3EGtBEHhHm8hdUCvwIMtxuhZ+U1PC5d9ZdA+qsSswdViYbbecH4xnkseyyDa1TYVSpmQ+WO4+fcteUdl3/38wfx7eNoMt6JNzjDNQxP0uXdJrhoG/3HqvHTShSoXwnWIChgtv3AJ6WXOQ5Y2cd/oyZcAUXKvWBFIfTUgfAwXjfuklNJOb2QblfOt1cCHi8jjG4ZQsZH2jrtN+KfjV4OcAyb04AcfUVF8hZlBNrcrT8VlAsZorktrVvroT//x/RfzAUOed0U3Ms/Y+BPMbvI16nOXZ1lRVavm5Mkd3O9cqJ7SDcRkDwkG8mnuVE40JlBm/+qBPCZvkfe4VGcmKC3qUvekpLNW6MaCsTYMb0Mto/7N4GZ3zHT8kNbYkSPuhUX32pH9iSN4ifWj8lE7Is= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN4PR0801MB3774.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(39830400003)(136003)(376002)(396003)(2906002)(107886003)(6506007)(8676002)(316002)(83380400001)(8936002)(86362001)(1076003)(36756003)(66946007)(186003)(6512007)(66556008)(38350700002)(2616005)(52116002)(26005)(38100700002)(41300700001)(478600001)(4326008)(66476007)(6666004)(6486002)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Abes1QiCI2cdaWLS56kb5tiCq8AvUQzhLMVyP3V4tE3LZ+QlIs+ljAAyT/v0n194Fc7vu2mA7VloJT6dVNx6fVLiVXCUBSGtuPMV2l86tHFZ+H5KKenGABamDFDD4w9YCnFxFKzXDZ5pooc0M0o1vHgHNptxlak1wasasH2jTNLlJ4SwU6ACe3ADxwk2JEsidDR5qeLk/+ml87T6KgbRnSAgn9KW2Q2+NOlQ3wZEc0ip/2FGx8RR2pW0GSutNZoRbhlyaOaSp6+V6/l5JoTUnZGTSSTsPIbLXUZiC3C06XksaeBhOSurUct1yw3eCqCHQGNelRgAt6Z2ARsAM9fSfWsOYLLnIPyPJ/juGIikU2WzizLxeaxO+A84r6748Lib2T5Lx2RAdsuOVo5Mv5UWs55XbM0Lb3aFCB7Kkp5tXFy2opSKa/4HGF9peFDw8bqBDS++FJPcMM6DVyJW+cyXfqGezWzDxyIyM+zSg/prjPS2apDNLUknLJOVQ03XxlsETjkcfFy7Kdf2FZuyJjd/eN5o1gzj5OhIaeNqZZYIcaH5lvnt++KVTBtzo+vUvScL+DhvjSeTLE6Sw3eaGhoBFXf9Sktanu6lDIWpij9Whh6VMCE1DHbMmq342kN//77Xu8TSPCZ55albl2vFI3YjT1FXJwYZ66pKbeZ42z+fX/pEaVRejyXOwt4V4FnzFvFDLKTTQ20ivk/s1AVo5XcWv88zsGVsp7/5kmJxfJ4bb3zls0pjVGU6l12zyz3GKxaM4wMrMNXaayjdMfB1vjoqbz6RYJFjth8LPA0jjnrZCROQCJXUV0e1n24jc617m+TB9gClhvvYu2hnLWyD8Fj9441i00UQXyOFAPGrODJoYD8HC/9lG/qhyKuz/THJFkvYSKCUNl9CqE/qidmVrEoNqwhzQH3NWIwphrspPODOilVPMEx++AIyilKo31fj1tZP3EOEJuGDVoUQxNUnJ+uUMDdYEiZpwotECvxCpxshkhHMQdS6LIGe8g5BEp7DOT1U24lGgtoAE+J1GcRXaqzdNpBH4Ee5amQ5QVHsqKuRsj4F4TpKMKbwDDlolwvgvOsNvFu/aDEzhnb9tl3uX2Nm6FA7RW1ZGeQ3xGexnIseoPPyd817dAIugBAR1enD1q4mpiSiun+lfttZRVSL85XgF9JfOSQjjZCdepBOb2vIBA5FchjW0m1UGyNb9Lua51Y4H4Khse7/SIrtLcHWVKWaHHtrF/VH16baoN3RfUU0Pek2QeFqOxLS1weS6YFv/9vdtDxTR3SpRbV1Z22GKj6LHBIqIBIAEH53+CulFLZOUxH0QA3kb5Diqu0a9ge7jJFmaOJVEgsXQ6vjbVTNbwawZVFD5pCt0Cchdch/382vzMjhUmtkhWUEwDY9zykVXDy73kYfMXp235J3WyRV31cVNX/GIinVKRPWU8/lVt3OGMETem7Lw2BVjND8vw5FJAzZfo0tA2RY5GGsgXozk5yvlOHIbNKrwXmM+vhIX3C8SW46F0SrwLC82tpPrddlW/e323Dlh3Lc83BUend6llH6dKSoCXPxIm1wy2XRJry801tlEux81rgXZjpmmjDeD8PR X-OriginatorOrg: labundy.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20b4c25a-1d72-450a-5ab3-08da57450521 X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2022 07:25:17.7872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iT4Rgzlk6SIZeVQXZKJLieFbqyf4fvMB20VqhWEd2IaT3QDVr7x110GJYURV6NxBihrPekS822nFU9B+pET4EQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR08MB3395 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Although the IQS7222C does not offer slider gesture support, the press/release event can still be mapped to any of the IQS7222C's three GPIO pins. Update the binding to reflect this relationship. Fixes: 44dc42d254bf ("dt-bindings: input: Add bindings for Azoteq IQS7222A/B/C") Signed-off-by: Jeff LaBundy --- Changes in v2: - Added to series .../bindings/input/azoteq,iqs7222.yaml | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml b/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml index c9c3a1e9bcae..32d0d5190334 100644 --- a/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml +++ b/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml @@ -611,16 +611,15 @@ patternProperties: azoteq,gpio-select: $ref: /schemas/types.yaml#/definitions/uint32-array minItems: 1 - maxItems: 1 + maxItems: 3 items: minimum: 0 - maximum: 0 + maximum: 2 description: | - Specifies an individual GPIO mapped to a tap, swipe or flick - gesture as follows: + Specifies one or more GPIO mapped to the event as follows: 0: GPIO0 - 1: GPIO3 (reserved) - 2: GPIO4 (reserved) + 1: GPIO3 (IQS7222C only) + 2: GPIO4 (IQS7222C only) Note that although multiple events can be mapped to a single GPIO, they must all be of the same type (proximity, touch or @@ -705,6 +704,14 @@ allOf: multipleOf: 4 maximum: 1020 + patternProperties: + "^event-(press|tap|(swipe|flick)-(pos|neg))$": + properties: + azoteq,gpio-select: + maxItems: 1 + items: + maximum: 0 + else: patternProperties: "^channel-([0-9]|1[0-9])$": @@ -721,8 +728,6 @@ allOf: azoteq,gesture-dist: false - azoteq,gpio-select: false - required: - compatible - reg