From patchwork Sat Jul 2 23:12:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 586960 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0226CCA47B for ; Sat, 2 Jul 2022 23:12:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230408AbiGBXMp (ORCPT ); Sat, 2 Jul 2022 19:12:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230405AbiGBXMo (ORCPT ); Sat, 2 Jul 2022 19:12:44 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD282BC21; Sat, 2 Jul 2022 16:12:42 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id z19so7116207edb.11; Sat, 02 Jul 2022 16:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=id5EAPhh+vCKRnSjZnH7hfilYjwKLu84ggjPXCm1/G8=; b=nqQ/bOLiokYQHiRMikb/oKWZA7po0z9WQaPyd7gHXSxKhnxKZwj5pbqWmmi5WyvTWa JuR1x9lISJwH6sX5265PcrMon9Q3RYmteK+hoS7l1kUAEfRzgVSxDTv3/pOzIlBYSq7k PGHHW4RUdqtYE2ai9jd6BZDX/KqtibFqeoVQQKTgUwey/+YSzfCxmD6rin3sgPo96oIV HFx06479WhIXrdj5ca2y2fQigIs2mDzb9r7nrrdu6kY3UCYKgIkR6hWrMAjbBxkzg4Ea oKKliTVTmdIjEfJUHBXWXNOJce+hSmqEYLkX89cFmcbdHmjVZPAi6NYZALT4lpnRYp4Q rKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=id5EAPhh+vCKRnSjZnH7hfilYjwKLu84ggjPXCm1/G8=; b=RB0EmUHyBKhUVUmNT3B4mRT7tpxVKl3yDVe4a/ItmDDQHBC7KQZKarx4b91d6dBHOG Vcc1zT+U8nf5mIMB4L99DdpMzVOdP2p2yw+PgdipgLjK7Qtg9SVzqaRvZjSZooUz9++U lKveddggysfftaKix7Gs46BCtXhIQFalLq5bxQUCtPAIJq0Vl7xTA40rQXffcMIdI0Ct 6qaFtj5rMGOrVKZRx6Mu7G9DPbpDLpKlnhzd8YR1TWR2EdcywLVsnZBNUj22whOL8Ttn G6QyROW29cy3YjtiXr5+5ozSc/QHbqWpfsY/xHAsuu5AR9zHtCQukLknLN6UIZckGpCG 4A3A== X-Gm-Message-State: AJIora97/yAqOBAqFi/1m04XF4X2qrxs3Kl487gONNrVcZeNcJ4RChDJ WZaS0g+ufwgs1a+3Rz+QS34= X-Google-Smtp-Source: AGRyM1s+PfHINkPK2o4Y9IrDNSoTxUsuRjB6Y56Vre6odL3SEEJp4RM55pYz5yPKUY9OP6eBFSY1pw== X-Received: by 2002:a05:6402:1e88:b0:435:bf05:f0f with SMTP id f8-20020a0564021e8800b00435bf050f0fmr28367231edf.2.1656803561139; Sat, 02 Jul 2022 16:12:41 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a01-0c23-c4d4-2700-f22f-74ff-fe21-0725.c23.pool.telefonica.de. [2a01:c23:c4d4:2700:f22f:74ff:fe21:725]) by smtp.googlemail.com with ESMTPSA id uz12-20020a170907118c00b00711aed17047sm12234329ejb.28.2022.07.02.16.12.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 16:12:40 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH v3 1/8] dt-bindings: mtd: intel: lgm-nand: Fix compatible string Date: Sun, 3 Jul 2022 01:12:20 +0200 Message-Id: <20220702231227.1579176-2-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> References: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The driver which was added at the same time as the dt-bindings uses the compatible string "intel,lgm-ebunand". Use the same compatible string also in the dt-bindings and rename the bindings file accordingly. Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- .../mtd/{intel,lgm-nand.yaml => intel,lgm-ebunand.yaml} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) rename Documentation/devicetree/bindings/mtd/{intel,lgm-nand.yaml => intel,lgm-ebunand.yaml} (92%) diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml similarity index 92% rename from Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml rename to Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml index 30e0c66ab0eb..763ee3e1faf3 100644 --- a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/mtd/intel,lgm-nand.yaml# +$id: http://devicetree.org/schemas/mtd/intel,lgm-ebunand.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: Intel LGM SoC NAND Controller Device Tree Bindings @@ -14,7 +14,7 @@ maintainers: properties: compatible: - const: intel,lgm-nand + const: intel,lgm-ebunand reg: maxItems: 6 @@ -75,7 +75,7 @@ additionalProperties: false examples: - | nand-controller@e0f00000 { - compatible = "intel,lgm-nand"; + compatible = "intel,lgm-ebunand"; reg = <0xe0f00000 0x100>, <0xe1000000 0x300>, <0xe1400000 0x8000>, From patchwork Sat Jul 2 23:12:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 586959 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ACCBCCA47B for ; Sat, 2 Jul 2022 23:12:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229596AbiGBXMs (ORCPT ); Sat, 2 Jul 2022 19:12:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbiGBXMp (ORCPT ); Sat, 2 Jul 2022 19:12:45 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 674F6BC1A; Sat, 2 Jul 2022 16:12:43 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id h23so10244920ejj.12; Sat, 02 Jul 2022 16:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jtcfJDlBtIQgsJctsItB2jzUjAIsrPcb5sLRSibvewY=; b=qed6BExX6r9RFcO7N/YaPXvv0CuF4LZlMKFRZXUeWaKTX/oo0mMQ0CtWdqXxVK/Pe8 tSmMt0syPx0daH/cypM0v17Kii6YdnDYYxAbqphyO7eHeuVf2CwcCNdXT+jIeKK5v/KG gI2C/gfRJmZ09ZKXZE4nK0Kr8eAteRL76xpgvq1HTQxuKUFR7ZTTnwiou1W49TV2xFrQ aVJr8Qdl4HOoixPdSH1HSkHp+qhQdFiLuF9ZUYnnoh7YtC+j7Oti5EtFatHJrSyvhYnQ 2L1ybUFJu2Y1KPwc3yfmnkGKC4LiyZO2YCD7imITIa8sdgVNjI92w+oFjLPSnVTJj+qW Bo+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jtcfJDlBtIQgsJctsItB2jzUjAIsrPcb5sLRSibvewY=; b=VJVrQkkhzyPPeMOsb1CcLPvSiEJVBqfFXtQgBNvJxHWY0WyUckO32NnbFlmWVViZz2 qGooCIaONS5fC5Qb8cjRn7St+S/e18gNPIM2wBECrNELxdJFRhk5ri6I5UUBs6BtVcWT 2F8akYytf0gQ6HU2yRaOz9vzLZrc2EeK4jTk4HVqr+A9Ll2MNR5qxwEb2pFGgH05AaLf VB6FTKuPbXo6vBAXtajztd04ZJOOeI0+18+LMGusKl5WMWY9Z6vQSX1g8BNfWJkZFJ2B NtvWX9QEXlWZD+hp1PhdRK4A7rtYnFzClzIP6eds+FLJDH8CQrFwYE/z0ybFigmBhpvv JnCQ== X-Gm-Message-State: AJIora+K7zD0HP1Jjt5b9lF+WFsniNJI85g9yX/6yZPYN49EmZN6lJ5/ hjWs/xRY9ia/eU7vdrFspnU= X-Google-Smtp-Source: AGRyM1uPubQUBkUKfCj6Pab0PNni4xlv9AST3IHTvB/EK4KaVO/XfMVh/qyaIxTVFiFgUYRv+RmQCw== X-Received: by 2002:a17:907:608b:b0:722:f954:6e3 with SMTP id ht11-20020a170907608b00b00722f95406e3mr21619271ejc.550.1656803561997; Sat, 02 Jul 2022 16:12:41 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a01-0c23-c4d4-2700-f22f-74ff-fe21-0725.c23.pool.telefonica.de. [2a01:c23:c4d4:2700:f22f:74ff:fe21:725]) by smtp.googlemail.com with ESMTPSA id uz12-20020a170907118c00b00711aed17047sm12234329ejb.28.2022.07.02.16.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 16:12:41 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl , Rob Herring Subject: [PATCH v3 2/8] dt-bindings: mtd: intel: lgm-nand: Fix maximum chip select value Date: Sun, 3 Jul 2022 01:12:21 +0200 Message-Id: <20220702231227.1579176-3-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> References: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Intel LGM NAND IP only supports two chip selects: There's only two CS and ADDR_SEL register sets. Fix the maximum allowed chip select value according to the dt-bindings. Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC") Acked-by: Rob Herring Signed-off-by: Martin Blumenstingl --- Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml index 763ee3e1faf3..04f26196c4c1 100644 --- a/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml @@ -51,7 +51,7 @@ patternProperties: properties: reg: minimum: 0 - maximum: 7 + maximum: 1 nand-ecc-mode: true From patchwork Sat Jul 2 23:12:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 586664 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75253C43334 for ; Sat, 2 Jul 2022 23:12:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230231AbiGBXMq (ORCPT ); Sat, 2 Jul 2022 19:12:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiGBXMp (ORCPT ); Sat, 2 Jul 2022 19:12:45 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7687BBC27; Sat, 2 Jul 2022 16:12:44 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id c65so7154455edf.4; Sat, 02 Jul 2022 16:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yCQTaNx44e60e0RQIQkoEDKE0jArPjhRbsgoDMKp9c8=; b=dgxlSIjFJwSCBjcvyW+PrWZomTklrALAUl2SxmBCl2+hC6/UnRF5C/QTl3DI+XlaVm zPO8X3hufGMWdx72k5+9W8OKCvBdvH9sJi62Lzdwy1jCQ7DwQFh/WtXIhbtDXFnP9DF3 n+xyF3SF1GEjaCY5YFD4IqX8XYShGmQ1AP1p/mxjajLRY0pMb941kFcCysS76Nv/vosM Y+1pJzmWG6ZcEky7XuMSGEC9onUjyVQF57dI7uMF/+4W9DNHFjHZZ3esF62Jw1IBV1I3 8Ihy3m3EuL2VX4CoUBd3zbxYNfVrTfaHzHIlvmn1KYV702KpO0NM4K51sbBbVJVeNEM2 +tPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yCQTaNx44e60e0RQIQkoEDKE0jArPjhRbsgoDMKp9c8=; b=5aA9tfu7WEa7htXVwxerbBfW2njDbykYycRjz6WA5vmxx4qe7gCL7sca9AnXkgL6U8 bvmvetaURretUpdvh+B8wJ5LoaD4R4CKeHPwi1nD2ntIh7/9mCcr9O9/37LfTNlxflBh y9GBnlVlj+b4zVDbK95VjRzkT/aOhg/IgFRgqxJ25ZYg15DupO2cT7OpNqso5CNIzjww 54HQKbVJI0UO80rkxrcepbm0R3IMZwuUtgqNk75n2C508lFqaRLUskuALXCJW51tBLNJ PbTyZLDzlqVaHiM7g54M6d+EyB4Y2tTJYBZTu/zX+PqXIfJA408CSmozwrGxuwsrH1a+ e3Gw== X-Gm-Message-State: AJIora/G3hXqnjOmnyDUy4pg6UZoOKZ/p82Nup7JyD/vcZU65OMDjsZ6 pFYy5xqD4gI9k/cCOSXStkM= X-Google-Smtp-Source: AGRyM1sKu0kp3FtCCbBKNYht3OJTpZgRKfuJVirFs6MCvvcbODpijjhQI7TKv9HNwbq7BMmmy6Kzag== X-Received: by 2002:aa7:c9cf:0:b0:435:de3b:c499 with SMTP id i15-20020aa7c9cf000000b00435de3bc499mr27700806edt.321.1656803562966; Sat, 02 Jul 2022 16:12:42 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a01-0c23-c4d4-2700-f22f-74ff-fe21-0725.c23.pool.telefonica.de. [2a01:c23:c4d4:2700:f22f:74ff:fe21:725]) by smtp.googlemail.com with ESMTPSA id uz12-20020a170907118c00b00711aed17047sm12234329ejb.28.2022.07.02.16.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 16:12:42 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH v3 3/8] mtd: rawnand: intel: Read the chip-select line from the correct OF node Date: Sun, 3 Jul 2022 01:12:22 +0200 Message-Id: <20220702231227.1579176-4-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> References: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The chip select has to be read from the flash node which is a child node of the NAND controller. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index e91b879b32bd..3df3f32423f9 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -16,6 +16,7 @@ #include #include +#include #include #include #include @@ -580,6 +581,7 @@ static int ebu_nand_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct ebu_nand_controller *ebu_host; + struct device_node *chip_np; struct nand_chip *nand; struct mtd_info *mtd; struct resource *res; @@ -604,7 +606,12 @@ static int ebu_nand_probe(struct platform_device *pdev) if (IS_ERR(ebu_host->hsnand)) return PTR_ERR(ebu_host->hsnand); - ret = device_property_read_u32(dev, "reg", &cs); + chip_np = of_get_next_child(dev->of_node, NULL); + if (!chip_np) + return dev_err_probe(dev, -EINVAL, + "Could not find child node for the NAND chip\n"); + + ret = of_property_read_u32(chip_np, "reg", &cs); if (ret) { dev_err(dev, "failed to get chip select: %d\n", ret); return ret; @@ -660,7 +667,7 @@ static int ebu_nand_probe(struct platform_device *pdev) writel(ebu_host->cs[cs].addr_sel | EBU_ADDR_MASK(5) | EBU_ADDR_SEL_REGEN, ebu_host->ebu + EBU_ADDR_SEL(cs)); - nand_set_flash_node(&ebu_host->chip, dev->of_node); + nand_set_flash_node(&ebu_host->chip, chip_np); mtd = nand_to_mtd(&ebu_host->chip); if (!mtd->name) { From patchwork Sat Jul 2 23:12:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 586663 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CEA4C433EF for ; Sat, 2 Jul 2022 23:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230463AbiGBXMy (ORCPT ); Sat, 2 Jul 2022 19:12:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbiGBXMq (ORCPT ); Sat, 2 Jul 2022 19:12:46 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 461FBBC21; Sat, 2 Jul 2022 16:12:45 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id z41so7188707ede.1; Sat, 02 Jul 2022 16:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DTaZ/9+DRnLhDSj0DOV2C+IIhpHfbKqhWacVmkOB7BY=; b=WAh2tNKM0lRNF8UUHv4MaNqhtwRvQubb5330+ZE3Y2mae4IDnvy7linhak+uRdzDuL fCnOAUVX4274xrZMmLilupQ2Z1rmJFGjBYLiBQuiV9sbuW+yfo2nF+9jAAxwZXGyXUiQ mGhlewzANw11TbAAokn2DtuU28zUdub/OmqISYRxdUQf6mqAhq+SYB95psXCfnNz2VE7 4Tyts//6DcsvsM8fyorliVDkfQeEi5iRyVm6igDR6m4vjEA3BeXscWuVYmO7FPmZ+vez b23iT/69ltBEHcXQWzut2ARq0z9pXxhcECQ/3Fn6s+6qdba7bMl67X5ssgJdadDriehm g9yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DTaZ/9+DRnLhDSj0DOV2C+IIhpHfbKqhWacVmkOB7BY=; b=7rdLGvY1LrX+ja1b/hJfI9mjrJIRiP2ZpHvySqXD4tANn4kTFpP6haVs/r1LL48pZB ty1oUo+Elbo56/RhcjCx1R3wzfKJKWTwfw5AovquyQIZ/7LLhjzkbjJTJt/1D5YXwYNP jkFoHemW2vn8QzTga84xSZGqUesy7rW39WmZahKfQ+K7zo/6gkHrjxYBYtEp04muXu9t y/sH3SLhyL/JuwP6E/ZUznusDCmqcXifirDPRiBWwoARGl5Nr4LIUmVfdAcyILihwBmh TBNdiLI4QUXTGtIlVgBaxXnAHR3FWd7ui+X+DAHXZSX2f0DCoyhOjMCTebrXG/YjGoQC hNkA== X-Gm-Message-State: AJIora84i4TBUP0ONBmeIWHiHy2+ZOjGJzDq9iSXDX3odBPE37ZxuBQP hfGDezxsOhAVizVWuyA5kv4= X-Google-Smtp-Source: AGRyM1t0QOBr9erpyf7jmjLE/oOiBlNlr/q0V5DW66YddsJao3mqr3ZWGBJYQtA1HfnkFRmj1rVVmA== X-Received: by 2002:a05:6402:1e95:b0:437:ce7f:e17a with SMTP id f21-20020a0564021e9500b00437ce7fe17amr27711429edf.169.1656803563812; Sat, 02 Jul 2022 16:12:43 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a01-0c23-c4d4-2700-f22f-74ff-fe21-0725.c23.pool.telefonica.de. [2a01:c23:c4d4:2700:f22f:74ff:fe21:725]) by smtp.googlemail.com with ESMTPSA id uz12-20020a170907118c00b00711aed17047sm12234329ejb.28.2022.07.02.16.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 16:12:43 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH v3 4/8] mtd: rawnand: intel: Remove undocumented compatible string Date: Sun, 3 Jul 2022 01:12:23 +0200 Message-Id: <20220702231227.1579176-5-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> References: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The "intel,nand-controller" compatible string is not part of the dt-bindings. Remove it from the driver as it's not supposed to be used without any documentation for it. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index 3df3f32423f9..056835fd4562 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -723,7 +723,6 @@ static int ebu_nand_remove(struct platform_device *pdev) } static const struct of_device_id ebu_nand_match[] = { - { .compatible = "intel,nand-controller" }, { .compatible = "intel,lgm-ebunand" }, {} }; From patchwork Sat Jul 2 23:12:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 586958 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8413C43334 for ; Sat, 2 Jul 2022 23:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231283AbiGBXNC (ORCPT ); Sat, 2 Jul 2022 19:13:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230464AbiGBXMr (ORCPT ); Sat, 2 Jul 2022 19:12:47 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28A93BC33; Sat, 2 Jul 2022 16:12:46 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id cf14so7133406edb.8; Sat, 02 Jul 2022 16:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jieKz72cmVh5R8qYrLL4foPrJEJnRnBgZYhz6Rx/tnM=; b=frQ1Qol83oss+lv4GeZejx5ahE9NUdxPRX7bykNoHAmP4yH9SlRkF8V0VDWBwvJ0BA 7n4Ck6HDdgQTsfE5uCN5BYfHbI9+YmmiiBPbTGGFY5EqBz7Ln+zmA2sjdOKzZGKEdDTN mg+iGjc9VzHsOvEwdNX5gou53MqdHNbsRwL6DL+ihsBxTMGll5CrKR0TmaC8FeQOhp7i K9jdBZkvJpSzKJM3T2j+lXjhCrssEjR6BvPyhL64OIWGiwod7aLBwEp+TWYWF+/pKMTG RywinF2Q9cQjR3saZBvz2fb/qnRDeEgxDfHOSN4ch7t/+3zYmA/RR+9/9kgEy4yEgB4C fMww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jieKz72cmVh5R8qYrLL4foPrJEJnRnBgZYhz6Rx/tnM=; b=r/WiYM9YJuT0ppwbIhwxaPoLQ5Ds2h4WbG9Q64groJDUfJ+JMZZ9Oe8PgUdr4Pnl+c T9CJH/Mi9BGNkI7fFTuwDU2vFHYFcp6aan2Euu5vNkqQEYh1z28vQ0WMuQQE1zqqRIAm 7CUNprF9L8NI4xt4lgMT7Od6arnatFZpLLUj0ahG01hY2natrJs57p3iPHC/mQWkmCId /iNVT5krepMptoX987cgf5Q57syrgu0Mv3X0Gm9hElyV6a4+DM1qoYZ8AV+9n+696jTV 6y8wdLlJHanGqniffKJPSKIFfVXL7hCkI/7+ZSUx9G16S7RvB3TYrPGEeVRrULFrvQDo AmBg== X-Gm-Message-State: AJIora9u9YgiflV1Xy1dTwEdv4YWYSDYLqhiO9HoeCMT0POeENJ7sIs+ 2EhkUMYx6/sp5Y13iZ6Lhp4= X-Google-Smtp-Source: AGRyM1u9Fq2VuzmmIzRNy0ZkprnEdbdp2bP9FPBBwB2JuLApMZEyuznyiXVqsHVJm3iOg6OSo5/iZg== X-Received: by 2002:a50:ef12:0:b0:435:81f3:a93a with SMTP id m18-20020a50ef12000000b0043581f3a93amr27300326eds.80.1656803564739; Sat, 02 Jul 2022 16:12:44 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a01-0c23-c4d4-2700-f22f-74ff-fe21-0725.c23.pool.telefonica.de. [2a01:c23:c4d4:2700:f22f:74ff:fe21:725]) by smtp.googlemail.com with ESMTPSA id uz12-20020a170907118c00b00711aed17047sm12234329ejb.28.2022.07.02.16.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 16:12:44 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH v3 5/8] mtd: rawnand: intel: Don't re-define NAND_DATA_IFACE_CHECK_ONLY Date: Sun, 3 Jul 2022 01:12:24 +0200 Message-Id: <20220702231227.1579176-6-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> References: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org NAND_DATA_IFACE_CHECK_ONLY is already defined in include/linux/mtd/rawnand.h which is also included by the driver. Drop the re-definition from the intel-nand-controller driver. Fixes: 0b1039f016e8a3 ("mtd: rawnand: Add NAND controller support on Intel LGM SoC") Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index 056835fd4562..3df16d5ecae8 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -100,8 +100,6 @@ #define HSNAND_ECC_OFFSET 0x008 -#define NAND_DATA_IFACE_CHECK_ONLY -1 - #define MAX_CS 2 #define USEC_PER_SEC 1000000L From patchwork Sat Jul 2 23:12:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 586661 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AAFDCCA480 for ; Sat, 2 Jul 2022 23:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231405AbiGBXNE (ORCPT ); Sat, 2 Jul 2022 19:13:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbiGBXMx (ORCPT ); Sat, 2 Jul 2022 19:12:53 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0406DBC3A; Sat, 2 Jul 2022 16:12:47 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id e40so7178221eda.2; Sat, 02 Jul 2022 16:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rMFZHu8PDqwv5GHr5nbOBzzYZPK8b+QduZ22FxBHIqo=; b=LmMpJrmNWZeApdyuPOlUWyIq9xXhlUREoibq6Q6UO4K47VwQD2ByfL3DwZaGQ/eLhc c9Z46PM3h5NxHMI9zEfHzJnVJ/vacO204dRiwGf+p2amHUA6KBExp/Wcnzu1Jy+CDdQ0 k4nDLlsNF+zX36ib8uD8VTPTtbQ6afyLNe2KKOj18X8enaCOmeVmW+r7FnACrAqn5/mF fgRhbJqjwYiwW8V+JQC1wwL3A8VZ1qIsZKomzgx0c61lkRxPyvB6zFZsQ80b1WOF/In0 JFMoKYaBxH1tR035v25j5whzFlj78ce0onBkRMDFht5l6aQ9Tqkf6e7XedQDZH63ve+S ieew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rMFZHu8PDqwv5GHr5nbOBzzYZPK8b+QduZ22FxBHIqo=; b=apsvtp0fc2V5Z0WTA9hk3CXEimP7Et0YiDbvcNCBxIFgEH497nKBqRRE+UV/tEXWdN mhNU+Rp+d9jHVEwg3d+xSnzdm2EXPyd3H9ost7uIzcO1FM/vHX1Hmp5OBqQPbxWET5wx W7bWIL41b5vwgS2ybQeL4GUB11Ym1zF0RDOFQiKV7sHquYDm7xKPUIjzADC2zY9TZLa3 Q3Mc/orH5RX3w4vBSqUiPUu5OEfEvda5aHQN8KACfqPJsiD/Ikls/HltPN42pORNwuMB hzKpw8AbjRxBWjQJw2USUZyHLb1wYKnqq3NODo5ftw4ieevs7LfaVfnh0ypcTTM7dAQY i32w== X-Gm-Message-State: AJIora+fi2jWCVurdnw0dt5W/NlHL1FCAtnvelvq8oOW4rDIhK+Rph4t FqtnbzJpQRDkANbhlSY8FZs= X-Google-Smtp-Source: AGRyM1sD+hNDqYlRurGJOdDI4Xbt/HFa3sI09ympVXFOMrrvtT1B020+WOXrAo26KkGChwkm/eBf0Q== X-Received: by 2002:a05:6402:2549:b0:437:788d:b363 with SMTP id l9-20020a056402254900b00437788db363mr27528790edb.406.1656803565559; Sat, 02 Jul 2022 16:12:45 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a01-0c23-c4d4-2700-f22f-74ff-fe21-0725.c23.pool.telefonica.de. [2a01:c23:c4d4:2700:f22f:74ff:fe21:725]) by smtp.googlemail.com with ESMTPSA id uz12-20020a170907118c00b00711aed17047sm12234329ejb.28.2022.07.02.16.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 16:12:45 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH v3 6/8] mtd: rawnand: intel: Remove unused nand_pa member from ebu_nand_cs Date: Sun, 3 Jul 2022 01:12:25 +0200 Message-Id: <20220702231227.1579176-7-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> References: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The nand_pa member from struct ebu_nand_cs is only written but never read. Remove this unused and unneeded member. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index 3df16d5ecae8..de4f85368988 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -106,7 +106,6 @@ struct ebu_nand_cs { void __iomem *chipaddr; - dma_addr_t nand_pa; u32 addr_sel; }; @@ -626,7 +625,6 @@ static int ebu_nand_probe(struct platform_device *pdev) ebu_host->cs[cs].chipaddr = devm_ioremap_resource(dev, res); if (IS_ERR(ebu_host->cs[cs].chipaddr)) return PTR_ERR(ebu_host->cs[cs].chipaddr); - ebu_host->cs[cs].nand_pa = res->start; ebu_host->clk = devm_clk_get(dev, NULL); if (IS_ERR(ebu_host->clk)) From patchwork Sat Jul 2 23:12:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 586662 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A2AEC433EF for ; Sat, 2 Jul 2022 23:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231319AbiGBXND (ORCPT ); Sat, 2 Jul 2022 19:13:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230517AbiGBXMx (ORCPT ); Sat, 2 Jul 2022 19:12:53 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D30C8BC3D; Sat, 2 Jul 2022 16:12:47 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id k20so7112148edj.13; Sat, 02 Jul 2022 16:12:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GtoWH3Twv71XknYtu8BYL5GG9PgQIu+29g9mDNFEswk=; b=i2P13B5htVIAXOVn3aOtys9xFRhh9MhWIKQhDBsF3OJp5Bk6Tk3p+wEq5Q6XG4d+Q3 9qOQS/7iMbs9xuGAUzX3Zjx7kCrCo6AP+ujhWDe1vD+uCoKOtHSAz+64zFvWjvDil71i WPHod0c0Et7CBl51X44fINlID1VhPU2FC9DyjvYohqc0cZEF9q/DGtnCan4rlvg1r1oN uRYzVjqWSWHWQW+8qKpJAbUzwMSVYOIUNiagrijfmqWH2mOU3vKbFIKdxRWYiQFXg5tH WLCzXPenfIjxkPuEvrbL2gM8Eg/EoI3WfQJu9RDfA60fIAdhfJ6XCRGoFP5Sq4EN2yQG WGFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GtoWH3Twv71XknYtu8BYL5GG9PgQIu+29g9mDNFEswk=; b=q7zh9KBq7jPJCX866IFfczLldDzAr6c0HnzLdiKRYzRVWFE/hNDgRPjvT2j4PkF39y U4+psbabeQp6O8DTFo1bpa/ZN4guScR83skittwHZwIZsRzrGeHL2F1OqUeDnUlCrl/h R5vR/es8mPxaS32Kg/32r6tisaDPCUrhY4XXmlFgueFV1+NSEUEEiXoXiTowwobNmgma 1pRR3QmjAW1F4F0GAoLQxqRM25SjqiZQIdhbF3PddUZYgtUhB4A3dkNTICaHI5nEAO+c M2tYm90QY+ODIbSkV/fItkxWdWa1aL1D2H5fktcvKPBLpOIovVR+Srgt2mkuebNiLDAs Ngpg== X-Gm-Message-State: AJIora+FIfnqmffkRmhFg54g/SbVS5mGAheaE7zNMufgQh8GXE3DsG9D Py9OiJKmWL/BAfVo+x53OUc= X-Google-Smtp-Source: AGRyM1u5k9aKO+kjClRFeCmf055a08Jc0GwYvjMkLIuQgHTnWlnBVgpFInI7O5yAAkYBIZg06v854Q== X-Received: by 2002:a05:6402:26d6:b0:435:ba41:dbb0 with SMTP id x22-20020a05640226d600b00435ba41dbb0mr28127029edd.242.1656803566388; Sat, 02 Jul 2022 16:12:46 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a01-0c23-c4d4-2700-f22f-74ff-fe21-0725.c23.pool.telefonica.de. [2a01:c23:c4d4:2700:f22f:74ff:fe21:725]) by smtp.googlemail.com with ESMTPSA id uz12-20020a170907118c00b00711aed17047sm12234329ejb.28.2022.07.02.16.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 16:12:46 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH v3 7/8] mtd: rawnand: intel: Remove unused clk_rate member from struct ebu_nand Date: Sun, 3 Jul 2022 01:12:26 +0200 Message-Id: <20220702231227.1579176-8-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> References: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The clk_rate member from struct ebu_nand is only written but never read. Remove this unused and unneeded member. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index de4f85368988..e486db11ecc3 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -118,7 +118,6 @@ struct ebu_nand_controller { struct dma_chan *dma_tx; struct dma_chan *dma_rx; struct completion dma_access_complete; - unsigned long clk_rate; struct clk *clk; u32 nd_para0; u8 cs_num; @@ -636,7 +635,6 @@ static int ebu_nand_probe(struct platform_device *pdev) dev_err(dev, "failed to enable clock: %d\n", ret); return ret; } - ebu_host->clk_rate = clk_get_rate(ebu_host->clk); ebu_host->dma_tx = dma_request_chan(dev, "tx"); if (IS_ERR(ebu_host->dma_tx)) { From patchwork Sat Jul 2 23:12:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 586957 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B21CCA47B for ; Sat, 2 Jul 2022 23:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231382AbiGBXNE (ORCPT ); Sat, 2 Jul 2022 19:13:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiGBXMx (ORCPT ); Sat, 2 Jul 2022 19:12:53 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4D64BC84; Sat, 2 Jul 2022 16:12:48 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id o9so7120533edt.12; Sat, 02 Jul 2022 16:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1tfhcm8JZSEoxWkGuUHKnCtWh4qkCjWwjLcTzBInqbQ=; b=qbIIucf1dHuEEnkQJeZxhoxVXunTNBrwf9pPgBg71UJEDtXVOAHHMiaM/j3sUnPzF4 46asSmFmH7jSYtv7wiE5CucIH7eN4l4/0NyOyVVrG8RpEP8QOgTGtC8buXFJUIm2EOwB PY+FXLWsmIz4WjcO/Cb9ZmEGV5zauPiwV+JW4P5LlnwK2vM5LfCTU8FTcXyuq7+m3Qci YcsNRVVO90cY4nHHJVbCD/loPHso+pV90AIizkTEqn42JyeLulqzGyRzVlbvQnqMLRB0 t6cRg9MP/2bmRy3mxFm9EUOSrJ1otUePF1pzZvIGlTFak+pXO+sKwLHoer7KuqWWrnMd ic3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1tfhcm8JZSEoxWkGuUHKnCtWh4qkCjWwjLcTzBInqbQ=; b=TMTNNMcIuYX27fLKOP2//a555+Du37TdQN3ZEiAmmM9DOuYsiECZ/W/SG5X5OBT9uu 3NGWUkbVidVRB1OPm0ziXigpa54pFOISy7S9erUBrl5z0blAMpDxz7RbUikSiiR4wxk8 y/s1aPqj0ufo4p04mJLhNhCI6IO1D3C0CvOQ4oO5D10cXypIDvbv8LJpt3jLWQltuHwk 02kAB/k+AhjJ8Jxw12TL0kjdOV2h/WiTMADDb9uBzFHz5L4cA8L6N5kbHZVGOFm61CJe g5Ims+3lvBfEHNlPU/UZ65gqYyPUd8oriGQtdXtvgdUHBgaoh3kmFUbBSUZOf7KoBy3C afYQ== X-Gm-Message-State: AJIora+WtfRqCZZkJhv9neagWvy63kXL3I3tO/NXn+X13r9vTnX5/6Lw 3JmgR6Dm9ySIofRWsejgCJ+9MalAvok= X-Google-Smtp-Source: AGRyM1sEQUtTu4io9H64uN46LrAbSLznCXdL3wuhSctJgfAka/2jCTDrvjy+AwrKFyWjb+CH6dGK4g== X-Received: by 2002:a05:6402:950:b0:439:646e:c68e with SMTP id h16-20020a056402095000b00439646ec68emr18073691edz.42.1656803567209; Sat, 02 Jul 2022 16:12:47 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a01-0c23-c4d4-2700-f22f-74ff-fe21-0725.c23.pool.telefonica.de. [2a01:c23:c4d4:2700:f22f:74ff:fe21:725]) by smtp.googlemail.com with ESMTPSA id uz12-20020a170907118c00b00711aed17047sm12234329ejb.28.2022.07.02.16.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 16:12:46 -0700 (PDT) From: Martin Blumenstingl To: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, tlanger@maxlinear.com, rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, Martin Blumenstingl Subject: [PATCH v3 8/8] mtd: rawnand: intel: Use devm_platform_ioremap_resource_byname() Date: Sun, 3 Jul 2022 01:12:27 +0200 Message-Id: <20220702231227.1579176-9-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> References: <20220702231227.1579176-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Switch from open-coded platform_get_resource_byname() and devm_ioremap_resource() to devm_platform_ioremap_resource_byname() where possible to simplify the code. Signed-off-by: Martin Blumenstingl --- drivers/mtd/nand/raw/intel-nand-controller.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/nand/raw/intel-nand-controller.c b/drivers/mtd/nand/raw/intel-nand-controller.c index e486db11ecc3..d4a0987e93ac 100644 --- a/drivers/mtd/nand/raw/intel-nand-controller.c +++ b/drivers/mtd/nand/raw/intel-nand-controller.c @@ -592,13 +592,11 @@ static int ebu_nand_probe(struct platform_device *pdev) ebu_host->dev = dev; nand_controller_init(&ebu_host->controller); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ebunand"); - ebu_host->ebu = devm_ioremap_resource(&pdev->dev, res); + ebu_host->ebu = devm_platform_ioremap_resource_byname(pdev, "ebunand"); if (IS_ERR(ebu_host->ebu)) return PTR_ERR(ebu_host->ebu); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hsnand"); - ebu_host->hsnand = devm_ioremap_resource(&pdev->dev, res); + ebu_host->hsnand = devm_platform_ioremap_resource_byname(pdev, "hsnand"); if (IS_ERR(ebu_host->hsnand)) return PTR_ERR(ebu_host->hsnand); @@ -620,8 +618,8 @@ static int ebu_nand_probe(struct platform_device *pdev) ebu_host->cs_num = cs; resname = devm_kasprintf(dev, GFP_KERNEL, "nand_cs%d", cs); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, resname); - ebu_host->cs[cs].chipaddr = devm_ioremap_resource(dev, res); + ebu_host->cs[cs].chipaddr = devm_platform_ioremap_resource_byname(pdev, + resname); if (IS_ERR(ebu_host->cs[cs].chipaddr)) return PTR_ERR(ebu_host->cs[cs].chipaddr);