From patchwork Mon Jul 11 17:17:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Tomlin X-Patchwork-Id: 589730 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF2FCCA481 for ; Mon, 11 Jul 2022 17:17:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231377AbiGKRR3 (ORCPT ); Mon, 11 Jul 2022 13:17:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbiGKRR2 (ORCPT ); Mon, 11 Jul 2022 13:17:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 58B395140F for ; Mon, 11 Jul 2022 10:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657559846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r5CZMjCHrznhAlDAvMwZi4LrvvAMrjysFI7tqvoFjPg=; b=QHuEVeJ3E2HsKTgsIrfib4yRWtfauiey4FK2pibXbpv9qd1/oAel0nZNnYRSiLgiDqaViM 806eH4N1k5jSKI7yoiGdm96AHabuVk/W0woXoxGRSAH60QtGCk8zVjURirQRUwZwdsBao8 lw37MSG0EcUQGcm6dFz/BiCXqldTrKA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-457-gb_2jp-oPAqsDXvK2lPndA-1; Mon, 11 Jul 2022 13:17:25 -0400 X-MC-Unique: gb_2jp-oPAqsDXvK2lPndA-1 Received: by mail-wm1-f72.google.com with SMTP id r206-20020a1c44d7000000b003a2cfab0839so2620599wma.5 for ; Mon, 11 Jul 2022 10:17:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r5CZMjCHrznhAlDAvMwZi4LrvvAMrjysFI7tqvoFjPg=; b=JlD9iq42pMiObFm1wtMWZ4kkf029iW4weYkCoQWe1Qb9bvLgFilRyX8Vw/QGw8Hqnf sN3Vzhd7B/gYndREw+etb7BaVExB1vLit8ckG59iHO/PxO7iCfyE4k6xSAyzCKiUk6Sf 3XQQu9kBo+ERUIdEZIAAh55olxHf6adfXKJu+mg9WyypY/cIHWHAXSyECiwy1JXU3nGk ygFPPPTYLtsU67whU6ma023mogTLEX5a8QWTaKy5J+/RmMs7MQ/No7zPsOMcVio7ct89 7O0AdZsuYvA2M0rmDWNXYx50OleVyIdinO7EGIZuf0HEaP9NinX5VdPjM9cGn81oz1Ct YWVg== X-Gm-Message-State: AJIora9ADkxXnXFAyNQXdI2OqM0j7naY4QFR+KVNm99FFZ6ySZO3bM6e OyWz4hmGqI9XjQpB9h7WBg+vdcJ1layPkmmeml0FzfkQVfuDNauA//qjzu3npXUXBxg/NrUl3CK EzSu7IFTWwjYA8jgDMGNqRCtN+Q== X-Received: by 2002:a05:600c:4f95:b0:3a1:7310:62d8 with SMTP id n21-20020a05600c4f9500b003a1731062d8mr16840445wmq.16.1657559844277; Mon, 11 Jul 2022 10:17:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v0iG5UhoXyDbYSBqO1pe6N4iA2WYxaZ6drqDo17YFm0K4RwhjlO/+3C4clOQZfwzUOTD1sGA== X-Received: by 2002:a05:600c:4f95:b0:3a1:7310:62d8 with SMTP id n21-20020a05600c4f9500b003a1731062d8mr16840422wmq.16.1657559844102; Mon, 11 Jul 2022 10:17:24 -0700 (PDT) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id f13-20020a05600c154d00b003a04d19dab3sm26356809wmg.3.2022.07.11.10.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 10:17:22 -0700 (PDT) From: Aaron Tomlin To: mcgrof@kernel.org, rostedt@goodmis.org Cc: cl@linux.com, pmladek@suse.com, mbenes@suse.cz, christophe.leroy@csgroup.eu, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, atomlin@atomlin.com, ghalat@redhat.com, oleksandr@natalenko.name, neelx@redhat.com, daniel.thompson@linaro.org, hch@infradead.org, tglx@linutronix.de, adrian.hunter@intel.com, linux-rt-users@vger.kernel.org Subject: [PATCH v3 -next 1/1] module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT_RT Date: Mon, 11 Jul 2022 18:17:19 +0100 Message-Id: <20220711171719.1244255-2-atomlin@redhat.com> X-Mailer: git-send-email 2.34.3 In-Reply-To: <20220711171719.1244255-1-atomlin@redhat.com> References: <20220711171719.1244255-1-atomlin@redhat.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org The commit 08126db5ff73 ("module: kallsyms: Fix suspicious rcu usage") under PREEMPT_RT=y, disabling preemption introduced an unbounded latency since the loop is not fixed. This change caused a regression since previously preemption was not disabled and we would dereference RCU-protected pointers explicitly. That being said, these pointers cannot change. Before kallsyms-specific data is prepared/or set-up, we ensure that the unformed module is known to be unique i.e. does not already exist (see load_module()). Therefore, we can fix this by using the common and more appropriate RCU flavour as this section of code can be safely preempted. Reported-by: Steven Rostedt Fixes: 08126db5ff73 ("module: kallsyms: Fix suspicious rcu usage") Signed-off-by: Aaron Tomlin --- kernel/module/kallsyms.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/kernel/module/kallsyms.c b/kernel/module/kallsyms.c index 18c23545b984..77e75bead569 100644 --- a/kernel/module/kallsyms.c +++ b/kernel/module/kallsyms.c @@ -176,14 +176,14 @@ void add_kallsyms(struct module *mod, const struct load_info *info) mod->kallsyms = (void __rcu *)mod->init_layout.base + info->mod_kallsyms_init_off; - preempt_disable(); + rcu_read_lock(); /* The following is safe since this pointer cannot change */ - rcu_dereference_sched(mod->kallsyms)->symtab = (void *)symsec->sh_addr; - rcu_dereference_sched(mod->kallsyms)->num_symtab = symsec->sh_size / sizeof(Elf_Sym); + rcu_dereference(mod->kallsyms)->symtab = (void *)symsec->sh_addr; + rcu_dereference(mod->kallsyms)->num_symtab = symsec->sh_size / sizeof(Elf_Sym); /* Make sure we get permanent strtab: don't use info->strtab. */ - rcu_dereference_sched(mod->kallsyms)->strtab = + rcu_dereference(mod->kallsyms)->strtab = (void *)info->sechdrs[info->index.str].sh_addr; - rcu_dereference_sched(mod->kallsyms)->typetab = mod->init_layout.base + info->init_typeoffs; + rcu_dereference(mod->kallsyms)->typetab = mod->init_layout.base + info->init_typeoffs; /* * Now populate the cut down core kallsyms for after init @@ -193,20 +193,20 @@ void add_kallsyms(struct module *mod, const struct load_info *info) mod->core_kallsyms.strtab = s = mod->data_layout.base + info->stroffs; mod->core_kallsyms.typetab = mod->data_layout.base + info->core_typeoffs; strtab_size = info->core_typeoffs - info->stroffs; - src = rcu_dereference_sched(mod->kallsyms)->symtab; - for (ndst = i = 0; i < rcu_dereference_sched(mod->kallsyms)->num_symtab; i++) { - rcu_dereference_sched(mod->kallsyms)->typetab[i] = elf_type(src + i, info); + src = rcu_dereference(mod->kallsyms)->symtab; + for (ndst = i = 0; i < rcu_dereference(mod->kallsyms)->num_symtab; i++) { + rcu_dereference(mod->kallsyms)->typetab[i] = elf_type(src + i, info); if (i == 0 || is_livepatch_module(mod) || is_core_symbol(src + i, info->sechdrs, info->hdr->e_shnum, info->index.pcpu)) { ssize_t ret; mod->core_kallsyms.typetab[ndst] = - rcu_dereference_sched(mod->kallsyms)->typetab[i]; + rcu_dereference(mod->kallsyms)->typetab[i]; dst[ndst] = src[i]; dst[ndst++].st_name = s - mod->core_kallsyms.strtab; ret = strscpy(s, - &rcu_dereference_sched(mod->kallsyms)->strtab[src[i].st_name], + &rcu_dereference(mod->kallsyms)->strtab[src[i].st_name], strtab_size); if (ret < 0) break; @@ -214,7 +214,7 @@ void add_kallsyms(struct module *mod, const struct load_info *info) strtab_size -= ret + 1; } } - preempt_enable(); + rcu_read_unlock(); mod->core_kallsyms.num_symtab = ndst; }