From patchwork Wed Jul 20 15:26:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 591869 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5817:0:0:0:0 with SMTP id j23csp5059956max; Wed, 20 Jul 2022 08:28:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vdzYAxe59F1KH3ZXdGejCx6WoQZcBwyiUGJG8jfrmDsIeFgkdtB9WC3C9KL9vtYjCidj3+ X-Received: by 2002:a05:6214:500b:b0:473:561f:1295 with SMTP id jo11-20020a056214500b00b00473561f1295mr30178217qvb.23.1658330921839; Wed, 20 Jul 2022 08:28:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658330921; cv=none; d=google.com; s=arc-20160816; b=QqjvUugAhWuhpvSzxRnDgl9qZ30aHxvu+/KjmKv1EDpza3hQCiPAW9JJzZD+R2AowB 4kUgWSYOISsKzvJYEKGnHHGYMijoXboMU/qz1WPKQRmw4v/3geflB1HCv6eQrtPysFOj 3Psn3JpPYn3Z2Udl+zxzwmoEElWCmrV5nhfQF935865YFasAjJ70oxbBAEUu/P77IJ6F VHV4rrtKRjzv01wv7xLN93G1a1qBj3imziY4S05u1kXZFf2Xw+OH7Rzw76LXwJbkL95J Z8H/igxxdzCQXsGOkPfrxThQNmv0faVR1NWgdSqK0YKs/UimjzS/Z/aW5K5CMlwtE/TW wTTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YO5oI71pbWpf1Cp3bbqdXyUqFH5RPgviSgLa1og9xxU=; b=KX5iNZSh9rgPpqTgyzDKCNhHcH8RYXTuNWh6xwxhw10ugpNfnDj38GSrx2r1hZhaNY DskDKDDrQq7NjtXOjvAnheXtAilJPvQdrZ33AICO8Cq7q/1RTGFJA+Cuqcs6qJhRs7dF ZXbeVrqad3b/zN7QoYgTOzPAlDo+PQ4kSa26++A6w2+OpQuUyn2I5050VDQEihl4CMiW RqddNstGRy0tJ8HKRaQtwiTjhPWzHo2CM6vgk9FFMgZXfONXuDFOjDqG2Hc2Jsyw8w29 Xl7SFfqR7afOg48+UWA6V+bZZtKupU0MbbBQtqeWQy+TNqdb9ayuEq1VWk2SHsY6KriL wg4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YMi3r6Mg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 202-20020a3705d3000000b006b55d58fb27si8271621qkf.153.2022.07.20.08.28.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jul 2022 08:28:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YMi3r6Mg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEBcv-0002Ox-GN for patch@linaro.org; Wed, 20 Jul 2022 11:28:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBav-0002MT-QO for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:37 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:45829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEBau-0005Bm-8i for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:37 -0400 Received: by mail-wr1-x434.google.com with SMTP id a5so26589028wrx.12 for ; Wed, 20 Jul 2022 08:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YO5oI71pbWpf1Cp3bbqdXyUqFH5RPgviSgLa1og9xxU=; b=YMi3r6Mgx9Su24p5f+ikpi0yRxA8+WW1IaOAUxP5RBZ3riNLssWNheTRcRjq5EcCZO Py5oYh3HOzKPcJ/2z473X5OCTeUiGAxAN7R9jTz01onvDaA0eOuf031LH1piiU1bfnEY LvdtG4ijYX7wqQ0jAP/lZFq90p0BN8EIB5Zll8Fwz2bpiZQ3/fqSeoarAbB0B4t1i3c+ S/z6IKqJG5oafl7mfCBHx7+MIO4FfrolZriMQeK+Nw++q9JKAxgFcagCjpzdnRWjqTLB tiBpEWLzZdJYu8RMNL2ybI9kW4d9dwO8hEdhHEIoljz5f338j8Z0hwr84vFHyoV66WU8 8EVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YO5oI71pbWpf1Cp3bbqdXyUqFH5RPgviSgLa1og9xxU=; b=600aJItoqzvBdGDVW585KH5RzDoDxZEOevX7OsTCNdexMQVWT1RPJwJmY32t9buAWh zhRzUY4CmOz7qbt0EcNDknLXjT6PlhsA53p8MUQNxCaJek2JggAreBo3kyl3yrDXZUPL kf/uK4nbfVZnMSZvjqGPT7LuCrcH5PM1SdPZ5cX+cCy9OfgyTj91CwUlv0VYFNu1FFsP YYwQnGyKI7tmj+pceX96RXN3jsS4JzdtYqgj1p0hATpZn1o8diP9fbogLnoIx+zmDDxc MQ2y6ZQRyY39AIUFF8PcbjQzeMYT3H/9rYNuMmtHwgf1uphByi6G37i0c5QzbepyUuD/ mA7A== X-Gm-Message-State: AJIora8aROTCfaj6vqw6TDCmiTiP+dHo6YFnqGtEWZye6pVYcVPUXgRh gvHXmXh1UYC3K/0gbqNbw/LVoAd96vXMWQ== X-Received: by 2002:adf:f108:0:b0:21d:7f0f:22db with SMTP id r8-20020adff108000000b0021d7f0f22dbmr30195610wro.187.1658330794841; Wed, 20 Jul 2022 08:26:34 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id r10-20020a056000014a00b0021d68a504cbsm16395987wrx.94.2022.07.20.08.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 08:26:34 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Dr. David Alan Gilbert" , Thomas Huth , Richard Henderson Subject: [PATCH 1/5] configure: Add missing POSIX-required space Date: Wed, 20 Jul 2022 16:26:27 +0100 Message-Id: <20220720152631.450903-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720152631.450903-1-peter.maydell@linaro.org> References: <20220720152631.450903-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" In commit 7d7dbf9dc15be6e1 we added a line to the configure script which is not valid POSIX shell syntax, because it is missing a space after a '!' character. shellcheck diagnoses this: if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then ^-- SC1035: You are missing a required space after the !. and the OpenBSD shell will not correctly handle this without the space. Fixes: 7d7dbf9dc15be6e1 ("configure: replace --enable/disable-git-update with --with-git-submodules") Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Tested-by: Dr. David Alan Gilbert --- David Gilbert noted the OpenBSD issue on IRC -- I have not tested this fix there myself. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 35e0b281985..dec6f030346 100755 --- a/configure +++ b/configure @@ -2425,7 +2425,7 @@ else cxx= fi -if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then +if ! (GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then exit 1 fi From patchwork Wed Jul 20 15:26:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 591870 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5817:0:0:0:0 with SMTP id j23csp5059972max; Wed, 20 Jul 2022 08:28:43 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sd9/y9897mesf8JxZWvSdCJq+hkoOg05Cewkyy/V9JRTMSjcn6lEE3Ag6OkF5gWwvD5KyX X-Received: by 2002:ac8:4e54:0:b0:31d:36a5:70cb with SMTP id e20-20020ac84e54000000b0031d36a570cbmr29745212qtw.18.1658330922971; Wed, 20 Jul 2022 08:28:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658330922; cv=none; d=google.com; s=arc-20160816; b=t+yzS4f+s6EvhHzrCotiltfF/wp/rXyrr7ZssGCdo42Q5ZlNe9w0f2wBJdKM6KXDBN sfYexe72mxCAfoWCXET7X7UR+HAIG0T77A2UR3JK8LeIEyZUdrVQdFMuk+FZrWziDgTB tL2j7wYHI6sBIx9kxTaTa0RUfwyi/WCrVoPIF1BM4JNfLFX5/VEmo2IrplZjheOhU/TE QKN9d57w4YcfPLPo2Km73EfAwWDthV1vx4NtMCjVj2hU62PE6oh5gDeso79zu9hxo3J+ OIYFQ9sJ88XJ58DSGoc0fgdjbaw7rU+E20Wx12ztTvmYlVCuS/VvoejMmhe56GDq59RK FI8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MscM+gZk5hsADKY0aO+LrAtG2rCxpG8OilnI2AQx9rg=; b=CTCGZ9S7xqoi7fgof3IVQvS9pZEPbJ4NQkNhMQr6NJyLUBUwEb+lA6KzMK7RxXxMFH 9fvip7qk1zoqymHIF4Dh/oTB5RRsXWUVC5eLV0YG8pRG+33Hgt1aiHcCccuBJekC1Lo+ oeAyucvtqHRHR0k3xLBcmAQSNDB3iP7c9FceyDw28wDXT+kaa1fs2kiJxL4oxcOQKOs3 n0G3hOIfmdDm2fd3WgGRR1hTTycPdPFzcieVPgrrscSCzmLRKCTNJ5TeM6DcpxrSjHeM CbmyzlVm/4vkdND9Stalp7VrxOXQBDdQugMFT0vynB2BROpsM81zITgJpWrsm54QBb2B Ml8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="eVdr/7Mw"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s14-20020a05620a0bce00b006b584eb2f7bsi9819215qki.586.2022.07.20.08.28.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jul 2022 08:28:42 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="eVdr/7Mw"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59038 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEBcw-0002RX-JT for patch@linaro.org; Wed, 20 Jul 2022 11:28:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBaw-0002NQ-KH for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:38 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:41773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEBau-0005Bu-W2 for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:38 -0400 Received: by mail-wr1-x42a.google.com with SMTP id n12so13771861wrc.8 for ; Wed, 20 Jul 2022 08:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MscM+gZk5hsADKY0aO+LrAtG2rCxpG8OilnI2AQx9rg=; b=eVdr/7MwlooMP4xoBzBnBF1o3p74s1pJJ0+Soj4OZMapGWlu2u6cKhFVC8WQhR7yva qRRg9RYH/euRk1lnml7DdJW62mUZTGq5oIl+SObD0QlrpPEr6yMm15NzMs7pdL+HAwXS tz0bRFSDA09iemXYZHpqjZSQpNWiTsG7eQSdZvkcoIvhZs5WEsc7JIS7/LIQ5qH+06PM UpFz0Jkv56f3xq11TeJmz/z6MBI/sNrEmOdaIecB3vAyHDzdlCIwwlqb2H30IaM+NlfQ sNRNYdy/R2PiQrOFYXqGXBjy1ka71twlpoB9muQFpt5wru5qNf/I+WehHluCacp2GLaZ bxWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MscM+gZk5hsADKY0aO+LrAtG2rCxpG8OilnI2AQx9rg=; b=65GNTTAhythsTVCuYsl2MgzD3BYZ0Er+vw7nCf5PcN9qQHR+pPG6wKJZuNZKsg0seZ ZjX6i06TZ91ih+S1HTlvQedt0ZJfOd0/XZzePgGrlJ1ulCKTvUY+sqT6FB/2WHBm+nRJ pdIAtPvSU18w71ID6tUIXWR14goYyEnUNEydq+BAK+sracwaMz1ixAID6La4SgqZbfl+ HuMK2Qp6WU3uakHltKWp2V8nFeIpbgKqfCd/F50wgYGj/I+Z57aAPkhCtZxtfTND/AxJ 4bSXWVe+Q7US61XNK1+MN2YfbBjwBrjh3GxS6EoWfSIEp4bvGt+VWBDXvrd7rmWmOYt0 iuRQ== X-Gm-Message-State: AJIora9OZxWxz0TcaG4ZpIZp6d8k193ru/gxJa2dVCVpRM/WLYLv9VL7 0hfohiy8EDAAbsOcWE8OH2sExUyOXaTF/A== X-Received: by 2002:adf:f245:0:b0:21d:a39a:bed5 with SMTP id b5-20020adff245000000b0021da39abed5mr30087614wrp.508.1658330795649; Wed, 20 Jul 2022 08:26:35 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id r10-20020a056000014a00b0021d68a504cbsm16395987wrx.94.2022.07.20.08.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 08:26:35 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Dr. David Alan Gilbert" , Thomas Huth , Richard Henderson Subject: [PATCH 2/5] configure: Add braces to clarify intent of $emu[[:space:]] Date: Wed, 20 Jul 2022 16:26:28 +0100 Message-Id: <20220720152631.450903-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720152631.450903-1-peter.maydell@linaro.org> References: <20220720152631.450903-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" In shell script syntax, $var[something] is not special for variable expansion: $emu is expanded. However, as it can look as if it were intended to be an array element access (the correct syntax for which is ${var[something]}), shellcheck recommends using explicit braces around ${var} to clarify the intended expansion. This fixes the warning: In ./configure line 2346: if "$target_ld" -verbose 2>&1 | grep -q "^[[:space:]]*$emu[[:space:]]*$"; then ^-- SC1087: Use braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet). Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth --- This is our only 'error' level shellcheck warning, so it seems worth suppressing even though it's not wrong as written. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index dec6f030346..a56c3d921be 100755 --- a/configure +++ b/configure @@ -2343,7 +2343,7 @@ if test -n "$target_cc" && # emulation. Linux and OpenBSD/amd64 use 'elf_i386'; FreeBSD uses the _fbsd # variant; OpenBSD/i386 uses the _obsd variant; and Windows uses i386pe. for emu in elf_i386 elf_i386_fbsd elf_i386_obsd i386pe; do - if "$target_ld" -verbose 2>&1 | grep -q "^[[:space:]]*$emu[[:space:]]*$"; then + if "$target_ld" -verbose 2>&1 | grep -q "^[[:space:]]*${emu}[[:space:]]*$"; then ld_i386_emulation="$emu" break fi From patchwork Wed Jul 20 15:26:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 591871 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5817:0:0:0:0 with SMTP id j23csp5062476max; Wed, 20 Jul 2022 08:31:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1slzxcJnoJO9VMq2ljtXfhJ135nFIX1+GvRAgYBtoA3MllRPFGobpg2TJt75xyVjNlnN6nF X-Received: by 2002:ac8:5fca:0:b0:31e:b661:7ae4 with SMTP id k10-20020ac85fca000000b0031eb6617ae4mr30091057qta.585.1658331085363; Wed, 20 Jul 2022 08:31:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658331085; cv=none; d=google.com; s=arc-20160816; b=kk8WdWC6pTSc50Unxuj5FVJuhGCmzjbNpIBI1QWDbg6Ruv3+cQPomkJEJZRUA/CMRT HMrAHNeyHb3OLNpEO+X+d3QbZhV4iIkw8YVzgw/LSoURRdY/Q3X9/pKgfFHhbDT/8Vgv GWMq8mIB+6Q/dsMAH31ocmpNLEiy7bg85gDbqCMgld8A7/HyxfNwwz/kL/q8wJReTBNV 4aJqcxcNcigqR4QuaYjDG7qs+HcetoirnZP5MGFi3OX3D26wzpQFWME3tbqC5Boy0/vS 1xj75V2qQmWdrD43ehkDkOX6hzRdILSq5+FQoFoS9pg+p8e4Zusb3ukGZxizw3HgzhC/ l/Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RnUi10H2zETr3PzFE8ItmqNkeEXhjlZHbA93aIrcRAo=; b=qwnXxQSZ39uMWoeRMxc9A0spfBJytZbdfVoKKZMRs4i8h9cuk74g5UUmLXyIm+rRtK s23nPcYagSVbSOXPO89YKw2ayqTvHrmacjiY2qMgZD/M27EvACpXqQ32sGI4+7ihlzwa XOrpIc6zkJTXV+cpV6R5Jy1NhcmrJi76FlQ5WlP6DEAtmCJAM/LcW2X18uSVqh5mvtdB 4YpyrvIqgasSo/TCB2wsodTPsD7k0Vbv3ik2Ked0wYgLyM7nH8dsNzWKfCh8PDMLlvWq znORxJr93sgUM38gNxnnvErUiJmjQGQuxQ/DAujLet6D1Q31jeTDaD90pp+0Gt38m7xM brhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=buCbvTCA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id bq30-20020a05620a469e00b006b14fa18a1bsi3149077qkb.540.2022.07.20.08.31.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jul 2022 08:31:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=buCbvTCA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEBfY-0007Bz-Uq for patch@linaro.org; Wed, 20 Jul 2022 11:31:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBax-0002Op-Bx for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:39 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:38795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEBav-0005C4-MF for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:38 -0400 Received: by mail-wr1-x434.google.com with SMTP id e15so21376370wro.5 for ; Wed, 20 Jul 2022 08:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RnUi10H2zETr3PzFE8ItmqNkeEXhjlZHbA93aIrcRAo=; b=buCbvTCAAaAlaZ9ed247zTejvVgpevlNDasn+Hl3z+XqLYQ2abTu7Yq76RdPACiuW3 Ctoq4fgDZ51uJIXRaT2uXqr3jMdAPzDNKh1uTldCEY41ptgJKw0g2PPgMQRcSXEb/3WG 9nqStl/pJxa9LpGkzAbecS9vZGBCBnIuVylGxZxKwy6p/h2Nmd1x/Ky4klBZOq0YI8Bt LA/j2osVOrN8MaeQ6Q3vE09iRjV81NJab1Hdf9Yi0ifVFpdJhojuDuZFApPg2rpg8Ob8 /VX39HfzVZxfVv+LBALD1wDS25oYs77bQ7lbvfFiIwv1bWLryyyBL5WHx76JmDsgyoZV C/Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RnUi10H2zETr3PzFE8ItmqNkeEXhjlZHbA93aIrcRAo=; b=2WaG3vybOafsETxLkMD6XL4+mNnUREAeB1VZqBcCMPVx1mm1WBQdZwrYbk7hW1xjzP DLwoBA52jY0cioMLdJwJ+WhenWcvBoEJ1R7BvHGk8EZfqlCbgoX8ZJdBB+w/7RJegF7O Wu1k2HIdnN79QCHiqXnsoYwjAYwGAOO8d6ZryORWCJ0ddsnYncnSgMTO50hamNN8nG+G gWah1jDUhQHwEouur9DC/Xe5nEsjWVm3ZGMq1EWxh5FsjYYlCi/ltAGLG7oZJLRtJueZ cQeWrCl1+cPtmgvGisFqMjcSGCWzSXbLepyc/Sf8auaxjWPaeBowc6/ymcUy32or6xAo o3IQ== X-Gm-Message-State: AJIora9JOiFgHcHdKJhTlmsC+IDtH2dZEzHp7y29yaq2pe9BE4Rv9Oxb 41EhM4F7IRDM/86Jw6llx4AYaDrcATyuHw== X-Received: by 2002:a05:6000:2ab:b0:21e:2e68:52f4 with SMTP id l11-20020a05600002ab00b0021e2e6852f4mr7262267wry.236.1658330796445; Wed, 20 Jul 2022 08:26:36 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id r10-20020a056000014a00b0021d68a504cbsm16395987wrx.94.2022.07.20.08.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 08:26:36 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Dr. David Alan Gilbert" , Thomas Huth , Richard Henderson Subject: [PATCH 3/5] configure: Don't use bash-specific string-replacement syntax Date: Wed, 20 Jul 2022 16:26:29 +0100 Message-Id: <20220720152631.450903-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720152631.450903-1-peter.maydell@linaro.org> References: <20220720152631.450903-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, WEIRD_QUOTING=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The variable string-replacement syntax ${var/old/new} is a bashism (though it is also supported by some other shells), and for instance does not work with the NetBSD /bin/sh, which complains: ../src/configure: 687: Syntax error: Bad substitution Replace it with a more portable sed-based approach, similar to what we already do in quote_sh(). Note that shellcheck also diagnoses this: In ./configure line 687: e=${e/'\'/'\\'} ^-----------^ SC2039: In POSIX sh, string replacement is undefined. ^-- SC1003: Want to escape a single quote? echo 'This is how it'\''s done'. ^-- SC1003: Want to escape a single quote? echo 'This is how it'\''s done'. In ./configure line 688: e=${e/\"/'\"'} ^----------^ SC2039: In POSIX sh, string replacement is undefined. Fixes: 8154f5e64b0cf ("meson: Prefix each element of firmware path") Signed-off-by: Peter Maydell Tested-by: Thomas Huth --- configure | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index a56c3d921be..c05205b6085 100755 --- a/configure +++ b/configure @@ -684,9 +684,10 @@ meson_option_build_array() { IFS=: fi for e in $1; do - e=${e/'\'/'\\'} - e=${e/\"/'\"'} - printf '"""%s""",' "$e" + printf '"""' + # backslash escape any '\' and '"' characters + printf "%s" "$e" | sed -e 's/\([\"]\)/\\\1/g' + printf '""",' done) printf ']\n' } From patchwork Wed Jul 20 15:26:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 591873 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5817:0:0:0:0 with SMTP id j23csp5065357max; Wed, 20 Jul 2022 08:34:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vGVGZuAmNsJKB95M3gTDlG5EMuGEAPI0fkumvXJ/deOoL0amJPo0jAZZflrqkXrOpUOI1C X-Received: by 2002:a05:620a:600b:b0:6b5:d3bc:341d with SMTP id dw11-20020a05620a600b00b006b5d3bc341dmr16305348qkb.49.1658331259636; Wed, 20 Jul 2022 08:34:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658331259; cv=none; d=google.com; s=arc-20160816; b=kWVTgj7QtSzeAq5vmW2Z1y/vKmUlkDyzr3dY1sxyAl1MiRyZGHX9ObQwU51xUm13OI 349bm2HYd7CEWZSx+/w9apcGqTdkXfOV34TwBJ/CIhh+MZWxUTBzH22zLjhNYkDEJlui xgla98C3EHm80D/9pgn2tU0VgbEO70ZJ7uieH4r4YeIWYqUTttuhQaTORXmmrCCsh1XA YuVgkXiSgbkxMZhNX7vlhP76IySNokw4xQq3KXMDzAGxxdDL0EMNakIVI3mOP5W1nbsm boMqW7+MVWYPxMVG27LpnldynwRfQq8B3TWudTGqHphN6RpnT9FRSG3kFle99EeqCG34 A1uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=241Cj3nRc+TfIsWqH9QSLVkPEH6LQqDnk//kT3z1Vb4=; b=kC4aOGtH1wf+VmEl6FcxUxkZ9ffX7TEAu1c5BvlUlJRLAd8CSOpkVq+X2KDKPp1UOi S9tDvN/bucQL04EsozUcG9Phyrs9g+0TBAqRYfhWFRLme2zSKmFVGhdxwq1T+5n1sAnO hBlOnTUNRdCub5o2LhGNWyxok6Az8PgeatSCK1cynSV+mkfV/itSy71pgse/LBQRXl71 K60Y1qUuXpTmgrl43HTOMAI4I9XC3s/JjxAmVjXUShkqUTQh1LCuh+i3ZDt+TP/WeH/4 39CTeFX08kMFBPMXqwbbzp2EgLd07ZS5O/OcIz4uRN1+isnmGXf3pnLMLjJvNDFaH5HV yPFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="j11TT9/O"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id bv19-20020a05622a0a1300b0031ee340d1fesi5781084qtb.233.2022.07.20.08.34.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jul 2022 08:34:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="j11TT9/O"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:41434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEBiN-0001tR-9C for patch@linaro.org; Wed, 20 Jul 2022 11:34:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBay-0002RU-UQ for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:41 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:33766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEBaw-0005CM-MK for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:39 -0400 Received: by mail-wr1-x435.google.com with SMTP id h9so1545702wrm.0 for ; Wed, 20 Jul 2022 08:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=241Cj3nRc+TfIsWqH9QSLVkPEH6LQqDnk//kT3z1Vb4=; b=j11TT9/OHYcYAu68D4+6RWK/QS08SMs1gkkboplA4Suw/1+hVNqxeaklBQ2sAXh/Yd X98iGuCpZtdONu6ql9BZcyj+iBjQ909zSiiVq3x5Hyzrytcu+2niKe5ssn3/4cmW1bkO ZUrINSHoYp4DNBe830QvRJMwwmZSiPFkxOutwWH5efjPyR/pBxi0D0tD81zC85KYS/cH PVZrzwczhHo3FMy4O37NgdCDtEn5fe8lJmICwh3wzuKJ8RfMAT7PptGDjj1a2q9ayn9j fAnozdbKltm4aV/rIvZqK0Hilfh7Zdq7Q2sKWayJnvUDsY4rohF6RTvbyxLiBhsNfBJX JMrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=241Cj3nRc+TfIsWqH9QSLVkPEH6LQqDnk//kT3z1Vb4=; b=69UKGmMZ+Qfo+wQfZ7p7fJTosxNF2CziXY/X6w2knWIBmkou0sV9SiykqgfxmtUnnn N8s8uAvwVOZmfVAcsoszKWIn1eE5+RvfN1AZFkSBDMhgrIMqme5/2ajK9qzAmVzZVbUN pwrnqEIREvZpuLgYVX4qT4ogDP6KqHC8uqYQHevc/uiX90Ps6L9wakkBTXGeQowDp64W CL2XwPOMoLx6q/TYbKlusnjmrXr5/BvYi7e3hPpk5gzh8IgNJDZkL/U5Iw5d1oR4ul55 A5asqWG1rgteFxz8mFldQFKwJugEfaH518LcqEaiyPbC/nVY1hNMJwlbZAI+97leUIRd 7z3w== X-Gm-Message-State: AJIora+O5Calu+29KAv4o2QKr607AB9n9xpygVD3xf02jMz6HLpKdjFH PTMmwume1ZXcTK/z0p+fIAqWnYOb2W6L5w== X-Received: by 2002:adf:e505:0:b0:21e:5134:c7b6 with SMTP id j5-20020adfe505000000b0021e5134c7b6mr211923wrm.159.1658330797373; Wed, 20 Jul 2022 08:26:37 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id r10-20020a056000014a00b0021d68a504cbsm16395987wrx.94.2022.07.20.08.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 08:26:37 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Dr. David Alan Gilbert" , Thomas Huth , Richard Henderson Subject: [PATCH 4/5] configure: Drop dead code attempting to use -msmall-data on alpha hosts Date: Wed, 20 Jul 2022 16:26:30 +0100 Message-Id: <20220720152631.450903-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720152631.450903-1-peter.maydell@linaro.org> References: <20220720152631.450903-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" In commit 823eb013452e93d we moved the setting of ARCH from configure to meson.build, but we accidentally left behind one attempt to use $ARCH in configure, which was trying to add -msmall-data to the compiler flags on Alpha hosts. Since ARCH is now never set, the test always fails and we never add the flag. There isn't actually any need to use this compiler flag on Alpha: the original intent was that it would allow us to simplify our TCG codegen on that platform, but we never actually made the TCG changes that would rely on -msmall-data. Drop the effectively-dead code from configure, as we don't need it. This was spotted by shellcheck: In ./configure line 2254: case "$ARCH" in ^---^ SC2153: Possible misspelling: ARCH may not be assigned, but arch is. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth --- configure | 7 ------- 1 file changed, 7 deletions(-) diff --git a/configure b/configure index c05205b6085..d0e9a51462e 100755 --- a/configure +++ b/configure @@ -2251,13 +2251,6 @@ if test "$fortify_source" = "yes" ; then QEMU_CFLAGS="-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $QEMU_CFLAGS" fi -case "$ARCH" in -alpha) - # Ensure there's only a single GP - QEMU_CFLAGS="-msmall-data $QEMU_CFLAGS" -;; -esac - if test "$have_asan" = "yes"; then QEMU_CFLAGS="-fsanitize=address $QEMU_CFLAGS" QEMU_LDFLAGS="-fsanitize=address $QEMU_LDFLAGS" From patchwork Wed Jul 20 15:26:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 591872 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:5817:0:0:0:0 with SMTP id j23csp5062487max; Wed, 20 Jul 2022 08:31:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uCCESk+Yu7qXXEAky55UNQVJpmuCa+Js7bwKrlAuUNErDUEtxrya4IUgDILmoF8FgkWsp/ X-Received: by 2002:a05:622a:613:b0:31e:f64a:6d88 with SMTP id z19-20020a05622a061300b0031ef64a6d88mr9709929qta.321.1658331085778; Wed, 20 Jul 2022 08:31:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658331085; cv=none; d=google.com; s=arc-20160816; b=M+XIOWM6WATTQGo8NwzcD0lbqOAO4YDaRat8FjV4MMz+gcm5xoSm9QDEEQh/qWEZ9P ThSn8ri6/z7Q7lCrI24aIS9PNe9c+HIOIjV7fL0WKEJc68M6mnNCSV1BRFqfG9LnFZCq TdQE0pZWNGM8Qr7UnW2FrylEje4EaI/otdTBormRXlQs3aw45nZfwsYzC45Vl+HVk4dH /pKLhI1iE4uOpwcHmuonppq4gWnnqyrDeotN81E8ZldUuxJcL7UHCMxW5GSCSkfA2kts wKctMwUUnvw3fDQfg3ig3a2aW4vZ7eGWMq6tTzpD8CyvpY3Spi/oAoAV0M57zmZnd3Gc i+lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=j7LZZeIQ/sz4HsnzuYWBDPxebi7JrS8w/X6Vb6vFc3U=; b=SijRoliAUAC8zo++WrnjOC3L089IK9Dt8dQyUnaVo61hUIEsgWGLWcrgMWVviS5cVa F4QylYgaCyNb7ri4qbY5f2b7bVzqatl9Cy0hkpqFzkeG0TYdXRTrE9QlrnXze1CnQ6DZ CrueODLAyKEWcQ1WpxluslQjE4gsyMZtBd/eYoyFadWWHpb7Q+0QHe+mqYj6KRA/SJwz xaJa0uK2pEiT/cVPkY5h8ET9m3YugXUKBjEZb94H8P7nTs1dLIF/k2xAJX7LO/NYvCZ+ G53PeM4OYQUUmIFKTnpYzg/e1Xsse04sZIQ/4uuNbqemlhjRPpQjf4ylg0IYd+6z/6Q5 +tsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ErKAfFUW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ee28-20020a05620a801c00b006b5ead97164si4266410qkb.599.2022.07.20.08.31.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Jul 2022 08:31:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ErKAfFUW; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEBfZ-0007BN-CI for patch@linaro.org; Wed, 20 Jul 2022 11:31:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEBay-0002RV-Ub for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:41 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:45829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEBaw-0005Bm-U9 for qemu-devel@nongnu.org; Wed, 20 Jul 2022 11:26:40 -0400 Received: by mail-wr1-x434.google.com with SMTP id a5so26589235wrx.12 for ; Wed, 20 Jul 2022 08:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j7LZZeIQ/sz4HsnzuYWBDPxebi7JrS8w/X6Vb6vFc3U=; b=ErKAfFUWDaFCW5fEZnWlNYDlVBJeFN6C9yxL139Usz3TFEmR79m/iTMU/Ew93YKLU0 fg+7TDSGSfEd5jdUKiP5UQKPrrwMtvBJiOYA0yutTZWzYpRqIjvrJSJ9en9guJgwdR/J CZHj48xwmWuKtXYSbnKCc/L8zfjpUu3K/Xla4FLTl/qm9fkPEEnmLSeC9Q1IqWpIoi8E 0kMS/jpHIhXIdjIQEC2qTOtvu8+ROVMYk7XkU2bJxuiodTn92CE1RSn2Zxge+i4knHn4 +PxaYYciY5Wk8dlfJPeUbQGuGXjKMjVJ4PbIWfbg48sQka9WkWxNGVOBXOap6PT9otJs hnpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j7LZZeIQ/sz4HsnzuYWBDPxebi7JrS8w/X6Vb6vFc3U=; b=378sgKU2w+AFh7kORiWV+ZsE4pnUVFDSZFaBABqc6r/Wf0cVpXWIiQT1OjucwBtJSV x+CpSGB+/ocoyS/A+B/PybWZOFgix0YKPpTnTRhPjEMcC+KIc+4LUJ0TkHEIDcRYo5BJ W7nqId+bxzOsdTgiwTpewYrrmPZ7TKkSBS00wvRseN+wg+Xk49PfFTBZXZgyJoVcoWrI HMLrQdBsXSYNXYUEtdIRbbv03V1MIxYKAXVn/cOP9xC0vv3SgWJQvLE/EMxsngdpMC+5 sIwP2biQkC5Ms43qRcPC6AWbXXv5b7OYw1R23lWJzR262uXCLlKifJj0XQZRWKLPlNFC JDBA== X-Gm-Message-State: AJIora+oJF5UWPG0NwrB0gQcPqbJgu4gK+4HRqXEIeJ7WrtYCxYi8tJs rAmE8izKX9XmyZ/jXXQhWDFHuYQVD0e1Cg== X-Received: by 2002:a5d:64c2:0:b0:21e:2e1b:d031 with SMTP id f2-20020a5d64c2000000b0021e2e1bd031mr7421595wri.8.1658330798265; Wed, 20 Jul 2022 08:26:38 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id r10-20020a056000014a00b0021d68a504cbsm16395987wrx.94.2022.07.20.08.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jul 2022 08:26:37 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Paolo Bonzini , "Dr. David Alan Gilbert" , Thomas Huth , Richard Henderson Subject: [PATCH 5/5] configure: Avoid '==' bashism Date: Wed, 20 Jul 2022 16:26:31 +0100 Message-Id: <20220720152631.450903-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720152631.450903-1-peter.maydell@linaro.org> References: <20220720152631.450903-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The '==' operator to test is a bashism; the standard way to copmare strings is '='. This causes dash to complain: ../../configure: 681: test: linux: unexpected operator Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d0e9a51462e..2c19329d58c 100755 --- a/configure +++ b/configure @@ -678,7 +678,7 @@ werror="" meson_option_build_array() { printf '[' - (if test "$targetos" == windows; then + (if test "$targetos" = windows; then IFS=\; else IFS=: