From patchwork Wed Aug 17 13:03:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597908 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE428C25B08 for ; Wed, 17 Aug 2022 13:04:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239394AbiHQNED (ORCPT ); Wed, 17 Aug 2022 09:04:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239539AbiHQNEC (ORCPT ); Wed, 17 Aug 2022 09:04:02 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D9BD31DC6 for ; Wed, 17 Aug 2022 06:03:54 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id v2so18920151lfi.6 for ; Wed, 17 Aug 2022 06:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Fu31UHcZ2LXLoLqG8lQtW1W1v+mxTPYhVi9HdleMdto=; b=Al0HfpTRNiVmLf1Ltv8H0kEaWM7RlsrinxpJ/BmAgcypfuG50URpD03yiHWeC6n7q0 0/RXgYGGpwDEvcW3gNu1qhAcdV10k8HQ/lt62yZQafuNb5766KLrU+p2+Y4cRktx/OFj so4P5dgfGKHJhagKPR0s+kmuFFP4P11CCWE3pnO57irtvZ5t/BbGx4tEVk24PSbDl24A 1Ghil/Vj3TKnPtdxIpegAJjo+/EbAdD/aVN05TIT40PX1nRyTU++UvuHZwifYcOTkY35 lXy07XAL+UJ/AqM1Y+tPCjzrZdf9RgnY8z5tocPvLqtRHtdmQWaMYymeQvDyHQzn3Lzu +9+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Fu31UHcZ2LXLoLqG8lQtW1W1v+mxTPYhVi9HdleMdto=; b=U0atAD1YWomJvFFS5QEnqErcOMwkX4HuIk9foWXBydeiLmCSdBsv6cmBecbZFY8cun kmYVx2iUota8hnE+atTYqcSU/HbxqeIxQAcywTsjJRlsvy4b7Ql8Q7S8VvXnUTRWbzGl HSWWNouhYplwAgHZBDBCTWuFSsCDgNhUFL6HYQ36V4o0OmHU7Cu/3tZaYcvHsfVuFIYl EfRQNU+IB640gzTRw6N79Eaf1Y7xvzyyHI/2o78gck208m0FotOh88BDj0LAi/mAjSxU OUK0bM0W5NkJtjXrXMFOxgIzEBncIwk3OfI/0JCV9+E8nxd6UU4AV2nCCyRsQVfBJ+Gt ZtKw== X-Gm-Message-State: ACgBeo1ttKw9+Tn/68ot34ALYyB3kgSaTJStBLzAvQOJdO+a+sYkKe3k 3mzL133GQ4WIxQ/tMGv3ScrE1w== X-Google-Smtp-Source: AA6agR4hselVCr5xeWZ6GrhELl9ZY9rOaufFtQoKburwlVDxbLqKVXqrVxlc9YkN1yPuXZkskihE7g== X-Received: by 2002:a05:6512:2243:b0:48b:2746:314d with SMTP id i3-20020a056512224300b0048b2746314dmr9429439lfu.392.1660741432396; Wed, 17 Aug 2022 06:03:52 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:51 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 01/14] dt-bindings: mfd: qcom,tcsr: add SC7x80, SDM845 and MSM8996/8 Date: Wed, 17 Aug 2022 16:03:29 +0300 Message-Id: <20220817130342.568396-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Document existing (MSM8996, SC7280) and new compatibles for TCSR syscon registers. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Correct order of compatibles. --- Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml index 2f816fd0c9ec..e1c4936a0352 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml @@ -18,6 +18,10 @@ properties: oneOf: - items: - enum: + - qcom,msm8998-tcsr + - qcom,sc7180-tcsr + - qcom,sc7280-tcsr + - qcom,sdm845-tcsr - qcom,tcsr-apq8064 - qcom,tcsr-apq8084 - qcom,tcsr-ipq8064 @@ -27,6 +31,7 @@ properties: - qcom,tcsr-msm8953 - qcom,tcsr-msm8960 - qcom,tcsr-msm8974 + - qcom,tcsr-msm8996 - const: syscon - items: - const: qcom,tcsr-ipq6018 From patchwork Wed Aug 17 13:03:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598200 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0D67C25B08 for ; Wed, 17 Aug 2022 13:04:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239551AbiHQNEJ (ORCPT ); Wed, 17 Aug 2022 09:04:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239548AbiHQNED (ORCPT ); Wed, 17 Aug 2022 09:04:03 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3407E32073 for ; Wed, 17 Aug 2022 06:03:56 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id w5so18925026lfq.5 for ; Wed, 17 Aug 2022 06:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=7xLpyvjcjxtFjBdq2TnMTpFX2axCPt8X9rBvt8vK73g=; b=PjUVTMLZrPosGW6XmepHlPO6eBG33wbigvyDIhLQxGCe0t0HNYb7qqhQRzDUb6WSUd 8Ix9XRC/u8xSK0VB2AfHrZNUZHgAdte+McfWQyJ+xGlUDAbzhIJqfxQgAOoDufNrsvGG lo3x89xgK1BBxmfSYHfrCNe/byq3/pfDGz3MH5mG2jHsd/zD6vMbeg6ljVZnzE23unAa 67DtmM3ZT+/PA7L/5Y5fXlcsT9JWh28VvfIwpSGdJm1/iUlX+mW0PidIsjXTl1pZV7Ys vLNq56vARazX3rlDUN3+hf4VqRjQV2kFkRKG09tIQrjmB4ag9j/J9rj/E6M03fUzbvee K0Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=7xLpyvjcjxtFjBdq2TnMTpFX2axCPt8X9rBvt8vK73g=; b=1L7RspAXxd/LYqGA5YUa0xIoI6Wf4wPGqcu1Js81mQuneMFkQmieF8pLzBgU8tDyCe 1CjcAK2bvJEjAo8kqAO6FXMs+O5HzSo13E8SGXV8XM35nFunzK6J+UQqFuF8yEA9+mEM 6QCxl7q6dufV2vCsSwZQJW7PGE01lJz6SNFKB5uhmMZBztuuyZ43xXsf821U/z9XeIKp 8jIATyLPEu1r0W+vNKFve5knj8+jmbqxGL6BavLIR/3EXdYrTOJbhRgtPS6zxNsgQTAA 6U5kOScEVUVEvyK5+RW2t5Gz98A11hiM+fXs5b2QlZJtNvoGoFKaJpw6L7jVr1iuC05X M78g== X-Gm-Message-State: ACgBeo3PN1U/4p/wW33Veq4/AG6v9VX+BF8HDb3RUrLTJ20qL+4vHFTS z+jrZRS050sFWf97pTczXOFn+g== X-Google-Smtp-Source: AA6agR7Zzblj4Xlxub0k83AuZvMCqpVVbNxPphlAI3oTNPmKajhVKPj/RJ1GaeWLs5yQwv1ptA1tfA== X-Received: by 2002:a05:6512:1392:b0:48d:a6b7:caff with SMTP id p18-20020a056512139200b0048da6b7caffmr9229978lfa.154.1660741433664; Wed, 17 Aug 2022 06:03:53 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:53 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 02/14] arm64: dts: qcom: msm8996: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:30 +0300 Message-Id: <20220817130342.568396-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 742eac4ce9b3..3411ced96db6 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -359,7 +359,7 @@ opp-2150400000 { firmware { scm { compatible = "qcom,scm-msm8996", "qcom,scm"; - qcom,dload-mode = <&tcsr 0x13000>; + qcom,dload-mode = <&tcsr_2 0x13000>; }; }; @@ -840,10 +840,15 @@ pnoc: interconnect@5c0000 { tcsr_mutex_regs: syscon@740000 { compatible = "syscon"; - reg = <0x00740000 0x40000>; + reg = <0x00740000 0x20000>; }; - tcsr: syscon@7a0000 { + tcsr_1: sycon@760000 { + compatible = "qcom,tcsr-msm8996", "syscon"; + reg = <0x00760000 0x20000>; + }; + + tcsr_2: syscon@7a0000 { compatible = "qcom,tcsr-msm8996", "syscon"; reg = <0x007a0000 0x18000>; }; @@ -2413,7 +2418,7 @@ mss_pil: remoteproc@2080000 { qcom,smem-states = <&mpss_smp2p_out 0>; qcom,smem-state-names = "stop"; - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs = <&tcsr_1 0x3000 0x5000 0x4000>; status = "disabled"; From patchwork Wed Aug 17 13:03:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB36C25B08 for ; Wed, 17 Aug 2022 13:04:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239590AbiHQNEX (ORCPT ); Wed, 17 Aug 2022 09:04:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239569AbiHQNEI (ORCPT ); Wed, 17 Aug 2022 09:04:08 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CEEC3336A for ; Wed, 17 Aug 2022 06:03:57 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id c28so14872327lfh.3 for ; Wed, 17 Aug 2022 06:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DmgjoU3ZwmShD+iuLbm/N6H6WPhywoNwmKzID5e5568=; b=dOoNqvye8xquk0IPEbhQhqui+Qtl+FwGe6xO/9UzbcZeyzno5z0sjyTEDevwNPNzZI LxmTr+GSKl1380Nz1jq42Qouq+iXDy1mDR+N3uPjd0W7UCAgLQN985quLi+FE7hVk+GE jIOzlHwbLSvijTeh7RfHxO8wXCvrMeaUH0cSa2DTcQM3FToaO4IQGyySLej/+PqUnekK z3KGXi8UOxo7kxFjMnJDvEHVn1MzXQKy0Tjd5tizb1D+yQb3y43/Id+I2AtklPjn3em3 2YbAQ2xzosOaW+DZHq4Y+HSSmZHaOwRL9vwIfsTzbjRJFJqWCB0X0cgYrHX9voJqMhqz OMVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DmgjoU3ZwmShD+iuLbm/N6H6WPhywoNwmKzID5e5568=; b=nRvtk2+9trzMH3n90b42ISWe3//ajYZqhRKiCkDdZ4zxKVHIkyvSSfxGg+80EEAQUc Z7wR5S5IrqZlS1yLVtW3DAhHVaj0NbiyAPCAFf6Ls5xoGfjzFuVmqfUkPhzwxopvcNf6 /BGmoyQLIweMmpbkpPd7CIxLYi+RvL+YN0MixQsaMnw/681+NhpF3CMXTMat/X0tFGec eL3yOO5nTY70nU+RKzC06f8NulwsZ9hJzG3mHFsnA0sELReu0DUlPgbOMLljamgy41K8 RdehSOYTPnJepSgWFCnqhBTvTR3huTDYFaH0qIct5268uUfabYqIilNblYhrxwE9xVFs nVGQ== X-Gm-Message-State: ACgBeo3MBo8guTYCZ8P2KtwM911U45gnePprc9F5euPbS0eGJBMYla8R Z200PTQZZrCqonBlahhvlOsAyQ== X-Google-Smtp-Source: AA6agR6lqDxgMK9JFImwUaoMuhNueyu4AJdfFEi+SBN7qOkfEFKxa/ji1nEoI+8vSCoCDkGlSQ3nRw== X-Received: by 2002:a05:6512:b89:b0:490:34f9:d1c6 with SMTP id b9-20020a0565120b8900b0049034f9d1c6mr8336696lfv.637.1660741434903; Wed, 17 Aug 2022 06:03:54 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:54 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 03/14] arm64: dts: qcom: msm8996: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:31 +0300 Message-Id: <20220817130342.568396-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'reg' is a required property qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 3411ced96db6..166374566a49 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -363,12 +363,6 @@ scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - memory@80000000 { device_type = "memory"; /* We expect the bootloader to fill in the reg */ @@ -838,9 +832,10 @@ pnoc: interconnect@5c0000 { <&rpmcc RPM_SMD_PCNOC_A_CLK>; }; - tcsr_mutex_regs: syscon@740000 { - compatible = "syscon"; + tcsr_mutex: hwlock@740000 { + compatible = "qcom,tcsr-mutex"; reg = <0x00740000 0x20000>; + #hwlock-cells = <1>; }; tcsr_1: sycon@760000 { From patchwork Wed Aug 17 13:03:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597906 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67FEEC28B2B for ; Wed, 17 Aug 2022 13:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239179AbiHQNEj (ORCPT ); Wed, 17 Aug 2022 09:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235930AbiHQNEL (ORCPT ); Wed, 17 Aug 2022 09:04:11 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94C9533A23 for ; Wed, 17 Aug 2022 06:03:58 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id v2so18920372lfi.6 for ; Wed, 17 Aug 2022 06:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=d81NAUVI3O6mHh9rRCLTkzFGlVQOgUX55hJVWZukNlg=; b=GIFpL+ATcIDKagtSP6rDHeoCcOFWWr/pW8xkg67OgOzuXkmqjQa8TAsgP6d8MPQ7jj qqJg+WFqfoF+EwMmJsCVZ1wXIL63HQvJYQmoIZn7t1jBMG+cTbuPHPOJ0a8Bf2UVJGzD P5FoLeWgBjexMccdTDJuh25nyvBuLT1QXHSP7X/h0SuDotdAC8jOh6Di97NbFpclUJVV eOUj3TyiIrOTofGk3sreML2YYY2+FPy4vDkZFPCARSTHOPYU9qtFFP3LkYk7cm0PBzv4 Qh4wFSS3FtUEZr8xfTPHbwtEgb07HMGEZC6I88DQVM9f1zSED1+cWnM0w54Cza6uW+TQ +/3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=d81NAUVI3O6mHh9rRCLTkzFGlVQOgUX55hJVWZukNlg=; b=Va1unFMWWxZFZIwae/NojkD8J0PKiaEcX6D7P4BgW1qTeOvoSaZvMhc16kuVMoJje5 u8N5zYFWyFsz8R2m/fLrkCSvch/5zHSEpKdX/h9zxF3CcGhLf8gZYn7Wy70c9kpMEA6x f+U1CTNWv8D3+N8hYwtd+QvkAcVdEP/Xdi3Glqgmtz6U8xusC2SOMwKLwGMjWaJnNzwW GSnuPZD1T8dQ2Z/AZO24J26Kw392HAfSE2HLPK6NHCqLBemNKZ8EttnuqlUjKH30BVv2 qL/bz3rNPIyaSKhKhxxGQaGwM20wmdoHKg3w0ZiCEe1Fd/srWUxWrRbjhM7GJXVxa4Cv sl6w== X-Gm-Message-State: ACgBeo36pFutKRqng9XCrBiaN1O1ge3Nffs5xXK3EJcIY+SwsOEdnF6S fbF8XV/eZHtjBRzwQTzyt+T2tw== X-Google-Smtp-Source: AA6agR6s5ElWmktazefBCvNFDDnaenAXi9o0z1jq4dXZQKKmJoPORPpgt5EBridafrYMiKy9WM5w0A== X-Received: by 2002:a05:6512:ac7:b0:491:571c:3ef5 with SMTP id n7-20020a0565120ac700b00491571c3ef5mr7149067lfu.2.1660741436156; Wed, 17 Aug 2022 06:03:56 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:55 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 04/14] arm64: dts: qcom: msm8998: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:32 +0300 Message-Id: <20220817130342.568396-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 02d21bff2198..f0806ed103f1 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1049,7 +1049,12 @@ ufsphy_lanes: phy@1da7400 { tcsr_mutex_regs: syscon@1f40000 { compatible = "syscon"; - reg = <0x01f40000 0x40000>; + reg = <0x01f40000 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible = "qcom,msm8998-tcsr", "syscon"; + reg = <0x01f60000 0x20000>; }; tlmm: pinctrl@3400000 { @@ -1340,7 +1345,7 @@ remoteproc_mss: remoteproc@4080000 { resets = <&gcc GCC_MSS_RESTART>; reset-names = "mss_restart"; - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>; power-domains = <&rpmpd MSM8998_VDDCX>, <&rpmpd MSM8998_VDDMX>; From patchwork Wed Aug 17 13:03:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598199 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28126C25B08 for ; Wed, 17 Aug 2022 13:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239577AbiHQNEj (ORCPT ); Wed, 17 Aug 2022 09:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239576AbiHQNEJ (ORCPT ); Wed, 17 Aug 2022 09:04:09 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7607D356C6 for ; Wed, 17 Aug 2022 06:03:59 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id s7so320114lfp.8 for ; Wed, 17 Aug 2022 06:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Oc1vz9/DWeA4ULM94yDKxE44YQvZ9a9JuzHX3olMNuY=; b=Fc9cabtFx1GJRo4qrTB1EhBZ7hgujc16iVvpb3ePFvG7T1vcX0scRoIps3RRq8NtN+ DL6+dWYcEg3ceKPL2PyTfkrMrW1SnWrgfKi3fyBxqQjjZzjSS/31qwzITB7Df7Dhf6V1 jIO9+VNh21NxuM8sc/hm5JRWUda/hlXtfMpr9CR4EDsrV9pG3PNHnMx9KWtGtZW46dbh ofza/0xET9r3x2cneAdfuR9tA7Q0UMH93VnLod/yHIxs4Imeb62+0unZImweenPvGxxh wIVPnk+/pg495RSGZVTs83+E4KUJnlf5RgrpmMRt6eHsW5C48azxrN/PtQHpd82+WvyS lnhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Oc1vz9/DWeA4ULM94yDKxE44YQvZ9a9JuzHX3olMNuY=; b=UYu2MKrSN0aZHUkW8U/L20X4sITZPMhDGk0S7EhRHYKfx++3jqiGbGJ/ABEvyjphiN hKayHBxcDWG3n4F6u1pHEcGs5AdGWKUxaRc0ildo5CITV9/l77i1nJEad4fNk83xzfto rPaInz5MBUdq2pIrlVuZA8BePXw2yAPxYHZh8FZh/xj8qiScPj4oGrBxyFmzdbeSzBup 8KXfVJK0JgodSECuqrf5fBlPf23LyX7ZSwFJrV394L95exRPzBygPiWQsngkz2wJ8ylp pTjVzjqYYWqZByoKw22Htoqv4YHY+HNATuq78qJ15PQEH0DwKodM5WektzkfLQiXiWLj QFlQ== X-Gm-Message-State: ACgBeo3jaRpGiKa+ij/Vy5DvxJqEeHch2eQpJ4tCLUtdKLH0K3+PJ3oc cjQk5WvBFgaCbOnnxdjCt2yAAA== X-Google-Smtp-Source: AA6agR6S9efhZzy0qbQxF1CplVeckdK+xn7G3qkjrDJjItBPaU5fJX7F/Rpvq3DguQqr5p/Ke3w0Fw== X-Received: by 2002:ac2:4c42:0:b0:482:cb18:25ac with SMTP id o2-20020ac24c42000000b00482cb1825acmr9289923lfk.643.1660741437470; Wed, 17 Aug 2022 06:03:57 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:57 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 05/14] arm64: dts: qcom: msm8998: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:33 +0300 Message-Id: <20220817130342.568396-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'reg' is a required property qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index f0806ed103f1..22b2da74d105 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -308,12 +308,6 @@ scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - psci { compatible = "arm,psci-1.0"; method = "smc"; @@ -1047,9 +1041,10 @@ ufsphy_lanes: phy@1da7400 { }; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; reg = <0x01f40000 0x20000>; + #hwlock-cells = <1>; }; tcsr_regs_1: sycon@1f60000 { From patchwork Wed Aug 17 13:03:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598198 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E2AC32789 for ; Wed, 17 Aug 2022 13:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239285AbiHQNEn (ORCPT ); Wed, 17 Aug 2022 09:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239427AbiHQNES (ORCPT ); Wed, 17 Aug 2022 09:04:18 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D36D22B26D for ; Wed, 17 Aug 2022 06:04:00 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id s7so320184lfp.8 for ; Wed, 17 Aug 2022 06:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=vdE5nDV3qdB6mAn0Qwup5zvvjj6Xy+e1DVZdaTpFju4=; b=hbL4Mc0yVll+ohqUSOFIwI5UQgyQ9IAczH/skLzCKCFgstC9xHSqgdFyDWs7reUdHA py4cQCracHpGd4bYfZ0lgsS9wLGJdciW1hzyKhGcnWCu2/9UlYGesp0IEgN9C8tncS8Y dxonBj6qBS7Vz8Cp+xTxTpSsbwpqFzrIXjvVfZorMq9oNOCZM/J9jFsVw3znpTCYiuAC KUCVMRMrFzTTuRxiDuPcbm7GSxOGl0OIDunh8ts6tKX0uaPXBO6LGndw0D/1n8EHReTk dAcszMMKzUYHlaIvY/XO/HWPTkQCLU1FMFyw6qAopt9rrFTVQ4YiRk50/2YeRsqZIUav 9ytA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=vdE5nDV3qdB6mAn0Qwup5zvvjj6Xy+e1DVZdaTpFju4=; b=gSktzFOKpKbtuWyPZ1IVX2+xnhDEHuFzX6NPz+HbCyR4LIQ7PPn91+3ohAVW8wHEHA 8H3TG0tvs6or7Hj8zsgo8kpypIsmCzdVA6gpZ5Q7QC5F3meTIPc1UC8RZZ8KNFmAZkzA qVIczF9ZHwGzvscqkpRNVJo604WG4cdpsrWv3pbWPSKTY/oIUyCi8PSCdi7+iuaHfEen O56KcSrgObf4gXThYEozWVigcDdOCcpeMAbK26nd9XW+coA0w3hj033BOaj6eFmfcY6s mFibJRvKBHwFerkGTedy7a1O/FWHjo9TrbaP6PpZ1nb06sS7Sw92NS023+k1QjYb/ZB+ LVig== X-Gm-Message-State: ACgBeo0zvblphMgMd8Rn1PiXq5w25PE6hy57fSIY449OYOlCzQfQSGMy 0wFiuxDtPBemC+AvUErmZ4apKQ== X-Google-Smtp-Source: AA6agR4TcR6MepQivrVzkp+HkVxK5fgE0thyMcGv9meclAUouUUgdAshS0KF0s85NEVvW9ZPsqBjrg== X-Received: by 2002:a05:6512:2248:b0:48a:f36a:2e63 with SMTP id i8-20020a056512224800b0048af36a2e63mr9118402lfu.485.1660741438859; Wed, 17 Aug 2022 06:03:58 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:58 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 06/14] arm64: dts: qcom: sc7180: add missing TCSR syscon compatible Date: Wed, 17 Aug 2022 16:03:34 +0300 Message-Id: <20220817130342.568396-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org TCSR syscon node should come with dedicated compatible. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index b82c335c25af..49f28cb531f6 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1468,7 +1468,7 @@ tcsr_mutex_regs: syscon@1f40000 { }; tcsr_regs: syscon@1fc0000 { - compatible = "syscon"; + compatible = "qcom,sc7180-tcsr", "syscon"; reg = <0 0x01fc0000 0 0x40000>; }; From patchwork Wed Aug 17 13:03:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54024C28B2B for ; Wed, 17 Aug 2022 13:05:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239539AbiHQNFg (ORCPT ); Wed, 17 Aug 2022 09:05:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239623AbiHQNEj (ORCPT ); Wed, 17 Aug 2022 09:04:39 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9F5331ECE for ; Wed, 17 Aug 2022 06:04:02 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id w5so18925355lfq.5 for ; Wed, 17 Aug 2022 06:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DL4opHqld4qCjVSblJBLt63Edv/Ob11xgTM5Drh1lj4=; b=mNTk2jWW7BPZjsiEHfFstCuM03Z30YRzcwqNDvf/vgliYt5PJjHCdjedZ+SToXIRi1 sMUhVGl5i3ltCiHJ4kGNgmqP7Cqp3AdkLTMGt/3LKf1trh0Ony5/9dH9XTKlupZg1eiI UFC9Xsg9KnPjRxygmsSH8m68tLKFF8sY2coFuxxluWZ590HSpEfOJYBsIEcgd8yFfO21 nRcN3f786/KZ15r8BiuM6AxltTSECW1FuYLJuNUW9CHDZYLRFkEs7wqjOb5EeDEKKmut dytda06RcSu8K8/p98yeSQIt7MCtton95J1mk38ntwftc+RjJIvHe58ZQF+OxDj/4Yqh Vnqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DL4opHqld4qCjVSblJBLt63Edv/Ob11xgTM5Drh1lj4=; b=GwUfFbAZfzG9nCI+ruyR0KhKPsqEDkCNVV6yO9HCmQ2rWYJTkxXl5mFhjg51s/KVVE 0daNPJKDzvnmYFXEO45weKX4MIO2dfOrZAJL2i4I0U4XiBz25jG29OlivUUBuV4HZv5x If7nV0k4a0lfNj07i8AFGi6WFeEYK6NGmQX61ij620BPLIWUmttWi4H1EMF8zQkhJj9Q 5VU3MsdtH9uBqdZrr3hY15J0sd1aTiXrpkPUcjTY36hASvpDlGmxR7ZL94dzmrADtqFe 09O4S5ROmKA+oAms8W9IpqngG66yH/eef/T+oRyzNvz9pGtUdMa8b2DuR3wuYAWvEsmA itDw== X-Gm-Message-State: ACgBeo0KSG9sBZreMKSZnkuZE9zoSZkbBbCHh5mgxR4JbQdESC+Y/TXj RQPpJGAweGv7RMkkBnwWuDVCfw== X-Google-Smtp-Source: AA6agR6+V//N5hqRVIChR7d/APwjJuKhzsEbiuHog+4LSACfqRJoz/zZzCw0gJU//JJ6cDsz8a/CSQ== X-Received: by 2002:a05:6512:3501:b0:48b:205f:91a2 with SMTP id h1-20020a056512350100b0048b205f91a2mr8569143lfs.83.1660741440168; Wed, 17 Aug 2022 06:04:00 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:59 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 07/14] arm64: dts: qcom: sc7180: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:35 +0300 Message-Id: <20220817130342.568396-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 49f28cb531f6..5d2dd21da79c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1464,10 +1464,15 @@ ipa: ipa@1e40000 { tcsr_mutex_regs: syscon@1f40000 { compatible = "syscon"; - reg = <0 0x01f40000 0 0x40000>; + reg = <0 0x01f40000 0 0x20000>; }; - tcsr_regs: syscon@1fc0000 { + tcsr_regs_1: sycon@1f60000 { + compatible = "qcom,sc7180-tcsr", "syscon"; + reg = <0 0x01f60000 0 0x20000>; + }; + + tcsr_regs_2: syscon@1fc0000 { compatible = "qcom,sc7180-tcsr", "syscon"; reg = <0 0x01fc0000 0 0x40000>; }; @@ -1932,8 +1937,8 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names = "mss_restart", "pdc_reset"; - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; - qcom,spare-regs = <&tcsr_regs 0xb3e4>; + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>; + qcom,spare-regs = <&tcsr_regs_2 0xb3e4>; status = "disabled"; From patchwork Wed Aug 17 13:03:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14767C32774 for ; Wed, 17 Aug 2022 13:04:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239638AbiHQNEl (ORCPT ); Wed, 17 Aug 2022 09:04:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239586AbiHQNES (ORCPT ); Wed, 17 Aug 2022 09:04:18 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA58C39B8C for ; Wed, 17 Aug 2022 06:04:03 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id by6so13476130ljb.11 for ; Wed, 17 Aug 2022 06:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DbSnvFkY9bvjJ+mlDkzyxC4/7mNnK/XqOObaGJH93/Q=; b=DCXz4XYINVpHYEIMfmn91NIOhMiYQDX8amq9srJMdlyklU16yHc0GsXqp2R3vAsKJZ eUB89uRwZgzbpTbLUfup3FuESytUkTEjOH2ayHi4YSEzShHbWCVJ4+X3PT+oafCwmYB/ w0tSfdgooKQUQ2gx3jPmG9jWPs6PKYP1ZARpXJFdmbFKEFcEYjBb6u9YAajQNjGLnSZA mnQ7Tjl/jv0Ik6KktCuqWEmL+gsgPWIlw408Wgh3vOMdanfSEJwJkpvXmlgDMaYKQpcu BQpqJN1KtIfU1armkcIxH0uN2kfHw3oNmSo0ZTTR5I2OCXpWsbnco54oomjKkiLzqYw1 c4tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DbSnvFkY9bvjJ+mlDkzyxC4/7mNnK/XqOObaGJH93/Q=; b=DNhHiWQLYKEOe9kIQoNLJypAI3FQlS9JVRn0SRZHB50A774BxFyPZxFYENWXoQFY5L p4+GVSxiCUNtW+Wz/UOsZkoledVHDRQHUn3TQzoFwokO3PsSeCOuG13QymTIVue+Vv4x 7Pm0keytuoXnMENtzSZcYJXjNot6LNngHBoqDhts/nVgcVxCo47Y3kjDrvgaeS/1aR2k /p8OUpdEcYRgLRZucoK9xUZ+7yqGQupq+Q1yi/zRmHFzqZvLVghef3ZY5gpksF7veVNe Jh9LnbFXE8H3CO447XYNgOG/7ZkeJey1UiUGsymIx5KJHTxvyvWf2AlsGy3OqoNAEVRf wt5g== X-Gm-Message-State: ACgBeo1zMfqO+FKHC8luly576OoyFM0+hzm+b6d20uCO6UOf6UNl6p4q g/uYlWDuKbrgAkYybABT/2iTZhSvvHMNa7MZ X-Google-Smtp-Source: AA6agR6LJukHMCtjGeJCKZ10+lfXnY0NJek6O2mC9zKYYS73f8w/yuUFVBQrcBJuS3faugWXHdjczA== X-Received: by 2002:a2e:bf11:0:b0:261:9343:fb2 with SMTP id c17-20020a2ebf11000000b0026193430fb2mr3084063ljr.47.1660741441473; Wed, 17 Aug 2022 06:04:01 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:01 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 08/14] arm64: dts: qcom: sc7180: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:36 +0300 Message-Id: <20220817130342.568396-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'reg' is a required property qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 5d2dd21da79c..e8debb0da411 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -555,12 +555,6 @@ scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - smem { compatible = "qcom,smem"; memory-region = <&smem_mem>; @@ -1462,9 +1456,10 @@ ipa: ipa@1e40000 { status = "disabled"; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; reg = <0 0x01f40000 0 0x20000>; + #hwlock-cells = <1>; }; tcsr_regs_1: sycon@1f60000 { From patchwork Wed Aug 17 13:03:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 605BDC25B08 for ; Wed, 17 Aug 2022 13:04:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239665AbiHQNEv (ORCPT ); Wed, 17 Aug 2022 09:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239598AbiHQNE1 (ORCPT ); Wed, 17 Aug 2022 09:04:27 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FC9E3B978 for ; Wed, 17 Aug 2022 06:04:04 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id l21so13509012ljj.2 for ; Wed, 17 Aug 2022 06:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=QCMHKhkVunzbtGiMJ/wq/fYfBgDNCThjx88/COvHDls=; b=iBbyiaFqKTDODYRVXGbUEnyLW64y2b+NXCcGhfcnBBw/8Ll59PGYqsbETO+Ymvq229 fTaHJ8yL/a6f0QlIAZ9lJT7oDtYt8T9P0oYQRJrlvHOgp6wYZRWmtSV+SgYijx+etsy7 Pzkp3S0YAkN/dt+aKsS4L3QHaO9gdZj4y+n06I9taPVq5jt8zkkwgXtlnPXGDJraK1jy LpTvvNJM8V8WpY3rRuIU6vGmF/n2Xwlf9ZMpp4kcNzXiecVQPCr3NTHrMEqlLGArDnFs a4j7X8f/eLt0DzFUOwT73Fp19X2byCbWXExCzXIE4oZrjCCrIBrbfDirqDFnwCu595DM Ea8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=QCMHKhkVunzbtGiMJ/wq/fYfBgDNCThjx88/COvHDls=; b=tQ0oAQt5/VKAY2ZN+YMZYfFJ8rOajmDgjUCHqFyY5l+wxoI2asAWeoy1ueoDROts3V 9YkF7wN3xMYMWEHbS93HLEfi9Fu+tPePY5D7/mJHsabQMZ6yPZWaUt9zeORoHu09sF4d ovk7FQ7XqQVymmn4edJFHrtnvtKZfdAISXMAbl9p94XiFBaiBmXRNYlnYMxMhiJHhlRL YAaodQr1aOf/X0aQJbBVH1vwE0eynwjXrKcoyhDLXg2gnZQ43Ckn2qtrJL17RnwnGF3o 1lmfhGu+Ckx+Gy/dclk+gm4a9z7jT1fS4/8CjY8NAnNTH6hRC4w5JlGn+tIgbmHWqwmU 4K0Q== X-Gm-Message-State: ACgBeo3eaS9fkrNczNKUIiIBvgXf3R8F0kZvMq4JHEh5beX1PrdxFfDH M0QoJYVVqUxciDJqJuEquQpaOUyEW3HxLoZW X-Google-Smtp-Source: AA6agR4voDsvddPVWKd+rLt8r1aP0H5GQ0S4vnExx5ubs+n/b5cZm+o7DR00uvmEZWwy9VfOo90F/A== X-Received: by 2002:a05:651c:12cb:b0:25b:fa3f:c3f with SMTP id 11-20020a05651c12cb00b0025bfa3f0c3fmr8365132lje.364.1660741442798; Wed, 17 Aug 2022 06:04:02 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:02 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 09/14] arm64: dts: qcom: sc7280: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:37 +0300 Message-Id: <20220817130342.568396-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space, and allows to remove incorrect syscon compatible from TCSR mutex: qcom/sc7280-herobrine-crd.dtb: hwlock@1f40000: compatible: ['qcom,tcsr-mutex', 'syscon'] is too long Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 13d7f267b289..89a8e6b9822a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2155,12 +2155,17 @@ ipa: ipa@1e40000 { }; tcsr_mutex: hwlock@1f40000 { - compatible = "qcom,tcsr-mutex", "syscon"; - reg = <0 0x01f40000 0 0x40000>; + compatible = "qcom,tcsr-mutex"; + reg = <0 0x01f40000 0 0x20000>; #hwlock-cells = <1>; }; - tcsr: syscon@1fc0000 { + tcsr_1: sycon@1f60000 { + compatible = "qcom,sc7280-tcsr", "syscon"; + reg = <0 0x01f60000 0 0x20000>; + }; + + tcsr_2: syscon@1fc0000 { compatible = "qcom,sc7280-tcsr", "syscon"; reg = <0 0x01fc0000 0 0x30000>; }; @@ -2522,9 +2527,9 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names = "mss_restart", "pdc_reset"; - qcom,halt-regs = <&tcsr_mutex 0x23000 0x25000 0x28000 0x33000>; - qcom,ext-regs = <&tcsr 0x10000 0x10004 &tcsr_mutex 0x26004 0x26008>; - qcom,qaccept-regs = <&tcsr_mutex 0x23030 0x23040 0x23020>; + qcom,halt-regs = <&tcsr_1 0x3000 0x5000 0x8000 0x13000>; + qcom,ext-regs = <&tcsr_2 0x10000 0x10004 &tcsr_1 0x6004 0x6008>; + qcom,qaccept-regs = <&tcsr_1 0x3030 0x3040 0x3020>; status = "disabled"; @@ -3259,7 +3264,7 @@ remoteproc_wpss: remoteproc@8a00000 { <&pdc_reset PDC_WPSS_SYNC_RESET>; reset-names = "restart", "pdc_sync"; - qcom,halt-regs = <&tcsr_mutex 0x37000>; + qcom,halt-regs = <&tcsr_1 0x17000>; status = "disabled"; From patchwork Wed Aug 17 13:03:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598194 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D38B3C28B2B for ; Wed, 17 Aug 2022 13:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239534AbiHQNFj (ORCPT ); Wed, 17 Aug 2022 09:05:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239554AbiHQNEi (ORCPT ); Wed, 17 Aug 2022 09:04:38 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ECA53D5A0 for ; Wed, 17 Aug 2022 06:04:06 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id u6so13499074ljk.8 for ; Wed, 17 Aug 2022 06:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=G5Gw9O1HRC2HZ2RUee8k0rPKQP+uhhOAxZLOGmh5CkQ=; b=fJd0a7YMv0ZcjMFd3JlFycpH5vDcvehDTH1dHlGQdq8x9ko4JNTkvGo9ShJOog7mea pZt9h/chVYurKMP2w6zu3EjZw8d+9oRjNnvF3mrYkk+2K1uN7tSN+ppst6Hna71YDNTr g3Yymbw8LIPuqTI1ToLs1kLWnoYnR7tCR6kFOiQAq/VtmQo30GjX2wMQS+Fs0DcNIxaG 0W+M2shtPxiUbeSqBBNgEqrsRVFyPIE7DqVbPYOtrZxEg2OCYXh5eZgVqTX5+mpQoe0U U9rkywJHQWN6xxGYl1en/4KuO0lbtNV1nlZdomRFq/43tmyEbvXjRhHRIYJhHa2fj/UQ Q+5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=G5Gw9O1HRC2HZ2RUee8k0rPKQP+uhhOAxZLOGmh5CkQ=; b=zc3vBxR2z+SHc/BBxPqPLwlwR4nYxzy/tioWRFzSH/3A6Cq5PA2SvGw0dmE3VQo064 Nh0NTcWmdNbjnA6oXUXAgAwgtNHwD3R+kx38c5SfSuBhUjryuKhJ7jW4L+ZQ5ChulZ+Q KpIKQOcAZ3htQIZlmqUuF/4DNUGHbsH7/Ox0eI38WBulrrFuBEhbXWNvmkzxkyLjEMG4 9BbLjqLJ8fFRL6pncZdlYMzN0dIHbLeq9ffDBmUnNAOQgaSMYlPUbnSnsI8rdlWu+Fyy uhOQtS5xyJDeKxH00Mah9V97w34smjAdU9w9qZeCUqZHLQcppq+X30FJQKNGtMfRosAm FYNA== X-Gm-Message-State: ACgBeo1orLufnBm2UJcDUlL/+g4qWON6WXG1/4CiC38bc3U9jdp0Klx5 HkQk8B8gpv5ll51pcG691ADTjw== X-Google-Smtp-Source: AA6agR5WXQrRTwjt8id+ceIUkD6C8jy56bGansLAj+V88Eet7oi7wGDthsIKYm2iqClkwXLkUy5f/w== X-Received: by 2002:a2e:9819:0:b0:25f:dbcd:3ad5 with SMTP id a25-20020a2e9819000000b0025fdbcd3ad5mr8039858ljj.527.1660741444164; Wed, 17 Aug 2022 06:04:04 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:03 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 10/14] arm64: dts: qcom: sdm845: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:38 +0300 Message-Id: <20220817130342.568396-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index f0e286715d1b..21ed14200986 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -2590,7 +2590,12 @@ ipa: ipa@1e40000 { tcsr_mutex_regs: syscon@1f40000 { compatible = "syscon"; - reg = <0 0x01f40000 0 0x40000>; + reg = <0 0x01f40000 0 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible = "qcom,sdm845-tcsr", "syscon"; + reg = <0 0x01f60000 0 0x20000>; }; tlmm: pinctrl@3400000 { @@ -3207,7 +3212,7 @@ mss_pil: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names = "mss_restart", "pdc_reset"; - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>; power-domains = <&rpmhpd SDM845_CX>, <&rpmhpd SDM845_MX>, From patchwork Wed Aug 17 13:03:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597904 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 781C0C28B2B for ; Wed, 17 Aug 2022 13:04:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239598AbiHQNEv (ORCPT ); Wed, 17 Aug 2022 09:04:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232466AbiHQNE2 (ORCPT ); Wed, 17 Aug 2022 09:04:28 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E140533436 for ; Wed, 17 Aug 2022 06:04:07 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id x19so18926060lfq.7 for ; Wed, 17 Aug 2022 06:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=v+CAkv8Hlyo2PxpwLaCJcPFqOS7vWYe9QQHHKSYzECU=; b=z2gY6kWdx5thVEWNbyzgP/AV8QjMQfV030JlnCO2kJWlqICwWvYGcK+QYVxh741Jlf gadgcu+vGFl66aA0ey07hG3KsXQeIkkfQghuPqFZrC73X6uzdcs2RBT3XxcT3a+PJ7EJ x96Jca9TD4Op2SX2pfGnvaAekt6NI7ssHth6FWBwIcAncg7zlm2ZbNg76SEyHqRUzmh5 tR5sXvcYMdY9wCcCElJz+n4xhRaz1TI4lyDpvBMaqh8f1vLHFGy+9BCBgSL1PoRw1VEZ tEEgwqhYzf2JKX45+end44U3T5/RC1v7pG9wAUe3y44U0T3ysANHIsuKn0s/U2HwWa2O NwaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=v+CAkv8Hlyo2PxpwLaCJcPFqOS7vWYe9QQHHKSYzECU=; b=qgFTW70MHz1FkRkUsBKbWkKxTIDRBcjDNnNSg+W1lCjCZipYcfj7jIWIDhdZhjlDTK 1e6xyaL96VSAkOT9rMoI6xpEDRZzbyIwE2MLrl8KisYWFC0qfLY5H1CR4wDnbbg0+heo 87Zl9SJp9EdJXCnQ1cLgDIjbm5QyfxDkeUTJtF2B1ywpr8xYFQZjW611Pyj5WtAnOgn+ AUubKD+01xGm8lRVYrOaX1O3xRVZCm7ikPLg38PYvvkzXOrwuxRhoimrWitg3EEzCgeg Ca4/bIi3V6o47mIJx/HYB99uWEOwAhJxnGLKijMjpXNr5fQao5PIlwK5VygOSIe0y93o RZYA== X-Gm-Message-State: ACgBeo2Qrv20sff34tf85xDh0ocb8IEE+CKiVQnA3Jdw83iPF6HlE+rN UYzPj/fYwCB0pPDICjvNbJLaaw== X-Google-Smtp-Source: AA6agR6gGaNvA1OCrY5FS5lVoXuUR7cXFbR03kr2uyJ4BWGJd3ujkvni9qmraTptHX7xhHiknZ+wFw== X-Received: by 2002:ac2:4d4a:0:b0:48b:1f80:a93d with SMTP id 10-20020ac24d4a000000b0048b1f80a93dmr8147107lfp.403.1660741445480; Wed, 17 Aug 2022 06:04:05 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:05 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 11/14] arm64: dts: qcom: sdm845: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:39 +0300 Message-Id: <20220817130342.568396-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm845-shift-axolotl.dtb: hwlock: 'reg' is a required property qcom/sdm845-shift-axolotl.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 21ed14200986..bd0ec0664283 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -919,12 +919,6 @@ compute-cb@8 { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - smp2p-cdsp { compatible = "qcom,smp2p"; qcom,smem = <94>, <432>; @@ -2588,9 +2582,10 @@ ipa: ipa@1e40000 { status = "disabled"; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; reg = <0 0x01f40000 0 0x20000>; + #hwlock-cells = <1>; }; tcsr_regs_1: sycon@1f60000 { From patchwork Wed Aug 17 13:03:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598195 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09276C32772 for ; Wed, 17 Aug 2022 13:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239562AbiHQNFh (ORCPT ); Wed, 17 Aug 2022 09:05:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239556AbiHQNEj (ORCPT ); Wed, 17 Aug 2022 09:04:39 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDD9B3ED4E for ; Wed, 17 Aug 2022 06:04:09 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id u6so13499185ljk.8 for ; Wed, 17 Aug 2022 06:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=uPnkJ9CZ7fbXWgaAUcfcWBXaeXKUW7FCT3L0V3onDIA=; b=Fc//ghCPlI2grror3k/gdiB3O/cjHqZyRs6QSvO/7x2zSS9OHfw8PAr62PzduFmqKy 8tFTKsMuhsxltwVTa3VkJlfRoP8v5W3/rDoUSXV7BVYsRdCEcumL2FYRr16R6bYV6LVl Zcflciwi81vjk1JVEMAuBeWY+f7AHICRyqyjqgh4d0uutrhHNMGwX3z98sbR+pwg/5NU GJsUUI1d49xWFqRI7krlV8INsAy7gz5Qsun4CZuOA7vnlFeuUKQVXBYZiXHyYesNO2Qx XiLFgvDYmrB08z4MEa+x75hajHfqIdsioU9d3wDXZEAmsoyLveg4pcfCYcEjHfYtz1xM RJZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=uPnkJ9CZ7fbXWgaAUcfcWBXaeXKUW7FCT3L0V3onDIA=; b=vhlipUS7WZs+D9/X92ftnClo8BYg88hwESpQZ1mmZVleFH9Pf4uJivWTlwk6gsNGpw 8sNsC2kJDiQqFxPWSDu0DL7Abuz+9Aqn9W793Bh2QA1PEcRYaKwqPHoi9bfkpxCanOiY RcJV7td/4nHkpUx0YREpD3p3mbHry6WFxSHtHHwgID8huj+ZlNP6mtUVR+2/JZHZFxB4 atB3qYpFmk06MmJHzCN2dKUxkEH9KHFy7RDWK/YC/XtXIQiIWko+Tlm1b1zTAtSMxDQK xizZKetoZgETVbx/ynthoi2uq1xf8d7Nm2RS+Bml9H9Q/K+BBgg6WIxGtyrHHtK/eBGS b+uA== X-Gm-Message-State: ACgBeo00CDGmuZgaFvmUT0VUp3mQ4lOPkd187kGX9kSWRVP7ZlnUIfp7 0QglgTSo/sgdj6v4OdF6mp4bqQ== X-Google-Smtp-Source: AA6agR6istx8JavCEXk3I5CtWbuvh0/no8XYd5sNH5SDdsxtdJ/jifPTQYUQdXQdDn3fvceLZTjHqw== X-Received: by 2002:a2e:7d08:0:b0:25e:c66f:2bc4 with SMTP id y8-20020a2e7d08000000b0025ec66f2bc4mr7530960ljc.22.1660741446898; Wed, 17 Aug 2022 06:04:06 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:06 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 12/14] arm64: dts: qcom: qcs404: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:40 +0300 Message-Id: <20220817130342.568396-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/qcs404-evb-4000.dtb: hwlock: 'reg' is a required property qcom/qcs404-evb-4000.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi index 9ab990061522..3a94eb2cc448 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -295,12 +295,6 @@ smem { hwlocks = <&tcsr_mutex 3>; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - soc: soc@0 { #address-cells = <1>; #size-cells = <1>; @@ -726,9 +720,10 @@ gcc: clock-controller@1800000 { assigned-clock-rates = <19200000>; }; - tcsr_mutex_regs: syscon@1905000 { - compatible = "syscon"; + tcsr_mutex: hwlock@1905000 { + compatible = "qcom,tcsr-mutex"; reg = <0x01905000 0x20000>; + #hwlock-cells = <1>; }; tcsr: syscon@1937000 { From patchwork Wed Aug 17 13:03:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 598196 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64980C32771 for ; Wed, 17 Aug 2022 13:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239141AbiHQNFe (ORCPT ); Wed, 17 Aug 2022 09:05:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239634AbiHQNEl (ORCPT ); Wed, 17 Aug 2022 09:04:41 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92BA53F335 for ; Wed, 17 Aug 2022 06:04:11 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id o2so18951248lfb.1 for ; Wed, 17 Aug 2022 06:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DqeinnIMS7tnZ1s/F5WbYXe7dS10PhHD2RlaXqtenk4=; b=i0GvDg8TPViBlqsgSYnRwUvswrg91GsMb+QaX4/VEVX2zBTIOPJt4gpUlxkvcXpBvT xK6+oxY6A3mVE05M0AW4zmDifbsfOCNDRjAH70dyD8TJliMxGLVYLN6Vp8u5xera9IT1 RoEouXPxXYB4W7DoAzax/1F30Pq2WI3Y7jLZO3h8V5s+C7h9aNwK29gPFeZK58PwrGx/ nuQn+j7/AwPxahNDvRsGaG1KtaSXjBkYaa8r57BzaSNVFNE48ryz03CCBznEcwwSdj+6 zsFWcsCqStRuqJKbNDFTU+Owsfv2bZZzwNRCDLLV2gvayHioBcyKT8RLkEu4a9wF4Wtd YRUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DqeinnIMS7tnZ1s/F5WbYXe7dS10PhHD2RlaXqtenk4=; b=Fs6Qm420tUyr/DllUVEIdvvEvIBN4U1AtBKrCDddEvtZmieFmBFxsR4r6HNEA5lvel TQbBaI0XbZBjrr+UZWK5gA1sUffe/zDLq6ktkHvdQ7hG2jKS+BRjumKX3AEWo+sl4jP5 eXlm1hJQCkG+kin+XnvaQSp596abnuTzyBjpS2W2QlSCtD2hQamGncyZQ1zwtOJjA4MN cgU7NoQpFtwi60nS5LQ7YPTBW7Mn4i8brXsIJf1/+G9I5GVbaCDXgN5G/FEK8Xa018kQ 2Yh3qYZ2mKCURSZG8UL4Ah2lV3p++YICt8+9x6TWj9Uf2xCufZfT3nc80o1f2TNjTrnO 2xFg== X-Gm-Message-State: ACgBeo2XqZUNkUmUeacGyNiIW5Ll5VjWEZPMo6tAbX8ceIcghqDhCMcH 3vp4SQkQUVTCcw0WEil42apPzQ== X-Google-Smtp-Source: AA6agR5TbOLMn+IOpEsiRnErXR+auYE0jmCcgUOl4UbPjLbAdI9ArIKLFXB3SX2CkDNJG+YlZYa+Ug== X-Received: by 2002:a05:6512:22ce:b0:48c:190f:5c37 with SMTP id g14-20020a05651222ce00b0048c190f5c37mr8321869lfu.564.1660741448295; Wed, 17 Aug 2022 06:04:08 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:07 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 13/14] arm64: dts: qcom: sdm630: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:41 +0300 Message-Id: <20220817130342.568396-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'reg' is a required property qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi index 1bc9091cad2a..40a40d00eae4 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -697,9 +697,10 @@ tsens: thermal-sensor@10ae000 { #thermal-sensor-cells = <1>; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; - reg = <0x01f40000 0x40000>; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; + reg = <0x01f40000 0x20000>; + #hwlock-cells = <1>; }; tlmm: pinctrl@3100000 { @@ -2351,12 +2352,6 @@ intc: interrupt-controller@17a00000 { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - sound: sound { }; From patchwork Wed Aug 17 13:03:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 597902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC522C32789 for ; Wed, 17 Aug 2022 13:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239556AbiHQNFi (ORCPT ); Wed, 17 Aug 2022 09:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239534AbiHQNEl (ORCPT ); Wed, 17 Aug 2022 09:04:41 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C46B4198F for ; Wed, 17 Aug 2022 06:04:13 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id r17so18903453lfm.11 for ; Wed, 17 Aug 2022 06:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=GGC6/FAtFLtsPec3v0Z//ulLsaLmio7LVXcsIKWCfDM=; b=Jh4Qy9iXI/c1oGXbZ0lnM/OpRok+s+cFSr4oZ/HZf/Wiu4RDv1f090LKWQXlfy2mQR 8vfSRgiphbSgHJ3xzY7oaBL+nsNpYIbGQ5estuegJ9wB+r3EbUOVo/+Czc+LLXgO+TN3 A5OGKUFN1Ii3mv8HYwxdWOvh9Pi1MazXBN/uX+YK3FyjmtPXKds1PIH9Q7C0fwpHn3mQ tkpzoIfkB5YwAnSZYf5f1q2kSp7fXo5kvFgG+EL0YiE+Tj1qFCwVvaZbFB/cFQpc3/mZ SATiRY3hkH2rApYsAKgOAmGLpPksC2V/uBntzjMrMT18SdNdzu1o/YTbeZhoFY/y/Y2g GFsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=GGC6/FAtFLtsPec3v0Z//ulLsaLmio7LVXcsIKWCfDM=; b=jwnwITGRM80n38dyHLO7r5Xs4C671m+9R1RwUDfG40685Jdxw82zV6tYEpkzYMJ4tT NCgPHdrRit5GjYdms1IRzqwOxhERG9VMyZTPSv0twiax0AtRzJKND1dw3dVLWubRKjoO rkwRjuSImw8RyQ66rd7NsH00DDSb4uR1EoejN3WUUoefSYIabFxoI3UMAePh7R1mQo+Q G46GIk1wixQt5ABw2d7uDSIgez2vnPZuzC4BRyvNr/v5518kLc4Ut3m4okf2wK/qlfvK dt3ABRIMhyUxrxQymIbfmfX/28bhGIvM57iFLmkR+uNY+htnNezv3caWyLLDNkSFNk1C tz1Q== X-Gm-Message-State: ACgBeo1WYwzSSuz72BsSZuIKipcmHylnNQPRdRkR89qDUtooiAuVhZu7 oyyGNxAlwgVjKfcsjA4hqRspPQ== X-Google-Smtp-Source: AA6agR7FDblqVQT9gybR5hPpqOJr92pA+VUM4Qhig09FQMQsWhnjjQeFyrRKTjyc7K2GZP4L90Ut5Q== X-Received: by 2002:a19:3856:0:b0:491:7b45:7617 with SMTP id d22-20020a193856000000b004917b457617mr5988001lfj.47.1660741449662; Wed, 17 Aug 2022 06:04:09 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:09 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 14/14] arm64: dts: qcom: sm8150: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:42 +0300 Message-Id: <20220817130342.568396-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sm8150-mtp.dtb: hwlock: 'reg' is a required property qcom/sm8150-mtp.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 7d509ecd44da..dc6770391813 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -585,12 +585,6 @@ scm: scm { }; }; - tcsr_mutex: hwlock { - compatible = "qcom,tcsr-mutex"; - syscon = <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells = <1>; - }; - memory@80000000 { device_type = "memory"; /* We expect the bootloader to fill in the size */ @@ -2054,9 +2048,10 @@ ipa_virt: interconnect@1e00000 { qcom,bcm-voters = <&apps_bcm_voter>; }; - tcsr_mutex_regs: syscon@1f40000 { - compatible = "syscon"; - reg = <0x0 0x01f40000 0x0 0x40000>; + tcsr_mutex: hwlock@1f40000 { + compatible = "qcom,tcsr-mutex"; + reg = <0 0x01f40000 0 0x20000>; + #hwlock-cells = <1>; }; remoteproc_slpi: remoteproc@2400000 {