From patchwork Wed Sep 7 02:54:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 603763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67280ECAAA1 for ; Wed, 7 Sep 2022 02:54:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbiIGCyA (ORCPT ); Tue, 6 Sep 2022 22:54:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbiIGCx6 (ORCPT ); Tue, 6 Sep 2022 22:53:58 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95E16985A0 for ; Tue, 6 Sep 2022 19:53:42 -0700 (PDT) X-UUID: 08efede753124c908b718eaf80eb6add-20220907 X-CPASD-INFO: 9101aeb3b46a4312ae97c61e7ebe3564 @goFqUY6XkGOOVHitg3Z8bIGWaWeTYlG0eZ- ClmFlYlSVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBhXoZgUZB3iHNqUZaTkg== X-CLOUD-ID: 9101aeb3b46a4312ae97c61e7ebe3564 X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:1.0, URL:-5, TVAL:172. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:150.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5 .0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:1.0, CFOB:5.0, SPC:0, SIG:- 5, AUF:17, DUF:4220, ACD:72, DCD:72, SL:0, EISP:0, AG:0, CFC:0.203, CFSR:0.151, UAT:0, R AF:0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EAF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 08efede753124c908b718eaf80eb6add-20220907 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 08efede753124c908b718eaf80eb6add-20220907 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 640301292; Wed, 07 Sep 2022 10:54:06 +0800 From: Hongling Zeng To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, Hongling Zeng Subject: [PATCH v2 1/3] uas: add no-uas quirk for Hiksemi usb_disk Date: Wed, 7 Sep 2022 10:54:06 +0800 Message-Id: <1662519246-18397-1-git-send-email-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Hiksemi is reported to fail to work on several platforms with the following error message, then after re-connecting the device will be offlined and not working at all. [ 592.518442][ 2] sd 8:0:0:0: [sda] tag#17 uas_eh_abort_handler 0 uas-tag 18 inflight: CMD [ 592.527575][ 2] sd 8:0:0:0: [sda] tag#17 CDB: Write(10) 2a 00 03 6f 88 00 00 04 00 00 [ 592.536330][ 2] sd 8:0:0:0: [sda] tag#0 uas_eh_abort_handler 0 uas-tag 1 inflight: CMD [ 592.545266][ 2] sd 8:0:0:0: [sda] tag#0 CDB: Write(10) 2a 00 07 44 1a 88 00 00 08 00 These disks have a broken uas implementation, the tag field of the status iu-s is not set properly,so we need to fall-back to usb-storage. Signed-off-by: Hongling Zeng Acked-by: Alan Stern --- change for v1 -Change the email real name Change for v2 -Change spelling error --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index cdff7dc..a6bf87a 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -62,6 +62,13 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_IGNORE_UAS), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x090c, 0x2000, 0x0000, 0x9999, + "Hiksemi", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI * commands in UAS mode. Observed with the 1.28 firmware; are there others? From patchwork Wed Sep 7 02:54:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongling Zeng X-Patchwork-Id: 604188 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CDDECAAA1 for ; Wed, 7 Sep 2022 02:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229987AbiIGCyG (ORCPT ); Tue, 6 Sep 2022 22:54:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbiIGCyF (ORCPT ); Tue, 6 Sep 2022 22:54:05 -0400 Received: from mailgw.kylinos.cn (unknown [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7651C7DF46 for ; Tue, 6 Sep 2022 19:54:04 -0700 (PDT) X-UUID: 3d00f30be93649969f28105c82ec9009-20220907 X-CPASD-INFO: c78c7e3bcbae4b28a3fd479f7b26a936@rIdyg2SXYZKPgqOxg6V9coFklpRkY1m 1eZxSZo9pX1aVhH5xTV5uYFV9fWtVYV9dYVR6eGxQYmBgZFJ4i3-XblBgXoZgUZB3snlyg2mTYw== X-CLOUD-ID: c78c7e3bcbae4b28a3fd479f7b26a936 X-CPASD-SUMMARY: SIP:-1, APTIP:-2.0, KEY:0.0, FROMBLOCK:1, OB:0.0, URL:-5, TVAL:172. 0, ESV:0.0, ECOM:-5.0, ML:0.0, FD:0.0, CUTS:123.0, IP:-2.0, MAL:-5.0, PHF:-5.0, PHC:-5 .0, SPF:4.0, EDMS:-5, IPLABEL:4480.0, FROMTO:0, AD:0, FFOB:0.0, CFOB:2.0, SPC:0, SIG:- 5, AUF:18, DUF:4221, ACD:72, DCD:72, SL:0, EISP:0, AG:0, CFC:0.308, CFSR:0.104, UAT:0, R AF:0, IMG:-5.0, DFA:0, DTA:0, IBL:-2.0, ADI:-5, SBL:0, REDM:0, REIP:0, ESB:0, ATTNUM:0, EAF:0,CID:-5.0,VERSION:2.3.17 X-CPASD-ID: 3d00f30be93649969f28105c82ec9009-20220907 X-CPASD-BLOCK: 1000 X-CPASD-STAGE: 1 X-UUID: 3d00f30be93649969f28105c82ec9009-20220907 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain.localdomain [(112.64.161.44)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1856273885; Wed, 07 Sep 2022 10:54:27 +0800 From: Hongling Zeng To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, zhongling0719@126.com, Hongling Zeng Subject: [PATCH v2 3/3] uas: ignore UAS for Thinkplus chips Date: Wed, 7 Sep 2022 10:54:28 +0800 Message-Id: <1662519268-18488-1-git-send-email-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The UAS mode of Thinkplus is reported to fail to work on several platforms with the following error message: [ 39.702439] xhci_hcd 0000:0c:00.3: ERROR Transfer event for disabled endpoint or incorrect stream ring [ 39.702442] xhci_hcd 0000:0c:00.3: @000000026c61f810 00000000 00000000 1b000000 05038000 Falling back to USB mass storage can solve this problem, so ignore UAS function of this chip. Signed-off-by: Hongling Zeng --- Change for v1 - Change the email real name and the code worng place. Change for v2 -Change spelling error. --- drivers/usb/storage/unusual_uas.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h index 8a18d58..156e89c 100644 --- a/drivers/usb/storage/unusual_uas.h +++ b/drivers/usb/storage/unusual_uas.h @@ -198,6 +198,13 @@ UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999, USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NO_ATA_1X), +/* Reported-by: Hongling Zeng */ +UNUSUAL_DEV(0x17ef, 0x3899, 0x0000, 0x9999, + "Thinkplus", + "External HDD", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Hans de Goede */ UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999, "VIA",