From patchwork Mon Sep 12 15:30:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101803 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp913993qgf; Mon, 12 Sep 2016 08:43:22 -0700 (PDT) X-Received: by 10.66.145.73 with SMTP id ss9mr34332902pab.82.1473695002104; Mon, 12 Sep 2016 08:43:22 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a75si18036181pfe.201.2016.09.12.08.43.21; Mon, 12 Sep 2016 08:43:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755258AbcILPnS (ORCPT + 27 others); Mon, 12 Sep 2016 11:43:18 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:61023 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933657AbcILPbc (ORCPT ); Mon, 12 Sep 2016 11:31:32 -0400 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0M8M5O-1anX7X1yao-00vuZG; Mon, 12 Sep 2016 17:31:09 +0200 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, Arnd Bergmann , Dmitry Torokhov , Rob Herring , Nick Dyer , Hans de Goede , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] [media] Input: atmel_mxt: disallow impossible configuration Date: Mon, 12 Sep 2016 17:30:32 +0200 Message-Id: <20160912153105.3035940-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:M+Lj9jv5cfItcTvib3fPXLDtvVY0bjvHLWfkmsKfTnuqYNMIoUb yk5YPQAFPf/IO+GYS9ImsnMkM+2MkF2iioZBA2M7m9ScEmtFBwBxGyPWQUj9wZ4JGRggDu5 wGBt3Pj4TcoIl6yfvAJDumIfONvsrBVdSYtPWoKjMblcMrHkZbwN1YUD8dkNhx2Y8+KSTIn diNq80mpid28sivKK2IkA== X-UI-Out-Filterresults: notjunk:1; V01:K0:ZUY5N+Hvzx8=:03aIXt7lVFGRq5GmXva53e fgf5BzAMl/4t7PpuQA+ppH7nXK26YgGb3QRl7XjxinY2Whsp2fTESc41nHnUKXGTZ9N+2aAJq sWSazR4PVxDbTtVAicxcsHXyh7QvtSMOfvbaH483Vrf/DZAaPBLjTPOKNwvbS7xvD5I0OwfTu 30GA1UOacCU+Yns9oynIrWmwjbSUuYZ2veyA8nGKQmRYKJQfH7oWCjdXQmNVH3xuwsStIPe/+ PoeiPznutntDgc4nCxkRLiE8Kfe3kSu+hJaC548bKgXoEwObmy40Jn4jN+qkcV/cMf0q0HiF8 TRnc5uM+B4eEDaRMfjkbaz0+g42/9HclJsd21dC783GKcQdw/HK3pTeWJtlxRLw2IXCq/0bZj XBLM9vj2ge5qccFfjLnab1Cs0rlUKkqpHs01oVhl/PJ6JE0Vt9U/RozktpXC89XHYgCiyyEit mAzpxEtxgCxsU7kDU07GL3SA65hbJCDAIfhZ52FIyCCTAdOF0n1QUQrustDFJ8Qd1oMcc3fvp JU9nxkWEwozFI7Z+sDvvU/OxxUxnhukpMhaEx9atQM1buukzac2I6s5/QZdjnIzikzIU8P3LB 65fVVCIEQL9Y4Wq1yLrPCdOcifX5Z4L2A4FaxUqhzG8nzAkqpckIErmGetZRKyL1SSJhGo0NQ AaCTvAlTQITrDsaIUysLBG8TiX1nIXokY4XYGzu2f2ZsLQg0r72UoHdJ17Y7PvUpxG8A= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newnly added debug mode for the atmel_mxt_ts driver relies on the v4l2 interface and vb2_vmalloc, but those might be configured as loadable modules when the driver itself is built-in, resulting in a link failure: drivers/input/touchscreen/atmel_mxt_ts.o: In function `mxt_vidioc_querycap': atmel_mxt_ts.c:(.text.mxt_vidioc_querycap+0x10): undefined reference to `video_devdata' drivers/input/touchscreen/atmel_mxt_ts.o: In function `mxt_buffer_queue': atmel_mxt_ts.c:(.text.mxt_buffer_queue+0x20): undefined reference to `vb2_plane_vaddr' atmel_mxt_ts.c:(.text.mxt_buffer_queue+0x164): undefined reference to `vb2_buffer_done' drivers/input/touchscreen/atmel_mxt_ts.o: In function `mxt_free_object_table': atmel_mxt_ts.c:(.text.mxt_free_object_table+0x18): undefined reference to `video_unregister_device' atmel_mxt_ts.c:(.text.mxt_free_object_table+0x20): undefined reference to `v4l2_device_unregister' The best workaround I could come up with is to disallow the debug mode unless it's actually possible to call it. Signed-off-by: Arnd Bergmann Fixes: ecfdd7e2660e ("[media] Input: atmel_mxt_ts - output diagnostic debug via V4L2 device") --- drivers/input/touchscreen/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index fce1e41ffe8b..ccf933969587 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -117,7 +117,8 @@ config TOUCHSCREEN_ATMEL_MXT config TOUCHSCREEN_ATMEL_MXT_T37 bool "Support T37 Diagnostic Data" - depends on TOUCHSCREEN_ATMEL_MXT && VIDEO_V4L2 + depends on TOUCHSCREEN_ATMEL_MXT + depends on VIDEO_V4L2=y || (TOUCHSCREEN_ATMEL_MXT=m && VIDEO_V4L2=m) select VIDEOBUF2_VMALLOC help Say Y here if you want support to output data from the T37 From patchwork Mon Sep 12 15:30:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101805 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp912622qgf; Mon, 12 Sep 2016 08:40:16 -0700 (PDT) X-Received: by 10.66.72.8 with SMTP id z8mr34136555pau.141.1473694813356; Mon, 12 Sep 2016 08:40:13 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id hr8si22131379pac.67.2016.09.12.08.40.13; Mon, 12 Sep 2016 08:40:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934145AbcILPkK (ORCPT + 27 others); Mon, 12 Sep 2016 11:40:10 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:53896 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932616AbcILPcG (ORCPT ); Mon, 12 Sep 2016 11:32:06 -0400 Received: from wuerfel.lan. ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue005) with ESMTPA (Nemesis) id 0MUjoe-1bXLi32YSy-00Y9Wu; Mon, 12 Sep 2016 17:31:39 +0200 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, Arnd Bergmann , Dmitry Torokhov , Andrew Duggan , Hans Verkuil , Nick Dyer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] [media] Input: synaptics-rmi4: disallow impossible configuration Date: Mon, 12 Sep 2016 17:30:33 +0200 Message-Id: <20160912153105.3035940-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160912153105.3035940-1-arnd@arndb.de> References: <20160912153105.3035940-1-arnd@arndb.de> X-Provags-ID: V03:K0:QJl2tw77su8LAUtskfX1mgwNGhaGdcxRRipAkCNlLZyugbMcvrn qByB+y7XLjiM3rF5Ka1x6mjXrHQ0gxxYUh5X4HoYhybuyUNTGqxwa43htUbVzAeri7szkCX UTPK3XnpKQWChDxRO+JvGHw5kEpd7CVfPsJqkKm6giCoT3zl2rjJo09/pKrr1GukyJf3CgI 9XkermSJdEym6jKiORF+A== X-UI-Out-Filterresults: notjunk:1; V01:K0:COyyJzZWoRg=:zG6N4281nxXCmhTzzSouM/ y/Uu+j44q1/fn3WHeHnhT7WStOHk878oHYu2ydHynuR5Py3ZcjeSUHjkOekbPRnaeyCobAfnv UVzgrnnY7kICmMomYv4cQ3fC+eqFYHF7EYpRfawkWoKCX0epqs0eZdJk7bfK2efKSnEwWT149 cGh8yVR1AKgWg4XzWgGmr+ibSCHG0FAtU/JAbk/fB9zR+5dfhhWtArlRl6wH7pFnXf6Ka+zj+ tGmM6AzZxOvWx3okp6EV2BivP5aVxpGnSxVgKymsnkpYarxTCEzXmD6WAmAmsqVdYN/hG6+Vh iQMpSeSBwa2FsqB4cz4wx/7BNlfcrdKENc4XXPIoysvfHWW/pdQmmE2uWiMoNZjkL2JqetluE 3r1qw6XX6X1GiAgJKfNNT+a9FVtoXwgH6vUUnx33jjRIAE/8QEa9Chtd1CtmD9a15B2cFdg+V FmnoqBoZ5iEED2tycwD9zqmAQ2xK3i8Et/KDFDyKuzHXtcXUlrTlmqhtEwe91/5L3WZLlycSY MUrgY3nSFDRUqPiyDRMOdhR2bNPATCwK30lDvqlnipLTqRAhVJO9Mnbr7be0SiHEpDHap7YNd FMc3ZmLhDq6h5W007PAyCQ1wYqzpsjVTRdpR4+0A+eERJPM7bOholQbWnVSP7wy/tcr5CkGS7 dFo6ATjaX4K52fh/6GE5/pC01hwLGjoPckLZidUSR1IrLOsJJg+WywUIrEiwyd9re7y0= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added debug mode for the synaptics-rmi4 driver relies on the v4l2 interface and vb2_vmalloc, but those might be configured as loadable modules when the driver itself is built-in, resulting in a link failure: drivers/input/rmi4/rmi_core.o: In function `rmi_f54_remove': rmi_f54.c:(.text.rmi_f54_remove+0x14): undefined reference to `video_unregister_device' rmi_f54.c:(.text.rmi_f54_remove+0x20): undefined reference to `v4l2_device_unregister' drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_s_input': rmi_f54.c:(.text.rmi_f54_vidioc_s_input+0x10): undefined reference to `video_devdata' drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_g_input': rmi_f54.c:(.text.rmi_f54_vidioc_g_input+0x10): undefined reference to `video_devdata' drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_fmt': rmi_f54.c:(.text.rmi_f54_vidioc_fmt+0x10): undefined reference to `video_devdata' drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_enum_input': rmi_f54.c:(.text.rmi_f54_vidioc_enum_input+0x10): undefined reference to `video_devdata' drivers/input/rmi4/rmi_core.o: In function `rmi_f54_vidioc_querycap': ... The best workaround I could come up with is to disallow the debug mode unless it's actually possible to call it. Signed-off-by: Arnd Bergmann Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 diagnostics") --- drivers/input/rmi4/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/input/rmi4/Kconfig b/drivers/input/rmi4/Kconfig index f3418b65eb41..4c8a55857e00 100644 --- a/drivers/input/rmi4/Kconfig +++ b/drivers/input/rmi4/Kconfig @@ -65,7 +65,7 @@ config RMI4_F30 config RMI4_F54 bool "RMI4 Function 54 (Analog diagnostics)" depends on RMI4_CORE - depends on VIDEO_V4L2 + depends on VIDEO_V4L2=y || (RMI4_CORE=m && VIDEO_V4L2=m) select VIDEOBUF2_VMALLOC help Say Y here if you want to add support for RMI4 function 54