From patchwork Mon Sep 26 00:29:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609442 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F569C6FA82 for ; Mon, 26 Sep 2022 00:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233074AbiIZAaX (ORCPT ); Sun, 25 Sep 2022 20:30:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232731AbiIZAaU (ORCPT ); Sun, 25 Sep 2022 20:30:20 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2093.outbound.protection.outlook.com [40.107.237.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60CE322BEB; Sun, 25 Sep 2022 17:30:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HwCjauJMZAN68KzIzYKZ1MQU0xj6S4vbOPgA1Y5kFHHSXjT4QAsM8OPubkO/FPLlqZb1mP23os/cH9ynLhUja1gIPoP13iQd3FHiI3dofyjmkmvcRnL4LRcQv/aFL9wvvXbdZOW7PMOkKrmXhNflfzqhJ3SEXjRpD81Fh1AalFQbmrsBusSrLrc/fOp3Iv8b481iKASEJ7q4xCqOXUbqw8/OYnaUpuLqsgvPOE+sG8wTNGc+JQ3ijzQKZTYk9F3Dl5D2UuaayN4OMwJXIG9eVGe/6KU6xBR7PZPhV7uMBKqhTFXpIw9b5qv2EQv+GJYU80KvJR+10VkGs6utR+HNlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P0c8wNJsp1ue06+XveUThFK29wEf2+TwqK+jWrEvygo=; b=ayyo2lzxsDwdfDs+rtTOszI36sUJOuw3Rthvfy3DwXZ78wlHH8S88yka+dLnSH6IO9OQfFF70Je7gkVK9g3XCZkQI6utx0ozVgNTUjYFl3iCuH3TlNR6dH8OA9WLT68mshoYyrj5GNgyvUk3D5RTptsIVZZ8U4YPBAqGqxwPVSBLLvny2asLNQiRpa2IffEbZYib1wztLUt2Mh/5UU6U7VhPVhx0xW/FPG1J543KnKnOKPLiJ2WLXxgylCy9zUvOrNdOW8embKrIbdIQGG+UemE//GsRCBjbCOYpVmJgBkNRzwPCsK5dWynbiVVxl1+cDyRFmPuUBywTjubgV1u1aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P0c8wNJsp1ue06+XveUThFK29wEf2+TwqK+jWrEvygo=; b=Zcktaq4BHs7Fy2RJ1j8ShqJKW7eVulC9Jr6Amqqsm+PsSwnJqw1FEI+P/OQGBvv2C+NtXLujmylittc7begdVpCrDd/I+SA05Y8Pu8U8Os0/x+0jRPX6tmOxeqc/NxuSh04fjfYyfZlbii7oMy2PPX7mU3sBxbD7S4POzSXQSuM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by DM4PR10MB6062.namprd10.prod.outlook.com (2603:10b6:8:b7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:16 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:16 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn , Vladimir Oltean Subject: [PATCH v3 net-next 01/14] net: mscc: ocelot: expose ocelot wm functions Date: Sun, 25 Sep 2022 17:29:15 -0700 Message-Id: <20220926002928.2744638-2-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|DM4PR10MB6062:EE_ X-MS-Office365-Filtering-Correlation-Id: f12891e9-c8a1-48e1-271a-08da9f564893 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fh65UwbIIfkLh+EfAI3tbz68Clq3i4cOXVVOTPhvd1rg5QJsx/gJ968eLZ/HpkvgmCZ/UZzFRe7O9p/zN+ICHQeQGN5Vbdm68cCEhn/3CgN4uLMfZ2v8QEP6/ip5b8EvARKDmVResX6+cWPnmNDXZs2qUoQ2qbDFw8kJ23GE9UeM5VMi3KcCNU5gwruVw3gxT5Fa+slmMArSsiW2Ywjx96noeYBv7si4x2gmsCd1Y+URdcA/jFQ5uYLLf6X22LdfFRQuBpl8LW+H3zLrFlYZQp5DyuvN8tu5r82i0Y1/r29PBXXXMlMCej1HnRIESLKoQBX0iINJPOi16FRdBu1Ed+qqjfaoNzdAYb0SUB1iaNpdkR6g0Zoe7kxMUKjgvH//X8CItQaH65Mh4jY9yyF2sXO9ZDu1gKLW9CDqzjpZYJbg41p8cy7lzf+VUBHUorzkPwoE6c+NIIcSpaPe5Q11D68grl+mRbcR0G/bk98I4DnWAddDkMNLiOccsKv2h7KWxaGbjcdxS8qDyCveeAwupOzykW+gdxjQoQE2uU2zePRk4B+rMVMt5FnJE3JCIKslMfSx9cn8FVFv7MAiJYTLwXAy8D3mopXViKzH9KGGjcm85/RAmbKNKiUcU5CbV7ZQGnf30nPdZF+qYQrvbzSMgSq6X6vhcy25FDrpIsmxTqSRBGG5npoyM8RilvDzVwXvoy3jpLZ10hG52w6kKYBLHmI409hTAqHV7C5CiNRT4yzXyNf6HoK+18+9TjZ1JKssQwOAfFNhLhwbbNxx/7/tSg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(346002)(396003)(39830400003)(136003)(451199015)(66556008)(66476007)(478600001)(8676002)(4326008)(66946007)(316002)(6486002)(54906003)(38100700002)(38350700002)(2616005)(1076003)(186003)(86362001)(26005)(6506007)(6512007)(52116002)(83380400001)(36756003)(8936002)(44832011)(7416002)(2906002)(5660300002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Qa/2bIdZTSIehx2xrp+ROKwGZPuJ3sUvMAwLOp6fGD7Y83zSposFYL4RSS4z7mB8B3wUZj/dSDJUUSNzWqajx/VrhlwOBNkQUYQxto7bXXYtLizBLfSmgG4jcEJKMmY60WTZczSHc+88oZhu3oO/06OSXlirjin7OWw/MIRK/x1ogbzZmhMFVJ1pertS0rRm//Bq5kZZXsy7o/7J6bVrrsE0YCXYx0m5+EgGkLGNRY8CWd/Ft65rEFrJoqiGWNjejQrufj/FM6EinheiQ2js+KmkncV5BkAC4/FBKuVnIQOyHp4M9HlnryAB78v9rksHD2rlIVGKTEqUszzo8E5i00kgvSQP80WBulXKT+vfnq3ey6i0HczeBPcjzi6Wu/ExVupL9xh4hIVqG1284TkCfS16MMbRB88Neqi8UL0TWJL50ooQ5QxoeOaYv+czzr/bJ324wC6Wcd7SV3l/iw04UQNCYpMBtFmGacL7hk9AXVo9BB/jNU/dU6Ewwlr+9r3BSmHUBCfAOPCO8scnvczjVKgu9uzMffR3parnAtjC2FzGE6lh3mgau1hSfhNCFZKdwekk02WrYH1s05f/L49QPQXpkRiHaTJ+MkvCQ/HckL10Bj8aoHyFAICf/eFNoyqXQbW3XEcznISEQ+eWrWLZReJBjsI3JhiY0vYjbypA/+k0wEvQVdXOS4jtdgDFesTYMATrQPg8t5I+CFTB3smdJGdVpy7h7LJ+wlXLNlRyse6EKavcpR7DtrMFDdGOPRNBI3jlnPkNlOsFmqLzDE0uMH+uOlNOxRidzcBLD4TRLincomyq5amXD7t5W1xPv8xa34d8i47DjzRlbJj1A9gCf5/T474x4NTBSdTuX8SgWoT51eUR7yanhZUf4dw6dc6DTdnxIg28d5qWw7KaRByDjNggCnTsNwjqMdWu3KbhQVwaTnJ5wQU9Vv81kis0GiW208FYlDxA0rmgGNA33eqFumCeoZt8FF/mfCBJcUqoGsg5QumKWwyZzFzupvReLgG/kSm4NigNMYJi8DgK930ciiiw44fWhQhGJSI6wIzT6bSSMoF5eAwcfTBwyNPdnfthEdICbpSIotnafbKl1CMqyjoKZ+mwZnqZtAo7SdU4yt2W2vlsEPC4EdYrcSIpoCPH2VpOEDJD0PRae5oHjX8tXOYnWTsbDrIyw41Y41g1Nhf4QDqkm9T/g3ZXI42K0PSKQ8a9scZ8lb4lQYq1loDQl+WF4cMRjJSDnmqUBvEk4htHjtE1lMR8f0boeYLSRevgIMAN6JlK8NtpgEwbkzN/a18g7U0SNiqUvVtehREL8V+zjHikh4YNnNdDnogCPXKa3D7Mu0CZglhxGINbqRFW7gWAbyS3Ow9FpvPyPFD4ShD2HT1KQkm0i5i4Tdlwc5Kjo9Wr6O40YJzcVR1dteFE1v8PYHar/WD4ZW6FCoAgEdoTRAsmVm8RcW6MavliDvu1vM9MyKCRzii8qgHsfaZtUGr6Nx0IctT3Ti8yai8dPNNzEBNt+MduN0jAMsXEHNlnqnKVOW+eVBRry4ZJxeJp7bP4E1dUplOQfuMK7tA80WfKSA5f2n+WJe+otnkiPbSj7KdY6TEAyMWa1D/9qJE4h2gmGgqzWihTfj8JD5OKEEY= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: f12891e9-c8a1-48e1-271a-08da9f564893 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:16.7453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mrEQB5ykCuuI/aTqe48R0WneSVxMp3bYTgB67iKxjw3MzRq80Lf6ndWYrx9UFjbPPx2ccp5Cr56w+Wc2QtJLmeXgoAwCzo1FQXb2t2jSGGw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6062 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Expose ocelot_wm functions so they can be shared with other drivers. Signed-off-by: Colin Foster Reviewed-by: Vladimir Oltean --- v1 - v3: * No changes since previous RFC --- drivers/net/ethernet/mscc/ocelot_devlink.c | 31 ++++++++++++++++++++++ drivers/net/ethernet/mscc/ocelot_vsc7514.c | 28 ------------------- include/soc/mscc/ocelot.h | 5 ++++ 3 files changed, 36 insertions(+), 28 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot_devlink.c b/drivers/net/ethernet/mscc/ocelot_devlink.c index b8737efd2a85..d9ea75a14f2f 100644 --- a/drivers/net/ethernet/mscc/ocelot_devlink.c +++ b/drivers/net/ethernet/mscc/ocelot_devlink.c @@ -487,6 +487,37 @@ static void ocelot_watermark_init(struct ocelot *ocelot) ocelot_setup_sharing_watermarks(ocelot); } +/* Watermark encode + * Bit 8: Unit; 0:1, 1:16 + * Bit 7-0: Value to be multiplied with unit + */ +u16 ocelot_wm_enc(u16 value) +{ + WARN_ON(value >= 16 * BIT(8)); + + if (value >= BIT(8)) + return BIT(8) | (value / 16); + + return value; +} +EXPORT_SYMBOL(ocelot_wm_enc); + +u16 ocelot_wm_dec(u16 wm) +{ + if (wm & BIT(8)) + return (wm & GENMASK(7, 0)) * 16; + + return wm; +} +EXPORT_SYMBOL(ocelot_wm_dec); + +void ocelot_wm_stat(u32 val, u32 *inuse, u32 *maxuse) +{ + *inuse = (val & GENMASK(23, 12)) >> 12; + *maxuse = val & GENMASK(11, 0); +} +EXPORT_SYMBOL(ocelot_wm_stat); + /* Pool size and type are fixed up at runtime. Keeping this structure to * look up the cell size multipliers. */ diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c index 6f22aea08a64..bac0ee9126f8 100644 --- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c +++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c @@ -234,34 +234,6 @@ static int ocelot_reset(struct ocelot *ocelot) return regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1); } -/* Watermark encode - * Bit 8: Unit; 0:1, 1:16 - * Bit 7-0: Value to be multiplied with unit - */ -static u16 ocelot_wm_enc(u16 value) -{ - WARN_ON(value >= 16 * BIT(8)); - - if (value >= BIT(8)) - return BIT(8) | (value / 16); - - return value; -} - -static u16 ocelot_wm_dec(u16 wm) -{ - if (wm & BIT(8)) - return (wm & GENMASK(7, 0)) * 16; - - return wm; -} - -static void ocelot_wm_stat(u32 val, u32 *inuse, u32 *maxuse) -{ - *inuse = (val & GENMASK(23, 12)) >> 12; - *maxuse = val & GENMASK(11, 0); -} - static const struct ocelot_ops ocelot_ops = { .reset = ocelot_reset, .wm_enc = ocelot_wm_enc, diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h index 967ba30ea636..55bbd5319128 100644 --- a/include/soc/mscc/ocelot.h +++ b/include/soc/mscc/ocelot.h @@ -1145,6 +1145,11 @@ void ocelot_port_assign_dsa_8021q_cpu(struct ocelot *ocelot, int port, int cpu); void ocelot_port_unassign_dsa_8021q_cpu(struct ocelot *ocelot, int port); u32 ocelot_port_assigned_dsa_8021q_cpu_mask(struct ocelot *ocelot, int port); +/* Watermark interface */ +u16 ocelot_wm_enc(u16 value); +u16 ocelot_wm_dec(u16 wm); +void ocelot_wm_stat(u32 val, u32 *inuse, u32 *maxuse); + /* DSA callbacks */ void ocelot_get_strings(struct ocelot *ocelot, int port, u32 sset, u8 *data); void ocelot_get_ethtool_stats(struct ocelot *ocelot, int port, u64 *data); From patchwork Mon Sep 26 00:29:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609874 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D06FCC6FA86 for ; Mon, 26 Sep 2022 00:30:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233095AbiIZAaY (ORCPT ); Sun, 25 Sep 2022 20:30:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233007AbiIZAaW (ORCPT ); Sun, 25 Sep 2022 20:30:22 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2093.outbound.protection.outlook.com [40.107.237.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF83DDFB; Sun, 25 Sep 2022 17:30:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LKsUTkpjOjCO90pI97oWXuu+qn1TIJE34BCr9kJUDfMaF21cqJcjv7ZyTq7mbrRM4GEmlj/4pBZCso2oFNeNWejiEhlBoQK6d0yQDr21/TDC5o0knHgdCfrk0EqluIaOnP7SZTDfiFFfWq/upQ6+IjdPRcch4ssFQ5nM1nJ8Q6ZBTmCDQOqGkVjGKMvjvR6fWzc8cpX8ysFk4s/zyerfOxVGLH1jmPz1ZKPZrMbbCzxcWjluPu7KSvC8yjoRfLi6eoR5T4X+rtAZzq7kYQAH0pb658tlbBmFFKi6YryT7TV/2HMQnGH88QxdGyj1bNKH+50TG41EHJfh6vPfsogXbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jqmBGl/Tg5V+/O9icejKCv5hf5v4n9ArjoewSzu+wQI=; b=ewrmnWj4O3ef053aDRseDD6IpvsBzyB3L72IZMMsOMmTf5SSK3Fygdka+5Idc/DTuvqemlLh2+JbizgKweRTx8ZFMSt6G2RPFjSOkae84aBfrDp7jwdlL/O2/UjxIuoFoLKAq4U7mFi4NdQ6qFLpKa1Ut2471kaCttVLMvqnkXZFDDuQhD2wsoKzUjiGfo2BoxU9i4GJXCbCXDKE8UFq5SL/sHtW4AStyOFligeX99KOpEZRBb6bV3VR8FCseC/Lb/KQJFiJMdBVRonl6zFwpSkbOhI4Yv2rXfkyqVFvLN5ZPKcEGLmdkjBm7+927Rdyukfb1UKmsc3WAGZZvcB3OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jqmBGl/Tg5V+/O9icejKCv5hf5v4n9ArjoewSzu+wQI=; b=HpYYdnm8uksE9ii+fMTkxvKSsEHLeEImGAVCv0XSJyB0M0OYrYT2Bds4PqnJIDo7b7SpAMnun2/07yjE72c4yXutWqy2dHqy8v7s24QCCvEEGJBuwDtW31U6I/TgALKLnWb0//tcLT2iM3MMRpGFlLqCDPNknf7OE25vz3I62gE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by DM4PR10MB6062.namprd10.prod.outlook.com (2603:10b6:8:b7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:17 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:17 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn , Vladimir Oltean Subject: [PATCH v3 net-next 02/14] net: mscc: ocelot: expose regfield definition to be used by other drivers Date: Sun, 25 Sep 2022 17:29:16 -0700 Message-Id: <20220926002928.2744638-3-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|DM4PR10MB6062:EE_ X-MS-Office365-Filtering-Correlation-Id: 03131806-734b-4a05-b914-08da9f56494a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hm+5rlTTPhRlTipTBtcNvIN+QSlETM4OhXBggJm91hCIRQMLKl7ICHoNijXnH5RP2GLBuOrrygkFlmaqeNBwO887X/JJIeUnFlYtOlE0Al02TBoqrpL7rIz61xN9Kufhnyt4KNN7tLBHBE5iCwQrdOfx0nNWDK40Rx18Gy6QWYATnL3H8uYDt98h1/cxFcWLkRpetxYvMCsGbFUDbX/aPIV1hMPHV1GYGapgOeZ4VMA+lwvkkQLUC27YApiqiyo5NxvVH+AGpTqYtPKNAbIQWc4T4KvGkP7vXZWXTc38NpH2bsAx62Mfs3RNMWKrvf07b9L7biX8Y7WHm5JCDVkqLCVkJtjf3mriNFC5rnO6uZPn+kMYn4zhiovFfVaWQiUe4ZC74QubUmRSoK19TJX1Q7JVXQPAIii7QT3q7BMJCptgy7l4owlwy/HyTWjlD4Rav0ldr6VjqkqZxwUkidsd5L02q77mwMwfJhlkg5Ri4zrk+9lVGEhQ7UrCLFzcUJYHMvd6j8vddrWt2ihXkvoGFYu7zwMuL5U1nJRDUXj1W9k+KGvarzF513XFyCLPB5BPtvfyilHgYMm8kQFQ+PPhcHTdgBK6AFbY4m4wbl4mPmg8Dnwbxj2tx73MXqBEn/6s5nh1IPq05wRqXdMQQ61zMqC7sPlrVa2dsB1NNem4LSZnD2hCsafteaFCa+jszwSH6wzVDDupderlEpJQg7GLUvHOfG3DBWdghjgoVOGua9x8tMOp0koW8KZX8EuQfrFD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(346002)(396003)(39830400003)(136003)(451199015)(66556008)(66476007)(478600001)(8676002)(4326008)(66946007)(316002)(6486002)(54906003)(38100700002)(38350700002)(2616005)(1076003)(186003)(86362001)(26005)(6506007)(6512007)(52116002)(83380400001)(36756003)(8936002)(30864003)(44832011)(7416002)(2906002)(5660300002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2ELHsbzoAK5+nLaFRAZ7SWYKCYshn7xlQtc5zT1Hzo8LV5P5JTUQfOYhBstZbQIl0mrZT0fIuh7nHLrTeIhbz/Xu8RvLrwERHir+jD2HE+fZ1MiZdWZirq8QwTIxXcBVqNc4fVRLrWP0rRF9WhSQpcmIB1BKTsNerMEbUQ5Bf2qbtUBCKriytFGydpeifyLheo9xyO5MrNk6nZMEyQUfn/UTuN1dAYET4yl3Q/qg5KBofKHnnMKvv7zdTc7WM7gzW/CrlbI2UTbDIUrypNfzP+4vpdLO079wTxsL87NE9cX7QAx9I510m2x3bF9Ex0Evqz7H/jY6Z6ZOs0mHB0Q0YAwBQZljbWYCEm+hdLtGay6SordQZvfaGvUEY0Pj/mOwjSCyeWwAGioXYTjrUo59bZrPRfjX1xAZNE5hYxdSY+BhMNfkrRDtBD6QDQqLaIxTEj4kuo1zGkmp2o4J32eUNlDO2/YldG0jKtSnE37BiN6Pzrk/tb+/baGNrgtDngLMYJdxSbSAzLp2rUNwpQTWUy//Enhigw0rt4s4otQG9kRN8Iv7c4AeAMQjr9JsYVhUea3HiIm9R5R4nF/JSlhDftkM8Eyzc7Jr92aSP8y59jzwQJpqTMgwgzyNZmgoJAQ1aXLQjnmufPAbaVFmlMc03nq7ejNIjlQFRux7hNP7z2DWg1j/1R6q6sC+B5Gl8FakdhGObMWowkfw3UYBcz5PJVEQsk8O33sb+vPZe1W9LU5EqhV/4Bmx0SatdmJqtgglQwqbfM/bIIEn5lc1NhyPJ1PLKoqwelK8+r6n/DSIegVQ9wzvycMXYQC+nF70MOcoj21sX9I2Pg6MqaHCqSeIluxFXHerFAgtmW4LT0CjazCdekZEEoM8qsHvYBZi4IsXgmMhXAwD7P9hqoJ8zaxQlmrs5kT2YjydPS+Hwbkv0vG8VqEAzmgqLercp0kYwjXkRAunx94RDwVkvYaysy3IW8C2+XiNBS1WwuCBfOp2yPPiKfuiv7PumctO7kHbf69Gq3YCpG+ABW+5vfJoNhieJGndyqSxm2sRQGQxXd+suxKjt+Fyig3uxYdIf+EiKOwhC1fNnnScqAzYfoxLIxWKQLDyek81kR07NTaCKuBmwkAxZ42PiB1NpNUnh3JxebOuCbi4iPoFmV0daTHmMToXYxBOTrKZ1zFMEdjSPs1goNAJZwaf2kQ/fRu8Qey62aWeYq/P6d8lrgmTT7oMf6xr0amL8Mj5hVVrH+Z6bcty507ott7elM0VhCDtSbDbAO5/va9ZtCPUBIPVTGyIvQzJN45+iNicfTuvGJUkwx0clhFLB6RAnXbF+p+fuwjtKSq9EzPEOAafyteSUQYCJsJkh901apEhOAAZX8xLI8g0nsxbVSYVa8TCjiIz4gtgz+0hkj/VRgtNJ1Rv16of3GjkVF8IzV0azJ05jNk+7flAzsDA7rq4yLZ4VABf7GX3pIKNcenyZ/r2UN+qbk9ogWad06Xk0fpLc6W3XKGeMI/kNThGx1kIHhpsl3ptHjrMVnE4XoshiQJrehP8wk74XQp6q1ZU3YkGhE3ghMhGhjVFVm9ycnyO+XwTdNjryldgMnqEUYi6tNiZMxMWUPhvqEvz4g== X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03131806-734b-4a05-b914-08da9f56494a X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:17.7140 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hhQnOLthD7qnqV7osvJR1DwFidpqKev21pABYWP/e9dJtKXduzNToUZ0hVBoR4s7aRbK0oUQ+XsDgdPZ4eQHy8jwApLBNUoVTFX26ImPa9U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6062 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The ocelot_regfields struct is common between several different chips, some of which can only be controlled externally. Export this structure so it doesn't have to be duplicated in these other drivers. Rename the structure as well, to follow the conventions of other shared resources. Signed-off-by: Colin Foster Reviewed-by: Vladimir Oltean --- v3 * No changes v2 * Add Reviewed tag v1 from previous RFC: * Remove GCB_SOFT_RST_SWC_RST entry from the regfields struct - it isn't used. * Export the vsc7514_regfields symbol so it can be used as a module. --- drivers/net/ethernet/mscc/ocelot_vsc7514.c | 60 +--------------------- drivers/net/ethernet/mscc/vsc7514_regs.c | 59 +++++++++++++++++++++ include/soc/mscc/vsc7514_regs.h | 2 + 3 files changed, 62 insertions(+), 59 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c index bac0ee9126f8..6d695375b14b 100644 --- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c +++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c @@ -42,64 +42,6 @@ static const u32 *ocelot_regmap[TARGET_MAX] = { [DEV_GMII] = vsc7514_dev_gmii_regmap, }; -static const struct reg_field ocelot_regfields[REGFIELD_MAX] = { - [ANA_ADVLEARN_VLAN_CHK] = REG_FIELD(ANA_ADVLEARN, 11, 11), - [ANA_ADVLEARN_LEARN_MIRROR] = REG_FIELD(ANA_ADVLEARN, 0, 10), - [ANA_ANEVENTS_MSTI_DROP] = REG_FIELD(ANA_ANEVENTS, 27, 27), - [ANA_ANEVENTS_ACLKILL] = REG_FIELD(ANA_ANEVENTS, 26, 26), - [ANA_ANEVENTS_ACLUSED] = REG_FIELD(ANA_ANEVENTS, 25, 25), - [ANA_ANEVENTS_AUTOAGE] = REG_FIELD(ANA_ANEVENTS, 24, 24), - [ANA_ANEVENTS_VS2TTL1] = REG_FIELD(ANA_ANEVENTS, 23, 23), - [ANA_ANEVENTS_STORM_DROP] = REG_FIELD(ANA_ANEVENTS, 22, 22), - [ANA_ANEVENTS_LEARN_DROP] = REG_FIELD(ANA_ANEVENTS, 21, 21), - [ANA_ANEVENTS_AGED_ENTRY] = REG_FIELD(ANA_ANEVENTS, 20, 20), - [ANA_ANEVENTS_CPU_LEARN_FAILED] = REG_FIELD(ANA_ANEVENTS, 19, 19), - [ANA_ANEVENTS_AUTO_LEARN_FAILED] = REG_FIELD(ANA_ANEVENTS, 18, 18), - [ANA_ANEVENTS_LEARN_REMOVE] = REG_FIELD(ANA_ANEVENTS, 17, 17), - [ANA_ANEVENTS_AUTO_LEARNED] = REG_FIELD(ANA_ANEVENTS, 16, 16), - [ANA_ANEVENTS_AUTO_MOVED] = REG_FIELD(ANA_ANEVENTS, 15, 15), - [ANA_ANEVENTS_DROPPED] = REG_FIELD(ANA_ANEVENTS, 14, 14), - [ANA_ANEVENTS_CLASSIFIED_DROP] = REG_FIELD(ANA_ANEVENTS, 13, 13), - [ANA_ANEVENTS_CLASSIFIED_COPY] = REG_FIELD(ANA_ANEVENTS, 12, 12), - [ANA_ANEVENTS_VLAN_DISCARD] = REG_FIELD(ANA_ANEVENTS, 11, 11), - [ANA_ANEVENTS_FWD_DISCARD] = REG_FIELD(ANA_ANEVENTS, 10, 10), - [ANA_ANEVENTS_MULTICAST_FLOOD] = REG_FIELD(ANA_ANEVENTS, 9, 9), - [ANA_ANEVENTS_UNICAST_FLOOD] = REG_FIELD(ANA_ANEVENTS, 8, 8), - [ANA_ANEVENTS_DEST_KNOWN] = REG_FIELD(ANA_ANEVENTS, 7, 7), - [ANA_ANEVENTS_BUCKET3_MATCH] = REG_FIELD(ANA_ANEVENTS, 6, 6), - [ANA_ANEVENTS_BUCKET2_MATCH] = REG_FIELD(ANA_ANEVENTS, 5, 5), - [ANA_ANEVENTS_BUCKET1_MATCH] = REG_FIELD(ANA_ANEVENTS, 4, 4), - [ANA_ANEVENTS_BUCKET0_MATCH] = REG_FIELD(ANA_ANEVENTS, 3, 3), - [ANA_ANEVENTS_CPU_OPERATION] = REG_FIELD(ANA_ANEVENTS, 2, 2), - [ANA_ANEVENTS_DMAC_LOOKUP] = REG_FIELD(ANA_ANEVENTS, 1, 1), - [ANA_ANEVENTS_SMAC_LOOKUP] = REG_FIELD(ANA_ANEVENTS, 0, 0), - [ANA_TABLES_MACACCESS_B_DOM] = REG_FIELD(ANA_TABLES_MACACCESS, 18, 18), - [ANA_TABLES_MACTINDX_BUCKET] = REG_FIELD(ANA_TABLES_MACTINDX, 10, 11), - [ANA_TABLES_MACTINDX_M_INDEX] = REG_FIELD(ANA_TABLES_MACTINDX, 0, 9), - [QSYS_TIMED_FRAME_ENTRY_TFRM_VLD] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 20, 20), - [QSYS_TIMED_FRAME_ENTRY_TFRM_FP] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 8, 19), - [QSYS_TIMED_FRAME_ENTRY_TFRM_PORTNO] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 4, 7), - [QSYS_TIMED_FRAME_ENTRY_TFRM_TM_SEL] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 1, 3), - [QSYS_TIMED_FRAME_ENTRY_TFRM_TM_T] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 0, 0), - [SYS_RESET_CFG_CORE_ENA] = REG_FIELD(SYS_RESET_CFG, 2, 2), - [SYS_RESET_CFG_MEM_ENA] = REG_FIELD(SYS_RESET_CFG, 1, 1), - [SYS_RESET_CFG_MEM_INIT] = REG_FIELD(SYS_RESET_CFG, 0, 0), - /* Replicated per number of ports (12), register size 4 per port */ - [QSYS_SWITCH_PORT_MODE_PORT_ENA] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 14, 14, 12, 4), - [QSYS_SWITCH_PORT_MODE_SCH_NEXT_CFG] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 11, 13, 12, 4), - [QSYS_SWITCH_PORT_MODE_YEL_RSRVD] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 10, 10, 12, 4), - [QSYS_SWITCH_PORT_MODE_INGRESS_DROP_MODE] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 9, 9, 12, 4), - [QSYS_SWITCH_PORT_MODE_TX_PFC_ENA] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 1, 8, 12, 4), - [QSYS_SWITCH_PORT_MODE_TX_PFC_MODE] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 0, 0, 12, 4), - [SYS_PORT_MODE_DATA_WO_TS] = REG_FIELD_ID(SYS_PORT_MODE, 5, 6, 12, 4), - [SYS_PORT_MODE_INCL_INJ_HDR] = REG_FIELD_ID(SYS_PORT_MODE, 3, 4, 12, 4), - [SYS_PORT_MODE_INCL_XTR_HDR] = REG_FIELD_ID(SYS_PORT_MODE, 1, 2, 12, 4), - [SYS_PORT_MODE_INCL_HDR_ERR] = REG_FIELD_ID(SYS_PORT_MODE, 0, 0, 12, 4), - [SYS_PAUSE_CFG_PAUSE_START] = REG_FIELD_ID(SYS_PAUSE_CFG, 10, 18, 12, 4), - [SYS_PAUSE_CFG_PAUSE_STOP] = REG_FIELD_ID(SYS_PAUSE_CFG, 1, 9, 12, 4), - [SYS_PAUSE_CFG_PAUSE_ENA] = REG_FIELD_ID(SYS_PAUSE_CFG, 0, 1, 12, 4), -}; - static const struct ocelot_stat_layout ocelot_stats_layout[OCELOT_NUM_STATS] = { OCELOT_COMMON_STATS, }; @@ -142,7 +84,7 @@ static int ocelot_chip_init(struct ocelot *ocelot, const struct ocelot_ops *ops) ocelot->num_mact_rows = 1024; ocelot->ops = ops; - ret = ocelot_regfields_init(ocelot, ocelot_regfields); + ret = ocelot_regfields_init(ocelot, vsc7514_regfields); if (ret) return ret; diff --git a/drivers/net/ethernet/mscc/vsc7514_regs.c b/drivers/net/ethernet/mscc/vsc7514_regs.c index 9d2d3e13cacf..123175618251 100644 --- a/drivers/net/ethernet/mscc/vsc7514_regs.c +++ b/drivers/net/ethernet/mscc/vsc7514_regs.c @@ -9,6 +9,65 @@ #include #include "ocelot.h" +const struct reg_field vsc7514_regfields[REGFIELD_MAX] = { + [ANA_ADVLEARN_VLAN_CHK] = REG_FIELD(ANA_ADVLEARN, 11, 11), + [ANA_ADVLEARN_LEARN_MIRROR] = REG_FIELD(ANA_ADVLEARN, 0, 10), + [ANA_ANEVENTS_MSTI_DROP] = REG_FIELD(ANA_ANEVENTS, 27, 27), + [ANA_ANEVENTS_ACLKILL] = REG_FIELD(ANA_ANEVENTS, 26, 26), + [ANA_ANEVENTS_ACLUSED] = REG_FIELD(ANA_ANEVENTS, 25, 25), + [ANA_ANEVENTS_AUTOAGE] = REG_FIELD(ANA_ANEVENTS, 24, 24), + [ANA_ANEVENTS_VS2TTL1] = REG_FIELD(ANA_ANEVENTS, 23, 23), + [ANA_ANEVENTS_STORM_DROP] = REG_FIELD(ANA_ANEVENTS, 22, 22), + [ANA_ANEVENTS_LEARN_DROP] = REG_FIELD(ANA_ANEVENTS, 21, 21), + [ANA_ANEVENTS_AGED_ENTRY] = REG_FIELD(ANA_ANEVENTS, 20, 20), + [ANA_ANEVENTS_CPU_LEARN_FAILED] = REG_FIELD(ANA_ANEVENTS, 19, 19), + [ANA_ANEVENTS_AUTO_LEARN_FAILED] = REG_FIELD(ANA_ANEVENTS, 18, 18), + [ANA_ANEVENTS_LEARN_REMOVE] = REG_FIELD(ANA_ANEVENTS, 17, 17), + [ANA_ANEVENTS_AUTO_LEARNED] = REG_FIELD(ANA_ANEVENTS, 16, 16), + [ANA_ANEVENTS_AUTO_MOVED] = REG_FIELD(ANA_ANEVENTS, 15, 15), + [ANA_ANEVENTS_DROPPED] = REG_FIELD(ANA_ANEVENTS, 14, 14), + [ANA_ANEVENTS_CLASSIFIED_DROP] = REG_FIELD(ANA_ANEVENTS, 13, 13), + [ANA_ANEVENTS_CLASSIFIED_COPY] = REG_FIELD(ANA_ANEVENTS, 12, 12), + [ANA_ANEVENTS_VLAN_DISCARD] = REG_FIELD(ANA_ANEVENTS, 11, 11), + [ANA_ANEVENTS_FWD_DISCARD] = REG_FIELD(ANA_ANEVENTS, 10, 10), + [ANA_ANEVENTS_MULTICAST_FLOOD] = REG_FIELD(ANA_ANEVENTS, 9, 9), + [ANA_ANEVENTS_UNICAST_FLOOD] = REG_FIELD(ANA_ANEVENTS, 8, 8), + [ANA_ANEVENTS_DEST_KNOWN] = REG_FIELD(ANA_ANEVENTS, 7, 7), + [ANA_ANEVENTS_BUCKET3_MATCH] = REG_FIELD(ANA_ANEVENTS, 6, 6), + [ANA_ANEVENTS_BUCKET2_MATCH] = REG_FIELD(ANA_ANEVENTS, 5, 5), + [ANA_ANEVENTS_BUCKET1_MATCH] = REG_FIELD(ANA_ANEVENTS, 4, 4), + [ANA_ANEVENTS_BUCKET0_MATCH] = REG_FIELD(ANA_ANEVENTS, 3, 3), + [ANA_ANEVENTS_CPU_OPERATION] = REG_FIELD(ANA_ANEVENTS, 2, 2), + [ANA_ANEVENTS_DMAC_LOOKUP] = REG_FIELD(ANA_ANEVENTS, 1, 1), + [ANA_ANEVENTS_SMAC_LOOKUP] = REG_FIELD(ANA_ANEVENTS, 0, 0), + [ANA_TABLES_MACACCESS_B_DOM] = REG_FIELD(ANA_TABLES_MACACCESS, 18, 18), + [ANA_TABLES_MACTINDX_BUCKET] = REG_FIELD(ANA_TABLES_MACTINDX, 10, 11), + [ANA_TABLES_MACTINDX_M_INDEX] = REG_FIELD(ANA_TABLES_MACTINDX, 0, 9), + [QSYS_TIMED_FRAME_ENTRY_TFRM_VLD] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 20, 20), + [QSYS_TIMED_FRAME_ENTRY_TFRM_FP] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 8, 19), + [QSYS_TIMED_FRAME_ENTRY_TFRM_PORTNO] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 4, 7), + [QSYS_TIMED_FRAME_ENTRY_TFRM_TM_SEL] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 1, 3), + [QSYS_TIMED_FRAME_ENTRY_TFRM_TM_T] = REG_FIELD(QSYS_TIMED_FRAME_ENTRY, 0, 0), + [SYS_RESET_CFG_CORE_ENA] = REG_FIELD(SYS_RESET_CFG, 2, 2), + [SYS_RESET_CFG_MEM_ENA] = REG_FIELD(SYS_RESET_CFG, 1, 1), + [SYS_RESET_CFG_MEM_INIT] = REG_FIELD(SYS_RESET_CFG, 0, 0), + /* Replicated per number of ports (12), register size 4 per port */ + [QSYS_SWITCH_PORT_MODE_PORT_ENA] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 14, 14, 12, 4), + [QSYS_SWITCH_PORT_MODE_SCH_NEXT_CFG] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 11, 13, 12, 4), + [QSYS_SWITCH_PORT_MODE_YEL_RSRVD] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 10, 10, 12, 4), + [QSYS_SWITCH_PORT_MODE_INGRESS_DROP_MODE] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 9, 9, 12, 4), + [QSYS_SWITCH_PORT_MODE_TX_PFC_ENA] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 1, 8, 12, 4), + [QSYS_SWITCH_PORT_MODE_TX_PFC_MODE] = REG_FIELD_ID(QSYS_SWITCH_PORT_MODE, 0, 0, 12, 4), + [SYS_PORT_MODE_DATA_WO_TS] = REG_FIELD_ID(SYS_PORT_MODE, 5, 6, 12, 4), + [SYS_PORT_MODE_INCL_INJ_HDR] = REG_FIELD_ID(SYS_PORT_MODE, 3, 4, 12, 4), + [SYS_PORT_MODE_INCL_XTR_HDR] = REG_FIELD_ID(SYS_PORT_MODE, 1, 2, 12, 4), + [SYS_PORT_MODE_INCL_HDR_ERR] = REG_FIELD_ID(SYS_PORT_MODE, 0, 0, 12, 4), + [SYS_PAUSE_CFG_PAUSE_START] = REG_FIELD_ID(SYS_PAUSE_CFG, 10, 18, 12, 4), + [SYS_PAUSE_CFG_PAUSE_STOP] = REG_FIELD_ID(SYS_PAUSE_CFG, 1, 9, 12, 4), + [SYS_PAUSE_CFG_PAUSE_ENA] = REG_FIELD_ID(SYS_PAUSE_CFG, 0, 1, 12, 4), +}; +EXPORT_SYMBOL(vsc7514_regfields); + const u32 vsc7514_ana_regmap[] = { REG(ANA_ADVLEARN, 0x009000), REG(ANA_VLANMASK, 0x009004), diff --git a/include/soc/mscc/vsc7514_regs.h b/include/soc/mscc/vsc7514_regs.h index ceee26c96959..9b40e7d00ec5 100644 --- a/include/soc/mscc/vsc7514_regs.h +++ b/include/soc/mscc/vsc7514_regs.h @@ -10,6 +10,8 @@ #include +extern const struct reg_field vsc7514_regfields[REGFIELD_MAX]; + extern const u32 vsc7514_ana_regmap[]; extern const u32 vsc7514_qs_regmap[]; extern const u32 vsc7514_qsys_regmap[]; From patchwork Mon Sep 26 00:29:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609441 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA23C6FA90 for ; Mon, 26 Sep 2022 00:30:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233108AbiIZAaZ (ORCPT ); Sun, 25 Sep 2022 20:30:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233071AbiIZAaX (ORCPT ); Sun, 25 Sep 2022 20:30:23 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2093.outbound.protection.outlook.com [40.107.237.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C2AE22BE6; Sun, 25 Sep 2022 17:30:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLK/VDxO9cZ+tFZVJ0x1samhmhyHGp4N8RNF4Uheew2o1wikxRD2Ymrkxqg0oARZ1V5P3uFRojkwL0rmNYCed5nT6Qenm709ilJbqsXnvUkcOWw6r4beeZZQ14Ep1i2pHh4OVx7IypmnkU8mXCB16OssszF40VAZFIhspMqIs382viT23DLpYzKTHc7ZYTt7epM56eBoLmubOWZbOqYO1+HomS1QAdhLNnF47Q0ouVMvclenTq4Sn0OkXsZy9O5RF5jgMa4kpY6sbTokSv4bX24RIbASJJT+Eldp5F10D8eZS6SqIT5hHFgCw+wIKVePR4haRezc1ija57qKY4cddw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tiNDagnBU7jhkphoxY+DLKG3LATJEVQTXOGPVfI5hyk=; b=OA82U62NfiI07eLhWo6YtlZEGhYiXNFyAkrRsyQ29Hx/E5ufn8wouLdtBKTwTmTisvPpMGjMy3uA5EoE82psIe4SgU+UTR1Agrkcfrdp0/73i0QBC7eSvzPGTxf8h9aGGCxq/POy+cl0ghhXFnhgemS7NVWExRtR6UyX+RLFQ721QztaPxIH8HAwhmhay9M5q/8DI94See+6K2T8tIDgdIGWRLLkubiyTDU4BV/iNzAvhmqLAFmY7fl85ZlYuC7hmzs8IQCM6UF5iXHbyusYPCcfSF3Za0VvbNGrvS2A8S9zT8b4lRFb+A4YPb+EPxG3aRteiHbYEInYZ1KLXBk1vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tiNDagnBU7jhkphoxY+DLKG3LATJEVQTXOGPVfI5hyk=; b=Eq4smpSZnRnH7K6fWc12aO88rwnXqp5y+JiE69fzVkLV9vb8QJW2yqX6iU+pbflXBJmIhCg0QhDyya5ZweAoe8kfw2yju7yxBdM9p4brzoMhqFZBRxER0KphU7kq751fthnKpzNffPOXycJjjuIOjVlk7m7Hnqsh9+KsFnb+UxY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by DM4PR10MB6062.namprd10.prod.outlook.com (2603:10b6:8:b7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:19 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:19 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 03/14] net: mscc: ocelot: expose stats layout definition to be used by other drivers Date: Sun, 25 Sep 2022 17:29:17 -0700 Message-Id: <20220926002928.2744638-4-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|DM4PR10MB6062:EE_ X-MS-Office365-Filtering-Correlation-Id: 18a14859-f204-41db-9a8e-08da9f5649f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: szOhbQv4Hrk0GZYRizyNyDWnVdofpXNfCrc6H1WxYl5w25k+nZrKOh5fxXEYA9p7uoVQVKWpCG+h4iTh55btR27D9qWfpevKRtbg7ZEGZxp4z12y8km7pbh8FFpwi2LjDmjmZ5eoV/fsDPCwzp7f80CgOaQc0vK1uPyanp9Ti3ifZUbtOlaWm7VDT6VB5xfcl4D0HdMH0+jfrmuDDeR6evtWQtHaKxo0D786WjEpXfxQBdGMxrFrMyGCW6v4W6gAo+2e1ZQkuiTf7aVNGHbqUv4G+bBxpSxxvOEejT/M8EQjtKKVzHRqmUmmEtEwC2kHJhnZknloe8XR1TByNx2JGUzjpWCfe0Sjn0/BOWvlKC2/MmvCsnXQyTpcAxP39Rv2cch9nEeeOWKSRVMdBiuy4EmM93xjzsYNHGL0qeiMBWRcKcm2vbZ3nyR+IdOQ/buLCpF+/HZw+XjViDZgWlb6ZuFT6EYHDZpJcTPkWpJffzVekhMmqUxbNzMWvfoC1W3wpgWnM7OtNgAjWWiQZ0PoXyBCCE6MHP8Gl54XVMExSI3SBpasHv6yvwj0HHL/GtzEcISUEgXYThQaJWyNomTvSSyc1taNhnAXtl6byQ+M52JK5yOwK0diV+7BE2XBHPskSMTjjFaat6fUH1FPlXvoa2/r2QSG7qcZZI46dbKVzXWKq+tCcY4S0UzxiRQOgDeQYZw0XjR0XmmbLSvF1K4AejHu94uw7hnQmjQC1mv2NLcgLY88/zxfV8FqoSDhYikCj7b2PlA0toJGOzma6WBrlA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(346002)(396003)(39830400003)(136003)(451199015)(66556008)(66476007)(478600001)(8676002)(4326008)(66946007)(316002)(6486002)(54906003)(38100700002)(38350700002)(2616005)(1076003)(186003)(86362001)(26005)(6506007)(6512007)(52116002)(83380400001)(36756003)(8936002)(44832011)(7416002)(2906002)(5660300002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GixZSHPjhO6cOpjyGgxqH616tFuIm/zlSfeidtpSskMKqbrR6O47mqHZblWFrUvNXbE/PixAX5jspq3di1On9FPx6R3MKC/faAAT6H/YvhHSc23nQUfsORabVdvubZktGhNUomj5gbdoDwY4+9GV7YwXNlcbiBFFQ3PYFwc8R9Eo2YOoLKRq+bd8jEq6iEm2CqGTaaojwgN8gYEoCLeqMRKG/FxVE58VmoRztJiY+yYQ7PF6kFWl/x7r44C0SSlMZ8UaAhnb9haMYyEAHkb4LKSdFd7TVBMILu3IZk9fAGnvgfhWJhBCLR2R1k5Op8SkEcj4wny2gIIR98tZU4QKvoAph28lL4BIsOMORjhpMEKXUfeLJlO5JzbhFbdiR1O/gyrDc4HsfELZ5KBXBEDV8sCksJwGYL7k769tKbIpJpcdO+iolbwGvlJ+xFUYhrWco47BTRfCtpB++3MQ06VmIqJp1KhWdN2zGz7Hc4rTve2sLZmJo21Ro+voIf3RD32R8x0aHUIz++Achtt6kgRZl3jALG0wfPkwu2qE5wc/speQ+dN/H4NSYHxN2kl2WpTP/xjXhvz8NF6QiVTnIRNdIvxBbhCuSUHoLcWTJqOaxpP33T5HPJVDrPbswRAzXL/JOXJ1C+c0uHvB3kmAsG67GDwtc7C2869b9SE5PTgesepu9f++359lQsj6DitK64F1WLQA/9GCXRj+CId5LhA1zaYdoYgPqWzp1MNaITSvpwBdqZPL4K3sWZCyQgKD33cSTxIO9QNsxayDK+5FNWtieOrIBJxEUxmhMCBDm8XjwwgC/lr0E7TnCF7kCdaTsW72RhO0bo9UnQqENud6qarn+PEqp1OA425kPGRRJpsQIt3PAMnXIlXCLJc1U8oJlL7gOjpBlgUQqUEqAMDHg7KHVTKvICTRA8ktZPMSktu9u7JsZpiWuhMuLLpgemmFpKQCB2IrUT9HXLCvBNJokIaO7+/6YKWr4sCGKXWxsRGeaDnH1va621MWrk9wtquWtR9lidt7T/OSS2gc+KIy3XX3jLVwCZ9CVBeo19z8lf0X78SQwvxJYQ/+akcjzeoEbgT/f+e3WrjJKX9A7B3WNKvOhevkWTN7V9AUA+uutxIpSPZCzP4eXJ33VQGFVze7M6reUqyS+rf81Uz2Rvsw4dvEokiXl28XrM/zqzuknQxKrjPMYYpMDgd/dWfBffSESAeYlkt8zgu0EjFiBSnBjJ33IIgn+2fqZGbF1BXRCs7ERWo56H52fAWj8myGyoGyGyiGXhrIrqwDmmdFobfvsUO4SLSSZ5WHA+qFqa2Qeh9E8t7283BUe/Ky3QqrwxLnjFrnz9kIindqKjdeqPkKVUnVhIuztfiyG3IEn505YO1sSR5VIilrEnDlfA4RHjMChuMlxedASxGROUKQnTxE5fKU7ullLtwxMqj4t11SCuW5s1EB16d3xZlEkkqq6ZoIDXJJKV65gCm9kc0bOqKadorDO4lsvFESxsq0rRGs2qvBtHeNdSuluV9QQN5tsLGZ+TxtFhJHITdmwH2xcW4ngwdL0AMetkCVFWkbRSC9rcIbCDZ3A+2YsiAjbeW9FKvcgG3Qs4YG+nEjmITFS5hpxY50jw== X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18a14859-f204-41db-9a8e-08da9f5649f1 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:18.9170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mgMx/n4LckT9H1hr7RyMPa9PPn2DneOeLn+jncFGpHOlk0L1Vyhu0yPgkRVZszmNLFIGSylzGhuu4QDi8w0BmgLiJB4QGui5Yjj9wwBFy6w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6062 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The ocelot_stats_layout array is common between several different chips, some of which can only be controlled externally. Export this structure so it doesn't have to be duplicated in these other drivers. Rename the structure as well, to follow the conventions of other shared resources. Signed-off-by: Colin Foster --- v2 & v3 * No change v1 from previous RFC: * Utilize OCELOT_COMMON_STATS --- drivers/net/ethernet/mscc/ocelot_vsc7514.c | 6 +----- drivers/net/ethernet/mscc/vsc7514_regs.c | 5 +++++ include/soc/mscc/vsc7514_regs.h | 3 +++ 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c index 6d695375b14b..4fb525f071ac 100644 --- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c +++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c @@ -42,10 +42,6 @@ static const u32 *ocelot_regmap[TARGET_MAX] = { [DEV_GMII] = vsc7514_dev_gmii_regmap, }; -static const struct ocelot_stat_layout ocelot_stats_layout[OCELOT_NUM_STATS] = { - OCELOT_COMMON_STATS, -}; - static void ocelot_pll5_init(struct ocelot *ocelot) { /* Configure PLL5. This will need a proper CCF driver @@ -80,7 +76,7 @@ static int ocelot_chip_init(struct ocelot *ocelot, const struct ocelot_ops *ops) int ret; ocelot->map = ocelot_regmap; - ocelot->stats_layout = ocelot_stats_layout; + ocelot->stats_layout = vsc7514_stats_layout; ocelot->num_mact_rows = 1024; ocelot->ops = ops; diff --git a/drivers/net/ethernet/mscc/vsc7514_regs.c b/drivers/net/ethernet/mscc/vsc7514_regs.c index 123175618251..d665522e18c6 100644 --- a/drivers/net/ethernet/mscc/vsc7514_regs.c +++ b/drivers/net/ethernet/mscc/vsc7514_regs.c @@ -9,6 +9,11 @@ #include #include "ocelot.h" +const struct ocelot_stat_layout vsc7514_stats_layout[OCELOT_NUM_STATS] = { + OCELOT_COMMON_STATS, +}; +EXPORT_SYMBOL(vsc7514_stats_layout); + const struct reg_field vsc7514_regfields[REGFIELD_MAX] = { [ANA_ADVLEARN_VLAN_CHK] = REG_FIELD(ANA_ADVLEARN, 11, 11), [ANA_ADVLEARN_LEARN_MIRROR] = REG_FIELD(ANA_ADVLEARN, 0, 10), diff --git a/include/soc/mscc/vsc7514_regs.h b/include/soc/mscc/vsc7514_regs.h index 9b40e7d00ec5..d2b5b6b86aff 100644 --- a/include/soc/mscc/vsc7514_regs.h +++ b/include/soc/mscc/vsc7514_regs.h @@ -8,8 +8,11 @@ #ifndef VSC7514_REGS_H #define VSC7514_REGS_H +#include #include +extern const struct ocelot_stat_layout vsc7514_stats_layout[]; + extern const struct reg_field vsc7514_regfields[REGFIELD_MAX]; extern const u32 vsc7514_ana_regmap[]; From patchwork Mon Sep 26 00:29:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609873 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7496C6FA82 for ; Mon, 26 Sep 2022 00:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233169AbiIZAbF (ORCPT ); Sun, 25 Sep 2022 20:31:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233071AbiIZAaq (ORCPT ); Sun, 25 Sep 2022 20:30:46 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2111.outbound.protection.outlook.com [40.107.96.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 097242315B; Sun, 25 Sep 2022 17:30:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TPOayuycVuR4qJWCFLyR2DhPlNGxbNC0yAOlbJzn7EselYLmdb+a2Q7+7iPw1UTR/2QkXYdwAfP5mmexpRWFjP31GvqrMSeQT/FvVisRN3cFYs/ss1NabkOb0z+vsGUHWlqHQ9HHmtb4ivF7Gxb4+y6NXc4iFqR9hEInBdu8QsymB05htFG4WwfxoaPCWWgr61fZIy0fnLPGYgMFvSVcCJulD+8R3owOfTNFdy8PkGbKrKAD62sJ31RNY/jQDdJVTPHd3ltJsFFzHozcvXt/F5dVf1tnq7N+IQnYo5k/Nbuy+8gcZKS3gLL/hEey++wh4fVOtoRQZCLsxLyQieRLbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SEnT12yDQn/2CStU+JEIT/KF/tslpV317IZjBR8XkUg=; b=e9kUm6aVwmkT9FwXNIqAe3W6GIts26m6mGzAOJ+GHE5cMvOxfRsBam83xuq1jDDNyefCjo3aqmjlyXA1HSeulsp7Tdj0da6ty34Mae3dWax1W73NbbRmTgMc/DC2cOooV4x0upTW/5MhCzigWUbPIlJgj34mD79v92zH7yyDRsPqTePUmGTwjfENKet+Tp4XDhrlZRe2qlca+55lRcxUBVsK8fcD3daKakf7zybEqVwJ75hX0L0uJDJ84oFK8ZAnkuQISl+tKC/he8lPeswJ0P5rz4+hTNPTjES1DgOEvFrGvUVVYW166xYuyTnpBMRJjS3JJ484449jrWbu4Z2ILQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SEnT12yDQn/2CStU+JEIT/KF/tslpV317IZjBR8XkUg=; b=OWZnBOsdauMEXe5kNJI2is1QQ99a5bSxahhDN/KdtP78/+pRVrxgBLz4Qn1DgnTftGvmUplIozYhYWkMKjF6TjqM/0k9o0r6TjpRECH7WAjOynE4bx47aale2JNWsPF+r9t7poq1+DlofGlGo9VGJU69omNDZyRvi6pFKuPOr8w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:21 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:20 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 04/14] net: mscc: ocelot: expose vcap_props structure Date: Sun, 25 Sep 2022 17:29:18 -0700 Message-Id: <20220926002928.2744638-5-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f884599-2477-4da1-9f3e-08da9f564add X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QzFBDP0Pu2k1fR9UgYV5t4/wIbjYZZI/6sHXzaBocSa+erBILorE3HKj/8ixkfULcCvBngmybrHkLwpbMGBVvrbl3pbK+cfQ65+AmjS7opPUZ14NoU/e6NEue8dRIlbcC6wFcx4YPFSNZX3nhybTgKct+/v+zSZ08F05x+nd1n/uPZ9W692Evyfx4IVp6jUlO6E/iWcEvnYigHo0lQZFRNHy1vVefSdMWhTz2ikIwq8fSLG0ta7hrbmiUQci9opmbKyJKpeR/0WmzTaHYqEEUwZY/CebwxM9ZKpzylMcmIxJNdYG0JmIdn6Q9Zdm4q1o87y3SxX+xB0r4r4gymkqNa31jj8FsvWEhcU8g2vowfFJq3cb9Sn1YksarTIG9N0wJWpwo45Tr0EOQcF7jgoT++SqIt+m5w4GtuH4cB5c2Q2sCJB4sIpxkQAulSu6eTMRIE1feQPKdh3o/tIC4cBRMo3YaW4H0ZFErPi9GFqTo/Y8TX9788jN8JKgdZpifvNB9ijXYvgWMpEFEj4YLgepCCY4ikRC85r4flEmEMbXGTmu42vMjUBByyBwu0M8r8+4YM2eyerpAUhlL42qlS0kdVCp8nH85Rfiz5PxgVKDbsK60aLHxwvl3W6wCQ7KUY7J36Xrt0OhnU2ImyXb5kVj+k0jOsTi7XJ3fXLEQlWZdj9VtC+AA9sofhbx5jBwD+uhG30ygSuUCM2f5rVUwOUrdliqK1MMyXJ20nZN/180YbQ/kLO2JSBQf0UhcPUaFSTXGrwHiRkmMZV4TYtnjZmfOg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(41300700001)(83380400001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: SJadmQZwkdF+UaIFSP4HEDGKCiJXPWXEuKwtX1NthyFjxsM2ptvpwnDayZNQE15aKMom/U3s7Msnw07pSHfC6F9iHW3PK4Cj8g9GYgyLuOj9YwA2vRamFzvs3YhrkjJMBi3i8nESya5xYbqjsO6wzjsFCOlMrFmMejMTBla1x8wOewRcl1Z4ykqGujFK22LhXQDCF02oxWUQRUZUJC1WslyoqMtDanf8MvqIBr4UQBTAxfdkaIi0/6ZsxexRsDjo76pXE7kPTdIrY4ievJwbQup1uCVHtoGgDK+6nHn43lRUll36OnA1jGncIcf4g4NNGb95+TuNHW83QRgy//jV/fQhDMR2o1yQJZawJ8HevAh8af9PRCxykG8BJ8H2CiJveQzAs22GYN9b3Xw9p9XKixrZ7YdpVlYuOV5iB37xkca7B9l6dcihpNotyfW6wnTXgqfhkPHOWTnB7rugtjzI8YrBYxXrrYyTMvSWdOETtpcZ2vQpXvK/9cnobZ1MFWVoEaqtU6rjqbhNi1zeqqypQMeLEFeYgT1y0vY1dwd9CNCJgavpvy3jEpgpvuDhHwaaN2es7ZaomrPCAxah1JofIWBiUn9VcO6PiEjaOlFfB9Hd2RKcbHTD+7tO7AOyG06YGL/DkhYc3X9YGNk90XBlHVmzjki98LSSmYyIMC3GutcV+JmTQNFLLiTBVigjCGfYk1/1pAxRV0aiCmxFTFiltKpY9JX5BOfavWQUT1Yj5hJYudOnBm45BeYyh+mINPEwvQ4ZZ8hrVwDu6+y6ALTmsPdXTQBxwC4lyd5hW8RHGo6ub+oSUoAgkZe1/cQwwu0xTcFY5WTyJCdATkXxIN/mf95pUABs/CP2C4b5dmVXDxW4rhzJK34764l5gFKKEF8Q8tIiVTchedwo87ug/iZKw/vaGIh7zRiOIm4nw6U5AyxCYOTw1Frt4/VhJ31fFXflOCkAZT1crQZGuise7t/g+W+ujTH47zizLrwEwBsw+K6h8eZC9hn3GsAfs5486vIEAdfh0ipYQAsHg09MVxgogmQC7qYI8xMV1lx/zc7/TgyiICiLEhd3A/8Hyq61ouMLniTzPTK3LE1xIPS0V6twGvtnsH1Yc5eJGFJbLRd+qYVZFHN/2cvz6PPksMfu8TqchneQagDPWPz7agHWQVdxtiY9kDhefgE0b6eWQ7kVyuD82zU0koIKfOnHUHkkjv1wDbdP4QULSjxFg1tQdRIFYVtCIqlw8PiyE5UKD9MzjuYQ9fEqrsQK9rw/zYezF/jVniXvn2E6WSbqFdfmChzxZ6G3QEB9/5E1jTzGQNLInWrWh9pKEV0YrdvBJNkY/z2G6ePWmrzbphzKMR4t81aReb32ua9+rVgSETNQ0vIAOJ2CTzTeybP6pE0sElyXiDthWcrtpW0jwOpxnrTc0dQERrJheC12TLIcXOj29HKRWDPXtwewErKq95iwxI8BGQuIBN/hFegwA+VFfiEA3ogPK3SsXBNO+pqWKVlBnDvtVnfRBWyliv1YyQmvrgA8uItff0um1O/Aq8plD4wdHUzwOSiWq+nOQ+FZ+KaVncXKErcUHqWKyPKo72Qi7MikidqIpA9vpe0MHse612rs7dnz6w== X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f884599-2477-4da1-9f3e-08da9f564add X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:20.4950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cxc8GQxzQozIqtBrBbs9AuFSD7xCef9l3VR/pExPryucjKTQRE9txYiGTYoI+ftIXNBBjnTEjjuqsrBTpqsahCDHi7ayWLeQU3CMNqeomnw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The vcap_props structure is common to other devices, specifically the VSC7512 chip that can only be controlled externally. Export this structure so it doesn't need to be recreated. Signed-off-by: Colin Foster --- v1 - v3 from previous RFC: * No changes --- drivers/net/ethernet/mscc/ocelot_vsc7514.c | 43 --------------------- drivers/net/ethernet/mscc/vsc7514_regs.c | 44 ++++++++++++++++++++++ include/soc/mscc/vsc7514_regs.h | 1 + 3 files changed, 45 insertions(+), 43 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c index 4fb525f071ac..19e5486d1dbd 100644 --- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c +++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c @@ -181,49 +181,6 @@ static const struct ocelot_ops ocelot_ops = { .netdev_to_port = ocelot_netdev_to_port, }; -static struct vcap_props vsc7514_vcap_props[] = { - [VCAP_ES0] = { - .action_type_width = 0, - .action_table = { - [ES0_ACTION_TYPE_NORMAL] = { - .width = 73, /* HIT_STICKY not included */ - .count = 1, - }, - }, - .target = S0, - .keys = vsc7514_vcap_es0_keys, - .actions = vsc7514_vcap_es0_actions, - }, - [VCAP_IS1] = { - .action_type_width = 0, - .action_table = { - [IS1_ACTION_TYPE_NORMAL] = { - .width = 78, /* HIT_STICKY not included */ - .count = 4, - }, - }, - .target = S1, - .keys = vsc7514_vcap_is1_keys, - .actions = vsc7514_vcap_is1_actions, - }, - [VCAP_IS2] = { - .action_type_width = 1, - .action_table = { - [IS2_ACTION_TYPE_NORMAL] = { - .width = 49, - .count = 2 - }, - [IS2_ACTION_TYPE_SMAC_SIP] = { - .width = 6, - .count = 4 - }, - }, - .target = S2, - .keys = vsc7514_vcap_is2_keys, - .actions = vsc7514_vcap_is2_actions, - }, -}; - static struct ptp_clock_info ocelot_ptp_clock_info = { .owner = THIS_MODULE, .name = "ocelot ptp", diff --git a/drivers/net/ethernet/mscc/vsc7514_regs.c b/drivers/net/ethernet/mscc/vsc7514_regs.c index d665522e18c6..c943da4dd1f1 100644 --- a/drivers/net/ethernet/mscc/vsc7514_regs.c +++ b/drivers/net/ethernet/mscc/vsc7514_regs.c @@ -644,3 +644,47 @@ const struct vcap_field vsc7514_vcap_is2_actions[] = { [VCAP_IS2_ACT_HIT_CNT] = { 49, 32 }, }; EXPORT_SYMBOL(vsc7514_vcap_is2_actions); + +struct vcap_props vsc7514_vcap_props[] = { + [VCAP_ES0] = { + .action_type_width = 0, + .action_table = { + [ES0_ACTION_TYPE_NORMAL] = { + .width = 73, /* HIT_STICKY not included */ + .count = 1, + }, + }, + .target = S0, + .keys = vsc7514_vcap_es0_keys, + .actions = vsc7514_vcap_es0_actions, + }, + [VCAP_IS1] = { + .action_type_width = 0, + .action_table = { + [IS1_ACTION_TYPE_NORMAL] = { + .width = 78, /* HIT_STICKY not included */ + .count = 4, + }, + }, + .target = S1, + .keys = vsc7514_vcap_is1_keys, + .actions = vsc7514_vcap_is1_actions, + }, + [VCAP_IS2] = { + .action_type_width = 1, + .action_table = { + [IS2_ACTION_TYPE_NORMAL] = { + .width = 49, + .count = 2 + }, + [IS2_ACTION_TYPE_SMAC_SIP] = { + .width = 6, + .count = 4 + }, + }, + .target = S2, + .keys = vsc7514_vcap_is2_keys, + .actions = vsc7514_vcap_is2_actions, + }, +}; +EXPORT_SYMBOL(vsc7514_vcap_props); diff --git a/include/soc/mscc/vsc7514_regs.h b/include/soc/mscc/vsc7514_regs.h index d2b5b6b86aff..a939849efd91 100644 --- a/include/soc/mscc/vsc7514_regs.h +++ b/include/soc/mscc/vsc7514_regs.h @@ -12,6 +12,7 @@ #include extern const struct ocelot_stat_layout vsc7514_stats_layout[]; +extern struct vcap_props vsc7514_vcap_props[]; extern const struct reg_field vsc7514_regfields[REGFIELD_MAX]; From patchwork Mon Sep 26 00:29:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609440 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F2ECC6FA82 for ; Mon, 26 Sep 2022 00:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbiIZAbH (ORCPT ); Sun, 25 Sep 2022 20:31:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233097AbiIZAat (ORCPT ); Sun, 25 Sep 2022 20:30:49 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2111.outbound.protection.outlook.com [40.107.96.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ADDC240A8; Sun, 25 Sep 2022 17:30:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OaJ7EYveHIay/z9VUlON9QecPFj/tGbw291heuiZnJG8Lh8NlYyh/bTy9ARzqvzWl8RYY6sDUoOp7S7qqzOFBFo1l9ZqKDu6TabIznVT9ADUT7p4L/6qlnjizDV3m0p73Fiq7/kwx7mpklL+PmDsUBaz5F1jrgA/J9IPYQx6h2Mpb2dgUW8y636mGicSwDb8aeEZbOIjJmuv9ZHMG91TU/omDJBIOCaLItuErBo4muIEv0Bs2tVihyegjCWTMTxfxzJjrQaNP2TrxA3uQl6qLGHHbu1ub+3l0j4qr8NqH2fEODYe7neW0kKizLvUOLEYUVvJo9tbfhEiKHgD2RdmZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vn81VQPcg7fyfI7Pi5zpXYQOYF1SQdh51qg80ett7Kc=; b=m9BfOcgSP8zL0/Pa65L1HNzitDaRtHEPl4YubP4auoBWyKhqnEc1Xkh+qWV0N5OY+o+ie4gNAnSX2OsLXi1TFD3bw7fINFr7SxenlU7PdXf7HYub7Q6W+0NJ9xIbQhGobu8gZw7m5q+Jlr9eQiESchYwl3qwQ39osMPSGv9zx0Na/qxbGP3nnpU+2NsVga2IgjEQlFQQ4lCrAjb5GYNrwqvbNJTyaBneVafaIzhhfs8PTeJa5ZXI6EYZWLUxAAqZJ9Ngn/UOR0571mO6HLsupWXOXQNZQ3H3pVoVK7tZG227jzdigfnshCU1CLRszrg0ZhG7NyBdjJ1o/5MrLypfqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vn81VQPcg7fyfI7Pi5zpXYQOYF1SQdh51qg80ett7Kc=; b=HPB5Er9eEF2hOtJprxKiNZn9wPmiCB8tjquyJLHC4XL7/NtrvmwIxeIPMNW4M19xwYRRdvVw54yI1FTyCcWHnMLkR+kvEilhDf1NsbxbB6gIdNJsUI5AjzNJhkUvWcoRXmkqHxY6qZeKA+2gTtkAxMCC2w6okH6+lZ6jxBulUn4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:22 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:22 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 05/14] net: mscc: ocelot: expose ocelot_reset routine Date: Sun, 25 Sep 2022 17:29:19 -0700 Message-Id: <20220926002928.2744638-6-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: d2c256a0-6a9b-4b07-0a27-08da9f564b8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h/MSRemMLfgzKQE5xtELx+8oiZXxr2LnvJCIjfRkMBVu1clzJo4XaLPdcVfQ2+Mh58lAElMJxv8Xo90v/K2MB5AT29XmP5IXVvKDPzlaHYue+7mfOhVrkpGJrYq3PsD3QDDV8rgOgb9lvjzq0gblj2VEmI4t1Jb0PcrJZdNDNZzh1ih5s6q9ETqPZrfnJhBSfakwPIKdatnjlvHUaY+fDqkBMrGUAQRzNL7TA1o0Hq30gQJ37zHXFWXgxvlqunRtRvs2yWwCmhPcVUQIN/BFuApFIgSswDSNXQv/6Qwsm6GwMRwNI1IFSWZfhMOVxfvfO9qVrNs+jgZbFG4kVfju3uv8N86cJTTw+EO/DJe/jzVx2QdM52pwHuQMJEkqcluKou1xUMWVnJI/OWQWtfZkQAvsLTYiLrGAqbsW+uvAO1WYzn0Ha/oCrg14eGOLzdpGaXEnRvetkJI97P+VWSv4keGyo3RiAkG+Wn8tQ6iurxj7tM4e7nxKQVJGvPCLx3UyBYAaresMYgUMbG6+6lu3uyOzFZXfvAwS/m/pCHqGYUBSK5W5Luotoy5Tw2v+cwW8D1KfhcycZ9jiu0uCRjr8dZALYtG7aJDnb1muCj1pMiRp/IzYWTtunob/hVNgtSjlSHkDpv41yjPzcai0lXySiIJFvNYGBfPn0fPVAPNHfL1/eMeSkawnulwDKsprasw7kCr2zsjhHXfj/CaTXwEYiTFpjyJrJOzjVoa4+uBruBiTY5TuytuyqVNjYSSwB8u7 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(6666004)(38350700002)(36756003)(44832011)(41300700001)(83380400001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wTAa2CbnP8ySGQd9OlDZApFwgvoDfLhzcgLraPc5Ks94tEYYefy6+g1NVFrfDpAYHibzin8sxkLbdcV9jmUvnYn4Jj9BMNV9Ib0s8kR6+VFcfY19CeuLwqZrjBrHaQpFUsj9kcjFVWeKs6lVQ17nhehUTs/LJPd9WcRDx3p8gHZW0OAyxpxPFbxOCVnDtVPkS8rsOCOVgkcXnNtcAHzRnbep414zgrYkUBJdTSjofpHNlKm2f/I9W1j9YBLvbjSye7IqD1Tz17lA6RayOJOh2YoHsjLXL9HUo6nWfq8DZmqlfj4kimpNxlk0z8qHICBU7Xs6n8ma9LalOZLmtHYfQRemzymD0T2eso8ndQAuEFM8Lx0adiO5xTcdRk3tMdC1/RpNMyHWbGG3PAremFkvIgak1EuzArbBurWmwAimXxxBsvcw1vfJu3VxoyE7Ol4oYXrpFt6pnZ5/oeH/ZgEffg4wCPXdjdJ8GgDKP4z1pQdrpuUsZcSM0/slC6aDCRWfqJCT6SlOYEBWJOGI/CIuurgUhglG5U7FiGA9ZG2vwtLvGgUGMNgTL4TfUYbyiZ47h0/KHiApG5xAW03Fdd0d0dkxdVXI3VF/gvKXKtIefk43EjK4Ofl0jjv9fbZIDHmYSIpvvQkNYodb+YjwgxjeyVFwCJpTIPpIiKugMVsSQ1tZasXp087TU4GyBPVxTGyO9XLtbXkonesJ+0ysD9wmTrhNrnYg12pFuCE0wwiGWYZW108p0Z+pxSIKkMzAXp7/5dyjgsqhkF9ZSpqvW1fan9kd858BZZbl43ZkEMGyP09LTYKTAvx7gWca/W9CvbZKTVSZutU+kP3iVfJMScw5GUhrJzAOwC0BCEbuXM4HWHBofj8+bDHViJ/LAQ57+oG36sWJdubXJOu2FW3YxNfD2WrrMpFfAuVO3by/rgLXVXQubUGd9FhGXHqDMSCSkgTni9lYZUEtoTuUeMC+a8gf/GIKzPsF7H27NWm33s3sVvPx4G/Lml03zS7pMAZzMCI2vXJvvzEVnE7wv69ltIgCl3LCDu8RZwXnfQGRVfHQ8/ORCWUMM8CY+FwJ3TMFXvZ6j9YzrK+Z6xixBEZC7gswH22UD7lKyfXjcNp5aHedQTwwAookWTU1bWfUAH3FoVZDgodB9IvlkK8huwKZIdaF8tCUCTkEG31vAYhV47Qh+DfvUDf692j611tnN0yfkCLJHHYe4fEy/nhSie4H4gCa/BWkRfNlBa9ll7hqSCbWTOUK/t0s0lAWbdbf8T7mGzTDxsw8B1VcpOGmQLuq6TLcvIdNlfmKF8elJ4FGQteMtJpT0cJhTR4ekWKyZn3JnI+n3uybewebHFQ8hauOZAuT06aXWRgEfWRdQVr3+AfqBMXeLF3OgjVL/KuHsyu3Mr/39gjskWwFcVCMJVWiB98dEK0yhcgPr6W6Nfh+DmjmtqgvxaVXoLeUQhbtycv+xhvJL/tPTvFq3GWeyqWXj2RPG4PRZvTb7qIlD6wZLjMs9fG7+SCWbYvEgZwbxP14kNC3phzLfRUztqtkSQ0cEolWekTG0CVdaDjN27BpPzmBZoyQsKqOB9Tac5a3i7qdsiRVIzaEC18ic7o6cpRBAC9Aig== X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2c256a0-6a9b-4b07-0a27-08da9f564b8e X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:21.3075 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IDgkrygQsNEKVDVSMG0wEepYp/9l1GI/rmLI7lOi3hWmMhkyysvK2U4TI30zKx3jOxHpZpj7l3EAcM/Z17Jf3ZnKduCpJQqbHrIQBuKyLoQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Resetting the switch core is the same whether it is done internally or externally. Move this routine to the ocelot library so it can be used by other drivers. Signed-off-by: Colin Foster --- v3 * No changes v2 * New patch --- drivers/net/ethernet/mscc/ocelot.c | 48 +++++++++++++++++++++- drivers/net/ethernet/mscc/ocelot_vsc7514.c | 44 +------------------- include/soc/mscc/ocelot.h | 1 + 3 files changed, 48 insertions(+), 45 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c index 7a613b52787d..d43106e386e6 100644 --- a/drivers/net/ethernet/mscc/ocelot.c +++ b/drivers/net/ethernet/mscc/ocelot.c @@ -6,12 +6,16 @@ */ #include #include +#include #include #include "ocelot.h" #include "ocelot_vcap.h" -#define TABLE_UPDATE_SLEEP_US 10 -#define TABLE_UPDATE_TIMEOUT_US 100000 +#define TABLE_UPDATE_SLEEP_US 10 +#define TABLE_UPDATE_TIMEOUT_US 100000 +#define MEM_INIT_SLEEP_US 1000 +#define MEM_INIT_TIMEOUT_US 100000 + #define OCELOT_RSV_VLAN_RANGE_START 4000 struct ocelot_mact_entry { @@ -2708,6 +2712,46 @@ static void ocelot_detect_features(struct ocelot *ocelot) ocelot->num_frame_refs = QSYS_MMGT_EQ_CTRL_FP_FREE_CNT(eq_ctrl); } +static int ocelot_mem_init_status(struct ocelot *ocelot) +{ + unsigned int val; + int err; + + err = regmap_field_read(ocelot->regfields[SYS_RESET_CFG_MEM_INIT], + &val); + + return err ?: val; +} + +int ocelot_reset(struct ocelot *ocelot) +{ + int err; + u32 val; + + err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_INIT], 1); + if (err) + return err; + + err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1); + if (err) + return err; + + /* MEM_INIT is a self-clearing bit. Wait for it to be cleared (should be + * 100us) before enabling the switch core. + */ + err = readx_poll_timeout(ocelot_mem_init_status, ocelot, val, !val, + MEM_INIT_SLEEP_US, MEM_INIT_TIMEOUT_US); + if (err) + return err; + + err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1); + if (err) + return err; + + return regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1); +} +EXPORT_SYMBOL(ocelot_reset); + int ocelot_init(struct ocelot *ocelot) { int i, ret; diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/ethernet/mscc/ocelot_vsc7514.c index 19e5486d1dbd..822b11d33288 100644 --- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c +++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c @@ -6,7 +6,6 @@ */ #include #include -#include #include #include #include @@ -17,6 +16,7 @@ #include #include +#include #include #include #include @@ -26,9 +26,6 @@ #define VSC7514_VCAP_POLICER_BASE 128 #define VSC7514_VCAP_POLICER_MAX 191 -#define MEM_INIT_SLEEP_US 1000 -#define MEM_INIT_TIMEOUT_US 100000 - static const u32 *ocelot_regmap[TARGET_MAX] = { [ANA] = vsc7514_ana_regmap, [QS] = vsc7514_qs_regmap, @@ -133,45 +130,6 @@ static const struct of_device_id mscc_ocelot_match[] = { }; MODULE_DEVICE_TABLE(of, mscc_ocelot_match); -static int ocelot_mem_init_status(struct ocelot *ocelot) -{ - unsigned int val; - int err; - - err = regmap_field_read(ocelot->regfields[SYS_RESET_CFG_MEM_INIT], - &val); - - return err ?: val; -} - -static int ocelot_reset(struct ocelot *ocelot) -{ - int err; - u32 val; - - err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_INIT], 1); - if (err) - return err; - - err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1); - if (err) - return err; - - /* MEM_INIT is a self-clearing bit. Wait for it to be cleared (should be - * 100us) before enabling the switch core. - */ - err = readx_poll_timeout(ocelot_mem_init_status, ocelot, val, !val, - MEM_INIT_SLEEP_US, MEM_INIT_TIMEOUT_US); - if (err) - return err; - - err = regmap_field_write(ocelot->regfields[SYS_RESET_CFG_MEM_ENA], 1); - if (err) - return err; - - return regmap_field_write(ocelot->regfields[SYS_RESET_CFG_CORE_ENA], 1); -} - static const struct ocelot_ops ocelot_ops = { .reset = ocelot_reset, .wm_enc = ocelot_wm_enc, diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h index 55bbd5319128..9c1c9b8c43f5 100644 --- a/include/soc/mscc/ocelot.h +++ b/include/soc/mscc/ocelot.h @@ -1134,6 +1134,7 @@ void ocelot_ptp_rx_timestamp(struct ocelot *ocelot, struct sk_buff *skb, int ocelot_regfields_init(struct ocelot *ocelot, const struct reg_field *const regfields); struct regmap *ocelot_regmap_init(struct ocelot *ocelot, struct resource *res); +int ocelot_reset(struct ocelot *ocelot); int ocelot_init(struct ocelot *ocelot); void ocelot_deinit(struct ocelot *ocelot); void ocelot_init_port(struct ocelot *ocelot, int port); From patchwork Mon Sep 26 00:29:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609439 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C7BBC6FA82 for ; Mon, 26 Sep 2022 00:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233242AbiIZAb0 (ORCPT ); Sun, 25 Sep 2022 20:31:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233145AbiIZAbF (ORCPT ); Sun, 25 Sep 2022 20:31:05 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2103.outbound.protection.outlook.com [40.107.96.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FC0929806; Sun, 25 Sep 2022 17:30:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DZsdWCK8LXZe81sA+nUFA0V7qdP1024StrqJ/PDa5xMN9bMhZ32/pG11R/32RnUp/pYJmQ1es2ZaleNak7mFto7THWaMvBeFZaJA6/51FzHDFZJydmKPzdlxmI5ld5ZY0DqNb05JndYN2fUB8NCXw71CKKj1542wa7QWGKNWCx3Q7z5c8ifmE2NUsIEc6TtKeiFerBUMoMeUJokl69jUT1i4G63SbcX8z04txX0iWXaooEMBYm7ivEuAz4Jp+dV8fnrAz5CZMt/WDFPBULtahhkM98ia+rvRBkofPFoClIQybIdceDAibjPEfb9bhqXeoi3Iao+Ow4sOEkaByA1DEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l5tmzslR0SqH4/hm51ye/UVs3IbfFpheM1Wdxer4/BA=; b=iAJrSl3J8aYQt2XpAuACmx8YFVzCsAYeCyxOP705twpbUJ6raMCYdUVZb/N0n52jSkxSZOO2TMTiVZfyfOTMtjnU1t+slgrvLV1/FaUT04wyj1QBTXx0VrmvMsIioFaCdTF2cNnbPe521tpHPQv9ML2/Llyy2biVGOWJdTjxImnb0NhW/rlh9oWpLt7qChiTTfBsbaLwFdanGMl6UlfxRQYMAJcrFndPmMTpHx7rGwHXBfJLo7vraEFX4dg/AyZS0ys0qpHhzusze/M2brMqLGlJDbh4T9DZ31da6C3gQgLcbFy4EAPvvR1GF3HQdkJ4WmnocgCKAyUb99YYsjeAjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l5tmzslR0SqH4/hm51ye/UVs3IbfFpheM1Wdxer4/BA=; b=btgwBTCwti/3M9d2VS7fKYztf3FiNMaunHhcjAQWjg+ZqpfO0es7ifxQKholbrbc8RS+e0bB5BlXHwPNce0cn+HpzykcxjKAPfUeqou75njFjpWbL2tdW3pqJuJ3UP2xss+dU5GRpWrLwdJoWITNTaaEAC+OaId188E//TzTx8c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:22 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:22 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn , Vladimir Oltean Subject: [PATCH v3 net-next 06/14] net: dsa: felix: add configurable device quirks Date: Sun, 25 Sep 2022 17:29:20 -0700 Message-Id: <20220926002928.2744638-7-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: e8c25ded-3bc0-4413-db45-08da9f564c02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nj+Gcg9X4EdiU0bc55Ff5E8u4Ig31LhFMJY0x86leXvNFlRQlpzpXWH0OEiHmTawz9+oGVo4C94ROVInob/PpFG4+GaWID+W63ookYtOMa0x1/GSJO+WJJ814b57L3JR10jo2TUm668XKrsUzNK1EQ7Qc73kauM5gvdsNKt7SL0z5sErmKAYE06S3f4caL7C7wJH6AovTI4ZLPTPzs6QGuZZ2Xa2ciNB0XsnjrWdd5k8hWqR4hZdkJA9iqTExRhR97h1SiJEfRrxssXfG3d4GZyfp/zihwS2o7mqLKdClhfOigsQ6NO4/U6EhUe2Althx393XeOn0A+MtDQUQGU0+/ZcflH5QkVCGg0yT/357VuWlk05CCnlIkPBk2GW4xAU9sjbqOpOcRKJN5F49lM1JAXyBVgTYkkITAAPNn0qUHSWqpqnane53qBQevz85CmJU/GoP6L2Qa1STSbDxsM3/D9zK9M5EhKIe2jPqJJ6VOA7DuGxMIi5u+VEpSdN/mpCCn7kcybApwqABBlwaStQIOjK5GAyuOxqgQtTbXB6jUBwBmFlyUuIPIAWqXCnbk+R4GQEUwJ6gRUOFVyQgfq1KXxezR3baUElo2UH8CyP4UicoEalbHpl0ZqIq7hv7wKvmE/vR6xPTdj1IWX3Z7DuAnLrzFo4/pVMl+Tat56Airt6M9AIG3PBUSMLJWxpm9lR8wh82iXaNt6H3g/OW7YFT93URNOFYozf28Jy5BfjgFqdcZsUe3wDry2TT934uqw7 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(41300700001)(83380400001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uBkVwnNvdErNVBM4O1H/JG7IQVZCAXPL9gvWmgh18jrPwSCtlyPIKL8aHzb6dYsU8FkL6zQmZ0lILPtUyfWnyPiX2zpIQB8MlZ8J7IzZuhS3b070Ppl/+gJo9X9AjThWMUhQp3yV4oNjhtBqwLKTOFkXOfD5fEnksgI8uTYuAdqt7/mj12XIRqCIZQ4Hof773z5wHYlBUAfx1S3kMdeOcMmAqDrhmprWjPfJxgEc2znd/YKibopzhruobZ7H7VVHYyuRVSiYqWxqSMYJfqCxt5Nc4vrvvwc+jFTmkD/raw6+WEqkQNxONs+tz9uQckWT4XkSXv6ftAK03UAOt0MjdOUvK7oE0XrMfO0JAroB76+Nxr/2eLP3XdrBfYIH2i4Sv6Cjts1DSUZPUwpvedWR1zV9bN+Hk34Cx9WgSocHJMxNACb/eTsYbY58G8ePF/3pqSLv2mMbcr5VE12PnrKtQ87gUZnBFxavkgl3ITua6aQ3mEyvLzmOQBjUlas1wF+zGuHbiGZdMnFICqQAb0XFJALBwtocWWEsPvcH4UOJym08Jur5KjVxQa/W5vyZRvWI7+cHBRRa+Q8/aqEbmfDTy+fIvmg9wBG62hr84T/LBPNu8y6+GiiSUoJQ/Xhb/yN1nUOy3aFgOg6uIHkTnds+JwS6AmO00vYo15iuKfYOB6i04evr9cfky0NswKpN30lwb7ytprvhT3ubtXvF93I/Z5Ux4qAkDFhXNYCfrqI+18K0OWNVuSR5lUVkuXyoasQWrZtGuFnT0OliLE+sucEknR5NbC5fa9gqeZ9FWhZ5xG1wS2xOjgtDNSS/GiiYvbobH2QDXSAUZC9NhjOhQi8LUXQQxstwQDdrhG4zcUodok7Q2k0WDLh/ELxVmHfXO6pJuzA+hksGTV7rGwFDOoI3vf0/eyRaD92MIZDw5KJauPHo1kBclMhuO0rQlpNY/reI5ukQ0SQkfwkphPzk5mM39C+gH0KrZ/SeJmgo8G7yIXv2eC0nAxpmQ+crRC2VGBIlr6qlpeXXhgmmNvWq7RO7Xpe/vTMl5q9vNDFtMjz2SJ7bbmAfM6xC5+bqBGYsFaxV97VSfoqpnD1MzQYje9mCwINrCID649OQ/N+iF+4fSxYU0XRgjmuVceivW9Dw1YeXj1+SzjM0QZMqFNWpXqyPyQyryUgRrOCSC1lCyCGJWmubFffvZSWUKZk7gIi4+BLrx/5B97GQZJPBS4u9OGDhiff+9JEfwAD1qut4Dk3zXCj/TXQoxgM6o/dEoYspsGDzWZly6YfoVhm5EYPGdZB0zDmCk3NVrfwHT8k6pQy93xj2It9TAEIOWXYHo8LDeawzSnXOUZsePm41Qvs47mhjdiRirwFLD2RxriRaL2oJTzx8PrUg59ee3bSPgoCVkpULDEX8ECJA2feLJzANh/1PvZ9YayjlnsBaUTm1th31o7Th3fyv/uwLHRtPk9ZXJqzBf0/AYW9fU1+PIXQ/zHztvBhgDJ57WTO688McQxxQv68q1PkDMm5mq5jZpjPLNluASOf7uryEr3Ui+09E6x4yeMB71cpthoX+Rv84caNLRUCIebvYePkt6w45Qpxo0+RRZBD67T6Q1+anXNm0NpphWA== X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8c25ded-3bc0-4413-db45-08da9f564c02 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:22.0418 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Cb0NEcsLnoE6seWf5STenbBBYaxEaWt9GkBE6BdDalBLxl6cQtn8c/mSBKXvAiU8PgPTiC2U7umy2Hw8d1Q/GacbkKGoBYa3IyqPmiK8w34= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The define FELIX_MAC_QUIRKS was used directly in the felix.c shared driver. Other devices (VSC7512 for example) don't require the same quirks, so they need to be configured on a per-device basis. Signed-off-by: Colin Foster Reviewed-by: Vladimir Oltean --- v2 & v3 * No changes v1 from previous RFC: * No changes --- drivers/net/dsa/ocelot/felix.c | 7 +++++-- drivers/net/dsa/ocelot/felix.h | 1 + drivers/net/dsa/ocelot/felix_vsc9959.c | 1 + drivers/net/dsa/ocelot/seville_vsc9953.c | 1 + 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c index d2a9d292160c..07c2f1b6913d 100644 --- a/drivers/net/dsa/ocelot/felix.c +++ b/drivers/net/dsa/ocelot/felix.c @@ -1082,9 +1082,12 @@ static void felix_phylink_mac_link_down(struct dsa_switch *ds, int port, phy_interface_t interface) { struct ocelot *ocelot = ds->priv; + struct felix *felix; + + felix = ocelot_to_felix(ocelot); ocelot_phylink_mac_link_down(ocelot, port, link_an_mode, interface, - FELIX_MAC_QUIRKS); + felix->info->quirks); } static void felix_phylink_mac_link_up(struct dsa_switch *ds, int port, @@ -1099,7 +1102,7 @@ static void felix_phylink_mac_link_up(struct dsa_switch *ds, int port, ocelot_phylink_mac_link_up(ocelot, port, phydev, link_an_mode, interface, speed, duplex, tx_pause, rx_pause, - FELIX_MAC_QUIRKS); + felix->info->quirks); if (felix->info->port_sched_speed_set) felix->info->port_sched_speed_set(ocelot, port, speed); diff --git a/drivers/net/dsa/ocelot/felix.h b/drivers/net/dsa/ocelot/felix.h index e4fd5eef57a0..f94a445c2542 100644 --- a/drivers/net/dsa/ocelot/felix.h +++ b/drivers/net/dsa/ocelot/felix.h @@ -33,6 +33,7 @@ struct felix_info { u16 vcap_pol_base2; u16 vcap_pol_max2; const struct ptp_clock_info *ptp_caps; + unsigned long quirks; /* Some Ocelot switches are integrated into the SoC without the * extraction IRQ line connected to the ARM GIC. By enabling this diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c index 2ec49e42b3f4..2fd2bb499e9c 100644 --- a/drivers/net/dsa/ocelot/felix_vsc9959.c +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c @@ -2605,6 +2605,7 @@ static const struct felix_info felix_info_vsc9959 = { .num_mact_rows = 2048, .num_ports = VSC9959_NUM_PORTS, .num_tx_queues = OCELOT_NUM_TC, + .quirks = FELIX_MAC_QUIRKS, .quirk_no_xtr_irq = true, .ptp_caps = &vsc9959_ptp_caps, .mdio_bus_alloc = vsc9959_mdio_bus_alloc, diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c index 5b29fa930627..e589d07f84db 100644 --- a/drivers/net/dsa/ocelot/seville_vsc9953.c +++ b/drivers/net/dsa/ocelot/seville_vsc9953.c @@ -1071,6 +1071,7 @@ static const struct felix_info seville_info_vsc9953 = { .vcap_pol_max = VSC9953_VCAP_POLICER_MAX, .vcap_pol_base2 = VSC9953_VCAP_POLICER_BASE2, .vcap_pol_max2 = VSC9953_VCAP_POLICER_MAX2, + .quirks = FELIX_MAC_QUIRKS, .num_mact_rows = 2048, .num_ports = VSC9953_NUM_PORTS, .num_tx_queues = OCELOT_NUM_TC, From patchwork Mon Sep 26 00:29:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609872 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD7D8C04A95 for ; Mon, 26 Sep 2022 00:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233228AbiIZAbI (ORCPT ); Sun, 25 Sep 2022 20:31:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233150AbiIZAau (ORCPT ); Sun, 25 Sep 2022 20:30:50 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2111.outbound.protection.outlook.com [40.107.96.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2649728E33; Sun, 25 Sep 2022 17:30:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=grMGP8gQEwf/fIaOPdetS0O/cv+DfML+VW55LDJM0qyj3kWitdYgi4HwKinadDs98Q/GiJ+Lu/w/cIKibajySozUEkQBIDOYrT7W4P6c+NbTfuvoVm3RGWdcnbr/MoZVuZRVi/1/wrz/a2sFNrnTqNJIXc5XxHeLVO1XrkCXAeenosHK7h+ZCPstcOKfTsoErS7dbC0vBvVflwT2T7FfRO8tuzSzjvnA6N+XdAACUD13YPWOCBifqH/jguRz0qVQVGaM30MD+6960IV4bO/xfSlnBIHoey7VgiCCXJh9IX/dny7DiAqNAfW20/gtgD2m/pXgOmEXl4Edp3ZmMkf5fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W+Au91cu3uuL08D0+MPuTCF6Asxdf83Cs5VMNNrP7Pc=; b=GjIp2r5kebtARfwwFwXMfBUoVfN8LHMTwgxi/k7pJ5kcYRHEVDpoVSMR/vllMYipRf6wvcLdOhMspNVKuTBkDBa22M/wZTmahL5Sy8x0gbxGBe3tj/4pgRBz0Bhr/3S88j3zWQ1r3lx14IsQapBIaXILYQScs5qhA1WKPvtvtfQES2g/AX4yisSRZyusieMs5O/NG2GlF/ycBb+JnTZ1JHXctWW2ne8b8SGp3GKbJdlWelh6pOZbjyDaQVodB/VMKVQY6rGhDvnjHY0gh7t54LfHW1Jct7cj3Ui4ztd6EClUfi4flmtTcdvSN76KxopCaETPQ5ctY/LSbhfQqZrXCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W+Au91cu3uuL08D0+MPuTCF6Asxdf83Cs5VMNNrP7Pc=; b=p4uc5Kbs/p7X0Ow0GknIngfQ41Yepd5bgyaI/zdR1RqmfusaTIaHXRi4xy4G6/b0MoZLv8MB14ab2ZhKkZtpMye1uP9vVnWVqp8iBmR1KRqXI02d7imRnSlUcbvi5PFs1yUnfJ/dJF8ZypX8YK39lqU9yIjEyv8sGQ/31W0c21Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:23 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:23 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 07/14] net: dsa: felix: populate mac_capabilities for all ports Date: Sun, 25 Sep 2022 17:29:21 -0700 Message-Id: <20220926002928.2744638-8-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d2a36fe-b75d-400b-e7e8-08da9f564c72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZjTTEGLtWpXKd4WjXRhZw/z7qJWpE5fat3sf6VR4ee8zaFzEvIhUlvpSePy/oS4HXkw8P1aB2rh4eViZkQBF/0h0ptfTFqZt7IMT6KNm91ivegnip6p5dewBM2JVsc+Rs9bC5j+itkzCjVoccwYd0PRk5ZdvGmMQGYZ+FuqkJZIpF3ZP+sUQIHz+94ba3ykq9KfezzRCrAnp+autntRDGMNZrmfbCjRLNXC9pNua22lm9eUrtrjHys041uHlKDw2KB3bZVohmgZ5eyisk8y61JdyYsYZLLH6/gNyEyMBq2eNp84aeuHqMLuNNM+25Nj5JjOlrx6tgQPfG1eIhi1a9/Ea7pCn7n+lIk2esyyLC9JP9qrlZAiLW3Ae3gmxx15R617Gf65EeVOMOC//jhWylS91DYc57UkoqLDC16n193Ia3ip60rsxMGJ8vGOoignhbQR1oslEQcFse873fXwQ4ISBDXSX3xwTGKqUiQAH6IY6fqeTQ0koSswEeT1KaSlybUJocqQW3a/3stUPFYjGpIdD36nB70/kGLtNYPDr4eTx+lWGbmdYu5vdUNzStDhoGENeQvuTuzODngvf21hevH6zh0BSydQuvrva9KOhJjbZc8l6ywmTaJZO/CfjwOIi3kgPG4o0cXH8aQ6QqgtDJnostnik2PrzH69pOqIrlmuYiwLYUZKYIn3k4S967HNMTrVgsY5y3IJCMVC7FnX7Sn8pY43r53JxXueSTKDsYrTkFjRNDM1KAe4EgY/63aVl X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(41300700001)(83380400001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zoSy74fbDoHoP0/C0z6iSi1DA6aYyWFHYRk6R1XpbVXknPZ+Qjq5FSmAywzoWhy+C5odAIuzY0DdS/HDKjw4Qz2J8t4haIsevbQxil9k69InDti8XHG4ZJ7CKuRYNYwUw4vJfNp0SgUj4/SaGHmn4m8KwqRanN0Ry2eT4wILDDbqB1blqzOBWcTwM0P0DKxJGrqIujqjkCIyNv91VJn9UoofDqTZVClsLEcHbWNJwM5ttqy2JsqRz7YH4Cvuh/yRiLrCPef7nPwDS6KExyPlzc9RrQSWRwcGAcBMIhztRF/UwbjCgNq2rkDbb7fukLLfUAyWwIQ4KnsiGr0ldUOKr/IQDm5ZurJB0wYkFw5jN2ECKU+vxwXvuVSKERA3v2qCHLpT9rTLsokO3qEnPsMmI/LZ4e5T10PV7sbYy+O+L0ZFoiIojR8E9DxMWC0u0UnR8QwVSGa2i+cgYFYgZsTNT42LIpG7J7ZgqbCjs366S8iSonH+SiYOhTitFhDlxKhnUHg3aTc9Qp9N4PXeknsLxX2XKj96/c6oQXEPJTW1MH/XtGltm94d3Ayb6saT3xeB2sZs3X2eY7oLbLsDaeObYfo5qV3yALLcAPfTqxH4WqlxyhQ6JMqbntoHF5CLedaf+qoWRSKlmuZC8MmvRT0y9/cheUL6boxl0RH8fM2W34gonjeZ1L3vsoOA8XYpaJYqGh0ZGENtxmN8PXGujUkrsEKZuJghtm+7XdwF+5MegJbuAG7X2pZlSlY1Rlr04774kF5Nx+XNZ/rjOGOEwXZpdwtPyHoYL5VSl+3T5W/akrfuohE91H0WUpq1S10qucxZbhHuV+NCDDsWoPKFVfFom1S2ERqpEUsEqiWugOmGSCvBwclzrDQXxjhRXdctmP8Kiqnd7PU/CSqSQw0AfMAXNnowci8bGTz5GNVk9kc/i7SbohgQTfyXBJ4XwzaFnT+7AJu/Lyr1NZF5ObcGdD5uVYOf47gv3TXasQ9kZAvjZS2a6uIjj6zfdzW8wEAdcc5xpABaMeKLXuVNUBbesjGWBUEz6niBVJBTHdA3nXYhZDXANjax57l43jHArPDyYvIqnSj4wz4PahdMQzZx5rJcvy3CxRkipwtr0JqYnTcl0EyBKejyb1/Nkm3xkI4UhKaelrEbH+hMxaAvUPGdMjn+cXKxmIKi3RP+ABSIEDh7OYRtsgcwlHFfWJaZiTQSoMwxYfKHdrAtmyhxZ396L7l5Ew6b1XUe0BpHSMqPBSjwZMaf4QTFZ/BJcRzWapq2RxcXXgk/1Tbh4SwK1SDK9l8ekNB/h4hcVbxz45gCO5Nk2f4+VMc4Jt9A1PsbJoNNZlHGPwupd2V59iP+LDHK8lRXMOO31dUoYi7zqklcm3H3v/RvsMUp73hfroQIUKrXol51JObVMhaLSp179t86GYQLQRMO/VMqRyn3J61JOc6AH7k2JhNltoCccqjFIzkg6/eyZl0TtamRLn/IpeHxYlMkCh2mrFrBefJEMCjp1IySg3VTwNSJ1xCg+VqG11v/mHBHzR1UeH4wySyG3rvkznG+1/0gfC4vbbBvT5Q73IbtXFTXbr6JskFBQLC7icymZUNV6/B6y2Hay1Qz7XzqsX+mxw== X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d2a36fe-b75d-400b-e7e8-08da9f564c72 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:22.6980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FysgqR6xYrYbGrYV+1j/DE6fC52B4DTnTqTQa/UclnWmF/tTqxl6uen0Mybohl6GwAtd8n1lfqvD5HjPi73+pqrWk1jNII9PSTCKF1XOzb8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org phylink_generic_validate() requires that mac_capabilities is correctly populated. While no existing felix drivers have used phylink_generic_validate(), the ocelot_ext.c driver will. Populate this element so the use of existing functions is possible. Signed-off-by: Colin Foster --- v3 * No change v2 * Updated commit message to indicate "no existing felix drivers" instead of "no existing drivers" v1 from previous RFC: * New patch --- drivers/net/dsa/ocelot/felix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c index 07c2f1b6913d..a8196cdedcc5 100644 --- a/drivers/net/dsa/ocelot/felix.c +++ b/drivers/net/dsa/ocelot/felix.c @@ -1050,6 +1050,9 @@ static void felix_phylink_get_caps(struct dsa_switch *ds, int port, __set_bit(ocelot->ports[port]->phy_mode, config->supported_interfaces); + + config->mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_10 | + MAC_100 | MAC_1000FD | MAC_2500FD; } static void felix_phylink_validate(struct dsa_switch *ds, int port, From patchwork Mon Sep 26 00:29:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609871 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79EE4C6FA82 for ; Mon, 26 Sep 2022 00:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233266AbiIZAbf (ORCPT ); Sun, 25 Sep 2022 20:31:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233089AbiIZAbG (ORCPT ); Sun, 25 Sep 2022 20:31:06 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2111.outbound.protection.outlook.com [40.107.96.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BFF129C83; Sun, 25 Sep 2022 17:30:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gLOC467/BsuCBTUPuKTbmhlkGKuwZ73vA6h+AWpvKEYHkv2SKA05i58iEWOhDbkf4I4IYquQkvgkJ6ULhdCjpxpQzC2Hq/YWYzmGEm9M/PWSoEzxmsKwLqdHt18P92DKIKyCBa6VXQwOPCNQO+87znAJFikZ28JnPo3EXFXyW7UlEXZ4BylrbQkhuKRQWHPQJZ1/bxUvSihr5q5iUrlwrENWtNpfVmcUa/oz9Hu8i0ybaIQoMFNiCkOC5NDVbtLTRE2lFXhxIKAJMAjRi29qdHslyzHP17k6ac363sL9pIJJ+K6xIEUpqIcWUkPnw+U064/Ld7rJ93AmFF97rd7JbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=usWnpg7aQcqYbfBiFKlyj2p+/ST4zMg0LoHWJvSqLAM=; b=J6+VJxRDjo2YoIea5Jh7ZFBR8LguBltWpcnTw6XkKFibXCW9okE3ZD0vY1B6LF+2OcoA1f+44Z9A+LO4V6YVy6/vjjs3ZcaIRUY9VF+MfWrpVWeTFwxaWfBvzoqgJFFn5yFrUQOPidT+LgWMAQloHKi5EyY9/uwvF34NujVMGsJVMnmSl4Oekl0nwwusf2FxB85aCOh5q60Bt/cnNz+NId7h44/9sjYzQnE8HMYQCGVvPzbLEgwd6EZFAu2RHLSvJd8bNGFdZJbImld+OpCq1Y2sK4hse9SWQzCEUkhZCT5tNWalmssjvmLXERu9W3UxGiJiXDAnnp7dObKzMsh8gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=usWnpg7aQcqYbfBiFKlyj2p+/ST4zMg0LoHWJvSqLAM=; b=RiqOS4WjHMm3msi/P+IFxCUtAPk7AOBtVQyRhZwthlmP9IM30Ti1gvsCoL/xJecK8dKVqIdnw1FnoyKpIhsIZvkUWMI/plxENY+ChygrQag4h+6NVTubfH587TPkK1/OsMkTYHMMRpF1IJOUkzT88ZFn/dos42f/HOPjxViKoQU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:24 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:24 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 08/14] net: dsa: felix: update init_regmap to be string-based Date: Sun, 25 Sep 2022 17:29:22 -0700 Message-Id: <20220926002928.2744638-9-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: 00d3ef06-4943-4ea3-9211-08da9f564ce0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mu/wkS7jpemavl9iKEQQlL3v1kqfH3GQNXjh2m1myw2hhzVwlQ5wtUe7OkZHG4mK2oirqa6fVEFBlJdhW5oKgooG1/IdWhZK87Oz7mkIayCk9MAYIg88B/BIj89kwOpSYrg50uWMIFE9CDA1ujUuU6UOPb08MfsGbnVXI0Ar/HLgh+r+VzCiSThpkxHaVH8xfq//I24JDEsnUJkP1jv1LKfOQKTWHllPuO1HwMnEGfna9MuPugP2B/Swqc9tR+U0fvjodqOsGBS9fSfcMXHmc27EaW0lskwjlpL60HdMEXrIjJjWyjjxcfxIqmXD5FDQ41n6orQJBp0PlYq/+NEs1ZTYARDldqgu9F+KKTKJlXQi3Euif3e5xpmOGtuZRTmvEWhtInSZ5K/4eCcwylpMoj/p63V2j5s0hwWk7IE+zLH0OzTz//5MdkOOlBTSE62E9WyGXi3623qdpDCWIi7jIera8zMkS3znBD5YNZzWp0kN1RnjrWDdTvF/4O+tuRxhh/kqeaNLVQ+wEzD1ayLErFB5wkVnAPzslH5tmsv91w6ZJCEji/5NFPzI1T2cGy3/cgIn3vAsFsyJqnvDsJHcPAT4n1e7aLf07i38eeK0L47Hr36PSMOarnl9oIVMkcY8wFP+F/wPpu9PMln3MPaBt/3gMWtV/mPqfq2gpmoe1ja7YaVAtwz3852Y0jxgVTmziN9Z82Iuu571Q09VcaBPixd9NRjEY/lHvboQa7Yah+CoERIz0rhN4Go1ms1HBXJD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(41300700001)(83380400001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dS889AFpacFby+Z9PuYLbUmakjLIJ85r91WXKhM1h7/iL3kbMYimJtProCg9VDPc06VmAI3IswCTjyOXgLfprypEXk2uw0Y6XYuBMZpwUEzUZNDVHr+EyrP9MEq+2/BKNpqSY24pYcMgs74oc+tg/mhDR9E1/py97ceIbKB3W2E0Vovh8ivIHjkmLxn9zQCJU7vhHfAE5QPojgGWww7Inl1ixzhVEdppxHoAY/TRgfeOr3LzPBNxzXxqnBEm1HO4c0iO2bX7fLmTAxmmRs2FrDRzvltpkTVrppuPAjh6onV5GJ57acwCicKCcEn7xorqAm4dx/gdKlfDAJxkGMF5p24QYq43WxadJETS3SQYdp19pa+vDlktvvxm7edpjXUju2Sov5f/Id3gsRQll1dihaFfBdnvKhs4H2ChT7n8cvCP/c2S/yQ3kxnxNlypNNx8ur/YKHkjBz7SjOwellE/CeVtvF00ODMpwRQHpEua/IA1V2m4Qfj07XkGL0Mh7bMoyBzMv4mkYcgDpG/HIDLxm++fTTD64xFYc3htLI/LFL7B7VUWAj/qGwRZuQVtX9iywcD4PAZm2oxDtUtZhstwz3JEMy0ZWVqyrdTAaoR95C8RiErM5n7yDpGU6D51rquzenbPiqNU83mXsZGXykw/37llLrfIAS/lHQ3EsgYxP34lh6SAvpdqXWfL9zgXeZI+BXjWBg1OpnHNCAEjETSwEX51pDMjbDtlj2gvIjM8l267PXvmmV7VEMtiDcCcUgCIVpFS5Pf2lf64jzurQMf+t9dUVcvyHu0N2U80Zey3ArN00GlA1kP8MLMot3gS+hDa8M/kL7k9XRfA1xZx2zfbUpf/jTLcPbHhshYz29VYsgA+8yLl5sOte4hT53/d0+TUhsWrtPEMHYVlK/7EjvtpH2alz5S3ZV51EtdYsos8+2MowlL51naXkdB8q+bVjV9xj7MUCP+/8Ih+L9AfnSvva0Y5RTJzmewu0EyftfOQdZNCNdZMUvexhQsSNKo7L+vtoDmxYGAplaZqx0nR9TB6qYiq6sgBGvQw80oCBoi6ZGCRXFxo3WdKdxpi2gAmxrDYLhzS5aT7FIo+BJMFs3D9YLCxnz1luTmy7Cu0pNio98KaCKdNSr7v+Gey89xqNdfGR5I/S01ja1VCTx6i3gMFFhcZogbvSyx+LMOXV0B1+EXUsp1+sYav5BsRKwjp6PjbFY0oNQJnet20qM/bmvGBzlwv41yodBi/SNFcXroiHFPXDmzN4vcNkVTt3/7U2FpUb5hRKlzU78YpaqQsWjbDPkI4eoZ+65T6C2aJxZgaAwuaFHXY6+IXM6TNb+Jn5RKhoxEOd6z6ltoEav1l53qE9HrZWCTVglw5R+aSYk/Op4PKFPmEdQEaknq9wlmWW6ddAR8oK7GQpWHZyJtw0XRr+HxtJiuc2S9jzRYYJ+cH67n53wmSugo67WPN/tTBJ2b8EeXZSW1Rcx6wu7KGfzI+fjRLV9LJHOuSLG0b+YtMycHDX2sj///SOl7VmBfpvVSD/O1y3gw5KDzfwWgdukmTYv+/EpissR/H4WZkiuhVXCmZXIhBia33v4IG3f39DLMx2YN9zBn239msZ6ljKIcW3A== X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00d3ef06-4943-4ea3-9211-08da9f564ce0 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:23.4011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3KAroa9xXKvXT9b76DUP3CAu/Hu3EFSgYwUDr6FLKnMMxYMzWzL864psiXxtkQBjgoZycJmH3FnwTDOm3rJT/bvC69dXD1Wvko118GZvjEE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org During development, it was believed that a wrapper for ocelot_regmap_init() would be sufficient for the felix driver to work in non-mmio scenarios. This was merged in during commit 242bd0c10bbd ("net: dsa: ocelot: felix: add interface for custom regmaps") As the external ocelot DSA driver grew closer to an acceptable state, it was realized that most of the parameters that were passed in from struct resource *res were useless and ignored. This is due to the fact that the external ocelot DSA driver utilizes dev_get_regmap(dev, resource->name). Instead of simply ignoring those parameters, refactor the API to only require the name as an argument. MMIO scenarios this will reconstruct the struct resource before calling ocelot_regmap_init(ocelot, resource). MFD scenarios need only call dev_get_regmap(dev, name). Signed-off-by: Colin Foster --- v3 * Assign match = NULL for the default case * Don't export felix_init_regmap symbol - the felix.o object is compiled directly into "mscc_felix-objs" and "mscc_seville-objs" v2 * New patch --- drivers/net/dsa/ocelot/felix.c | 58 ++++++++++++++++++------ drivers/net/dsa/ocelot/felix.h | 4 +- drivers/net/dsa/ocelot/felix_vsc9959.c | 2 +- drivers/net/dsa/ocelot/seville_vsc9953.c | 2 +- 4 files changed, 48 insertions(+), 18 deletions(-) diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c index a8196cdedcc5..b01482b24e7a 100644 --- a/drivers/net/dsa/ocelot/felix.c +++ b/drivers/net/dsa/ocelot/felix.c @@ -1318,11 +1318,48 @@ static int felix_parse_dt(struct felix *felix, phy_interface_t *port_phy_modes) return err; } +struct regmap *felix_init_regmap(struct ocelot *ocelot, const char *name) +{ + struct felix *felix = ocelot_to_felix(ocelot); + const struct resource *match = NULL; + struct resource res; + int i; + + for (i = 0; i < TARGET_MAX; i++) { + if (!felix->info->target_io_res[i].name) + continue; + + if (!strcmp(name, felix->info->target_io_res[i].name)) { + match = &felix->info->target_io_res[i]; + break; + } + } + + if (!match) { + for (i = 0; i < ocelot->num_phys_ports; i++) { + if (!strcmp(name, felix->info->port_io_res[i].name)) { + match = &felix->info->port_io_res[i]; + break; + } + } + } + + if (!match) + return ERR_PTR(-EINVAL); + + memcpy(&res, match, sizeof(res)); + res.flags = IORESOURCE_MEM; + res.start += felix->switch_base; + res.end += felix->switch_base; + + return ocelot_regmap_init(ocelot, &res); +} + static int felix_init_structs(struct felix *felix, int num_phys_ports) { struct ocelot *ocelot = &felix->ocelot; phy_interface_t *port_phy_modes; - struct resource res; + const char *name; int port, i, err; ocelot->num_phys_ports = num_phys_ports; @@ -1358,15 +1395,12 @@ static int felix_init_structs(struct felix *felix, int num_phys_ports) for (i = 0; i < TARGET_MAX; i++) { struct regmap *target; - if (!felix->info->target_io_res[i].name) - continue; + name = felix->info->target_io_res[i].name; - memcpy(&res, &felix->info->target_io_res[i], sizeof(res)); - res.flags = IORESOURCE_MEM; - res.start += felix->switch_base; - res.end += felix->switch_base; + if (!name) + continue; - target = felix->info->init_regmap(ocelot, &res); + target = felix->info->init_regmap(ocelot, name); if (IS_ERR(target)) { dev_err(ocelot->dev, "Failed to map device memory space\n"); @@ -1398,12 +1432,8 @@ static int felix_init_structs(struct felix *felix, int num_phys_ports) return -ENOMEM; } - memcpy(&res, &felix->info->port_io_res[port], sizeof(res)); - res.flags = IORESOURCE_MEM; - res.start += felix->switch_base; - res.end += felix->switch_base; - - target = felix->info->init_regmap(ocelot, &res); + name = felix->info->port_io_res[port].name; + target = felix->info->init_regmap(ocelot, name); if (IS_ERR(target)) { dev_err(ocelot->dev, "Failed to map memory space for port %d\n", diff --git a/drivers/net/dsa/ocelot/felix.h b/drivers/net/dsa/ocelot/felix.h index f94a445c2542..e623806eb8ee 100644 --- a/drivers/net/dsa/ocelot/felix.h +++ b/drivers/net/dsa/ocelot/felix.h @@ -57,8 +57,7 @@ struct felix_info { void (*tas_guard_bands_update)(struct ocelot *ocelot, int port); void (*port_sched_speed_set)(struct ocelot *ocelot, int port, u32 speed); - struct regmap *(*init_regmap)(struct ocelot *ocelot, - struct resource *res); + struct regmap *(*init_regmap)(struct ocelot *ocelot, const char *name); }; /* Methods for initializing the hardware resources specific to a tagging @@ -97,5 +96,6 @@ struct felix { struct net_device *felix_port_to_netdev(struct ocelot *ocelot, int port); int felix_netdev_to_port(struct net_device *dev); +struct regmap *felix_init_regmap(struct ocelot *ocelot, const char *name); #endif diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c index 2fd2bb499e9c..e20d5d5d2de9 100644 --- a/drivers/net/dsa/ocelot/felix_vsc9959.c +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c @@ -2615,7 +2615,7 @@ static const struct felix_info felix_info_vsc9959 = { .port_setup_tc = vsc9959_port_setup_tc, .port_sched_speed_set = vsc9959_sched_speed_set, .tas_guard_bands_update = vsc9959_tas_guard_bands_update, - .init_regmap = ocelot_regmap_init, + .init_regmap = felix_init_regmap, }; static irqreturn_t felix_irq_handler(int irq, void *data) diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c index e589d07f84db..7c698e19d818 100644 --- a/drivers/net/dsa/ocelot/seville_vsc9953.c +++ b/drivers/net/dsa/ocelot/seville_vsc9953.c @@ -1079,7 +1079,7 @@ static const struct felix_info seville_info_vsc9953 = { .mdio_bus_free = vsc9953_mdio_bus_free, .phylink_validate = vsc9953_phylink_validate, .port_modes = vsc9953_port_modes, - .init_regmap = ocelot_regmap_init, + .init_regmap = felix_init_regmap, }; static int seville_probe(struct platform_device *pdev) From patchwork Mon Sep 26 00:29:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609438 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ED8BC6FA83 for ; Mon, 26 Sep 2022 00:31:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233319AbiIZAby (ORCPT ); Sun, 25 Sep 2022 20:31:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233220AbiIZAbI (ORCPT ); Sun, 25 Sep 2022 20:31:08 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2103.outbound.protection.outlook.com [40.107.96.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9B082A256; Sun, 25 Sep 2022 17:30:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Liiw5aMaBKYKQ24l0JpFB78WokniF/BSWBP5Bnil0F1bywSZXKhqDfQrqKJcjnRryr78Su4g4UEe8Y5ntASqk7ToLO+E+6bNzkLUOZftHB2nZY5StBk8l9qvm4xCaeT8/76MVK9OSkKb/gvZGAN6oW2z4tonxD+UgwCdXhPIv1zgXxoEdQv4t79EzFJWH6ba+reYlZagBfMLoVkzSkZhoUbfUUqH/8x++4g/VGD4OWIdFwrXyeb6L+D8CvKltRUfmtd+Tj7bfMqnngiBCtEAP+fLC8lY/mlsx8CynNicTCj4b0Hbn5jLt6zQo99kbH2Y/reuACJVRzV+oA9I8CJKVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ASIiEnFKGLw923mztlg95DyOv0KbmFqGr7B6B5DszVQ=; b=HCrkr/TMx2R0C2OuTKvm+r5ppyQnHZDJRghq+q7tea37+4LWfCxi72znlhAvqjIVLp8DmxQq+pPr/kEQSCHNcc2Cjl5AjJ8Jqu3pZDtHHyM1j6ZaM2zJPE2ebQ/S/J/B8XG5aXbhJyQFSC0QtO/55fhWBHOFfDVpXNu+hHm2M99WopO3Woc3Wrdusao0FdqbHAi7OrrZa1WkY8HfnefjaXnMzy++gISNnsqWpUsjVlAYjn0AJi20MjgFF31o2wuZbMH9+8zzyPt1rw9lniVRb4IrqNv5P6ZhdKguCSWs1X6Ua0uZZ6emo7IN+DgQD1jLzq+8fuhmnFw0hX9o0PBjIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ASIiEnFKGLw923mztlg95DyOv0KbmFqGr7B6B5DszVQ=; b=wLhm22o6C6iPdLJi+XNSzlISZOk3SMfP1PAGVo7KkPwJhwp34wj3AcEDei8AJTQyyapp7fMrlICpVJUIdhJfXs40FWqv/U94Gtaydw9ZKgDivfUSLvK599OVmdT5Msv6HHun41t0ofqbCmyKAz5DG7ZOvTiLXMfnL6EUoiyRYJY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:24 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:24 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 09/14] pinctrl: ocelot: avoid macro redefinition Date: Sun, 25 Sep 2022 17:29:23 -0700 Message-Id: <20220926002928.2744638-10-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: 255ac755-44d4-4259-ee6c-08da9f564d3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EBQcHfXEWzsBcYqMqCbv25aXVobgIauqH4U29nkQNnCHRFsbTUKJK4idodAWH3CegZXtQ3NuWVxwAZtUGJnCRPiJaDCIJDMzBFo23miAk7h5C1+QkbNpvblPoKb4fbVaMaflU7ad4GOdNM/kBVBRKc8lJ9B4fiiYQDUN/H+MO4WhGZsdE3klk7MtBkoMorZhnEbkS0LmczTWuSXFL91zCF8oM8fw77E8QfonQDD7JGL/RlNUaA6ZFCBxVtLP9Aa4wn/wnzvgWmNwIVT66+PaKCJE4qBFawxxNnVVyINb8nXUfO5/LKezu4ml1t6gd3TA/DqnCZCH7bDUstwoj89XVDnZsHnqZPymHqig1xbCWdlsgRXzIhZ3kdFTa2itNx2AKgpJyberL/pFsQ1UUwN4QT3VnO/+57hWaKiESTr7CI25g4ko29CcTmmKwvME+wOVGxxOrYYqYubCBfavbKR00CbjMbspmfPaqcnlpZk0OQPSrpVvYP6UjKPxsS/lLJG6CE4wNIbWsd4bZoX9dkCJq6of77q/3XhcfGIsc15ohdFkPlv6F2NvCyvlv5BDXcLjGFpZh3PkWmspmMSupttFXbvRDN+Kjob+Umm51jvSrjHgksvJd81A8LBECRaTNBQmPbH4Nq2XlcKlEHsagEYUqjhc3c1agUWl85VTHLGcw//NuJcA0YBscwlsGD4AJmBadVWk4YW80WM/FuWl9IKX+Cg31f7YNtfsd6vsyiY/g+eKumPbqx1Y6LqmnFMg0W4w X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(41300700001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: U+NyP+LYXXw4dq05qV3+ScatVX5UKdUNPSjNAfMv2llIKI/g4RvMYgC/NRElpAAkt6fogrGROajs1IXMKaEhVchrKFA9U4j8nA7gnW1XEN7yTjdAsIYh33f/ZFxkkL+Z+R0d8dUvZpZqqhUDLSPamkZllNYYTOxwmTmHn0MUUgy2BpG9kryqoZRotHSaCXNGafCVjmszWIoD2wl0fih658K+IQ2wxAAJ8LKZQD0Wn+pEe6YGnGWPaQkIowjgIk6ab14Tn/Fh5R5Q7a77KszkQ2r6CtUlPtvTLI1F/Zo8jey8PAEZYTQ7Ud3+jTRyuvN9qqDNrWMHh/bhrSXfEQsXlIXB17QjXwGMjqPntWRJ3aL8UNfXv6NunqbfmSwyhD/e+F3TXorVkaYg3S+DJCskQpjYX/y1GqSRP5fBsS6MBHDFZLJfREsDuCOP0UTF5q1N/LW0+09YVPEZtjmqwOGhlcmao9YC8kTeP12zfxxhzm0hPOJGXbfJeWudEcSnsj4tBlmDyPde93uK8lQPpKczhQu0m5Gy0vzC5sdP22NGWZINcIxufwdCXZTkQKHfp5zgG/2xDOZZi78GZ23fkhn+Os6G8QTCa+1H9bXoYDCE8UHZp7JHVdcZS5vscXA4R84Av1Q1InK2gXM+ekpSHEf8Y/HvNERuBdqeQUh0U4re6ebWsIr3OCJuB4R8qKy8dn5ZQ2lWOXldMknrp6IDn71lJpTBxmTK21YbaoWph1wr2bpR7WN8i3zkMqnQiJOGCkBZdDO8SydH9FDQd1B/zJ6hRF9IFphNvp08cJTSdb/ZFnQln/uxZqgSg4Oq9plTuVqptBCOWjdc7yAIcHTH1WbWNzVNOXoJPOxPY+4+kawjiTBOV8MNzKbsTcjNZf8XsbbjcVfGIEu5GJELAHFznTicXe8rkRYXGkgRusXiqDY3Vb0Xi4/aF7zC5AQjREVgiGDYtu3VZlWFdKcSV1lQeVICR1rh+o7D4WEt8CYXw1Du8kY/wzgMEgWnlwW79NlhrIPS10EbN+85IQXVcSCQT4UBMfiqyD2UOCRhZCkzVLaNk6Eo5H9+BzsO5z2UT0aEpHHEcAYGzHjLkk3Pib8lb/sxGLtAcDExUdxZ7gWSUXtxP1bbOFWz2YLTZfdGJgR5/9Lu4cPIMv7SlFA/JRf4yBDG7tXR+SLVZ5LcoJjwG5koE1dzjm46E8Jc/vsiw1ZYrB4cD08d2nsvGmiF7hVCymKljMaGtGyh5QyV+vaFqoaaGy1EGQi3W7AI1f32iUqwxUHvA9npYiig65NRsbd7xXJWWT2f4m7arII/JiRs+JEakkHHbPJPCCD+6AUDgTE9w6dMBw8PofqZGyfTzQTkx9Q3ZQNFPKqxYpvDFOsyMKg0bWQCt7A8NJ4YA4kiDHnl01cqYFkYfqQmoazOkQAM82C4/4G0OYuw127ObDWMQclaeRq96nIA8FR+TTkA7CZLbqtWIoUta7GzAxC2St/bWV1zf9GBVtHDzM3JPrEEMQhUqOqrPyIlUJG5aQe26Kss68UcI22MejWRwQXMw/nmWLOA3P/QOP0Zu5iYucoDBKzU+/yvR9hY6rtKrkUqpck6QUaawVex1/XhjbLc48kU/b2jNw== X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 255ac755-44d4-4259-ee6c-08da9f564d3f X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:24.3072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8eUnaYjrUy8ESHHzc1oA+cZx/E4e30BksLQ3u4dAqu3yuS/zqPc4dOXsYKRPaiSikBuYJmGfrhioRnzYxP6eVcNPAiiTvsIliyYQ1ykdPEw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The macro REG gets defined in at least two locations - drivers/pinctrl/pinctrl-ocelot.c and include/soc/mscc/ocelot.h. While pinctrl-ocelot.c doesn't include include/soc/mscc/ocelot.h, it does in fact include include/linux/mfd/ocelot.h. This was all fine, until include/linux/mfd/ocelot.h needed resources from include/soc/mscc/ocelot.h. At that point the REG macro becomes redefined, and will throw a compiler error. Undefine the REG macro in drivers/pinctrl/pinctrl-ocelot.c before it is defined to avoid this error. Signed-off-by: Colin Foster --- v3 * No change v2 * New patch --- drivers/pinctrl/pinctrl-ocelot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c index 62ce3957abe4..525c6ae898e2 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -1237,6 +1237,7 @@ static int lan966x_pinmux_set_mux(struct pinctrl_dev *pctldev, return 0; } +#undef REG #define REG(r, info, p) ((r) * (info)->stride + (4 * ((p) / 32))) static int ocelot_gpio_set_direction(struct pinctrl_dev *pctldev, From patchwork Mon Sep 26 00:29:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609870 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28913C04A95 for ; Mon, 26 Sep 2022 00:32:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233386AbiIZAcV (ORCPT ); Sun, 25 Sep 2022 20:32:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbiIZAbd (ORCPT ); Sun, 25 Sep 2022 20:31:33 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2111.outbound.protection.outlook.com [40.107.96.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AEEE2A438; Sun, 25 Sep 2022 17:30:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjhpNS/AKe43nO8liXGspr6iwSSgXXav+Kr1gWp9GSdBTmHLh+VyZhtRuqf9H1TlRWsJU9HeYr228IPsGY6uInj1rTRYuZq63jNRoTusy0CyujC802IxQaOWfqfr5QO0DUPIVvDyHzRmSEPyROpZ/qX2tNBbDW8IdalnMCCnRjKWE4LEPSIJ6hfYfrQw1dIsbPdR9fK5NFJ/ID7eGhpP5iQNV/rwnkuSmKlEpTcqSyJLHbFY+Hf0f6WJteth5Y9ZifZmd+WLLYMbv73XUEpler9+u4tuMN+vBAasw0QGjUzZSL48RaP0CyF7GXHaeoMqI7IU+pingVcDEN19gwppSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EjgLO9u32pEV+OAvuDZG62F+qdkTStLP6SR/sEud5L4=; b=OWR04W7sT/JbBKQc4pmqMCTzhdAauQr9ZarvTy9Wk6RelbtdPBvvNw0Ak3/Ukjc/HsPoVM+P2Zi3aYcfWs6h0Zae/hOZ9ClBOSzJlBeLTNdBtpNNOk/MiHXc53bDgfLc75Lo6L1JFH0XV1rTVHnaLanEU2NSLICOOAUOd9+FQo+B78QZrm//0jgF+cKbEQNPBSbKD/f0y8a9pFBrfVXiAKBcASlQhA77GlfdcdW/ddCve4clMUqo+ukClvME2HgsYDIS6LEkcrlglkPiPDzIZ+K/FSlTc78h/t5gQ3PDJ4XkjyI/jTs9Jtenq6mtTlUG+Uei802zYXFwVGyHh+Tl2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EjgLO9u32pEV+OAvuDZG62F+qdkTStLP6SR/sEud5L4=; b=qGIsANpSoF2zut7RH9Lxp1g8BlsFRG44IhBA0bBMPoOxSQNURKJX1FuJjc/4AUwRhB4S7s+s6orhFNchuKk2p2EHu5u3GhFKrUAbH0rofc87xutY6Jcn8Xwy0S+NBsrDePEgfYLylxkhhTINSpT1k6Be24eAZPfLPdY/HOC6k1M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:25 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:25 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 10/14] mfd: ocelot: prepend resource size macros to be 32-bit Date: Sun, 25 Sep 2022 17:29:24 -0700 Message-Id: <20220926002928.2744638-11-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: ccc5caa0-7469-474b-5b4d-08da9f564dd1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TwvhM93gAY3gSlMJQ0GHNa5yOuApaaDCho49uTqwifGb3Oc+G68SzJFoaaL7V4GYtxAmfDphK5PGEj+OfAFfjk26F1X3fJgVWh3cN6soxoStpYtR8x3VGupTnM2HQefic0yyk98N6moGtJ3wHDD7UchJ1OOP0ZGNxjSDO+u7qne569tqXYLiQX7W6S7FjCNR/qsUc7KipxWXHR31kXoRiUZu+Js3pH1VnNNyBYDQudmqHaa60uITVDf8uZG4W3SyAu8V95Q0Iy+AGlDzu4Aag7dnw6rnaUFSRiWxwqNeSgsXqd7+l+udNSaHvM9dMnJr6g+3QNecK/hwclc6FkFThZz+dh8ySUymQhFqkIklCuYEdPCn+NAzfrci2gbMQv3VpfX/NPLH15jzFVb3qu9DfQ0IKaPz1W2mK7V3p7QrNUwU69cy3R0XursoK3h8nYcF/svKh5TuUPH4vA6eyYd9TciMZVnEYzGbcXe/gdMAR6GBILBvNkrfXlZuGUCKMVmidqfyZYzK6af9WvneQjm8S6xPHCLJSgAXjXFw/yXEtQdZLRWLROiaZGr+fZhZhyCC+71WNIAoPUULAHH+zDvAdRbzg6m0aBqg53+H/1kawVmoU8G97vv12n0Qy4AcceqsozgZCfW9cJuq6xmh4LiPZyvxMToXNhvaqWDins/9kPpUw6L7JL3cC6aXaRgK+lSRq1CnVwYU2UiBSBadAKHnFUcOAKwLD+P7ZpO/An5Am4WO4wG2DIb9UlF/daX8MliQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(41300700001)(83380400001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sfOG2f7uwrfil7C67Wgx6RSiCDGCpoDibHxVxQglCKNs2aioHrcwFIf8rN/iJM+vr4nC7Ezyguhuir2LpqLhHquge6NrZepmGlpLrb2HzQi6pu2xsS5Vfo0tyQV8AHX4RipSX3DRz0be7g4DDcPhaNa8vUsubPzY7BktZk2S5c4XKPWV23XC4gCvumqeJ1xV9Kz5PcydxbVvTPoVASWxYIhZKybZ9++hvJidv3R5Q78he/+sNONGreG+hR34fff3pLe1EWIvvpgC4KDFBu/9sLXz/Y4nviY73u3ydH+tpOL3fQpK/eY2ZgA+qoO6idYaj+a3gnhutYwW8VFdmOm5xc1vK5R5IS8RVLitjirZePMY+vVJ7ZrSTC8gx54p1OUYJP2K/pr0jVxk1RtrCG0VfOg5w+1zE9l8oFUMtBhtqvJqpxtRRg+sTsyRrHOJFE+Hw1bFSz3JBEamrC8485c0dYqK8NFzb9z2jgDsJCSy0bTdODlnvUDf/mM4P0n44DkKkSElR/IjYnQUOm7sat5bXUsA5pTipfQbKa/WEpodtv2c+d3D+RgGlgTUSmqQxxxOFH+iuQUgNO7CSGgVM7gEO3j2INVejMctCNxwpd7MbbWk6mk7CeMZJaI5ltPRD4vGy4QQtiHrEwd1Zoqa4CUsesHnIYIXHYmu4iKsQzoIkl43vzmGD5+bjsMgLIgm6WlbMCwPYJNUwmZu08BpwxUR0AmtEg8e458d5M/BpO3c+ZSwhuqLi8iNv6tpvagLioyukM/mkdcBtaB+Pgu5J2nmLYeMJpWEPk/scbn9IzIqLS7n17HsnZ/zySCxq7TYAxrBS5fzUXaQ1fkRFy6lVa/Fg6saVDdJLzwgVSIetP9zClLSiDlRYW2BksTkOJPprw2L+WvE1RMHoB3wac19J7ksujfADgVbvC8Dbma74Cf8swjLC+Eig4g0UCr/i24ZkGS8ruo0UOcpDDWkMa626uMeafMlMZukXoeTcNFJnSQrS0YET23WX0zwnegTP/PeAIPe17SnO70/PSJElf53GrkVId+DVheJZYR61Yhas6vTqpQ/2IavGU1/GRfgP22/AKiFmI2MX4gfnQ6QUOXZMH2F8LF0UyzmzE7094DCgU9BQ+Ip5rPyQPGgl3lkLHnw8sE3S13rDmHxzSkVpRpxtK3nsgQvv5sx6XeyA15QbnN4TDPzelHIMpvqlavlMgCcUnQOWKYrC/YdTEJVaHHhRPxm0H26evvi7UByBms0Oa2pctDXFBbZCaKn6Zlksl1Xx6dWzFYlf5g3AtDXGIvbdN9FPlZYEnru1BYDN0wO1XeKqXG4U0f55XHYdvviNAMqkfDNaPImYthm/lwl0BTCJMu9okxQuA66WOBrwSU1jHRWUgXcCRtH17/Sk14nSIw+e3QxryWSI/wSPuSNXrEjRtnEp/J4XFAr0kPo8ym0W5J8WyhsXTKeMCWKq5Z4/PJ+vi3s6YHdL6Yd4ilTBGr5qFpIv3ioWLoipCxjC1ySpjhfKtxJGXxytDlD1Zc5UX8wFYr0yrSgeP+7MO66nd76VNLJUa0i4iSg0rmh52oOH1fX1bGWNwtEz8+3VeZUQE4V2Ye2sKN4l4p87o+UIw6J73hV9QDlaH3gA8s6K3IWSshsJJ8= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccc5caa0-7469-474b-5b4d-08da9f564dd1 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:25.0572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9z7WHJtLTx21QZm13V3Sc0LKoY+roElkJUcEt7h0EfBwDg7VYtDzb1zbbYfYJR2pJuWm2NuwsEnPeHkJrSP9nKOHEAmvcwiGib64LWhrgS0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The *_RES_SIZE macros are initally <= 0x100. Future resource sizes will be upwards of 0x200000 in size. To keep things clean, fully align the RES_SIZE macros to 32-bit to do nothing more than make the code more consistent. Signed-off-by: Colin Foster --- b3 * No change v2 * New patch - broken out from a different one --- drivers/mfd/ocelot-core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/ocelot-core.c b/drivers/mfd/ocelot-core.c index 1816d52c65c5..013e83173062 100644 --- a/drivers/mfd/ocelot-core.c +++ b/drivers/mfd/ocelot-core.c @@ -34,16 +34,16 @@ #define VSC7512_MIIM0_RES_START 0x7107009c #define VSC7512_MIIM1_RES_START 0x710700c0 -#define VSC7512_MIIM_RES_SIZE 0x024 +#define VSC7512_MIIM_RES_SIZE 0x00000024 #define VSC7512_PHY_RES_START 0x710700f0 -#define VSC7512_PHY_RES_SIZE 0x004 +#define VSC7512_PHY_RES_SIZE 0x00000004 #define VSC7512_GPIO_RES_START 0x71070034 -#define VSC7512_GPIO_RES_SIZE 0x06c +#define VSC7512_GPIO_RES_SIZE 0x0000006c #define VSC7512_SIO_CTRL_RES_START 0x710700f8 -#define VSC7512_SIO_CTRL_RES_SIZE 0x100 +#define VSC7512_SIO_CTRL_RES_SIZE 0x00000100 #define VSC7512_GCB_RST_SLEEP_US 100 #define VSC7512_GCB_RST_TIMEOUT_US 100000 From patchwork Mon Sep 26 00:29:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609437 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B07C04A95 for ; Mon, 26 Sep 2022 00:32:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233316AbiIZAci (ORCPT ); Sun, 25 Sep 2022 20:32:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233344AbiIZAb6 (ORCPT ); Sun, 25 Sep 2022 20:31:58 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2103.outbound.protection.outlook.com [40.107.96.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47B002BB2A; Sun, 25 Sep 2022 17:30:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RPq+GLN0iteNFYRa1VsjSL/JPHsigd+olCYE9uaqCNrjRfnTJixmEmMfPIcNrWWvvmWOGzj8yu7eI5ElDchfzTM+Mnin4XI7I8q22sza+/+h0bnZLUlWfD3d9fDUNiQDttC8g3l+OGOPuUUBFY5yQ5Gud2AERlcEeUzLj3jqxZRU/5QSPr2R/9t2nou4fR1zD3pQf0j78O8gRN95ZOGiVm1Cp0/LFig8hchrv/nsRDRGa1IgMFZbdwEBdBREspuJO5/VwGbtg5CRUNohykALpX0FXcO6sUs/I1Ty1vOKf4/p07y55pri98iTn9g6jn2xA7LceyAFBLFN76GGPLvLnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wnbrng3C39HxQG17YiICGr64osjT34z8DO2fFxIDC4Q=; b=aHLYflVUjULdlbAhQoj9dEArYBoMzSFMCB7YYNsgRKEcdkup3QgR8A7pgc4TiwN2g3fRJg4hZ41BD8cqeW+/e5H2X69zHldX3AoLW5TD8Q5xEzNZS2yi5RCdMurMzG3KfT/hWmSbaTdoi48xfXzQRm9bC1dBjmdFdAlw6r3IFiosAMh0MdlTngIhHv/UYf5KAERlo9/8P1FALnJy1/+uqgS20w2zehTzsfp5ZyihsMc7B4n6dVqT3KCAUHQwzkd881XzJKrtDfoMDu5t5kluoM+b07fSSM16GTkLP4/seNj1CTOd6yiQO8RY0E87ur0v1AzBuKwMIVdB/hE3dqRgyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wnbrng3C39HxQG17YiICGr64osjT34z8DO2fFxIDC4Q=; b=iTox6RNmrDc0EGvtSe72rbWpF1NBMIMt+SawLCNyN50s9s5zX9g1sxWkeADu6zktV9bKJPfOtms0ZRH6nEaHHeL3ec9oj1keprO29IoFumpR7ohyqyOX33Qgm8rl1xCrp15ZFxFvDDjaG89OSe2rLEzv4u8Lul4eT9NKOXQ+dHU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:26 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:26 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 11/14] mfd: ocelot: add regmaps for ocelot_ext Date: Sun, 25 Sep 2022 17:29:25 -0700 Message-Id: <20220926002928.2744638-12-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: b4dd2333-fa3b-46e1-40e8-08da9f564e3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: unwSLHwhjFsYyPQxSjPHCo10IIa2YVpfa5EcoGexHegwCfIbeHCMXHZCoXHxpNKoCQhZE80YTG889vzotXqHbboR5cev8i/3e2bcoIeT4AAGBDisVXRgFZyo+PQUxNfdy9PidRUjFa2tIlsIlO5e3l/9MhMCYWyjl75rUsoRkYh5xdi1dkDd1SxifthXUxCUnk4hQK/kbnGp0bqMldsOY7yrZpQDftxgixkHtSo3FrOyRbViJf9vT469+A9CvDDF/GqqTZsorJiVe+HBtNI7WqzsfDJ5bRm26o3UnSY+y9ApRL4+DWmZYmpKhAOlwYLhXDLU15CCJaAnkiC6Obck75i2dCgjtpJ2Eq+pIhAOH977cOz7a6J+ZdK1+4DAz0b50cGbPNpL7y7geGksd0xmf14jI98n6Zm6V2QcIu1uJjb0N7sdcqmZ5t5QqLyP1+NPyBkilzTFRIaVHXxiOwXrQ74rxqUeG+QtU7sQ1BaA341ubRBMTNwG/63b8vgu77A/O07e//R0LMYKl+Gsr2+Z9ppqhVYoFDBwuPAt2F6Us/XrvQ75993CaGqr8xO44wKsbWq3ADFAV3X3z86UdUGgQW7hNk3y6Lu3sRruB2WkqaRQva8stU/xrq82BzYdt4LJi50n6+TK4GQ4Y0LsogELFYk7lMtuhxyD3Wb3svf2D0IjMDa1fRMRnx/YBhM47PfDwkFp4PRPl9siW91SRKqXTaDqXAkCDYA2humoG8TVZRVaFTYojrMRAPN7s0ExmqgB X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(41300700001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /fnGFz7+9HYuzcLdZ5NoJSEEshoB8aiQh05VcBNZXkZ7nUE8JkmkZCzociK1bkE/wcGxxJ+LhquySzsL0jzlXitcU2ojHFFkVBeeurAWce21aXRNB0YY22S89Vq89QHHNDQ9yW9c40hp4p8OV9gNdf4xaKN9pn/pTKGVYwYl2KJqhzE4nijx+mFcZCl//t8n49f7JogXeHxj+o/WXOzYazpmv80/4vZou9HCLco1gf3rmz2OBGCiTMYXheJmvfU+dZqUSU7p28+ZYamdTHehImR0lwSj+iyutC99kA6S9Hic/XBQj49UP+Uoq2Hsl7tEZ2ibNvewpy5ecbvHAwDNEMrbfRmKVbHeaYEm1mwDowcP1fziDdftaOqMXQFxx8W4MbdVQp7Uqcg4DbU9TB1bo2xP4sPOAAd1wmepNfxyY4zaRL+uslbSLlrIzli+6AiNi+QDtlrD6QC0ggCif6+fBtuByqw1Cy7+NFsoHZHt9rOqrVjFJhicI3Ih96FK0FtrOtXoHIRwLALGbMC17qzO+p4039SGnOhrKoRvvwHb/v9NB74NpnRU2HbrxaoAaAzT6bj5iM8GLCiQ0501HhJISx7Q3yD3k6BJuCcrqrQMiFC3bj0uNXYkupRqPrVwjJXOE/AIHTgRhJgH2mLJiUu79R3NZsEuvDJgkfLsvGVtUyN15ihQO3VopVxpV7Ck3qcxt4RmR/vtTJcjylJsH8CBxXPTKb+rD7chMVHgMVLoEVTmvGAoIkd9bbWpl6arpKrVG5Otlhd2uciKRSehiEyfHfL+9iXxFQCXMsR92j88hMFNhGVrvcHDmgXZnqVs0XPXdsof8s4mdGhEqVb8oy+yjwrmVBhIIoVOYDM64jNHnlYTvIY/3Fu4ERVv6BwrlRmodPiKhaO7NZCQn37KBE6tk7KiVHI7qxKV+fljmkfw/Az2k1qd8loCU0zve/E72zEZkTvGcfzkDXargZ6o2KeLbrJM+rKuuN8EoL3iWQn64TJZFKfd1iYN2ta8GC+kcjapSGQdp5ViMz/s0UiCvE2xIo0YvP1jYouphyHM2ynbQmJ8DolCpGhKAmc613sREgbw+tDTk560q2OyySYql3+tDRJxsqHcP1WTRU+IQMAQOieddTC2DFZQ4Ix3UcUuOHFE8rWOUjiG1CCvCwG6mzYlZSr9kn2l1/qlC3BZTSsbQ0rnB+PBIODJ2Mu5TniQwhtfQALJy2ZT2ZhSgSMQ+LbLHrrKJ+qFLJIsjkFMkJi12nd/WjySk8l/HgbG034O0oAhX37dAVV5XogDETpvInNlz9us23sAUgDSMuSN2mYQJcI28slNXCKxRfyK7TGpUv4BEbRz9TWPN3yMc5lJdh0c3KZHzLA6/+e5k58lUS8iCKFgrALTqfXyOVPxjDeDBdg2AHlkd0B3xIud0Ibvb8nXJ2VOwtllNwMeMRD17bmPWe0wyD12IG1ikb5EVDrtrzSlIEpJzjUwAZTCJ6ZoO0n5XCP0Zzrqm3quKT0d1VQDHEpn1rmBMj4wGIKm7LYKS6lS/Np/AN2/DEjXdh42Ad9NTrhxZ2e7u391bDhxXX3RtIpPIgtzu7kg3tlOS38Z4a/JzacWq92YR62wqCw+F26z7bTKnE1bV7wtCP4ZHPbXurg= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4dd2333-fa3b-46e1-40e8-08da9f564e3a X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:25.6353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gOx792GIKyKyHs9MtnyFBkgwRZLwNbk2Uz4ivK12irKgk0mOK2SG8r/LYiqe9oEJcPdc5qbbdcEpR7wX551x6M3Y/klAnRIpZgQosCQyJXg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The Ocelot switch core driver relies heavily on a fixed array of resources for both ports and peripherals. This is in contrast to existing peripherals - pinctrl for example - which have a one-to-one mapping of driver <> resource. As such, these regmaps must be created differently so that enumeration-based offsets are preserved. Register the regmaps to the core MFD device unconditionally so they can be referenced by the Ocelot switch / Felix DSA systems. Signed-off-by: Colin Foster --- v3 * No change v2 * Alignment of variables broken out to a separate patch * Structs now correctly use EXPORT_SYMBOL* * Logic moved and comments added to clear up conditionals around vsc7512_target_io_res[i].start v1 from previous RFC: * New patch --- drivers/mfd/ocelot-core.c | 87 ++++++++++++++++++++++++++++++++++++++ include/linux/mfd/ocelot.h | 5 +++ 2 files changed, 92 insertions(+) diff --git a/drivers/mfd/ocelot-core.c b/drivers/mfd/ocelot-core.c index 013e83173062..702555fbdcc5 100644 --- a/drivers/mfd/ocelot-core.c +++ b/drivers/mfd/ocelot-core.c @@ -45,6 +45,45 @@ #define VSC7512_SIO_CTRL_RES_START 0x710700f8 #define VSC7512_SIO_CTRL_RES_SIZE 0x00000100 +#define VSC7512_HSIO_RES_START 0x710d0000 +#define VSC7512_HSIO_RES_SIZE 0x00000128 + +#define VSC7512_ANA_RES_START 0x71880000 +#define VSC7512_ANA_RES_SIZE 0x00010000 + +#define VSC7512_QS_RES_START 0x71080000 +#define VSC7512_QS_RES_SIZE 0x00000100 + +#define VSC7512_QSYS_RES_START 0x71800000 +#define VSC7512_QSYS_RES_SIZE 0x00200000 + +#define VSC7512_REW_RES_START 0x71030000 +#define VSC7512_REW_RES_SIZE 0x00010000 + +#define VSC7512_SYS_RES_START 0x71010000 +#define VSC7512_SYS_RES_SIZE 0x00010000 + +#define VSC7512_S0_RES_START 0x71040000 +#define VSC7512_S1_RES_START 0x71050000 +#define VSC7512_S2_RES_START 0x71060000 +#define VSC7512_S_RES_SIZE 0x00000400 + +#define VSC7512_GCB_RES_START 0x71070000 +#define VSC7512_GCB_RES_SIZE 0x0000022c + +#define VSC7512_PORT_0_RES_START 0x711e0000 +#define VSC7512_PORT_1_RES_START 0x711f0000 +#define VSC7512_PORT_2_RES_START 0x71200000 +#define VSC7512_PORT_3_RES_START 0x71210000 +#define VSC7512_PORT_4_RES_START 0x71220000 +#define VSC7512_PORT_5_RES_START 0x71230000 +#define VSC7512_PORT_6_RES_START 0x71240000 +#define VSC7512_PORT_7_RES_START 0x71250000 +#define VSC7512_PORT_8_RES_START 0x71260000 +#define VSC7512_PORT_9_RES_START 0x71270000 +#define VSC7512_PORT_10_RES_START 0x71280000 +#define VSC7512_PORT_RES_SIZE 0x00010000 + #define VSC7512_GCB_RST_SLEEP_US 100 #define VSC7512_GCB_RST_TIMEOUT_US 100000 @@ -96,6 +135,36 @@ static const struct resource vsc7512_sgpio_resources[] = { DEFINE_RES_REG_NAMED(VSC7512_SIO_CTRL_RES_START, VSC7512_SIO_CTRL_RES_SIZE, "gcb_sio"), }; +const struct resource vsc7512_target_io_res[TARGET_MAX] = { + [ANA] = DEFINE_RES_REG_NAMED(VSC7512_ANA_RES_START, VSC7512_ANA_RES_SIZE, "ana"), + [QS] = DEFINE_RES_REG_NAMED(VSC7512_QS_RES_START, VSC7512_QS_RES_SIZE, "qs"), + [QSYS] = DEFINE_RES_REG_NAMED(VSC7512_QSYS_RES_START, VSC7512_QSYS_RES_SIZE, "qsys"), + [REW] = DEFINE_RES_REG_NAMED(VSC7512_REW_RES_START, VSC7512_REW_RES_SIZE, "rew"), + [SYS] = DEFINE_RES_REG_NAMED(VSC7512_SYS_RES_START, VSC7512_SYS_RES_SIZE, "sys"), + [S0] = DEFINE_RES_REG_NAMED(VSC7512_S0_RES_START, VSC7512_S_RES_SIZE, "s0"), + [S1] = DEFINE_RES_REG_NAMED(VSC7512_S1_RES_START, VSC7512_S_RES_SIZE, "s1"), + [S2] = DEFINE_RES_REG_NAMED(VSC7512_S2_RES_START, VSC7512_S_RES_SIZE, "s2"), + [GCB] = DEFINE_RES_REG_NAMED(VSC7512_GCB_RES_START, VSC7512_GCB_RES_SIZE, "devcpu_gcb"), + [HSIO] = DEFINE_RES_REG_NAMED(VSC7512_HSIO_RES_START, VSC7512_HSIO_RES_SIZE, "hsio"), +}; +EXPORT_SYMBOL_NS(vsc7512_target_io_res, MFD_OCELOT); + +const struct resource vsc7512_port_io_res[] = { + DEFINE_RES_REG_NAMED(VSC7512_PORT_0_RES_START, VSC7512_PORT_RES_SIZE, "port0"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_1_RES_START, VSC7512_PORT_RES_SIZE, "port1"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_2_RES_START, VSC7512_PORT_RES_SIZE, "port2"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_3_RES_START, VSC7512_PORT_RES_SIZE, "port3"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_4_RES_START, VSC7512_PORT_RES_SIZE, "port4"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_5_RES_START, VSC7512_PORT_RES_SIZE, "port5"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_6_RES_START, VSC7512_PORT_RES_SIZE, "port6"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_7_RES_START, VSC7512_PORT_RES_SIZE, "port7"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_8_RES_START, VSC7512_PORT_RES_SIZE, "port8"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_9_RES_START, VSC7512_PORT_RES_SIZE, "port9"), + DEFINE_RES_REG_NAMED(VSC7512_PORT_10_RES_START, VSC7512_PORT_RES_SIZE, "port10"), + {} +}; +EXPORT_SYMBOL_NS(vsc7512_port_io_res, MFD_OCELOT); + static const struct mfd_cell vsc7512_devs[] = { { .name = "ocelot-pinctrl", @@ -144,6 +213,7 @@ static void ocelot_core_try_add_regmaps(struct device *dev, int ocelot_core_init(struct device *dev) { + const struct resource *port_res; int i, ndevs; ndevs = ARRAY_SIZE(vsc7512_devs); @@ -151,6 +221,23 @@ int ocelot_core_init(struct device *dev) for (i = 0; i < ndevs; i++) ocelot_core_try_add_regmaps(dev, &vsc7512_devs[i]); + /* + * Both the target_io_res and the port_io_res structs need to be referenced directly by + * the ocelot_ext driver, so they can't be attached to the dev directly and referenced by + * offset like the rest of the drivers. Instead, create these regmaps always and allow any + * children look these up by name. + */ + for (i = 0; i < TARGET_MAX; i++) + /* + * The target_io_res array is sparsely populated. Use .start as an indication that + * the entry isn't defined + */ + if (vsc7512_target_io_res[i].start) + ocelot_core_try_add_regmap(dev, &vsc7512_target_io_res[i]); + + for (port_res = vsc7512_port_io_res; port_res->start; port_res++) + ocelot_core_try_add_regmap(dev, port_res); + return devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO, vsc7512_devs, ndevs, NULL, 0, NULL); } EXPORT_SYMBOL_NS(ocelot_core_init, MFD_OCELOT); diff --git a/include/linux/mfd/ocelot.h b/include/linux/mfd/ocelot.h index dd72073d2d4f..439ff5256cf0 100644 --- a/include/linux/mfd/ocelot.h +++ b/include/linux/mfd/ocelot.h @@ -11,8 +11,13 @@ #include #include +#include + struct resource; +extern const struct resource vsc7512_target_io_res[TARGET_MAX]; +extern const struct resource vsc7512_port_io_res[]; + static inline struct regmap * ocelot_regmap_from_resource_optional(struct platform_device *pdev, unsigned int index, From patchwork Mon Sep 26 00:29:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609869 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14960C6FA82 for ; Mon, 26 Sep 2022 00:32:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233459AbiIZAcu (ORCPT ); Sun, 25 Sep 2022 20:32:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233376AbiIZAcR (ORCPT ); Sun, 25 Sep 2022 20:32:17 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2111.outbound.protection.outlook.com [40.107.96.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D87E2CDC6; Sun, 25 Sep 2022 17:30:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rg8EeUhOpvEE0ZTO/vPSXiJEthMff+7h7/D7Njcr18DqleZ+ApH82dofMCa/XvFCQnM5DXIZX0B6CdyDJKHmsJ92rbIRiAvCrbI1M1EWV4CqP+C4fNFXtjHcBRj+dHIKRVYHzhN4CaeOBxCcJVmRrijhDR+7gMhOkDvZNoxy7AsKa1K9zTMNC6JD3uFlUtfa9VyQkGS6SrGflGnTyOo5I+AlEdCT/jB9PNsYdxqePqR4djPf/Uu5Ehjhtein4RUeBJXqCxty9FMy21h0/wbvh21iymxDFFrh7qn3vbS3jztB4fPZPGsx8HldD+S7qsNYZZdKMozzIWHRHMofKDvrsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gOgtO4olfoQJMgTD5BdxeRZ7GlcqXt0TvHTnnPb1w7A=; b=h1bYyipCO8wKL69MokMo9DllxDuXCyh1gk9Na1L/k2y7h1Nv8+WZhMvKwTkpGknhTr13fq0/OUwonFB38cInsyW+omq0KMzYUjzviJRe573Ani67ksDa44bbezAxwue0FtVWaEQUjrQMnr+4hmOLbF2Vf15YN4r1+/dt4WpZ6WvMV1y9b9wTFW9ZpOjGX2MICHM//fzfS8I8n83odQYwB7K8Yh3BeUSicS9RgWiLuYIgyU6qZsz6bkaOR9VXqGi/OOLlEVq9Gv+RclOX5h+Q4evzrssy/GkLAkuaCjnwVijbnVgSCK87hntfFrLxugK9iH64JywzH1dLKkdF9C1xyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gOgtO4olfoQJMgTD5BdxeRZ7GlcqXt0TvHTnnPb1w7A=; b=tzL9aoPJTmxYZpHKWwAJQ06u/CL/Os2z0OsfQZcmbbiP7i+zYWZw4Bn6TE51a8I0t/be47+GWVc1Vkoyqgj0qsDL6OGrBKQDhFAa6MPILzOTwFJz11iSG2SJ+HmwU6Xz/UB0AbW7kdzZQ8Q5kj+M2naLXE46QL0IHMmII6CMNTU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:26 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:26 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 12/14] dt-bindings: net: dsa: ocelot: add ocelot-ext documentation Date: Sun, 25 Sep 2022 17:29:26 -0700 Message-Id: <20220926002928.2744638-13-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d281862-959b-4bef-d8ad-08da9f564e94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GyC47QH2TjggQhh0wU9tKzBVT6QxoLx9UlFu07tEmdzxb3zj28vkSmlzerERCY31NyXAZUPPI0noV6sRq4J7C4prgyCnYMhPh2Uz7s8nvjRiQ3/EAuwkHtL4ysQa4zDqXqHdTBI6X0aR/s8QrW8Lv6/vYIhyZEIFcGbyx2a3gI79f5rwhNIbrtYYTLcF/YNJUJ7CTouDi0vju+3iCTwweSEAjXYI9jrwooPe2oVqQVUHxx3g0VQ/Mb7mHD/ccicba7CL3gxo8hELcMvKm08x4Kpv29l/4K+f6vy317F2HyTj1tqNT+Z2mtdlqESuk6Zvd9s+gpa/lI0ChhvPs2VK2ybjNGjgGqORPgTuo+EPc+pYvHJCUOelATJ/Vtf0KbUxr2gJ9re+iLqNdQkDtWvEUTLPT6YKHw5MeG1zhBQJ+kDXN5AGrvj+7ciBZKkIc1xw4QafazmPrxftUVrMesoT3GVysNcMEC5aKXenwpeCBOacFkPtT/aHO/2GscDSVJYDCglU5xPXxWhxJGTaY8MTdN3sNxI7rI56V9zU7HPfw6nO+8cucqNh0xM6ymETxxNssI1IJ4NixDJ/GBvat/CPLb4ikFzK65vjY8aXr85k1BeHPWNzx936R9zeRXyUJQMQEhvMqigbVrSB4wl9MdqbhFecgQwNadbD0YDsSngMCSei/2Ps1hI4YnAsJGXEur8n3xMwcP+sNEHTyKiZoFddIzwvU2fjv+0HNrO8flJIsJdW1kmjQ5Fcmqq5n8x1EFnZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(41300700001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XxjcFSVxfhPaG450/mQHGrhG3E5V41j4yqmp9cNhHXQDmn9IqUSfq52L5VK/MKSgxKMzRB8Fj7krGOUApEJb4XD3kSbUKw7mzXSPC3Agyii+L69BKsvuLJNP0viLvUokvww82OQbnsgH/GoGbKLpiRVg3jEbJtzR+1iCfywzAHnJimkuzMCo5jFAvkt1VyJm1DF37uNg0Axe3lNfFeYLoIPYDaGFMcVcb8zu4BBFDg3wwwTkHUgP1iikhzDY5KmWLIubeiyRSUITJ7okWlK/1eEEsB0kIoTOwRZ84sf+CzTFbBPdYLhvfApOe9IHnkvO2hu0JC1zhMTFNT7LyOuasehKbhg37NZIpCiK76LPSF94U9vvvaD/Gjgc6CySuz3cFGRC3/HgU+ZJFsd7d/PP7D72N6pc3vpVhDerNJrXpE4LWn51R9lbpw6935GzbAyVrua4Qg+ogR/6WFMicjNpo9n03F3TMI0YBd3PyivCYFBYl3fVP1xnehuU3LsTWKaKwzPK94YzxUar8OjV96YlOrqOeNSZVOzRP+9TlSmFp5nd8eam7cQQIL6U0Vszkod1mQmvxLTBoh2V8UYxsI1HM7OXI8g3cgRFyPpomPDz+/Mc7QTipxmGNhR1wnkvEDKSoaljkPhKXTwqnwRZA8e6YWcjIxDXWOUKW2qK+0U4rVcoyEif7Cwyp9cLq8eL/EiyOIi5rlAkChWP9kjxal0lWPYD4K9YzCQGLxYLh9nC8cWosWF6L335UCH8BkwEC/0qwF6u9WIA9hKZIPdWP4fGNpeK7H1E+PbNAtTIyrepz2zIItGiVBCm2tPzW0L1Gy/YjjKIj2KuTfjNL0+te2Tawhx9HGYv51kgsFxEjKtvxGRaUO4zFGoPc1xQ191THfwTZl+s42maHqMdnjjcFfnZTbdiF782mHXTwh+tpISKD0y567/wm0bYV9keLx/gR3jZsggLG8u2BUklcS71M/7HAjQoBdTsQjXDXH9PHfgLZmzQ116bfkVqVrEUej713DqFVCncI4yHApyZvsqVYxkoRpwxLPoJgU8ThCunqp0S1sxqJXtY7CbFLUy2QmV7e7g0KHpF1Ju/xjNsTA0u13kvmrTBEm7eS0c3ETEvIX7EHLMfIYMmKWEYM80T1NnbcDGkgj0PYrirJpWZAxrt/NU/q/YHoTCuMuc/nSiRIX8QhPxtkQ3B9QXjUNIuIX+tyWfrJHM+Evq1gNHRXv/mYaHsdC8AFxwQTukcA8eyy1gDifWOR4tonA089GtsRp8Yw1gHWcUKnRGMRDLK7poYvcXAnf7LHBoLCVwbP41NPb3aOvEvBU8e2khvgqC1RBxGS9M7sQGas23h+ynKA0sjXfdnmVdd6X1KxlZ6655His9EWFSTzozG4JneoV9vQRne5kStLI+0rSiLmMmjdKsxtC1lVlHGNBiIAXoOMfbELctiwSiEIoDcIuVZiJC34P3rTLb7pngz99uB4h0WLldbdr9bqu3HF9LX9m3374USQhBxZK2G88xt8YoQsD1HUYw06uJMlJm1v7VFL2jJ6PZ2CZpCRwHNMjTJVWeETXbnKLwblIi+T56h/rSXtLnn7TNnRxJdQ2aoH0Y8Ok8E8Zpfj89mCXMculRVnS8Etvq0UdqLaZs= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d281862-959b-4bef-d8ad-08da9f564e94 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:26.2602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nP18DnPNR2sr3MILuGtIMSGGoecgH0m+Puqh0pyq06lbjS4+K7z8UIVHBzpwksDdkVQvXPL3MQi7YrQVcmJ6P0vI5EF+UNSc4kASaH+Yfzo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The ocelot-ext driver is another sub-device of the Ocelot / Felix driver system, which currently supports the four internal copper phys. Signed-off-by: Colin Foster --- v3 * Remove "currently supported" verbage The Seville and Felix 9959 all list their supported modes following the sentence "The following PHY interface types are supported". During V2, I had used "currently supported" to suggest more interface modes are around the corner, though this had raised questions. The suggestion was to drop the entire sentence. I did leave the modified sentence there because it exactly matches the other two supported products. v2 * New patch --- .../bindings/net/dsa/mscc,ocelot.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml index 8d93ed9c172c..49450a04e589 100644 --- a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml +++ b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml @@ -54,9 +54,22 @@ description: | - phy-mode = "1000base-x": on ports 0, 1, 2, 3 - phy-mode = "2500base-x": on ports 0, 1, 2, 3 + VSC7412 (Ocelot-Ext): + + The Ocelot family consists of four devices, the VSC7511, VSC7512, VSC7513, + and the VSC7514. The VSC7513 and VSC7514 both have an internal MIPS + processor that natively support Linux. Additionally, all four devices + support control over external interfaces, SPI and PCIe. The Ocelot-Ext + driver is for the external control portion. + + The following PHY interface types are supported: + + - phy-mode = "internal": on ports 0, 1, 2, 3 + properties: compatible: enum: + - mscc,vsc7512-switch - mscc,vsc9953-switch - pci1957,eef0 @@ -258,3 +271,49 @@ examples: }; }; }; + # Ocelot-ext VSC7512 + - | + spi { + soc@0 { + compatible = "mscc,vsc7512"; + #address-cells = <1>; + #size-cells = <1>; + + ethernet-switch@0 { + compatible = "mscc,vsc7512-switch"; + reg = <0 0>; + + ethernet-ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + label = "cpu"; + ethernet = <&mac_sw>; + phy-handle = <&phy0>; + phy-mode = "internal"; + }; + + port@1 { + reg = <1>; + label = "swp1"; + phy-mode = "internal"; + phy-handle = <&phy1>; + }; + + port@2 { + reg = <2>; + phy-mode = "internal"; + phy-handle = <&phy2>; + }; + + port@3 { + reg = <3>; + phy-mode = "internal"; + phy-handle = <&phy3>; + }; + }; + }; + }; + }; From patchwork Mon Sep 26 00:29:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609436 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49A8CC6FA83 for ; Mon, 26 Sep 2022 00:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233476AbiIZAdE (ORCPT ); Sun, 25 Sep 2022 20:33:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233420AbiIZAcX (ORCPT ); Sun, 25 Sep 2022 20:32:23 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2103.outbound.protection.outlook.com [40.107.96.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A32EC2E698; Sun, 25 Sep 2022 17:30:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LFJnWiSyGzaO5rbNFq9KbjmGBxJ3/QsFbNkzN1OEORl6RS7D4EDShGqZsR7I06pTFK/XjbguY8Qe/cCDG3McX1+YdWdkAWCK+QI1jtB2eO0fIBPkym6w1xhqmTnrXI9k9eci5rEM8jKeI5wuF+RqdLs3F8Xjit5ZV7kE2PRPUtjFYhdaeKS9QZso1vi+5z8eEBru2vY6DvgaPs4m9gHPOMzR/xi15XnNLpC/6LoqMspIFG4dmMUn0HZYLkxyubQP0f1c+rnYq3gSB8AeC2hIY9s/94SsuWjCeTFG6FbamHgMX4DbirJZ+M00NtK1XzCFYwNU3EErtLbusLio1S66Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a8G+Y8Y69mawiZ3jyxZ+YrijN9pffWSRlzViWHi8/5Q=; b=hYUnX0bA9FVtyHpW+odTExEeS3KmZFUaWOXQ+uMgPgw4ZB9xAEX/P1JChO9JmQPwRmyIo9VA9UK6J1TS3TV0UbLfCjDjJwVcYXMR83jXrjEjffmcNlFW0T/pu7OiGuIALtY3it68CEvlmWI8Dd1wwhflkN3d1YKrkM4TQmcE0DAZLXXFAT7WQOGlKrL44LP38fVBWmZWAyjblG6PeeB/gY7Q9rXdrJ0rWrEOJ4KbIMYAPpRuVSSSDT3wrhMVaSywzftm1w+g4+Gn54A6CX/2EaYBoQ+Q1f4iJ66UCB1M47wtMbK4lflxb8w5fbktbOSK4IIiyytwqFIX8iuJ8uihcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a8G+Y8Y69mawiZ3jyxZ+YrijN9pffWSRlzViWHi8/5Q=; b=H+3ve4Hl7W8WosxrBQiBD1+4cPuSbmjb2R1QbQyzpfyKkWzXpYzEPwlN78APSOUZlY6/RtRl8ruEDmX8KIwj4UlR7KOu+5HIv2QUG7kzDMil8pGpnE6Hlw+iOF6cmSPKKEzOFm/s1iNGqBk0a0d+BveDl6TdmmS9Vf0NEWyx9Cs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:27 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:27 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 13/14] net: dsa: ocelot: add external ocelot switch control Date: Sun, 25 Sep 2022 17:29:27 -0700 Message-Id: <20220926002928.2744638-14-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: 071a9def-53eb-4dae-350d-08da9f564ef4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gqfvoPDOrmMRr1HkSVFnbUi+kRuZ3jid2sfqp+W9lLTO8PNY46TjmWm+MAQqLA1FnE4tlx58RHnSwI+PrZAGHAlWWKITA2pcSrlQO/FyC3kxYyDTgtuXtfwGPq/XS1l4OZon0KWwH7jYSnJMonW79CkhTi5cipjR5AAeG4cvl0CTJnI/31xNcDsD0h/gdAi/iO3tOeuMpUzuy2/ikihRnqkQi4SwyZcH52Qc0patkbfyNxJqTkmUMpjEuMV8dO9vp+cBqErFnpEgnhpQKlLfHncWco7/TNyCXMZMLKX4GTKy1H/ysMkjXMHRmRD7TUk+0+WiNjaZ5LpAWhdSUSHAD6dFZlQ8JWj2kAaWZXLWE7IWpAT3R8qvDiHI78V8KpLFgH61S4jdqK4I7EIAwEpIFQSJPuVDcowY0Ig1VZuVusX3OQfWwDJAWZ0NdkegXe8HznJzM5DCY7ZpBwg5ZCBKlLNTAEpCqvt7/CIbR0FwrPw+IgjGXFwCG7chXKZAbtJEsA52zZO8OrqRGCdTSjmst4wppIgqmbutGhmf/jl37pQ8ClCAkT1BwHTrJ4lToXqENeO1CzIeD8TPmqesEMU+hsgQaPJOPlD+6XRU1ptDb/+L7UpCZlkhRYJXblEfqG23NwIfqdbuoHU9gNvWpAi21wOuRf0+VZzKxaTh668laNZYqW7QPMJEFDnX+lAOg9Hn5JbJkTQGoBk240HV9UX2GTaSNT+lLE/W9uqPe+KmAunORtdsZHXk0ijpauA06ZHT X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(41300700001)(83380400001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 077m6cTFLBFdeFnC1YpCPtygOlw1GbXSrSE4IhrgZW6irT9bxiVDiY15rVGml4k458/DjwtW23maquw2s3SneQ9vQa1vMWDUtjw+c+dp44dk6XM5miXTFvTpJpADxW+f4fqqmcma9Msj2wgzWgbVknmHvtZEBJ0FBqYVOJbmjyyesKIwT+Dmb1+aiuAzOz5a5BTK9VqYLdItZuYidQTP2c+H7YcqpG4ojqTN7L20188nfrfkmNEDUZDaugnLCDADWlSXopMweLKlmd0ny7esvE6U2WXngVQPeEBrte4AHfvKd8wqDjmoGnKqKytRhO1OanBPTOSM9VRA5mbObk1eddS1IHBcTt1UJtEIeGS3jKMNIse920uePOHlvOAJgrJuIoN/NNU2V9sw//Khg7IHr/wbmPbvzNw2NZFBFXYS/PPk+bxv69/0hqT4qm/GzJ++JjyLpeAq1VSwpDFOMBDC7zCcPHlWx50A3mBaF+7bXok5ryI3fPqwBCDznxVigxbIzuXWQlezYG4snh/xNsas1TLPwk3nz8aYURsla2u0RXvQjkNxXhSozQX8tclu6qO/tLL79JMmX5BrAz4F6vhen1G380n/R7ub3KqvaGnK6UywDWicnE4a2b6v/rIHOnkMK1hrLMITs5sjE6FE9vc8RLkPfz3X9/7t+ZkH+XvwfFvW8hYw8ufwL8Uoml9+6PlSF7kXDiw1asa/t84ubzovsvukzcEgk1kWSGpvMBRazSSVTJmPVrTea8QJjk/gNuZsrfYN3+kArOb4fgidA19xH1cymR6wGO498nBUnDuNZY1wnKmVh7UVwwDXngkECu6U5j1UDMrOPyOvtu4bjhMAxCWU/50Xex2Hw3CK96U8MgbdUwAL4uvDcrzwOROC6EVHa0aPb4ks+XwQQ31UV9zc3ZCl/OX7mJSLkBuCU+WnzUfuAPLNXfvEP4swO6yLGP5Nx8HzNAbxMpQHcAxN8Y//WI78fqVS5/Ms5Z1lAkbNRe9EXB9JaOsv7vw4HKZBU/U1rg0UzXxstfhBH5dPz5GvT3QPRekVW/FgES99IVKcXlwnuv7bv1Mbs7We2Pg3UIhSPg3vRnwip8XbGR3LWco2W/IR5WPn2RNSkDPHjIbSfKppvK/x1ASs0H/+uQ+MINIccxdFPODw72dOPgPkNoMBnlA6Fxn7zGzPtKeh8rjx2EyQjPwLXw0N7QGbJUcsqfCIHtu1w/WufyQ+yhz96wgbKfMvfUQt8Koobo9LJd8waDTHMqtYUnCTw1AOLbLqN2jJ7oyS8LT5uG7GzbgPg0FPb02HLXxxsPfdCfPX0xcLyleUNpp+QisdlkF/B+/oUJnO9dTsBn4bsX5isr/ePUra7fS+jFaL1KA3tx6sHBHN3eQbTvKvFsVRpf1+THIZNJohCDDqrP4JXHp+vATNupEJNef15Pjcb8Tn7rBOqRE9eBbe3BZ1PF5G4O/j3fycZ8Pda02ijtxPQtkZvsBKBSkYzTxe7L6IQd/OxgBae4de6sD1MarfyI+p2qpAyCYJMBJDpIFhzAMK0Sdep2CynqEXR5akfjxv7P4z3rIDpbcpT4HVMQ87tM9WNu3zie6GtuK1V3PLZKB6R0DEhYyGXRgdGtHT/tlEnvz3k3Wc16vmMpE= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 071a9def-53eb-4dae-350d-08da9f564ef4 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:26.8852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q3bywajhAf3N7hH/wdgxyHiNkA80LlS5XUQwunOxG+4D1tppC/HL7ULVOr9VG1dnvE/c1XBKyvKh4t1VwpK1YYKP2SBmrUhiSobzW1fmNxI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Add control of an external VSC7512 chip. Currently the four copper phy ports are fully functional. Communication to external phys is also functional, but the SGMII / QSGMII interfaces are currently non-functional. Signed-off-by: Colin Foster --- v3 * Remove additional entry in vsc7512_port_modes array * Add MFD_OCELOT namespace import, which is needed for vsc7512_*_io_res v2 * Add MAINTAINERS update * Remove phrase "by way of the ocelot-mfd interface" from the commit message * Move MFD resource addition to a separate patch * Update Kconfig help * Remove "ocelot_ext_reset()" - it is now shared with ocelot_lib * Remove unnecessary includes * Remove "_EXT" from OCELOT_EXT_PORT_MODE_SERDES * Remove _ext from the compatible string * Remove no-longer-necessary GCB register definitions v1 from previous RFC: * Remove unnecessary byteorder and kconfig header includes. * Create OCELOT_EXT_PORT_MODE_SERDES macro to match vsc9959. * Utilize readx_poll_timeout for SYS_RESET_CFG_MEM_INIT. * *_io_res struct arrays have been moved to the MFD files. * Changes to utilize phylink_generic_validate() have been squashed. * dev_err_probe() is used in the probe function. * Make ocelot_ext_switch_of_match static. * Relocate ocelot_ext_ops structure to be next to vsc7512_info, to match what was done in other felix drivers. * Utilize dev_get_regmap() instead of the obsolete ocelot_init_regmap_from_resource() routine. --- MAINTAINERS | 1 + drivers/net/dsa/ocelot/Kconfig | 19 +++ drivers/net/dsa/ocelot/Makefile | 5 + drivers/net/dsa/ocelot/ocelot_ext.c | 194 ++++++++++++++++++++++++++++ 4 files changed, 219 insertions(+) create mode 100644 drivers/net/dsa/ocelot/ocelot_ext.c diff --git a/MAINTAINERS b/MAINTAINERS index 1415a1498d68..214b3f836446 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14752,6 +14752,7 @@ M: Colin Foster S: Supported F: Documentation/devicetree/bindings/mfd/mscc,ocelot.yaml F: drivers/mfd/ocelot* +F: drivers/net/dsa/ocelot/ocelot_ext.c F: include/linux/mfd/ocelot.h OCXL (Open Coherent Accelerator Processor Interface OpenCAPI) DRIVER diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig index 08db9cf76818..74a900e16d76 100644 --- a/drivers/net/dsa/ocelot/Kconfig +++ b/drivers/net/dsa/ocelot/Kconfig @@ -1,4 +1,23 @@ # SPDX-License-Identifier: GPL-2.0-only +config NET_DSA_MSCC_OCELOT_EXT + tristate "Ocelot External Ethernet switch support" + depends on NET_DSA && SPI + depends on NET_VENDOR_MICROSEMI + select MDIO_MSCC_MIIM + select MFD_OCELOT_CORE + select MSCC_OCELOT_SWITCH_LIB + select NET_DSA_TAG_OCELOT_8021Q + select NET_DSA_TAG_OCELOT + help + This driver supports the VSC7511, VSC7512, VSC7513 and VSC7514 chips + when controlled through SPI. + + The Ocelot switch family is a set of multi-port networking chips. All + of these chips have the ability to be controlled externally through + SPI or PCIe interfaces. + + Say "Y" here to enable external control to these chips. + config NET_DSA_MSCC_FELIX tristate "Ocelot / Felix Ethernet switch support" depends on NET_DSA && PCI diff --git a/drivers/net/dsa/ocelot/Makefile b/drivers/net/dsa/ocelot/Makefile index f6dd131e7491..d7f3f5a4461c 100644 --- a/drivers/net/dsa/ocelot/Makefile +++ b/drivers/net/dsa/ocelot/Makefile @@ -1,11 +1,16 @@ # SPDX-License-Identifier: GPL-2.0-only obj-$(CONFIG_NET_DSA_MSCC_FELIX) += mscc_felix.o +obj-$(CONFIG_NET_DSA_MSCC_OCELOT_EXT) += mscc_ocelot_ext.o obj-$(CONFIG_NET_DSA_MSCC_SEVILLE) += mscc_seville.o mscc_felix-objs := \ felix.o \ felix_vsc9959.o +mscc_ocelot_ext-objs := \ + felix.o \ + ocelot_ext.o + mscc_seville-objs := \ felix.o \ seville_vsc9953.o diff --git a/drivers/net/dsa/ocelot/ocelot_ext.c b/drivers/net/dsa/ocelot/ocelot_ext.c new file mode 100644 index 000000000000..fb9dbb31fea1 --- /dev/null +++ b/drivers/net/dsa/ocelot/ocelot_ext.c @@ -0,0 +1,194 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2021-2022 Innovative Advantage Inc. + */ + +#include +#include +#include +#include +#include +#include +#include "felix.h" + +#define VSC7512_NUM_PORTS 11 + +#define OCELOT_PORT_MODE_SERDES (OCELOT_PORT_MODE_SGMII | \ + OCELOT_PORT_MODE_QSGMII) + +static const u32 vsc7512_port_modes[VSC7512_NUM_PORTS] = { + OCELOT_PORT_MODE_INTERNAL, + OCELOT_PORT_MODE_INTERNAL, + OCELOT_PORT_MODE_INTERNAL, + OCELOT_PORT_MODE_INTERNAL, + OCELOT_PORT_MODE_SERDES, + OCELOT_PORT_MODE_SERDES, + OCELOT_PORT_MODE_SERDES, + OCELOT_PORT_MODE_SERDES, + OCELOT_PORT_MODE_SERDES, + OCELOT_PORT_MODE_SERDES, + OCELOT_PORT_MODE_SGMII, +}; + +static const u32 *vsc7512_regmap[TARGET_MAX] = { + [ANA] = vsc7514_ana_regmap, + [QS] = vsc7514_qs_regmap, + [QSYS] = vsc7514_qsys_regmap, + [REW] = vsc7514_rew_regmap, + [SYS] = vsc7514_sys_regmap, + [S0] = vsc7514_vcap_regmap, + [S1] = vsc7514_vcap_regmap, + [S2] = vsc7514_vcap_regmap, + [PTP] = vsc7514_ptp_regmap, + [DEV_GMII] = vsc7514_dev_gmii_regmap, +}; + +static void ocelot_ext_phylink_validate(struct ocelot *ocelot, int port, + unsigned long *supported, + struct phylink_link_state *state) +{ + struct felix *felix = ocelot_to_felix(ocelot); + struct dsa_switch *ds = felix->ds; + struct dsa_port *dp; + + dp = dsa_to_port(ds, port); + + phylink_generic_validate(&dp->pl_config, supported, state); +} + +static struct regmap *ocelot_ext_regmap_init(struct ocelot *ocelot, + const char *name) +{ + /* In the ocelot-mfd configuration, regmaps are attached to the device + * by name alone, so dev_get_regmap will return the requested regmap + * without the need to fully define the resource + */ + return dev_get_regmap(ocelot->dev->parent, name); +} + +static const struct ocelot_ops ocelot_ext_ops = { + .reset = ocelot_reset, + .wm_enc = ocelot_wm_enc, + .wm_dec = ocelot_wm_dec, + .wm_stat = ocelot_wm_stat, + .port_to_netdev = felix_port_to_netdev, + .netdev_to_port = felix_netdev_to_port, +}; + +static const struct felix_info vsc7512_info = { + .target_io_res = vsc7512_target_io_res, + .port_io_res = vsc7512_port_io_res, + .regfields = vsc7514_regfields, + .map = vsc7512_regmap, + .ops = &ocelot_ext_ops, + .stats_layout = vsc7514_stats_layout, + .vcap = vsc7514_vcap_props, + .num_mact_rows = 1024, + .num_ports = VSC7512_NUM_PORTS, + .num_tx_queues = OCELOT_NUM_TC, + .phylink_validate = ocelot_ext_phylink_validate, + .port_modes = vsc7512_port_modes, + .init_regmap = ocelot_ext_regmap_init, +}; + +static int ocelot_ext_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct dsa_switch *ds; + struct ocelot *ocelot; + struct felix *felix; + int err; + + felix = kzalloc(sizeof(*felix), GFP_KERNEL); + if (!felix) + return -ENOMEM; + + dev_set_drvdata(dev, felix); + + ocelot = &felix->ocelot; + ocelot->dev = dev; + + ocelot->num_flooding_pgids = 1; + + felix->info = &vsc7512_info; + + ds = kzalloc(sizeof(*ds), GFP_KERNEL); + if (!ds) { + err = -ENOMEM; + dev_err_probe(dev, err, "Failed to allocate DSA switch\n"); + goto err_free_felix; + } + + ds->dev = dev; + ds->num_ports = felix->info->num_ports; + ds->num_tx_queues = felix->info->num_tx_queues; + + ds->ops = &felix_switch_ops; + ds->priv = ocelot; + felix->ds = ds; + felix->tag_proto = DSA_TAG_PROTO_OCELOT; + + err = dsa_register_switch(ds); + if (err) { + dev_err_probe(dev, err, "Failed to register DSA switch\n"); + goto err_free_ds; + } + + return 0; + +err_free_ds: + kfree(ds); +err_free_felix: + kfree(felix); + return err; +} + +static int ocelot_ext_remove(struct platform_device *pdev) +{ + struct felix *felix = dev_get_drvdata(&pdev->dev); + + if (!felix) + return 0; + + dsa_unregister_switch(felix->ds); + + kfree(felix->ds); + kfree(felix); + + dev_set_drvdata(&pdev->dev, NULL); + + return 0; +} + +static void ocelot_ext_shutdown(struct platform_device *pdev) +{ + struct felix *felix = dev_get_drvdata(&pdev->dev); + + if (!felix) + return; + + dsa_switch_shutdown(felix->ds); + + dev_set_drvdata(&pdev->dev, NULL); +} + +static const struct of_device_id ocelot_ext_switch_of_match[] = { + { .compatible = "mscc,vsc7512-switch" }, + { }, +}; +MODULE_DEVICE_TABLE(of, ocelot_ext_switch_of_match); + +static struct platform_driver ocelot_ext_switch_driver = { + .driver = { + .name = "ocelot-switch", + .of_match_table = of_match_ptr(ocelot_ext_switch_of_match), + }, + .probe = ocelot_ext_probe, + .remove = ocelot_ext_remove, + .shutdown = ocelot_ext_shutdown, +}; +module_platform_driver(ocelot_ext_switch_driver); + +MODULE_DESCRIPTION("External Ocelot Switch driver"); +MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS(MFD_OCELOT); From patchwork Mon Sep 26 00:29:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Foster X-Patchwork-Id: 609868 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7DF1C04A95 for ; Mon, 26 Sep 2022 00:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233222AbiIZAdX (ORCPT ); Sun, 25 Sep 2022 20:33:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233244AbiIZAch (ORCPT ); Sun, 25 Sep 2022 20:32:37 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2111.outbound.protection.outlook.com [40.107.96.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36AC22F662; Sun, 25 Sep 2022 17:31:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BdfZuqNZHYE4SV1nAGCgwBdFiFMXwSdVgItsCQI/nyHG1+hJoA9ddAfDFSToo0MB7iIzMxvEIDK4TXvy5qEEbghIF+xbqp0DZEFzQ+RLp/0RxTb5KLlaQB16uw89qyUSu9WiZRY+pLuWydcyDkwgKdTNLNF1J2E9od3plID/QmeFk7p7iqZbdawzgKGqEm613XwQeG5ZyAwiKtJtdbAA5z2qLWO/z8S2APadzpmt4eQz6BMa6qItgOF6AgGdwd/fPVyvqfOrjWWq+1pde8/12YetbEbKgNlqLCoVegKu2X/VUwbatbJf0rwBUm1jyb6MaEQOhc1p1hngHbll/FIRbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YC5g1ocJuDiF8rbRilSLDB2qkCF+FTUQ/rftX0G9Q+8=; b=NNk+i/dJ5/BzoxDaNUy/hFwXdj1cwP8+3AyOs181Yu/RaC0LpRmUCXAFrrgrNc+rfJL6IlWeHIOpPeXIMXk2rQ75bTfkyr/X4gMnm18EvCdzuHCgN8Nd5dJ0mIv5A3rZp71w18VTxLhy0y3dpdu9TizxortkyOBOrSXoKQ9bXVwSo1AyY8yfFn8bOKnK0qhJZFAS97EZ20pH1vCJAw/9ec/bRpGtIFz7iGkuHoryQLbZAHw2pgNjTG73tneC85iiobN7mCQMY/90S+vH5YOtfIUszM5MrEmmtTt1Sr65xADWOeuG9DBpiq30ZREjROOY2SYlfqjIhUGuXG2JifUjhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=in-advantage.com; dmarc=pass action=none header.from=in-advantage.com; dkim=pass header.d=in-advantage.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inadvantage.onmicrosoft.com; s=selector2-inadvantage-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YC5g1ocJuDiF8rbRilSLDB2qkCF+FTUQ/rftX0G9Q+8=; b=BHauCrzkuNMeNqwDcOHHPBri97vRxhjWnCtILLWwSQVnR2+IzKhQaNcYCWvJ+g/YQsdjj0YvZS9KwhNknR7yRybVYqUFDzz69DLzYlHaWeVs8fs9RCU8tyubGfcodx/w+ZJ4llZwVVP4Sjn1kagEzE23O6epTussPkJlS2+xFVw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=in-advantage.com; Received: from MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) by BLAPR10MB4849.namprd10.prod.outlook.com (2603:10b6:208:321::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.25; Mon, 26 Sep 2022 00:30:27 +0000 Received: from MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69]) by MWHPR1001MB2351.namprd10.prod.outlook.com ([fe80::b417:2ac7:1925:8f69%4]) with mapi id 15.20.5654.025; Mon, 26 Sep 2022 00:30:27 +0000 From: Colin Foster To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn Subject: [PATCH v3 net-next 14/14] mfd: ocelot: add external ocelot switch control Date: Sun, 25 Sep 2022 17:29:28 -0700 Message-Id: <20220926002928.2744638-15-colin.foster@in-advantage.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220926002928.2744638-1-colin.foster@in-advantage.com> References: <20220926002928.2744638-1-colin.foster@in-advantage.com> X-ClientProxiedBy: MW4PR04CA0260.namprd04.prod.outlook.com (2603:10b6:303:88::25) To MWHPR1001MB2351.namprd10.prod.outlook.com (2603:10b6:301:35::37) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2351:EE_|BLAPR10MB4849:EE_ X-MS-Office365-Filtering-Correlation-Id: 53c99098-da02-4712-2f21-08da9f564f51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lxb9bDwBkVK/NPqaf9R9zdXx13t1OZQnlUnMFA2tQWlGClGAwrNh2chx41guIVQIgsTJY5H+UVMMIf5XMHe7Cbn23d/VG8D+k+gBI/NPyIC4ojYxfsmRysQDy3oBLHvWLW244SYoItkvgAMJEMv0E6rJZpHAUErxJmKWrfStbeCCjev6LXSZhfgCPUTcawBHc0Il1DEZn8m6tGOxQK6LJjio6LYx5bbqzQIN6I/JtllU+kOso2Uuq5ddM6Hf76cZyzaiLRNTupysqX2mj1IOPu/F47ogncvAMbyyTzD4wwx9jyQrLSegiRe69BaWys9u/hZs5LpVBzpqgEY9hQvxvJxPq44Ps0k4iEL3ehs9MQmh6EwCB4UIEqHV1OEDjbdgLRDZrNmMzMOx3g7jRK6B3xYlQkxFIuGEEYyZ4nHFnO/kmbTxFZdL06sAZnrJ4Aq/C8cIVMnQY8rvpfmCUiJsVeA0LvQmhGkhHBMqRjZKBI4eSgqw9GjA1gALv79X8+gNPjETrkxUbQWGXIOmP2GiIfGIkPurnVIq4UKWnsFgkXtaLGSGod2ujSX56bVi7zHPZrq0aN+6K7b9i5++dROCvWfRhgvRvzQ5fc/+vCD5R4mbaLNMlDqQTppNlJaRTTc/08EUBjonFmAFgFBDI59iPeSQ52mRkzy2eTLqTOtQyOs6p/ki/gVeqjKtWjBUqxKAxHquf6HXxE6V9ULFFtnDiAUIp936ZvEfJAkaFjdAHZdPR+Eg420zyaGocm2NhiWY X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2351.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(376002)(39830400003)(366004)(136003)(451199015)(54906003)(38100700002)(478600001)(6486002)(316002)(2906002)(2616005)(6506007)(6512007)(26005)(5660300002)(1076003)(8936002)(7416002)(186003)(52116002)(86362001)(8676002)(38350700002)(36756003)(44832011)(4744005)(41300700001)(66946007)(66556008)(4326008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QZ9zBR/trxrMaFZaITUr//Weh9jYqd+RPUDts3AUj8gZIrxd+PNrwxOFU7HlDuZ26tWOg9AEYoV+97h8ixBfoP7YFgqa3JcPxUFDN0MOcshRrFJDqmeFK93/GrsqWTiGS6a8O30BgNhbX3wyXqjseTua0448x3Yk/kZBFSjSvsuX47NDZoRIDJcGnCRg7Wsu2A9FPeKgC+aurY8EMs5p4cJyKhFhl+BqXtKNKEEI/jLn8qJbs2vLBtekiQFzya+jyTYvNnqxSs+PcvKm5qvRaxrzjqZgBrtz5YUHBeA/yyyY0S0mNhNnLMnepuZWx/GZGGrGi5MievbYHKWnwfJKmSGJa2oZw/2wEY4a3bWHhbGxyfcl3CRgbeROsMQmxfLOX19rhrHZMl0YGltNgj5ZKsuWBVGO93ESlmNvKaqdEwrOaLa5pU7F2vneA+eEjQrYtzNl10AKeXVcA9z6qrVL6ESRWU2jf0O4BWo0AlYkEdqITClHyvdOnoxYHgWDXFja++wG1BBrdCyazPdCa+LFsiaqhv1QzRTv5gsHQrecseAufhvHSoAqQZ9N9GVIUXc5L6XMiTahraCJS37J16V6kKgxehSt2cp435cFzA6YjQbrRw3agRYvfMLMraGRoVEkhk5VUkWYNZ4YuNnsPLlD2mzrS4BswGdtBnIoYGGFHYa8UbU3SmSXi7i38OwDAkZwv4cLcrjEMaocVg6UA7ZDk2bW5P0T16MtUP3PsXPPx35/564U65Euqf7J+Gt2w52guyKdD0ANC2XjXYRK+VIn4+Xmz0pWyEGe/6cDAiL7e+s43TabVMNSXBIoLIPESvFPawhK8IlbgPrRZ+7Yn/UQmt6S0DkVlbgzgaAgiETL+tqzjwgR5cvsbMZmi75YyH9Yudn5gjp+fQJX+aSFPE4LKGABKVl40aSHWtxET0gHW+i0RMpIX3aDXsqLvx01ERxotDhRCVOdtAS6xlV5MMFraJs5rsDByTGrdjbpSSNDuwAbV0MYyT8zT6VIkzRBDJUV7HEGGavMy709sIllZkE6AkkLQpjJ28WrAQVf8xslbBcLW0rmjO17yCctplzIonQRvnmSH/SRIhNLxwup4270OUuY8+6u7hoX4Euu01ua2hUpJKMcZ/pgDEXiaqVpB9HGA5tLVt6ZdKvpaWhkjYdEwhEcmG6KR1+5yrt95X0T3VjfZsavNkOsr87mLiIw43CibigFkcA2IpV6vFypED/fQguW+6kUtyDVTp9HuUI12Wx2o4am11K9aBhJ00+yXneEKrLD2ia+GqVWzDkYEeOUjzPKXsEGdBConJqTL7DaS8BbyUZwrWZ8h/bcx2nYYVJA9zsyLUlmItkFMQKXWoMv0Y7EOznTxgRxL3Gv/JYQ92LPG8SG6AbBJ8ChYWfuZ2a0/hc5CUthoyr4D8agQsIgg2Ey/uCZh8ioqcDHyVtLJm3C/c0g38NA/DQB4ioj5JNh+OiIppnnXycO6tNoMIoiHlWzNN+LkXOrnkNF9sWzf3XDMicB+wHHVnUEdFxKMd55neBSMf2CT0xfSrGvC1jEgj1ArV0W/meJFehbOFs53BQ9pUZ3mVK87O9HDZ8OzAbLTm7QEsn4pHomPdEgucCbevUFpJPRMargdpucvG79/hk= X-OriginatorOrg: in-advantage.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53c99098-da02-4712-2f21-08da9f564f51 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2022 00:30:27.7289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LMpRkY0aWxt8ZGrpJwbHRg4MqgFMNvsNkneuk3HS0M/J7m0L1ZEplGq/BDQo4/UzSngGJ+AQLMQHfhSjXuiiJ59b3Ns3a0Vkog0Xdm5u9Io= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4849 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Utilize the existing ocelot MFD interface to add switch functionality to the Microsemi VSC7512 chip. Signed-off-by: Colin Foster --- v3 * No change v2 * New patch, broken out from a previous one --- drivers/mfd/ocelot-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/ocelot-core.c b/drivers/mfd/ocelot-core.c index 702555fbdcc5..8b4d813d3139 100644 --- a/drivers/mfd/ocelot-core.c +++ b/drivers/mfd/ocelot-core.c @@ -190,6 +190,9 @@ static const struct mfd_cell vsc7512_devs[] = { .use_of_reg = true, .num_resources = ARRAY_SIZE(vsc7512_miim1_resources), .resources = vsc7512_miim1_resources, + }, { + .name = "ocelot-switch", + .of_compatible = "mscc,vsc7512-switch", }, };