From patchwork Sun Feb 24 15:15:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 159145 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp1067061jad; Sun, 24 Feb 2019 07:16:23 -0800 (PST) X-Google-Smtp-Source: AHgI3IagkkdtC5kIfRqKPEZiilHAjqWQz3x/iDWL7suQYVUGBQh/afAxrDSpr6/+GakHPzJyNDGa X-Received: by 2002:a25:3783:: with SMTP id e125mr1706238yba.362.1551021383795; Sun, 24 Feb 2019 07:16:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551021383; cv=none; d=google.com; s=arc-20160816; b=xxP2822T5IqsLV8xx3yOTlxoZcpRazNSa/OuLraEC/hi4n7NKBxHh4diO+cKW0tfNm vXyM2+OdhsyjmmiufR0ugcu1VicTLiHWdt9Eftw8BeIBau6pDC9RixfGLX0tRWYYCl5i G8dst0yNBEH7uddfqVUoCtaYlfXWFmk+IuNRiQ7aw2Ye80jep2c6Z7PcerSrLLFITw+q pBq9jNE7WxM0VHbdgUPsRzqXcEdm7ELJFFANFU1HAjo9MxD0EmtwKcC7GPtQX9n4vA0x jaOsXZrAlmCZAGuJOx8dmSZqWzT3E/6CJDN4+TQgkZLIaCLbisxZ7/K8uOiukderX4Qb v+dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from :dkim-signature; bh=2gHe7tQlW0HUPAtPTZ5RmKO0fOzbGo3XO5guyKO3HJU=; b=tMZZ8+5CQV2HEPZbfzfLKhkdjmJiXdOJC/2+XyC1gGMxk3kyhrA85/EYH0ah5Kwd+2 6F6bEUlCetN/lBB5iesaV2zaSrpEwyvWLYbwt9BtQtkT8aini8ZSehnYLpcTX8Xyx0g9 YVSa2ozCDFWNiO6/RHYZkM/A+HYItcOIdrBzV5pWnglMhEo+3eOpasX7lD7worNomp1A /ktiGLLxG5b7TTM07yPGq4QPgeqifHbKUrle3vws/EMvGaTRKvJaxbvioq1A4isnF3Nx ZIjRMcfpfu2mJSnVePzkLDqtLZU6xIrA7V99pOga6/n6luLlY3WaooZXStPoe34NFPRA o6ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="yAebnk5/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v40si4064554ywh.208.2019.02.24.07.16.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 24 Feb 2019 07:16:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="yAebnk5/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([127.0.0.1]:52525 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxvVv-0001DY-Cj for patch@linaro.org; Sun, 24 Feb 2019 10:16:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxvVe-0001DG-DX for qemu-devel@nongnu.org; Sun, 24 Feb 2019 10:16:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxvVc-0007t1-IT for qemu-devel@nongnu.org; Sun, 24 Feb 2019 10:16:06 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:37324) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxvVc-0007r6-C1 for qemu-devel@nongnu.org; Sun, 24 Feb 2019 10:16:04 -0500 Received: by mail-wr1-x442.google.com with SMTP id w6so3929806wrs.4 for ; Sun, 24 Feb 2019 07:15:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2gHe7tQlW0HUPAtPTZ5RmKO0fOzbGo3XO5guyKO3HJU=; b=yAebnk5/qxkQfxSkew1Sa6tueBxufe+RCWEaqIpfZ4yDfLhI+vF9DCyffHf1ci3xBz gTpmntb1m45T9vY10J+fKXR3iuNoGrLQp/WaSYmx9Js3uZXOVZsK4xAgT6kEsEICeJ8z n0O03Sj2Tvqpijqz+yJELY9zwrHm7bnf3CI71wZz2Unx80qLK1ie2Rv0UwrMAXKYSDoK y0VWBcYIxkUG5XWtbeRO5LoDnFrxl8dWXZxeFeNrXtTEnVRUxkhXw5R0t6d+b+8L7tiI fRAXL/DrLRYDsnSsweM8csHl+9xQa34h4l4WcP29YBIqrnshsxg8EJoDaDDu8Do3/gtq pagg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2gHe7tQlW0HUPAtPTZ5RmKO0fOzbGo3XO5guyKO3HJU=; b=JLglQeXI+0EUvcJ4apYvtUrqd7tyF2ERRJeVuQxL0HH4Y53K8NJ9omC98AFLc0hvMH D0xXpjXapOMjr7P4kGiLGwcjnHrQjgZQMWYxaxhQSh8AhBvON7kVAvhi8E5uvhEnk+MW i/65/dP3yHV0GQ/14puzc7A6MEQRJA3n6Zzd3WSmcIVqXvEHgWn817yyYRLZsLuoaB7c M/Sb0qsO6K8cwwkmnt2I9R9qLT4zXNUy1eobtw1EcmDfb8swLn4Z99ioDn8XmQ4EKSyT 55warJL8KUGT7Rv+xdnpp9UVB0mxvLmUVnOviMLLm5DjSLTEN+l+wletCishDW6KX4lv DWYQ== X-Gm-Message-State: AHQUAubE1+L+FN+8Yq/lsi018m9qp8mZHj/oqQ2NBVesKSYdeaB+ci6e YyPPOJLQa5bEOrEZnxkW5FeAlg== X-Received: by 2002:adf:fd07:: with SMTP id e7mr10325011wrr.175.1551021357993; Sun, 24 Feb 2019 07:15:57 -0800 (PST) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id o12sm17698356wre.0.2019.02.24.07.15.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Feb 2019 07:15:57 -0800 (PST) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 0FC5B1FF80; Sun, 24 Feb 2019 15:15:57 +0000 (UTC) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Sun, 24 Feb 2019 15:15:53 +0000 Message-Id: <20190224151553.31344-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH] tests/Makefile.include: test all rounding modes of softfloat X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We missed a bug in a recent patch as we were not testing all the rounding modes for all operations. However enabling all rounding modes for mulAdd does slow down the already slowest test and doesn't really buy us much additional coverage so lets allow the default test flags to be overridden. Signed-off-by: Alex Bennée --- tests/Makefile.include | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.20.1 Reviewed-by: Richard Henderson diff --git a/tests/Makefile.include b/tests/Makefile.include index 060f765b0e..f260014f02 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -898,12 +898,12 @@ $(FP_TEST_BIN): # The full test suite can take a bit of time, default to a quick run # "-l 2 -r all" can take more than a day for some operations and is best # run manually -FP_TL=-l 1 +FP_TL=-l 1 -r all -# $1 = tests, $2 = description +# $1 = tests, $2 = description, $3 = test flags test-softfloat = $(call quiet-command, \ cd $(BUILD_DIR)/tests/fp && \ - ./fp-test -s $(FP_TL) $1 > $2.out 2>&1 || \ + ./fp-test -s $(if $3,$3,$(FP_TL)) $1 > $2.out 2>&1 || \ (cat $2.out && exit 1;), \ "FLOAT TEST", $2) @@ -984,7 +984,7 @@ check-softfloat-compare: $(SF_COMPARE_RULES) check-softfloat-mulAdd: $(FP_TEST_BIN) $(call test-softfloat, \ f16_mulAdd f32_mulAdd f64_mulAdd f128_mulAdd, \ - mulAdd) + mulAdd,-l 1) # FIXME: extF80_rem (broken) check-softfloat-rem: $(FP_TEST_BIN)