From patchwork Tue Oct 4 21:35:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 612393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C20C433FE for ; Tue, 4 Oct 2022 21:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229516AbiJDVfL (ORCPT ); Tue, 4 Oct 2022 17:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbiJDVfK (ORCPT ); Tue, 4 Oct 2022 17:35:10 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28DA4520AB; Tue, 4 Oct 2022 14:35:08 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id b15so5906836pje.1; Tue, 04 Oct 2022 14:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=VxhM66mMMUQbnYR8BIES2RN9lh3AWlJeJAa9Fgty5So=; b=b7hC7vRRtEXFCYyZxaj+EWPRsUKYnWuZw1FX9KcRCTkqra5waRPl9Fuay2F/ST4gKv 9mPF4JXkqPUt5hVTvqoO5WBb2giRQA9m7FnGPisbRUA4MLLANY6y2hy7ojM0YScGNe7c n70gRO+i+la2JZXG1iZLHLLWmIS11kTMZnYrPo+wjhveK3EbYEwDkIH25gTeMsTcbh6g H68D4y6359V0uTFPPDRWtrikkYx69Ad/JPfRmQ5LU5MYopdRj1muucD6AChnea85oQ3W DFjEDGXOrVknN4vI3CKBP+7iJV+LMyq2/M33uyfOeQYIqBbNLOQ5hmPtCd+2xhHvf75K zqbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=VxhM66mMMUQbnYR8BIES2RN9lh3AWlJeJAa9Fgty5So=; b=oNNHWm3E7UoZJSSrWxwcKUF1Kdn2APq79MEmW432LbQWyMnQAVj1Wd+jN0qy+ja+L7 Vhypxqvl897UydGgfmQMcTbq3+OzUGpwdtAsyrmIiSsE6crwvhrHq0inMwbmc7EQEzrX T55FQ6u5Ul0LyzHTRiP/VPeopB7oTHojtm3+eBcicoTyZlCqBKPMeamr7vdKM7Fvpu5V gtnX0LQ39iDt0a9ney8CmYujnMtim7g/RxlE+ALo2be92AuzWGrwIqW2JcCUnLm3K+O5 SVxRp525JmZS8g9bjyzwHNLCKrUI2CBUUvkfPP9U9gicstLaGbGQ8O9cdUD3QEQxEXTs h4tg== X-Gm-Message-State: ACrzQf2+Kvejz9wI4nQECXdn6DcTt3EpGgzM18PKR3xd8tsWO1hGL/gq htdM3Tjl4+Rq5K/YExFRjP1f0q5aWW4= X-Google-Smtp-Source: AMsMyM4Xo0MrP6m95yQTu2zoNqaIxVAFAUc1CXY3o4Q9AcskF1uInnflpvVWA0f39QpbEFM2jal3JA== X-Received: by 2002:a17:90a:aa96:b0:205:bb67:a85f with SMTP id l22-20020a17090aaa9600b00205bb67a85fmr1652256pjq.202.1664919307565; Tue, 04 Oct 2022 14:35:07 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:978:a034:8ff4:b4b5]) by smtp.gmail.com with ESMTPSA id y187-20020a6232c4000000b0055f209690c0sm7675219pfy.50.2022.10.04.14.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 14:35:06 -0700 (PDT) From: Dmitry Torokhov To: =?utf-8?q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Krzysztof Kozlowski , Rob Herring Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] ARM: dts: omap3-n900: fix LCD reset line polarity Date: Tue, 4 Oct 2022 14:35:00 -0700 Message-Id: <20221004213503.848262-1-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The LCD driver (panel-sony-acx565akm), when probing, starts with line driven low, and then toggles it to high and keeps it there. Also, the line is driven low when powering off the device, and ls released when powering it back on. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS. Signed-off-by: Dmitry Torokhov --- arch/arm/boot/dts/omap3-n900.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index dd7971556449..c2e5bde19452 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -1038,7 +1038,7 @@ lcd: acx565akm@2 { pinctrl-0 = <&acx565akm_pins>; label = "lcd"; - reset-gpios = <&gpio3 26 GPIO_ACTIVE_HIGH>; /* 90 */ + reset-gpios = <&gpio3 26 GPIO_ACTIVE_LOW>; /* 90 */ port { lcd_in: endpoint { From patchwork Tue Oct 4 21:35:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 612392 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0498DC433FE for ; Tue, 4 Oct 2022 21:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229725AbiJDVfR (ORCPT ); Tue, 4 Oct 2022 17:35:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbiJDVfO (ORCPT ); Tue, 4 Oct 2022 17:35:14 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5C2B520AB; Tue, 4 Oct 2022 14:35:11 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id b2so8880648plc.7; Tue, 04 Oct 2022 14:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=SEuMG1PV2vuBeTlNXduiO37BC+xa1Q5/Izz8GxQ/6zY=; b=GEYHFZ6A9n+QqooBY8Dpa2ko+JgUcRB4y48ms9TsecRpWql5z+J4SDWz6itkG/IRMq y6kfeWpcY3uDjgbd4+iSaXUcqALQBKAbllPQX2V6vtjBQU8hAJszM5Uam8mJfD1JKOLj m0aG5Q3TFgMieVUCYEwbiVpyc4WAIvfFU53dmygpJHaQequ4XFbYPlhONUlBh66Om5HB lBuZCBEajD3bw9CHNWbdEsPV6z/otICUnNmB2Nhj+WFEFF404zDi9oq3VUpby8x9biiu /nkCyXdVRv3MvmfEpeI6CTLGYAd8Nm44wDUtmk+zmsOXbein9dEJhCxpV8X4Uu1UIq+n kCsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=SEuMG1PV2vuBeTlNXduiO37BC+xa1Q5/Izz8GxQ/6zY=; b=QZjK0OZt9xNA/LtRqGRydHaMZribyELY9mAAZJAh5MiW1xv1lmoF6b3Kcj2L/F6idQ d3lrvztCwSrtceM4Jk2ShaNyjCceBob/FN4Wx39iaCKcHB97cTQugK/ha2tKjbILworw 3Py+3msxJQ8mgzbAzytZghhM/Xg7FwETRwPygBtXiWqQQxvADK1gBeR7VkuUgpNdN4Qr jHxMnkEsBozPG/6OJb0np8ULjf2RTWvIOTjG5OaytOQGo89+avIt8GuXfmi9bwwRjIwX DnJrV6L9Ox22RLpkgNChA+P3JSQG9KoPh2YglJXtx6d7Yp10S/WpCy4+YbXf5qxFA+Wh wWoA== X-Gm-Message-State: ACrzQf1hIIITJ0WKPs4PIkzu5ATjgcb5zscVhyaDyx0NZaGjoDAy3HlE AD4O/S82Ym15ILzUPffdS8U= X-Google-Smtp-Source: AMsMyM4dGFz0In6c5+NmHVzG0Hi2cgXiNr0O3tCLUHm4/juYyyCteobJwKJkdtOBsuRgZwMl4819zg== X-Received: by 2002:a17:90a:4413:b0:20a:10e2:cb3 with SMTP id s19-20020a17090a441300b0020a10e20cb3mr1644705pjg.37.1664919310938; Tue, 04 Oct 2022 14:35:10 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:978:a034:8ff4:b4b5]) by smtp.gmail.com with ESMTPSA id y187-20020a6232c4000000b0055f209690c0sm7675219pfy.50.2022.10.04.14.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 14:35:10 -0700 (PDT) From: Dmitry Torokhov To: =?utf-8?q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Krzysztof Kozlowski , Rob Herring Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] ARM: dts: omap3-n950: fix LCD reset line polarity Date: Tue, 4 Oct 2022 14:35:02 -0700 Message-Id: <20221004213503.848262-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog In-Reply-To: <20221004213503.848262-1-dmitry.torokhov@gmail.com> References: <20221004213503.848262-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The LCD driver (panel-dsi-cm), when performing reset, starts with line set high, then drives it low, holds it there for a moment, and releases it back to high. This means that the reset line should be described as "active low" in DTS. This will be important when the driver is converted to gpiod API which respects the polarity declared in DTS. Signed-off-by: Dmitry Torokhov --- arch/arm/boot/dts/omap3-n950.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3-n950.dts b/arch/arm/boot/dts/omap3-n950.dts index b2f480022ff6..fa133612bcc2 100644 --- a/arch/arm/boot/dts/omap3-n950.dts +++ b/arch/arm/boot/dts/omap3-n950.dts @@ -235,7 +235,7 @@ lcd0: panel@0 { vpnl-supply = <&vmmc2>; vddi-supply = <&vio>; - reset-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ + reset-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>; /* 87 */ te-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>; /* 62 */ width-mm = <49>; /* 48.960 mm */