From patchwork Mon Mar 4 20:06:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 159593 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp4160764jad; Mon, 4 Mar 2019 12:07:31 -0800 (PST) X-Google-Smtp-Source: APXvYqzVIL2GNs1Si2vQ7Dj3xaCwdkxbWbYAGnVTGqrb3zcng5pfxYu1uk/MiHQna3xpfHm2CRU+ X-Received: by 2002:a63:1f5e:: with SMTP id q30mr6694625pgm.63.1551730051834; Mon, 04 Mar 2019 12:07:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551730051; cv=none; d=google.com; s=arc-20160816; b=oLvjUpo5xKBud0J/jUMPuIjN+0OOgJsWACryai02lC8b/MQps+opfQE++K0bqs6VbG L8x7Fuh0dV/ItT/dDQozHO3AcMc8uBZ0Bi+PEagwyu+T844wTC7c0GTHI0CmaZQ5VTNB oL6wwIYWJeSfVeNIcfLg93LjDkz/HMgRF9YSnVySK2NpCr57RuGarVoi+29mMTfRjmXO g6deCzo9u+hslG7zxTdv9Cq6TEtOmR8vjhRFGnbaoZPLWxyLiMm6AZXDD5Asdx7THT+A UgQvfqA/R4ZhHqdUy5FH/ft8ZNVF3x7WPHzrg77Nu+5yhnnGpDlo0PhF13tNJ6bn1Dfi LCGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=C/KsnXI77BX/uC+H4jrFl1NRIdrqwMo0j0LC/tydh5g=; b=kAvZKYxNlyTauVpRSA/hE6D/cV3WOgOPJsxbkPV2wMshMX9Pdc4U4sT3D0FyUG4Rrw istWc4fHaEhXkN4/M1isfThCPRE/iplX/aTZAzHoHmsULqeKNU0VCFXcT6rAmfPFp39x Gp8iaggpGBTANueavmJhZ8DHvL17DMnpMB73hgVY17yO2U9N5g4pNRGMKQpSbhGLLGxy dRf3QEtbtSB6SK1otGfBupeywlThMQbcpFSdqBUGMY/PkbfqL8uEia8EDt0NPwFLZsa/ OnrGqTB3ReVv9m2PGb9A435ez0gL4XjRb/NvYaWBdoIW1fCdx3aDXs+8qcJIMMkQChGO z+aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m3si6037254pgs.8.2019.03.04.12.07.31; Mon, 04 Mar 2019 12:07:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726203AbfCDUHa (ORCPT + 31 others); Mon, 4 Mar 2019 15:07:30 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:50277 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfCDUH3 (ORCPT ); Mon, 4 Mar 2019 15:07:29 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPA (Nemesis) id 1M4384-1h0trt2NiC-0007i2; Mon, 04 Mar 2019 21:07:21 +0100 From: Arnd Bergmann To: Benson Leung , Enric Balletbo i Serra Cc: Arnd Bergmann , Duncan Laurie , Nick Crews , Wei Yongjun , linux-kernel@vger.kernel.org Subject: [PATCH] platform/chrome: fix wilco-ec dependencies Date: Mon, 4 Mar 2019 21:06:51 +0100 Message-Id: <20190304200719.1382717-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:/v3yO6TDk5tSSmrr8Ji4PHRmHqwKTNQ/vI50XsyjOHrBvdh6gIr 9+e+YQf3vylviPbDCfq0RyXNlgESMuVKYzb+r6s3Pp6dYg/dIqAN/QO4l6419+OCMtoX3Gx 2hrIm00ncWASPYMZJgqpHzkKqZlw9KBgoK1eydhaz3HwxgxZUaCKbAECFo6pEGzgUhh5cFz Woq0rXDUiWYPsu9+vc36g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:KBqFG4Xa3S4=:ZKL2GIl6XwJMIHaPRqv4Dc g1Rhkbu6a2Y2V9N7qHAfxu+UCzn97MEBQPZb8JyFRl6NojM1LEi9Vvdv+5Oo1OvV3LJP7+jlI N1WlJXbGzaQjcC1VYxqeHsbrEX8UgUrnYKXd0Cof806m6O80H37tk/0k2OyjPefuQn1kyrTit py5xIhsvwzWlefvL56ZxyRvEOAKzOpWCxHjUD4YlcM5W/t9F61l7Fd7u+JPkpVlqPuTldnjML w2AmLqKeNr0xbiyQHeVGtOal2QI2nyV0AQhYzPFnu+QhuofQweMYk4cLPEGi4gBjrxV9DD8y4 EXEITP5Sz1lDwo5JUt7T5POAI6yXxP9OOjWm1Xpa80luQuvo+eHrWcUodDVUNdvM2dDDabM3q IkrSnNpwC/B/U0BmplxNxfH+YOK0+YXMLtyIZCDO6PwkHu5b4JjZAlu+qU/bWz7OFBoA1bNDW PIBKxLHOKds6iLnuynsKUQfwt/rYzGiLPw/W4XjgZbPTQ0gJNTFteteUIUY/ZBRgOq+Nd5/xI srVDcd1cvrCJwfA0fK2mWTa+R39ZoFpw7wyNW3AT1hJtowJkbGk05V7BKCM3uXZwp34YpPpDJ zzSlEv6LKrechgmVYnEAK+meODBA0aC/7dpPZePvCRrzOLlxowDfj8tXyyytEsLd7fV8PsUtE ynI+NeApVQJ6Aya8VM1Et3U05UboyJ6e5puOAdjz2kV28b/HVdEt3ys4jP3GolBXAmIWtHDhV TqjoMVyM58SV5AfN9wnSxUJcMykcwGrZ855/eA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CROS_EC_LPC is set to =m, we get a link failure for a builtin wilco-ec module: drivers/platform/chrome/wilco_ec/core.o: In function `wilco_ec_remove': core.c:(.text+0x26): undefined reference to `cros_ec_lpc_mec_destroy' drivers/platform/chrome/wilco_ec/core.o: In function `wilco_ec_probe': core.c:(.text+0x18c): undefined reference to `cros_ec_lpc_mec_init' core.c:(.text+0x224): undefined reference to `cros_ec_lpc_mec_destroy' drivers/platform/chrome/wilco_ec/mailbox.o: In function `wilco_ec_mailbox': mailbox.c:(.text+0x104): undefined reference to `cros_ec_lpc_io_bytes_mec' The problem with the existing CROS_EC_LPC_MEC dependency is that this is only for a 'bool' symbol, so the information about the exported functions being in a module is lost on the way, and we actually have to depend on both CROS_EC_LPC and CROS_EC_LPC_MEC. Fixes: 7b3d4f44abf0 ("platform/chrome: Add new driver for Wilco EC") Signed-off-by: Arnd Bergmann --- drivers/platform/chrome/wilco_ec/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig index 4a119ced4d0c..e09e4cebe9b4 100644 --- a/drivers/platform/chrome/wilco_ec/Kconfig +++ b/drivers/platform/chrome/wilco_ec/Kconfig @@ -1,6 +1,6 @@ config WILCO_EC tristate "ChromeOS Wilco Embedded Controller" - depends on ACPI && X86 && CROS_EC_LPC_MEC + depends on ACPI && X86 && CROS_EC_LPC && CROS_EC_LPC_MEC help If you say Y here, you get support for talking to the ChromeOS Wilco EC over an eSPI bus. This uses a simple byte-level protocol