From patchwork Fri Nov 4 08:53:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 621361 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp81515pvb; Fri, 4 Nov 2022 01:54:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4O/f7dnQ6vKcx4sDMJ+FAAAwbyvJxDSiKNODFjvvGRuOM/67HKEJCm/Mq3sS437j9Xw6Jo X-Received: by 2002:aca:a84e:0:b0:359:f154:6cec with SMTP id r75-20020acaa84e000000b00359f1546cecmr17443914oie.247.1667552079387; Fri, 04 Nov 2022 01:54:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667552079; cv=none; d=google.com; s=arc-20160816; b=naAnhH7d6fIaXeAf3gNlIfftq2an9NSK1tn2JwaIXaX2V+OKV5QmSI8HORhfAnmfhQ DXEzzz1UMlHEieaMvbHeelY2d/7F0ndE3tVn5DTa9pdCYRNaEXjwH0vptvSdbMffdie5 kCy6YMJg27tcKFxOaWnoUo/i2BIGKAAwhoxRnwA14VJ4ytvGA38o/+IHPVlpu3qkEIZ1 EzG1rCZqE2U6gs9wVF5eoY3joZlf7JYaoJRNaU0lgCVikKl5pRzULv0KrpvywEcIFWai UTRfWPbR+sVBCqYCm8qisqSX4+i6OHvZmGtUkQRkVfzUH9MgK/1lke839rMHw6pDODyc Q3AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dkim-signature; bh=6A6eMtDaqxFgLsJN2qsmOBu75ggu2rPtGawlpUOGwWA=; b=yDKJ8xn/eZ55GmvyXUJQN4rQYjSrYzvyjM6w3NN5ruIpxKDs2Tz/seaHi2rjF6LCpw Xrgcjjq53V51jlObdZI1mrvveDi6wtsTdX7Z4ij40h/5pPq8WW5cUiw/XLU6NeBKRCC6 qVzRupaul7ogBeK1Md+8pWzqqMTxqbLDVX/I4fV0KznE5KJzysBTQ4nktUZm4OflxMlc 2GBK9s8ZFkKDGTg9TXFXcw0Eni8hm6SBF5WOC5GjkBawAREYNYRGVfK4E9xZe8lzw0As nzou0xkFBBYX6WqTfyTPPkfPnK2UsAgbu2fpcCNiCKOvW/MSg/aO/gIEvdXXNwXcoawv EbzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=T6P2EGqb; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=VaWqn0Xt; spf=none (google.com: lists.infradead.org does not designate permitted sender hosts) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:3::133]) by mx.google.com with ESMTPS id f11-20020a056871070b00b001367f6a9965si3908544oap.124.2022.11.04.01.54.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 01:54:39 -0700 (PDT) Received-SPF: none (google.com: lists.infradead.org does not designate permitted sender hosts) client-ip=2607:7c80:54:3::133; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=bombadil.20210309 header.b=T6P2EGqb; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=VaWqn0Xt; spf=none (google.com: lists.infradead.org does not designate permitted sender hosts) smtp.mailfrom="linux-mtd-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6A6eMtDaqxFgLsJN2qsmOBu75ggu2rPtGawlpUOGwWA=; b=T6P2EGqbXi3PEt wzuhBRyszVCiYZGHhSvZnlJm/aOcoD8jB7/8LkAgsZ8zbgt7rKQEyNP00VDneB4sYP6wcvDKFIKIS dskcxGBDa5WyoLhr8qea6GdH0+mUN9idI9SrobAr1AVJ9h0iL58hlUTt7Low3eQK0g1sFSOYo8y6d amwI8Dky18Kkq6P0R4Jkv32g5+nYFxLr6iUYFo9J87ZxpXKFgl4LOEwYbB0GcUsgfO6ArfCT8gJ1v IV0Bo2od7EyfzXDAPAaaaFy6Qp6WlLvgHjcTHHpbhi3fewbVMwin+kHnJtmFAILSlSkZ/KBoKLNXc e0o+xfJawH9AGrD1aWSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqsSP-0030uv-5P; Fri, 04 Nov 2022 08:53:45 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqsSL-0030u6-Fm for linux-mtd@lists.infradead.org; Fri, 04 Nov 2022 08:53:42 +0000 Received: by mail-ed1-x52d.google.com with SMTP id a5so6583811edb.11 for ; Fri, 04 Nov 2022 01:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=t6K3WLbhxOgDEZ9hXqPpZBln8equCl9q3CJzloOm20w=; b=VaWqn0XtodbhiJItcKfauFR5OaWGXYuLV0myA9mRKIkpXkwA+5VJhPaDHdGWF2URw6 o4mFkAHj9Ws9pbqw8AUdvgzVpzJV44aRanXGq3tV9504fpqwQFhxsfwgi1/gk0hdhiuy lRlDOYbUcZZUwMAgimggG9kIiYiRcoyN/KUHLiX1Ics1sqhR1nEV9q1UP4kEImh/Kdfe oRi3Qtj6PTSWJ41WTW2JFcr90PjQ6p6jGCU/jZ4gvSvHaWqE72MvauvHS1gD8k4QO6Vm Y97mCrIVLTB212y3cUO5z+GzlGTglMCz4OKCSwX9h+R0VRI286LUJkkYE81P1fHLM7mt hhUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t6K3WLbhxOgDEZ9hXqPpZBln8equCl9q3CJzloOm20w=; b=kMFZbFTy2ktsxtwX4xp6+EMZXiJqYKJBAyQUksJkjGhhNTQ1iG5DCchSWH80ZTS5Xn GZd5rGrxjwMb71PyhaJWAYbPCSVOrA+tNsT+zD5t9Wdc0otmqu3Ot6Ds3i1cT67r3nLm /M5lLzMkC+e83ppMK3Z7oFW8sEw6GLVPe7WPqTcDNbFk5Et/5u6zgXmvyS/Rey241sdy 1YamiIaewUM8efFPoP8bErcdCEseSUQDagforvBQeluq07PCNGqgwXfF81X6v9awvJBk b9dfmbu2UB6UNdPDV4KNDjs4G7/jHe5B8qusDQaSCbbJ5VXVxzNv4bo5O5N5zIiyoDq2 gmeQ== X-Gm-Message-State: ACrzQf2mRSceUGiTKHM+kxTby7D88Kc9Ofb4LZ9YijD+o2SQ07wlPZ0O 6Sy9TXiTGc2F0Ph/nOMG19E= X-Received: by 2002:a05:6402:4505:b0:451:1551:7b14 with SMTP id ez5-20020a056402450500b0045115517b14mr13428747edb.300.1667552016512; Fri, 04 Nov 2022 01:53:36 -0700 (PDT) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id f12-20020a170906c08c00b0078d21574986sm1477599ejz.203.2022.11.04.01.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 01:53:36 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Rob Herring , Krzysztof Kozlowski , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: Brian Norris , Kamal Dasu , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli Subject: [PATCH] dt-bindings: mtd: brcm,brcmnand: update interrupts description Date: Fri, 4 Nov 2022 09:53:16 +0100 Message-Id: <20221104085316.24499-1-zajec5@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_015341_585980_CDDEC069 X-CRM114-Status: GOOD ( 11.86 ) X-Spam-Score: 0.1 (/) X-Spam-Report: =?utf-8?q?Spam_detection_software=2C_running_on_the_system_?= =?utf-8?q?=22bombadil=2Einfradead=2Eorg=22=2C?= =?utf-8?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_original?= =?utf-8?q?_message_has_been_attached_to_this_so_you_can_view_it_or_label?= =?utf-8?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?utf-8?q?_the_administrator_of_that_system_for_details=2E?= =?utf-8?q?_?= =?utf-8?q?_Content_preview=3A__From=3A_Rafa=C3=85=C2=82_Mi=C3=85=C2=82ecki_1?= =?utf-8?q?=2E_DMA_and_EDU_are_mutually_exclusive=3A?= =?utf-8?q?_don=27t_allow_both_at_the_same_time_2=2E_Require_interrupt-names_?= =?utf-8?q?for_2+_interrupts?= =?utf-8?q?_to_avoid_/guessing/_Reported-by=3A_Florian_Fainelli_Signed-off-by?= =?utf-8?q?=3A_Rafa=C3=85=C2=82_Mi=C3=85=C2=82ecki?= =?utf-8?q?_---_I_also_thought_of_something_like=3A_interrupts=3A_minItems=3A?= =?utf-8?q?_1_items=3A_-_description=3A?= =?utf-8?q?_NAND_CTLRDY_interrupt_-_anyOf=3A_-_description=3A_FLASH_=5B=2E=2E?= =?utf-8?q?=2E=5D_?= =?utf-8?q?_?= =?utf-8?q?_Content_analysis_details=3A___=280=2E1_points=2C_5=2E0_required?= =?utf-8?q?=29?= =?utf-8?q?_?= =?utf-8?q?_pts_rule_name______________description?= =?utf-8?q?_----_----------------------_-------------------------------------?= =?utf-8?q?-------------?= =?utf-8?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_record?= =?utf-8?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publish_an_?= =?utf-8?q?SPF_Record?= =?utf-8?q?_0=2E0_FREEMAIL=5FFROM__________Sender_email_is_commonly_abused_en?= =?utf-8?q?duser_mail?= =?utf-8?q?_provider?= =?utf-8?q?_=5Bzajec5=5Bat=5Dgmail=2Ecom=5D?= =?utf-8?q?_0=2E2_FREEMAIL=5FENVFROM=5FEND=5FDIGIT_Envelope-from_freemail_use?= =?utf-8?q?rname_ends?= =?utf-8?q?_in_digit?= =?utf-8?q?_=5Bzajec5=5Bat=5Dgmail=2Ecom=5D?= =?utf-8?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM_or_DK_?= =?utf-8?q?signature_from?= =?utf-8?q?_author=27s_domain?= =?utf-8?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_valid_DK?= =?utf-8?q?IM_or_DK_signature?= =?utf-8?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_signature?= =?utf-8?q?=2C_not_necessarily?= =?utf-8?q?_valid?= =?utf-8?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM_or_DK_?= =?utf-8?q?signature_from?= =?utf-8?q?_envelope-from_domain?= =?utf-8?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_at_https?= =?utf-8?q?=3A//www=2Ednswl=2Eorg/=2C?= =?utf-8?q?_no_trust?= =?utf-8?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDo1MmQgbGlzdGVkIGluXQ==?= =?utf-8?b?IFtsaXN0LmRuc3dsLm9yZ10=?= X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+patch=linaro.org@lists.infradead.org From: Rafał Miłecki 1. DMA and EDU are mutually exclusive: don't allow both at the same time 2. Require interrupt-names for 2+ interrupts to avoid /guessing/ Reported-by: Florian Fainelli Signed-off-by: Rafał Miłecki Reviewed-by: Rob Herring --- I also thought of something like: interrupts: minItems: 1 items: - description: NAND CTLRDY interrupt - anyOf: - description: FLASH_DMA_DONE if flash DMA is available - description: FLASH_EDU_DONE if EDU is available (to avoid text-form "or" in "description") but that didn't work: CHKDT Documentation/devicetree/bindings/processed-schema.json ./Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml: error checking schema file SCHEMA Documentation/devicetree/bindings/processed-schema.json Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml: ignoring, error in schema: properties: interrupts --- .../devicetree/bindings/mtd/brcm,brcmnand.yaml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml index dd5a64969e37..cd606a21b53b 100644 --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml @@ -86,15 +86,15 @@ properties: minItems: 1 items: - description: NAND CTLRDY interrupt - - description: FLASH_DMA_DONE if flash DMA is available - - description: FLASH_EDU_DONE if EDU is available + - description: FLASH_DMA_DONE (if flash DMA is available) or FLASH_EDU_DONE (if EDU is available) interrupt-names: minItems: 1 items: - const: nand_ctlrdy - - const: flash_dma_done - - const: flash_edu_done + - enum: + - flash_dma_done + - flash_edu_done clocks: maxItems: 1 @@ -173,6 +173,13 @@ allOf: - const: nand - const: iproc-idm - const: iproc-ext + - if: + properties: + interrupts: + minItems: 2 + then: + required: + - interrupt-names unevaluatedProperties: false @@ -190,6 +197,7 @@ examples: reg-names = "nand", "flash-dma"; interrupt-parent = <&hif_intr2_intc>; interrupts = <24>, <4>; + interrupt-names = "nand_ctlrdy", "flash_dma_done"; #address-cells = <1>; #size-cells = <0>;