From patchwork Fri Nov 11 09:47:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 623875 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938BBC4332F for ; Fri, 11 Nov 2022 09:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233440AbiKKJsN (ORCPT ); Fri, 11 Nov 2022 04:48:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233374AbiKKJsK (ORCPT ); Fri, 11 Nov 2022 04:48:10 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08880B4AB; Fri, 11 Nov 2022 01:48:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9952761F34; Fri, 11 Nov 2022 09:48:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1D74C433D6; Fri, 11 Nov 2022 09:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668160087; bh=2YqPzDXDMqXwtJ11fiLbIU3FQOTlL2T/9y0yy0vOMJA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gqTSwAjQm9LrZUjZgAOOmUeOlV7fVvEnq4wJwGn9jBW15KIVAid8Fh2xn/H+VxUwM HIhBSiYLLcOZxUebTN/mWTBHKvCmy7qGsEm8bFriV96lhwkUATtrmHQH0uCjSPPctF xiRn/IBfX2jak54d50fbwP4i0Bd6focVefF0Cj95kIVQ+I5cjOZj9wfUbbEezAO3Xg Q0YXLcLqhH6mDfLTziy7J4Pz/FK+dN+nt3J+rSRfzwv7VTttHY3ZrucK4N1uH2QXsN xno3wDeAAumYSt4KUTzMazTpUWJt7dxk6h1hk00TNl+BJPwy1xryh/h+Im17om8Qrq RcRYPylpMXb1w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1otQdP-00035H-3g; Fri, 11 Nov 2022 10:47:39 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Vinod Koul , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 1/2] arm64: dts: qcom: sm6350: fix USB-DP PHY registers Date: Fri, 11 Nov 2022 10:47:28 +0100 Message-Id: <20221111094729.11842-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20221111094729.11842-1-johan+linaro@kernel.org> References: <20221111094729.11842-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org When adding support for the DisplayPort part of the QMP PHY the binding (and devicetree parser) for the (USB) child node was simply reused and this has lead to some confusion. The third DP register region is really the DP_PHY region, not "PCS" as the binding claims, and lie at offset 0x2a00 (not 0x2c00). Similarly, there likely are no "RX", "RX2" or "PCS_MISC" regions as there are for the USB part of the PHY (and in any case the Linux driver does not use them). Note that the sixth "PCS_MISC" region is not even in the binding. Fixes: 23737b9557fe ("arm64: dts: qcom: sm6350: Add USB1 nodes") Cc: stable@vger.kernel.org # 5.16 Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi index 3a315280c34a..f3843749ec63 100644 --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi @@ -1148,10 +1148,9 @@ usb_1_ssphy: usb3-phy@88e9200 { dp_phy: dp-phy@88ea200 { reg = <0 0x088ea200 0 0x200>, <0 0x088ea400 0 0x200>, - <0 0x088eac00 0 0x400>, + <0 0x088eaa00 0 0x200>, <0 0x088ea600 0 0x200>, - <0 0x088ea800 0 0x200>, - <0 0x088eaa00 0 0x100>; + <0 0x088ea800 0 0x200>; #phy-cells = <0>; #clock-cells = <1>; }; From patchwork Fri Nov 11 09:47:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 623874 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F5AC4167D for ; Fri, 11 Nov 2022 09:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233338AbiKKJsO (ORCPT ); Fri, 11 Nov 2022 04:48:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233493AbiKKJsK (ORCPT ); Fri, 11 Nov 2022 04:48:10 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9D86F015; Fri, 11 Nov 2022 01:48:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A76B2B824B3; Fri, 11 Nov 2022 09:48:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50200C43149; Fri, 11 Nov 2022 09:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668160087; bh=k7HWwmkJ5Tj0P6Rb2U81O5MNZ1lTYtGf+8AT/P4q3L8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iBoJ71x9S5lfZTP0sVVv2XlkBss9uRA/cqs+7WyDIOmnq3x1D6V8rY9wK3ZszpdiB p5dwNwkX2pBBqDEs2EnwuuxFxi610EYPMedBKenpJmb4ihq3kY8r+i3V09G1pGBApm 2Yi16SzsFrjT6lLi0n8BzVecd+hn/HyWrWuu2Ohie6OWsy+GaFhE2UEyl/yrnUa2zN jAMxVd7PlAeMjJuZ2nDDJiQy2UA3f+n4mfiPFmYhDCLSrbOCmOTuqCPt+PTSDwjCk/ V1+ZYI8iJihI+UUHx6D+EsIM97ciodtE81+tTjxxXtbASLALIgBPoxbuS3mmcJH2mw 64jzMq7ctaPDw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1otQdP-00035J-6Y; Fri, 11 Nov 2022 10:47:39 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Vinod Koul , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/2] arm64: dts: qcom: sm8250: fix USB-DP PHY registers Date: Fri, 11 Nov 2022 10:47:29 +0100 Message-Id: <20221111094729.11842-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20221111094729.11842-1-johan+linaro@kernel.org> References: <20221111094729.11842-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org When adding support for the DisplayPort part of the QMP PHY the binding (and devicetree parser) for the (USB) child node was simply reused and this has lead to some confusion. The third DP register region is really the DP_PHY region, not "PCS" as the binding claims, and lie at offset 0x2a00 (not 0x2c00). Similarly, there likely are no "RX", "RX2" or "PCS_MISC" regions as there are for the USB part of the PHY (and in any case the Linux driver does not use them). Note that the sixth "PCS_MISC" region is not even in the binding. Fixes: 5aa0d1becd5b ("arm64: dts: qcom: sm8250: switch usb1 qmp phy to USB3+DP mode") Cc: stable@vger.kernel.org # 5.13 Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 52686f963dfc..0e86ed688fc2 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -2891,10 +2891,9 @@ usb_1_ssphy: usb3-phy@88e9200 { dp_phy: dp-phy@88ea200 { reg = <0 0x088ea200 0 0x200>, <0 0x088ea400 0 0x200>, - <0 0x088eac00 0 0x400>, + <0 0x088eaa00 0 0x200>, <0 0x088ea600 0 0x200>, - <0 0x088ea800 0 0x200>, - <0 0x088eaa00 0 0x100>; + <0 0x088ea800 0 0x200>; #phy-cells = <0>; #clock-cells = <1>; };