From patchwork Thu Jun 16 11:38:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102180 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp212639qgy; Thu, 16 Jun 2016 04:38:44 -0700 (PDT) X-Received: by 10.36.65.97 with SMTP id x94mr23958501ita.16.1466077106987; Thu, 16 Jun 2016 04:38:26 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8si5648539pfi.182.2016.06.16.04.38.26; Thu, 16 Jun 2016 04:38:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754303AbcFPLiY (ORCPT + 30 others); Thu, 16 Jun 2016 07:38:24 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:60386 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261AbcFPLiU (ORCPT ); Thu, 16 Jun 2016 07:38:20 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0M8zYj-1b8Ix93wUP-00CRwJ; Thu, 16 Jun 2016 13:38:15 +0200 From: Arnd Bergmann To: Sudeep Dutt , Ashutosh Dixit Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH 3/5] mic: remove unused function arg Date: Thu, 16 Jun 2016 13:38:24 +0200 Message-Id: <20160616113831.4108439-4-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160616113831.4108439-1-arnd@arndb.de> References: <20160616113831.4108439-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K0:Ugy0SSb0mf2HvPdhCRDcESl1VepFrd/LxBuJTMubLcN29TFKHrP MrVTYsPNTOfrysHj/1Nm44OcArLdsKdUG14uSIdGHUmg6bvq7ToHRcZB7BdtSdxyLXOKvCf cmdUwJWdLAt9UGYVdZqGTUyvLli8KGM2H+KJhhmkaessz/lGYbcZQ1WM4jcu6Q5jPKTsaWG j8LFb5MQFAG48betCLnOA== X-UI-Out-Filterresults: notjunk:1; V01:K0:tedtm8zEF+E=:oZxuaDvNtJ7VY6s2FHfu++ rUihNLfDgRNBSdwgshDZKHsicMwl5KcsFlpIj+xjFn3CEKk2n+EcNHIxqsgy5ezvIbSmjLoGM J3W8L+HqHI8SobtSXSWyqGMydg8AEXQyynykPSYJS5wdheh94o34E4IQoV2MPJw+RyJx6UQO0 o/ca2fQk32G+uJLq0ViiMLgBtm+l9QIIX9cdqrKtWbKdaDQHnRxXz06KQs3ckr6Vzm+c+4RMd f9WzN61mVjPbGZtoBvLw7cPect/1HTFkbAVHfd3SENRTag88TIFawui6rDj86GT/f06nyIb2a q4XKmVvCM0MGO5UkddI5iM//seANdSwt5nLfKan+4dPgTJkBkfzQZ47fLaWK5Ng5UWTTxO8L4 i1Ykhi7FfwieAJUi1E4shl26ahVyXdqdaZqCqQ1fafVoxWkWhQ0+PXGmjQGyGwQCYidiGNW7M j2P+oG70RkHDUQsCqf4Xearb+jlnC0TsZGLbNNY1WIc1BbDCY+Gkvz2DRIHQH89ITarlX+pDO 71tR/oSjHzeOW2qVztg1sm/otxIYJ2OxNkPv5NvT7RXfK6+YV+MBswB6ZmjpbzGjRqd36+SYJ J98JZFCPM/7aHueeBL0USnWg8KSLhQo3FE4dGiHHQss8ucSA4OMJogK8eexiD1aL6aYst2Pe0 IQIcfO5RTu4+MU8DN2pagUKrd3Jde9U2U22kWyacptn1IOU62aFzyDviEqUCZIXWeFjKDOld3 yIz8JeoHQYUWUp5u Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building with W=1, the __scif_rma_destroy_tcw function causes a harmless warning about an argument variable that is modified but not used: drivers/misc/mic/scif/scif_dma.c: In function ‘__scif_rma_destroy_tcw’: drivers/misc/mic/scif/scif_dma.c:118:27: error: parameter ‘ep’ set but not used [-Werror=unused-but-set-parameter] In this case, we can just remove the argument, since all callers are in the same file. Signed-off-by: Arnd Bergmann --- drivers/misc/mic/scif/scif_dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.9.0 diff --git a/drivers/misc/mic/scif/scif_dma.c b/drivers/misc/mic/scif/scif_dma.c index cd01a0efda6b..64d5760d069a 100644 --- a/drivers/misc/mic/scif/scif_dma.c +++ b/drivers/misc/mic/scif/scif_dma.c @@ -115,7 +115,6 @@ int scif_reserve_dma_chan(struct scif_endpt *ep) */ static void __scif_rma_destroy_tcw(struct scif_mmu_notif *mmn, - struct scif_endpt *ep, u64 start, u64 len) { struct list_head *item, *tmp; @@ -128,7 +127,6 @@ void __scif_rma_destroy_tcw(struct scif_mmu_notif *mmn, list_for_each_safe(item, tmp, &mmn->tc_reg_list) { window = list_entry(item, struct scif_window, list); - ep = (struct scif_endpt *)window->ep; if (!len) break; start_va = window->va_for_temp; @@ -146,7 +144,7 @@ static void scif_rma_destroy_tcw(struct scif_mmu_notif *mmn, u64 start, u64 len) struct scif_endpt *ep = mmn->ep; spin_lock(&ep->rma_info.tc_lock); - __scif_rma_destroy_tcw(mmn, ep, start, len); + __scif_rma_destroy_tcw(mmn, start, len); spin_unlock(&ep->rma_info.tc_lock); } @@ -169,7 +167,7 @@ static void __scif_rma_destroy_tcw_ep(struct scif_endpt *ep) spin_lock(&ep->rma_info.tc_lock); list_for_each_safe(item, tmp, &ep->rma_info.mmn_list) { mmn = list_entry(item, struct scif_mmu_notif, list); - __scif_rma_destroy_tcw(mmn, ep, 0, ULONG_MAX); + __scif_rma_destroy_tcw(mmn, 0, ULONG_MAX); } spin_unlock(&ep->rma_info.tc_lock); } From patchwork Thu Jun 16 11:38:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102179 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp212907qgy; Thu, 16 Jun 2016 04:39:24 -0700 (PDT) X-Received: by 10.36.34.3 with SMTP id o3mr24354498ito.50.1466077157566; Thu, 16 Jun 2016 04:39:17 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h124si5645145pfe.212.2016.06.16.04.39.17; Thu, 16 Jun 2016 04:39:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754359AbcFPLjO (ORCPT + 30 others); Thu, 16 Jun 2016 07:39:14 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:52115 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753849AbcFPLjM (ORCPT ); Thu, 16 Jun 2016 07:39:12 -0400 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0LjJmB-1bpZrt3XsF-00dZHN; Thu, 16 Jun 2016 13:38:39 +0200 From: Arnd Bergmann To: Felipe Balbi Cc: Arnd Bergmann , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] usb: pxa27x_udc: remove unused function argument Date: Thu, 16 Jun 2016 13:38:25 +0200 Message-Id: <20160616113831.4108439-5-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160616113831.4108439-1-arnd@arndb.de> References: <20160616113831.4108439-1-arnd@arndb.de> X-Provags-ID: V03:K0:Gon9gfxuj/Y81MMDtjJELrpwo+6LLqJziVftAbbLaAovYtOnd+Q FMS1Cf59b/RCjDneDBvgXuVuSYtBRAnu7hzTnOsLEwn9w18KDXwzz6SrSsJwOTDicrP+gVa 0wrSFvkIOD1AhKgT5AUF5nMSPAFM0ve4ctsFnpJJLP8ehiwdVL0T8VQdSGbxSoFHu9khl5k PKdfzwUWwJeNfm7aIGkpg== X-UI-Out-Filterresults: notjunk:1; V01:K0:Wuz3u56SNcM=:nFh9biK6dPnZ573l4sq7Mc NjhkGnY/MGlRuQDUbWSP6z7GLrn1APYzM2xXUX+eMLfyO8GbBCza0mKqVAOCutOiBqsPhHvxA e3Ia3wAkHcRMNXTt5Pjn0ZWXxAznPtvQt6s6e01TDaH+sn9EVCqnw0p+gOepcNpXG4gifV/s4 AqaaAcIM1vXofCGrVr3L22jX2DZKr/sW24nHvfr3QAmtuaPWsU3p2l3bZxOwMSGvIIo0s5GWF 8e/klwHl2KIAVPOEvA98A+SU2bwuuwelIhk5UE3UHcLW0fecogSaFmEWRfE/Eo/eZmZALqysa ogxb3n9mxQAJRbWY7gfxJeOc9JcfrNDk8CUHWgz0hcpOOnULBVwC9GWfsYuH/yA+qFFYTAFQz ZKauiNskCD7T3BWnwZ4zdAoV4HV8yHVFJbKPx2oSGR9N9WrWzEF2dIDjmwH4UwQFbJkDYVD26 2u1l0OsJ9JXSMUIL8MxyDS7HuewSBBNFAcu3d8nfvZDkcAGjkwE9P+KXQBhVbPlv4K31pis60 r7gybKQmWcQA4F5KT3h7Gk9fSg/MUpqTopIKzW0uKH8PEfB5uVq0hjDNrAlX/8xNvkjp1HFf4 q3UA3nZDQPQ4nfb3XQIY6qshJnU6drU8l6//Pv2lh9YuAuhrZUIKpQmhrRR2MUemQjOQPanXg r4Hc7OkGmFLaIg7tSOHBdnTlLYZsSeRn+dMNJJcVKEEveL32C33+RTRWLiYG25lg2p5I= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get a warning for this when building with W=1 because the argument gets assigned to something else but never read: drivers/usb/gadget/udc/pxa27x_udc.c: In function 'stop_activity': drivers/usb/gadget/udc/pxa27x_udc.c:1828:74: error: parameter 'driver' set but not used [-Werror=unused-but-set-parameter] This remove the argument entirely. Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/udc/pxa27x_udc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.9.0 diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 001a3b74a993..ad140aa00132 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -1825,13 +1825,10 @@ fail: * Disables all udc endpoints (even control endpoint), report disconnect to * the gadget user. */ -static void stop_activity(struct pxa_udc *udc, struct usb_gadget_driver *driver) +static void stop_activity(struct pxa_udc *udc) { int i; - /* don't disconnect drivers more than once */ - if (udc->gadget.speed == USB_SPEED_UNKNOWN) - driver = NULL; udc->gadget.speed = USB_SPEED_UNKNOWN; for (i = 0; i < NR_USB_ENDPOINTS; i++) @@ -1848,7 +1845,7 @@ static int pxa27x_udc_stop(struct usb_gadget *g) { struct pxa_udc *udc = to_pxa(g); - stop_activity(udc, NULL); + stop_activity(udc); udc_disable(udc); udc->driver = NULL; @@ -2296,7 +2293,7 @@ static void irq_udc_reset(struct pxa_udc *udc) if ((udccr & UDCCR_UDA) == 0) { dev_dbg(udc->dev, "USB reset start\n"); - stop_activity(udc, udc->driver); + stop_activity(udc); } udc->gadget.speed = USB_SPEED_FULL; memset(&udc->stats, 0, sizeof udc->stats);