From patchwork Thu Dec 8 16:42:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 631936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D37DC63708 for ; Thu, 8 Dec 2022 16:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbiLHQmc (ORCPT ); Thu, 8 Dec 2022 11:42:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbiLHQma (ORCPT ); Thu, 8 Dec 2022 11:42:30 -0500 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2054.outbound.protection.outlook.com [40.107.244.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7545859875 for ; Thu, 8 Dec 2022 08:42:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJES4TxLSmZzCG73G8Ktl5JIlcxTc/Xmp3pvQIdA9Azqlnxa/A8CrX1bKnQL+1ZoVnY1mjXoLTVSmBZ51kztISOZh7taj2XoLYpo0o3jHoN7oa/aqFQ7QyKtU6pPblYxdBsULjbCjfsbcyF0Vrqh31ELPDoavYp043ZF0bfPoPe5DaKIYyIw1eGyDebIhmmCSx5wyaMPO9ZZ9bONOb6v7dfqLsl0rGjntIMdqPdeIm+n6W3nfzvJqZKLTN8R9mcoaQwRM/FKbBCHqkXyp4omt+rWw3mOue+Kq4rLWPE2Efccbnt0TzaxNFxYt62XQE7Enu9h/N+61tC0CB3EmmFfjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YSPTzDtJjJaiib+dRhTY3bPyGovgFYnN4BOLuCl0Cms=; b=HJfvfaVKVtDFVhn0cYjpBnVzj2UorlNx1VQrmqJfdfd3ToOVg1c3CiVIhAl1qAEJEaG4ywXMQkfZ6vmExPHQAfIzWqbeyFSyyAk9bkRV6xTBl+VeErNkOxXrXSo7mx5a6ywZZH23rhELJUsx1Z87F4sQWClX/P7suo9jI2rJwNjJwRDwnMgJZm1dZgKFBLSFfTcqUsEk7eO9ODvn9jDvWAYBMhgVGGpnlOr4/SK4WZ3A/yCKdfm4EpfFBYT238ki18CcXwXrzMa5CDzQA6vuMtqWqSgIYi+VpJIYhLNnLorH5FWGHfzUDGEfcYXwX7uyRgwNmbdDtq+tJV6b/Exp+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YSPTzDtJjJaiib+dRhTY3bPyGovgFYnN4BOLuCl0Cms=; b=ER9KyvNFiEM/IZqpngMSaZutHlz4PBpd9OSpF5U6w6AfQhLrHGBEp6UBDj7VFHBXOrx942fyFq7ROHfLUD/WquYe197D8kMT5mTxFWbFS1kw4jpsN2Lpx82gVoYxyDKMvqSPJnT+7vRgVf3xVW7HTotx2SQOm8CCZGMEln/ceZM= Received: from MW4PR04CA0373.namprd04.prod.outlook.com (2603:10b6:303:81::18) by CH0PR12MB5091.namprd12.prod.outlook.com (2603:10b6:610:be::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.16; Thu, 8 Dec 2022 16:42:26 +0000 Received: from CO1NAM11FT015.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::e9) by MW4PR04CA0373.outlook.office365.com (2603:10b6:303:81::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.16 via Frontend Transport; Thu, 8 Dec 2022 16:42:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT015.mail.protection.outlook.com (10.13.175.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5901.17 via Frontend Transport; Thu, 8 Dec 2022 16:42:26 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 8 Dec 2022 10:42:24 -0600 From: Mario Limonciello To: "Rafael J . Wysocki" , Alexander Deucher , Hans de Goede CC: , , "Daniel Dadap" , Mario Limonciello Subject: [PATCH v3 1/3] ACPI: video: Allow GPU drivers to report no panels Date: Thu, 8 Dec 2022 10:42:05 -0600 Message-ID: <20221208164207.13518-2-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221208164207.13518-1-mario.limonciello@amd.com> References: <20221208164207.13518-1-mario.limonciello@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT015:EE_|CH0PR12MB5091:EE_ X-MS-Office365-Filtering-Correlation-Id: 3c5969f3-af76-4c56-03e9-08dad93b303d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QRoppHF4dun41ekRnk5w5YFDj0hu+0w369jJrVKjPCBx25sr8Az5w9XAcaFflQ/tL7mNL5l6CIc/fcAucUkSMh+0yupB6WC4Pa/aZdvByHT1ouzl6z4DWmFy6tmKf1Z15VCn0oY+YkRpcQgox+5plTE5VtSSSasHU8hM5Z33YWUlUoUz12LzcmH63vC5vu0ssiH2/Gkbf8UGHmDPcQs2S9n6/sB9iHycsdVy6KbAX+I/Z+r6Q0PKvGOnk8JYQpqN4cUWv//lfqcNC6KHCrgZdYKkeqz+4tSPn/NZTURJWhyN3qG9pfpGJRTV+EYBKvV4NXQUZyNJS3SW8cA1RpuZvsEEu0zBlRfwZG23+s5C23nBcwSr9SWdVA/odMiET9IOJlnCFQt8jMyJmFx1yOR8ZttwXeM+lB7t/Wx2do/P0qmezSKRfiBlYH2ypR1+xcJD66R5wfuOxpowB91DrxadJFa6CTdxP+cLBCB0GChMfMokJgHXO8EazjnpvvUWgZQPI/3JkR77kFf1CeZGvjuwh9tjV3JyUHXT6Rvw0vfewIT6hjwBtYkfbTztmh/qW2NYW15qT3K3OkP9R1+/ZnbhUofYwdA/CdOfR2KZ7mbmXYxiTTDUHKG7TfL3hV+gbCZBO16lFRw0Yag4mk3w9VjrPQ/UPVW9++altrqmnYIL6fXwcsjUH9QwJ4sFHkyK3t2hLtmNAAS14AmQNH9DO5bHUZLD+8mJljNOFaIKXmaSGsE= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(2906002)(54906003)(110136005)(8936002)(5660300002)(36756003)(86362001)(44832011)(70206006)(70586007)(8676002)(4326008)(316002)(7696005)(6666004)(41300700001)(478600001)(82310400005)(83380400001)(426003)(47076005)(40460700003)(36860700001)(356005)(81166007)(40480700001)(1076003)(2616005)(186003)(336012)(26005)(16526019)(82740400003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 16:42:26.0230 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c5969f3-af76-4c56-03e9-08dad93b303d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT015.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5091 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org The current logic for the ACPI backlight detection will create a backlight device if no native or vendor drivers have created 8 seconds after the system has booted if the ACPI tables included backlight control methods. If the GPU drivers have loaded, they may be able to report whether any LCD panels were found. Allow using this information to factor in whether to enable the fallback logic for making an acpi_video0 backlight device. Suggested-by: Hans de Goede Signed-off-by: Mario Limonciello Reviewed-by: Hans de Goede --- v2->v3: * Add Hans' R-b * Add missing declaration for non CONFIG_ACPI_VIDEO case v1->v2: * Cancel registration for backlight device instead (Hans) * drop desktop check (Dan) --- drivers/acpi/acpi_video.c | 11 +++++++++++ include/acpi/video.h | 2 ++ 2 files changed, 13 insertions(+) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index 32953646caeb..f64fdb029090 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -2178,6 +2178,17 @@ static bool should_check_lcd_flag(void) return false; } +/* + * At least one graphics driver has reported that no LCD is connected + * via the native interface. cancel the registration for fallback acpi_video0. + * If another driver still deems this necessary, it can explicitly register it. + */ +void acpi_video_report_nolcd(void) +{ + cancel_delayed_work(&video_bus_register_backlight_work); +} +EXPORT_SYMBOL(acpi_video_report_nolcd); + int acpi_video_register(void) { int ret = 0; diff --git a/include/acpi/video.h b/include/acpi/video.h index a275c35e5249..a56c8d45e9f8 100644 --- a/include/acpi/video.h +++ b/include/acpi/video.h @@ -53,6 +53,7 @@ enum acpi_backlight_type { }; #if IS_ENABLED(CONFIG_ACPI_VIDEO) +extern void acpi_video_report_nolcd(void); extern int acpi_video_register(void); extern void acpi_video_unregister(void); extern void acpi_video_register_backlight(void); @@ -69,6 +70,7 @@ extern int acpi_video_get_levels(struct acpi_device *device, struct acpi_video_device_brightness **dev_br, int *pmax_level); #else +static inline void acpi_video_report_nolcd(void) { return; }; static inline int acpi_video_register(void) { return -ENODEV; } static inline void acpi_video_unregister(void) { return; } static inline void acpi_video_register_backlight(void) { return; } From patchwork Thu Dec 8 16:42:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 632917 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B27C63703 for ; Thu, 8 Dec 2022 16:42:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229470AbiLHQma (ORCPT ); Thu, 8 Dec 2022 11:42:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbiLHQm3 (ORCPT ); Thu, 8 Dec 2022 11:42:29 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2053.outbound.protection.outlook.com [40.107.243.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB92B4E417 for ; Thu, 8 Dec 2022 08:42:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HBiWmCuT9/8gHazUhJNKQDaG0E5rok8FWbsITF7aQBxZ+P8Yx/Xsk5bb9UCK7NXbSaPQbHnT4DljwmicP57W5n4uy1REmyAQaEebcCfELVQo+rxN0Ae8ygZZNwZhK/xWYIjKCJkCrAR4prM0nqBInvN+5IvVT7FRJeCuEeFLNBPdEQpTZzvcuIlKT3V7XTA4begu18Fu25LIr7BSo9rwMCKUKiztHEiBX5MlhXLEUtZpQjZtfilbDv+K+ezOpwtuMTEmU0Uzns1gyFg55XmVBgTRw3MOYSIoxG66BVLAtRKWbBUSEy9Nf4DfkX1unH6XfosIbv+rBmUb3ErjD7WDow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ytQKvfda0NEOJhvrhlW3S5MbyVQgIA4XN9XSJb1ttbo=; b=KuU0twLmPCEZMD1MIkFqmGGb19pOWGR3TfuqVCQUhLN+Zph6js683O0sZ6S1+dgDEUYd8vYZg5aFezGSf2jzUgHWuMifH7OSACMjUmuCKlsSyff3un5THv7rDT0w2lk29xjvI5d9haBW5JexuJ+3gZdbvRbgAhKiUgDbH0+212SGB02cljBQGnJDo16J4b1N824FVeoR64F2V7CyAKmKK/aOG84JPS7ijvSBOTTG5yOJmL7mRLxdI/pP6112m0X2QTqEm6iihkhigJ1+pq6gBlM6e2h0kaO1aPEKyAVnpuvn6vDbhqZN+kQKLP69CKcvL1wWIc1bcChCMytcPpYbbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ytQKvfda0NEOJhvrhlW3S5MbyVQgIA4XN9XSJb1ttbo=; b=FkP0uFQi+QpfbO4e1uQJ1sRymOPtOoODeOpSd8XmAM0hPmYY4aQgtFTZimM+WJEHO7N6GEFOpyMndUCoZrh4FPqeTEu/PHLOzEDoYOhkmcVqo06Ab8ZcBONVLdV3ujhn40y0eCq9+Wrfry9Lx2GCJIU0v9mTwjpWvjDhzmbPa9g= Received: from MW4PR04CA0381.namprd04.prod.outlook.com (2603:10b6:303:81::26) by CY5PR12MB6276.namprd12.prod.outlook.com (2603:10b6:930:f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Thu, 8 Dec 2022 16:42:26 +0000 Received: from CO1NAM11FT015.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::80) by MW4PR04CA0381.outlook.office365.com (2603:10b6:303:81::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.16 via Frontend Transport; Thu, 8 Dec 2022 16:42:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT015.mail.protection.outlook.com (10.13.175.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5901.17 via Frontend Transport; Thu, 8 Dec 2022 16:42:26 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 8 Dec 2022 10:42:24 -0600 From: Mario Limonciello To: "Rafael J . Wysocki" , Alexander Deucher , Hans de Goede CC: , , "Daniel Dadap" , Mario Limonciello Subject: [PATCH v3 2/3] drm/amd/display: Report to ACPI video if no panels were found Date: Thu, 8 Dec 2022 10:42:06 -0600 Message-ID: <20221208164207.13518-3-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221208164207.13518-1-mario.limonciello@amd.com> References: <20221208164207.13518-1-mario.limonciello@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT015:EE_|CY5PR12MB6276:EE_ X-MS-Office365-Filtering-Correlation-Id: f10bae81-92c5-4a13-9bdd-08dad93b3097 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nPPSxNPuU3YxrZxOD8CodJWlETRchbcjUYciaRRPeb374+mrGn1xRwuiBE1dkoZk59L8FQ/GQS458ARrmkt6ITzo1iOjYK/5hp7Ws0rolCMuNigN9HLX2z+YeWvw5iL213oJ6h/Do2AzD8fTrHpM49ujLoPRNYxY7ui/qBV1YCkwvUwnWN0h8Pe+hY2r1mthDxUQ3gsrCUSE3J8FayFZNil3/NGBCZflqBIkGEW6C87EFJ48qxzUMM5pn7+ei+/w6xpzcGE82LbGbDJyskcS25a0FspmIfkUEsyKMTl6kBjqRyFcic5RU9kZkosI8vxxfrob0Gl7Kvo9XQq8ASLfxdKByRmhb464iFW87qaWI8YVpXoWv30qxfTr7DZbk3QP/H03K5eVqdzRyh+15s/Sh833HxvIvYLn6cydn68QroYDiK2ArqytRP+zJ8jw5phM8VktfFbVCYrZNgy5zX8VEX/7LFxHHTiL9ONdwN3M1mlwBa6beCAcHCshvn9yZ/3MHQDDDYHyqbBa4waZTZaNDu+GcOkpVmFpA83/JiCMsVUGz45O0RDR2bKlgN8TJrAgG4zXb3t+4jN2FUYdw4ERdKR5vOil+CrNFDCF28otQnJn3lSSYtt/d0cNREfkfXnr/38dCMPlItKtDmRbReAP0B2hD0zHHDUsEU2tjbwt+HKJqsuIgfIk5YlJcdWR51iYHQR7Qi+9l6M+cn4o9WCQqLq8oXj1CbNNR6rXqhwzFQdlXApff90a8M14WkL4UQ0QbttU9iAe3zJhs8Io2cKD/A== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(396003)(451199015)(46966006)(40470700004)(36840700001)(36860700001)(70206006)(70586007)(40480700001)(8676002)(4326008)(6666004)(81166007)(966005)(478600001)(82740400003)(356005)(16526019)(110136005)(86362001)(2906002)(26005)(336012)(186003)(83380400001)(7696005)(54906003)(426003)(5660300002)(47076005)(36756003)(8936002)(1076003)(41300700001)(2616005)(316002)(40460700003)(82310400005)(44832011)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 16:42:26.6167 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f10bae81-92c5-4a13-9bdd-08dad93b3097 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT015.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6276 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On desktop APUs amdgpu doesn't create a native backlight device as no eDP panels are found. However if the BIOS has reported backlight control methods in the ACPI tables then an acpi_video0 backlight device will be made 8 seconds after boot. This has manifested in a power slider on a number of desktop APUs ranging from Ryzen 5000 through Ryzen 7000 on various motherboard manufacturers. To avoid this, report to the acpi video detection that the system does not have any panel connected in the native driver. Link: https://bugzilla.redhat.com/show_bug.cgi?id=1783786 Reported-by: Hans de Goede Signed-off-by: Mario Limonciello Reviewed-by: Hans de Goede Reviewed-by: Harry Wentland --- v2->v3: * Add Hans' R-b v1->v2: * No changes --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 512c32327eb1..b73f61ac5dd5 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -4371,6 +4371,10 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) amdgpu_set_panel_orientation(&aconnector->base); } + /* If we didn't find a panel, notify the acpi video detection */ + if (dm->adev->flags & AMD_IS_APU && dm->num_of_edps == 0) + acpi_video_report_nolcd(); + /* Software is initialized. Now we can register interrupt handlers. */ switch (adev->asic_type) { #if defined(CONFIG_DRM_AMD_DC_SI) From patchwork Thu Dec 8 16:42:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 632916 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F397C4332F for ; Thu, 8 Dec 2022 16:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229844AbiLHQmq (ORCPT ); Thu, 8 Dec 2022 11:42:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbiLHQmp (ORCPT ); Thu, 8 Dec 2022 11:42:45 -0500 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2082.outbound.protection.outlook.com [40.107.223.82]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF90B13DE7 for ; Thu, 8 Dec 2022 08:42:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k4hgNUcsKulIWBa7Y5WAa5xFuLPMwKqJvCVr5O7oppuHjfZ4NC8dwL+HLZKnK+7n95VcBCuzciD8lQaAJFtQIOd/HA+laRS5Bt0sc9p5X6jqpNTcGPX9DZmNEoFcq02vaVi+8GIm25HDf3X2iu++DX9T9bomq1rcPlOs95rzH52V5SICNu5X4xYpmCsx1E0OgTjbwp2KVL8MZmnOxFO9v01F0K8KILdQhOG9weZY0yaw0vkxbg0sE1W1bT7k2wcg6MvrWyE4UHeu82xgnYgN5So5xTK8ShEkkzeb8C6VZd8iWszAJEoT6jLNT7lQIgoxBuFQrKQYhOa1LNSN9PdOpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S55bNDPeGdOCZxbCyAmWx1sJTYmGm/iCBQwhMSyqvHw=; b=ocLeZVBNY+Tfp6lYHamlnT/ub7UBndQ89eg76JIat+KaucADXeT6loXXzIIl7T4bXS0bVfYLI+NWaQ1nHbW18CioTCB9tiqsMd7/0pTJ8mmARb7AbuZ3BBDgA8vyULHSJo/omWGAdnGbwtUzBzhFIPoTQDoMItNLZOAgiyqWX6aIhsaWONPaB9BqANw23nB3cGvh9uN0JeTHUC6hqd6ZpuM8G5Jiqj9vhJUQfm4oBICdll0abjbPpLKsP/uCRYX0ZSiNqVRSu0QxPXIJrxgioIOexgrOLG3oQXV5FTbQwGzDjlS1wC4B54jtOF+7BoiwOgCY46aY5e51Pk1DO/8iSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S55bNDPeGdOCZxbCyAmWx1sJTYmGm/iCBQwhMSyqvHw=; b=WEcoYm8gX6b+BvaQ/Ldkd3H22evruXLyU2pCi3rqVYbPFlpAEcHr74S06iJx/kRbAVx1ac4Weo0LIQkX99xR/m5Idy5xIwRsfj3hz9GPYMHGoOh6gGVaGR93K/C70xDBK9Iyazp6oWgG5YLTjxMtkO4BwtLV0z1fohzp79CUQCA= Received: from MW4PR04CA0371.namprd04.prod.outlook.com (2603:10b6:303:81::16) by DS7PR12MB6117.namprd12.prod.outlook.com (2603:10b6:8:9b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Thu, 8 Dec 2022 16:42:41 +0000 Received: from CO1NAM11FT015.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::66) by MW4PR04CA0371.outlook.office365.com (2603:10b6:303:81::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.16 via Frontend Transport; Thu, 8 Dec 2022 16:42:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT015.mail.protection.outlook.com (10.13.175.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5901.17 via Frontend Transport; Thu, 8 Dec 2022 16:42:27 +0000 Received: from AUS-LX-MLIMONCI.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 8 Dec 2022 10:42:25 -0600 From: Mario Limonciello To: "Rafael J . Wysocki" , Alexander Deucher , Hans de Goede CC: , , "Daniel Dadap" , Mario Limonciello Subject: [PATCH v3 3/3] ACPI: video: Don't enable fallback path for creating ACPI backlight by default Date: Thu, 8 Dec 2022 10:42:07 -0600 Message-ID: <20221208164207.13518-4-mario.limonciello@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221208164207.13518-1-mario.limonciello@amd.com> References: <20221208164207.13518-1-mario.limonciello@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT015:EE_|DS7PR12MB6117:EE_ X-MS-Office365-Filtering-Correlation-Id: 8add979e-4e68-4607-683f-08dad93b38e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AqVDjJuA6ukuTDK5B49eF2LAQYwpne7RHEzZqKoKT86SXKn4QzyByxhc7hceK7E49L7G/cZ+vciqBCrE8XR8mqBPwgS+OnMhW2bxflpow09CDwYiCZsOw3ekoDe3UED5fAQzly7gDZHJiOvaANIpScfgQgL8e0a7RBGgXlD2uxCpQuYa5lCEFBH3PJbgX3M6CdASrU68vbctY1xZmYlYLsQX+9TfzsQU6EipLbQw4YnZm3TKVJSNquJTZm5gHQzUdXdx9m+VvVHU3z4sm5jWD9NdaP0T4Cp0HBDPx3Nr0j6oN3fTei/2iktBvgaMMFzcWUDe9ICGIJflnJzxfDhEcgzEX2/uktGW+8+EnBqi3NRmfGmGZhUCrKutXSWwxs2nBYW674mRXgxDzGcztoTWAre3yphIzZuqe1u74GW3JpehliHbnmaOmyJtkLqJtEY/bcSJiz/0UHFbyulrOFFENuF0gD5pgSufKhNDnh1BB/rnWCWsyPIN4tfl2xrmbKZ9/spaKJbx0n3ahnYh3k4NxjlCRVRHXPo9ldSNeHIfQa/6Cleq/rs8r7byYt7chhBhXeUNqBDPGwG9FFZlceocD7on2yaMOeZqG2/zY9R9D9Z9Fo8DjI59kerAFaI/R4Js1h33l6Z9//q8IrXk0tl4JbcunwkiMcRworz5VTl61g+A9QAPkRwjYhoz8da7e5FVcBuobLOolUNDtNyjV8c6XMWraDlL/ekE6hOO8F7YoJU= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(2906002)(40480700001)(426003)(5660300002)(41300700001)(36756003)(83380400001)(8936002)(82740400003)(86362001)(110136005)(2616005)(70586007)(70206006)(44832011)(54906003)(316002)(8676002)(4326008)(16526019)(82310400005)(47076005)(478600001)(7696005)(26005)(6666004)(336012)(1076003)(36860700001)(356005)(186003)(81166007)(40460700003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 16:42:27.1792 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8add979e-4e68-4607-683f-08dad93b38e1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT015.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6117 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org The ACPI video detection code has a module parameter `register_backlight_delay` which is currently configured to 8 seconds. This means that if after 8 seconds of booting no native driver has created a backlight device then the code will attempt to make an ACPI video backlight device. This was intended as a safety mechanism with the backlight overhaul that occurred in kernel 6.1, but as it doesn't appear necesssary set it to be disabled by default. Suggested-by: Hans de Goede Signed-off-by: Mario Limonciello Reviewed-by: Hans de Goede --- v2->v3: * Add Hans' R-b v1->v2: * New patch --- drivers/acpi/acpi_video.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index f64fdb029090..0c79f463fbfd 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -70,11 +70,7 @@ module_param(device_id_scheme, bool, 0444); static int only_lcd = -1; module_param(only_lcd, int, 0444); -/* - * Display probing is known to take up to 5 seconds, so delay the fallback - * backlight registration by 5 seconds + 3 seconds for some extra margin. - */ -static int register_backlight_delay = 8; +static int register_backlight_delay; module_param(register_backlight_delay, int, 0444); MODULE_PARM_DESC(register_backlight_delay, "Delay in seconds before doing fallback (non GPU driver triggered) "