From patchwork Fri Mar 29 15:33:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 161460 Delivered-To: patch@linaro.org Received: by 2002:ac9:18c7:0:0:0:0:0 with SMTP id i7csp2080574oce; Fri, 29 Mar 2019 08:33:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzprF6z6IaQhszug12S9PR9Swuo57dw5ANgfoJ+f5tK/WNMI4obUu/qJuv/c9KP3VOITExT X-Received: by 2002:a17:902:3381:: with SMTP id b1mr39959283plc.5.1553873621550; Fri, 29 Mar 2019 08:33:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553873621; cv=none; d=google.com; s=arc-20160816; b=Cvj9aiR7H1FYPhA9a9siSJrZKwDvQ5y+4tuBfRGuMv/CeZdfPLILeKOe1qT55P8m/X 5qPuqTjpowN5RqlyLGaFd3xgRj9bIoshm/IXcN57BGNIa0RjQNEsUPaXicHqMU1gdmqd f1jm7arQHzE5BJ/oQFPsNpjBU5XkIXVE2MsvFNeqKmplmZHwnBBieY8RILY7nZ+2paLV MRdA4MS79va9Xn2FoxQ2B7F1/apiSKFBypEr7AAU5lqDoh7jAMRDorBEWlkr4vaGznkx 5Y5zwV/iZLF+2N34+5hwZ+Y7LKjBhIN9GZGHklliSFgwFST8c5YXYjKA3pNLL9+RfkJ8 Kg/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GPit8v+Q7DtocOZEXU4jiFZqiXXyIE54mF68t3axNAg=; b=gzC7S7ZWOHQAfyqGUwTxDe6mP5eukRCclrEVKJbesYApHy6GvFY1GqNdj4tg0DOOK1 fvETp3ZH9pPeXZ0G52C3yVpJCIjtpfonIHQlh9jWj3yFuTWKIHynnzuHxOaoFcB1XsaE CZ9bHg4AtHYNAJ/mw9rVY9HP6pQBhMcTyN9/xCjdMadFkZ/3ZAA3cr9k9wfFQFcXFQYe NZNfzITGiJNJyo1iYE5tPsBQ7WySFKImmt46NGF6/uZcXjY5GmgiAUor7ewnqbFGIPpT 6DgJUQyXqoHEbu8jtGDdhIy4AghMB89j/g925YSwevyNyeSvyaKJgfRHV1qCANEzlUPm cdNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=JFlOjZCu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n22si2099901pgk.102.2019.03.29.08.33.41; Fri, 29 Mar 2019 08:33:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=JFlOjZCu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728945AbfC2Pdj (ORCPT + 31 others); Fri, 29 Mar 2019 11:33:39 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:43237 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729654AbfC2Pdg (ORCPT ); Fri, 29 Mar 2019 11:33:36 -0400 Received: by mail-wr1-f67.google.com with SMTP id k17so3088975wrx.10 for ; Fri, 29 Mar 2019 08:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GPit8v+Q7DtocOZEXU4jiFZqiXXyIE54mF68t3axNAg=; b=JFlOjZCuBF4USFLbmGUtrAoPYawoUOO5wzWamoY/Tyuudb+4Gu2K4bS484QHyG0il3 GOq9ccl7t08dBEtKgSNnmy554RdlGvJs9vcKT20n7kZq2+WSD4fjeic11WWGQudS2z+9 L5jhk/mBV3ZShqtJnnDPv+b8OcPLQ0G9GXNXSffdzMc+AWP3KjrQkJlnFormY9M74haX ijyHZ5Pab+pbsIfSSR7/1q0WElWoAPw4ob70hS2m3xPFQkSZb8bIkbgrUXPnicKQE0ss gmT/YLwB7QlBtEe9HfXfZF1mv7UUt+4FjMoYv7KcugC+hW6TEZ/VDjtU/WSlEdnPIm1E 8FIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GPit8v+Q7DtocOZEXU4jiFZqiXXyIE54mF68t3axNAg=; b=lG5V6utYQEU87XYPEnknXC2zYi3JJlWp8r7vAu8nUv2ySwaV8HpakfPnqaaKkmlsuc G9oKPIClrU7v6FyDCZy4jGXtO5+CRaYxTijlnhITB5xIgdoj0IW2vYzHxUzDDlTe23oU nIVfWCHKfFN78CFSqQUYyQ1FrkWvprJJAAAjhtGlxwuL4k2Lq2GNqIKTReN6x64lTxTk i2MHojD7llJrqCtlBEm0XPHJaXWi70eFZZvzDNwn4081m7BPBSj28TemvYMhFczNJ5LG V+DT7uyT3lszgCNJua6uVFc9bxM1HdVKNISaCyP2qKst6yAC25AlnmYFz6B9wdNPdxkx Cj6w== X-Gm-Message-State: APjAAAU6dNFdulnNG08ql8vlT7OhBT/aDXNrFQLLzY7IY/+IvaRK0/EQ EiKX/3TPQTCIyAZErmQTeEUD8w== X-Received: by 2002:adf:db10:: with SMTP id s16mr23886951wri.181.1553873614583; Fri, 29 Mar 2019 08:33:34 -0700 (PDT) Received: from boomer.local ([2a01:e34:eeb6:4690:106b:bae3:31ed:7561]) by smtp.googlemail.com with ESMTPSA id s18sm1930173wmc.41.2019.03.29.08.33.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 08:33:34 -0700 (PDT) From: Jerome Brunet To: Neil Armstrong Cc: Jerome Brunet , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] clk: meson: mpll: properly handle spread spectrum Date: Fri, 29 Mar 2019 16:33:23 +0100 Message-Id: <20190329153325.23869-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329153325.23869-1-jbrunet@baylibre.com> References: <20190329153325.23869-1-jbrunet@baylibre.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The bit 'SSEN' available on some MPLL DSS outputs is not related to the fractional part of the divider but to the function called 'Spread Spectrum'. This function might be used to solve EM issues by adding a jitter on clock signal. This widens the signal spectrum and weakens the peaks in it. While spread spectrum might be useful for some application, it is problematic for others, such as audio. This patch introduce a new flag to the MPLL driver to enable (or not) the spread spectrum function. Fixes: 1f737ffa13ef ("clk: meson: mpll: fix mpll0 fractional part ignored") Signed-off-by: Jerome Brunet --- drivers/clk/meson/clk-mpll.c | 9 ++++++--- drivers/clk/meson/clk-mpll.h | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) -- 2.20.1 Tested-by: Martin Blumenstingl diff --git a/drivers/clk/meson/clk-mpll.c b/drivers/clk/meson/clk-mpll.c index 64d31c8ba3d0..2d39a8bc367c 100644 --- a/drivers/clk/meson/clk-mpll.c +++ b/drivers/clk/meson/clk-mpll.c @@ -141,9 +141,12 @@ static void mpll_init(struct clk_hw *hw) /* Enable the fractional part */ meson_parm_write(clk->map, &mpll->sdm_en, 1); - /* Set additional fractional part enable if required */ - if (MESON_PARM_APPLICABLE(&mpll->ssen)) - meson_parm_write(clk->map, &mpll->ssen, 1); + /* Set spread spectrum if possible */ + if (MESON_PARM_APPLICABLE(&mpll->ssen)) { + unsigned int ss = + mpll->flags & CLK_MESON_MPLL_SPREAD_SPECTRUM ? 1 : 0; + meson_parm_write(clk->map, &mpll->ssen, ss); + } /* Set the magic misc bit if required */ if (MESON_PARM_APPLICABLE(&mpll->misc)) diff --git a/drivers/clk/meson/clk-mpll.h b/drivers/clk/meson/clk-mpll.h index 2925fb939fdd..a991d568c43a 100644 --- a/drivers/clk/meson/clk-mpll.h +++ b/drivers/clk/meson/clk-mpll.h @@ -25,6 +25,7 @@ struct meson_clk_mpll_data { }; #define CLK_MESON_MPLL_ROUND_CLOSEST BIT(0) +#define CLK_MESON_MPLL_SPREAD_SPECTRUM BIT(1) extern const struct clk_ops meson_clk_mpll_ro_ops; extern const struct clk_ops meson_clk_mpll_ops; From patchwork Fri Mar 29 15:33:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 161461 Delivered-To: patch@linaro.org Received: by 2002:ac9:18c7:0:0:0:0:0 with SMTP id i7csp2080625oce; Fri, 29 Mar 2019 08:33:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqzOzzSouoQqpKjOv985dv+ReuKqPytKOQGeMERLKcLrYgemZJ2HPGmhcNQsDq8Y3kkRfIfQ X-Received: by 2002:aa7:85d9:: with SMTP id z25mr37422214pfn.31.1553873624226; Fri, 29 Mar 2019 08:33:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553873624; cv=none; d=google.com; s=arc-20160816; b=kLaQoMoruoAzQfLU+CKHq9Asl9Z+cPcgDoNGx0Jmi9Hg5I1o5ldr5DMJRN8gUt5T1o ii2jDT1ruSeniMjCV66TLzUI0MJ0njOlqmaz3CgmykEhXP4hRfaX9zk0FHXvYqp1rqF2 AGR+dcPYV9nr0FGVXyJyz78QZtVWWbraKJNS5Owyz42yyCBKLIDslUljgh/sn4xOfOu5 QwUM1q00HYU6z/z+ccB4kM5BfP88067OoRP/nurVLcICKksVlXyaBE2e9+YUFLjd4uaE UqxbKG4W7eZbwYuAm0y3QvIboUHsoCC8mSU/l1OF65gLPyZ+2yUeiTSLVfXFd8QlqrKZ IM5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FWfQp5+ZZrqhqHBdYBd1fS5YgiYNyIDWJS2WXanIlaU=; b=zVQmGML8sCl4MIn5i9oBu8lywwLaQbC+xDlIQeAIjT19Mgyy87yJlUoySzg1dyg9z/ ZXMNKw1c55tGlgsPhh1ZTyB56sf7/Avm0THSuIeZGpf/Pm6E7aDbq50KHMZVupt0XceZ 8SvpQQkIna3bfdWd305xmJTlBrx9Xk/XmyESEodzu7jRK0i8r3wuW8x3S9Dzo2wtjRNc lGQAtvqi3kZyDIylbe2U4EV2IuWl5kCXZa4B1vyV5B9cVZ3tUXOQpD+jJ1RWaPmcknln IhtRMh1S/dDs8/iUaafqZpY8sGiL46eatRfxH0MX/2PG9elhBYebrYEjUCCxtSYfRDvf AXSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=pYS1Spzw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n22si2099901pgk.102.2019.03.29.08.33.43; Fri, 29 Mar 2019 08:33:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=pYS1Spzw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729716AbfC2Pdm (ORCPT + 31 others); Fri, 29 Mar 2019 11:33:42 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:33667 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729480AbfC2Pdi (ORCPT ); Fri, 29 Mar 2019 11:33:38 -0400 Received: by mail-wm1-f66.google.com with SMTP id z6so9973901wmi.0 for ; Fri, 29 Mar 2019 08:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FWfQp5+ZZrqhqHBdYBd1fS5YgiYNyIDWJS2WXanIlaU=; b=pYS1SpzwcqPn03mG5ybxNzW305QTPzPCQZN263IXlWMguaxWwsEMBYjnXbcCHLgUwE fPH+js9vlzVc2+Eu+zV/J/qRA2bEk7q7ZGQdJK7o556F7K76c5LkxkgpOASIB0NUdQbo mwNZ4bd+82iSvruITeR0gIhLo/Zg5LWPo2ZSFNTOCXeyqJs6mAPBtKgR7D/WxPExfndZ YmhxNF4OX1zYm07GCzwBHvtIslQSb2pZ1GZzwoXlBmtQX+p2/oDSS/8+KhAmDjqy7zcV O4U85x6VYdjnzcXit5A3CNCMdKSTa4OyR1sqhu0DdOejiZISh2hua7PuBgqjTwmwbVY5 PENg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FWfQp5+ZZrqhqHBdYBd1fS5YgiYNyIDWJS2WXanIlaU=; b=KWxmCL3yuOiOpausecs0tDuM0vb/n/XPsD4QhTcUudh+Zv62kAILXYa/J6NNlMftTw jgxf1ZV/zyCFTlbN/xFHYss7saawUKuHVJuBPiYvm5+I5JWqleCnR6B/CouoZKBQfGGu GcTz2uvjB07lTTXTcbQTelHolanSS1cSyM6whz3WZd+69gxB+6LL+YMFmDvjcZuaz1tf +vo3fx5jYHUzc0pYJArkMz3i4qVxgL/EtAL29SVrw2BMzRQsRLSmzPb09Bs21DCJKODV SeBid64CXMMpUhW/S9n+YESCtQbrp55j/g7sW/MTS3xGbiZJn4VGSt0pSPgdNPXGsTsK Oh8g== X-Gm-Message-State: APjAAAXl8m80FMGpN66tiK+st4jirjwbz3F9sz4WABU1FVIN1uPCunDI S45oraiT1ILd4anLyrpyQKW0sw== X-Received: by 2002:a1c:e70b:: with SMTP id e11mr3828070wmh.17.1553873615975; Fri, 29 Mar 2019 08:33:35 -0700 (PDT) Received: from boomer.local ([2a01:e34:eeb6:4690:106b:bae3:31ed:7561]) by smtp.googlemail.com with ESMTPSA id s18sm1930173wmc.41.2019.03.29.08.33.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 08:33:35 -0700 (PDT) From: Jerome Brunet To: Neil Armstrong Cc: Jerome Brunet , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] clk: meson: gxbb: no spread spectrum on mpll0 Date: Fri, 29 Mar 2019 16:33:24 +0100 Message-Id: <20190329153325.23869-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329153325.23869-1-jbrunet@baylibre.com> References: <20190329153325.23869-1-jbrunet@baylibre.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The documentation says there is an SSEN bit on mpll0 but, after testing it, no spread spectrum function appears to be enabled by this bit on any of the MPLLs. Let's remove it until we know more Fixes: 1f737ffa13ef ("clk: meson: mpll: fix mpll0 fractional part ignored") Signed-off-by: Jerome Brunet --- drivers/clk/meson/gxbb.c | 5 ----- 1 file changed, 5 deletions(-) -- 2.20.1 diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index 04df2e208ed6..17d4e85bde65 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -679,11 +679,6 @@ static struct clk_regmap gxbb_mpll0_div = { .shift = 16, .width = 9, }, - .ssen = { - .reg_off = HHI_MPLL_CNTL, - .shift = 25, - .width = 1, - }, .lock = &meson_clk_lock, }, .hw.init = &(struct clk_init_data){ From patchwork Fri Mar 29 15:33:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 161462 Delivered-To: patch@linaro.org Received: by 2002:ac9:18c7:0:0:0:0:0 with SMTP id i7csp2080723oce; Fri, 29 Mar 2019 08:33:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLp9uJurTWYXGjma1lATd2RwJvaVKIJKF5kB0cqaRa4Kyd0nKJ3INpsdZIkyX8W3AVsTH9 X-Received: by 2002:a17:902:e709:: with SMTP id co9mr26337953plb.86.1553873630303; Fri, 29 Mar 2019 08:33:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553873630; cv=none; d=google.com; s=arc-20160816; b=tKBJS3N+Bha7xEapF7uWc0Guhflk4bgfTaI05JZeKL0QHbh/M758ySab0juFRJl1wi /zhMTTyfh9Ik450cGEsb0h9HaodjV4biGCHEtbA/DfNVK90XydF2p0Tn2u9kf7yDM+iN 4RQJVOAadkEve+2vpJDgRHzNvHQRX6yqEjbTEorjFsydNEt5tODaSoRDlfNSBBtw5I9R 7tmDUCeFRdYHcn9ve2jYSCnunaHKBJlEbeUA8cyBvu+EmKvG36RKnWYVYrc1mVbZQIId WhUTXbJJ5N/3Rqz+x5rHZGvE/XqvpVfSKDgGVBapcmz956VB/dCHZUg/JrF3Kx69MzVf Dkyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=StsbiAbV0Vt+lXEMy/BJGmoZrMBaAxbvBsCBZl1IPto=; b=V3HyoNo7TkduSZBfftXzhGXkb6QPW4WCmg0tNJP4JyHwp7J29H5GTu+OElEYj8lYFK gamnYgLxvAtyC52yWuRInVNJflj8XWu3J6HIfCvslTy52xVnExtEhWeI/VLWDVXioh6D t8ppsVCZfQsw+JLlRSAY+V5OhF97q4Ppu4Zjhlz4qt9Vj7HejV3aVekHGvqWLax4P/fI OLDKIo8zdYXqmQSycnwAxSq8ueU+JtZva0OGqbmqoedKfPfGaNOSbetSPT9SmYZyziv7 oZjOjcvLctUSRAVMkKGoc+hMPwRXQZetafJbCYhjv9Ff+GHAHgUHOwf5owBbQYlQl7Iq fzhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=cFyX65t+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e22si1999198pgv.323.2019.03.29.08.33.49; Fri, 29 Mar 2019 08:33:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=cFyX65t+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729730AbfC2Pds (ORCPT + 31 others); Fri, 29 Mar 2019 11:33:48 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:53614 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729682AbfC2Pdi (ORCPT ); Fri, 29 Mar 2019 11:33:38 -0400 Received: by mail-wm1-f65.google.com with SMTP id q16so2955253wmj.3 for ; Fri, 29 Mar 2019 08:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=StsbiAbV0Vt+lXEMy/BJGmoZrMBaAxbvBsCBZl1IPto=; b=cFyX65t+guMxH0r6wwSuBGb7zt9F3l3OAKQIUEhzCLXzE9CP1DjsgeoNuVQfOmgQ9y 3E/6EPaEtzmqGcEH9hfmtSE7ExYLYk9jyUkcSonbTaAG0Q3Qg/SKCR6whaIsLf2y0pe0 p1TmqbeqhCmxnkBkINo/3nH2dQ8k+Hay49Ayh6DwhFa+fwuJtSUi7FP3LxePzFlJpRJp zN3NkuPjWOXkDWZzcO9QaOPs+4MMfYbXS428Oj+P3uT/N7oHtV/j215UkGowhHb6JFyn kgS4PwzsxbTByarKfja5OCK9EBCgaGjwGaRlp7Ex0fp55rpLgW+SU7NIFFj/Gr/Cx+ix CoMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=StsbiAbV0Vt+lXEMy/BJGmoZrMBaAxbvBsCBZl1IPto=; b=frcY3BmRWZrTti/qAC9tZSMnCaPAyia+urhfES47AGtHyRN9s/4BVoy4v/17EpIA2K DCk+qRzY5sLOGG1Gviprk1XicsHG2qpn08LFKSi9L2xdoQ5aCo+pQ+QKoXXy6245GOJt +SXoh2I3wx1GVGOlfEcJ1AoI2DpemmnENSEbv+5ZI+x7QpGX3uHOjj99ghZUa9P9Lg5z HrC9WZd8bkxkCEp+0BW+aeRo6gAn8BdqVoFdc1IfEWS9622XwSln54y2PubIQa7VmrCV 0P6weQE2jClQhvLzIbeeMNFWrBgYWxhrJ+uKphLcuFVLnWwsU/7/fhhWVvYSEjNt0N75 2WqA== X-Gm-Message-State: APjAAAWXdPjmGkC8oEd58yxTnSI0t6YTRR1u53lbsmMNN1LNj9t3AoFb uDMWmuOgPzIQ8KGPVF8dZc0Qpw== X-Received: by 2002:a1c:2d91:: with SMTP id t139mr4275362wmt.102.1553873617383; Fri, 29 Mar 2019 08:33:37 -0700 (PDT) Received: from boomer.local ([2a01:e34:eeb6:4690:106b:bae3:31ed:7561]) by smtp.googlemail.com with ESMTPSA id s18sm1930173wmc.41.2019.03.29.08.33.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 08:33:36 -0700 (PDT) From: Jerome Brunet To: Neil Armstrong Cc: Jerome Brunet , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] clk: meson: axg: spread spectrum is on mpll2 Date: Fri, 29 Mar 2019 16:33:25 +0100 Message-Id: <20190329153325.23869-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329153325.23869-1-jbrunet@baylibre.com> References: <20190329153325.23869-1-jbrunet@baylibre.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After testing, it appears that the SSEN bit controls the spread spectrum function on MPLL2, not MPLL0. Fixes: 78b4af312f91 ("clk: meson-axg: add clock controller drivers") Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.20.1 diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 7a8ef80e5f2c..3ddd0efc9ee0 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -469,11 +469,6 @@ static struct clk_regmap axg_mpll0_div = { .shift = 16, .width = 9, }, - .ssen = { - .reg_off = HHI_MPLL_CNTL, - .shift = 25, - .width = 1, - }, .misc = { .reg_off = HHI_PLL_TOP_MISC, .shift = 0, @@ -568,6 +563,11 @@ static struct clk_regmap axg_mpll2_div = { .shift = 16, .width = 9, }, + .ssen = { + .reg_off = HHI_MPLL_CNTL, + .shift = 25, + .width = 1, + }, .misc = { .reg_off = HHI_PLL_TOP_MISC, .shift = 2,