From patchwork Tue Jan 10 15:41:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 641219 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BDAC54EBC for ; Tue, 10 Jan 2023 15:41:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232997AbjAJPlv (ORCPT ); Tue, 10 Jan 2023 10:41:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234191AbjAJPlr (ORCPT ); Tue, 10 Jan 2023 10:41:47 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22B611AD98 for ; Tue, 10 Jan 2023 07:41:46 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id fy8so29632798ejc.13 for ; Tue, 10 Jan 2023 07:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=/S0PGqXFKksi2Doprlka03QKocY/2FcAHAXJYc0T+BY=; b=KoClTt+kW9zIoNJn7Lu1nRrEfD48GXN8zndPM/j0Of2YP6fHnUbPghnsmvk/ngVAF3 7w8eA3iQnFm675p52QwBp7GKHnmQQduP6EfwOtpPyWklnKY0qsMUqp2eQGQaZeCKsiD8 lXXUyPko1PzrZ6Bh7wMzG5KvPuEXTuHPyV5XrTv0dAqsE4WneYJX4dlxdYqOO3lbD1H8 sw1eV4jGbc+lfN57zJ/fqNaJH476h3bf0+1vml3XjpCK4ojhCeY137EsYvGGgDL4/suN aChkw61fDnfS49YCxI0JTegzR4nD/NRqiOohaPqCYVLTamSKmSRwmWvDFriLMOafzAv9 fEpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/S0PGqXFKksi2Doprlka03QKocY/2FcAHAXJYc0T+BY=; b=um1vrHl+q7iuWDtzqEqXzt1+yi/LY617j9gQGx4FZ4qOd0CzKRsrUUAt2A/zatHLrw YJwComQKQX00epmtF1AEv2kiR7Aub4g29wyYMHqr+rLjMWShGTi6SOwFShblf5WzGHHX GVVo5L47Up2wbb4icE1nNwvDVxqStVZvukNj2vl/WVIbWALb49VLas3kp8IK11/2VFjQ lsl5TtqUmg18NJejRR8hkkJdSiqfGFkrgIiIgKI/daWTCKqVLQZMeyzuwO3M3EJwPu3t dH27GckzjL7SjaTW95EaDIqAXf4+Oo7+URgNYJNmlrqXQz2qnNIjXfLqy0JIgqyRq3dl rmLg== X-Gm-Message-State: AFqh2kq+PZUylbVZGLeS9nMok8CX6rbJC/AwSJqnrWDRZdySXfh7i3s4 85Ke4Ma+u0hhk07UFAwMHd/7qna/KK4= X-Google-Smtp-Source: AMrXdXs7mREFT2yskvQp9Y2cbzAIXIKgMvODjgY8wUx3CmAfyhdFFF9FSnwSVuGpNCj2Ia3NhlC6fA== X-Received: by 2002:a17:906:524b:b0:7c1:5098:907f with SMTP id y11-20020a170906524b00b007c15098907fmr58425586ejm.61.1673365304588; Tue, 10 Jan 2023 07:41:44 -0800 (PST) Received: from [192.168.1.50] ([79.119.240.114]) by smtp.gmail.com with ESMTPSA id s10-20020a17090699ca00b0084d43100f19sm3095916ejn.89.2023.01.10.07.41.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 07:41:44 -0800 (PST) Message-ID: Date: Tue, 10 Jan 2023 17:41:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Content-Language: en-US To: "linux-wireless@vger.kernel.org" Cc: Jes Sorensen , Ping-Ke Shih From: Bitterblue Smith Subject: [PATCH 1/2] wifi: rtl8xxxu: Print the ROM version too Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Make rtl8xxxu_print_chipinfo() print the ROM version. This is relevant at least for the RTL8723AU and possibly relevant for the RTL8710BU. Signed-off-by: Bitterblue Smith Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index fd97c040948a..d521435e1c07 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -1582,10 +1582,11 @@ static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_priv *priv) cut = 'A' + priv->chip_cut; dev_info(dev, - "RTL%s rev %c (%s) %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n", - priv->chip_name, cut, priv->chip_vendor, priv->tx_paths, - priv->rx_paths, priv->ep_tx_count, priv->has_wifi, - priv->has_bluetooth, priv->has_gps, priv->hi_pa); + "RTL%s rev %c (%s) romver %d, %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n", + priv->chip_name, cut, priv->chip_vendor, priv->rom_rev, + priv->tx_paths, priv->rx_paths, priv->ep_tx_count, + priv->has_wifi, priv->has_bluetooth, priv->has_gps, + priv->hi_pa); dev_info(dev, "RTL%s MAC: %pM\n", priv->chip_name, priv->mac_addr); } From patchwork Tue Jan 10 15:42:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bitterblue Smith X-Patchwork-Id: 641642 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C55C46467 for ; Tue, 10 Jan 2023 15:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238249AbjAJPmp (ORCPT ); Tue, 10 Jan 2023 10:42:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233939AbjAJPmo (ORCPT ); Tue, 10 Jan 2023 10:42:44 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6974E3FC91 for ; Tue, 10 Jan 2023 07:42:42 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id u9so29802933ejo.0 for ; Tue, 10 Jan 2023 07:42:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fvskllAMxjpoYxy8x91Ay3wHk+edHsNAvSmQ+G4D/28=; b=M2e2m0o/SO/SkR3TdYczdGi2OcFE75a0cGVpRPpAa2m46IVI7Qm+RJMd40tKr9NkOv aDgbggUcO6WLqPeAzzFJyxJOj0rH6TShM3P6kuX7JDoJdvhJS+ArBylpnTcKQxZDU4Ew nyJ2oB3P2G696Q+OSNAu1iJ3/uPgZnKBejr6LOnzf3FE8xlolX5Z9EsA9vcXRDU6JZpd Yd52sjZ7FQ+a4RcGuJu3+Va5w4ryQav7io9PU+z+oskKPlO9uwO7kCTTmAd4FwfGnQxV oeTHSVVPOXvHO4P7Zi5T1DUsnPp2KYb7e0iiLqL8AnudNV81dvocETbhECDRFu+fCegz bWOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fvskllAMxjpoYxy8x91Ay3wHk+edHsNAvSmQ+G4D/28=; b=JCNMfUqAfbzU/nhpfMrW9j9bEzRATuGLWdqycDNFPqWa4Kgqr+dn//71wyyIN5kkdY Pb7uj+I1x56QmKqQ4XDbPxZHpEf5UygNaUsA8S5/zeWnbLKmOpGGAD2KEktUBcFe4soM TuxLW7RCCsvTt5415NTS1pzfiqP+TZqPrutky9Qz9XIGV0nlx4x1UakEjsr2UjDa84zv aO94DSu+DPNyF7Kp5JiIrGQD69InaUca1GvNa0B/UbcpYQj3InXU44XxrK9fCct0evqC wAw7VA53GOoDqF17mH4S0wpRvZTJo6VqeNlgkrKxLG5fm4FmXZk9/ee/cHDpRImxYcfa D7nQ== X-Gm-Message-State: AFqh2krA4WKakqXEQCvZj0j9Cei5HQwViqahYYMMcIFffBjkt7SUi7RT UK4E1mbSVa8X/dZwKaJ/n+HUxZjhBfU= X-Google-Smtp-Source: AMrXdXt+aaSr6VwSZxQEJnkNjMobBX+aSAP9U/9qLFQ/g0DsUuI8SYYf5/qh5ZaABEQlfAGpD0d/Sw== X-Received: by 2002:a17:906:d205:b0:7c1:51ee:a2ec with SMTP id w5-20020a170906d20500b007c151eea2ecmr58517152ejz.46.1673365361039; Tue, 10 Jan 2023 07:42:41 -0800 (PST) Received: from [192.168.1.50] ([79.119.240.114]) by smtp.gmail.com with ESMTPSA id v10-20020a170906292a00b00782fbb7f5f7sm5114950ejd.113.2023.01.10.07.42.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 07:42:40 -0800 (PST) Message-ID: Date: Tue, 10 Jan 2023 17:42:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: [PATCH 2/2] wifi: rtl8xxxu: Dump the efuse only for untested devices Content-Language: en-US From: Bitterblue Smith To: "linux-wireless@vger.kernel.org" Cc: Jes Sorensen , Ping-Ke Shih References: In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org It appears this was the intention all along, but commit 3307d84024d2 ("rtl8xxxu: Add initial code to parse rtl8192eu efuse") initialised rtl8xxxu_debug with RTL8XXXU_DEBUG_EFUSE for no apparent reason, which made it dump the efuse for all devices, even the tested ones. Signed-off-by: Bitterblue Smith Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index d521435e1c07..07c3af5d0374 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -34,7 +34,7 @@ #define DRIVER_NAME "rtl8xxxu" -int rtl8xxxu_debug = RTL8XXXU_DEBUG_EFUSE; +int rtl8xxxu_debug; static bool rtl8xxxu_ht40_2g; static bool rtl8xxxu_dma_aggregation; static int rtl8xxxu_dma_agg_timeout = -1;