From patchwork Mon Jan 30 07:45:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaewan Kim X-Patchwork-Id: 649152 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFBFC54EAA for ; Mon, 30 Jan 2023 07:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235488AbjA3Hp1 (ORCPT ); Mon, 30 Jan 2023 02:45:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235437AbjA3HpW (ORCPT ); Mon, 30 Jan 2023 02:45:22 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C80142943A for ; Sun, 29 Jan 2023 23:45:20 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id x8-20020a25e008000000b007cb4f1e3e57so7505239ybg.8 for ; Sun, 29 Jan 2023 23:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=NGmk51CCKcAKRhbiqyWogk1UQgGD95j5Rcfy6uBYfbg=; b=UABrQ96CX4rhaVZW6t2QPtsRFEbyGc0Si9JtLTtEVUie+G6WCqaZXOYtWDfpqn54q4 y2fis2FL3p3uo0WWu+GNugV0JAsw2jr7zjgbdFF/jj9C6dD3Le5JI0Mb9vn9kEG0h0Nx jOe3noZGz4eoLG65qj1f53rmxoJZthSJLpslIr58hmK4a4LGalztVMn+z/Sd2bYy019l 1FbKYr4geJVWchuVsx/UZZutXjr5ZlMYE+mRe1dS/a4zu5eVeWoHXlqH6q7BiVAaV9Ok GJBvfVc33XBDnVstTUBaZxOBkyLB7u8/1X8OCCQUM3ems04+yGrNQ9CC+erqkegKN2nV MyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NGmk51CCKcAKRhbiqyWogk1UQgGD95j5Rcfy6uBYfbg=; b=i/PfPGhZ9Lnxst3GcMUbhhnbtFlxrOMLg9HK+iKsTCBohyYxfSBOLjWV0lvMQj0PVh O184PpUtIG51+6uEBTZQZlFgKWvdNsgsJuWywZPgHV2La0W2WmXZDDGtTTUm91Ty5EnB yTOnCUfVdKTlsZtNGs915QtEMVs5Bi4S/2bOI8LqDeNaWb38vRpQnTZi5fvghrzBoH3P QHtDJmqAeclQVXoeJWJiYLQLZBMUsL+EtcQiuQW/nn6SVzwj/5SUGBjScVmjaJwoNSUR Es7RKNiYBEeEX0GYptN/096uAXTI6xrWyGgPYRXrfQiUT9chVjxwGeSXazYQg4Ept71f BFOQ== X-Gm-Message-State: AFqh2kpeOpftbtGu4JRT3yZqBzJg2z/h2dWVoHw0HOLYvo9KeHfF8CNW 8I5BVwclETYWkA75+gkQfTivKLQRUNo= X-Google-Smtp-Source: AMrXdXuh1GYnokliZipsoswZ9/Qq1Dxz+VJKyPNgRLMycJzRNzKbHJM8Vy1N6zKYILiqt3jbsTFytjf8u3E= X-Received: from jaewan1.c.googlers.com ([fda3:e722:ac3:cc00:3:22c1:c0a8:e59]) (user=jaewan job=sendgmr) by 2002:a25:644:0:b0:7c8:3b5:b58d with SMTP id 65-20020a250644000000b007c803b5b58dmr6585606ybg.494.1675064719934; Sun, 29 Jan 2023 23:45:19 -0800 (PST) Date: Mon, 30 Jan 2023 07:45:14 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog Message-ID: <20230130074514.1560021-1-jaewan@google.com> Subject: [PATCH] wifi: nl80211: log for malformed chandef From: Jaewan Kim To: johannes@sipsolutions.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-team@android.com, Jaewan Kim Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This change ensures consistency for returning error in nl80211_parse_chandef() by logging reasons for all EINVAL returns. Signed-off-by: Jaewan Kim --- net/wireless/nl80211.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 33a82ecab9d5..e12b01721bec 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -3181,8 +3181,11 @@ int nl80211_parse_chandef(struct cfg80211_registered_device *rdev, struct nlattr **attrs = info->attrs; u32 control_freq; - if (!attrs[NL80211_ATTR_WIPHY_FREQ]) + if (!attrs[NL80211_ATTR_WIPHY_FREQ]) { + NL_SET_ERR_MSG_ATTR(extack, attrs[NL80211_ATTR_WIPHY_FREQ], + "Frequency is missing"); return -EINVAL; + } control_freq = MHZ_TO_KHZ( nla_get_u32(info->attrs[NL80211_ATTR_WIPHY_FREQ]));