From patchwork Tue Feb 7 19:32:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 652283 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C41C636CC for ; Tue, 7 Feb 2023 19:33:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231622AbjBGTdD (ORCPT ); Tue, 7 Feb 2023 14:33:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbjBGTdC (ORCPT ); Tue, 7 Feb 2023 14:33:02 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 257C83B655 for ; Tue, 7 Feb 2023 11:33:00 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id j29-20020a05600c1c1d00b003dc52fed235so12326145wms.1 for ; Tue, 07 Feb 2023 11:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aDwz8ebyu9Jo7GZkf4h4ogBfSjVLdYt8W82W2oxUCBw=; b=o1nMqJ1JV7BH6nSbGoYhVezSQWYdsIwIHO2oFzyFGogxcJLHmPwe9icRyVU0CPVRdH LdQqsnc/XihYDgSfu5KXBhnFDFmQir7OHeNwLDLeIU+MXVG43QgTJJz79R7ouJVp2EGY xNhhFAW/mVyxPwXlrUopmdxEV+2L1ze0sqg2pLkgT+CEuRRzfTZ34oo7qz4WQF69LkpY AOT/DavIzxwqnyX5RijMWO+3tmStjS/teYbwI4aow06M7dAROfuyl6Dwv5oIuFYM84XV LNhbk2fdCDUAemNW3cKZi8CB5yMAIlLViRFK6RSlCC2WpOE103o9kAMVpKoArOP94U8h gndw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aDwz8ebyu9Jo7GZkf4h4ogBfSjVLdYt8W82W2oxUCBw=; b=yizZzuYf4UuGjLkfatD0cCWZadAonWvpHDhzcpkDaAifU2xAZrjrtM2l6nE/etRYWh iY76xSJz6iyMSS5YW6U1TWDum8h72PgKTPmlWV38GcweVwQcnKqUecRoxP1xo9m39R16 knAU269URc367oNFPZFNTlTZLAkSUpCZVxGXtENWTCBwbqMWivH0iYK/6IC08LiCeCgs DYVHjlPh3QVdY5dcxcgCNw0TgfyrmMt3YkqweB0t+xYujrURyqkcE+N22AvLJ26JGvvj ZpCA74gjd72Ys7PoQc2+/T0YWrA4H5YkOdp/KXnMuu6sB20m/9gh6/D49B+XIDK8CfjT gGeQ== X-Gm-Message-State: AO0yUKW7nd3Txo3e3QSdLSNukkLorEE462FQaEwrbE9lUvxR57ywIPTi BtCrzeKpy9v1vAFWQzLrp/SswA== X-Google-Smtp-Source: AK7set92ZR+qa3SVZ8aNN05BcIhoOfWWX1JrmGGCPTSPHm3q4M3R/VGXCw3bbDGaZvrte7sR/+oijw== X-Received: by 2002:a05:600c:713:b0:3df:e4b4:de69 with SMTP id i19-20020a05600c071300b003dfe4b4de69mr4118923wmn.27.1675798378737; Tue, 07 Feb 2023 11:32:58 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d17-20020adff851000000b002c3dd82a0e9sm9199448wrq.91.2023.02.07.11.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:32:58 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] ARM: dts: exynos: drop simple-bus from FIMC in Exynos4 Date: Tue, 7 Feb 2023 20:32:53 +0100 Message-Id: <20230207193254.550236-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Dropping simple-bus node fixes warnings: exynos4210-smdkv310.dtb: camera: $nodename:0: 'camera' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$' The change is not backwards compatible and expects the FIMC driver to populate its children. Signed-off-by: Krzysztof Kozlowski --- Depends on: https://lore.kernel.org/linux-samsung-soc/20230207192914.549309-1-krzysztof.kozlowski@linaro.org/T/#t --- arch/arm/boot/dts/exynos4.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 8dd6976ab0a7..434025331041 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -201,8 +201,8 @@ dsi_0: dsi@11c80000 { #size-cells = <0>; }; - camera: camera { - compatible = "samsung,fimc", "simple-bus"; + camera: camera@11800000 { + compatible = "samsung,fimc"; status = "disabled"; #address-cells = <1>; #size-cells = <1>; From patchwork Tue Feb 7 19:32:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 651637 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C34DC636D4 for ; Tue, 7 Feb 2023 19:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229726AbjBGTdE (ORCPT ); Tue, 7 Feb 2023 14:33:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231572AbjBGTdD (ORCPT ); Tue, 7 Feb 2023 14:33:03 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C1C23B656 for ; Tue, 7 Feb 2023 11:33:01 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id d14so14632497wrr.9 for ; Tue, 07 Feb 2023 11:33:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fSuoB4IgL+0KHcN4gvN6QaVojWpwSFr2mY0I+k3bLs0=; b=v/JFcetmcjwGGYaS8wQ2wLEvWCsjn37OPr0kKYZWgI1T7qbTU/6sAUJANbV8PYOqSe OLKALAFb+3j7ommNQ3CWd7r+DGgvwVdodH7/q7cUFEzReRVW4WFFOM3kmEEvAJRi0dOm lSPjsnt4jntZqB/mmkYA/kv+JO/EypR7Ipk0vmPVmiagMdbnYp2p1o9mmmuiNU+MVzr3 mUTrHyXmdrJpGW8RypV7ulMhDqDgHbTweQ/1bEJ6OjFk46ATwDAEBQbjCwV8ZZ+s1wge ncwdckumvk3UWIEBMjgeFQnnmjwm8XgRh7cIH23oZ/2WhSmOuupBYEe25S/t6X5gy9z0 LhXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fSuoB4IgL+0KHcN4gvN6QaVojWpwSFr2mY0I+k3bLs0=; b=Csv6uQmN+TTEUinsBJNy/UyNZN0gVGkgGZrQjPqFg3zoyE1/M03OuTga7/l8yOiPU0 d9FnN/tiOlDT1kMfXxOpcgNOyvZLAiW8H2/j1Gw9qx8xuCnhJUyV0dltiguL29GyTNEX 9HqalbbSg0Q42Ltsxe6nQdrSV3+y3YEbyEHEUgPoIYQz8yO+wChHmR0Ap9b+zSlLDjGI xDr6tmMH5mHagd7o3i8OdF1Z0ZafRCkXn6QyUqejh5GfcyBwCYLhxxXAEsETLkF94yZZ RMghmrdHC6S9CoAOmH+JbCaDpUgkNPdbpKWiD5JBuD4W/rEFz6mSo7TiTdnlhabE9ARO LQeA== X-Gm-Message-State: AO0yUKW3hfhi//IcbR2sMvwag3BRy3dUYmgW7/HV/P4L9cH6QKY/6RJT tXzPWxju/HQhMUvviwq4AEI6SA== X-Google-Smtp-Source: AK7set+yCl0xscd6K/QjrdVW4ZAjBoi3nmA2Kcuqn7OIxVOOjmdBYTEimKuJlM6khGQTzXYkJYO+Hw== X-Received: by 2002:adf:9dd2:0:b0:2c3:efb7:e9a2 with SMTP id q18-20020adf9dd2000000b002c3efb7e9a2mr112678wre.16.1675798379782; Tue, 07 Feb 2023 11:32:59 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d17-20020adff851000000b002c3dd82a0e9sm9199448wrq.91.2023.02.07.11.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 11:32:59 -0800 (PST) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] ARM: dts: s5pv210: drop simple-bus from FIMC Date: Tue, 7 Feb 2023 20:32:54 +0100 Message-Id: <20230207193254.550236-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207193254.550236-1-krzysztof.kozlowski@linaro.org> References: <20230207193254.550236-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. The change is not backwards compatible and expects the FIMC driver to populate its children. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s5pv210.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 12e90a1cc6a1..5cf75cccd088 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -547,8 +547,8 @@ i2c1: i2c@fab00000 { status = "disabled"; }; - camera: camera { - compatible = "samsung,fimc", "simple-bus"; + camera: camera@fa600000 { + compatible = "samsung,fimc"; pinctrl-names = "default"; pinctrl-0 = <>; clocks = <&clocks SCLK_CAM0>, <&clocks SCLK_CAM1>;