From patchwork Sat Feb 11 10:53:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pauli Virtanen X-Patchwork-Id: 652771 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4EAC61DA4 for ; Sat, 11 Feb 2023 10:57:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbjBKK5L (ORCPT ); Sat, 11 Feb 2023 05:57:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbjBKK5J (ORCPT ); Sat, 11 Feb 2023 05:57:09 -0500 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6712230D7 for ; Sat, 11 Feb 2023 02:57:08 -0800 (PST) Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EFB03240769 for ; Sat, 11 Feb 2023 11:57:06 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PDSGp2QjJz9rxM; Sat, 11 Feb 2023 11:57:06 +0100 (CET) From: Pauli Virtanen To: linux-bluetooth@vger.kernel.org Cc: Pauli Virtanen Subject: [PATCH BlueZ v2 1/9] doc: remove unimplemented Quality Report from MGMT settings Date: Sat, 11 Feb 2023 10:53:45 +0000 Message-Id: <3df45c4a6737b249b519d4c6128e2eb783198abc.1676112710.git.pav@iki.fi> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org The Set Quality Report command was removed in commit 0454e2d09570 ("mgmt: Add support for Mesh in the kernel"), but the settings bit was not removed. It's also not implemented on kernel side, so remove it now. --- Notes: v2: split to two commits doc/mgmt-api.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index 90d612ed8..0e0b4fdf0 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -332,7 +332,6 @@ Read Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech - 18 Quality Report This command generates a Command Complete event on success or a Command Status event on failure. @@ -2925,7 +2924,6 @@ Read Extended Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech - 18 Quality Report The EIR_Data field contains information about class of device, local name and other values. Not all of them might be present. For From patchwork Sat Feb 11 10:53:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pauli Virtanen X-Patchwork-Id: 652770 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 265BBC64EC4 for ; Sat, 11 Feb 2023 10:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbjBKK5M (ORCPT ); Sat, 11 Feb 2023 05:57:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229897AbjBKK5J (ORCPT ); Sat, 11 Feb 2023 05:57:09 -0500 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0383A83D2 for ; Sat, 11 Feb 2023 02:57:08 -0800 (PST) Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8E46F2404CC for ; Sat, 11 Feb 2023 11:57:07 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PDSGq0SlNz9rxR; Sat, 11 Feb 2023 11:57:07 +0100 (CET) From: Pauli Virtanen To: linux-bluetooth@vger.kernel.org Cc: Pauli Virtanen Subject: [PATCH BlueZ v2 3/9] lib: Add defines for MGMT setting bits for CIS feature support Date: Sat, 11 Feb 2023 10:53:47 +0000 Message-Id: In-Reply-To: <3df45c4a6737b249b519d4c6128e2eb783198abc.1676112710.git.pav@iki.fi> References: <20230127205205.20235-1-pav@iki.fi> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org --- Notes: v2: no changes The kernel mgmt.h doesn't use BIT(n) macro here, so I didn't change that now to keep these defines identical. lib/mgmt.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/mgmt.h b/lib/mgmt.h index 796190cd9..efbdfb4b1 100644 --- a/lib/mgmt.h +++ b/lib/mgmt.h @@ -96,6 +96,8 @@ struct mgmt_rp_read_index_list { #define MGMT_SETTING_STATIC_ADDRESS 0x00008000 #define MGMT_SETTING_PHY_CONFIGURATION 0x00010000 #define MGMT_SETTING_WIDEBAND_SPEECH 0x00020000 +#define MGMT_SETTING_CIS_CENTRAL 0x00040000 +#define MGMT_SETTING_CIS_PERIPHERAL 0x00080000 #define MGMT_OP_READ_INFO 0x0004 struct mgmt_rp_read_info { From patchwork Sat Feb 11 10:53:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pauli Virtanen X-Patchwork-Id: 652769 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB9F1C636D7 for ; Sat, 11 Feb 2023 10:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbjBKK5N (ORCPT ); Sat, 11 Feb 2023 05:57:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbjBKK5K (ORCPT ); Sat, 11 Feb 2023 05:57:10 -0500 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A7AA1C7F9 for ; Sat, 11 Feb 2023 02:57:09 -0800 (PST) Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E106824076D for ; Sat, 11 Feb 2023 11:57:07 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PDSGq322Nz9rxL; Sat, 11 Feb 2023 11:57:07 +0100 (CET) From: Pauli Virtanen To: linux-bluetooth@vger.kernel.org Cc: Pauli Virtanen Subject: [PATCH BlueZ v2 4/9] monitor: add MGMT setting bit names for CIS feature support Date: Sat, 11 Feb 2023 10:53:48 +0000 Message-Id: <4fce505a05e24dfa66e35cbef4371f8166b44853.1676112710.git.pav@iki.fi> In-Reply-To: <3df45c4a6737b249b519d4c6128e2eb783198abc.1676112710.git.pav@iki.fi> References: <20230127205205.20235-1-pav@iki.fi> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Add names for CIS Central/Peripheral MGMT bits: @ MGMT Event: Command Complete (0x0001) plen 283 {0x0002} [hci0] 3.745117 Read Controller Information (0x0004) plen 280 Status: Success (0x00) Address: XX:XX:XX:XX:XX:XX (Intel Corporate) Version: Bluetooth 5.3 (0x0c) Manufacturer: Intel Corp. (2) Supported settings: 0x000ffeff Powered Connectable Fast Connectable Discoverable Bondable Link Security Secure Simple Pairing BR/EDR Low Energy Advertising Secure Connections Debug Keys Privacy Controller Configuration Static Address PHY Configuration Wideband Speech CIS Central CIS Peripheral Current settings: 0x000c0ad1 Powered Bondable Secure Simple Pairing BR/EDR Low Energy Secure Connections CIS Central CIS Peripheral Class: 0x7c0104 Major class: Computer (desktop, notebook, PDA, organizers) Minor class: Desktop workstation Rendering (Printing, Speaker) Capturing (Scanner, Microphone) Object Transfer (v-Inbox, v-Folder) Audio (Speaker, Microphone, Headset) Telephony (Cordless telephony, Modem, Headset) Name: xxx Short name: --- Notes: v2: add example output monitor/packet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/monitor/packet.c b/monitor/packet.c index 44f1941bd..d9e8abf41 100644 --- a/monitor/packet.c +++ b/monitor/packet.c @@ -12649,6 +12649,8 @@ static const struct bitfield_data mgmt_settings_table[] = { { 15, "Static Address" }, { 16, "PHY Configuration" }, { 17, "Wideband Speech" }, + { 18, "CIS Central" }, + { 19, "CIS Peripheral" }, { } };