From patchwork Tue Mar 7 05:34:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Taylor Simpson X-Patchwork-Id: 659725 Delivered-To: patch@linaro.org Received: by 2002:adf:a3c6:0:0:0:0:0 with SMTP id m6csp2213789wrb; Mon, 6 Mar 2023 21:36:03 -0800 (PST) X-Google-Smtp-Source: AK7set9ei8YOd9VtWbqc1yuYesmqWFImSf6NgqcVoH93NzkLJSZqGivCzwLfnMIlGWrrMdFZnJwk X-Received: by 2002:a05:6214:1c4f:b0:56e:bb46:fc72 with SMTP id if15-20020a0562141c4f00b0056ebb46fc72mr24134529qvb.45.1678167363441; Mon, 06 Mar 2023 21:36:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678167363; cv=none; d=google.com; s=arc-20160816; b=fa3qb3Y6zwxFA73kYKak6NjYfUQ0DByPZyxz82hmENXqNZ2UDBPHOYEZMpxVGEwQK8 WL+krkodxd2TYkd6PWbAsHwIVjHcDF1E2eIbaPEjNpXOFROslqA/Raw3DZPjMNp2XoA4 15wQkh579/AIL42fpH1qctYziIDGLIX8HW0psx7A3RaOGWiWh5krFFoSfXpfkBB3x0tp mhBw8JVaDZWrEbqpN6vsYNwupbVeJIWPldwTpBor9x1O8nzwvt86l6E0cMN5T9bAozHk Yo776aXfBIQAQiftVjwbzsdGUElbsvNxS32QrkDOyCgal6a0zscKbN5/xk3l+pX6P33J ceXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fXUO3+z//s0qOrHjzGePRFosSuJNgVAbZL4I/3MD2fc=; b=nEsgh5eIi/w5tkwWuvTVrqGNb1UldvFuEfO12PzKKlDnHKdSRq0oeht9uJdIoYi9l6 2oUW61BRbQZTDzmsbRxhfr/0L7NMyv7QjMAENqdan81pkhrMqPfRmUCIA9wpnJL/2+rp hC3HJTHFzU1ytRkFa3SEroqHrfjX0ewpkcRDJIeawHXjERX52jMOaO1h7QDlnq/QM6i+ e3lqjFMH4PcnJSPWQV7ZHIw03n76CIqdadExcOS0uSV1Pc9lhIhFjCWfw2ILhKZuYdpv cfU3D6Mblrz/Zoy+Du2x+I4Pq6F8sxF6ugssqLMHg9L63wQ4/WHTPGgz9Klt3UDUY14l YD9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=g3S5MdqA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x16-20020ae9e910000000b007065803b294si8344901qkf.527.2023.03.06.21.36.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Mar 2023 21:36:03 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=g3S5MdqA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZPyb-0006mg-HL; Tue, 07 Mar 2023 00:35:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZPyL-0006X7-Vv for qemu-devel@nongnu.org; Tue, 07 Mar 2023 00:34:53 -0500 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZPyJ-0006Yd-2Q for qemu-devel@nongnu.org; Tue, 07 Mar 2023 00:34:48 -0500 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3274KPP7029385; Tue, 7 Mar 2023 05:34:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-type : content-transfer-encoding; s=qcppdkim1; bh=fXUO3+z//s0qOrHjzGePRFosSuJNgVAbZL4I/3MD2fc=; b=g3S5MdqAD6haPyxIfGKGlpjuKvjY1Yij5ltf4RgIoRN9wBRREP1fB+cqMSD9W1F2dNI7 xS2twd38VxUaOF++mOTrgt1+yMSHgpl/RlIZ3hP6VySFab+DNYqWcY0vnLrkA2hdrBMv RnlavAO/B1OWxHmTDluQDD8PO/AAS83/fX6atB+/cdXeMF/TDNRbwEojU0nKI2v+eDLd unGutRva0WPtRSI5IuRdekfifw3SRw12iXSIFcqupr3DDhgtWVTe5d0OJ8JqngsJOeXh Hviwjd1lqetBPueeI9Thl6YWa9cIb2D59bGU3ifJ6C2u7DNoyU9TO8iCJCMpbIIrSkpQ xA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3p5x5c847r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Mar 2023 05:34:44 +0000 Received: from pps.filterd (NALASPPMTA04.qualcomm.com [127.0.0.1]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 3275Yh22004489; Tue, 7 Mar 2023 05:34:43 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NALASPPMTA04.qualcomm.com (PPS) with ESMTPS id 3p4few49ku-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Mar 2023 05:34:43 +0000 Received: from NALASPPMTA04.qualcomm.com (NALASPPMTA04.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3275Yhg6004479; Tue, 7 Mar 2023 05:34:43 GMT Received: from hu-devc-sd-u20-a-1.qualcomm.com (hu-tsimpson-lv.qualcomm.com [10.47.204.221]) by NALASPPMTA04.qualcomm.com (PPS) with ESMTPS id 3275YgIH004474 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Mar 2023 05:34:43 +0000 Received: by hu-devc-sd-u20-a-1.qualcomm.com (Postfix, from userid 47164) id 887F5687; Mon, 6 Mar 2023 21:34:42 -0800 (PST) From: Taylor Simpson To: qemu-devel@nongnu.org Cc: tsimpson@quicinc.com, richard.henderson@linaro.org, philmd@linaro.org, peter.maydell@linaro.org, bcain@quicinc.com, quic_mathbern@quicinc.com, stefanha@redhat.com, ale@rev.ng, anjo@rev.ng Subject: [PULL 02/17] target/hexagon/idef-parser: Elide mov in gen_pred_assign Date: Mon, 6 Mar 2023 21:34:23 -0800 Message-Id: <20230307053438.2416629-3-tsimpson@quicinc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230307053438.2416629-1-tsimpson@quicinc.com> References: <20230307053438.2416629-1-tsimpson@quicinc.com> MIME-Version: 1.0 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: V7BclWyuWEKh9_yryZF1CJ-Yjb_U6LOc X-Proofpoint-GUID: V7BclWyuWEKh9_yryZF1CJ-Yjb_U6LOc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-06_14,2023-03-06_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=351 phishscore=0 suspectscore=0 clxscore=1015 adultscore=0 malwarescore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303070049 Received-SPF: pass client-ip=205.220.180.131; envelope-from=tsimpson@qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson Merge mov with andi. Suggested-by: Taylor Simpson Signed-off-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Taylor Simpson Message-Id: <20230306225724.2105263-1-richard.henderson@linaro.org> --- target/hexagon/idef-parser/parser-helpers.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/idef-parser/parser-helpers.c index e1a55412c8..7b494c2f9e 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1722,9 +1722,7 @@ void gen_pred_assign(Context *c, YYLTYPE *locp, HexValue *left_pred, *left_pred = gen_tmp(c, locp, 32, UNSIGNED); } /* Extract first 8 bits, and store new predicate value */ - OUT(c, locp, "tcg_gen_mov_i32(", left_pred, ", ", &r, ");\n"); - OUT(c, locp, "tcg_gen_andi_i32(", left_pred, ", ", left_pred, - ", 0xff);\n"); + OUT(c, locp, "tcg_gen_andi_i32(", left_pred, ", ", &r, ", 0xff);\n"); if (is_direct) { OUT(c, locp, "gen_log_pred_write(ctx, ", pred_id, ", ", left_pred, ");\n");