From patchwork Mon Mar 20 13:57:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 665267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 575B1C7618A for ; Mon, 20 Mar 2023 13:56:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbjCTN4o (ORCPT ); Mon, 20 Mar 2023 09:56:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231691AbjCTN4Z (ORCPT ); Mon, 20 Mar 2023 09:56:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C053BDF0; Mon, 20 Mar 2023 06:55:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D4CF6B80E97; Mon, 20 Mar 2023 13:55:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 742D3C4339B; Mon, 20 Mar 2023 13:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679320556; bh=C1Qh/WWAaSUHP1prYGquNRNsLHTSbT09WNuA4Tp6dX0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YM8ovJ9BCFM9YRI7fD52jsnPiQWlsiY2ma5zgSTUGycS5JNHIlAhTvKUpkgJPc91q 9TGcf9UIThGTLh3ZsSwT1NNVUkeiRV+YUcxFo2UiRXVcV3XqFrgqs6jhfMLZrZLtHF x4ofq2gl0zt3Tm/2CfpFgE8jzAE92Jv+Ckw046UmlFzZ0pqA0NqrHy86bYHfupKaGU AoI5XbwntL8u94f0Ovk0RYw7mI2RqoNFYBZj0qWQwfo0p1ah2zNZyk83JiGL7AMCXy k36UD+xVTBPypDgKhiKjSQjE4g18qks9wmfpbkeU9fE/ymN3aswZuErLbOcJ3jCiCq BEgaJsMaYzbUg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1peG0j-0000WR-OP; Mon, 20 Mar 2023 14:57:17 +0100 From: Johan Hovold To: Bjorn Andersson , Lee Jones , Srinivas Kandagatla Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 1/3] dt-bindings: nvmem: qcom,spmi-sdam: fix example 'reg' property Date: Mon, 20 Mar 2023 14:57:08 +0100 Message-Id: <20230320135710.1989-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230320135710.1989-1-johan+linaro@kernel.org> References: <20230320135710.1989-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The SPMI PMIC register region width is fixed and should not be encoded in the devicetree. Amend the example with a parent pmic node with the expected '#address-cells' and '#size-cells' and fix up the 'reg' property. Fixes: 9664a6b54c57 ("dt-bindings: nvmem: add binding for QTI SPMI SDAM") Signed-off-by: Johan Hovold --- .../bindings/nvmem/qcom,spmi-sdam.yaml | 31 +++++++++++-------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml b/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml index e08504ef3b6e..4702f10ecca2 100644 --- a/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml +++ b/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml @@ -42,17 +42,22 @@ unevaluatedProperties: false examples: - | - sdam_1: nvram@b000 { - #address-cells = <1>; - #size-cells = <1>; - compatible = "qcom,spmi-sdam"; - reg = <0xb000 0x100>; - ranges = <0 0xb000 0x100>; - - /* Data cells */ - restart_reason: restart@50 { - reg = <0x50 0x1>; - bits = <6 2>; - }; - }; + pmic { + #address-cells = <1>; + #size-cells = <0>; + + sdam_1: nvram@b000 { + compatible = "qcom,spmi-sdam"; + reg = <0xb000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0xb000 0x100>; + + /* Data cells */ + restart_reason: restart@50 { + reg = <0x50 0x1>; + bits = <6 2>; + }; + }; + }; ... From patchwork Mon Mar 20 13:57:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 665268 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6742AC7618D for ; Mon, 20 Mar 2023 13:56:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231538AbjCTN4m (ORCPT ); Mon, 20 Mar 2023 09:56:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231680AbjCTN4Z (ORCPT ); Mon, 20 Mar 2023 09:56:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73CA613501; Mon, 20 Mar 2023 06:55:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1824E6151C; Mon, 20 Mar 2023 13:55:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BD45C433EF; Mon, 20 Mar 2023 13:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679320556; bh=wc3FoLvFgLDkOgN7gxHKEwm4JJ7/VP0SV4GEWDLU+TU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kp1rXR92DwaNGamGVlJ5BA0l4VTVEUJo5h8XtXWuNyt1UjKof2mnkfEFScjfMRHl5 nd9UbqNHsGuJGIBalp3Yr6AGzsdKUnF8VGRjSYA4JDOVdQMuI6sx/6cme6EEbHQf7t qWEK51be3jcK5BMorqyaYtG856SOhkXNz4AZnWHvr8S0dwnQfu6TOp1RL1DM0neXOF RFSDlrjVAzSzYPbXiTykloQkH3auezR6iGrDQ0WRpGe+L+GQMfJ0+NBmsWwWWZAu9l BQHvqnmq5zfW+22mrsG3vHx1Q3ukNqoiRoWeh4Lcqd5GeKf99wT0muiIzvREbcCRMM GdBZyRmlbUfyQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1peG0j-0000WT-R5; Mon, 20 Mar 2023 14:57:17 +0100 From: Johan Hovold To: Bjorn Andersson , Lee Jones , Srinivas Kandagatla Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 2/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property Date: Mon, 20 Mar 2023 14:57:09 +0100 Message-Id: <20230320135710.1989-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230320135710.1989-1-johan+linaro@kernel.org> References: <20230320135710.1989-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The SPMI PMIC register region width is fixed and should not be encoded in the devicetree. Fixes: 42f45cc655d0 ("arm64: dts: qcom: sc8280xp-pmics: add pmk8280 sdam nvram") Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi index 1411edd42b25..c35e7f6bd657 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi @@ -107,7 +107,7 @@ pmk8280_rtc: rtc@6100 { pmk8280_sdam_6: nvram@8500 { compatible = "qcom,spmi-sdam"; - reg = <0x8500 0x100>; + reg = <0x8500>; #address-cells = <1>; #size-cells = <1>; ranges = <0 0x8500 0x100>;