From patchwork Fri Mar 24 07:41:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 666841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D0DC77B60 for ; Fri, 24 Mar 2023 07:41:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231792AbjCXHll (ORCPT ); Fri, 24 Mar 2023 03:41:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230491AbjCXHlj (ORCPT ); Fri, 24 Mar 2023 03:41:39 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9896B2594B for ; Fri, 24 Mar 2023 00:41:37 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id ew6so4352659edb.7 for ; Fri, 24 Mar 2023 00:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1679643696; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e0n73iZ8VJIt54nEx9Q7fNmrfFMw8zxjDedrs3LziIE=; b=ZgoCJhbx7jqrXRcPUZMkEl51Sb5ctO/NU6fKtzeFTfNP1oNNxxD9ihAaBkwLDBxnrP jO4HJBcfgCEjbRTNTNMa8IiAjtqWV6itywJhUg0dksc+NVYbi1M/mwNSAtCl/RQafFfu cMeOj527FqHLT+mt2w1m+kOKsdTD62sAG4yuidM05mE/Z1EdvjDE/zdhY4qtF7hZuFAC OGSLIcRrraavOdOg8I1Oc3ILsDnMHv+agbnXyDRmlAjrho17JK2PRt5ylXhb/jab5ZAH Ef/PdRbCRy7Az12rQb2HNXfhQjPrTBJT69BMq4/v16OUv9U+hyDu90HuHnqHKbC+SoTn QixQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679643696; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e0n73iZ8VJIt54nEx9Q7fNmrfFMw8zxjDedrs3LziIE=; b=GZoyOHsZoH4POzWzo7ZOdjz/AejWjCW1oOCdDSfa6W4HxSxJBX00u5RuIOLCzNsgfh myW0MyiYNTiNUshWJoo+5OlJH9bRwORonoRASp9JxOOuxnICRj0jlJvaXiaA3ojSEgey E6twaiDypev8yYwqujp1QTq/sJgGCjiVw+UxslEllRxGHPFGoLXmRJP4A+mQ+3i2s8E5 nMoQ8MgZxRifiBexjiYIZYuthC5IbbgE2BEZAgw2UZHY8im/v7hT8xn5Wh/o0fBtoa1M XIIjfos+ydKMql1CBl2zZwgBAWGkMtn9AhNCKWxxECbKDYt5nZ7+3+VIkkGbGmR9GbcG JsOQ== X-Gm-Message-State: AAQBX9fS2zVnVE/QphJuwP6dMgy6VkkgZb8U9BqfwneKcFZMiWDX73o2 G8GlOS8padXuu9R1VRIk+F6ytQ== X-Google-Smtp-Source: AKy350abskR8P4cqQaIB6SmOAJ/5w82M5UcNawDqlSgx0L7XYyF4R1ERvpCx/v3JOC3ev2IBCfj27g== X-Received: by 2002:a17:907:1905:b0:8b1:3467:d71b with SMTP id ll5-20020a170907190500b008b13467d71bmr1987216ejc.48.1679643696142; Fri, 24 Mar 2023 00:41:36 -0700 (PDT) Received: from [192.168.0.29] (84-115-214-73.cable.dynamic.surfer.at. [84.115.214.73]) by smtp.gmail.com with ESMTPSA id d23-20020a50f697000000b004fd2a7aa1ecsm10271227edn.32.2023.03.24.00.41.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 00:41:35 -0700 (PDT) From: Luca Weiss Date: Fri, 24 Mar 2023 08:41:29 +0100 Subject: [PATCH v3 2/3] dt-bindings: ufs: qcom: Add reg-names property for ICE MIME-Version: 1.0 Message-Id: <20221209-dt-binding-ufs-v3-2-499dff23a03c@fairphone.com> References: <20221209-dt-binding-ufs-v3-0-499dff23a03c@fairphone.com> In-Reply-To: <20221209-dt-binding-ufs-v3-0-499dff23a03c@fairphone.com> To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Luca Weiss , Krzysztof Kozlowski X-Mailer: b4 0.12.1 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this in the bindings so the existing dts can validate successfully. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss Reviewed-by: Eric Biggers --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 23447281deec..ebc8e1adbc6f 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -75,6 +75,10 @@ properties: minItems: 1 maxItems: 2 + reg-names: + minItems: 1 + maxItems: 2 + required-opps: maxItems: 1 @@ -129,6 +133,8 @@ allOf: reg: minItems: 1 maxItems: 1 + reg-names: + maxItems: 1 - if: properties: @@ -157,6 +163,12 @@ allOf: reg: minItems: 2 maxItems: 2 + reg-names: + items: + - const: std + - const: ice + required: + - reg-names - if: properties: @@ -185,6 +197,8 @@ allOf: reg: minItems: 1 maxItems: 1 + reg-names: + maxItems: 1 - if: properties: @@ -210,6 +224,12 @@ allOf: reg: minItems: 2 maxItems: 2 + reg-names: + items: + - const: std + - const: ice + required: + - reg-names # TODO: define clock bindings for qcom,msm8994-ufshc From patchwork Fri Mar 24 07:41:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 666840 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C65B0C6FD20 for ; Fri, 24 Mar 2023 07:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231874AbjCXHmD (ORCPT ); Fri, 24 Mar 2023 03:42:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231777AbjCXHll (ORCPT ); Fri, 24 Mar 2023 03:41:41 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EF2422790 for ; Fri, 24 Mar 2023 00:41:38 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id eh3so4281022edb.11 for ; Fri, 24 Mar 2023 00:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1679643697; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HcxZofqIK3HRTdfpbgfEH068msVjQMhnD45KuQ5H/ms=; b=UpxLxwfQ3V5dOLpYAxUHsBqOU/qL0dFRrAKzHeFjnL9i1MORE7bFusJ8QZhtRpJZBX jdUFiNSk0OYHx2U8sI7pOR81D3o10pW9LMOIGqlecqAfJtI6N+kf0T59P7jS4AP7WLZp I79gJy9W6BAKRgY1Q34popVJyDtTK/HQMF1cIOGufNPViWrIwy/bAq69zeg/wdh3v3qq JAuMoRraWIQAkmPZCCOlvx7XeUq0/Z8ubjAiNE5CiE3Q3I5WIjPJMpqlwc57X2ts2V3m JP5gfj7eQVHOj9FhFZ2FalYis5PCt5r0HMFnSf7TLUQVdqO5mT/xPqF4ykmEpPz/AtCu Ef8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679643697; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HcxZofqIK3HRTdfpbgfEH068msVjQMhnD45KuQ5H/ms=; b=x2s0wuj5w1akVXohComIGpDZ7CjMrwgGv+wJWSLSxRmeD54gmiLbK6FhcN64A823DV xjp7ffl6ekWnz8Y2CRyQTHX3Or9ctHPzTzl6+c2d3JyYBDfNBzNCYVi69N/4dC0vXRHR OjYbYAweSSIaI8IaT+4wDuoTc3j4tMLaM4bJjVbm6ER9TwTAsB5huDTSvZpMCkv/QOOQ 9ijPPpEH/a4Tr0PxctWpO3/aOALuyPLhIR43nh5u0uepEZv/D1qCWbNbcS4zhgxgDLMb 9S8JdD2kLK/GOWz1mU4qZdJLct+ch5y7SUm4ErJQgm3Jxf+Wr/T9Fpg9D23f0tqX2yer 6k2A== X-Gm-Message-State: AAQBX9fjbeYKxtPs5O9Wyv2qo+A2yC7sAzY6FHCKgYLFuZ0v3L/Dx4HW 9shdPP/bbkvnG6Y1C1c20M01Ig== X-Google-Smtp-Source: AKy350bjHXtnBgON3ZW3HnBdpfI4Z4agAe97ZtevC+h3lL7GTKudFDLdnSm5AHY7pX49rQ77F85nJQ== X-Received: by 2002:a17:906:c11:b0:91f:17a5:b359 with SMTP id s17-20020a1709060c1100b0091f17a5b359mr1648648ejf.66.1679643696996; Fri, 24 Mar 2023 00:41:36 -0700 (PDT) Received: from [192.168.0.29] (84-115-214-73.cable.dynamic.surfer.at. [84.115.214.73]) by smtp.gmail.com with ESMTPSA id d23-20020a50f697000000b004fd2a7aa1ecsm10271227edn.32.2023.03.24.00.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 00:41:36 -0700 (PDT) From: Luca Weiss Date: Fri, 24 Mar 2023 08:41:30 +0100 Subject: [PATCH v3 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings MIME-Version: 1.0 Message-Id: <20221209-dt-binding-ufs-v3-3-499dff23a03c@fairphone.com> References: <20221209-dt-binding-ufs-v3-0-499dff23a03c@fairphone.com> In-Reply-To: <20221209-dt-binding-ufs-v3-0-499dff23a03c@fairphone.com> To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Luca Weiss , Krzysztof Kozlowski X-Mailer: b4 0.12.1 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org SM8450 actually supports ICE (Inline Crypto Engine) so adjust the bindings and the example to match. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss Reviewed-by: Eric Biggers --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index ebc8e1adbc6f..3af786120fa5 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -113,7 +113,6 @@ allOf: - qcom,sc8280xp-ufshc - qcom,sm8250-ufshc - qcom,sm8350-ufshc - - qcom,sm8450-ufshc - qcom,sm8550-ufshc then: properties: @@ -144,6 +143,7 @@ allOf: - qcom,sdm845-ufshc - qcom,sm6350-ufshc - qcom,sm8150-ufshc + - qcom,sm8450-ufshc then: properties: clocks: @@ -250,7 +250,9 @@ examples: ufs@1d84000 { compatible = "qcom,sm8450-ufshc", "qcom,ufshc", "jedec,ufs-2.0"; - reg = <0 0x01d84000 0 0x3000>; + reg = <0 0x01d84000 0 0x3000>, + <0 0x01d88000 0 0x8000>; + reg-names = "std", "ice"; interrupts = ; phys = <&ufs_mem_phy_lanes>; phy-names = "ufsphy"; @@ -278,7 +280,8 @@ examples: "ref_clk", "tx_lane0_sync_clk", "rx_lane0_sync_clk", - "rx_lane1_sync_clk"; + "rx_lane1_sync_clk", + "ice_core_clk"; clocks = <&gcc GCC_UFS_PHY_AXI_CLK>, <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>, <&gcc GCC_UFS_PHY_AHB_CLK>, @@ -286,7 +289,8 @@ examples: <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>, <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>, - <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>; + <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK>, + <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; freq-table-hz = <75000000 300000000>, <0 0>, <0 0>, @@ -294,6 +298,7 @@ examples: <75000000 300000000>, <0 0>, <0 0>, - <0 0>; + <0 0>, + <75000000 300000000>; }; };