From patchwork Wed May 22 01:53:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 164765 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp275757ili; Tue, 21 May 2019 18:53:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqwocTcSjY/baEhE+uzdWO4E+kDIPaQs5GD5RwdHwmPvXy7lMj3Tk9BAdnjPWauOc/M13CTN X-Received: by 2002:a63:5105:: with SMTP id f5mr70364450pgb.373.1558490028397; Tue, 21 May 2019 18:53:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558490028; cv=none; d=google.com; s=arc-20160816; b=Ly7W0m+hroY1jf8pnNvL0ooyg+fRh27KJwMq/7fqvmKQip4hrA1A1bvrHPFCPhfm8C 3ss1P6QQUbdWgD5sT6ULCNFUan4+ClYtZRdcUUxkdLW4S+F36V/PInAOLdYIrzzVUyvK o72nLoNSrEm0CE6/kZEsGeOedo0hzKo+uQ4HFQm24ZZ+cl1e+fnWSguIIEuN7+tv85y5 ESf1GhYMRPKE07I5077mvrBsWMbyhoh18qILyLbrExrVtNwTU4+WcDRwdB6FJ9FtyFrO otjyuXAhDOUZ0ucgCnZA19qz4JzQE8maBtt0FqfGaEbxzApwAuNiM3nTVSybHa8b1rzf omGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=LlxRyT+mbsnTVNTKSITBJmRiSrxfctVw8atQ9aC4s90=; b=D/4KA/xTWOCy8IAFfbgHB0uTuuROfm2YCdRnSNUPMTdKk6u864tVbDdiln5Kgzv7F1 95jhBBLVA3nTP+8EiuK7pXT/SHQmXv5MUKy4MMAgxE+0Y3tdsI7rXEI9/z+O69ozUFxo +QjkP+/jcDliNhsKRBVSFvLrkHRpfVmlgABCrR5Q8apVL9yYYGlEqWBckRGMTlURRni+ 1ogGoEoOIyKVIWJ4XoiQKypPSkas91JFnfKRARxacXY7yvQP/7RKQF5OmakjmqtHUM66 UVsWIEeemmXykdwFbii9BeLGekedzD9loQ95iepHY5M0A5vpnmMVvWgSBgxgt5o92mTI 14Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="LQZb/vjK"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 204si9212571pga.373.2019.05.21.18.53.47; Tue, 21 May 2019 18:53:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="LQZb/vjK"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbfEVBxr (ORCPT + 15 others); Tue, 21 May 2019 21:53:47 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:35044 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbfEVBxr (ORCPT ); Tue, 21 May 2019 21:53:47 -0400 Received: by mail-pf1-f193.google.com with SMTP id t87so433813pfa.2 for ; Tue, 21 May 2019 18:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=LlxRyT+mbsnTVNTKSITBJmRiSrxfctVw8atQ9aC4s90=; b=LQZb/vjKAJSs4KcX5G91N4TfJF4lnwNCerToC7NPX0ZiF1SeZmnFrgslAo/Ehj7Ays vTcCigfoicBqFk3/cFD25tDvPYKCmuopKzOB9wZjNGLQMLqTfqSMXsx5xkIp+TMIwZ9p /aXA51kU0Nw4LB1636JvDgComqQYYS4O/aMmzkr0gDOAEC12uRDf2ha+OI7/Z3OsqBol +FaAMtdRYzoIKo+08tsZE0kpHNdsf/Cu9bAGhJwVHeDBpxKDY4Mz182jLQLSO5yH6hoI EQSNJLOUtcDP930SVt0p2UpKO/ZuX2YeviTNEAGqBjGHhI05Yul6Y345Nfg4CEuAk8gr feiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LlxRyT+mbsnTVNTKSITBJmRiSrxfctVw8atQ9aC4s90=; b=DT8ejWGqXUj3psKe1avr251HAa5OgYLkBeOEoFHSx0uDOBdrjA0K2mxXVmeKlOSvcf 3AqS5n+2NIfQ8gJBxPwm3Km7OWXB8SzbU9jdymqmxYemuWBWdgm8qyOHQrOAOg/9Gx3k LUiHDA8bXmMMwm1iFdIa2On5HjMGsAnxSRUSHc7+nRJ/W1Upm3WA3X1xQUFEqJ9tcTdl nQRiSrfTaCmpxbPIORcY5S8YWUTQeejS4nMi5dHUeJjio/10+7TbAVmdV2lZmtycsgh0 D+T+huCVXdgsfHRj6qcVZQaJ5/EHRTYmfdnGtEw6Hc+a15eIuMn962rNiD5o/NnikiJe nq8Q== X-Gm-Message-State: APjAAAXlY/vvgdCU6Rlk6pDiMy30z4eqPqf5lLfywE4pIQjq4/n+tv+z HnKeznaSTMKLnTgU/aZyOiGxCQ== X-Received: by 2002:a63:700b:: with SMTP id l11mr30923085pgc.449.1558490026123; Tue, 21 May 2019 18:53:46 -0700 (PDT) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id i27sm47073805pfk.162.2019.05.21.18.53.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2019 18:53:45 -0700 (PDT) From: Bjorn Andersson To: Andy Gross , Rob Herring , Mark Rutland Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org Subject: [PATCH] soc: qcom: apr: Don't use reg for domain id Date: Tue, 21 May 2019 18:53:42 -0700 Message-Id: <20190522015342.29501-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The reg property represents the address and size on the bus that a device lives, but for APR the parent is a rpmsg bus, which does not have numerical addresses. Simply defining #address/#size-cells to 1 and 0, respectively, to silence the compiler is not an appropriate solution. Replace the use of "reg" with an APR specific property. Signed-off-by: Bjorn Andersson --- The APR device was recently added to msm8996.dtsi, but this is still depending on working SMMU to provide functional audio support. Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt | 2 +- drivers/soc/qcom/apr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.18.0 Reviewed-by: Srinivas Kandagatla diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt index bcc612cc7423..38d3c06abc41 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt @@ -9,7 +9,7 @@ used for audio/voice services on the QDSP. Value type: Definition: must be "qcom,apr-v", example "qcom,apr-v2" -- reg +- qcom,apr-domain Usage: required Value type: Definition: Destination processor ID. diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c index 74f8b9607daa..b83d71b2e0a4 100644 --- a/drivers/soc/qcom/apr.c +++ b/drivers/soc/qcom/apr.c @@ -276,7 +276,7 @@ static int apr_probe(struct rpmsg_device *rpdev) if (!apr) return -ENOMEM; - ret = of_property_read_u32(dev->of_node, "reg", &apr->dest_domain_id); + ret = of_property_read_u32(dev->of_node, "qcom,apr-domain", &apr->dest_domain_id); if (ret) { dev_err(dev, "APR Domain ID not specified in DT\n"); return ret;