From patchwork Fri Mar 31 09:25:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 668844 Delivered-To: patches@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp381895wrt; Fri, 31 Mar 2023 02:27:02 -0700 (PDT) X-Google-Smtp-Source: AK7set9H2UWrOZmAycaLBwIHdCV77As+Qr3maG2Grpde901NcbotXU0AYlsKsE//Lx51OJkanVZK X-Received: by 2002:ac8:7e8e:0:b0:3d2:5776:4b39 with SMTP id w14-20020ac87e8e000000b003d257764b39mr44941630qtj.37.1680254822710; Fri, 31 Mar 2023 02:27:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254822; cv=none; d=google.com; s=arc-20160816; b=sesh7gyQyoy1A7QJWIhmPmCm5/SXxxPhiI6r1iq7BY33Clw5ZMvis86fS9esmSTYvz JIz/d/JtadW3Cf+7Vz5XoPyuSHLq53nvCxe8Jqhju5Xs0z3tgiQL6SQjUBesnDzkFwxF cMZoN0Hg3dw9srbE46m5el2q/pyMlL9PYIpBNbrfaqit9o+RTE7FWAgON4rXxybxO793 6tJly//053nV2216PHA2K+S6oyKR6ETFhiT8XvnHezRQKMMk/cx3jfAU8Oi6lsNJapGJ nZ6vIagEeL3bQskLgi+oTrXNlLVMeaYosSBqRY1LEuIpu5Jlt1IU9MGpMyCO2flziIrL Ze7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=Dv8PEft0/jS+QnEcrgX18cT50Zzlz0usqv+CV3ID0C0=; b=sPAI35qNROiCuzsP4bMfKlp2vQsTa1cxztA+Iq0wLQi2quMxp7POfGIWl0N7ASVl/Z qfnhzAix43IN66rmTeThA1rPa8rowEN+hnH+jZ94QR+qD5iuvKfqXYHsH/U3iDglhSUW pNKxXMDxaUlm04wRbukyFOqkuPUpVSGvauMd+9LzRI/JCa+dG9mNzv8wT5gDZdQf2KsO 1fOY5MiDXykGmC2Gif68P4z1C0Mo0hMcA2g4i5J1nU8H/MWVzeIcEmZReB15LN4+A510 xXCDmroYkpIHWfijwqz2ufuy9I8YBCQW7nwNeQzS6w7H9MYxPCN6lmC+IrgRdyrUVH4b Tc6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=HMOUvqSF; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id n1-20020ac85a01000000b003e383799ac6si1251954qta.448.2023.03.31.02.27.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 02:27:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=HMOUvqSF; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 5808E3F586 for ; Fri, 31 Mar 2023 09:27:02 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lists.linaro.org (Postfix) with ESMTPS id 9E5E83E975 for ; Fri, 31 Mar 2023 09:26:45 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HMOUvqSF; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 3BAFECE2E19; Fri, 31 Mar 2023 09:26:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78591C4339B; Fri, 31 Mar 2023 09:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254801; bh=qE4hn7zYZUo3qbgZnQ+ZnfMoG9qxdOCoGyG59h+a2iI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HMOUvqSFkkL8phRrpkrGaaVnaZAeEib8Rpcx16VtW/ll+GjB/7y0qvIF/0Fl9Rbf8 cTlRDGAnWRHRBH4CUYdoEl6e7QHLTHKAHO2spvPQiqKCXKy/FF5hvYFH1m8jzKf8sp 12ZEpJgY5wIo5FggwySBJ55M7yENduSFgEnM//E2b1+/A2WXyhUvRIpDt3puvtM5MF MYU77ZRNuRAGcKUBf8P7HIjKZR5e4EaSYlxb1xboeDJUGyrgzKEpeXJSp8XsY5nmoc fGhN8pUw5KbyJtHmSqJSM2lGUnOzh5u+Iug9o3onO+LQVpMxD43AvO2ilS1Yx948ym W7AHFjMZRaODA== From: Lee Jones To: lee@kernel.org Date: Fri, 31 Mar 2023 10:25:58 +0100 Message-Id: <20230331092607.700644-11-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org X-Rspamd-Queue-Id: 9E5E83E975 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.00 / 15.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; RCVD_IN_DNSWL_HI(-1.00)[52.25.139.140:received,145.40.73.55:from]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_SPF_ALLOW(-0.20)[+a:sin.source.kernel.org]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM(-0.00)[-1.000]; ASN(0.00)[asn:54825, ipnet:145.40.73.0/24, country:US]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,linux.intel.com,intel.com,gmail.com,ffwll.ch,linaro.org,amd.com,lists.freedesktop.org,lists.linaro.org]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[15]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Message-ID-Hash: ACEIJQ7BFKCOXQR6DHVIAMHFKX5T3KTS X-Message-ID-Hash: ACEIJQ7BFKCOXQR6DHVIAMHFKX5T3KTS X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Matthew Auld , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 10/19] drm/i915/gem/i915_gem_ttm: Demote half-filled kerneldoc List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hopefully someone knowledgable will follow-up to complete it. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1292: warning: Function parameter or member 'offset' not described in '__i915_gem_ttm_object_init' drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1292: warning: Function parameter or member 'page_size' not described in '__i915_gem_ttm_object_init' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Matthew Auld Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index 341b94672abcb..9227f8146a583 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -1274,7 +1274,7 @@ void i915_ttm_bo_destroy(struct ttm_buffer_object *bo) } } -/** +/* * __i915_gem_ttm_object_init - Initialize a ttm-backed i915 gem object * @mem: The initial memory region for the object. * @obj: The gem object. From patchwork Fri Mar 31 09:25:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 668845 Delivered-To: patches@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp381989wrt; Fri, 31 Mar 2023 02:27:22 -0700 (PDT) X-Google-Smtp-Source: AK7set8wG0SZ8HwvzjlY29x4qNm066KyEMTQNt/MgxNpo1NsQd9hSQ8KDL2qLtEsj8BgaNch3GTz X-Received: by 2002:a05:622a:1ba6:b0:3d7:57b:467c with SMTP id bp38-20020a05622a1ba600b003d7057b467cmr38489613qtb.43.1680254842034; Fri, 31 Mar 2023 02:27:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254842; cv=none; d=google.com; s=arc-20160816; b=wqBT2aaHxJ40ThZhCDC+IBAmU0EMqJIYDyXNtU9AR8UN/oFPdJwjW6LNGQ9SM5HmAN EovH06E/1Vb/IJF1ECg4yrZCxPItTojgukMEtN5QSTmWUtzyK4oNkeAqFXIASq9+I6HG vS9Vcaz9kn85eJhk0JyaaKHAAgzimbPw0TN2kWjsX/kWGb1zhchM+L9xpoD19svmCtnn DI6I012E4wkDGe/m2MCocC5kFHxh7vFWWBUyzv86DHKXvF3QLWyMGIQ5SBAGpKH8cubb pCD6X5VyoVzTy+MQinBWWVkAOJN8onKH0VjCNXRdxpS4baDmxCM55YxRKomWLpJUlsDj kfbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=NQlsrspnnzFWEv0Bv1rHqYNY6B7U9m9wwnJYpUXYclI=; b=bix9A/tM++MtZfq7GsmM4uQcDOeLLkKw7x+I52BzDi5hoPwQNd+rZ54J2fVhHMGD9l CvAJ+So7XWJ1oC6sNROLNkDaHi590deh/VcwpgwUV7Ku/NATLzm/Lt96x0cvrJDAm5tY qiTirrYqgWma7ycz2fht9gEDYNneQIxYqeZxyH5Jva/H9dxz19HyfLw3xaC66X/SkI+u E5CJKYwjBcsVwe2L2YcX9h8aVRPR66DyZZk6hMuGMLOE6hx5s7cSy79QLFR5vj8aHtKb fwiU3+JqTNITZ1ujIL+mQkKkFh/SOrb/2QpZbQbs0QzBPzBmsJTBIUJkhA97sUIvrwG7 zNIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=dzBRFbow; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id b137-20020ae9eb8f000000b00746b18b3f65si1111103qkg.665.2023.03.31.02.27.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 02:27:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=dzBRFbow; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id AD96C3E977 for ; Fri, 31 Mar 2023 09:27:21 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lists.linaro.org (Postfix) with ESMTPS id 03AE23E975 for ; Fri, 31 Mar 2023 09:26:47 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dzBRFbow; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 18DE4B82DAD; Fri, 31 Mar 2023 09:26:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05B61C4339E; Fri, 31 Mar 2023 09:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254804; bh=zuwKMJNqTDoHBJoWH8QH3yXQEHwpZC6+8Slwblrz11M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dzBRFbowGUW/YExXI2jTQQk/JtNvslenNW0Y4g0oY2Dk6yMfna/AhJ0nRE8VSsS+3 PYWM9WyB+QL7TZ/0nfbfiIAHK53Q5l1qd2BolEBM4l6XaL26ixqrOzMRpF1C60ZEC/ umXpAj7gPpWGyMqN/FdC907acxLU3FNGj5QRZySmOGhvw0WUGaQW5sooG6ClxbOsMQ P4lIpdMnyh1AKrCvBhDFrd5vMqY7Z/1NV2GNnAhBYfZlpGGDQMcbiYPGnLOU0OuYmc YMFmUiDYTg8RvB8RkPeGnOoVxFTY8fkrLil7jOF093eJ5BTgmLjYn+P9+CSTeeUulc mKn+attwDlEdA== From: Lee Jones To: lee@kernel.org Date: Fri, 31 Mar 2023 10:25:59 +0100 Message-Id: <20230331092607.700644-12-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org X-Rspamd-Queue-Id: 03AE23E975 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.00 / 15.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; RCVD_IN_DNSWL_HI(-1.00)[52.25.139.140:received,145.40.68.75:from]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_SPF_ALLOW(-0.20)[+a:ams.source.kernel.org:c]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM(-0.00)[-1.000]; ASN(0.00)[asn:54825, ipnet:145.40.68.0/24, country:US]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,linux.intel.com,intel.com,gmail.com,ffwll.ch,linaro.org,amd.com,lists.freedesktop.org,lists.linaro.org]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Message-ID-Hash: YCMY6ZAP4TMBBYM4O55BRXCUXHTEASWX X-Message-ID-Hash: YCMY6ZAP4TMBBYM4O55BRXCUXHTEASWX X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 11/19] drm/i915/gem/i915_gem_ttm_move: Provide a couple of missing descriptions for 'num_pages' and 'ctx' List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:272: warning: Function parameter or member 'num_pages' not described in 'i915_ttm_memcpy_arg' drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:569: warning: Function parameter or member 'ctx' not described in 'i915_ttm_move' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c index d030182ca1764..dd188dfcc423e 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c @@ -253,6 +253,7 @@ static struct dma_fence *i915_ttm_accel_move(struct ttm_buffer_object *bo, * @_src_iter: Storage space for the source kmap iterator. * @dst_iter: Pointer to the destination kmap iterator. * @src_iter: Pointer to the source kmap iterator. + * @num_pages: Number of pages * @clear: Whether to clear instead of copy. * @src_rsgt: Refcounted scatter-gather list of source memory. * @dst_rsgt: Refcounted scatter-gather list of destination memory. @@ -557,6 +558,8 @@ __i915_ttm_move(struct ttm_buffer_object *bo, * i915_ttm_move - The TTM move callback used by i915. * @bo: The buffer object. * @evict: Whether this is an eviction. + * @ctx: Pointer to a struct ttm_operation_ctx indicating how the waits should be + * performed if waiting * @dst_mem: The destination ttm resource. * @hop: If we need multihop, what temporary memory type to move to. * From patchwork Fri Mar 31 09:26:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 668846 Delivered-To: patches@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp382103wrt; Fri, 31 Mar 2023 02:27:41 -0700 (PDT) X-Google-Smtp-Source: AKy350ZALT312EHDTcSm+bjc61hDUbyFcA/FxCzzb3f6uAnQWxZQAw/Inh76JIQPvOvcQgnJuK+f X-Received: by 2002:a05:622a:1a98:b0:3dc:a4e5:aef0 with SMTP id s24-20020a05622a1a9800b003dca4e5aef0mr41591726qtc.9.1680254861372; Fri, 31 Mar 2023 02:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254861; cv=none; d=google.com; s=arc-20160816; b=WCO6pAzE5KrFBwrOGzSY4EqbkaS4hPqT0myqOa47GJj+AqE3ZWRzs4FBjGpbQyoZeO OvYtz4BCHY+Buf/xWPM9r5gsX5zuwtfmk62kaCkLzoOANuOMqy7S+Gcd8uDYBJpca5Di RLDY/hlk28ZNGvp8kablRl7WtMeYP9kwF7AuuR3cSbMRCVczoAkUcy2lynmJQcZtmbKx V0EtDWKSigaAA70nk2Jcr5+i8HxPecui0Bvm+MZzChbN7kZjraDOd4fKmsgSIKnhwD6j ANHveAOPegk8q7xhdaJtU4Bbgt1ayhNruqXs0a8VF2HSaW15ZALvLQgIWfj4N4IjaAVY Tcrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=jiGQ2SCYHjCdS722XxoHwW4QR1Em/GpyLNBYC52oQrw=; b=MJ+aO+lrLgBawb9upXO/gaj+PSZyQ5Ep8Cpqqam8XsMj1n7UJVm7kh3E/wjYfjmLkM YZtR/h9dzoT6NsBUK4AlY+HlARSmwVyPzL+/ahw7mxnFL1kCNWJvba8rqda+O00TTfK3 0Kp8xXhv4ZOeS8HW+0tFqpnNaCXgbFgNTH2jbB6RpJA1cmQo/0oJfP297xyO4uiTS7L8 /uH33+/Qr5HYJnncqbOm3Xg9/RYtm0SwesY4DiuEYQezuNbUhmEOoLK8NoqDja2oN2ZH UCWZp7LFN7x5QcqvHx63SmWpxEOwvdjEh1YVliAp+X1lJ6pNnK9gKG0eSl8HGQ/E/0R6 iDRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=vDS8Yn2p; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id a5-20020a05622a02c500b003b86abe419bsi1157537qtx.307.2023.03.31.02.27.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 02:27:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=vDS8Yn2p; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 0F5983E977 for ; Fri, 31 Mar 2023 09:27:41 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lists.linaro.org (Postfix) with ESMTPS id 6B2CE3F58A for ; Fri, 31 Mar 2023 09:26:50 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vDS8Yn2p; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 94AF4B82DAD; Fri, 31 Mar 2023 09:26:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56981C433D2; Fri, 31 Mar 2023 09:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254808; bh=r5fKy7MNhH7WvIHl7tsH50Rr1NXN1GtPNTehilUeT48=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vDS8Yn2pSVeuQBmaB8f1DwbAVhzhZF9HxT+M3EzlgbyrEoPsPn4xDEpKOO/s9FYu8 b7QndHG5T6MTXL2VI1lL2uvOUiQfx7Vpt/hvVpfXK3XoKnJT2O+kfYj/pbeq/WO2+q ozxEsrOgsxmdxXZjEatn5QXbtkAh9aQxCnZ2PmsbYo8x7Eij9i1brW5omIQZlU+2nC 26lu12CzGPnEY7zfz9xs20xUDXYAhEsOhT66IsbYnsciyZyS57vwOnp37JfreRCNwV /vOoCDLTCO3S8mWs47FhhrH9WbfnzV9Lr/PCvLAiSMk0yxdgltPtn1RNov73Hsv2Rr zl4p1and8/Jjg== From: Lee Jones To: lee@kernel.org Date: Fri, 31 Mar 2023 10:26:00 +0100 Message-Id: <20230331092607.700644-13-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org X-Spam-Level: *** X-Rspamd-Queue-Id: 6B2CE3F58A X-Spamd-Result: default: False [3.30 / 15.00]; URIBL_BLACK(7.50)[chris-wilson.co.uk:email]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; RCVD_IN_DNSWL_HI(-1.00)[145.40.68.75:from,52.25.139.140:received]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM(-0.00)[-1.000]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,linux.intel.com,intel.com,gmail.com,ffwll.ch,linaro.org,amd.com,chris-wilson.co.uk,lists.freedesktop.org,lists.linaro.org]; ASN(0.00)[asn:54825, ipnet:145.40.68.0/24, country:US]; RCPT_COUNT_TWELVE(0.00)[15]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DMARC_POLICY_ALLOW(0.00)[kernel.org,none]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; R_SPF_ALLOW(0.00)[+a:ams.source.kernel.org:c]; RCVD_COUNT_TWO(0.00)[2] X-Spamd-Bar: +++ Message-ID-Hash: 43HN5QPUX7XUBHP37NK2UBEYYQ2QSFRM X-Message-ID-Hash: 43HN5QPUX7XUBHP37NK2UBEYYQ2QSFRM X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Chris Wilson , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 12/19] drm/i915/gem/i915_gem_wait: Provide function name to validate the kerneldoc header List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Spam: Yes Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_wait.c:164: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Chris Wilson Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index e6e01c2a74a65..4a33ad2d122bd 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c @@ -161,7 +161,7 @@ i915_gem_object_wait_priority(struct drm_i915_gem_object *obj, } /** - * Waits for rendering to the object to be completed + * i915_gem_object_wait - Waits for rendering to the object to be completed * @obj: i915 gem object * @flags: how to wait (under a lock, for all rendering or just for writes etc) * @timeout: how long to wait From patchwork Fri Mar 31 09:26:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 668847 Delivered-To: patches@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp382212wrt; Fri, 31 Mar 2023 02:28:00 -0700 (PDT) X-Google-Smtp-Source: AKy350Z6Gac8YxrdxU4DEGR9q583KM1qUcDTtMnrmER/4tW1CAOzpp5YO89h89iDkFCuUhXfnZeN X-Received: by 2002:a05:6214:19cd:b0:5cd:1adc:30e2 with SMTP id j13-20020a05621419cd00b005cd1adc30e2mr44318340qvc.11.1680254880406; Fri, 31 Mar 2023 02:28:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254880; cv=none; d=google.com; s=arc-20160816; b=rypvnl0pagk9IQUJDaXp1PG2rnRXITR9kVdE0bV3/Eb/khqCbBmrbP0kloFIdDcrnL 9l6T+WEL/6KPVJc2f0P6MDLw/rHQLKMrskwIiaxRuN9/Vyf6cO0guYTYFlKE8WZ124i2 JGIGJv4KeAEMxAuwwFKVnV77/vDeApCTn3MHF9ydl5ONED9GC7MR9GoOGwa/T8dIMPVx P79ux0zTdqvUZMTKa3PceOt0dIgDn//ZV13MuCViJqqXXzSpHq8vqWDXrhJVHpGrEdXr c3vvdgufbhwcArH43B+eNXRKNisdH6kLIVcQHS/XV1dZcDaL7dhL9uWKrlJ5d+QuvtCQ WnIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=BR3Nnjo6Hjel6eh7o47FCwbEBL87PXHZxM17z1b+wyE=; b=YRve5NLi+csB3ktf1u+KZHkCU4ZB3ZV1LShykv+TujCfyBTtaDX4Br4YGTSHkwQMO4 mJjPz/28GT/1bLLM/AdgNHOHzvKXomA4U5Una9LniERVjhXYr71hR5roaGo1djSVAFQS QAzSQ9Ff0f2RjZ3Aut5WJ4ixOLrf7LoqDpzGbiLJrudC00T4ZQmgutGzyF9OXS3MTqJf qGUeIpV7pHu8YScbLJVuH3cNeTAggS2rmRhQCM4Mf8KbH68ensBI97+QZvHE2xj8Xq73 RjtHLmI3v7IPZGCkpIsGntJ7FQeXfsKB296yUxi+Ta7KH008P1lIGj/S/AdxDjJvVU/a ZaRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=SkUG3+i1; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id iv12-20020ad45cec000000b005b0b569efa0si1140652qvb.111.2023.03.31.02.28.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 02:28:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=SkUG3+i1; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 0DF463F580 for ; Fri, 31 Mar 2023 09:28:00 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lists.linaro.org (Postfix) with ESMTPS id C0E993F596 for ; Fri, 31 Mar 2023 09:26:52 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SkUG3+i1; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4246662660; Fri, 31 Mar 2023 09:26:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3188C433EF; Fri, 31 Mar 2023 09:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254812; bh=Br+vno0fyLfK0vDswtuXDu7r0uipb+c1SKUt2eq3Kbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SkUG3+i1jOY+ZEq6u8LzdDURgEfUOlF4Z7UiHPMkVapNIeNGaMOyzsrIzdkCEmx0W 3nA24C0K7BqYIC9ZqtAHfsTRVFi3iTF0HKxSJOEMgVmy7ca6Tiax8sX13sQoOqwyy2 I1zhwSuIKil8isuOeF4SrJDxDZvyXBVUfXSvamyNZyyO1UhbcKgCJlhnvivt1buAKL /zTPC6+rLWaRpQWPLTtxTW+fYTH6o1x4fbuWuE77rKyweF1tf3fx000sHfczmMBI3s KZNAiwpypQvIa5QkLy+df8VMnGfvHHiA1yd96VZwgVvQPTJ0CEVoYgiZKY+KTK4orD xXg0CZqn+Ko/w== From: Lee Jones To: lee@kernel.org Date: Fri, 31 Mar 2023 10:26:01 +0100 Message-Id: <20230331092607.700644-14-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org X-Rspamd-Queue-Id: C0E993F596 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.00 / 15.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; RCVD_IN_DNSWL_HI(-1.00)[52.25.139.140:received,139.178.84.217:from]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_SPF_ALLOW(-0.20)[+a:dfw.source.kernel.org:c]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM(-0.00)[-1.000]; ASN(0.00)[asn:54825, ipnet:139.178.80.0/21, country:US]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,linux.intel.com,intel.com,gmail.com,ffwll.ch,linaro.org,amd.com,lists.freedesktop.org,lists.linaro.org]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[16]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Message-ID-Hash: E252XJ5YJ6XUXWO3OCDRPVG7V6GYS256 X-Message-ID-Hash: E252XJ5YJ6XUXWO3OCDRPVG7V6GYS256 X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , Matthew Auld , Nirmoy Das , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 13/19] drm/i915/gem/i915_gem_object: Demote non-kerneldoc header with no param descriptions List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_object.c:887: warning: Function parameter or member 'obj' not described in 'i915_gem_object_has_unknown_state' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Matthew Auld Cc: Nirmoy Das Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c index e6d4efde4fc51..4666bb82f312c 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c @@ -875,7 +875,7 @@ int i915_gem_object_wait_moving_fence(struct drm_i915_gem_object *obj, return ret < 0 ? ret : 0; } -/** +/* * i915_gem_object_has_unknown_state - Return true if the object backing pages are * in an unknown_state. This means that userspace must NEVER be allowed to touch * the pages, with either the GPU or CPU. From patchwork Fri Mar 31 09:26:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 668848 Delivered-To: patches@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp382338wrt; Fri, 31 Mar 2023 02:28:19 -0700 (PDT) X-Google-Smtp-Source: AK7set8u5PmJXUL+oSZbcnuO8lpggQctHa84AQluNcpp0lFaFvOgE6xrTVleXi3S9584cZYWv1lm X-Received: by 2002:a05:622a:19a6:b0:3d6:43fc:2a52 with SMTP id u38-20020a05622a19a600b003d643fc2a52mr44828277qtc.42.1680254899713; Fri, 31 Mar 2023 02:28:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254899; cv=none; d=google.com; s=arc-20160816; b=w4yJXG+DmvS/1vRPaGEsmGrJiHyxP2z+GSeRO8Oe7gyS7t4w2aQQfFRDj50fCVMs0s negloA/9kYXp2qSOWMFKWEbv9hfnGy+ja9DLnE3beP0zMjv4ZnUp4OjiuHbeXjY6A5Fz IusTs6lLZZvODVq3ZDZHnynHT5XLIOro8et8kEv0Hss+4sQhs4E0oZRBQ9773xBlMp2/ ohgPy4TKUctmG5oKywSPkNOZpjwue8HBsLQl6Camc12v12jdMWLpfS8CsBdwyq13IaIh 6sVYLh0rj6+zzGg4GH1+RL39i5DSN7xax9FMS3hfSYCqBGr3B18MLV28YevEJ1Cn7vWc NBrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=+QZ8e3YbwL0OTRjQMclqGuf15AhcDneDsLlI5KXcvH8=; b=yDcjDOTVDyB6ItTJ2Kp3SclTpdxfl4whhTn1jlksek6W4ph+MIrcnu4eAAUl4CaMAM wIgmQa573FQSJlPOi82vsx1M/V3Wasc+g87oAefXgtItQtx2i+pZM18HJJ+IYOspehbA caiNDNLrODJPsKWNpI0ej1x2zZikjIp2X2ByrMiRla1YlhO5mQhV0YwhudT70LKsnUOm V29uyxXJl5aYFR7TDPX99ZmRo2H4Vwh/w4konce+3E4kvc/1pM4MKbwPd8CfoYgFGLbS 3G9nTScHwpA2WnOZaN7D3o8oPADDS38F6MDn1eq/vPd5wV5zCbXWs8s4UgM7hl7/uFZ3 ddow== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=GXZqS0n3; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id r11-20020ac85c8b000000b003e4e6681278si1247764qta.18.2023.03.31.02.28.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 02:28:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=GXZqS0n3; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 5929C3F581 for ; Fri, 31 Mar 2023 09:28:19 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lists.linaro.org (Postfix) with ESMTPS id 33B7D3F598 for ; Fri, 31 Mar 2023 09:27:03 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GXZqS0n3; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5C6A5B82DAE; Fri, 31 Mar 2023 09:27:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49991C433D2; Fri, 31 Mar 2023 09:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254821; bh=jDg9+LbHBtf4EjDGettNNrjuuWGpis85RdG5aiSWD5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GXZqS0n3DzEGbnhm/VuFgz81qhHhbB8LYxa+QNGAK8aCAKZfMDsCONopQkz8C59WJ g+wiN/k7a9am8lJiu10gLlcLLq0pkMCDKLjQUF9kQV0/UzS6ZgKXtvMjql8GREQSDj JLo/9iiWbrsgQvqctkGbq4tBXdPctKCLSWoKS7w3/uO3PUHxqYSQvycxPNZIa4dQhe ETiYPunbpUdXC1m0XmEaMVB4f1zGu8ws65dTCpINbY9ntnfw+Kmw5iIWHAZGE0U+Rh /HgCOd+PyR8UBGJPb2K5PUtZV95W4tDsGUbWREGq14UCvHYGepF2JwZpMrlSLkVwu6 P1tN1uJeoFwmA== From: Lee Jones To: lee@kernel.org Date: Fri, 31 Mar 2023 10:26:04 +0100 Message-Id: <20230331092607.700644-17-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org X-Rspamd-Queue-Id: 33B7D3F598 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.00 / 15.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; RCVD_IN_DNSWL_HI(-1.00)[52.25.139.140:received,145.40.68.75:from]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_SPF_ALLOW(-0.20)[+a:ams.source.kernel.org:c]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM(-0.00)[-1.000]; ASN(0.00)[asn:54825, ipnet:145.40.68.0/24, country:US]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,linux.intel.com,intel.com,gmail.com,ffwll.ch,linaro.org,amd.com,lists.freedesktop.org,lists.linaro.org]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[14]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Message-ID-Hash: AI5KFHJGUNIZOV3CLK2GOPVBBIPZ23E2 X-Message-ID-Hash: AI5KFHJGUNIZOV3CLK2GOPVBBIPZ23E2 X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Daniel Vetter , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 16/19] drm/i915/i915_vma: Provide one missing param and demote another non-kerneldoc header List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_vma.c:756: warning: Function parameter or member 'ww' not described in 'i915_vma_insert' drivers/gpu/drm/i915/i915_vma.c:1744: warning: Function parameter or member 'vma' not described in 'i915_vma_destroy_locked' Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/i915/i915_vma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index f51fd9fd4c89c..20a44788999e5 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -739,6 +739,7 @@ bool i915_gem_valid_gtt_space(struct i915_vma *vma, unsigned long color) /** * i915_vma_insert - finds a slot for the vma in its address space * @vma: the vma + * @ww: An optional struct i915_gem_ww_ctx * @size: requested size in bytes (can be larger than the VMA) * @alignment: required alignment * @flags: mask of PIN_* flags to use @@ -1714,7 +1715,7 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt, i915_vma_free(vma); } -/** +/* * i915_vma_destroy_locked - Remove all weak reference to the vma and put * the initial reference. * From patchwork Fri Mar 31 09:26:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 668849 Delivered-To: patches@linaro.org Received: by 2002:a5d:4d08:0:0:0:0:0 with SMTP id z8csp382451wrt; Fri, 31 Mar 2023 02:28:42 -0700 (PDT) X-Google-Smtp-Source: AK7set9fPQmAV3S/u873ORhfSSiXme17LbTjoGAHXLOidHbYoL5EKDvlWNhJzFAbzmZFgDEpWT7A X-Received: by 2002:ac8:5c84:0:b0:3e3:8be5:c3d4 with SMTP id r4-20020ac85c84000000b003e38be5c3d4mr45991987qta.37.1680254922362; Fri, 31 Mar 2023 02:28:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680254922; cv=none; d=google.com; s=arc-20160816; b=IszBWkmnom3nRhWcnuNQ7/pWFHBkio7CZIp3pLm+qA3UjcGI3iR2PH3VZdb0Jh6aSB 33IGxIuDonau+1eTvTU8jO7M6RZK//O3tQvxCN4itpX0wdicDpIxnr9PeW7+3zdj2Ca7 PFWuH34Xgvy2V6j86+llY8dSM+LCN3LNjcVXoB8NlcYh9U3k89aLnSGWxSakYMXt9cLh Pw7R+T5m6fszT4pw5uTKEtlSIBYWd4bbu1FmyZaAKyVnwNloSREjQQ0XVZ+/gfQJfddf 4GXo5EVeW7+2n0rdOa5zwh4f/JDVQUZHjxFHWzi5NLP+fxnziJKI4Y3t2/nTPzefRfBg oCFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:list-unsubscribe:list-subscribe:list-post :list-owner:list-help:list-archive:archived-at:list-id:subject :precedence:cc:message-id-hash:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=wGuagbNoXXTTDj7PEtxkNyXXKH047vjbB6R5v7/yZ/o=; b=ufjFTu7CtszG3ZrnLvX+XJuXANGNkzpGn0WyIx1QRa3xS6XFH4xa0A2k5xOxDBP0Za LD5lo1XsaNkgyUdTJ05rCVt3EKbHqVXKw+GGNPXUv0y4GEvD8NfcyGBw+sUtIr3XsltO cZYZtQJhUjIMgUlZlfzA8rURGStfEk3lxnVgAhREjMZirN0WxSoF42Zn+WGXLxZdPT7X YCjI3ZaqHM5fSPNsCfkXC7K8oNu89iyWqw6Ro57Lz90hGPJknH0LCumRHYRFzy65taYQ nK/2zq7ksxCugqJO9pnmqpyKNXXkamLAhn/SiZA7oLS+s2g6KU5WDnDNmr5udclSxPZ3 2Slg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=dsTJ8rRV; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [3.208.193.21]) by mx.google.com with ESMTPS id i10-20020ac85c0a000000b003e4e21adee2si1186270qti.96.2023.03.31.02.28.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 02:28:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) client-ip=3.208.193.21; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=dsTJ8rRV; spf=pass (google.com: domain of linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org designates 3.208.193.21 as permitted sender) smtp.mailfrom="linaro-mm-sig-bounces+patches=linaro.org@lists.linaro.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from lists.linaro.org (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 0C5363E966 for ; Fri, 31 Mar 2023 09:28:42 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lists.linaro.org (Postfix) with ESMTPS id 10CCC3F598 for ; Fri, 31 Mar 2023 09:27:08 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dsTJ8rRV; spf=pass (lists.linaro.org: domain of lee@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=lee@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE4616265A; Fri, 31 Mar 2023 09:27:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68DD6C433D2; Fri, 31 Mar 2023 09:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680254827; bh=h8C/nCvQ95GrVt3vhY71TCmgTeCG4/uxqnWpxM7dCvc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dsTJ8rRVglkyMZumINEy8WnEYodYuNEhZ7bk1k65j6hRSt6A+H6HSIvwtd10Q7Pew mDw2gtHjx/Wcbcjzbkz+E4al5QovbvJmBTGuowMkfOeT3uswymaaryDuad3rt3skik 5V5Bbv3qYCq7vivephtUFBGWG86wnCgaWebo/0f/p2rqGeM9esEDofWzKN7G+RpviI uGVW/qs5y+ADztJb7OtXuw83KGVnks7D3LZENOEVzA8BLUVYaq3VNB0jjOaOb5xHKz KUcG4WeYIOei20QDLzRmfFPg48kD4AHMaklv91+4SWntbuAwafm2Tk9Hkn2rRjV4B2 yMfi7F7+H4KBw== From: Lee Jones To: lee@kernel.org Date: Fri, 31 Mar 2023 10:26:06 +0100 Message-Id: <20230331092607.700644-19-lee@kernel.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331092607.700644-1-lee@kernel.org> References: <20230331092607.700644-1-lee@kernel.org> MIME-Version: 1.0 X-Rspamd-Action: no action X-Rspamd-Server: lists.linaro.org X-Rspamd-Queue-Id: 10CCC3F598 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.00 / 15.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; RCVD_DKIM_ARC_DNSWL_HI(-1.00)[]; RCVD_IN_DNSWL_HI(-1.00)[139.178.84.217:from,52.25.139.140:received]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,none]; R_SPF_ALLOW(-0.20)[+a:dfw.source.kernel.org:c]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20201202]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM(-0.00)[-1.000]; ASN(0.00)[asn:54825, ipnet:139.178.80.0/21, country:US]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_CC(0.00)[vger.kernel.org,amd.com,gmail.com,ffwll.ch,linaro.org,lists.freedesktop.org,lists.linaro.org]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[13]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Message-ID-Hash: CSMEDKUJAPRLJ27RNK3WSN4V3LBJUJGC X-Message-ID-Hash: CSMEDKUJAPRLJ27RNK3WSN4V3LBJUJGC X-MailFrom: lee@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-kernel@vger.kernel.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Daniel Vetter , Sumit Semwal , Stanley Yang , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org X-Mailman-Version: 3.3.5 Precedence: list Subject: [Linaro-mm-sig] [PATCH 18/19] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers List-Id: "Unified memory management interest group." Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush' Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Stanley Yang Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c index 40e6b22daa226..efea4ef30a787 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c @@ -233,7 +233,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) amdgpu_ring_write(ring, ring->funcs->nop); } -/** +/* * sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine * * @ring: amdgpu ring pointer @@ -933,7 +933,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring) return r; } -/** +/* * sdma_v6_0_ring_test_ib - test an IB on the DMA engine * * @ring: amdgpu_ring structure holding ring information @@ -1114,7 +1114,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib, ib->ptr[ib->length_dw++] = count - 1; /* number of entries */ } -/** +/* * sdma_v6_0_ring_pad_ib - pad the IB * @ib: indirect buffer to fill with padding * @@ -1162,7 +1162,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring) SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */ } -/** +/* * sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA * * @ring: amdgpu_ring pointer